| @iwienand:matrix.org | have we seen any recent ansible-lint failures a-la https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_a9f/881890/1/gate/openstack-zuul-jobs-linters/a9f991b/job-output.txt | 01:43 |
|---|---|---|
| @iwienand:matrix.org | o-z-j has pretty locked down dependencies and it doesn't look like ansible-lint or ansible has changed since last good run | 01:44 |
| @iwienand:matrix.org | it's ansible-compat for reference if anything else starts hitting it -- https://github.com/ansible/ansible-compat/issues/258 | 02:50 |
| @iwienand:matrix.org | i suspect zuul-jobs will but haven't looked | 02:51 |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/nodepool] 881941: Prevent Nodepool from crash-looping on busy system https://review.opendev.org/c/zuul/nodepool/+/881941 | 06:43 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/nodepool] 881941: Prevent Nodepool from crash-looping on busy system https://review.opendev.org/c/zuul/nodepool/+/881941 | 06:49 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 881947: Correctly complete build on transient errors https://review.opendev.org/c/zuul/zuul/+/881947 | 08:55 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 881964: Fix bug around Github token expiration https://review.opendev.org/c/zuul/zuul/+/881964 | 12:47 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 881964: Fix bug around Github token expiration https://review.opendev.org/c/zuul/zuul/+/881964 | 13:52 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 882101: Fix connection handling in recursive tree cache https://review.opendev.org/c/zuul/nodepool/+/882101 | 21:47 | |
| @jim:acmegating.com | zuul-maint: ^ we should probably consider that somewhat high priority; it corrects a bug that can leave nodepool effectively unresponsive | 21:54 |
| @clarkb:matrix.org | looking | 21:58 |
| @clarkb:matrix.org | corvus: do we need to check if connection state is suspended and set _ready to false there? | 22:01 |
| @clarkb:matrix.org | I'm a little confused by what the second portion of the commit message is trying to convey against the change made | 22:01 |
| @jim:acmegating.com | Clark: oh... not exactly, but we should move it... lemme make the change then see if you still have questions | 22:02 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 882101: Fix connection handling in recursive tree cache https://review.opendev.org/c/zuul/nodepool/+/882101 | 22:03 | |
| @jim:acmegating.com | Clark: okay, does that make more sense? | 22:03 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 882101: Fix connection handling in recursive tree cache https://review.opendev.org/c/zuul/nodepool/+/882101 | 22:05 | |
| @jim:acmegating.com | Clark: actually... how about that? :) | 22:05 |
| @clarkb:matrix.org | I see. We get the newly connected event and then process from there. We can largely ignore suspended as a result? | 22:05 |
| @clarkb:matrix.org | since the state transition is connected -> do lots of work -> suspended -> connected | 22:06 |
| @jim:acmegating.com | yep. and if suspended takes too long, it -> lost. so in that case, it's reasonable to unset the _ready flag before the reconnection happens. | 22:07 |
| @jim:acmegating.com | i suppose we might want to be even more conservative and unset the ready flag as soon as we are suspended. it's a bit hard to say though since we're not actually using that right now. it seems like it might be okay for a cache to have a grace period though where we still consider it "ready" for a short time after disconnection. | 22:09 |
| @clarkb:matrix.org | swest: please check my comment on https://review.opendev.org/c/zuul/zuul/+/881964 | 22:16 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 882104: Add ZK 3.6.0 release note https://review.opendev.org/c/zuul/nodepool/+/882104 | 22:25 | |
| @jim:acmegating.com | that's probably a good thing to merge before the next release. considering how old that is, i'm not sure if that warrants a major version bump (9.x) or just a minor one (8.x) | 22:26 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/nodepool] 882101: Fix connection handling in recursive tree cache https://review.opendev.org/c/zuul/nodepool/+/882101 | 23:19 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/nodepool] 878802: Report leaked resource metrics in statemachine driver https://review.opendev.org/c/zuul/nodepool/+/878802 | 23:29 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!