-@gerrit:opendev.org- daniel.pawlik https://matrix.to/#/@dpawlik:matrix.org proposed: [zuul/zuul-jobs] 876081: Provide deploy-microshift role https://review.opendev.org/c/zuul/zuul-jobs/+/876081 | 07:44 | |
-@gerrit:opendev.org- daniel.pawlik https://matrix.to/#/@dpawlik:matrix.org proposed: [zuul/zuul-jobs] 876081: Provide deploy-microshift role https://review.opendev.org/c/zuul/zuul-jobs/+/876081 | 07:46 | |
-@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 876255: Truncate Github file annotation message to 64 KB https://review.opendev.org/c/zuul/zuul/+/876255 | 07:51 | |
-@gerrit:opendev.org- Artem Goncharov proposed: [zuul/zuul] 859940: Implement tests of the gitea driver https://review.opendev.org/c/zuul/zuul/+/859940 | 09:05 | |
-@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 876255: Truncate Github file annotation message to 64 KB https://review.opendev.org/c/zuul/zuul/+/876255 | 09:56 | |
-@gerrit:opendev.org- Christian Mueller proposed: [zuul/nodepool] 865531: Provide the option to launch Amazon EC2 Spot instances https://review.opendev.org/c/zuul/nodepool/+/865531 | 13:33 | |
@bridgefan:matrix.org | Does anyone here now if there exists a way for a job to be both dependent on another job (based on time) but still runs regardless of the dependent job. | 15:57 |
---|---|---|
@bridgefan:matrix.org | I'm trying to do a cleanup job of sorts which needs to run even when the main job fails. | 15:57 |
@bridgefan:matrix.org | I looked into soft dependencies but that doesn't quite work. | 15:57 |
@clarkb:matrix.org | bridgefan: can you use a cleanup playbook in a single job instead? That is what the run phase exists for | 16:18 |
@bridgefan:matrix.org | Ok. If that is the only way, I will try that direction. The reason that was not the obvious choice on my side is that this cleanup job could service multiple other jobs rather than needing to be instanced for each. | 16:20 |
@bridgefan:matrix.org | And if it were possible, it would be helpful in this case | 16:20 |
@bridgefan:matrix.org | Thanks for the insight | 16:21 |
@clarkb:matrix.org | I'm not sure if there is a way to do what you describe. I haven't had to do that anywhere myself | 16:38 |
@michael_kelly_anet:matrix.org | Trying to get the github connection up and going, but we keep getting an error that the Request + Payload signature do not match. | 22:32 |
@michael_kelly_anet:matrix.org | It looks like the webhook_token, not the app key is being used to verify this. Am misunderstanding something here? | 22:33 |
@clarkb:matrix.org | I'm not super familar with github's webhook system. But I think when you create webhooks without an app you generate a shared secret that is used to verify the signatures. When you use an app instead github provides you with that shared secret which ou need to make note of and stick in the zuul config somewhere? | 22:40 |
@michael_kelly_anet:matrix.org | Yea, there's a key and a token - just not 100% sure what form the token is supposed to be in | 22:42 |
@clarkb:matrix.org | I suspect that you need to set the webhook token value to whatever was returned when you created the app? | 22:42 |
@clarkb:matrix.org | https://docs.github.com/en/rest/apps/webhooks?apiVersion=2022-11-28#get-a-webhook-configuration-for-an-app | 22:42 |
-@gerrit:opendev.org- Zuul merged on behalf of Simon Westphahl: [zuul/zuul] 875970: Fix race related to PR with changed base branch https://review.opendev.org/c/zuul/zuul/+/875970 | 22:43 | |
@michael_kelly_anet:matrix.org | Hmmm. Are the values in the github connection expected to base64 encoded or in clear? | 22:44 |
@michael_kelly_anet:matrix.org | (in zuul.conf?) | 22:45 |
@clarkb:matrix.org | the docs don't say you should encode it. I would expect it to be as returned by that api call above | 22:46 |
@michael_kelly_anet:matrix.org | Gotcha. I suspect this is a bug in the operator. | 22:46 |
@michael_kelly_anet:matrix.org | It's setting app_key as the base64 encoded value it took from the input config (looks like it should be pointing at a file, in fact) and webhook_token as the base64 encoded token | 22:47 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!