| -@gerrit:opendev.org- Zuul merged on behalf of Dong Zhang: [zuul/nodepool] 866520: Block device mappings should apply for that label only https://review.opendev.org/c/zuul/nodepool/+/866520 | 02:12 | |
| @flaper87:matrix.org | > <@vonschultz:matrix.org> I tried to set up Oauth with Google according to https://zuul-ci.org/docs/zuul/latest/howtos/openid-with-google.html, and it only sort of works. There's the option to sign in, I can select my user on the Oauth page Google gives me, and it redirects back to Zuul, the /auth_callback page. Then it just stands there "Fetching info..." If I then change the URL to the tenant status URL, it works again, and I can bring up a User Info box that has my name in it and a nice "Sign Out" button, so the login seems to have worked. Only, I have to manually leave the /auth_callback page. Did I miss something? | 08:44 |
|---|---|---|
| Same thing happened to me yday once I tested this. It would get "stuck" in the `auth_callback` page instead of completing the redirect flow. For now, I've put an oauth2-proxy in front of it | ||
| @flaper87:matrix.org | I would like to pass a custom image-pull-secret and I noticed that it was only implemented for the OpenShift driver: https://zuul-ci.org/docs/nodepool/latest/openshift.html#attr-providers.[openshift].pools.labels.image-pull-secrets I guess I could just use that one for now | 08:59 |
| @flaper87:matrix.org | > <@flaper87:matrix.org> I would like to pass a custom image-pull-secret and I noticed that it was only implemented for the OpenShift driver: https://zuul-ci.org/docs/nodepool/latest/openshift.html#attr-providers.[openshift].pools.labels.image-pull-secrets I guess I could just use that one for now | 09:00 |
| Based on the docs, it seems like this would work only if a namespace with the secret is provided. That is, the driver won't try to create the secret from (copying it from the executor namespace, for example). | ||
| -@gerrit:opendev.org- Flavio Percoco proposed: [zuul/nodepool] 875847: Allow to pass ImagePullSecrets to Kubernetes pods https://review.opendev.org/c/zuul/nodepool/+/875847 | 09:38 | |
| @flaper87:matrix.org | > <@gerrit:opendev.org> Flavio Percoco proposed: [zuul/nodepool] 875847: Allow to pass ImagePullSecrets to Kubernetes pods https://review.opendev.org/c/zuul/nodepool/+/875847 | 09:39 |
| It's been a loooong time since my last `git review` command 🤣 hope this helps | ||
| -@gerrit:opendev.org- Zuul merged on behalf of Fabien Boucher: [zuul/zuul] 867804: Handle missing diff_refs attribute https://review.opendev.org/c/zuul/zuul/+/867804 | 09:39 | |
| -@gerrit:opendev.org- Flavio Percoco proposed: [zuul/nodepool] 875847: Allow to pass ImagePullSecrets to Kubernetes pods https://review.opendev.org/c/zuul/nodepool/+/875847 | 10:02 | |
| @tcarrez:matrix.org | flaper87: pretty sure you missed it | 12:51 |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 875899: Don't add PR title in commit message on squash https://review.opendev.org/c/zuul/zuul/+/875899 | 13:07 | |
| -@gerrit:opendev.org- Flavio Percoco proposed: [zuul/nodepool] 875847: Allow to pass ImagePullSecrets to Kubernetes pods https://review.opendev.org/c/zuul/nodepool/+/875847 | 13:49 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 875899: Don't add PR title in commit message on squash https://review.opendev.org/c/zuul/zuul/+/875899 | 16:58 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 875970: wip: Fix race condition in PR with changed base branch https://review.opendev.org/c/zuul/zuul/+/875970 | 17:08 | |
| @flaper87:matrix.org | Are users that logged in using google authenticator mapped to some role automatically? | 17:37 |
| @flaper87:matrix.org | > <@flaper87:matrix.org> Are users that logged in using google authenticator mapped to some role automatically? | 17:38 |
| Trying to build the right authorization rules for the tenant. I basically want all logged in users to be able to do everything | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 875980: Log cherrypy elapsed request time https://review.opendev.org/c/zuul/zuul/+/875980 | 19:28 | |
| @clarkb:matrix.org | corvus: question on https://review.opendev.org/c/zuul/zuul/+/875574 if you have a moment | 21:33 |
| @jim:acmegating.com | Clark: replied, lemme know if that's still unclear | 21:46 |
| @clarkb:matrix.org | will do about to post a couple comments on the child chagne too | 21:46 |
| @clarkb:matrix.org | corvus: and posted | 21:47 |
| @clarkb:matrix.org | and ya that clarifies things for the first change | 21:49 |
| @jpew:matrix.org | Ping on https://review.opendev.org/c/zuul/zuul/+/873742 | 21:52 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 875575: Avoid layout updates after delete-pipeline-state https://review.opendev.org/c/zuul/zuul/+/875575 | 21:55 | |
| @jim:acmegating.com | Clark: ^ | 21:55 |
| @clarkb:matrix.org | jpew: the latest update handles the case of an intentional empty commit by only backing out the commit if it knows there was ocntent in that commit but we ended up with an empty commit anyway? | 21:56 |
| @clarkb:matrix.org | I think that should address my previous concerns. I'll rereview shortly | 21:56 |
| @jpew:matrix.org | Correct. It backs it out if the initial commit was _not_ empty (so it preserves a cherry pick of an empty commit). I can't figure out why this isn't an option to `git cherry-pick` by alas | 21:58 |
| @jpew:matrix.org | * Correct. It backs it out if the initial commit was _not_ empty (so it preserves a cherry pick of an empty commit). I can't figure out why this isn't an option to `git cherry-pick` but alas | 21:58 |
| @jpew:matrix.org | And thanks | 21:58 |
| @jim:acmegating.com | jpew: consider trying to sneak a release note in before Clark re-reviews :) | 22:00 |
| @jpew:matrix.org | clearly, git acknowledges this is a useful thing to do, since it's the same behavior `git rebase` does by default :) | 22:01 |
| @jim:acmegating.com | (i don't think it's a requirement for the change, but a nice to have) | 22:01 |
| @jpew:matrix.org | corvus: Ah, right | 22:01 |
| @jpew:matrix.org | I was also apparently quite tired when I wrote the commit message; ugh | 22:09 |
| @clarkb:matrix.org | I +2'd but didn't approve. Happy to do a quick rereview if/when a release note shows up | 22:09 |
| @jpew:matrix.org | This would be a `feature` in the release notes I think? | 22:14 |
| @jim:acmegating.com | jpew: maybe, or a fix -- i think the interesting thing to communicate in a release note is "hey if you tried and failed to use cherry-pick change-merged pipelines before, they should work now". it's a coin toss whether that's a new feature or a fix of a bug that existed forever. :) whichever feels right to you | 22:17 |
| -@gerrit:opendev.org- Joshua Watt proposed: [zuul/zuul] 873742: merger: Keep redundant cherry-pick commits https://review.opendev.org/c/zuul/zuul/+/873742 | 22:22 | |
| @jpew:matrix.org | I would expect to see it as a "fix", so I added it as such | 22:22 |
| -@gerrit:opendev.org- Zuul merged on behalf of Michael Kelly: | 22:55 | |
| - [zuul/zuul-operator] 875284: Convert docs from tox to nox https://review.opendev.org/c/zuul/zuul-operator/+/875284 | ||
| - [zuul/zuul-operator] 875286: Convert linters from tox to nox https://review.opendev.org/c/zuul/zuul-operator/+/875286 | ||
| - [zuul/zuul-operator] 875287: Add remaining nox sessions based on tox.ini https://review.opendev.org/c/zuul/zuul-operator/+/875287 | ||
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!