| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 872733: ensure-skopeo: fixup some typos https://review.opendev.org/c/zuul/zuul-jobs/+/872733 | 03:05 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 872806: build-docker-image: further cleanup buildx path https://review.opendev.org/c/zuul/zuul-jobs/+/872806 | 03:05 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul-jobs] 872495: ansible-lint: uncap https://review.opendev.org/c/zuul/zuul-jobs/+/872495 | 03:29 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: | 03:39 | |
| - [zuul/zuul-jobs] 872258: build-docker-image: fix change prefix https://review.opendev.org/c/zuul/zuul-jobs/+/872258 | ||
| - [zuul/zuul-jobs] 872375: container-roles-jobs: Update tests to jammy nodes https://review.opendev.org/c/zuul/zuul-jobs/+/872375 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul-jobs] 872733: ensure-skopeo: fixup some typos https://review.opendev.org/c/zuul/zuul-jobs/+/872733 | 05:19 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 872842: promote-docker-image: improve failure debugability https://review.opendev.org/c/zuul/zuul-jobs/+/872842 | 05:48 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 872519: Replace use of ProjectContext with SourceContext https://review.opendev.org/c/zuul/zuul/+/872519 | 07:44 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 872908: Cleanup old rebase-merge dirs on repo reset https://review.opendev.org/c/zuul/zuul/+/872908 | 12:28 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 872908: Cleanup old rebase-merge dirs on repo reset https://review.opendev.org/c/zuul/zuul/+/872908 | 12:31 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 872908: Cleanup old rebase-merge dirs on repo reset https://review.opendev.org/c/zuul/zuul/+/872908 | 12:36 | |
| @mhuin:matrix.org | Hello zuul-maint, this is a small QoL change that adds a tenant selector to the GUI: https://review.opendev.org/c/zuul/zuul/+/810955 - it had 3 +2's last it was reviewed but never got merged | 14:17 |
|---|---|---|
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul-client] 872967: Support for ZUUL_TOKEN environment variable https://review.opendev.org/c/zuul/zuul-client/+/872967 | 14:32 | |
| @mhuin:matrix.org | Clark: I am trying to run unit tests for zuul on a Ubuntu 22.04 VM, using the setup-test-docker.sh script to start the required services, but I keep getting permission errors for zookeeper when trying to access the certificate dirs. Is there something I'm missing? I run the script as root - since docker-compose needs to be run as root | 15:04 |
| @jim:acmegating.com | mhu: you should be able to run the script with `ROOTCMD=sudo` or something similar | 15:10 |
| @clarkb:matrix.org | Yup the comment in the script explains that | 15:10 |
| @clarkb:matrix.org | If you run it as root then the SSL certs are all root owned and you will need to run the unittests as root or chown the certs to your user I think | 15:11 |
| @mhuin:matrix.org | ok let me clean it all up and try again | 15:11 |
| @jim:acmegating.com | mhu: https://opendev.org/zuul/zuul/src/branch/master/TESTING.rst?display=source#L26-L27 | 15:12 |
| @jim:acmegating.com | mhu: an alternative with some security implications is adding your user to the docker group. | 15:20 |
| @mhuin:matrix.org | I might just switch to podman but podman-compose can have some compatibility issues with some compose files | 15:24 |
| @mhuin:matrix.org | alright, got it working, thanks! | 15:34 |
| @elpell:matrix.org | Hi. I'm trying the metastatic driver and want using the slot information exposed here to isolate workspaces, based on this change: | 16:43 |
| https://review.opendev.org/c/zuul/nodepool/+/811016/4 | ||
| However, using the latest nodepool release I do not manage to expose the slot information to my jobs. I was think I would be able to find the slot information in the executor's inventory, but I do not (maybe this is not supported yet). Do I have to configure something for this feature? I cannot seem to find much documentation about this. | ||
| @jim:acmegating.com | Per Wiklund: that's a low-priority project i'm working on. it's not finished yet, and not exposed via zuul yet. | 16:45 |
| @jim:acmegating.com | https://review.opendev.org/811017 is the next piece | 16:47 |
| @elpell:matrix.org | > <@jim:acmegating.com> https://review.opendev.org/811017 is the next piece | 16:56 |
| I see, and makes sense! Nice to see it's progressing though! | ||
| @jim:acmegating.com | yep, thanks. once that lands, we're going to have to think about the best way to incorporate it into the standard zuul-jobs roles/jobs. | 16:59 |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 872842: promote-docker-image: improve failure debugability https://review.opendev.org/c/zuul/zuul-jobs/+/872842 | 19:10 | |
| -@gerrit:opendev.org- Ade Lee proposed: [zuul/zuul-jobs] 866881: Add ubuntu to enable-fips role https://review.opendev.org/c/zuul/zuul-jobs/+/866881 | 19:29 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 872482: Fix race condition in pipeline change list init https://review.opendev.org/c/zuul/zuul/+/872482 | 19:37 | |
| -@gerrit:opendev.org- Ian Wienand proposed: | 20:31 | |
| - [zuul/zuul-jobs] 872842: promote-docker-image: improve failure debugability https://review.opendev.org/c/zuul/zuul-jobs/+/872842 | ||
| - [zuul/zuul-jobs] 873028: promote-docker-image: double-quote regexes https://review.opendev.org/c/zuul/zuul-jobs/+/873028 | ||
| @iwienand:matrix.org | Clark: fungi ^ i think the first there is the real solution, from a little local testing playbook. but i think it might not be a bad idea to make it more explicit too | 20:32 |
| @jim:acmegating.com | ianw: i think there's something missing from 842? | 20:46 |
| @clarkb:matrix.org | ianw: double quote == double escape? | 20:54 |
| @clarkb:matrix.org | also I kinda wish this wasn't a linter rule given they behave differently... | 20:55 |
| @iwienand:matrix.org | Clark: ansible itself actually warns on it too | 20:56 |
| @iwienand:matrix.org | ```[WARNING]: conditional statements should not include jinja2 templating delimiters such as {{ }} or {% %}. Found: {{ ((ansible_date_time.iso860 ... blah blah``` | 20:57 |
| @clarkb:matrix.org | ugh | 20:57 |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 872842: promote-docker-image: improve failure debugability https://review.opendev.org/c/zuul/zuul-jobs/+/872842 | 20:58 | |
| @clarkb:matrix.org | anyway change approved | 20:58 |
| @clarkb:matrix.org | ianw: and can you check my comment on the deugging change | 20:59 |
| @iwienand:matrix.org | yeah, i wonder if we do it anywhere else to compare | 21:01 |
| @clarkb:matrix.org | could just uri in a random change and see what it looks like but I'm pretty sure all of the registered data goes in the json file if you don't no log it | 21:02 |
| @jim:acmegating.com | it's definitely unsafe that's why we had no_log before | 21:06 |
| @jim:acmegating.com | (unless something has changed in ansible since then) | 21:08 |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul-jobs] 873028: promote-docker-image: double-quote regexes https://review.opendev.org/c/zuul/zuul-jobs/+/873028 | 21:08 | |
| @iwienand:matrix.org | i'm thinking here that it registers the results, which don't include any header token. but i agree on confirming | 21:09 |
| @jim:acmegating.com | ianw: it's not about registering, it's about the fact that the json output plugin logs all of the input values | 21:09 |
| @clarkb:matrix.org | Theres the initial fix at least which doesn't change those bits | 21:09 |
| @iwienand:matrix.org | right, the call is still no_log; i'm registering it's result though | 21:10 |
| @jim:acmegating.com | i don't see a no_log there? | 21:10 |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 872842: promote-docker-image: improve failure debugability https://review.opendev.org/c/zuul/zuul-jobs/+/872842 | 21:11 | |
| @iwienand:matrix.org | ahh, that's my copy-paste error | 21:12 |
| @jim:acmegating.com | okay, so now with the no_log there -- we're basically assuming that nothing bad can ever end up in result.status or result.msg. honestly, i don't think it's worth the risk. this credential is too important, and the value from seeing "502 server error" there is not high enough to risk exposure imo. | 21:15 |
| @jim:acmegating.com | (i can get behind the idea of doing the templating and filtering as a separate step though -- the rest of the change) | 21:16 |
| @iwienand:matrix.org | that's fair enough. i was thinking this sort of thing would also have helped with the other api error we got with the manifest problem | 21:18 |
| @iwienand:matrix.org | i guess that's why my mind first jumped to "api error" rather than "ansible error" | 21:18 |
| @jim:acmegating.com | yeah. it's annoyingly hard to debug. but it's also so easy for stuff to slip through here (and problems can be caused by some module or ansible changing behavior) and i'm just really paranoid about credentials used for publishing. :/ | 21:20 |
| @iwienand:matrix.org | i can rework it; as you say i think having a bit more explicit info on what was deleted in the logs is probably enough anyway | 21:24 |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 872842: promote-docker-image: improve failure debugability https://review.opendev.org/c/zuul/zuul-jobs/+/872842 | 21:26 | |
| @jim:acmegating.com | yeah. i can probably be persuaded to go along with the change as written if you feel strongly about it and have double checked nothing secret is getting in the json file because of that. but my inclination to be very conservative here leads me to think the list-building part of the change is significant improvement with no risk, and the other part is little improvement for high risk | 21:27 |
| @clarkb:matrix.org | corvus: ianw what keeps that bit of code from deleting permanent tags that are old? | 21:27 |
| @clarkb:matrix.org | (sorry was looking at it more closely and that question popped up in my head) | 21:27 |
| @jim:acmegating.com | Clark: "startswith('change')" | 21:27 |
| @jim:acmegating.com | * Clark: "startswith('change_')" | 21:27 |
| @iwienand:matrix.org | i think it only matches "change_" | 21:27 |
| @clarkb:matrix.org | aha thanks | 21:28 |
| @jim:acmegating.com | or (i guess since that other change we were talking about landed, "startswith(pipeline)". that's more dangerous than i would like, and probably warrants revisiting given that i suspect the rest of that change doesn't work anymore. | 21:28 |
| @jim:acmegating.com | best not use this in a pipeline called "latest_builds" | 21:29 |
| @jim:acmegating.com | * best not use this in a pipeline called "latest" | 21:29 |
| @clarkb:matrix.org | heh we havea deploy pipeline... don't tag things "deploy" | 21:30 |
| @jim:acmegating.com | (to resolve that reference, i'm talking about https://review.opendev.org/740560 which we discussed yesterday. i believe the use case for that change is now broken because it didn't add a test case, and subsequent changes accidentally broke it) i suspect its remnants can be reverted. | 21:31 |
| @jim:acmegating.com | it probably should have used "pipeline_{{pipeline}}" to be safer | 21:32 |
| @jim:acmegating.com | also, i'm really bad at closing parens today. sorry to any lisp hackers. )) | 21:34 |
| @iwienand:matrix.org | i may have stuffed up the tag that we do require in the additional fixup for that | 22:08 |
| @iwienand:matrix.org | https://zuul.opendev.org/t/zuul/build/5dab299d2b7d49329d7999b164727e7c/console | 22:08 |
| @clarkb:matrix.org | ianw: which additional fixup? | 22:09 |
| @iwienand:matrix.org | 22:10 | |
| build-docker-image: further cleanup buildx path : https://review.opendev.org/872806 | ||
| @jim:acmegating.com | ianw: that sort of makes it look like that's coping from the temp registry (rather than the buildset registry) to the intermediate registry | 22:18 |
| @iwienand:matrix.org | https://zuul.opendev.org/t/zuul/build/60d0020b8e2e40508eaf7d5f8c5c244c/console#2/6/17/executor is a working example that looks ~ the same | 22:33 |
| @iwienand:matrix.org | oh i think i see | 22:36 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 873037: Add OpenStack volume quota https://review.opendev.org/c/zuul/nodepool/+/873037 | 22:41 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 872806: build-docker-image: further cleanup buildx path https://review.opendev.org/c/zuul/zuul-jobs/+/872806 | 22:42 | |
| @iwienand:matrix.org | it had dropped the buildset registry tag; i think that was it | 22:43 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 872722: Add scheduler, volumes, and labels to k8s/openshift https://review.opendev.org/c/zuul/nodepool/+/872722 | 22:47 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!