| @clarkb:matrix.org | https://www.sqlalchemy.org/blog/2023/01/26/sqlalchemy-2.0.0-released/ I remember we did some sqlalchemy 1.4 work but we may need to cap sqlalchemy and then move to it intentionally | 01:58 |
|---|---|---|
| @clarkb:matrix.org | Have to look more closely tomorrow | 01:59 |
| @maheshbarai1234:matrix.org | Hi Team, we are facing one issue with respect to the Zuul CI job trigger. We have one project and a few jobs enabled at check and gate pipelines. The pipelines are getting triggered on the PR when there finite number of file changes that have to be merged. The pipelines are not getting when there is an infinite number of file changes. | 07:07 |
| Is there some limitation on the zuul to trigger the pipeline based on the file changes? | ||
| Zuul version: 3.19.1 | ||
| @jkt_:matrix.org | an "infinite number"? | 11:22 |
| @fungicide:matrix.org | > <@maheshbarai1234:matrix.org> Hi Team, we are facing one issue with respect to the Zuul CI job trigger. We have one project and a few jobs enabled at check and gate pipelines. The pipelines are getting triggered on the PR when there finite number of file changes that have to be merged. The pipelines are not getting when there is an infinite number of file changes. | 12:53 |
| > | ||
| > Is there some limitation on the zuul to trigger the pipeline based on the file changes? | ||
| > Zuul version: 3.19.1 | ||
| there's no intentional file limit for the github driver in zuul, but i suppose it's possible there's some sort of bug or something changed with the github api which only affects pull requests over a certain size... keep in mind that zuul 3.19.1 is several years old (july 2020), so you may want to run a more current version of zuul in order to get the fixes for bugs we've identified in that time and changes we've had to make as external system apis have evolved. for example, here's the changes just in the drivers/github tree: https://opendev.org/zuul/zuul/commits/branch/master/zuul/driver/github | ||
| @fungicide:matrix.org | one that catches my eye when skimming that list is https://review.opendev.org/834857 which fixed an issue with getting the changed files list for some pull requests | 12:55 |
| @jpew:matrix.org | I can't quite figure out how https://review.opendev.org/869760 is breaking the mulitarch jobs; does anyone have any ideas? | 14:09 |
| @fungicide:matrix.org | jpew: check the build history for that job, the periodic-weekly run seems to have failed in what looks to me to be the same way: https://zuul.opendev.org/t/zuul/build/eedb0a88b6ae458aba640f2b65908a96 | 14:32 |
| @fungicide:matrix.org | so probably not your change, some external factor has broken the job maybe? | 14:33 |
| @jpew:matrix.org | fungi: Ah, that makese sense. I thought it was my change because all my other changes passed, but I see they don't run that job, so that makes sense | 14:34 |
| @fungicide:matrix.org | i mean, we obviously still need to solve the problem in order to be able to merge your change, but at least we have a good idea of what the cause isn't | 14:34 |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul-client] 751238: Add console-stream subcommand https://review.opendev.org/c/zuul/zuul-client/+/751238 | 15:40 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 872026: Pin sqlalchemy to <2.0 https://review.opendev.org/c/zuul/zuul/+/872026 | 15:52 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 871863: Add an !unsafe change_message variable https://review.opendev.org/c/zuul/zuul/+/871863 | 15:52 | |
| @clarkb:matrix.org | corvus: I guess we aren't sqlalchemy 2.0 compatible yet then? I know we fixed some things but I guess not all | 16:23 |
| @jim:acmegating.com | Clark: yeah i haven't dug into it yet either, but saw tests exploding with sqlalchemy errors | 16:24 |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 794854: Test zuul-client console-stream https://review.opendev.org/c/zuul/zuul/+/794854 | 16:26 | |
| @clarkb:matrix.org | looking at a traceback it almost looks like pymysql and sqlalchemy 2.0 might not be getting along | 16:47 |
| @mhuin:matrix.org | > <@clarkb:matrix.org> corvus: I guess we aren't sqlalchemy 2.0 compatible yet then? I know we fixed some things but I guess not all | 16:48 |
| Would pinning sqlalchemy to 1.4.46 help? | ||
| @mhuin:matrix.org | since 2.0 was released yesterday | 16:48 |
| @clarkb:matrix.org | mhu: yes the change above pins to sqlalchemy<2.0 | 16:48 |
| @clarkb:matrix.org | I just wasn't sure if we needed to do that last night when I linked the 2.0 release info | 16:48 |
| @mhuin:matrix.org | oh right, didn't see it | 16:48 |
| @clarkb:matrix.org | we did do some work to get 1.4 compatibility which is sort of forward compatible. | 16:49 |
| @clarkb:matrix.org | Looking at the first error emitted in this unittest run it looks like sqlalchemy 2.0 wants to do a rollback and pymysql raises an interface error on that | 16:49 |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 842361: zuul-web: harmonize behavior for boolean parameters https://review.opendev.org/c/zuul/zuul/+/842361 | 16:51 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 758985: zuul-client: Test buildsets, buildset-info subcommands https://review.opendev.org/c/zuul/zuul/+/758985 | 16:51 | |
| @clarkb:matrix.org | oh it is only trying to rollback because something else timed out | 16:51 |
| @clarkb:matrix.org | likely a problem but not *the* problem | 16:51 |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 794854: Test zuul-client console-stream https://review.opendev.org/c/zuul/zuul/+/794854 | 16:51 | |
| @clarkb:matrix.org | ya this is beginning to feel like a "pin until the aftershocks settle" sort of situation. It is possible the dbapi drivers and alembic and so on all need modification (or are exposing bugs in the 2.0 release) | 16:58 |
| @clarkb:matrix.org | I'm working on a change that addresses from of the removed in 20 warnings | 17:24 |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul] 872034: Address SqlAlchemy Removed in 2.0 Warnings https://review.opendev.org/c/zuul/zuul/+/872034 | 17:43 | |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul] 872034: Address SqlAlchemy Removed in 2.0 Warnings https://review.opendev.org/c/zuul/zuul/+/872034 | 17:58 | |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul] 872044: Switch to sqlalchemy 2.0 https://review.opendev.org/c/zuul/zuul/+/872044 | 19:20 | |
| @clarkb:matrix.org | All of the warnings emitted by the test suite seem to be fixedin 872034. 872044 is a bit of a toe in the water to see if that was all we had to do | 19:22 |
| @clarkb:matrix.org | hrm looks like there is a different warning "SADeprecationWarning | 19:24 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 871863: Add an !unsafe change_message variable https://review.opendev.org/c/zuul/zuul/+/871863 | 19:33 | |
| -@gerrit:opendev.org- Clark Boylan proposed: | 20:00 | |
| - [zuul/zuul] 872034: Address SqlAlchemy Removed in 2.0 Warnings https://review.opendev.org/c/zuul/zuul/+/872034 | ||
| - [zuul/zuul] 872044: Switch to sqlalchemy 2.0 https://review.opendev.org/c/zuul/zuul/+/872044 | ||
| @clarkb:matrix.org | well I'm not quite sure why sqlalchemy 2.0 is still breaking. I've fixed the obvious things and I think 872034 is mergeable as a first step | 21:50 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!