Thursday, 2022-10-06

-@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul] 858244: web: Differentiate console entries https://review.opendev.org/c/zuul/zuul/+/85824401:41
-@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 828614: Correct exit routine in web, merger https://review.opendev.org/c/zuul/zuul/+/82861406:27
-@gerrit:opendev.org- Benedikt Löffler proposed: [zuul/nodepool] 860470: Cleanup local builds without .d folder https://review.opendev.org/c/zuul/nodepool/+/86047007:14
@elpell:matrix.orgHi, I am trying to use static nodes for running parallell jobs and this change from earlier this spring is a facilitator for this:07:31
https://review.opendev.org/c/zuul/nodepool/+/807806
Is there any possibility to get some reviews for this change?
-@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 860487: Include tenant and pipeline in QueueItem span https://review.opendev.org/c/zuul/zuul/+/86048709:39
-@gerrit:opendev.org- Benjamin Schanzel proposed: [zuul/nodepool] 851988: Implement cleanup of leaked resources in k8s driver https://review.opendev.org/c/zuul/nodepool/+/85198810:19
-@gerrit:opendev.org- Benedikt Löffler proposed: [zuul/nodepool] 860470: Cleanup local builds without .d folder https://review.opendev.org/c/zuul/nodepool/+/86047010:49
-@gerrit:opendev.org- Benedikt Löffler proposed: [zuul/nodepool] 860470: Cleanup local builds without .d folder https://review.opendev.org/c/zuul/nodepool/+/86047010:50
-@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 860572: Store parent span context with span info https://review.opendev.org/c/zuul/zuul/+/86057213:45
@sean-k-mooney:matrix.orghi o/ got a meeting in a sec so ill loop back later but corvus Clark  were yes asking about zuul breaking with devstack deployed openstack recently 14:59
@sean-k-mooney:matrix.org6.4 does seam to not work with yoga nova if the new policy defaults are enabeld15:00
@sean-k-mooney:matrix.orgi have not had time to look into why other then /server/detail is rejected by an account with only member role15:00
@sean-k-mooney:matrix.orgso not sure if its on the nova or zuul side but wanted to confrim that i have also seen the saem behaivor15:01
@sean-k-mooney:matrix.orgi redeployed https://zuul.seanmooney.info at the weekend and hit the same issue15:01
@sean-k-mooney:matrix.orgalso just another FYI the podman example is kind of broken. the hack ye have to bypass the gerrit first run page did  not work15:03
@sean-k-mooney:matrix.orgso it never created the zuul users or projects15:03
@sean-k-mooney:matrix.orgi have ran true that tutoral a few times so i just worked aroudn it then modifed it to deploy the way i wanted just wanted to let ye know15:06
@clarkb:matrix.orgsean-k-mooney: I don't think this has anything to do with zuul. I think that there is something broken somewhere in nova/neutron. I called it out in the nova channel when we first ran into it. That said when it happened for us it wasn't fatal. The fatal error appeared to be in libvirt attaching interfaces. I have changes up to capture the libvirt logs but they haven't merged yet. https://review.opendev.org/c/zuul/nodepool/+/85917215:17
@clarkb:matrix.orgI don't know anything about podman. I don't use it15:17
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 860506: Include skipped builds in database and web ui https://review.opendev.org/c/zuul/zuul/+/86050615:58
@clarkb:matrix.orgcorvus: https://review.opendev.org/c/zuul/nodepool/+/857217 is the don't pause static driver and it failed in the gate on a test metastatic startup unittest. I don't want to recheck in case the test failure is related16:09
@jim:acmegating.comClark: thanks -- it shouldn't be related since metastatic doesn't interact with static, but i'll run it down just to make sure we're not missing something (and hopefully fix a test race assuming all is as expected)16:12
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Simon Westphahl: [zuul/zuul] 860572: Store parent span context with span info https://review.opendev.org/c/zuul/zuul/+/86057216:15
@clarkb:matrix.orgcorvus: ya it would have to be through the new base class flag but I thought that was equivalent for the other drivers16:15
@jim:acmegating.comyeah, a "leak" there is the only way i could see it affecting it16:16
@jim:acmegating.com(the flag should be a noop for other drivers)16:16
-@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 860488: Don't trace merge jobs that we don't lock https://review.opendev.org/c/zuul/zuul/+/86048816:33
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 860591: Avoid simultaneous init in metastatic driver https://review.opendev.org/c/zuul/nodepool/+/86059116:34
@jim:acmegating.comClark: ^ confirmed unrelated but a real metastatic bug16:34
@jim:acmegating.com"Performing init" showed up 3 times instead of the expected 2 times in the failing test log; that was the clue16:35
@clarkb:matrix.orgah ok I'll review that really quickly16:35
@clarkb:matrix.orgcorvus:  in 860572 does the opentelemetry Span object convert the parent dict to have parent_span_id that is queried in the tests?16:44
@jim:acmegating.comClark: i think the answer is yes, but let me elaborate to make sure i understand the question properly.  we actually implement an otel collector in the unit tests, so the values we get back from "getSpan" in the tests are actually gRPC objects which were created when our collector received data over the wire from zuul.  so effectively, we're asserting that something like jaeger gets a data structure that has the correct parent span ids16:47
@clarkb:matrix.orgyes, I guess what I'm asking is that the opentelemetry Span object convers the parent dict to something that gets sent over the wire as span.parent_span.id16:48
@clarkb:matrix.org * yes, I guess what I'm asking is that the opentelemetry Span object convers the parent dict to something that gets sent over the wire as span.parent\_span\_id16:48
@jim:acmegating.comyep.  and we make the assertion at the far end of that chain.16:48
@jim:acmegating.comhere's what we get back, if you're curious: https://paste.opendev.org/show/bztWSdlvA5o6drpmQ70D/16:51
@jim:acmegating.com(i think that's a repr of a grpc object)16:52
-@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/nodepool] 857217: Don't pause the static provider at quota https://review.opendev.org/c/zuul/nodepool/+/85721717:52
@tristanc_:matrix.orgClark: corvus re zuul with FIPS node: adding a custom ~zuul/.ssh/config with host crypto-policy to the  *_ro_paths does not work unfortunately because zuul-bwrap swap the zuul homedir with the buildir. 17:56
@tristanc_:matrix.orgI guess the only solution is to replace /bin/ssh with a wrapper to add the necessary ssh_config17:58
@clarkb:matrix.orgor maybe have your base job write the config?17:59
@clarkb:matrix.orgor maybe it makes sense to have zuul copy an ssh config into the bwrap env? Basically don't make a specific flag for this, but instead just have zuul copy a config if present?18:00
@clarkb:matrix.org(I still think the correct way to deal with this is to fix the ssh client/server)18:00
@tristanc_:matrix.orgClark: oh that's a great idea, thanks!18:00
@tristanc_:matrix.orgClark: we are trying the base job option here: https://review.rdoproject.org/r/c/rdo-jobs/+/45545 . Adding the ssh config to the bwrap env is tricky, at least the simple approach of using `--bind /etc/crypto-policies` fails with "Bad ownership" because the files are created with nobody owner uid.18:11
@clarkb:matrix.orgoh that is good to know. I guess it wants it to be root:root?18:11
@tristanc_:matrix.orgClark: probably yes18:13
@jim:acmegating.comyeah, $HOME is the work dir which is writable, so that seems like a potentially good solution18:22
-@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 856338: Add semaphore support to web UI https://review.opendev.org/c/zuul/zuul/+/85633818:36
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed:22:08
- [zuul/zuul] 860506: Include skipped builds in database and web ui https://review.opendev.org/c/zuul/zuul/+/860506
- [zuul/zuul] 860605: Include skip reason in build error_detail https://review.opendev.org/c/zuul/zuul/+/860605
- [zuul/zuul] 860606: Include some skipped jobs in the code-review report https://review.opendev.org/c/zuul/zuul/+/860606
@jim:acmegating.comClark: ^ i believe the end of that stack should address your concern with skipped jobs; i think it'll improve the experience quite a bit actually22:09
@clarkb:matrix.orgnice! I'll do my best to take a look22:10
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 860608: Remove auth_callback from routes https://review.opendev.org/c/zuul/zuul/+/86060822:38
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed:22:39
- [zuul/zuul] 858987: Rename admin-rule to authorization-rule https://review.opendev.org/c/zuul/zuul/+/858987
- [zuul/zuul] 859353: Remove unused /api/user/authorizations REST endpoint https://review.opendev.org/c/zuul/zuul/+/859353
- [zuul/zuul] 859354: Simplify tenant_authorizatons check https://review.opendev.org/c/zuul/zuul/+/859354
- [zuul/zuul] 859355: Add check_auth tool to zuul-web https://review.opendev.org/c/zuul/zuul/+/859355
- [zuul/zuul] 859356: Hide components in whitelabel tenants https://review.opendev.org/c/zuul/zuul/+/859356
- [zuul/zuul] 859357: Add api-root tenant config object https://review.opendev.org/c/zuul/zuul/+/859357
- [zuul/zuul] 859466: Linger on auth_callback page until login is complete https://review.opendev.org/c/zuul/zuul/+/859466
- [zuul/zuul] 859481: Web: always set redux auth and wait for it https://review.opendev.org/c/zuul/zuul/+/859481
- [zuul/zuul] 860032: Show login button any time auth is available https://review.opendev.org/c/zuul/zuul/+/860032
- [zuul/zuul] 860033: Add access-rules configuration and documentation https://review.opendev.org/c/zuul/zuul/+/860033
- [zuul/zuul] 860034: Set Access-Control-Allow-Origin headers in check_auth tool https://review.opendev.org/c/zuul/zuul/+/860034
- [zuul/zuul] 860035: Support authz for read-only web access https://review.opendev.org/c/zuul/zuul/+/860035
- [zuul/zuul] 860608: Remove auth_callback from routes https://review.opendev.org/c/zuul/zuul/+/860608
-@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed:22:41
- [zuul/zuul] 859466: Linger on auth_callback page until login is complete https://review.opendev.org/c/zuul/zuul/+/859466
- [zuul/zuul] 859481: Web: always set redux auth and wait for it https://review.opendev.org/c/zuul/zuul/+/859481
- [zuul/zuul] 860032: Show login button any time auth is available https://review.opendev.org/c/zuul/zuul/+/860032
- [zuul/zuul] 860033: Add access-rules configuration and documentation https://review.opendev.org/c/zuul/zuul/+/860033
- [zuul/zuul] 860034: Set Access-Control-Allow-Origin headers in check_auth tool https://review.opendev.org/c/zuul/zuul/+/860034
- [zuul/zuul] 860035: Support authz for read-only web access https://review.opendev.org/c/zuul/zuul/+/860035

Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!