| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 843723: Fix the model API 8 transition https://review.opendev.org/c/zuul/zuul/+/843723 | 15:04 | |
| @jim:acmegating.com | Clark: i'm sorry about that! i proposed an alternate fix ^ -- that fixes it on the deserialize side rather than the serialize side. I think that's safer, since it means we don't need to wrap any accesses of the attribute with api version conditionals (we know it's always there). unfortunately, the testing situation for that is worse than the testing situation for your fix. because if we did do it on the serialize side, we could actually test that part of the upgrade. but on the deserialize, we can't -- at least not in a way that's useful (i mean, we could delete the attr from zookeeper, but really we're looking for a test to make sure we didn't forget an attribute, so if we remember to add that attribute to the test, clearly we didn't forget about it, so it's not really a useful test). so i'm inclined to say we should just merge 723 without any test changes. | 15:08 |
|---|---|---|
| @jim:acmegating.com | Clark: one thing we could do to make this more robust would be to check that every known FrozenJob attribute has been deserialized, and if not, set a default value from the Job class. that would solve this class of problem, but would require extra computation on every deserialization... :/ | 15:09 |
| -@gerrit:opendev.org- Denys Mishchenko proposed: [zuul/nodepool] 842913: Fix for post_upload_hook failure. id missing https://review.opendev.org/c/zuul/nodepool/+/842913 | 15:26 | |
| -@gerrit:opendev.org- Denys Mishchenko proposed: [zuul/nodepool] 842913: Fix for post_upload_hook failure. id missing https://review.opendev.org/c/zuul/nodepool/+/842913 | 17:17 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 843731: Unify service stop sequence https://review.opendev.org/c/zuul/zuul/+/843731 | 17:34 | |
| @jim:acmegating.com | Clarkfungi ^ that should make the rolling restart happy | 17:34 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 842010: Add global semaphore support https://review.opendev.org/c/zuul/zuul/+/842010 | 17:55 | |
| -@gerrit:opendev.org- Denys Mishchenko proposed: [zuul/nodepool] 842913: Fix for post_upload_hook failure. id missing https://review.opendev.org/c/zuul/nodepool/+/842913 | 18:01 | |
| @arddennis:matrix.org | Hello, I need help with the test scenario for the 842913. I managed to write a test case which do verification, but I don't think I did it the best way possible. It might be due to a lack of my knowledge or I might be missing something. The problems is: I had to mock create_image and delete_image methods and add files creation to leave some traces of the cloud provider activity which could be checked in the unittest. | 18:07 |
| I do need someone's review and help with this test scenario as I do not know another way to access images list from the fake cloud provider and verify that no error was suppressed by broad exception handler. | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 843734: Fix result updating in deduplication https://review.opendev.org/c/zuul/zuul/+/843734 | 20:53 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 843735: Fix change cache key in pipeline manager https://review.opendev.org/c/zuul/zuul/+/843735 | 21:13 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 843736: Dowgrade pipeline summary refresh error to warning https://review.opendev.org/c/zuul/zuul/+/843736 | 21:20 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!