| @iwienand:matrix.org | > <@fungicide:matrix.org> since ianw wrote the initial implementation of those checks, hopefully he can provide some context when reviewing 842719 | 00:44 |
|---|---|---|
| https://review.opendev.org/c/zuul/nodepool/+/123639 predates my notes in my current form, which i seemed to start about 2 months later (2014-11)! | ||
| @iwienand:matrix.org | "clarkb / modred : ^ first-cut at meta-data setting as discussed for RAX images ... hopefully that is somewhat similar to what you're thinking of :)", we must have been discussing | 00:48 |
| @iwienand:matrix.org | https://meetings.opendev.org/irclogs/%23openstack-infra/%23openstack-infra.2014-09-22.log.html#t2014-09-22T20:00:42 | 00:49 |
| @iwienand:matrix.org | clarkbfungi: jeblair: interested in what you think about https://review.openstack.org/#/c/122960/2 (using our first dib image with nodepool) | 00:49 |
| @iwienand:matrix.org | so that must have been about the time we were finally sick of snapshot images and upstream providers changing their base images in random ways | 00:50 |
| @iwienand:matrix.org | oh and us wondering and back-and-forthing over what DISTRO_NAME DIB_RELEASE etc. mean for centos 7 v 6 v rhel etc. | 01:07 |
| -@gerrit:opendev.org- Denys Mishchenko proposed: [zuul/nodepool] 842913: Fix for post_upload_hook failure. id missing https://review.opendev.org/c/zuul/nodepool/+/842913 | 07:16 | |
| @arddennis:matrix.org | Hi, I proposed change 842913 and got a comment to write a test. Then I started to look at testing and the drivers… And found that all drivers wrote differently. There is no abstract method defined or whatever which defines exact list of arguments. It seems that aws and azure drivers uses some statemachine and more or less defined methods, but they do not follow https://opendev.org/zuul/nodepool/src/branch/master/nodepool/driver/statemachine.py#L667 and are different from openstack. | 14:33 |
| To compare "def deleteImage(self, external_id):" vs "def deleteImage(self, name, id):" | ||
| It might be better to remove id from the deleteImage function in the openstack provider ( https://opendev.org/zuul/nodepool/src/branch/master/nodepool/driver/openstack/provider.py#L216 ) | ||
| And get it from the image object. https://opendev.org/zuul/nodepool/src/branch/master/nodepool/driver/openstack/provider.py#L201 | ||
| Maybe it could be changed to **kwargs to have id as optional argument. | ||
| Can someone give a hint on a better way? | ||
| I want to use post_upload_hook. but it's failure should be handled properly. | ||
| -@gerrit:opendev.org- Joseph Kostreva proposed: [zuul/zuul-jobs] 842723: prepare-workspace: Add role variable prepare_workspace_delete_dest https://review.opendev.org/c/zuul/zuul-jobs/+/842723 | 14:36 | |
| -@gerrit:opendev.org- Joseph Kostreva proposed: [zuul/zuul-jobs] 842723: prepare-workspace: Add variable prepare_workspace_delete_dest https://review.opendev.org/c/zuul/zuul-jobs/+/842723 | 14:37 | |
| @arddennis:matrix.org | * Hi, I proposed change 842913 and got a comment to write a test. Then I started to look at testing and the drivers… And found that all drivers wrote differently. There is no abstract method defined or whatever which defines exact list of arguments. It seems that aws and azure drivers uses some statemachine and more or less defined methods, but they do not follow https://opendev.org/zuul/nodepool/src/branch/master/nodepool/driver/statemachine.py#L667 and are different from openstack. | 14:40 |
| To compare "def deleteImage(self, external\_id):" vs "def deleteImage(self, name, id):" | ||
| It might be better to remove id(or name) from the deleteImage function in the openstack provider ( https://opendev.org/zuul/nodepool/src/branch/master/nodepool/driver/openstack/provider.py#L216 ) | ||
| And get it from the image object. https://opendev.org/zuul/nodepool/src/branch/master/nodepool/driver/openstack/provider.py#L201 | ||
| Maybe it could be changed to \*\*kwargs to have name as optional argument. | ||
| Can someone give a hint on a better way? | ||
| I want to use post\_upload\_hook. but it's failure should be handled properly. | ||
| (edited reason: mixed up name and id while wrote a message) | ||
| -@gerrit:opendev.org- Joseph Kostreva proposed: [zuul/zuul-jobs] 842723: prepare-workspace: Add variable prepare_workspace_delete_dest https://review.opendev.org/c/zuul/zuul-jobs/+/842723 | 14:44 | |
| @fzzfh:matrix.org | hello folks, I use zuul connect gerrit. after run job. zuul ssh gerrit return failed. zuul scheduler log like https://paste.opendev.org/show/bswFnZkkQBC74kWkuK2j/ . where should I modify. thanks. | 14:45 |
| @tobias.henkel:matrix.org | sounds to me that zuul has not the permission to report on that change (e.g. verified=1) | 14:52 |
| @tobias.henkel:matrix.org | is this third party ci against opendev zuul? | 14:52 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 14:52 | |
| - [zuul/nodepool] 841510: Use Zuul-style ZooKeeper connections https://review.opendev.org/c/zuul/nodepool/+/841510 | ||
| - [zuul/nodepool] 841651: Add the component registry from Zuul https://review.opendev.org/c/zuul/nodepool/+/841651 | ||
| - [zuul/nodepool] 841816: Add provider/pool priority support https://review.opendev.org/c/zuul/nodepool/+/841816 | ||
| @tobias.henkel:matrix.org | * fzzf: sounds to me that zuul has not the permission to report on that change (e.g. verified=1) | 14:52 |
| @fzzfh:matrix.org | > <@tobias.henkel:matrix.org> is this third party ci against opendev zuul? | 14:58 |
| yes. it's third party CI report , should I use | ||
| success: | ||
| gerrit:{} instead of | ||
| success: | ||
| gerrit: | ||
| verfied: 1? | ||
| @jim:acmegating.com | fzzf: yes, and then if you would like to leave verified votes in the future, the opendev team should be able to help you with access perms in #_oftc_#opendev:matrix.org | 15:00 |
| @fzzfh:matrix.org | corvus: I get it. much thanks. | 15:01 |
| @clarkb:matrix.org | > <@arddennis:matrix.org> Hi, I proposed change 842913 and got a comment to write a test. Then I started to look at testing and the drivers… And found that all drivers wrote differently. There is no abstract method defined or whatever which defines exact list of arguments. It seems that aws and azure drivers uses some statemachine and more or less defined methods, but they do not follow https://opendev.org/zuul/nodepool/src/branch/master/nodepool/driver/statemachine.py#L667 and are different from openstack. | 15:31 |
| > To compare "def deleteImage(self, external\_id):" vs "def deleteImage(self, name, id):" | ||
| > | ||
| > It might be better to remove id(or name) from the deleteImage function in the openstack provider ( https://opendev.org/zuul/nodepool/src/branch/master/nodepool/driver/openstack/provider.py#L216 ) | ||
| > And get it from the image object. https://opendev.org/zuul/nodepool/src/branch/master/nodepool/driver/openstack/provider.py#L201 | ||
| > | ||
| > Maybe it could be changed to \*\*kwargs to have name as optional argument. | ||
| > | ||
| > Can someone give a hint on a better way? | ||
| > | ||
| > I want to use post\_upload\_hook. but it's failure should be handled properly. | ||
| > (edited reason: mixed up name and id while wrote a message) | ||
| I think your code is correct and even for the other drivers they would call https://opendev.org/zuul/nodepool/src/branch/master/nodepool/driver/statemachine.py#L667 which has the same signature of the openstack provider | ||
| @clarkb:matrix.org | All that to say I the interfaces are identical and nothing should need to change | 15:31 |
| @clarkb:matrix.org | a test is probably a good idea just to assert that and ensure that if we shift interfaces we catch it | 15:32 |
| @arddennis:matrix.org | > <@clarkb:matrix.org> a test is probably a good idea just to assert that and ensure that if we shift interfaces we catch it | 15:34 |
| So I don't need to worry and can just add script for the failed post_upload_hook scenario. Thank you for a clarification. | ||
| @clarkb:matrix.org | I don't think so. If we want to change the interface doing that as a followup for everything would be better. I think your code is correct as is, but agree a test would be helpful to help illustrate that and catch any bad assumptions | 15:35 |
| -@gerrit:opendev.org- Joshua Watt proposed: [zuul/nodepool] 842719: openstack: Remove metadata limit checks https://review.opendev.org/c/zuul/nodepool/+/842719 | 16:44 | |
| @arddennis:matrix.org | Sorry to ask obvious question, but Is zookeeper a must for the nodepool unit tests ? Maybe there is a mock for it to test tox locally and I just missed it. | 17:56 |
| @jim:acmegating.com | > <@arddennis:matrix.org> Sorry to ask obvious question, but Is zookeeper a must for the nodepool unit tests ? Maybe there is a mock for it to test tox locally and I just missed it. | 18:01 |
| it is required -- there's a docker-compose file you can use to set it up easily: https://opendev.org/zuul/nodepool/src/branch/master/tools/test-setup-docker.sh | ||
| @jim:acmegating.com | (basically, run that script, then tox should work) | 18:02 |
| @arddennis:matrix.org | corvus: thank you. It does simplify the process a bit. | 18:34 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/nodepool] 843020: Update some variable names https://review.opendev.org/c/zuul/nodepool/+/843020 | 19:35 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 840758: Add USER to Dockerfile https://review.opendev.org/c/zuul/zuul/+/840758 | 19:36 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 843023: Correct git config item name in mirror-workspace-git-repos https://review.opendev.org/c/zuul/zuul-jobs/+/843023 | 20:13 | |
| @clarkb:matrix.org | corvus: I have approved ^ just now | 20:27 |
| @clarkb:matrix.org | shouldn't be any problems after the testing but makign sure everyone knows it is incming now :) | 20:28 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 20:31 | |
| - [zuul/nodepool] 841816: Add provider/pool priority support https://review.opendev.org/c/zuul/nodepool/+/841816 | ||
| - [zuul/nodepool] 843020: Update some variable names https://review.opendev.org/c/zuul/nodepool/+/843020 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 840758: Add USER to Dockerfile https://review.opendev.org/c/zuul/zuul/+/840758 | 20:36 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul-jobs] 843023: Correct git config item name in mirror-workspace-git-repos https://review.opendev.org/c/zuul/zuul-jobs/+/843023 | 20:36 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 842243: DNM: Try jobs with Ansible 5 https://review.opendev.org/c/zuul/zuul/+/842243 | 20:41 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 843026: Remove "include:" usage from multi-node-bridge https://review.opendev.org/c/zuul/zuul-jobs/+/843026 | 21:09 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 842243: DNM: Try jobs with Ansible 5 https://review.opendev.org/c/zuul/zuul/+/842243 | 21:09 | |
| @jim:acmegating.com | wow... apparently our stream test job is running with a bridge.... | 21:18 |
| @jim:acmegating.com | maybe that should have been a "multinode-bridge" job instead of "multinode" so that jobs that don't need ip bridging don't have the extra complexity | 21:20 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 843026: Remove "include:" usage from multi-node-bridge https://review.opendev.org/c/zuul/zuul-jobs/+/843026 | 21:24 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 840758: Add USER to Dockerfile https://review.opendev.org/c/zuul/zuul/+/840758 | 21:35 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 843026: Remove "include:" usage from multi-node-bridge https://review.opendev.org/c/zuul/zuul-jobs/+/843026 | 21:37 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-jobs] 843026: Remove "include:" usage from multi-node-bridge https://review.opendev.org/c/zuul/zuul-jobs/+/843026 | 21:44 | |
| @jim:acmegating.com | infra-root: i have piloted switching jobs for the zuul project to ansible 5 and fixed two issues that came up. it would probably be good for someone to do similar with some openstack jobs before opendev and/or zuul switches the default version | 22:11 |
| @jim:acmegating.com | as of today, ansible 5 is now the only non-eol ansible supported by zuul, so... i expect zuul to switch defaults soon. | 22:11 |
| @jim:acmegating.com | also, totally meant to say that in #opendev sorry | 22:13 |
| @jim:acmegating.com | * also, totally meant to say the first part in #opendev sorry | 22:13 |
| @clarkb:matrix.org | that is a tenant settable default too right if people want to roll out more slowly (though eventually zuul will drop old ansible and that will be a hard cutoff) | 22:13 |
| @clarkb:matrix.org | I'll put it on opendev's meeting agenda now while I'm thinking about it | 22:14 |
| @jim:acmegating.com | exactly -- i think zuul should switch the default soon but keep the eol versions around for a while and folks can override the default | 22:14 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 840758: Add USER to Dockerfile https://review.opendev.org/c/zuul/zuul/+/840758 | 22:21 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 842243: DNM: Try jobs with Ansible 5. https://review.opendev.org/c/zuul/zuul/+/842243 | 22:26 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/nodepool] 841510: Use Zuul-style ZooKeeper connections https://review.opendev.org/c/zuul/nodepool/+/841510 | 22:57 | |
| @jim:acmegating.com | it seems like there's something wrong with the image build job under ansible 5: https://zuul.opendev.org/t/zuul/build/42d4b86b0da047818049c45612fdbe43/console | 23:08 |
| @jim:acmegating.com | i don't understand the error yet | 23:08 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 842243: DNM: Try jobs with Ansible 5 https://review.opendev.org/c/zuul/zuul/+/842243 | 23:09 | |
| @jim:acmegating.com | i set an autohold for it | 23:09 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 840758: WIP: Add USER to Dockerfile https://review.opendev.org/c/zuul/zuul/+/840758 | 23:15 | |
| @jim:acmegating.com | i think the issue is that the socat we run in the background is getting killed | 23:38 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul-jobs] 843026: Remove "include:" usage from multi-node-bridge https://review.opendev.org/c/zuul/zuul-jobs/+/843026 | 23:47 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!