| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 827589: ensure-virtualenv: Don't support on CentOS 9-stream https://review.opendev.org/c/zuul/zuul-jobs/+/827589 | 02:28 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 827788: Not swallow exception when cat job fails https://review.opendev.org/c/zuul/zuul/+/827788 | 03:03 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul-jobs] 827589: ensure-virtualenv: Don't support on CentOS 9-stream https://review.opendev.org/c/zuul/zuul-jobs/+/827589 | 03:45 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 827799: for build load image and debugging https://review.opendev.org/c/zuul/zuul/+/827799 | 06:02 | |
| -@gerrit:opendev.org- Dong Zhang marked as active: [zuul/zuul] 827788: Not swallow exception when cat job fails https://review.opendev.org/c/zuul/zuul/+/827788 | 08:03 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 827813: Don't convert frozensets to list during job freeze https://review.opendev.org/c/zuul/zuul/+/827813 | 08:26 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 827818: Don't delete items of partially dequeued bundles https://review.opendev.org/c/zuul/zuul/+/827818 | 09:12 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 827813: Don't convert frozensets to list during job freeze https://review.opendev.org/c/zuul/zuul/+/827813 | 10:50 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 827813: Don't convert frozensets to list during job freeze https://review.opendev.org/c/zuul/zuul/+/827813 | 10:54 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 827841: wip: Don't lock pipelines during local layout update https://review.opendev.org/c/zuul/zuul/+/827841 | 11:14 | |
| @avass:vassast.org | We're thinking about implementing some way to disable nodes in nodepool (without having to edit the config file). Since we're relying on a lot of static nodes it's a bit cumbersome to offline nodes for maintenance or quickly offlining a node with a lot of intermittent errors. Would it make sense to just add another set of subcommands to nodepool, like `nodepool disable <id>` and `nodepool enable <id>` so nodepool can mark a node as 'disabled' or 'offline' in zookeeper? | 13:23 |
|---|---|---|
| @ekapoun1:matrix.org | > <@avass:vassast.org> ekapoun1: for example: https://review.opendev.org/plugins/gitiles/zuul/zuul-jobs/+/refs/changes/08/764808/75/roles/zuul-cache-s3/library/zuul_cache_s3_urls.py#97 | 13:59 |
| Would this mean that the project running the custom Ansible module would need to be trusted? | ||
| @avass:vassast.org | ekapoun1: do you mean a config project? If so no, you should be able to run custom modules in an untrusted project as long as you don't target localhost | 14:01 |
| @ekapoun1:matrix.org | Albin Vass: Perhaps I'm misunderstanding but I'm referring to the docs on Configuration here: https://zuul-ci.org/docs/zuul/latest/configuration.html#trusted-and-untrusted-playbooks . Quotes: "The trusted execution context has access to all Ansible features, including the ability to load custom Ansible modules." and "Playbooks run in the untrusted execution context are not permitted to load additional Ansible modules" | 14:03 |
| @jim:acmegating.com | > <@avass:vassast.org> We're thinking about implementing some way to disable nodes in nodepool (without having to edit the config file). Since we're relying on a lot of static nodes it's a bit cumbersome to offline nodes for maintenance or quickly offlining a node with a lot of intermittent errors. Would it make sense to just add another set of subcommands to nodepool, like `nodepool disable <id>` and `nodepool enable <id>` so nodepool can mark a node as 'disabled' or 'offline' in zookeeper? | 14:20 |
| I would suggest a "hold" command | ||
| @avass:vassast.org | > <@jim:acmegating.com> I would suggest a "hold" command | 14:23 |
| So the same function autohold uses without requiring a failed job from zuul i guess? :) | ||
| @jim:acmegating.com | yep, lock + change state. the opposite command already exists with 'delete' | 14:34 |
| @clarkb:matrix.org | Zuulians https://review.opendev.org/c/zuul/zuul/+/827540 should be an easy review. tristanC you haev previously reviewed this one if you have time for it again | 17:11 |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul-jobs] 827589: ensure-virtualenv: Don't support on CentOS 9-stream https://review.opendev.org/c/zuul/zuul-jobs/+/827589 | 17:24 | |
| @clarkb:matrix.org | corvus: can you check my comments on https://review.opendev.org/c/zuul/zuul/+/827788 I'm not sure the author is one matrix | 17:26 |
| @clarkb:matrix.org | * corvus: can you check my comments on https://review.opendev.org/c/zuul/zuul/+/827788 I'm not sure the author is on matrix | 17:27 |
| @clarkb:matrix.org | corvus: swest does https://review.opendev.org/c/zuul/zuul/+/827813 requires a new model api version? | 17:36 |
| @clarkb:matrix.org | In particular we'll try to deserialize tag values that weren't serialized | 17:36 |
| @clarkb:matrix.org | with a mixed system | 17:36 |
| @jim:acmegating.com | Clark: i think the schema is the same | 17:37 |
| @westphahl:matrix.org | Clark: yes, the schema should be the same | 17:38 |
| @jim:acmegating.com | if you're looking at tags, they're already being serialized/deserialized; it's just whether we deserialize them as frozenset or list | 17:38 |
| @jim:acmegating.com | the "attributes" list that we iterate over includes tags | 17:38 |
| @clarkb:matrix.org | I see. So we're being more explicit in the serialize method, but that doesn't really affect the content in the database | 17:40 |
| @clarkb:matrix.org | Thanks for clarifying that. I've approved the change | 17:41 |
| @jim:acmegating.com | Clark: agree re 827788. there may be conflicting goals there; if so, we need to be explicit about what we want to achieve and how. | 17:44 |
| @jim:acmegating.com | ideally with tests | 17:47 |
| @clarkb:matrix.org | ++thanks | 17:48 |
| @jim:acmegating.com | Clark: there's a 3rd change on the 827540 stack btw: https://review.opendev.org/827574 | 17:59 |
| @clarkb:matrix.org | looking | 18:01 |
| -@gerrit:opendev.org- Zuul merged on behalf of Simon Westphahl: [zuul/zuul] 827813: Don't convert frozensets to list during job freeze https://review.opendev.org/c/zuul/zuul/+/827813 | 19:12 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 827540: Explicitly close finger sockets in web https://review.opendev.org/c/zuul/zuul/+/827540 | 22:39 | |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!