| @clarkb:matrix.org | Also probably not much sense in rebasing until we are ready to land them (there is a merge conflict halfway through the stack according to Gerrit) | 00:08 |
|---|---|---|
| @clarkb:matrix.org | corvus: I reviewed the gearman removal stack and didn't find anything worthy of a -1 but did leave a few notes across the stack | 00:36 |
| @jim:acmegating.com | Clark: thanks -- i'll probably save those comments for the rebase then | 00:42 |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 824516: Shuffle list of tenants in run handler https://review.opendev.org/c/zuul/zuul/+/824516 | 09:08 | |
| -@gerrit:opendev.org- chandan kumar proposed: [zuul/zuul-jobs] 822503: Add task to install iptables-nft https://review.opendev.org/c/zuul/zuul-jobs/+/822503 | 09:21 | |
| @hanson76:matrix.org | > <@clarkb:matrix.org> If you'd prefer someone else write the change let us know, but this is probably a good bugfix to get involved if interested :) | 15:33 |
| it had been nice to get someone to help with this, I've not had time to setup a working python env yet nor had time to figure out how to do fix the code in a good way. | ||
| tried with plain editor but then I need to spend some time reading apis etc. Too used to IDEs that give you hints... | ||
| -@gerrit:opendev.org- Zuul merged on behalf of Fabien Boucher: [zuul/zuul] 822484: gerrit driver - skip ignored events before they hit zookeeper https://review.opendev.org/c/zuul/zuul/+/822484 | 15:54 | |
| @avass:vassast.org | Upgrading between 4.10.1 to 4.11.0 breaks zuul-web since now it apparently requires more secrets present to start (mqtt certs and keystore password from what I've seen so far). I don't understand why since there's no release note about that from what I can see. | 16:23 |
| @clarkb:matrix.org | > <@avass:vassast.org> Upgrading between 4.10.1 to 4.11.0 breaks zuul-web since now it apparently requires more secrets present to start (mqtt certs and keystore password from what I've seen so far). I don't understand why since there's no release note about that from what I can see. | 16:26 |
| The keystore password has been required for some time: https://zuul-ci.org/docs/zuul/releasenotes.html#relnotes-4-3-0-upgrade-notes Maybe zuul didn't complain if it was missing until recently though? I'm not sure about the mqtt certs | ||
| @clarkb:matrix.org | > <@hanson76:matrix.org> it had been nice to get someone to help with this, I've not had time to setup a working python env yet nor had time to figure out how to do fix the code in a good way. | 16:26 |
| > tried with plain editor but then I need to spend some time reading apis etc. Too used to IDEs that give you hints... | ||
| Ok, I can probably take a look later today. | ||
| @jim:acmegating.com | Albin Vass: yeah, i think we should have said to put the keystore password everywhere; we messed up the original release note for that. | 16:27 |
| @jim:acmegating.com | we can add another one for 5.0. | 16:27 |
| @clarkb:matrix.org | Oh I see its a location of the password problem | 16:27 |
| @avass:vassast.org | works after adding those two it seems | 16:27 |
| @avass:vassast.org | Clark: yeah, I'd rather not mount secrets in the pods unless they're actually required :) | 16:27 |
| @clarkb:matrix.org | corvus: I think you can modify the old release notes by updated the file they went into | 16:27 |
| @clarkb:matrix.org | * corvus: I think you can modify the old release notes by updating the file they went into | 16:28 |
| @clarkb:matrix.org | I guess we woudldn't republish them to the tag though | 16:28 |
| @clarkb:matrix.org | related to improving docs https://review.opendev.org/c/zuul/zuul/+/824477 is one I wrote based on some feedback we got through storyboard | 16:29 |
| @jim:acmegating.com | Albin Vass: i don't think mqtt secrets were intentionally required; that could probably be changed. | 16:32 |
| @jim:acmegating.com | it may *theoretically* be possible to avoid the keystore password too, but that might be more difficult. | 16:32 |
| @avass:vassast.org | it was easy to mount the mqtt secrets so it's no big issue. just don't wanna spread the secrets around if they're not actually needed :) | 16:36 |
| @jim:acmegating.com | agree | 16:36 |
| @jim:acmegating.com | i'll take a quick look at whether we can fix those things. thanks for trying it out; those are good to find before releasing 5.0. we should either remove the requirements or make them clear in a release note. | 16:37 |
| @tobias.henkel:matrix.org | Clark: 824245 would be a small and easy review to improve scheduler shutdown sequence for when you have time | 17:53 |
| -@gerrit:opendev.org- Tobias Henkel proposed: [zuul/zuul] 772695: Perform per tenant locking in getStatus https://review.opendev.org/c/zuul/zuul/+/772695 | 18:25 | |
| @clarkb:matrix.org | > <@tobias.henkel:matrix.org> Clark: 824245 would be a small and easy review to improve scheduler shutdown sequence for when you have time | 18:28 |
| Done | ||
| @tobias.henkel:matrix.org | thanks! | 18:28 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 824640: Don't load some drivers in zuul-web, and add keystore reno https://review.opendev.org/c/zuul/zuul/+/824640 | 18:55 | |
| @jim:acmegating.com | Albin VassClark tobiash felixedel tristanC ^ i think that should address the issues Albin Vass brought up earlier; i think that would be good to get into 4.12.0 | 18:57 |
| @jim:acmegating.com | oh forgot to git add the reno | 18:57 |
| @tristanc_:matrix.org | corvus: we are also blocked by the tenant-config-check requiring zookeeper certificates (which makes our config-check integration test fail when trying to upgrade to 4.11) | 18:59 |
| @tristanc_:matrix.org | so could we get that in too https://review.opendev.org/c/zuul/zuul/+/824058 ? | 18:59 |
| @jim:acmegating.com | tristanC: yes thanks, i agree! | 19:00 |
| @clarkb:matrix.org | I can review both changes in the next little bit | 19:00 |
| @jim:acmegating.com | (i think i saw that, checked it locally, and forgot to +2) | 19:00 |
| @jim:acmegating.com | cool, when those land, i'll plan to restart opendev to sanity check, and presume that will be the basis for 4.12. then we can land the gearmanectomy and that will be 5.0 | 19:02 |
| @clarkb:matrix.org | corvus: can youcheck my comment on https://review.opendev.org/c/zuul/zuul/+/824640? | 19:05 |
| @jim:acmegating.com | Clark: replied | 19:06 |
| @jim:acmegating.com | Clark: i think it's like that because of the backwards-compat stuff... which actually we should think about removing for 5.0. but probably in another change (like the gearmanectomy) | 19:08 |
| @clarkb:matrix.org | I agree that seems to handle it. I guess we can refactor later then | 19:08 |
| @jim:acmegating.com | (because right now, line 141 can add the connection) | 19:08 |
| @jim:acmegating.com | (that's what we would remove to remove the backwards compat) | 19:09 |
| @clarkb:matrix.org | Oh this is from when we had different db connection syntax | 19:09 |
| @clarkb:matrix.org | got it | 19:09 |
| -@gerrit:opendev.org- Zuul merged on behalf of Clark Boylan: [zuul/zuul] 824477: Improve documentation around ZK requirements https://review.opendev.org/c/zuul/zuul/+/824477 | 19:15 | |
| @clarkb:matrix.org | I just remembered once Gearman is removed we can bump up the test nodes to focal too | 19:40 |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/nodepool] 824645: Retry EC2 instance state GETs https://review.opendev.org/c/zuul/nodepool/+/824645 | 20:23 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 823739: Offload FrozenJob secrets https://review.opendev.org/c/zuul/zuul/+/823739 | 22:05 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Simon Westphahl: [zuul/zuul] 823782: Compress ZKObject data https://review.opendev.org/c/zuul/zuul/+/823782 | 22:05 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Tristan Cacqueray: [zuul/zuul] 824058: Remove ZooKeeperClient for tenant-conf-check https://review.opendev.org/c/zuul/zuul/+/824058 | 22:16 | |
| @clarkb:matrix.org | corvus: are the governor complaints in https://zuul.opendev.org/t/zuul/build/75fb66de768447e892b764c50173a470/log/job-output.txt known? I think they might be ok since they are temp dirs that are probably getting deleted before it can check the dir but wonder if that is related to the job timing out somehow | 23:17 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 824077: Add a zk-shell debug script https://review.opendev.org/c/zuul/zuul/+/824077 | 23:30 | |
| @clarkb:matrix.org | Zuulians the OpenInfra Summit in June has a CI/CD track (and others if you are interested). If you'd like to participate on the programming committee you can apply for that at https://openinfrafoundation.formstack.com/forms/programmingcommittee2022 and if you would like to submit a talk you can do that at https://cfp.openinfra.dev/app/berlin-2022 | 23:37 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 824655: Handle missing config files in zuul-web https://review.opendev.org/c/zuul/zuul/+/824655 | 23:38 | |
| @jim:acmegating.com | Clark: i think that's a harmless side effect of the test failing | 23:40 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 824640: Don't load some drivers in zuul-web, and add keystore reno https://review.opendev.org/c/zuul/zuul/+/824640 | 23:47 | |
| @jim:acmegating.com | i think that needed some test framework changes to match ^ | 23:47 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!