| -@gerrit:opendev.org- Zuul merged on behalf of Clark Boylan: [zuul/nodepool] 817114: Fix boto deps https://review.opendev.org/c/zuul/nodepool/+/817114 | 01:52 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 817328: Clear and load TPCs before updating layouts on secondary schedulers https://review.opendev.org/c/zuul/zuul/+/817328 | 02:21 | |
| @jim:acmegating.com | Clark, tobiash, swest: ^ that is the biggest one-line change i've written in quite a while | 02:22 |
|---|---|---|
| @clarkb:matrix.org | I need to eat something with sugar in it then I can do a review | 02:23 |
| @clarkb:matrix.org | corvus: what is the call path between createDynamicLayout and updateTenantLayout? I'm currently trying to understand taht relationship so that I can understand the change better | 02:31 |
| @clarkb:matrix.org | Looks like in the scheduler run loop we detect our layout isn't up to date when processing queues and call updateTenantLayout | 02:33 |
| @clarkb:matrix.org | I think what is going on is that loadTPCs call sets things up for the manager getLayout calls that happen later | 02:38 |
| @clarkb:matrix.org | I ended up writing down what i put together to make sense of this in review and suggested additioanl belts and suspenders or an alternative implementation. Mostly concerned that cacheConfig is relying on side effects in other code that are not entirely obvious so being explicit about it might be a good idea | 03:18 |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 817342: WIP: Fix a bug in getting changed files https://review.opendev.org/c/zuul/zuul/+/817342 | 04:22 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 817342: WIP: Fix a bug in getting changed files https://review.opendev.org/c/zuul/zuul/+/817342 | 04:25 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 817342: WIP: Fix a bug in getting changed files https://review.opendev.org/c/zuul/zuul/+/817342 | 04:48 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 817343: WIP: Fix a bug in getting changed files https://review.opendev.org/c/zuul/zuul/+/817343 | 04:52 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 817343: Fix a bug in getting changed files https://review.opendev.org/c/zuul/zuul/+/817343 | 05:52 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 817343: Fix a bug in getting changed files https://review.opendev.org/c/zuul/zuul/+/817343 | 05:54 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul] 817343: Fix a bug in getting changed files https://review.opendev.org/c/zuul/zuul/+/817343 | 05:55 | |
| @westphahl:matrix.org | corvus: small comment on 817328 | 06:10 |
| -@gerrit:opendev.org- Simon Westphahl proposed on behalf of Felix Edel: | 06:33 | |
| - [zuul/zuul] 817159: Implement job endpoints directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817159 | ||
| - [zuul/zuul] 817160: Implement project endpoints directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817160 | ||
| - [zuul/zuul] 817196: Implement tenant endpoints directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817196 | ||
| - [zuul/zuul] 817228: Remove gearman from zuul-web https://review.opendev.org/c/zuul/zuul/+/817228 | ||
| -@gerrit:opendev.org- Simon Westphahl proposed: | 06:33 | |
| - [zuul/zuul] 817003: Store pipeline summary for zuul-web in Zookeeper https://review.opendev.org/c/zuul/zuul/+/817003 | ||
| - [zuul/zuul] 817004: Use pipeline summary from Zookeeper in zuul-web https://review.opendev.org/c/zuul/zuul/+/817004 | ||
| - [zuul/zuul] 817157: Use abide for listing pipelines in zuul-web https://review.opendev.org/c/zuul/zuul/+/817157 | ||
| - [zuul/zuul] 817158: Use abide for getting public keys in zuul-web https://review.opendev.org/c/zuul/zuul/+/817158 | ||
| - [zuul/zuul] 817164: Use abide for getting project SSH keys in zuul-web https://review.opendev.org/c/zuul/zuul/+/817164 | ||
| - [zuul/zuul] 817171: Check authentication directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817171 | ||
| - [zuul/zuul] 817172: Create list of admin tenants directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817172 | ||
| - [zuul/zuul] 817174: Use abide to get (dis-)allowed labels in zuul-web https://review.opendev.org/c/zuul/zuul/+/817174 | ||
| - [zuul/zuul] 817177: Create list of connections directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817177 | ||
| - [zuul/zuul] 817193: Use config errors directly from layout in zuul-web https://review.opendev.org/c/zuul/zuul/+/817193 | ||
| -@gerrit:opendev.org- Felix Edel proposed: | 07:59 | |
| - [zuul/zuul] 817160: Implement project endpoints directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817160 | ||
| - [zuul/zuul] 817196: Implement tenant endpoints directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817196 | ||
| - [zuul/zuul] 817228: Remove gearman from zuul-web https://review.opendev.org/c/zuul/zuul/+/817228 | ||
| - [zuul/zuul] 817354: Align common parts in zuul-web API methods https://review.opendev.org/c/zuul/zuul/+/817354 | ||
| -@gerrit:opendev.org- Felix Edel proposed: [zuul/zuul] 817354: Align common parts in zuul-web API methods https://review.opendev.org/c/zuul/zuul/+/817354 | 08:03 | |
| -@gerrit:opendev.org- Felix Edel proposed on behalf of Simon Westphahl: | 08:35 | |
| - [zuul/zuul] 817003: Store pipeline summary for zuul-web in Zookeeper https://review.opendev.org/c/zuul/zuul/+/817003 | ||
| - [zuul/zuul] 817004: Use pipeline summary from Zookeeper in zuul-web https://review.opendev.org/c/zuul/zuul/+/817004 | ||
| - [zuul/zuul] 817157: Use abide for listing pipelines in zuul-web https://review.opendev.org/c/zuul/zuul/+/817157 | ||
| - [zuul/zuul] 817158: Use abide for getting public keys in zuul-web https://review.opendev.org/c/zuul/zuul/+/817158 | ||
| - [zuul/zuul] 817164: Use abide for getting project SSH keys in zuul-web https://review.opendev.org/c/zuul/zuul/+/817164 | ||
| - [zuul/zuul] 817171: Check authentication directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817171 | ||
| - [zuul/zuul] 817172: Create list of admin tenants directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817172 | ||
| - [zuul/zuul] 817174: Use abide to get (dis-)allowed labels in zuul-web https://review.opendev.org/c/zuul/zuul/+/817174 | ||
| - [zuul/zuul] 817177: Create list of connections directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817177 | ||
| - [zuul/zuul] 817193: Use config errors directly from layout in zuul-web https://review.opendev.org/c/zuul/zuul/+/817193 | ||
| -@gerrit:opendev.org- Felix Edel proposed: | 08:35 | |
| - [zuul/zuul] 814996: Make the ConfigLoader work independently of the Scheduler https://review.opendev.org/c/zuul/zuul/+/814996 | ||
| - [zuul/zuul] 816361: Load system config and tenant layouts in zuul-web https://review.opendev.org/c/zuul/zuul/+/816361 | ||
| - [zuul/zuul] 816362: Implement job freezing API in zuul-web https://review.opendev.org/c/zuul/zuul/+/816362 | ||
| - [zuul/zuul] 816514: Handle management events directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/816514 | ||
| - [zuul/zuul] 816783: Implement autohold endpoints directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/816783 | ||
| - [zuul/zuul] 817159: Use abide to look up jobs directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817159 | ||
| - [zuul/zuul] 817160: Use abide to look up projects directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817160 | ||
| - [zuul/zuul] 817196: Use abide for listing tenants in zuul-web https://review.opendev.org/c/zuul/zuul/+/817196 | ||
| - [zuul/zuul] 817228: Remove gearman from zuul-web https://review.opendev.org/c/zuul/zuul/+/817228 | ||
| - [zuul/zuul] 817354: Align common parts in zuul-web API methods https://review.opendev.org/c/zuul/zuul/+/817354 | ||
| -@gerrit:opendev.org- Felix Edel proposed on behalf of Simon Westphahl: | 08:53 | |
| - [zuul/zuul] 817003: Store pipeline summary for zuul-web in Zookeeper https://review.opendev.org/c/zuul/zuul/+/817003 | ||
| - [zuul/zuul] 817004: Use pipeline summary from Zookeeper in zuul-web https://review.opendev.org/c/zuul/zuul/+/817004 | ||
| - [zuul/zuul] 817157: Use abide for listing pipelines in zuul-web https://review.opendev.org/c/zuul/zuul/+/817157 | ||
| - [zuul/zuul] 817158: Use abide for getting public keys in zuul-web https://review.opendev.org/c/zuul/zuul/+/817158 | ||
| - [zuul/zuul] 817164: Use abide for getting project SSH keys in zuul-web https://review.opendev.org/c/zuul/zuul/+/817164 | ||
| - [zuul/zuul] 817171: Check authentication directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817171 | ||
| - [zuul/zuul] 817172: Create list of admin tenants directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817172 | ||
| - [zuul/zuul] 817174: Use abide to get (dis-)allowed labels in zuul-web https://review.opendev.org/c/zuul/zuul/+/817174 | ||
| - [zuul/zuul] 817177: Create list of connections directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817177 | ||
| - [zuul/zuul] 817193: Use config errors directly from layout in zuul-web https://review.opendev.org/c/zuul/zuul/+/817193 | ||
| -@gerrit:opendev.org- Felix Edel proposed: | 08:53 | |
| - [zuul/zuul] 816514: Handle management events directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/816514 | ||
| - [zuul/zuul] 816783: Implement autohold endpoints directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/816783 | ||
| - [zuul/zuul] 817159: Use abide to look up jobs directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817159 | ||
| - [zuul/zuul] 817160: Use abide to look up projects directly in zuul-web https://review.opendev.org/c/zuul/zuul/+/817160 | ||
| - [zuul/zuul] 817196: Use abide for listing tenants in zuul-web https://review.opendev.org/c/zuul/zuul/+/817196 | ||
| - [zuul/zuul] 817228: Remove gearman from zuul-web https://review.opendev.org/c/zuul/zuul/+/817228 | ||
| - [zuul/zuul] 817354: Align common parts in zuul-web API methods https://review.opendev.org/c/zuul/zuul/+/817354 | ||
| -@gerrit:opendev.org- Felix Edel proposed: [zuul/zuul] 817363: Don't let zuul-web wait for management events to complete https://review.opendev.org/c/zuul/zuul/+/817363 | 09:02 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 817383: Shuffle list of tenants in run handler https://review.opendev.org/c/zuul/zuul/+/817383 | 10:33 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 817388: Add testing for tenant authorizations override https://review.opendev.org/c/zuul/zuul/+/817388 | 11:52 | |
| -@gerrit:opendev.org- Artem Goncharov proposed: [zuul/zuul] 817393: Fix gitlab squash merge https://review.opendev.org/c/zuul/zuul/+/817393 | 12:23 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 768115: Web UI: allow a privileged user to request autohold https://review.opendev.org/c/zuul/zuul/+/768115 | 12:23 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 768199: Web UI: add Autoholds, Autohold page https://review.opendev.org/c/zuul/zuul/+/768199 | 12:23 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 810699: Web UI: Show pipeline types as icons https://review.opendev.org/c/zuul/zuul/+/810699 | 12:24 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 781858: web UI: allow a privileged user to promote a change https://review.opendev.org/c/zuul/zuul/+/781858 | 12:24 | |
| -@gerrit:opendev.org- Felix Edel proposed: [zuul/zuul] 817400: Move serialization helper methods to ZooKeeperBase class https://review.opendev.org/c/zuul/zuul/+/817400 | 13:14 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 817328: Clear and load TPCs before updating layouts on secondary schedulers https://review.opendev.org/c/zuul/zuul/+/817328 | 14:06 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 802559: Web UI: Add "Create Autohold Request" form, improve API error messages https://review.opendev.org/c/zuul/zuul/+/802559 | 15:01 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 769943: Example Docker compose: keycloak integration https://review.opendev.org/c/zuul/zuul/+/769943 | 15:01 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: | 15:27 | |
| - [zuul/zuul] 815787: Refresh pipelines in tests when settled https://review.opendev.org/c/zuul/zuul/+/815787 | ||
| - [zuul/zuul] 815278: DNM: execute tests with two schedulers https://review.opendev.org/c/zuul/zuul/+/815278 | ||
| @spamaps:spamaps.ems.host | corvus: FYI, I'm working on adding network specification to GCE pools. :) | 15:33 |
| @spamaps:spamaps.ems.host | Also trying out hooking nodepool up to Spotify's GKE clusters. | 15:34 |
| @tobias.henkel:matrix.org | corvus: +2 on 817328, do you want a re-review by clark or shall I +3? | 16:09 |
| @jim:acmegating.com | tobiash: ah thx; i just added the +w myself, i think Clark's ok with it | 16:11 |
| -@gerrit:opendev.org- Simon Westphahl proposed on behalf of Felix Edel: | 16:48 | |
| - [zuul/zuul] 817354: Align common parts in zuul-web API methods https://review.opendev.org/c/zuul/zuul/+/817354 | ||
| - [zuul/zuul] 817363: Don't let zuul-web wait for management events to complete https://review.opendev.org/c/zuul/zuul/+/817363 | ||
| -@gerrit:opendev.org- Simon Westphahl proposed: | 16:48 | |
| - [zuul/zuul] 815787: Refresh pipelines in tests when settled https://review.opendev.org/c/zuul/zuul/+/815787 | ||
| - [zuul/zuul] 815278: DNM: execute tests with two schedulers https://review.opendev.org/c/zuul/zuul/+/815278 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 817328: Clear and load TPCs before updating layouts on secondary schedulers https://review.opendev.org/c/zuul/zuul/+/817328 | 17:27 | |
| @spamaps:spamaps.ems.host | I'm not familiar with nodepool review practices anymore. Can https://review.opendev.org/c/zuul/nodepool/+/817070 be +A'd? | 18:39 |
| @jim:acmegating.com | spamaps: normally i'd give Clark a chance to weigh in again, but he may be out today. if not, we can probably +w since the new ps just added testing. | 18:41 |
| @jim:acmegating.com | er, by "if not" i mean "if he's unable to re-review" | 18:41 |
| @clarkb:matrix.org | I can probably take a look. Sorry slow sickly day for me | 18:48 |
| -@gerrit:opendev.org- Zuul merged on behalf of Clint Byrum: [zuul/nodepool] 817070: Fix infinite recursion in GCE provider https://review.opendev.org/c/zuul/nodepool/+/817070 | 20:30 | |
| @spamaps:spamaps.ems.host | TY! | 21:01 |
| @jim:acmegating.com | omg i found the config_errors problem. == instead of - | 21:24 |
| @jim:acmegating.com | * omg i found the config_errors problem. == instead of = | 21:24 |
| @jim:acmegating.com | i spotted some other issues/potential issues, so i'm going to do a bit more work on it. | 21:30 |
| @fungicide:matrix.org | wow, comparison instead of assignment... usually it's the other way around! | 22:01 |
| @fungicide:matrix.org | and yeah, that sort of mistake is really, really tough to spot | 22:01 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 817479: Fix buildset config_errors https://review.opendev.org/c/zuul/zuul/+/817479 | 22:09 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 817479: Fix buildset config_errors https://review.opendev.org/c/zuul/zuul/+/817479 | 22:09 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/nodepool] 817482: Bump DIB to 3.15.1 https://review.opendev.org/c/zuul/nodepool/+/817482 | 22:17 | |
| @tristanc_:matrix.org | fungi: though in that case, a static check should be able to tell the comparaison result was not used | 22:18 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 817484: Use a stable hash for ConfigurationErrorKeys https://review.opendev.org/c/zuul/zuul/+/817484 | 22:19 | |
| @jim:acmegating.com | yeah, i'm surprised pyflakes missed it | 22:19 |
| @clarkb:matrix.org | corvus the last assertEqual in the test for 817479 seems unnecessary. Is there a reason for that one? | 22:21 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 817486: Identify the object in ZKObject (de)serialization errors https://review.opendev.org/c/zuul/zuul/+/817486 | 22:28 | |
| @jim:acmegating.com | Clark: i wanted to reassure myself that testing the equality through the list worked transitively. :) i agree it's very silly, but the actual code is very hard to test, so i thought getting as close to it as possible would be good. | 22:29 |
| -@gerrit:opendev.org- Clint Byrum proposed: [zuul/nodepool] 817487: Add network and subnetwork to GCE driver https://review.opendev.org/c/zuul/nodepool/+/817487 | 22:29 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] 817488: WIP Fix authentication not carrying over tabs https://review.opendev.org/c/zuul/zuul/+/817488 | 22:31 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 817490: Log null change key deference https://review.opendev.org/c/zuul/zuul/+/817490 | 22:35 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 817491: Add repr to FrozenJob https://review.opendev.org/c/zuul/zuul/+/817491 | 22:42 | |
| @jim:acmegating.com | zuul-maint: 817479--817491 (series of 5 patches) are what i'd like to merge before we restart opendev again. they either fix or add additional info for all the issues i'm aware of. | 22:44 |
| @clarkb:matrix.org | corvus: left a comment on a couple of the changes | 23:00 |
| @jim:acmegating.com | Clark: thanks. i'll fix, push up the stack, then run a local test suite | 23:11 |
| @jim:acmegating.com | (i'm pretty sure that is tested, just not sure which test) | 23:11 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 23:12 | |
| - [zuul/zuul] 817479: Fix buildset config_errors https://review.opendev.org/c/zuul/zuul/+/817479 | ||
| - [zuul/zuul] 817484: Use a stable hash for ConfigurationErrorKeys https://review.opendev.org/c/zuul/zuul/+/817484 | ||
| - [zuul/zuul] 817486: Identify the object in ZKObject (de)serialization errors https://review.opendev.org/c/zuul/zuul/+/817486 | ||
| - [zuul/zuul] 817490: Log null change key deference https://review.opendev.org/c/zuul/zuul/+/817490 | ||
| - [zuul/zuul] 817491: Add repr to FrozenJob https://review.opendev.org/c/zuul/zuul/+/817491 | ||
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 23:17 | |
| - [zuul/zuul] 817484: Use a stable hash for ConfigurationErrorKeys https://review.opendev.org/c/zuul/zuul/+/817484 | ||
| - [zuul/zuul] 817486: Identify the object in ZKObject (de)serialization errors https://review.opendev.org/c/zuul/zuul/+/817486 | ||
| - [zuul/zuul] 817490: Log null change key deference https://review.opendev.org/c/zuul/zuul/+/817490 | ||
| - [zuul/zuul] 817491: Add repr to FrozenJob https://review.opendev.org/c/zuul/zuul/+/817491 | ||
| @jim:acmegating.com | caught an issue with the hash change | 23:17 |
| @clarkb:matrix.org | corvus: tristanC has a couple of comments on that hash change too | 23:23 |
| @jim:acmegating.com | tristanC: thx, i'll implement as soon as the local test run finishes | 23:24 |
| @tristanc_:matrix.org | you're welcome, not sure the comments are correct though :) Also, a bytes -> string helper function to do the hashlib//update//hexdigest sequence might be useful to have too | 23:28 |
| @jim:acmegating.com | i'm pretty sure those are straight scalar types, so the comment doesn't apply. and the sort isn't necessary, but i agree it's a good habit to get into for something like this. | 23:29 |
| @jim:acmegating.com | okay, no test failures on the current stack | 23:29 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 23:31 | |
| - [zuul/zuul] 817484: Use a stable hash for ConfigurationErrorKeys https://review.opendev.org/c/zuul/zuul/+/817484 | ||
| - [zuul/zuul] 817486: Identify the object in ZKObject (de)serialization errors https://review.opendev.org/c/zuul/zuul/+/817486 | ||
| - [zuul/zuul] 817490: Log null change key deference https://review.opendev.org/c/zuul/zuul/+/817490 | ||
| - [zuul/zuul] 817491: Add repr to FrozenJob https://review.opendev.org/c/zuul/zuul/+/817491 | ||
| @jim:acmegating.com | that should do it | 23:31 |
| @tristanc_:matrix.org | corvus: thank you for the fast iteration! | 23:32 |
| @jim:acmegating.com | oh just saw the comment on the last change. i'll alter that as well. | 23:33 |
| @jim:acmegating.com | actually... i think it's not possible for name to be unset, so i think maybe it's okay to leave it. | 23:34 |
| @jim:acmegating.com | frozen jobs are only created from jobs, and they always have names | 23:34 |
| @tristanc_:matrix.org | corvus: I guess, but can we prevent using `zuul.model.FrozenJob()` ? otherwise, this will raise an AttributeError on the REPL | 23:38 |
| @jim:acmegating.com | we can't but there's no code path that uses it, and it would not make sense to add one. since it's a zkobject, we only instantiate it with .new() or .fromZK(). | 23:40 |
| @spamaps:spamaps.ems.host | weee got custom networks working on GCE | 23:53 |
| @jim:acmegating.com | i'm looking at what's required to finish removing gearman, and ironically, there's a bunch of web api tests that need to be changed :) | 23:57 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 817495: Use merger API for merger stats https://review.opendev.org/c/zuul/zuul/+/817495 | 23:58 | |
| @spamaps:spamaps.ems.host | That makes sense. | 23:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!