| @iwienand:matrix.org | when i just run a curl, I get "curl: (6) getaddrinfo() thread failed to start" | 00:06 |
|---|---|---|
| @iwienand:matrix.org | it appears to be this -> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=995777 | 00:12 |
| @iwienand:matrix.org | further confirmed by https://review.opendev.org/c/openstack/diskimage-builder/+/815763 working to build f34 | 00:13 |
| @iwienand:matrix.org | fedora is f*ing annoying, but i guess fundamentally these are real problems that it's better to sort out now one-by-one, than in several years at major LTS updates | 00:13 |
| @clarkb:matrix.org | I think the issue is that we're running into them and have nothing to do with the OS development :) | 00:14 |
| @jim:acmegating.com | ianw: what are you doing in 815763 to make it work? | 00:15 |
| @jim:acmegating.com | i feel like i'm missing something | 00:15 |
| @iwienand:matrix.org | corvus: nothing -- that's using bullseye native podman to build f34, so it shows that it's not a generic problem | 00:16 |
| @iwienand:matrix.org | using the custom .debs from that bug, the f35 containers work | 00:16 |
| @jim:acmegating.com | oh, i think i was missing the f34/f35 bit. sorry and thanks | 00:17 |
| @jim:acmegating.com | (my understanding now: f34 works with bullseye; that means that the latest problem is f35 specific and matches that bug) | 00:18 |
| @jim:acmegating.com | (and the nodepool bullseye change should be okay to merge?) | 00:18 |
| @iwienand:matrix.org | that's correct. the only problem is that f34 ships a initramfs without drivers to boot on Xen (at least, same issue might also be causing boot issues on some of our other non-xen providers) | 00:19 |
| @iwienand:matrix.org | so it builds, but it's not a particularly useful output | 00:19 |
| @iwienand:matrix.org | so, it is safe i think to merge the nodepool "use bullsye podman" change. but practically we either need to keep debugging that issue, or move to f35 | 00:22 |
| @iwienand:matrix.org | moving to f35 seems the most practical solution. however that now means we need this fixed podman for the clone3() issue | 00:24 |
| @iwienand:matrix.org | (or figure out the custom seccomp flags) | 00:25 |
| @iwienand:matrix.org | ... reading more | 00:27 |
| @iwienand:matrix.org | > I could get convinced if the issue was fixable by just upading the seccomp.json policy file. | 00:27 |
| > Sadly, that's not the case. | ||
| @iwienand:matrix.org | different, but related bug -> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=994451 | 00:27 |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/nodepool] 815766: Dockerfile: install podman from unstable https://review.opendev.org/c/zuul/nodepool/+/815766 | 01:02 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/nodepool] 815753: Use bullseye podman in container https://review.opendev.org/c/zuul/nodepool/+/815753 | 02:08 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: | 03:58 | |
| - [zuul/zuul] 815752: Rely on bullseye image for skopeo in container image https://review.opendev.org/c/zuul/zuul/+/815752 | ||
| - [zuul/zuul] 813552: Remove Worker class https://review.opendev.org/c/zuul/zuul/+/813552 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of Simon Westphahl: [zuul/zuul] 813805: Remove project pipeline config from queue item https://review.opendev.org/c/zuul/zuul/+/813805 | 04:04 | |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/nodepool] 815766: Dockerfile: install podman from unstable https://review.opendev.org/c/zuul/nodepool/+/815766 | 04:24 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 815764: Add a pipeline change list object to ZK https://review.opendev.org/c/zuul/zuul/+/815764 | 05:34 | |
| @iwienand:matrix.org | dib-nodepool-functional-openstack-fedora-35-containerfile-src: **success** 🎉 | 05:40 |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/nodepool] 815766: Dockerfile: install podman from unstable https://review.opendev.org/c/zuul/nodepool/+/815766 | 05:42 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: | 08:31 | |
| - [zuul/zuul] 815278: DNM: execute tests with two schedulers https://review.opendev.org/c/zuul/zuul/+/815278 | ||
| - [zuul/zuul] 815787: Refresh pipelines in tests when settled https://review.opendev.org/c/zuul/zuul/+/815787 | ||
| - [zuul/zuul] 815788: wip: Allow refreshing project branches https://review.opendev.org/c/zuul/zuul/+/815788 | ||
| -@gerrit:opendev.org- Simon Westphahl proposed on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 815764: Add a pipeline change list object to ZK https://review.opendev.org/c/zuul/zuul/+/815764 | 08:31 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: | 08:32 | |
| - [zuul/zuul] 815787: Refresh pipelines in tests when settled https://review.opendev.org/c/zuul/zuul/+/815787 | ||
| - [zuul/zuul] 815788: wip: Allow refreshing project branches https://review.opendev.org/c/zuul/zuul/+/815788 | ||
| - [zuul/zuul] 815278: DNM: execute tests with two schedulers https://review.opendev.org/c/zuul/zuul/+/815278 | ||
| -@gerrit:opendev.org- Benjamin Schanzel proposed: [zuul/nodepool] 815813: Increase log level of messages https://review.opendev.org/c/zuul/nodepool/+/815813 | 09:40 | |
| -@gerrit:opendev.org- Benjamin Schanzel proposed: [zuul/nodepool] 815813: Increase log level of messages https://review.opendev.org/c/zuul/nodepool/+/815813 | 09:46 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: | 10:14 | |
| - [zuul/zuul] 815787: Refresh pipelines in tests when settled https://review.opendev.org/c/zuul/zuul/+/815787 | ||
| - [zuul/zuul] 815788: wip: Allow refreshing project branches https://review.opendev.org/c/zuul/zuul/+/815788 | ||
| - [zuul/zuul] 815278: DNM: execute tests with two schedulers https://review.opendev.org/c/zuul/zuul/+/815278 | ||
| -@gerrit:opendev.org- Felix Edel proposed: [zuul/zuul] 815844: Provide zstat version when updating Node Request in ZooKeeper https://review.opendev.org/c/zuul/zuul/+/815844 | 13:21 | |
| @westphahl:matrix.org | corvus: I'm interested in your thoughts on 815788 | 13:24 |
| -@gerrit:opendev.org- Zuul merged on behalf of Simon Westphahl: [zuul/zuul] 813809: Lookup event class names from global symbol table https://review.opendev.org/c/zuul/zuul/+/813809 | 14:23 | |
| @spamaps:spamaps.ems.host | Are we all aware that GitLab came up with a cooler name for what Zuul does in the dependent pipeline? https://docs.gitlab.com/ee/ci/pipelines/merge_trains.html | 14:26 |
| @clarkb:matrix.org | But with artificial rev limiter in place | 14:27 |
| @spamaps:spamaps.ems.host | What's that? | 14:28 |
| @clarkb:matrix.org | They limit running jobs to 20 requests at a time. Zuul makes that configurable (and it does a slow start expansion) | 14:29 |
| -@gerrit:opendev.org- Zuul merged on behalf of Simon Westphahl: [zuul/zuul] 813826: Store and resolve queue item's ahead/behind refs https://review.opendev.org/c/zuul/zuul/+/813826 | 14:29 | |
| @spamaps:spamaps.ems.host | That's probably just a compromise because they want it to be simple. | 14:29 |
| @clarkb:matrix.org | Also you have to be able to push to the branch to use them. Thats a weird choice for having computers do this stuff | 14:30 |
| @clarkb:matrix.org | I wonder if that is just a limitation of their ACL system | 14:30 |
| @clarkb:matrix.org | eg no way to express "can merge things via the computer" vs "can merge things" | 14:31 |
| @spamaps:spamaps.ems.host | Still I've now run into two different groups who listened to me explain Zuul and went "oh like GitLab merge trains" | 14:31 |
| @spamaps:spamaps.ems.host | So it might make sense to make some reference to them in docs to explain the difference. But really, the outcome is likely very similar, even if Zuul has some advantages. | 14:32 |
| @spamaps:spamaps.ems.host | Hard to beat billion dollar marketing budgets. Might as well join them. | 14:33 |
| @clarkb:matrix.org | Yes, I think the outcomes are very similar. The biggest differences are going to be ability to scale up more with zuul and ability to use finer controls since you can delegate to zuul then you just have to control who can trigger what in zuul. | 14:33 |
| @clarkb:matrix.org | Fwiw github just announced their feature for this and they use a third term iirc | 14:34 |
| @jim:acmegating.com | also maybe cross-repo speculative dependencies? | 14:34 |
| @clarkb:matrix.org | Merge Queue: https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/using-a-merge-queue | 14:34 |
| @jim:acmegating.com | not to mention cross-source speculative dependencies... which i can't imagine either of them will be implementing any time soon | 14:34 |
| @clarkb:matrix.org | corvus: oh ya + all of zuul's other awesome features | 14:35 |
| @mhuin:matrix.org | Can we come out with our new own hype term? I propose "the merginator" | 14:35 |
| @jim:acmegating.com | mhu: ++ or merge rockets? those are cooler than trains right? | 14:35 |
| @jim:acmegating.com | spamaps: but yes; frequently people ask for "how does zuul compare to X?" marketing material, and i think including those in such material would be good. unfortunately, no one has written that yet. :( | 14:36 |
| @jim:acmegating.com | we also still haven't fleshed out gating.dev. i believe we wanted to include things about dependencies on it. | 14:38 |
| @clarkb:matrix.org | https://review.opendev.org/c/zuul/zuul/+/815747 should be an easy test race fix if anyone has time for review | 14:38 |
| @clarkb:matrix.org | And now school run time. Hoping to dive right into hashtag:sos after wards though (maybe after some email catchup) | 14:38 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 813895: Move job_graph attribute to BuildSet https://review.opendev.org/c/zuul/zuul/+/813895 | 14:43 | |
| @mhuin:matrix.org | corvus: regarding 736968 would you like me to edit the commit message with the rationale behind it? This patch came to be when I split the changes between zuul-web and the GUI, so the commit message was a bit of an afterthought | 14:59 |
| @jim:acmegating.com | mhu: i'm not too worried about it... it's somewhat self evident (the driver bit was what i couldn't figure out on my own), and there's a comment record in gerrit now. if you happen to update for something else, it wouldn't hurt. :) | 15:01 |
| @mhuin:matrix.org | np | 15:01 |
| @clarkb:matrix.org | fungi: maybe you want to review https://review.opendev.org/c/zuul/nodepool/+/815766 since it adds debian unstable stuff to nodepool dib images (for podman specifically) | 15:29 |
| -@gerrit:opendev.org- Zuul merged on behalf of Clark Boylan: [zuul/nodepool] 815545: Add py39 testing to nodepool https://review.opendev.org/c/zuul/nodepool/+/815545 | 15:57 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 815864: Fix race in change cache removal https://review.opendev.org/c/zuul/zuul/+/815864 | 16:17 | |
| @jim:acmegating.com | Clark: i think that's the change_cache error i added the debugs to catch (they helped) | 16:18 |
| @jim:acmegating.com | tobiash, swest: ^ | 16:18 |
| @clarkb:matrix.org | thanks +2 | 16:23 |
| @spamaps:spamaps.ems.host | > <@jim:acmegating.com> we also still haven't fleshed out gating.dev. i believe we wanted to include things about dependencies on it. | 16:27 |
| I've been trying to find some time to work on this specifically. | ||
| @jim:acmegating.com | tobiash: https://review.opendev.org/815747 is another race fix if you have a sec | 16:33 |
| @clarkb:matrix.org | corvus: comments on https://review.opendev.org/c/zuul/zuul/+/814070 if you have a second | 16:41 |
| @jim:acmegating.com | Clark: looking | 16:41 |
| @jim:acmegating.com | Clark: replied | 16:47 |
| @clarkb:matrix.org | oh heh I shoudl've expanded diffs more to be sure of the _deepUpdate return type. The name and class method imply you're getting an updated Job type but ya this should be fine as dict is serializable | 16:51 |
| @jim:acmegating.com | yeah, was just trying to reuse that with minimal churn :) | 16:52 |
| @goneri:matrix.org | https://review.opendev.org/c/zuul/zuul-jobs/+/815866 prevents use from using the role on Fedora 34 (py39). The line does not make a lot of sense and it looks like a mistake was introduce during the import of the module. | 17:04 |
| @clarkb:matrix.org | corvus: super minor thing on https://review.opendev.org/c/zuul/zuul/+/814242 but I feel like I'm overthinking it so went ahead and approved it | 17:11 |
| @jim:acmegating.com | Clark: ++ | 17:14 |
| @goneri:matrix.org | Thank for the super quick review ❤️. | 17:21 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 813913: Serialize JobGraph objects to ZK https://review.opendev.org/c/zuul/zuul/+/813913 | 17:29 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 814065: Serialize ProjectMetadata on JobGraph https://review.opendev.org/c/zuul/zuul/+/814065 | 17:32 | |
| @clarkb:matrix.org | corvus: couple more minor things on https://review.opendev.org/c/zuul/zuul/+/814243 can you take a look before I approve? | 17:52 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 815894: Use ZK transactions when deleting job request locks https://review.opendev.org/c/zuul/zuul/+/815894 | 17:55 | |
| @jim:acmegating.com | Clark: will do; there's another race fix ^ | 17:55 |
| @jim:acmegating.com | Clark: rpld | 18:00 |
| @clarkb:matrix.org | corvus: question on the race fix | 18:05 |
| @jim:acmegating.com | Clark: replied there | 18:14 |
| @jim:acmegating.com | i did miss a NoNodeError check there though; will update | 18:16 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 815894: Use ZK transactions when deleting job request locks https://review.opendev.org/c/zuul/zuul/+/815894 | 18:17 | |
| @jim:acmegating.com | actually that's a silly fix hang on | 18:17 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 815894: Use ZK transactions when deleting job request locks https://review.opendev.org/c/zuul/zuul/+/815894 | 18:18 | |
| @jim:acmegating.com | better, i think. | 18:18 |
| @clarkb:matrix.org | ah ok clean check in the tests is the problem but in production another pass of the cleanup will prune appropriately | 18:35 |
| @jim:acmegating.com | yeah, and i figured the tighter we can make that the better in general | 18:37 |
| @clarkb:matrix.org | Gonéri: comment on your zuul-jobs fips change | 19:08 |
| @clarkb:matrix.org | though now that I'm rethinking it maybe its fine. To the truth table | 19:11 |
| @clarkb:matrix.org | ya ist fine in my head I thought we wanted Fedora to produce a true output for some reason. Its True to fail so we want it to produce False | 19:17 |
| @goneri:matrix.org | Clark: I did some tests before using a Fedora 34 VM and I was working as expeected, but I was also confused by the way the test is done. I've simplify the when condition. | 19:23 |
| @jpew:matrix.org | huh, apparently `kubectl` has a hard (non configurable) 4 hour time limit on a single connection... this is disappointing | 19:57 |
| @jim:acmegating.com | i guess they figured 14.4ksec should be enough for anybody? | 19:58 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 814071: Add test_freeze_noop_job https://review.opendev.org/c/zuul/zuul/+/814071 | 20:04 | |
| @jpew:matrix.org | corvus: Ya, it's just really annoying b/c it limits my ability to use k8s for my builds :( | 20:05 |
| @jpew:matrix.org | Unless maybe I can ssh in instead of using kubectl | 20:05 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 814069: Remove setBase from job freeze API https://review.opendev.org/c/zuul/zuul/+/814069 | 20:12 | |
| @jim:acmegating.com | Clark: what do you think about concurrency n-2? | 20:22 |
| @jim:acmegating.com | if all the opendev nodes are 8cpus now, that's 6, vs 4 prior | 20:23 |
| @clarkb:matrix.org | corvus: probablyworht a try if we're still seeing the load issues | 20:27 |
| @jim:acmegating.com | yeah. i'm not fully there yet, but mulling it over. | 20:28 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 815864: Fix race in change cache removal https://review.opendev.org/c/zuul/zuul/+/815864 | 20:50 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 815894: Use ZK transactions when deleting job request locks https://review.opendev.org/c/zuul/zuul/+/815894 | 20:52 | |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 815747: Fix race is test_zookeeper_disconnect https://review.opendev.org/c/zuul/zuul/+/815747 | 21:02 | |
| @jim:acmegating.com | Clark: now we're cooking with gas :) | 21:03 |
| @clarkb:matrix.org | Nice I was just going to start reviewing the next change in the sos stack | 21:03 |
| @jim:acmegating.com | \o/ | 21:03 |
| @clarkb:matrix.org | Also I just had a crazy idea. We could do two node test jobs for zuul and run mysql postgres and zk on the second node | 21:04 |
| @jim:acmegating.com | ooh | 21:04 |
| @clarkb:matrix.org | to try and offload that load from where the unitetsts run | 21:04 |
| @jim:acmegating.com | we could share that node between all the tox- jobs; i don't know if that's a good or bad idea though. | 21:05 |
| @clarkb:matrix.org | ya I haven't really thought it through yet, but realized that at least some of the load overhead is in the databases and we can in theory run them elsewhere to limit what the executor governors are seeing | 21:06 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 815910: Clean up leaked lock path in request queue https://review.opendev.org/c/zuul/zuul/+/815910 | 21:17 | |
| @jim:acmegating.com | unfortunately, the atomic lock delete wasn't sufficient, so we'll need that to fix that race ^ | 21:17 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 814070: Create Abstract and FrozenJob classes https://review.opendev.org/c/zuul/zuul/+/814070 | 21:18 | |
| @jim:acmegating.com | i think i may go ahead and approve that one with just votes from Clark and I; it's a followup race fix to well-tested code | 21:25 |
| @jim:acmegating.com | this failure really has me stumped: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_32c/814242/9/gate/zuul-tox-py38/32cacbd/testr_results.html | 21:27 |
| @jim:acmegating.com | i'm wondering if it's something about how we check for watches. i'm actually able to reproduce it locally occasionally, but i have to run the full test suite for it, and it only happens like 20% of the time, so it's still not a quick debug cycle | 21:27 |
| @jim:acmegating.com | maybe the output from the server is limited | 21:29 |
| @clarkb:matrix.org | when reviewing this sos stacks I really wish gerrit let me align the two sides of the diff independently | 21:29 |
| @jim:acmegating.com | Clark: ah like when functions move... that would be cool | 21:31 |
| @clarkb:matrix.org | ya | 21:31 |
| @jim:acmegating.com | aha! the response from the server to admin commands is capped at 8k | 21:33 |
| @clarkb:matrix.org | is that true for the http 4 letter words too? | 21:34 |
| @clarkb:matrix.org | might be better off using that if not | 21:34 |
| @clarkb:matrix.org | corvus: couple of notes on https://review.opendev.org/c/zuul/zuul/+/814329 | 21:41 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 815911: Remove getZKWatches https://review.opendev.org/c/zuul/zuul/+/815911 | 21:43 | |
| @jim:acmegating.com | Clark: it's a client-side limitation. i'm sure we could either fix the tcp impl, or switch to http. but maybe it's not worth it. i just removed the check ^ | 21:44 |
| @clarkb:matrix.org | corvus: looking at that change it seems we really only care if watches is not empty or if it is empty. Maybe we should keep the check but boil it down to that binary rather than caring about a full deserialization? | 21:46 |
| @jim:acmegating.com | Clark: the problem is that the wchs command returns, say 10k of data, and our watches might be in the last 2k of it, so we don't get it. the failure mode is returning empty when there really are watches. | 21:47 |
| @jim:acmegating.com | if we get a value, we can trust it. but we can't trust non-values. | 21:48 |
| @clarkb:matrix.org | I see, and we're always going to get some value back | 21:48 |
| @clarkb:matrix.org | or rather some output back which may or may not have the values we want due to the limit | 21:48 |
| @jim:acmegating.com | right | 21:48 |
| @jim:acmegating.com | i guess we could keep it and fail if it's non-empty at the end. that would correctly fail when run in isolation, but might incorrectly pass when run under contention. | 21:49 |
| @jim:acmegating.com | maybe that's better than nothing? | 21:49 |
| @jim:acmegating.com | could do that and add a TODO to re-implement the command method | 21:49 |
| @clarkb:matrix.org | that might help future us debugging a test in isolation | 21:49 |
| @jim:acmegating.com | k, will rework. | 21:50 |
| @jim:acmegating.com | Clark: replied on 814329 | 21:53 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 815911: Remove false-negative in zk test https://review.opendev.org/c/zuul/zuul/+/815911 | 21:57 | |
| @jim:acmegating.com | Clark: reworked ^ | 21:57 |
| @clarkb:matrix.org | corvus: https://review.opendev.org/c/zuul/zuul/+/814679 has a suggestion for a simplification and possible performance improvement | 22:07 |
| @clarkb:matrix.org | Also an other general thing is maybe we should use a bunch of constants for the various zk paths we're interacting with? Would be easier to find where we interact with specific nodes that way | 22:10 |
| @clarkb:matrix.org | corvus: comment on https://review.opendev.org/c/zuul/zuul/+/814570 about simplification too | 22:18 |
| @jim:acmegating.com | Clark: i wish we could make that optimization on 814679, but i don't see a way to do that (except maybe storing the serialized json and passing it in as an extra argument to bypass that case); see comment reply | 22:32 |
| @clarkb:matrix.org | is the issue that we haev to save the path and some minimal content to zk before writing the JobData object? | 22:36 |
| @jim:acmegating.com | Clark: yes because the JobData is hierarchicaly under the job | 22:37 |
| @jim:acmegating.com | Clark: agree on 814570; i'll make a followup | 22:38 |
| @clarkb:matrix.org | corvus: for 814679 can you check my response. I think it may still be possible? Though I may be missing something important there and it may not actually be more efficient now | 22:40 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 815910: Clean up leaked lock path in request queue https://review.opendev.org/c/zuul/zuul/+/815910 | 22:42 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 815916: Reduce use of OrderedDict in PipelineState https://review.opendev.org/c/zuul/zuul/+/815916 | 22:44 | |
| @clarkb:matrix.org | corvus: https://review.opendev.org/c/zuul/zuul/+/815916 has a bit that needs updating that was missed (comment left inline) | 22:49 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 814242: Make FrozenJob.updateParentData a static method https://review.opendev.org/c/zuul/zuul/+/814242 | 22:50 | |
| @jim:acmegating.com | Clark: thx, replied on 679 | 22:54 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 815916: Reduce use of OrderedDict in PipelineState https://review.opendev.org/c/zuul/zuul/+/815916 | 22:55 | |
| @clarkb:matrix.org | makes sense approved | 22:55 |
| @clarkb:matrix.org | corvus: left a note on https://review.opendev.org/c/zuul/zuul/+/814571 about some code symmetry | 23:03 |
| @clarkb:matrix.org | I might need to take a break here and exercise the brain on something different for a bit :) | 23:03 |
| @jim:acmegating.com | Clark: replied | 23:06 |
| @clarkb:matrix.org | corvus: thanks I suggested some edits for symmetry then | 23:08 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 815917: Update Pipeline for symmetry https://review.opendev.org/c/zuul/zuul/+/815917 | 23:14 | |
| @jim:acmegating.com | Clark: ^ too much typing so i went with your original suggestion :) | 23:14 |
| @clarkb:matrix.org | heh ok. Mostly for me reading that I imemdiately have alarm bells when the add and get don't operate on the same objects (they do but it isn't clear the way it was written). I'm happy as long as we avoid those alarm bells | 23:15 |
| @clarkb:matrix.org | unrelated is https://review.opendev.org/c/zuul/zuul/+/815343 worht single core approving? It doesn't fix anything super important but while we are at the game of improve CI seems worthwhile | 23:15 |
| @jim:acmegating.com | Clark: yeah i agree the symmetry helps, at least locally. i didn't see that all the others were that way already :) | 23:16 |
| @jim:acmegating.com | Clark: yeah, i went ahead and approved it. | 23:17 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!