| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 813552: Remove Worker class https://review.opendev.org/c/zuul/zuul/+/813552 | 00:14 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Felix Edel: [zuul/zuul] 811969: WIP Put frozen jobs in ZooKeeper https://review.opendev.org/c/zuul/zuul/+/811969 | 00:14 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Simon Westphahl: [zuul/zuul] 813189: Use correct variable for build request stats https://review.opendev.org/c/zuul/zuul/+/813189 | 02:09 | |
| -@gerrit:opendev.org- Ian Wienand proposed: | 02:37 | |
| - [zuul/zuul] 813732: gerrit: handle POST 400 errors and don't retry https://review.opendev.org/c/zuul/zuul/+/813732 | ||
| - [zuul/zuul] 813733: gerrit: trim messages to "human length" https://review.opendev.org/c/zuul/zuul/+/813733 | ||
| @nborg:matrix.org | Oleg Loginov: I don't know the gitlab configuration. But I do know that we've had similar problems with reporting when using community edition gitlab while setting approval: true as you have. It is an premium or higher feature to be allowed to set the approval: https://docs.gitlab.com/ee/api/merge_request_approvals.html | 05:04 |
|---|---|---|
| You could try setting approval: false and see if zuul is reporting back then. | ||
| @ologinov:synapse.sardinasystems.com | nborg thx for the info | 05:40 |
| @nborg:matrix.org | Oleg Loginov: Remove the approval than setting it to false: https://zuul-ci.org/docs/zuul/reference/drivers/gitlab.html?highlight=gitlab%20driver | 06:28 |
| -@gerrit:opendev.org- Ian Wienand proposed: | 06:29 | |
| - [zuul/zuul] 813732: gerrit: handle POST 400 errors and don't retry https://review.opendev.org/c/zuul/zuul/+/813732 | ||
| - [zuul/zuul] 813733: gerrit: trim messages to "human length" https://review.opendev.org/c/zuul/zuul/+/813733 | ||
| -@gerrit:opendev.org- Bhagyashri Shewale proposed: [zuul/zuul-jobs] 813749: [DNM] Handle TypeError while installing the any sibling python packages https://review.opendev.org/c/zuul/zuul-jobs/+/813749 | 06:50 | |
| @ologinov:synapse.sardinasystems.com | @nborg thanks! I'll check it later. I think that able to leave comment in MR will be enough at this point. | 06:54 |
| -@gerrit:opendev.org- Bhagyashri Shewale proposed: [zuul/zuul-jobs] 813749: [DNM] Handle TypeError while installing the any sibling python packages https://review.opendev.org/c/zuul/zuul-jobs/+/813749 | 06:59 | |
| @ologinov:synapse.sardinasystems.com | * nborg thanks! I'll check it later. I think that able to leave comment in MR will be enough at this point. | 07:03 |
| -@gerrit:opendev.org- Bhagyashri Shewale proposed: [zuul/zuul-jobs] 813749: [DNM] Handle TypeError while installing the any sibling python packages https://review.opendev.org/c/zuul/zuul-jobs/+/813749 | 07:09 | |
| -@gerrit:opendev.org- Dong Zhang proposed: [zuul/zuul-jobs] 813034: Implement role for limiting zuul log file size https://review.opendev.org/c/zuul/zuul-jobs/+/813034 | 07:18 | |
| -@gerrit:opendev.org- Bhagyashri Shewale proposed: [zuul/zuul-jobs] 813749: Handled TypeError while installing any sibling python packages https://review.opendev.org/c/zuul/zuul-jobs/+/813749 | 07:25 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 813805: Remove project pipeline config from queue item https://review.opendev.org/c/zuul/zuul/+/813805 | 12:08 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 813809: Lookup event class names from global symbol table https://review.opendev.org/c/zuul/zuul/+/813809 | 12:32 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 813826: Store and resolve queue item's ahead/behind refs https://review.opendev.org/c/zuul/zuul/+/813826 | 13:44 | |
| @theikki6:matrix.org | Hello, | 14:11 |
| I have a question regarding the use of variables in project.templates. | ||
| Does anyone know if it is possible to use the vars to specify the jobs in the templates? I have tried the following: | ||
| Ex 1. | ||
| - project-template: | ||
| name: test_template | ||
| description: | | ||
| Decription of template. | ||
| vars: | ||
| my_var: foo | ||
| check: | ||
| jobs: | ||
| - test-{{ my_var }} | ||
| Also, would it be possible to set/overwrite the variable in the project vars or read it from a file? I have failed when I have tried. | ||
| Ex 2. | ||
| - project: | ||
| templates: | ||
| - test_template | ||
| vars: | ||
| module_id: bar | ||
| vars_files: | ||
| - my_var.yml | ||
| Thanks! | ||
| -@gerrit:opendev.org- Zuul merged on behalf of Clark Boylan: [zuul/zuul] 813711: Build Zuul's docker images on Bullseye https://review.opendev.org/c/zuul/zuul/+/813711 | 14:42 | |
| @mordred:inaugust.com | theikki6: hi! the zuul job config itself is not templated, so no - using variables like that won't work. any content in zuul config that contains variables like that get passed through to any ansible playbooks where they get expanded - so there are cases where you might see a {{ }} construct in a zuul config, but it's just containing passthrough data | 15:22 |
| @clarkb:matrix.org | theikki6 you can't do jinja templating of the zuul configs like that. I don't think zuul's config supports loading vars from files either. Remember this is a layer above the Ansible. | 15:23 |
| @mordred:inaugust.com | Clark: jinx | 15:25 |
| @clarkb:matrix.org | ya the keyboard on my phone covered up your resposne until after I sent mine :) | 15:28 |
| @clarkb:matrix.org | now I am at a proper machine | 15:28 |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] 813826: Store and resolve queue item's ahead/behind refs https://review.opendev.org/c/zuul/zuul/+/813826 | 15:31 | |
| @clarkb:matrix.org | fungi: any objections to me approving https://review.opendev.org/c/zuul/zuul-jobs/+/813749 now? I'm not sure how much you want to push getting answers on the config parser backport first? | 15:36 |
| @clarkb:matrix.org | corvus: it does seem like we are still leaking znodes https://grafana.opendev.org/d/5Imot6EMk/zuul-status?viewPanel=37&orgId=1&from=now-7d&to=now just at a lesser rate | 15:39 |
| @jim:acmegating.com | Clark: hrm, ok i'll take a look | 15:40 |
| @clarkb:matrix.org | ianw: left some comments on the gerrit comment length fixup | 15:47 |
| @fungicide:matrix.org | > <@clarkb:matrix.org> fungi: any objections to me approving https://review.opendev.org/c/zuul/zuul-jobs/+/813749 now? I'm not sure how much you want to push getting answers on the config parser backport first? | 15:47 |
| no objection | ||
| @clarkb:matrix.org | Did openshift origin stop publishing the client tools as an open source build? Seems like the red hat openshift customer portal has a much newer version of that tooling. I ask because I noticed we install it in our docker images and am wondering if there is a newer version we should be using | 16:01 |
| @jim:acmegating.com | Clark: there's an exception related to cache cleanup and recursion depth. i think that's why the leak has reappeared after a few days. | 16:59 |
| @clarkb:matrix.org | ha hitting the python stack size limit? | 17:04 |
| @jim:acmegating.com | yeah, i think it's subject to infinite recursion; i'll rework to be safer | 17:07 |
| -@gerrit:opendev.org- Zuul merged on behalf of Bhagyashri Shewale: [zuul/zuul-jobs] 813749: Handled TypeError while installing any sibling python packages https://review.opendev.org/c/zuul/zuul-jobs/+/813749 | 17:11 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 813878: Fix infinite recursion in getRelatedChanges https://review.opendev.org/c/zuul/zuul/+/813878 | 17:39 | |
| @jim:acmegating.com | Clark, swest, tobiash: ^ i think we'll want that in 10.0.2. actually, lemme add a reno. | 17:40 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 813878: Fix infinite recursion in getRelatedChanges https://review.opendev.org/c/zuul/zuul/+/813878 | 17:42 | |
| @jim:acmegating.com | Clark, swest, tobiash: ^ with reno | 17:42 |
| @clarkb:matrix.org | thanks I'll review it shortly. Trying to track down an issue with fedora-34 boots in some clouds ... | 17:48 |
| @jim:acmegating.com | er 4.10.2 even :) something something .2 | 17:49 |
| @clarkb:matrix.org | corvus: the commit message isn't clear to me, is the bug with mixed cache key types fixed by this? | 18:06 |
| @clarkb:matrix.org | I guess the issue was when we were adding reference previously when we wanted to add self.cache_stat.key | 18:08 |
| @clarkb:matrix.org | and this chagne only adds to the set using self.cache_stat.key now | 18:08 |
| @jim:acmegating.com | Yes. 2 bugs fixed. | 18:25 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] 813878: Fix infinite recursion in getRelatedChanges https://review.opendev.org/c/zuul/zuul/+/813878 | 20:30 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Felix Edel: [zuul/zuul] 811969: WIP Put frozen jobs in ZooKeeper https://review.opendev.org/c/zuul/zuul/+/811969 | 20:42 | |
| -@gerrit:opendev.org- Andrii Ostapenko proposed: [zuul/zuul-jobs] 813894: Add retries for docker image upload to buildset registry https://review.opendev.org/c/zuul/zuul-jobs/+/813894 | 20:49 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] 813895: Move job_graph attribute to BuildSet https://review.opendev.org/c/zuul/zuul/+/813895 | 21:16 | |
| @iwienand:matrix.org | Clark: thanks for review. the gerrit side of things does say somewhere the size limits are "approximate" ... i'm guessing because of the difficulty of saying what "size" is with unicode | 21:19 |
| @iwienand:matrix.org | https://gerrit.googlesource.com/gerrit/+/refs/heads/master/java/com/google/gerrit/entities/Comment.java#297 is the function that actually does it | 21:34 |
| @clarkb:matrix.org | ianw: right, but I think we can do a decent job ourselves by converting to utf8 and taking the len of that? | 21:36 |
| @clarkb:matrix.org | ianw: then when you truncate do the truncating as a python string as cutting 20 characters off will always be at least 20 bytes | 21:36 |
| @clarkb:matrix.org | basically what you've got is really close we just need to do len(message.encode('utf8')) > LIMIT as the check? | 21:37 |
| @clarkb:matrix.org | corvus: if we do a restart for 813878 in opendev note taht we also bumped the container images to bullseye from buster (I don' | 21:38 |
| @clarkb:matrix.org | * corvus: if we do a restart for 813878 in opendev note taht we also bumped the container images to bullseye from buster (I don't expect issues but it is a newer git so maybe we get slightly better performance?) | 21:39 |
| @jim:acmegating.com | Clark: yeah, i'd like to do that restart today. good to note. | 21:44 |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 813733: gerrit: trim messages to "human length" https://review.opendev.org/c/zuul/zuul/+/813733 | 22:09 | |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul] 813732: gerrit: handle POST 400 errors and don't retry https://review.opendev.org/c/zuul/zuul/+/813732 | 22:41 | |
| @clarkb:matrix.org | ianw: should we do the same utf8 conversion and check in the update in https://review.opendev.org/c/zuul/zuul/+/813733/3/tests/base.py ? | 23:01 |
| @iwienand:matrix.org | Clark: umm, i guess so, although that is pretended to be gerrit | 23:03 |
| @iwienand:matrix.org | * Clark: umm, i guess so, although that is pretending to be gerrit | 23:03 |
| @clarkb:matrix.org | right but isn't gerrit doing a byte check too? | 23:03 |
| @clarkb:matrix.org | I mean a handwavy byte check | 23:04 |
| @iwienand:matrix.org | i'm really not sure, it's taking lengths but if that's of strings or byte objects is beyond my java reading abilities :) | 23:05 |
| @clarkb:matrix.org | I think if we do bytes it is the more conservative version because bytes will always be at least as long as an ascii string and will be longer than a tring with utf8 in it | 23:06 |
| @clarkb:matrix.org | the other way around might let stuff through if people put snowmen in their configs :) | 23:06 |
| @iwienand:matrix.org | in that case it would have to be put ☃ in the unit-tests, but i take your point | 23:07 |
| -@gerrit:opendev.org- Ian Wienand proposed: [zuul/zuul] 813733: gerrit: trim messages to "human length" https://review.opendev.org/c/zuul/zuul/+/813733 | 23:10 | |
| @iwienand:matrix.org | Clark: done ✅ | 23:11 |
| @clarkb:matrix.org | +2 thanks | 23:12 |
| @clarkb:matrix.org | ianw: and I forgot to take you out of the attention set. Sorry! | 23:16 |
| @clarkb:matrix.org | that will take some practice | 23:16 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!