| -@gerrit:opendev.org- Jeremy Stanley proposed: [zuul/zuul-jobs] Test tox.requires doesn't break sibling installs https://review.opendev.org/c/zuul/zuul-jobs/+/812004 | 01:07 | |
| -@gerrit:opendev.org- Tobias Henkel proposed: [zuul/zuul] DNM: Try out pyston https://review.opendev.org/c/zuul/zuul/+/803781 | 07:45 | |
| -@gerrit:opendev.org- Tobias Henkel proposed: [zuul/zuul] DNM: Try pyston in the docker images https://review.opendev.org/c/zuul/zuul/+/803782 | 07:45 | |
| -@gerrit:opendev.org- Tobias Henkel proposed: [zuul/zuul] DNM: Try pyston in the docker images https://review.opendev.org/c/zuul/zuul/+/803782 | 07:46 | |
| @tobias.henkel:matrix.org | corvus: there has an important fix in gear to make tls work on ubuntu focal: https://review.opendev.org/c/opendev/gear/+/741288. There has been no release yet since that merged so could we do a gear release? | 09:54 |
|---|---|---|
| @tobias.henkel:matrix.org | (this might also to be the reason why the pyston changes failed) | 09:55 |
| @tobias.henkel:matrix.org | * corvus: there has beenan important fix in gear to make tls work on ubuntu focal: https://review.opendev.org/c/opendev/gear/+/741288. There has been no release yet since that merged so could we do a gear release? | 11:36 |
| @tobias.henkel:matrix.org | * corvus: there has been an important fix in gear to make tls work on ubuntu focal: https://review.opendev.org/c/opendev/gear/+/741288. There has been no release yet since that merged so could we do a gear release? | 11:37 |
| -@gerrit:opendev.org- Albin Vass proposed: [zuul/zuul] Throw a warning if the executors ssh-key can't be loaded https://review.opendev.org/c/zuul/zuul/+/764584 | 12:16 | |
| -@gerrit:opendev.org- Jeremy Stanley proposed: [zuul/zuul-jobs] Revert "Revert "Include tox_extra_args in tox siblings tasks"" https://review.opendev.org/c/zuul/zuul-jobs/+/812005 | 12:37 | |
| -@gerrit:opendev.org- Jeremy Stanley proposed: | 12:49 | |
| - [zuul/zuul-jobs] Test tox.requires doesn't break sibling installs https://review.opendev.org/c/zuul/zuul-jobs/+/812004 | ||
| - [zuul/zuul-jobs] Revert "Revert "Include tox_extra_args in tox siblings tasks"" https://review.opendev.org/c/zuul/zuul-jobs/+/812005 | ||
| @clarkb:matrix.org | > <@tobias.henkel:matrix.org> corvus: there has been an important fix in gear to make tls work on ubuntu focal: https://review.opendev.org/c/opendev/gear/+/741288. There has been no release yet since that merged so could we do a gear release? | 13:45 |
| We were holding off on a release until zuul stopped using gearman to avoid unexpected complications there. That said opensuse packagers reached out about this recently too. | ||
| @fungicide:matrix.org | as have the wikimedia folks | 13:48 |
| @fungicide:matrix.org | though we also pinned the max gear version in requirements.txt before the zuul 4.8.0 release was cut, so it's probably been long enough now to be safe releasing gear 0.16.0 | 13:51 |
| @fungicide:matrix.org | it's been almost two months and a couple of zuul releases since then | 13:52 |
| @jim:acmegating.com | yeah, i think i said i was okay with a gear release about 1 week after we pinned | 14:16 |
| @clarkb:matrix.org | Should we go ahead and push a tag today? or would people prefer a monday release? | 14:57 |
| @clarkb:matrix.org | corvus: re the zero file case we're skipping over https://opendev.org/zuul/zuul/src/branch/master/zuul/change_matcher.py#L145-L148 for some reason. I guess change.files is set somehow has len == 1 but indexing by 0 is an error | 15:03 |
| @jim:acmegating.com | Clark: yeah, might be worth trying to find out what change.files is in that case. | 15:07 |
| @clarkb:matrix.org | `{"/COMMIT_MSG":{"status":"A","lines_inserted":10,"size_delta":439,"size":439}}` is what it is for the nova example if I manually curl the api. The code seems to think it is getting a list though https://opendev.org/zuul/zuul/src/branch/master/zuul/driver/gerrit/gerritmodel.py#L145 | 15:12 |
| @clarkb:matrix.org | The for loop at https://opendev.org/zuul/zuul/src/branch/master/zuul/change_matcher.py#L151-L154 works because that iterates over the keys in the dict | 15:13 |
| @clarkb:matrix.org | I think the fix here is to coerce it back to a list and maybe drop the Commit message entry | 15:16 |
| @clarkb:matrix.org | I need to compare against what the ssh request gives us | 15:16 |
| -@gerrit:opendev.org- Jeremy Stanley proposed: [zuul/zuul-jobs] More exact section matching for tox showconfig https://review.opendev.org/c/zuul/zuul-jobs/+/812160 | 15:20 | |
| -@gerrit:opendev.org- Ade Lee proposed on behalf of Jiri Podivin: [zuul/zuul-jobs] DNM https://review.opendev.org/c/zuul/zuul-jobs/+/807031 | 15:20 | |
| -@gerrit:opendev.org- Clark Boylan proposed: [zuul/zuul] Handle no file commits in the Gerrit driver https://review.opendev.org/c/zuul/zuul/+/812161 | 15:31 | |
| @clarkb:matrix.org | corvus: ^ I think that will fix the issue we have seen. I don't know what changed to trigger this. Could it be the merge commit file listing updates maybe? | 15:32 |
| @jim:acmegating.com | Clark: yeah, i think that was likely it. sorry! i guess file matching still works because of the iterator, so it's really only the empty-commit case that would trigger this (just wondering why testing didn't catch it). | 15:36 |
| @clarkb:matrix.org | Yup. Also the fake gerrit server returns the data in the correct format | 15:38 |
| @clarkb:matrix.org | I think the test we are missing is the no files commit, but I'm not sure if the test tooling allows for that | 15:38 |
| @clarkb:matrix.org | That said, I'm still leaning towards it being better for zuul to ignore those changes. But this was clearly intended behavior previously so I restored it rather than changing what I think would be better behavior | 15:42 |
| -@gerrit:opendev.org- Jeremy Stanley proposed: | 16:03 | |
| - [zuul/zuul-jobs] More exact section matching for tox showconfig https://review.opendev.org/c/zuul/zuul-jobs/+/812160 | ||
| - [zuul/zuul-jobs] Revert "Revert "Include tox_extra_args in tox siblings tasks"" https://review.opendev.org/c/zuul/zuul-jobs/+/812005 | ||
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: | 16:34 | |
| - [zuul/zuul] zuul-web: add start time, end time info on buildsets https://review.opendev.org/c/zuul/zuul/+/812173 | ||
| - [zuul/zuul] Web UI: display buildsets start, end times on buildsets page https://review.opendev.org/c/zuul/zuul/+/812174 | ||
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] Web UI: add builds timeline on buildset page https://review.opendev.org/c/zuul/zuul/+/811753 | 17:26 | |
| @fungicide:matrix.org | just a heads up, since opendev's statusbot doesn't matrix yet, the review.opendev.org server has been unreachable for the past ~35 minutes due to some sort of network outage in the provider who hosts it, in case anyone's wondering | 19:47 |
| @jim:acmegating.com | zuul-maint: i think we should do a zuul-registry release due to the significant bugfixes from ianw. how does this look: | 22:20 |
| @jim:acmegating.com | commit 6439b16c04c1d36c48a802cc28d89c67a630368e (HEAD -> master, tag: 1.1.0, origin/master, origin/HEAD, refs/changes/28/809528/1) | 22:20 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-operator] Add support for imagePullSecrets https://review.opendev.org/c/zuul/zuul-operator/+/812234 | 22:27 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-preview] DNM: test whether this builds https://review.opendev.org/c/zuul/zuul-preview/+/812237 | 23:05 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul-preview] Switch base image to debian buster https://review.opendev.org/c/zuul/zuul-preview/+/812237 | 23:27 | |
| @jim:acmegating.com | mhu: i haven't had a chance to re-review yet, but it just occurred to me you should add a release note to the gantt chart change (that's new functionality for ppl to know about) | 23:35 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 23:47 | |
| - [zuul/zuul-operator] Add support for imagePullSecrets https://review.opendev.org/c/zuul/zuul-operator/+/812234 | ||
| - [zuul/zuul-operator] Fix zuulRegistryImageVersion https://review.opendev.org/c/zuul/zuul-operator/+/812240 | ||
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!