| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 02:58 | |
| - [zuul/zuul] Only refresh deps if change messages have changed https://review.opendev.org/c/zuul/zuul/+/810787 | ||
| - [zuul/zuul] Use structured change cache keys https://review.opendev.org/c/zuul/zuul/+/810801 | ||
| @jim:acmegating.com | Clark, swest: topic:sos-change-cache has fixes for the change cache slowness we observed in opendev. i tried to improve efficiency as much as possible, and at the end i added a change to how we're keying the change cache so that we don't have to actually fetch changes from the cache as often. i tried to make all of this with the upcoming pipeline state in mind (thinking that the more change references can stand on their own, the better). so i think we want to take a look at that stack asap because we should be able to run opendev on it again, and i think it'll be good to have in place for pipeline state. | 03:02 |
|---|---|---|
| -@gerrit:opendev.org- Zuul merged on behalf of Matthieu Huin https://matrix.to/#/@mhuin:matrix.org: [zuul/zuul] web UI: add "show retries" toggles on buildset page https://review.opendev.org/c/zuul/zuul/+/806201 | 09:07 | |
| -@gerrit:opendev.org- Simon Westphahl proposed: [zuul/zuul] wip: Store queue state in Zookeeper https://review.opendev.org/c/zuul/zuul/+/810920 | 14:14 | |
| @westphahl:matrix.org | corvus: re. the pipeline state I think we have a few use-cases where we want to instantiate ZKObjects w/o saving them to zookeeper. not sure if what I tried in https://review.opendev.org/c/zuul/zuul/+/809414/10/zuul/rpclistener.py is the best way to accomplish that | 14:16 |
| @jim:acmegating.com | swest: that makes sense to me | 14:21 |
| @clarkb:matrix.org | corvus: sos-change-cache is top of my priority this morning once I'm generally caught up today. It looks like ianw also pushed some changes to try and make handling of the github situation better? | 15:03 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] Verify ZK certs can be read https://review.opendev.org/c/zuul/zuul/+/797135 | 16:40 | |
| @clarkb:matrix.org | http://lists.openstack.org/pipermail/openstack-discuss/2021-September/025057.html may be of interest to zuul users using zuul config pragmas to override implied branch matchers | 17:07 |
| @clarkb:matrix.org | TL;DR is you can accidentally match too many branches then have too many pre-run playbooks (and post-run I guess) | 17:07 |
| @clarkb:matrix.org | I'm going to take a break then try to get back to reviewing the sos-change-cache stack again. | 17:08 |
| @jim:acmegating.com | Clark, gtema: for future reference another way to have accomplished that would be to set required-projects: - {name: devstack, override-checkout: master} on the feature/r1 branch of sdk. | 17:28 |
| @clarkb:matrix.org | I seem to recall they didn't want to do that for some reason but I can't remember | 17:29 |
| @gtema:matrix.org | If I remember correctly we tried that, but it didn't work for some reason | 17:29 |
| @gtema:matrix.org | Mordred pointed to this option as alternative | 17:30 |
| @jim:acmegating.com | the pragma implied-branches is better at matching up things like "openstack victoria == ceph squiddy" | 17:30 |
| @gtema:matrix.org | https://review.opendev.org/c/openstack/openstacksdk/+/791023 | 17:31 |
| @gtema:matrix.org | Here I tried that | 17:31 |
| @clarkb:matrix.org | corvus: left a question and some comments on https://review.opendev.org/c/zuul/zuul/+/810539 if you have a second to take a look | 18:07 |
| @jim:acmegating.com | Clark: thx, replied and updated | 18:48 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: | 18:48 | |
| - [zuul/zuul] Remove onChangeUpdated method https://review.opendev.org/c/zuul/zuul/+/810539 | ||
| - [zuul/zuul] Only refresh deps if change messages have changed https://review.opendev.org/c/zuul/zuul/+/810787 | ||
| - [zuul/zuul] Use structured change cache keys https://review.opendev.org/c/zuul/zuul/+/810801 | ||
| @clarkb:matrix.org | followup to evaluate the move sounds good to me | 18:51 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] Attempt to refresh deps less often https://review.opendev.org/c/zuul/zuul/+/810954 | 18:53 | |
| @jim:acmegating.com | that's that | 18:53 |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] [WIP] GUI: Add tenant selector to top menu https://review.opendev.org/c/zuul/zuul/+/810955 | 19:08 | |
| @clarkb:matrix.org | corvus: https://review.opendev.org/c/zuul/zuul/+/810539/7 may be worth approving with carry over votes since the updates were minor? I'll let you decide on that. The changes below that one are approevd and the one after it has enough +2s. I'll keep looking at the others after some lunch | 19:21 |
| @jim:acmegating.com | Clark: agreed and done | 19:32 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] Add a test for github dependency updates https://review.opendev.org/c/zuul/zuul/+/810726 | 20:09 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] [WIP] GUI: Add tenant dropdown to top menu https://review.opendev.org/c/zuul/zuul/+/810955 | 20:27 | |
| -@gerrit:opendev.org- Matthieu Huin https://matrix.to/#/@mhuin:matrix.org proposed: [zuul/zuul] [WIP] GUI: Add tenant dropdown to top menu https://review.opendev.org/c/zuul/zuul/+/810955 | 20:28 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] Fix race in test_data_return_child_from_retried_paused_job https://review.opendev.org/c/zuul/zuul/+/810961 | 20:36 | |
| @jim:acmegating.com | zuul-maint: ^ i'm continuing to fix test races as i see them | 20:36 |
| @clarkb:matrix.org | corvus: small thing on https://review.opendev.org/c/zuul/zuul/+/810801 I +2'd becuase I think that can be addressed in a followup as well. But also happy to rereview the change if you update it | 20:43 |
| @jim:acmegating.com | Clark: hrm, some of those values are also intentonally null... | 20:44 |
| @jim:acmegating.com | Clark: so maybe we need a "strornull" converter method? | 20:44 |
| @clarkb:matrix.org | oh ya that would be fine. I think the important bit is that we don't treat numbers as strings or vice versa | 20:45 |
| @clarkb:matrix.org | it would be easy to do with the existing api | 20:45 |
| @jim:acmegating.com | ok sounds good. i'll revise it to do that | 20:45 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] Use structured change cache keys https://review.opendev.org/c/zuul/zuul/+/810801 | 20:48 | |
| @jim:acmegating.com | Clark: ^ how's that look? | 20:49 |
| @clarkb:matrix.org | that looks good. You can clean up some of the str() conversions in the various drivers too if you like. | 20:50 |
| @clarkb:matrix.org | I'm more worried about subsequent chagnes to the drivers or new drivers that end up mixing and matching types and the update addresses that as is | 20:50 |
| @jim:acmegating.com | yeah. tbh, i think belt and suspenders is probably good for this :) | 20:51 |
| @clarkb:matrix.org | https://review.opendev.org/c/zuul/zuul/+/810954 will need a rebase onto that latest update. But it lgtm | 20:53 |
| @clarkb:matrix.org | and possibly will help make things just a bit quicker occasionally :) | 20:54 |
| @jim:acmegating.com | rebased | 21:01 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] Attempt to refresh deps less often https://review.opendev.org/c/zuul/zuul/+/810954 | 21:01 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] Allow more time in test_smart_reconfiguration https://review.opendev.org/c/zuul/zuul/+/810967 | 21:53 | |
| @jim:acmegating.com | another test fix ^ | 21:53 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] Fix race in component re-registration https://review.opendev.org/c/zuul/zuul/+/810968 | 22:03 | |
| @jim:acmegating.com | and another ^ | 22:03 |
| @clarkb:matrix.org | corvus: minor cleanup suggested on that last one | 22:08 |
| @jim:acmegating.com | derp | 22:08 |
| @jim:acmegating.com | Clark: thx nice catch :) | 22:09 |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed: [zuul/zuul] Fix race in component re-registration https://review.opendev.org/c/zuul/zuul/+/810968 | 22:09 | |
| @clarkb:matrix.org | corvus: felixedel left some thoughts/questions on https://review.opendev.org/c/zuul/zuul/+/808091 if you want to take a look | 22:36 |
| @clarkb:matrix.org | corvus: https://review.opendev.org/c/zuul/zuul/+/808792 that one conflicts with your race fix above | 22:49 |
| @clarkb:matrix.org | not sure if you want to try and land that one instead if my comments in 808091 aren't too concerning | 22:49 |
| -@gerrit:opendev.org- Zuul merged on behalf of Ian Wienand: [zuul/zuul] github: more complete mocking for app setup https://review.opendev.org/c/zuul/zuul/+/810553 | 22:52 | |
| @jim:acmegating.com | Clark, felixedel: hrm... i think i like my fix to that test race a little better; it's more conservative. mostly this: we should always have a release() after we set hold to false | 23:01 |
| @jim:acmegating.com | Clark: i think we should merge my fix for that and remove the similar fix from 808792 | 23:02 |
| @clarkb:matrix.org | wfm | 23:02 |
| @jim:acmegating.com | looking at other comments now | 23:02 |
| @jim:acmegating.com | Clark: replied | 23:21 |
| @clarkb:matrix.org | ok I +2'd but not sure if want to remove the test race fix and approve the stack together or if we should approve just that change for now | 23:23 |
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: | 23:23 | |
| - [zuul/zuul] Add a test for dequeue-on-new-patchest https://review.opendev.org/c/zuul/zuul/+/810772 | ||
| - [zuul/zuul] Remove onChangeUpdated method https://review.opendev.org/c/zuul/zuul/+/810539 | ||
| -@gerrit:opendev.org- Zuul merged on behalf of James E. Blair https://matrix.to/#/@jim:acmegating.com: [zuul/zuul] Only refresh deps if change messages have changed https://review.opendev.org/c/zuul/zuul/+/810787 | 23:26 | |
| -@gerrit:opendev.org- James E. Blair https://matrix.to/#/@jim:acmegating.com proposed on behalf of Felix Edel: | 23:27 | |
| - [zuul/zuul] Don't use executor.builds when processing build result events https://review.opendev.org/c/zuul/zuul/+/808091 | ||
| - [zuul/zuul] Don't use executor.builds to find out if tests are settled https://review.opendev.org/c/zuul/zuul/+/808792 | ||
| - [zuul/zuul] Remove the local builds list from the executor client https://review.opendev.org/c/zuul/zuul/+/809175 | ||
| @jim:acmegating.com | Clark: i went ahead and rebased it on my fix and removed the other | 23:27 |
| @jim:acmegating.com | i ran that test locally just to double check it still works :) | 23:27 |
| @clarkb:matrix.org | cool I've updated my reviews on the stack | 23:31 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!