| opendevreview | James E. Blair proposed zuul/zuul master: Perform an implicit smart-reconfigure on startup https://review.opendev.org/c/zuul/zuul/+/804806 | 00:10 |
|---|---|---|
| opendevreview | James E. Blair proposed zuul/zuul-operator master: Fix wait for scheduler to settle in tests https://review.opendev.org/c/zuul/zuul-operator/+/804462 | 00:10 |
| corvus | swest, tobiash: can you take a look at https://review.opendev.org/804806 and let me know if that makes sense? | 00:30 |
| opendevreview | James E. Blair proposed zuul/zuul master: Add tenant name on NodeRequests for Nodepool https://review.opendev.org/c/zuul/zuul/+/788680 | 00:36 |
| swest | corvus: lgtm | 06:10 |
| opendevreview | Ian Wienand proposed zuul/zuul master: web: JobVariant : convert to DescriptionList https://review.opendev.org/c/zuul/zuul/+/804601 | 06:19 |
| opendevreview | Ian Wienand proposed zuul/zuul master: web: JobVariant : use wide layout for DescriptionList https://review.opendev.org/c/zuul/zuul/+/804602 | 06:19 |
| opendevreview | Ian Wienand proposed zuul/zuul master: web: Job: don't display loading/refresh header https://review.opendev.org/c/zuul/zuul/+/804821 | 06:19 |
| opendevreview | Ian Wienand proposed zuul/zuul master: web: JobVariant : use wide layout for DescriptionList https://review.opendev.org/c/zuul/zuul/+/804602 | 06:56 |
| opendevreview | Benjamin Schanzel proposed zuul/nodepool master: Add Tenant-Scoped Resource Quota https://review.opendev.org/c/zuul/nodepool/+/800765 | 07:09 |
| opendevreview | Benjamin Schanzel proposed zuul/nodepool master: Add Tenant-Scoped Resource Quota https://review.opendev.org/c/zuul/nodepool/+/800765 | 07:11 |
| opendevreview | Benjamin Schanzel proposed zuul/nodepool master: Add Tenant-Scoped Resource Quota https://review.opendev.org/c/zuul/nodepool/+/800765 | 07:21 |
| lidaliu[m] | Hello, I have a question related to the grafana plot shown here. How does zuul send out nodepool metrics to the grafana ?https://grafana.opendev.org/d/KRmop6EMz/nodepool?orgId=1 | 07:23 |
| opendevreview | Tobias Henkel proposed zuul/zuul master: Don't return nodeset on cancel https://review.opendev.org/c/zuul/zuul/+/804830 | 07:32 |
| *** jpena|off is now known as jpena | 07:32 | |
| opendevreview | Tobias Henkel proposed zuul/zuul master: Remove noop builds from builds list https://review.opendev.org/c/zuul/zuul/+/804831 | 07:49 |
| *** rpittau|afk is now known as rpittau | 07:54 | |
| tobiash[m] | zuul-maint: this fixes a serious memory leak since we leak all noop jobs and thus all layouts in the system ^ | 08:10 |
| tobiash[m] | (at least all layouts that involve noop jobs which are many in our system) | 08:11 |
| opendevreview | Tobias Henkel proposed zuul/zuul master: Remove noop builds from builds list https://review.opendev.org/c/zuul/zuul/+/804831 | 08:13 |
| avass[m] | tobiash: only got a nit that the code could check `if build.build_request_ref` instead of checking the inverse and returning early | 08:17 |
| opendevreview | Tobias Henkel proposed zuul/zuul master: Remove noop builds from builds list https://review.opendev.org/c/zuul/zuul/+/804831 | 08:26 |
| tobiash[m] | now with test | 08:26 |
| opendevreview | Ian Wienand proposed zuul/zuul master: web: Job: don't display loading/refresh header https://review.opendev.org/c/zuul/zuul/+/804821 | 09:04 |
| opendevreview | Ian Wienand proposed zuul/zuul master: web: JobVariant : convert to DescriptionList https://review.opendev.org/c/zuul/zuul/+/804601 | 09:04 |
| opendevreview | Ian Wienand proposed zuul/zuul master: web: JobVariant : use wide layout for DescriptionList https://review.opendev.org/c/zuul/zuul/+/804602 | 09:04 |
| opendevreview | likui proposed zuul/nodepool master: setup.cfg: Replace dashes with underscores https://review.opendev.org/c/zuul/nodepool/+/804837 | 09:20 |
| opendevreview | Merged zuul/zuul master: Perform an implicit smart-reconfigure on startup https://review.opendev.org/c/zuul/zuul/+/804806 | 10:08 |
| avass[m] | corvus: does 800786 depend on 804462 ? | 11:10 |
| *** dviroel|out is now known as dviroel|ruck | 11:26 | |
| *** jpena is now known as jpena|lunch | 11:39 | |
| opendevreview | Merged zuul/zuul-operator master: Make nodepool external_config mount more generic https://review.opendev.org/c/zuul/zuul-operator/+/800786 | 11:53 |
| avass[m] | I guess not :) | 12:19 |
| alexh | Hi folks - hope this isn't out of place - we are running into an issue with Zuul (on the executor) if a git branch gets deleted -- even if that branch isn't the merge target or anything like that. It's during the "restore repo" logic that it tries to resolve, seemingly, all heads (even if not relevant?), and so if the commit for one of them is gone, because the branch was deleted, it trips up and keeps retrying forever. http://pastie.org/p/3AIJ5Vfzb0CY75V7PW | 12:31 |
| avass[m] | alexh: that link is giving me a 404 | 12:32 |
| alexh | Hm, odd - can you try https://pastebin.com/raw/GDRfC0Vj ? | 12:33 |
| *** jpena|lunch is now known as jpena | 12:42 | |
| avass[m] | alexh: that works | 12:45 |
| corvus | alexh: was the branch deleted between when the item was enqueued and the job started running? | 12:47 |
| alexh | corvus: quite possibly. The jobs we have run for an hour or two, and there was most definitely stuff running at the time it got deleted. | 12:47 |
| alexh | OK, you specifically asked between enqueuing and starting to run -- not so sure about that. | 12:50 |
| alexh | So far we've had a reasonably smooth experience using Zuul, until we deleted the odd branch last week, and again today. | 12:52 |
| corvus | alexh: you should be able to recover from this by deleting the repo on the executor | 12:52 |
| alexh | Deleting the cache repo? I tried that last Thursday, and it still failed -- but I think then it starts failing on commits that Zuul creates (sort of intermediate rebases for the gate pipeline, etc) | 12:53 |
| alexh | Or at least I couldn't find any other reference to those SHAs anywhere else, which is why I think they were intermediate rebases | 12:54 |
| alexh | If the cache repo is the problem, sorta, is there a way to tell Zuul to only cache the branches it's actually asked to merge anything onto rather than all branches? | 12:55 |
| alexh | Even if deleting the cache repo worked, I don't think it's a sustainable option for us. At that point, I'd get someone to prevent branch deletions in the gerrit project, which also isn't fantastic. | 12:56 |
| corvus | alexh: yeah, it sounds like a bug | 12:56 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: user login with OpenID Connect https://review.opendev.org/c/zuul/zuul/+/734082 | 13:07 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: Alternative styling for autohold and re-enqueue buttons https://review.opendev.org/c/zuul/zuul/+/804043 | 13:08 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Add authentication-realm attribute to tenants https://review.opendev.org/c/zuul/zuul/+/735586 | 13:09 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to dequeue a change https://review.opendev.org/c/zuul/zuul/+/734850 | 13:09 |
| alexh | Alright, thanks. I've created https://storyboard.openstack.org/#!/story/2009121 - hopefully that's the right thing to do. | 13:10 |
| corvus | avass: the operator change should be subject to the same issue; it must have raced in just the right way. | 13:10 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to re-enqueue a change https://review.opendev.org/c/zuul/zuul/+/736772 | 13:14 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: allow a privileged user to request autohold https://review.opendev.org/c/zuul/zuul/+/768115 | 13:14 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: add Autoholds, Autohold page https://review.opendev.org/c/zuul/zuul/+/768199 | 13:15 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: REST API, Web UI: add pipelines' manager, triggers data in status https://review.opendev.org/c/zuul/zuul/+/736968 | 13:15 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to promote a change https://review.opendev.org/c/zuul/zuul/+/781858 | 13:19 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: Add "Create Autohold Request" form, improve API error messages https://review.opendev.org/c/zuul/zuul/+/802559 | 13:19 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Example Docker compose: keycloak integration https://review.opendev.org/c/zuul/zuul/+/769943 | 13:19 |
| fungi | odd issue brought up today by one of our users... removed a project-template from within an untrusted repo, but it's still being selected to run jobs for subsequent changes *unless* those changes touch the zuul configuration: https://meetings.opendev.org/irclogs/%23openstack-infra/%23openstack-infra.2021-08-17.log.html | 13:32 |
| corvus | fungi: sounds like it could be a bug with the new config caching regime | 13:36 |
| fungi | that's what i was wondering, yes | 13:36 |
| fungi | any good way to debug this that you can think of? how do we inspect those caches? | 13:37 |
| corvus | fungi: i'd start by collecting logs related to it, especially to make sure we processed the change-merged event and correctly decided that needed a reconfiguration | 13:44 |
| fungi | thanks, i'll dig those up after my next two conference calls | 13:54 |
| fungi | see if anything looks fishy | 13:55 |
| clarkb | corvus: I think the matrix email didn't include the rooms address? | 13:55 |
| clarkb | (its early and I may ahve simply overlooked it when catching up on email) | 13:55 |
| fungi | i thought that would get mentioned during the cut-over announcement | 13:56 |
| corvus | fungi, clarkb: yeah, was looking for an okay on timing first :) | 14:01 |
| clarkb | ah ok. The email indicated people could join now/early. ALso it is early and my brain needs more fuel | 14:01 |
| *** jpena is now known as jpena|off | 15:26 | |
| *** jpena|off is now known as jpena | 15:27 | |
| Clark[m] | corvus: not sure those last messages ever made it to IRC. | 15:30 |
| Clark[m] | Not a big deal but interesting how things don't always get across the bridge | 15:31 |
| corvus | oh that's interesting. fwiw, i suspect the different bridges may have different performance characteristics. i think the libera.chat bridge is getting a lot of love and attention right now. | 15:32 |
| corvus | i think we've learned some thing that would be useful for folks who do want to maintain a bridged presence, even if we don't. | 15:34 |
| corvus | Clark: also doubly ironic that a message about miscommunication was lost :) | 15:34 |
| Clark[m] | Indeed | 15:35 |
| corvus | Clark: I also see that i didn't get your last msg in the other direction | 15:35 |
| corvus | er, disregard that. i was mistaken | 15:36 |
| corvus | looks like only mine were lost | 15:36 |
| clarkb | corvus: ya I think I misparsed the email because it was too early for the brain | 15:46 |
| *** jpena is now known as jpena|off | 15:48 | |
| *** marios is now known as marios|out | 16:08 | |
| *** rpittau is now known as rpittau|afk | 16:31 | |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to re-enqueue a change https://review.opendev.org/c/zuul/zuul/+/736772 | 16:47 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: allow a privileged user to request autohold https://review.opendev.org/c/zuul/zuul/+/768115 | 17:04 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: add Autoholds, Autohold page https://review.opendev.org/c/zuul/zuul/+/768199 | 17:06 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: REST API, Web UI: add pipelines' manager, triggers data in status https://review.opendev.org/c/zuul/zuul/+/736968 | 17:06 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to promote a change https://review.opendev.org/c/zuul/zuul/+/781858 | 17:06 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: Add "Create Autohold Request" form, improve API error messages https://review.opendev.org/c/zuul/zuul/+/802559 | 17:06 |
| opendevreview | Merged zuul/zuul master: Remove noop builds from builds list https://review.opendev.org/c/zuul/zuul/+/804831 | 17:42 |
| clarkb | pabelanger[m]: fwiw mitogen apparently also avoids the python forks. I didn't realize that so it would likely help us | 18:04 |
| opendevreview | Ian Wienand proposed zuul/zuul master: web: JobVariant : use wide layout for DescriptionList https://review.opendev.org/c/zuul/zuul/+/804602 | 19:13 |
| pabelanger[m] | clarkb: yah, I was going to push up a change to have you test. It did make a big impact for us | 19:34 |
| pabelanger[m] | For console streaming, what do people think of adding some sort of job runtime field to the header on the console: https://dashboard.zuul.ansible.com/t/ansible/stream/bef5e502659144f8a9eff983d649d18e?logfile=console.log | 19:35 |
| pabelanger[m] | I often try to figure out how long a test has been running via console.log but need to do math :) | 19:36 |
| clarkb | pabelanger[m]: a chagne should be self testing and that would be much appreciated if you are willing | 20:02 |
| *** dviroel|ruck is now known as dviroel|ruck|out | 21:15 | |
| corvus | clarkb, tristanC: https://review.opendev.org/804462 looks like it's ready to go and should unblock the rest of the operator changes | 21:54 |
| corvus | i think the current master of zuul is a good place for a .1 release | 21:55 |
| fungi | seems so | 21:59 |
| fungi | my stale project config situation from earlier looks like it's not a cache bug, at least | 22:00 |
| corvus | opendev restart on current master is done; if this looks good, i'll plan on tagging a .1 tomorrow | 22:21 |
| TylerPearce[m] | Hello again! Where can I overwrite the base url Zuul uses when commenting on a PR? Right now the comment uses the base URL "localhost:9000" but I need to point that to my EC2 instance. I tried searching the wiki but couldn't find the rights docs 😅 | 22:40 |
| * TylerPearce[m] uploaded an image: (39KiB) < https://matrix.org/_matrix/media/r0/download/matrix.org/TwBdUCILjdrDfUywhUhZQkWR/image.png > | 22:41 | |
| clarkb | TylerPearce[m]: in your zuul.conf there is a [web] section and that has root and status_url options I believe those control that | 22:43 |
| TylerPearce[m] | Awesome, thank you! | 22:44 |
| pabelanger[m] | https://zuul-ci.org/docs/zuul/discussion/components.html#attr-web.root | 22:44 |
| pabelanger[m] | I believe that is it | 22:44 |
| clarkb | pabelanger[m]: thanks I was trying to look that up | 22:45 |
| TylerPearce[m] | Ahh yes, thank you for the link! | 22:45 |
| pabelanger[m] | clarkb: I pushed up mitogen change, which server is opendev on now? | 22:45 |
| pabelanger[m] | for #opendev irc channel I mean | 22:46 |
| clarkb | pabelanger[m]: oftc #opendev | 22:46 |
| pabelanger[m] | tyty | 22:46 |
| clarkb | corvus: have you had a chance to look at https://review.opendev.org/c/zuul/zuul/+/804456 for the sqlaclhemy 2.0 prep yet? | 23:02 |
| clarkb | landing that after the .1 may make sense then we can run it through its paces before the next release | 23:02 |
| corvus | clarkb: LGTM, also I want to merge the sigterm change after .1 | 23:12 |
| opendevreview | Clark Boylan proposed zuul/zuul master: Retry gerrit queryChange() https://review.opendev.org/c/zuul/zuul/+/804929 | 23:18 |
| clarkb | corvus: fungi ^ thats a quick first stab at retrying the change queries | 23:19 |
| corvus | clarkb: bare exception | 23:20 |
| clarkb | corvus: ya We know what the http exception is but do you know what the ssh connection would raise in that case? | 23:20 |
| clarkb | corvus: or do you think it would be ok to catch Exception there? | 23:23 |
| corvus | Exception | 23:25 |
| corvus | There's a linter rule about "except" | 23:26 |
| clarkb | corvus: ok I think paramiko.ssh_exception.NoValidConnectionsError might be what ssh raises. Would you prefer Exception or paramiko.ssh_exception.NoValidConnectionsError and requests.exceptions.ConnectionError? | 23:27 |
| corvus | Exception | 23:27 |
| clarkb | ok | 23:27 |
| corvus | sorry, wasn't trying to make this complicated | 23:27 |
| corvus | just "except:" isn't going to pass linting; needs to be "except Exception:" | 23:28 |
| corvus | i'm strongly in favor of "except Exception:" for most error handling like this :) | 23:28 |
| opendevreview | Clark Boylan proposed zuul/zuul master: Retry gerrit queryChange() https://review.opendev.org/c/zuul/zuul/+/804929 | 23:28 |
| corvus | tristanC: re sigterm, it looks like people like the zuul.conf followup at https://review.opendev.org/804464 -- if you don't object, i'll approve both after the release tomorrow. just wanted to ping you since you +2d the parent. | 23:32 |
| opendevreview | Merged zuul/zuul-operator master: Fix wait for scheduler to settle in tests https://review.opendev.org/c/zuul/zuul-operator/+/804462 | 23:36 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
