| *** marios is now known as marios|ruck | 05:32 | |
| *** jpena|off is now known as jpena | 07:35 | |
| *** rpittau|afk is now known as rpittau | 07:52 | |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: user login with OpenID Connect https://review.opendev.org/c/zuul/zuul/+/734082 | 08:49 |
|---|---|---|
| opendevreview | Matthieu Huin proposed zuul/zuul master: Add authentication-realm attribute to tenants https://review.opendev.org/c/zuul/zuul/+/735586 | 08:49 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to dequeue a change https://review.opendev.org/c/zuul/zuul/+/734850 | 08:49 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to re-enqueue a change https://review.opendev.org/c/zuul/zuul/+/736772 | 08:49 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: allow a privileged user to request autohold https://review.opendev.org/c/zuul/zuul/+/768115 | 08:49 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: add Autoholds, Autohold page https://review.opendev.org/c/zuul/zuul/+/768199 | 08:49 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: REST API, Web UI: add pipelines' manager, triggers data in status https://review.opendev.org/c/zuul/zuul/+/736968 | 08:49 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to promote a change https://review.opendev.org/c/zuul/zuul/+/781858 | 09:41 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Example Docker compose: keycloak integration https://review.opendev.org/c/zuul/zuul/+/769943 | 09:42 |
| *** jcapitao is now known as jcapitao_lunch | 10:41 | |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: Add "Create Autohold Request" form, improve API error messages https://review.opendev.org/c/zuul/zuul/+/802559 | 10:43 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Example Docker compose: keycloak integration https://review.opendev.org/c/zuul/zuul/+/769943 | 10:53 |
| *** jpena is now known as jpena|lunch | 11:39 | |
| *** jpena|lunch is now known as jpena | 12:32 | |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to re-enqueue a change https://review.opendev.org/c/zuul/zuul/+/736772 | 14:06 |
| erbarr | Hi, I'm trying to run a task now which is a "shell" in the job.yaml file but on zuul I'm seeing a "waiting on logger" repeating until a "[Zuul] Log stream did not terminate". I'm also not seeing any Task Summary, Artifacts, Logs, or Console. What am I missing to populate those? | 15:02 |
| fungi | erbarr: does the job include the start-zuul-console role? usually you'd add it to the pre-run playbook of your base job so that all jobs inherit that behavior | 15:03 |
| erbarr | ahh, okay, let me add that | 15:04 |
| fungi | erbarr: here's where we add it to opendev's base job, for example: https://opendev.org/opendev/base-jobs/src/branch/master/playbooks/base/pre.yaml#L25 | 15:05 |
| *** marios|ruck is now known as marios | 15:06 | |
| *** marios is now known as marios|ruck | 15:08 | |
| erbarr | thanks! | 15:09 |
| fungi | andrii_ostapenko: see #opendev, clarkb has cleaned those up now. i suspect they may have been the result of reenqueuing earlier items in those pipelines after a recent restart | 15:22 |
| andrii_ostapenko | fungi: cool, thx! | 15:22 |
| *** jpena is now known as jpena|off | 15:32 | |
| clarkb | corvus: only 2 sos changes this morning and one one of them isn't approved \o/ | 15:40 |
| clarkb | *only one isn't approved | 15:40 |
| corvus | yeah, we should make some more :) | 15:42 |
| corvus | clarkb: i see 3 changes | 15:48 |
| clarkb | oh ya the zk key management change. I don't know why gerrit shows you emrged things by default which makes the lists long and you miss open hcanges like that | 15:49 |
| clarkb | looks like that change needs to be rebased too | 15:49 |
| opendevreview | James E. Blair proposed zuul/zuul master: Stop running mypy in linters https://review.opendev.org/c/zuul/zuul/+/803602 | 15:49 |
| corvus | oh it does, i'll rebase | 15:50 |
| opendevreview | James E. Blair proposed zuul/zuul master: Add commands to export/import keys to/from ZK https://review.opendev.org/c/zuul/zuul/+/800854 | 15:51 |
| *** marios|ruck is now known as marios | 16:11 | |
| *** rpittau is now known as rpittau|afk | 16:26 | |
| *** marios is now known as marios|out | 16:39 | |
| nirmoy | I was working on bad get repo where HEAD points to an non-existing master branch. Now we changed HEAD to point to correct branch, we have no master branch for that repo. I understand zuul maintains local cache of git repos, how do I ask zuul to refresh that cache ? | 16:41 |
| clarkb | nirmoy: you should be able to simply delete the repo in the zuul merger and executor dirs /var/lib/zuul/executor-git and /var/lib/zuul/git | 16:44 |
| clarkb | zuul will reclone when it doesn't already have the repo cloned. You may want to pause zuul's processing of jobs to do that safely though | 16:44 |
| clarkb | safely meaning jobs won't fail due to intermediate states however it seems they are likely to fail anyway? | 16:45 |
| nirmoy | clarkb: Thanks! Yes jobs are failing already | 16:46 |
| clarkb | nirmoy: another option would be to do srugery in the git repos there and fix the head | 16:47 |
| clarkb | you might prefer this if the repo is very large and recloning will be a slow process | 16:47 |
| nirmoy | clarkb: ah that is even better, thanks :) | 16:49 |
| corvus | clarkb and i are tracking down a potential issue first found in #opendev | 16:51 |
| clarkb | corvus: I see if not self.last_reconfigured: <- in startCleanup | 16:51 |
| corvus | it looks like we may not be running the semaphore cleanup | 16:51 |
| clarkb | I think that may be the issue | 16:51 |
| corvus | yeah... i think maybe the solution is we don't need that anymore, but lemme think about that a minute | 16:52 |
| clarkb | corvus: we can probably confirm this by doing a thread dump and looking for a thread named 'cleanup start' normally it would go away after scheduling the apsched stuff but I think it may be spinning on that condition | 16:52 |
| corvus | clarkb: agreed | 16:52 |
| corvus | i'll do that | 16:54 |
| clarkb | ok | 16:54 |
| clarkb | don't forget to run it twice to turn off the yappi stuff (otherwise zuul gets slow) | 16:54 |
| corvus | ya | 16:55 |
| corvus | yeah, cleanup start is running | 16:56 |
| corvus | i'll work on a patch | 16:56 |
| clarkb | I suspect that condition was there before to ensure we know about all the semaphores so that when we cleanup we aren't cleaning up inappropriately? | 16:59 |
| corvus | clarkb: exactly | 16:59 |
| opendevreview | James E. Blair proposed zuul/zuul master: Fix cleanup thread not starting https://review.opendev.org/c/zuul/zuul/+/803944 | 17:00 |
| corvus | clarkb: i think we can repair opendev without a restart by essentially running that ^ from the repl | 17:01 |
| clarkb | corvus: re the comment in your change I'm not sure that we necesarily want to store that in zk as the state that matters is in the running process: eg does it know about the configs? | 17:05 |
| clarkb | corvus: maybe instead we want to set scheduler.config_loaded to true in prime()? and check that flag? | 17:05 |
| clarkb | or scheduler.primed = True. | 17:06 |
| corvus | clarkb: sorry i meant my comment to mean the other thing: instead of setting last_reconfigured to time.time() set it to whatever is in zk | 17:06 |
| corvus | any non-null vallue is sufficient | 17:06 |
| clarkb | oh I see since the actual last reconfigured time doesn't really matter | 17:06 |
| clarkb | just that we've read a config and set a flag saying we have done so | 17:06 |
| corvus | yep. and right now, it's slightly wrong from a human pov, so i'm suggesting when we're able to, we use a more human-meaningful value | 17:07 |
| clarkb | makes sense | 17:07 |
| corvus | but really, the main point of that comment was to make sure that people know about the relationship between that and the cleanup thread wait :) | 17:07 |
| corvus | so that no one just removes it without thinking of it | 17:08 |
| clarkb | ++ | 17:09 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to dequeue a change https://review.opendev.org/c/zuul/zuul/+/734850 | 17:13 |
| corvus | clarkb: aha, i think i get the issue that's causing the semaphore red herrings | 17:18 |
| opendevreview | James E. Blair proposed zuul/zuul master: Suppress spurious semaphore lock error logs https://review.opendev.org/c/zuul/zuul/+/803948 | 17:24 |
| corvus | clarkb: ^ | 17:24 |
| clarkb | looking | 17:24 |
| corvus | i think we should restart opendev after those 2 land and consider that a candidate for release | 17:51 |
| clarkb | tobiash[m]: can you review the parent of ^ https://review.opendev.org/c/zuul/zuul/+/803944/ as well if you are stillaround? | 17:52 |
| clarkb | this fixes a regression created by the most recent sos changes | 17:52 |
| clarkb | corvus: I'm tryingto catch up on https://review.opendev.org/c/zuul/zuul/+/800854 and wondering if you saw my latest comments on ps3 | 17:58 |
| clarkb | corvus: specifically the thing about --force | 17:59 |
| corvus | clarkb: i think i implemented --force | 17:59 |
| clarkb | oh I should do a diff then sorry | 17:59 |
| corvus | clarkb: latest ps is only a rebase | 18:00 |
| corvus | 3..4 is meaningful diff | 18:00 |
| clarkb | thanks | 18:00 |
| corvus | (4..5 is a rebase with a resolved merge conflict, which is why it's not a trivial rebase and didn't carry over tobiash's vote, but the merge confict was just textual proximity, no actual changes needed; i think we can consider the +2 still applies.) | 18:01 |
| clarkb | and there isn't a followon change to do the copy delete things yet? I was looking for that too and not seeing it | 18:02 |
| corvus | clarkb: i'm writing it now :) | 18:08 |
| clarkb | gerrit's diff of ps3..ps4 seems the same as base..ps4 | 18:13 |
| clarkb | I'll just review ps5 in that case :/ | 18:13 |
| corvus | really? gertty's diff is way different | 18:14 |
| clarkb | I guess it isn't compeltely the same but for a number of files it seems to be | 18:14 |
| clarkb | there must be some weird rebase thing it is trying to accomodate there? I don't understand it | 18:15 |
| clarkb | oh hrm I think I see why, it is that ps4 is sufficiently different than ps3 that its delta between base and ps3 renders similarly? | 18:15 |
| corvus | clarkb: gerrit's 3..4 diff looks correct to me | 18:16 |
| clarkb | ya I think it is correct, it is larger than I anticipated because it differs sufficiently from ps3 that it is similar to delta to base | 18:16 |
| corvus | that's possible. the tests and test fixtures are very similar. | 18:17 |
| corvus | almost everything else changed :) | 18:17 |
| opendevreview | James E. Blair proposed zuul/zuul master: Add copy-keys and delete-keys zuul client commands https://review.opendev.org/c/zuul/zuul/+/803973 | 18:32 |
| corvus | clarkb: there ya are | 18:32 |
| clarkb | thanks, sorry got distracted but I'm trying to do those reviews | 18:33 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to re-enqueue a change https://review.opendev.org/c/zuul/zuul/+/736772 | 20:02 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: allow a privileged user to request autohold https://review.opendev.org/c/zuul/zuul/+/768115 | 20:02 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: add Autoholds, Autohold page https://review.opendev.org/c/zuul/zuul/+/768199 | 20:02 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: REST API, Web UI: add pipelines' manager, triggers data in status https://review.opendev.org/c/zuul/zuul/+/736968 | 20:02 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to promote a change https://review.opendev.org/c/zuul/zuul/+/781858 | 20:02 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: Add "Create Autohold Request" form, improve API error messages https://review.opendev.org/c/zuul/zuul/+/802559 | 20:02 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Example Docker compose: keycloak integration https://review.opendev.org/c/zuul/zuul/+/769943 | 20:02 |
| *** dviroel is now known as dviroel|brb | 20:06 | |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: user login with OpenID Connect https://review.opendev.org/c/zuul/zuul/+/734082 | 20:42 |
| opendevreview | James E. Blair proposed zuul/zuul master: DNM: Add script to pre-populate private keys https://review.opendev.org/c/zuul/zuul/+/803991 | 20:43 |
| clarkb | corvus: making sure I'm reading these changes properly. The lastest import/export code dumps everything to a single json file and imports from a single json file? | 20:44 |
| corvus | clarkb: correct | 20:45 |
| clarkb | thanks for confirming | 20:46 |
| corvus | so if you want to do surgery, you need to use a json parser. but hopefully copy-keys and delete-keys reduces the need for surgery | 20:46 |
| clarkb | ++ I did leave a comment about some test asserts that might be worth a followup but +2'd | 20:47 |
| clarkb | looks like the copy and delete stuff failed testing fwiw | 20:47 |
| *** dviroel|brb is now known as dviroel | 20:50 | |
| corvus | probably some white-box tests that need updating for the refactor | 20:53 |
| corvus | clarkb: re you comment i think we should delete the entire test file because it's covered by testv3.TestProjectKeys.testkey_generation -- does that work for you? | 20:56 |
| clarkb | corvus: I'll look shortly, finishing up revie wof copy and delete. I think I found one issue that may be making tests unhappy | 20:57 |
| clarkb | corvus: ok those comments have been posted | 21:01 |
| clarkb | corvus: yes I think removing that test in favor of test_key_generation is fine if we don't care about the specific key contents being reliably read back which seems to be the only thing different happening in the to be deleted test? | 21:06 |
| corvus | clarkb: i think other tests verify that the loaded secrets are actually the fixtures (any test that actually has an encrypted secret) | 21:09 |
| clarkb | ah good point | 21:10 |
| clarkb | since they wouldn't decrypt otherwise | 21:10 |
| opendevreview | James E. Blair proposed zuul/zuul master: Add copy-keys and delete-keys zuul client commands https://review.opendev.org/c/zuul/zuul/+/803973 | 21:10 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to re-enqueue a change https://review.opendev.org/c/zuul/zuul/+/736772 | 21:19 |
| clarkb | corvus: one additional thought on those backups: do we need to make them 0600? Or are we happy with the fact they are still covered by the encryption key? | 21:21 |
| corvus | clarkb: seems like 0600 would be good | 21:26 |
| opendevreview | Merged zuul/zuul master: Fix cleanup thread not starting https://review.opendev.org/c/zuul/zuul/+/803944 | 21:27 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Add authentication-realm attribute to tenants https://review.opendev.org/c/zuul/zuul/+/735586 | 21:29 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to dequeue a change https://review.opendev.org/c/zuul/zuul/+/734850 | 21:29 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to re-enqueue a change https://review.opendev.org/c/zuul/zuul/+/736772 | 21:30 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: allow a privileged user to request autohold https://review.opendev.org/c/zuul/zuul/+/768115 | 21:32 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: add Autoholds, Autohold page https://review.opendev.org/c/zuul/zuul/+/768199 | 21:32 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: REST API, Web UI: add pipelines' manager, triggers data in status https://review.opendev.org/c/zuul/zuul/+/736968 | 21:32 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to promote a change https://review.opendev.org/c/zuul/zuul/+/781858 | 21:32 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Web UI: Add "Create Autohold Request" form, improve API error messages https://review.opendev.org/c/zuul/zuul/+/802559 | 21:32 |
| opendevreview | Matthieu Huin proposed zuul/zuul master: Example Docker compose: keycloak integration https://review.opendev.org/c/zuul/zuul/+/769943 | 21:32 |
| *** dviroel is now known as dviroel|out | 21:47 | |
| opendevreview | James E. Blair proposed zuul/zuul master: Fix race in test_lost_merge_requests https://review.opendev.org/c/zuul/zuul/+/803850 | 22:03 |
| corvus | clarkb, tobiash: ^ that hit the test race it was aiming to fix, but i think i was able to find the underlying issue now | 22:04 |
| opendevreview | James E. Blair proposed zuul/zuul master: Join the scheduler thread before stopping the zk client https://review.opendev.org/c/zuul/zuul/+/803851 | 22:04 |
| clarkb | corvus: small thing on that bug fix but I +2'd anyway | 22:08 |
| opendevreview | James E. Blair proposed zuul/zuul master: Add commands to export/import keys to/from ZK https://review.opendev.org/c/zuul/zuul/+/800854 | 22:10 |
| corvus | clarkb: ack; i'll fix it | 22:11 |
| opendevreview | James E. Blair proposed zuul/zuul master: Fix race in test_lost_merge_requests https://review.opendev.org/c/zuul/zuul/+/803850 | 22:12 |
| opendevreview | James E. Blair proposed zuul/zuul master: Join the scheduler thread before stopping the zk client https://review.opendev.org/c/zuul/zuul/+/803851 | 22:12 |
| opendevreview | James E. Blair proposed zuul/zuul master: Add copy-keys and delete-keys zuul client commands https://review.opendev.org/c/zuul/zuul/+/803973 | 22:12 |
| corvus | okay, i think that set is stable now :) | 22:13 |
| pabelanger[m] | unrelated to zuul, could someone recommend where best to ask questions for PBR? I am down the rabbit hole of git describe tags and multiple branches, and trying to understand more how it all works | 22:20 |
| fungi | pabelanger[m]: officially, #openstack-oslo (that's the team overseeing reviews/approvals for the codebase) | 22:22 |
| fungi | pabelanger[m]: unofficially, a lot also gets discussed in #openstack-infra | 22:22 |
| fungi | ping me in either channel and i can try to help | 22:22 |
| fungi | it does also have documentation, though it's not as comprehensive as it could be (but really, when is documentation ever as comprehensive as it *could* be?) | 22:24 |
| fungi | oh, and you can ask on the openstack-discuss@lists.openstack.org mailing list too if you prefer | 22:25 |
| pabelanger[m] | thanks, I'll post something into infra tomorrow for some help | 22:34 |
| pabelanger[m] | trying to figure out how to handle stable / main properly | 22:34 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!