Friday, 2021-08-06

*** marios is now known as marios|ruck05:20
opendevreviewMerged zuul/zuul-jobs master: Fix install podman error on Ubuntu aarch64 Bionic  https://review.opendev.org/c/zuul/zuul-jobs/+/80341305:31
*** bhavikdbavishi1 is now known as bhavikdbavishi06:13
*** jpena|off is now known as jpena07:36
*** jcapitao is now known as jcapitao_lunch10:34
opendevreviewMatthieu Huin proposed zuul/zuul master: web UI: user login with OpenID Connect  https://review.opendev.org/c/zuul/zuul/+/73408210:39
opendevreviewMatthieu Huin proposed zuul/zuul master: Add authentication-realm attribute to tenants  https://review.opendev.org/c/zuul/zuul/+/73558610:39
opendevreviewMatthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to dequeue a change  https://review.opendev.org/c/zuul/zuul/+/73485010:39
tobias-urdinis it possible to in a zuul run execute a ansible task that reboots the node, waits for the node to come back up, then continue executing?11:00
avass[m]tobias-urdin: yeah there's a `reboot` module in Ansible11:01
avass[m]tobias-urdin: https://docs.ansible.com/ansible/latest/collections/ansible/builtin/reboot_module.html11:02
tobias-urdinavass[m]: yeah, but i'm more wondering on how zuul will behave since i assume i might need to start for example the zuul_console log streamer on the node again etc.11:07
avass[m]I thinking it's enough to just rerun the start-zuul-console role again after the reboot (or whatever the role is called)11:08
*** jpena is now known as jpena|lunch11:26
opendevreviewSorin Sbârnea proposed zuul/zuul-jobs master: Include podman installation with molecule  https://review.opendev.org/c/zuul/zuul-jobs/+/80347111:39
fungitobias-urdin: avass[m]: https://zuul-ci.org/docs/zuul-jobs/general-roles.html#role-start-zuul-console11:40
fungitobias-urdin: here's an example including it in another role along with a rebooot: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/enable-fips/tasks/main.yaml11:44
fungi(you can skim to the end of that file)11:44
tobias-urdinthank you both :)11:58
opendevreviewSorin Sbârnea proposed zuul/zuul-jobs master: Include podman installation with molecule  https://review.opendev.org/c/zuul/zuul-jobs/+/80347112:17
*** jcapitao_lunch is now known as jcapitao12:20
opendevreviewSorin Sbârnea proposed zuul/zuul-jobs master: Include podman installation with molecule  https://review.opendev.org/c/zuul/zuul-jobs/+/80347112:24
*** jpena|lunch is now known as jpena12:31
opendevreviewJames E. Blair proposed zuul/zuul master: Fix race in component registry  https://review.opendev.org/c/zuul/zuul/+/80376014:26
corvuszuul-maint: ^ that's our #1 test race (turns out it's a real race); that should save us much grief14:26
*** rpittau is now known as rpittau|afk14:43
*** jpena is now known as jpena|off15:34
opendevreviewMatthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to re-enqueue a change  https://review.opendev.org/c/zuul/zuul/+/73677215:43
*** marios|ruck is now known as marios|out15:59
opendevreviewTobias Henkel proposed zuul/zuul master: DNM: Try out pyston  https://review.opendev.org/c/zuul/zuul/+/80378116:05
clarkbtobiash[m]: re ^ it will be interesting to see how much of the unittest slowness is io vs python16:17
opendevreviewTobias Henkel proposed zuul/zuul master: DNM: Try pyston in the docker images  https://review.opendev.org/c/zuul/zuul/+/80378216:18
tobiash[m]yeah16:18
opendevreviewTobias Henkel proposed zuul/zuul master: DNM: Try pyston in the docker images  https://review.opendev.org/c/zuul/zuul/+/80378216:19
clarkbcorvus: ok, the refactor merger and executor api chagne is next up on my list. I feel like the brain isn't quite awake enough for that yet, but I intend on getting to it soon16:21
opendevreviewTobias Henkel proposed zuul/zuul master: DNM: Try out pyston  https://review.opendev.org/c/zuul/zuul/+/80378116:22
opendevreviewJames E. Blair proposed zuul/zuul master: DNM: review companion for merger/executor api refactor  https://review.opendev.org/c/zuul/zuul/+/80378416:28
corvusclarkb: thanks -- ^ in case it helps, that shows the main diff you can't see in the refactor change because of the file moves.16:29
clarkboh thanks that looks helpful16:31
opendevreviewMatthieu Huin proposed zuul/zuul master: Web UI: allow a privileged user to request autohold  https://review.opendev.org/c/zuul/zuul/+/76811516:32
opendevreviewTobias Henkel proposed zuul/zuul master: DNM: Try pyston in the docker images  https://review.opendev.org/c/zuul/zuul/+/80378216:36
clarkbcorvus: the consumption side of the api all seems to have had minimal updates which is a good sign17:00
corvusyeah, if you strip out the s/merge// and s/build// lines it's a lot smaller :)17:01
corvusthe biggest structural usage change is probably in the zone handling17:01
nirmoycorvus: is there any other way to find out why zuul isn't starting hourly pipeline trigger without  -d option in scheduler ? I can queue a change in the hourly pipeline queue using "kubectl exec  -n zuul scheduler -it -- zuul enqueue --tenant <tenant_name >--project <project_name>  --pipeline periodic-hourly --change <change,patchset>"17:02
clarkbcorvus: ya the merger api basically goes away and relies on the parent which is also a good sign17:04
corvusnirmoy: not that i can think offhand; that's where i would start.17:04
corvusnirmoy: changes don't get enqueued into periodic pipelines, only heads17:06
corvus(ie, branches)17:06
funginirmoy: it's easier with code review triggered builds because you can ask zuul to provide a debug report in a change comment explaining why it did or didn't do certain things, but for timer triggers there's no obvious place to dump that information so it's basically just the global debug logging17:06
corvusnirmoy: so that enqueue command is not equivalent to what zuul would do.17:06
opendevreviewMatthieu Huin proposed zuul/zuul master: Web UI: add Autoholds, Autohold page  https://review.opendev.org/c/zuul/zuul/+/76819917:08
corvusnirmoy: enqueue-ref with --ref and --oldrev and --newrev would be the equivalent command17:12
nirmoycorvus: thanks let me try that. I just realized that I am actually working on a git repo without a master branch. I will also try to change project.default-branch17:13
nirmoyfungi: true, global debug seems like last resort if nothing works. 17:14
fungiyeah, unfortunately if you have a very busy zuul install it can be overwhelmingly verbose17:15
fungiand if you're not the service administrator you won't have access to those logs either17:15
nirmoyfungi: same, I already messed up something while debugging this yesterday and had to restart some services. I am trying to be more careful now :)  17:22
opendevreviewMerged zuul/zuul master: Fix race in component registry  https://review.opendev.org/c/zuul/zuul/+/80376017:28
nirmoycorvus: enqueue-ref  worked and queued the job that I assigned for that  project in hourly pipeline 17:34
opendevreviewMatthieu Huin proposed zuul/zuul master: REST API, Web UI: add pipelines' manager, triggers data in status  https://review.opendev.org/c/zuul/zuul/+/73696817:34
nirmoythe hourly pipeline trigger looks like https://pastebin.com/aMWjLDQB17:40
opendevreviewMatthieu Huin proposed zuul/zuul master: REST API, Web UI: add pipelines' manager, triggers data in status  https://review.opendev.org/c/zuul/zuul/+/73696817:45
clarkbcorvus: I have +2'd https://review.opendev.org/c/zuul/zuul/+/803529 but did leave some comments/questions/nits if you want to take a look17:54
corvusclarkb: thanks! replied18:32
clarkboh thats weird new gerrit allows you to reply within comment threads now18:36
clarkbI was trying to ack my comments to mark them resolfed and instaed of going at the end of the comment thread like old gerrit it went between yours and mine. Anyway all your comments make sense to me. I left the one about the override comment in there in case anyone felt strongly about it though18:37
opendevreviewClark Boylan proposed zuul/zuul master: DNM: Try out pyston  https://review.opendev.org/c/zuul/zuul/+/80378118:47
clarkbtobiash[m]: ^ pyston needs wheels rebuilt for it so we need things like libpq-dev for postgres bindings and rust for cryptography builds18:47
corvusclarkb: does that mean we would need to use pyston in the builder image for docker builds?18:50
fungiwe might ought to list those as build requirements anyway18:50
corvusi wasn't sure if it did its magic at runtime, or also needed to be used for .pyc?18:51
Clark[m]Looks like we would yes18:53
tobiash[m]corvus: regarding the merge result, when we have the pipeline state in zk I think it might make sense to put the repo state then directly to the buildset instead of doing multiple copies via the event queue to get it there19:09
tobiash[m](let the merger directly put it there)19:10
opendevreviewTobias Henkel proposed zuul/zuul master: Align Executor API test helper methods with Merger API  https://review.opendev.org/c/zuul/zuul/+/80230019:15
corvustobiash: wfm -- we were already planning (discussed in a comment on the executor api changes) to have the executor read it from that single location; it also makes sense for the merger to write it only once.  but i think that it would only be one extra read/write, which isn't terrible.  so maybe we could make that as a standalone followup change.19:19
tobiash[m]sure, a standalone change makes perfect sense and we're not there yet anyway19:20
tobiash[m]Clark: thanks for fixing :)19:21
tristanCtobiash[m]: when you have a moment, could you please have a look at this multiple github app support fix: https://review.opendev.org/c/zuul/zuul/+/80365219:26
tobiash[m]tristanC: q on that ^19:33
tristanCtobiash[m]: thanks, i replied19:38
tobiash[m]corvus: is it on purpose that the keystorage is under /keystorage and not under /zuul/keystorage in zk?19:39
corvustobiash: tbh, that came as a bit of a surprise to me.  i am wondering if we should move it, or if we should keep it there to make operations like "delete all of the ephemeral state" easier.  my guess is that may be why swest (i think?) put it there.  either that or it was an accident.  :)19:42
corvus(to elaborate: if we keep it separate then "rm -fr /zuul" is a relatively safe operation)19:43
corvus(if we combine them, then "delete all the ephemeral state" has to be implemented as: delete everything under /zuul except /zuul/keystore)19:44
corvusdefinitely doable, not as convenient19:44
swestcorvus tobiash : I think the keystore was the first thing I implemented and we didn't have the /zuul namespace yet. I guess that counts as accident19:47
tobiash[m]corvus: is 771463 ready to go or do you like to have more reviews on that?20:08
corvustobiash: i think it's ready to go.  and if we merge it, i'm totally going to do an open restart today :)20:10
corvuss/open/opendev/20:12
*** dviroel is now known as dviroel|out20:23
opendevreviewMerged zuul/zuul master: Add MergerApi  https://review.opendev.org/c/zuul/zuul/+/78768620:27
opendevreviewMerged zuul/zuul master: Remove deprecated DataWatch extra args  https://review.opendev.org/c/zuul/zuul/+/80268920:41
opendevreviewMerged zuul/zuul-jobs master: Remove success-url  https://review.opendev.org/c/zuul/zuul-jobs/+/80297420:53
opendevreviewMerged zuul/zuul master: Store runtime related system attributes together  https://review.opendev.org/c/zuul/zuul/+/80174920:59
opendevreviewMerged zuul/zuul master: Cache system config in Zookeeper  https://review.opendev.org/c/zuul/zuul/+/80185921:07
opendevreviewMerged zuul/zuul master: Support cross scheduler config loading  https://review.opendev.org/c/zuul/zuul/+/77146321:24
opendevreviewMerged zuul/zuul master: Display branch of queue in status page  https://review.opendev.org/c/zuul/zuul/+/77761322:14
opendevreviewMerged zuul/zuul master: Fix support for multiple github connection  https://review.opendev.org/c/zuul/zuul/+/80365222:17
opendevreviewMerged zuul/zuul master: Fix test_gerrit.TestPolling.test_config_update  https://review.opendev.org/c/zuul/zuul/+/77302322:17
pabelanger[m]Hmm, just noticed this today from zuul-executor22:27
pabelanger[m]2021-08-06 22:20:11,561 DEBUG zuul.AnsibleJob.output: [e: 6bedebe0-f6ff-11eb-9fd6-86beb1283741] [build: 1fbd92453a5d482c8018ed6e4bc59d63] Ansible output: b'fatal: [vyos-1.1.8]: FAILED! => {"msg": "Unable to automatically determine host network os. Please manually configure ansible_network_os value for this host"}'22:27
pabelanger[m]that's trying to get the frozen facts before the job runs22:28
pabelanger[m]actually, could just be me22:38
opendevreviewJames E. Blair proposed zuul/zuul master: Execute merge jobs via ZooKeeper  https://review.opendev.org/c/zuul/zuul/+/80229922:40
opendevreviewJames E. Blair proposed zuul/zuul master: Refactor Merger/Executor API  https://review.opendev.org/c/zuul/zuul/+/80352922:41
opendevreviewJames E. Blair proposed zuul/zuul master: Streamline unlocking in merger and builder run loops  https://review.opendev.org/c/zuul/zuul/+/80365722:41
opendevreviewJames E. Blair proposed zuul/zuul master: Align Executor API test helper methods with Merger API  https://review.opendev.org/c/zuul/zuul/+/80230022:41
corvusthe merger and config stacks collided, and so those changes failed gating (yay gating!)  but the collision was trivial, so i've gone ahead and fixed it and will just re-approve those22:41
corvus(the name of the cat job changed from "merger:cat" to "cat")22:42
corvus(and the config changes added a new test that looked for 'merger:cat')22:42
opendevreviewMerged zuul/zuul master: [doc] Clarify how regexp matching works  https://review.opendev.org/c/zuul/zuul/+/79498723:20
opendevreviewJames E. Blair proposed zuul/zuul master: Update regex note  https://review.opendev.org/c/zuul/zuul/+/80381123:40
corvusfungi, tobiash: fungi had some good suggestions on that ^23:40
opendevreviewJames E. Blair proposed zuul/zuul master: Update regex note  https://review.opendev.org/c/zuul/zuul/+/80381123:41
corvusnow with missing letters added23:41
opendevreviewJames E. Blair proposed zuul/zuul master: Update regex note  https://review.opendev.org/c/zuul/zuul/+/80381123:44
opendevreviewMerged zuul/zuul master: Execute merge jobs via ZooKeeper  https://review.opendev.org/c/zuul/zuul/+/80229923:45

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!