| clarkb | corvus: I left some comments on https://review.opendev.org/c/zuul/zuul/+/797440/12 (note that is not hte current ps because you pushed updates while I was reviewing) | 00:05 |
|---|---|---|
| corvus | clarkb: when you say "we split them out here into two different queues" what do you mean? | 00:11 |
| clarkb | corvus: we have the TenantManagementQueue object and the TenantEventQueue object. They both ultimtaely source from a single actual queue in the database | 00:12 |
| corvus | ah, thx | 00:12 |
| clarkb | but we change the prefix on the db entries depending on which queue we want stuff to go in reather than changing the queue praent node | 00:12 |
| clarkb | I just noticed it was a bit odd way of constructing a queue but I'm guessing it simplifies watching? | 00:12 |
| corvus | clarkb: good q. that may be it -- but i'm getting a bit EOD for that (and also the statsd q), so let's ask swest to take a look at your questions on https://review.opendev.org/797440 tomorrow | 00:16 |
| corvus | clarkb: (i did answer the one about the function sig) | 00:16 |
| clarkb | thanks and ya I don't think any of those are super urgent | 00:16 |
| corvus | felixedel, tobiash: and if you could look at https://review.opendev.org/798966 please, that would be great | 00:17 |
| clarkb | also note my comments on 797440 are on patchset 12 (gerrit renders that a bit oddly if you want ot see them with the context | 00:17 |
| clarkb | though I guess if you click on the link in the top level comment it takes you to the code page | 00:18 |
| opendevreview | Merged zuul/zuul master: Only call one build callback in executor api https://review.opendev.org/c/zuul/zuul/+/798750 | 00:33 |
| opendevreview | Merged zuul/zuul master: Remove exception handling in executor api isLocked https://review.opendev.org/c/zuul/zuul/+/798751 | 00:34 |
| opendevreview | Merged zuul/zuul master: Execute builds via ZooKeeper https://review.opendev.org/c/zuul/zuul/+/788988 | 00:34 |
| opendevreview | Merged zuul/zuul master: Move build request cleanup from executor to scheduler https://review.opendev.org/c/zuul/zuul/+/794687 | 00:35 |
| opendevreview | Merged zuul/zuul master: Handle errors in the executor main loop https://review.opendev.org/c/zuul/zuul/+/796583 | 00:35 |
| opendevreview | Merged zuul/zuul master: Shard BuildRequest parameters https://review.opendev.org/c/zuul/zuul/+/797149 | 01:52 |
| opendevreview | Merged zuul/zuul master: Compress sharded ZK data https://review.opendev.org/c/zuul/zuul/+/797156 | 02:00 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: Add introduction to the container jobs documentation https://review.opendev.org/c/zuul/zuul-jobs/+/798969 | 04:53 |
| *** bhagyashris is now known as bhagyashris|ruck | 05:22 | |
| *** chandankumar is now known as chkumar|rover | 05:31 | |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Simplify queue traversal of fileschangescompletedevent processing https://review.opendev.org/c/zuul/zuul/+/798966 | 05:45 |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Switch from global to tenant event queues https://review.opendev.org/c/zuul/zuul/+/797440 | 05:45 |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Remove unused addResultEvent method https://review.opendev.org/c/zuul/zuul/+/797542 | 05:45 |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Lock/unlock nodes on executor server https://review.opendev.org/c/zuul/zuul/+/774610 | 05:46 |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Remove ExecutorApi.update() call from tests https://review.opendev.org/c/zuul/zuul/+/798778 | 05:47 |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Add some jitter to apscheduler interval cleanup jobs https://review.opendev.org/c/zuul/zuul/+/798953 | 05:47 |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Add comment for test method https://review.opendev.org/c/zuul/zuul/+/798954 | 05:47 |
| swest | clarkb: corvus: responded to questions in 797440. let me know if you think we should change the statsd metric | 07:05 |
| *** jpena|off is now known as jpena | 07:34 | |
| avass[m] | Apparently `nodepool config-validate` doesn't error when a provider uses a label that hasn't been defined | 07:50 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: Add introduction to the container jobs documentation https://review.opendev.org/c/zuul/zuul-jobs/+/798969 | 08:27 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: Add introduction to the container jobs documentation https://review.opendev.org/c/zuul/zuul-jobs/+/798969 | 08:31 |
| opendevreview | Ian Wienand proposed zuul/zuul-jobs master: Add introduction to the container jobs documentation https://review.opendev.org/c/zuul/zuul-jobs/+/798969 | 08:51 |
| *** sshnaidm is now known as sshnaidm|afk | 09:24 | |
| sean-k-mooney | o/ am where are the corresponding setting in Nodepool for ansible_python_interperter | 10:31 |
| sean-k-mooney | https://zuul-ci.org/docs/zuul/reference/releasenotes.html#security-issues | 10:31 |
| sean-k-mooney | i dont see them here https://zuul-ci.org/docs/nodepool/openstack.html | 10:32 |
| sean-k-mooney | i assumned it was a per label thing? | 10:32 |
| sean-k-mooney | oh | 10:32 |
| sean-k-mooney | https://zuul-ci.org/docs/nodepool/configuration.html#attr-diskimages.python-path | 10:32 |
| sean-k-mooney | does that also work with cloud images | 10:35 |
| sean-k-mooney | yes https://zuul-ci.org/docs/nodepool/openstack.html#attr-providers.[openstack].cloud-images.python-path | 10:36 |
| avass[m] | sean-k-mooney: you're welcome ;) | 10:37 |
| sean-k-mooney | :) | 10:38 |
| sean-k-mooney | if i can answer my own question im always happy too but somethimes it nice to "say them out loud" as it were | 10:38 |
| sean-k-mooney | downstream we have osp 13 still suported on python 2 so we will need to update those jobs with this fortunetly they also use a different image rhel7 to our python 3 jobs on rhel8 | 10:40 |
| *** sshnaidm|afk is now known as sshnaidm | 10:47 | |
| tobiash[m] | I like rubber duck debugging :) | 10:59 |
| *** jpena is now known as jpena|lunch | 11:47 | |
| sean-k-mooney | tobiash[m]: i have one on my desk. it an xray duck. one of my coworkers got an alpabet set of debugging ducks somewhere | 11:49 |
| opendevreview | Tobias Henkel proposed zuul/nodepool master: Allow empty string in leaked port cleanup https://review.opendev.org/c/zuul/nodepool/+/799046 | 12:36 |
| tobiash[m] | zuul-maint: we just ran into port shortage and found out that the port cleanup in nodepool didn't work for all leaked ports. This should fix that ^ | 12:37 |
| *** jpena|lunch is now known as jpena | 12:45 | |
| *** corvus is now known as Guest1170 | 13:12 | |
| *** marios is now known as marios|call | 13:26 | |
| clarkb | tobiash[m]: do you also see ports with None? I wonder if that was an api change in the sdk | 14:24 |
| tobiash[m] | clarkb: not in our cloud | 14:24 |
| clarkb | ya wouldn't surprise me if None became '' in that case | 14:24 |
| tobiash[m] | so I could imagine that there was either an api change in the sdk or this change never worked | 14:24 |
| tobiash[m] | s/change/check | 14:25 |
| tobiash[m] | or it could be even related to the openstack api version of the cloud | 14:26 |
| clarkb | yup | 14:26 |
| clarkb | swest: 797440 lgtm, thanks | 14:27 |
| clarkb | I have one more large change near the end of that stack to review then I'm through the set. I'll try to get to that this morning | 14:28 |
| *** Guest1170 is now known as corvus | 14:54 | |
| *** corvus is now known as Guest1175 | 14:55 | |
| *** Guest1175 is now known as corvus | 14:57 | |
| *** corvus is now known as jeblair | 14:58 | |
| *** jeblair is now known as corvus | 14:58 | |
| *** marios|call is now known as marios | 15:26 | |
| *** sshnaidm is now known as sshnaidm|afk | 15:46 | |
| *** marios is now known as marios|afk | 16:12 | |
| *** marios|afk is now known as marios|bosu | 16:22 | |
| *** marios|bosu is now known as marios|out | 16:23 | |
| opendevreview | Merged zuul/zuul master: Switch to ZooKeeper backed merge result events https://review.opendev.org/c/zuul/zuul/+/784195 | 16:36 |
| *** jpena is now known as jpena|off | 16:36 | |
| opendevreview | Merged zuul/zuul master: Simplify queue traversal of fileschangescompletedevent processing https://review.opendev.org/c/zuul/zuul/+/798966 | 16:36 |
| opendevreview | Merged zuul/zuul master: Switch from global to tenant event queues https://review.opendev.org/c/zuul/zuul/+/797440 | 16:39 |
| opendevreview | Merged zuul/zuul master: Remove unused addResultEvent method https://review.opendev.org/c/zuul/zuul/+/797542 | 16:39 |
| clarkb | oh hey everything has merged up to the point where I haven't reviewed yet /me starts that review now | 16:57 |
| clarkb | corvus: felixedel ok I've +2'd https://review.opendev.org/c/zuul/zuul/+/774610 but had a couple of questions/comments if you have achance to take a look | 17:38 |
| clarkb | I think I'm through the stack now too | 17:38 |
| clarkb | I suspect that you can approve the stack in its state now then do any followups if my commecnts are worth following up on | 17:45 |
| clarkb | sean-k-mooney: also newer ansible is supposed to autodetect the target python version iirc | 17:50 |
| clarkb | sean-k-mooney: it may work if you drop the specification entirely | 17:50 |
| avass[m] | I'm not sure we needed to blacklist ansible_python_interpreter for non-localhost connections either | 17:51 |
| sean-k-mooney | thats what our ci folks did | 17:51 |
| sean-k-mooney | it was there for older operating systsem versions where we need to force it to by python 3 i think | 17:52 |
| clarkb | pabelanger[m]: corvus I left a thought on 798784 about how a new resource might be used to support pabelanger[m]'s specific use case | 17:59 |
| corvus | that looks like a good solution | 18:09 |
| clarkb | corvus: have you had a chance to look at my comments on https://review.opendev.org/c/zuul/zuul/+/774610 ? | 18:45 |
| clarkb | just thinking we can approve the next set of changes if we get through those | 18:45 |
| corvus | clarkb: will do after lunch | 18:46 |
| clarkb | ok | 18:46 |
| clarkb | zuulian reviewers other than corvus https://review.opendev.org/c/zuul/nodepool/+/793508/2 is an easy change to review and land | 18:50 |
| opendevreview | Merged zuul/nodepool master: Rename pip4/6 to public_ipv4 https://review.opendev.org/c/zuul/nodepool/+/793508 | 20:03 |
| corvus | clarkb: replied; i agree some fixes warranted but can proceed | 20:29 |
| corvus | i'll work on those in a bit | 20:30 |
| opendevreview | Ian Wienand proposed zuul/nodepool master: [wip] map in hwrng for builder https://review.opendev.org/c/zuul/nodepool/+/799125 | 23:25 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!