| *** marios is now known as marios|ruck | 05:23 | |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Switch from global to tenant event queues https://review.opendev.org/c/zuul/zuul/+/797440 | 05:57 |
|---|---|---|
| *** ChanServ changes topic to "Discussion of the project gating system Zuul | Website: https://zuul-ci.org/ | Docs: https://zuul-ci.org/docs/ | Source: https://opendev.org/zuul | Channel logs: https://meetings.opendev.org/irclogs/%23zuul/" | 06:52 | |
| *** jpena|off is now known as jpena | 06:56 | |
| *** rpittau|afk is now known as rpittau | 07:07 | |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Remove unused addResultEvent method https://review.opendev.org/c/zuul/zuul/+/797542 | 07:14 |
| *** bhagyashris_ is now known as bhagyashris | 08:27 | |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Switch from global to tenant event queues https://review.opendev.org/c/zuul/zuul/+/797440 | 11:15 |
| *** jpena is now known as jpena|lunch | 11:30 | |
| *** marios|ruck is now known as marios|ruck|call | 12:00 | |
| opendevreview | Felix Edel proposed zuul/zuul master: Move parent provider determination to pipeline manager https://review.opendev.org/c/zuul/zuul/+/797631 | 12:32 |
| *** jpena|lunch is now known as jpena | 12:33 | |
| *** marios|ruck|call is now known as marios|ruck | 12:47 | |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Make reporting asynchronous https://review.opendev.org/c/zuul/zuul/+/691253 | 12:47 |
| opendevreview | Pierre-Louis Bonicoli proposed zuul/zuul master: Escape raw percent in 'dburi' value https://review.opendev.org/c/zuul/zuul/+/797660 | 14:19 |
| *** marios|ruck is now known as marios|ruck|call | 14:31 | |
| opendevreview | Pierre-Louis Bonicoli proposed zuul/zuul master: zuul.lib.yamlutil: Fix TypeError exception https://review.opendev.org/c/zuul/zuul/+/797661 | 14:33 |
| opendevreview | Tobias Henkel proposed zuul/zuul master: Make reporting asynchronous https://review.opendev.org/c/zuul/zuul/+/691253 | 14:36 |
| opendevreview | Tobias Henkel proposed zuul/zuul master: Make reporting asynchronous https://review.opendev.org/c/zuul/zuul/+/691253 | 14:38 |
| *** marios|ruck|call is now known as marios|ruck | 14:51 | |
| pabelanger[m] | greetings, I am still working on upgrading our zuul to the latest version, but have a question around the SQL reporter. We are going to keep using the deprecated syntax for now, but moving forward, is a reporter connection actually needed? I am confused on how to assign a reporter to a pipeline now for success / failures | 15:12 |
| pabelanger[m] | or is that just done by default now | 15:12 |
| corvus | pabelanger: it's done by default | 15:15 |
| pabelanger[m] | thanks, do I need to worry about invalid syntax in pipeline configuration once we upgrade to 4.x? I don't see any reference to that | 15:16 |
| corvus | pabelanger: nope, no need to worry. it's just ignored now. after you upgrade, you can just remove the sql reporter from the success/failure stuff | 15:16 |
| pabelanger[m] | great, thanks | 15:17 |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Add missing attributes to to change mgmt events https://review.opendev.org/c/zuul/zuul/+/796761 | 15:17 |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Add missing attributes to change mgmt events https://review.opendev.org/c/zuul/zuul/+/796761 | 15:17 |
| opendevreview | Simon Westphahl proposed zuul/zuul master: Add missing attributes to change mgmt events https://review.opendev.org/c/zuul/zuul/+/796761 | 15:20 |
| *** marios|ruck is now known as marios|out | 15:55 | |
| *** jpena is now known as jpena|off | 16:00 | |
| opendevreview | Pierre-Louis Bonicoli proposed zuul/zuul master: Zookeeper: keep compatibility with 3.4 API https://review.opendev.org/c/zuul/zuul/+/797689 | 16:02 |
| opendevreview | Pierre-Louis Bonicoli proposed zuul/zuul master: zuul.lib.yamlutil: Fix TypeError exception https://review.opendev.org/c/zuul/zuul/+/797661 | 16:07 |
| *** rpittau is now known as rpittau|afk | 16:08 | |
| opendevreview | Pierre-Louis Bonicoli proposed zuul/zuul master: Escape raw percent in 'dburi' value https://review.opendev.org/c/zuul/zuul/+/797660 | 16:08 |
| *** sshnaidm is now known as sshnaidm|afk | 16:35 | |
| opendevreview | James E. Blair proposed zuul/zuul master: Replace TreeCache in component registry https://review.opendev.org/c/zuul/zuul/+/796582 | 16:44 |
| opendevreview | James E. Blair proposed zuul/zuul master: Add ExecutorApi https://review.opendev.org/c/zuul/zuul/+/770902 | 16:44 |
| opendevreview | James E. Blair proposed zuul/zuul master: Change zone handling in ExecutorApi https://review.opendev.org/c/zuul/zuul/+/787833 | 16:44 |
| opendevreview | James E. Blair proposed zuul/zuul master: Switch to string constants in BuildRequest https://review.opendev.org/c/zuul/zuul/+/791849 | 16:44 |
| opendevreview | James E. Blair proposed zuul/zuul master: Clean up Executor API build request locking and add tests https://review.opendev.org/c/zuul/zuul/+/788624 | 16:46 |
| opendevreview | James E. Blair proposed zuul/zuul master: Fix race with watches in ExecutorAPI https://review.opendev.org/c/zuul/zuul/+/792300 | 16:46 |
| opendevreview | James E. Blair proposed zuul/zuul master: Execute builds via ZooKeeper https://review.opendev.org/c/zuul/zuul/+/788988 | 16:46 |
| opendevreview | James E. Blair proposed zuul/zuul master: Move build request cleanup from executor to scheduler https://review.opendev.org/c/zuul/zuul/+/794687 | 16:48 |
| opendevreview | James E. Blair proposed zuul/zuul master: Handle errors in the executor main loop https://review.opendev.org/c/zuul/zuul/+/796583 | 16:48 |
| opendevreview | James E. Blair proposed zuul/zuul master: Shard BuildRequest parameters https://review.opendev.org/c/zuul/zuul/+/797149 | 16:48 |
| opendevreview | James E. Blair proposed zuul/zuul master: Compress sharded ZK data https://review.opendev.org/c/zuul/zuul/+/797156 | 16:48 |
| opendevreview | James E. Blair proposed zuul/zuul master: Switch to ZooKeeper backed merge result events https://review.opendev.org/c/zuul/zuul/+/784195 | 16:49 |
| opendevreview | James E. Blair proposed zuul/zuul master: Refactor pipeline processing in run handler https://review.opendev.org/c/zuul/zuul/+/795985 | 16:49 |
| opendevreview | James E. Blair proposed zuul/zuul master: Switch from global to tenant event queues https://review.opendev.org/c/zuul/zuul/+/797440 | 17:16 |
| corvus | swest: it looks like https://review.opendev.org/795985 should be rebased on https://review.opendev.org/c/zuul/zuul/+/797440 and will need some significant changes; i marked it WIP for now and pulled it out of the stack. | 17:17 |
| corvus | zuul-maint: all of the significant changes related to the azure driver in nodepool before and after the change that makes the switch have +2s; the actual change that makes the switch has no reviews. I'm assuming that's because it's relatively unreadable due to the nature of the switch. it's mostly file moves, but there are some test additions and small related bugfixes. should we take the positive reviews of the other implementing changes as | 17:26 |
| corvus | license to approve that one (ie, treat it as a pro-forma change that doesn't need its own review)? or would folks like to review that one as well? | 17:26 |
| corvus | https://review.opendev.org/781925 is the change in question | 17:29 |
| opendevreview | Merged zuul/nodepool master: Assign waiting static nodes by request priority https://review.opendev.org/c/zuul/nodepool/+/790674 | 18:31 |
| pabelanger[m] | I think there is a bug in latest nodepool (git) for aws driver | 18:48 |
| * pabelanger[m] < https://matrix.org/_matrix/media/r0/download/matrix.org/qESJMwuhapafDrtxxTEPMRLe/message.txt > | 18:48 | |
| pabelanger[m] | that keeps spamming the logs of my test jobs | 18:48 |
| avass[m] | I don't think we're seeing that | 18:48 |
| corvus | pabelanger: ah yep, my fault, i can fix in a few minutes. | 18:48 |
| pabelanger[m] | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_aeb/797657/1/check/windmill-src-ubuntu-bionic/aebaa18/logs/nb01/var/log/nodepool/nodepool-builder.log | 18:49 |
| corvus | lemme see if i can confirm it | 18:49 |
| pabelanger[m] | cool, thanks | 18:49 |
| corvus | yep, can repro locally | 18:51 |
| avass[m] | but mayber we're not updated enough? :) | 18:51 |
| corvus | avass: it's a refactor that's part of the azure stack; very recent | 18:51 |
| corvus | https://review.opendev.org/797357 is the fix for the static driver | 18:52 |
| corvus | (this is uncovering test gaps unfortunately) | 18:52 |
| avass[m] | oh I was working on deploying the azure driver today, maybe I should hold off on that for a bit | 18:55 |
| corvus | avass: probably so if you're also using aws | 19:01 |
| opendevreview | James E. Blair proposed zuul/nodepool master: Fix AWS driver equality check https://review.opendev.org/c/zuul/nodepool/+/797740 | 19:08 |
| corvus | zuul-maint: that's another regression fix we should urgently merge | 19:08 |
| corvus | pabelanger: in the mean time, can you use the latest release? i don't think there's anything majorly compelling in master | 19:09 |
| pabelanger[m] | yah, we are using 4.1.0 now on zuul.a.c, I only noticed this trying to bring windmill testing jobs back online | 19:11 |
| pabelanger[m] | https://review.opendev.org/c/windmill/windmill/+/797742 | 19:11 |
| corvus | great | 19:11 |
| avass[m] | speaking of nodepool, I think I'm gonna start on a kubevirt driver soon since I'm moving off digitalocean. maybe that can be done by just extending the already existing kubernetes driver. :) | 20:21 |
| fungi | avass[m]: also consider https://metal3.io/ which may have broader hardware support | 20:42 |
| avass[m] | fungi: thanks I'll take a look at that! | 20:43 |
| avass[m] | though I just got things setup and working with multus so I can use dhcp to allocate ip addresses alongside a k8s internal network | 20:43 |
| avass[m] | tristanC: working on a simple ensure-nix, do you have any good ideas how to get ~/.nix-profile/bin into path without having to add that to the environment for every single task? | 20:57 |
| corvus | avass: you can seet an environment variable at the play level | 21:04 |
| tristanC | avass[m]: how about `cp -s ~/.nix-profile/bin/nix* /bin` ? | 21:04 |
| avass[m] | tristanC: that won't really work if anything is installed after running that command | 21:05 |
| avass[m] | corvus: I think that's the best I got so far, it makes it a bit easier but then the environment has to be set for every playbook | 21:05 |
| tristanC | corvus: i think we would like the path to be available for any playbook using the role | 21:06 |
| avass[m] | but I suppose it's the same issue that ~/.local/bin has | 21:06 |
| tristanC | avass[m]: assuming the ensure-nix stops if nix is not available, it should be ok to put the current nix-profile in /bin | 21:07 |
| avass[m] | oh maybe that's possible | 21:07 |
| * avass[m] was gonna take a look at overlays | 21:08 | |
| tristanC | though you also needs to setup the NIX_SSL_CERT_FILE environment | 21:08 |
| avass[m] | yep | 21:09 |
| avass[m] | I mostly want to avoid having to run `source ~/.nix-profile/etc/profile.d/nix.sh && nix ...` everywhere | 21:10 |
| tristanC | avass[m]: could that be done by a `nix-build` role? the role could take the path of the nix file and an optional attribute to build | 21:13 |
| avass[m] | tristanC: I was thinking that it should be more general since it's possible to install packages with `nix-env -i curl` and then curl would be located in ~/.nix-profile/bin | 21:14 |
| avass[m] | corvus: I think this may be a case where we want reusable modules across repos :) | 21:14 |
| avass[m] | something like a `nix_command` | 21:14 |
| avass[m] | though if users don't know about that it doesn't really help a lot anyway | 21:15 |
| avass[m] | (in this case teh user is me however) | 21:16 |
| tristanC | avass[m]: the ensure-nix could setup a nix_enviroment fact, then user would simply need to add `environment: "{{ nix_environment }}"` to their command | 21:16 |
| avass[m] | yes but preferably one would not need to do that. what would be nice is some way to cache environment across playbooks similar to set_fact with cacheable, but something like set_env. so once it's set you don't need to think about it | 21:20 |
| tristanC | avass[m]: i don't know if that is possible with ansible | 21:21 |
| avass[m] | oh, actually. maybe it's possible to just set ansible_env ? | 21:21 |
| avass[m] | nope, ansible doesn't use it when executing tasks. | 21:23 |
| opendevreview | Merged zuul/nodepool master: Fix AWS driver equality check https://review.opendev.org/c/zuul/nodepool/+/797740 | 21:28 |
| pabelanger[m] | just upgraded to zuul 4.5.1 | 23:56 |
| pabelanger[m] | 1 issue I found | 23:56 |
| pabelanger[m] | https://zuul-ci.org/docs/zuul/discussion/components.html#attr-keystore.password seems to say only zuul schedule needs it | 23:56 |
| pabelanger[m] | but it seem zuul-executors do too | 23:56 |
| pabelanger[m] | so when we upgraded to 4.5.1, zuul-executors wouldn't start | 23:56 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!