| ianw | https://review.opendev.org/c/opendev/system-config/+/794353 i put in the queue to try and test an upstream ansible change | 00:36 |
|---|---|---|
| ianw | it appears to have caused a traceback | 00:37 |
| ianw | "2021-06-03 00:07:49,290 ERROR zuul.GithubConnection.GithubClientManager: No installation ID available for project ansible/ansible" | 00:37 |
| ianw | http://paste.openstack.org/show/806295/ | 00:37 |
| ianw | interesting, i've managed to run the graphql query and i get a status | 01:56 |
| opendevreview | Ian Wienand proposed zuul/zuul master: github driver: log graphql errors https://review.opendev.org/c/zuul/zuul/+/794371 | 04:13 |
| opendevreview | Ian Wienand proposed zuul/zuul master: github : show query response on missing fields https://review.opendev.org/c/zuul/zuul/+/794372 | 04:13 |
| opendevreview | Ian Wienand proposed zuul/zuul master: github: handle exceptions from _updateCanMergeInfo https://review.opendev.org/c/zuul/zuul/+/794393 | 04:13 |
| opendevreview | Ian Wienand proposed zuul/zuul master: github: log graphql errors https://review.opendev.org/c/zuul/zuul/+/794371 | 04:14 |
| opendevreview | Ian Wienand proposed zuul/zuul master: github: show query response on missing fields https://review.opendev.org/c/zuul/zuul/+/794372 | 04:14 |
| opendevreview | Ian Wienand proposed zuul/zuul master: github: handle exceptions from _updateCanMergeInfo https://review.opendev.org/c/zuul/zuul/+/794393 | 04:14 |
| ianw | tobiash / corvus : in summary; https://review.opendev.org/c/opendev/system-config/+/794353 appears to have triggered an issue with the github pull; details in https://storyboard.openstack.org/#!/story/2008940. ^^^ is some suggestions that i think would have perhaps dumped the query and handled the error better | 04:18 |
| ianw | however, i'm still not sure what the root cause is. i'm not going to touch it any more in case there is some live state that might be helpful to debug | 04:18 |
| *** marios has joined #zuul | 05:15 | |
| opendevreview | Ian Wienand proposed zuul/zuul master: github: show query response on missing fields https://review.opendev.org/c/zuul/zuul/+/794372 | 05:49 |
| opendevreview | Ian Wienand proposed zuul/zuul master: github: handle exceptions from _updateCanMergeInfo https://review.opendev.org/c/zuul/zuul/+/794393 | 05:49 |
| opendevreview | Niklas Borg proposed zuul/zuul-jobs master: Add properties to upload-artifactory https://review.opendev.org/c/zuul/zuul-jobs/+/789543 | 07:09 |
| *** hashar has joined #zuul | 07:17 | |
| *** jpena|off is now known as jpena | 07:20 | |
| *** tosky has joined #zuul | 07:20 | |
| *** rpittau|afk is now known as rpittau | 07:34 | |
| avass[m] | guillaumec: I also pushed an update to gitlabs docs about the protected branch api: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/62891 | 07:52 |
| mhu | hello zuul-maint, these 4 patches need one final +2 before we can release zuul-client 0.0.5 : https://review.opendev.org/q/topic:%2522builds_query%2522+status:open+label:%2522Code-Review%252B2%2522 | 08:15 |
| opendevreview | Sankar Palanivel proposed zuul/zuul-jobs master: TEST: Do not merge https://review.opendev.org/c/zuul/zuul-jobs/+/794268 | 08:30 |
| opendevreview | Sankar Palanivel proposed zuul/zuul-jobs master: TEST: Do not merge https://review.opendev.org/c/zuul/zuul-jobs/+/794268 | 09:23 |
| *** jangutter has joined #zuul | 09:48 | |
| *** jangutter_ has quit IRC | 09:55 | |
| opendevreview | Matthieu Huin proposed zuul/zuul-client master: builds API: fix queries for boolean parameters https://review.opendev.org/c/zuul/zuul-client/+/794553 | 10:00 |
| *** jangutter has quit IRC | 10:01 | |
| *** jangutter has joined #zuul | 10:01 | |
| *** jangutter has quit IRC | 10:14 | |
| *** jangutter_ has joined #zuul | 10:15 | |
| opendevreview | Matthieu Huin proposed zuul/zuul-client master: builds: fix API queries for boolean parameters, make tenant optional https://review.opendev.org/c/zuul/zuul-client/+/794553 | 10:33 |
| *** jpena is now known as jpena|lunch | 11:33 | |
| *** jpena|lunch is now known as jpena | 12:23 | |
| *** Shrews has joined #zuul | 13:56 | |
| corvus | mhu: q on 751238 | 14:04 |
| opendevreview | Merged zuul/zuul-jobs master: Add properties to upload-artifactory https://review.opendev.org/c/zuul/zuul-jobs/+/789543 | 14:05 |
| mhu | corvus: I'm not sure how to test this change. Is the console stream tested in zuul unit tests ? | 14:08 |
| corvus | mhu: it is indeed | 14:12 |
| corvus | both the fingergw and websocket paths | 14:12 |
| mhu | I'll have a look how it's done and I'll add the tests then | 14:13 |
| mhu | zuul-maint, can we merge https://review.opendev.org/c/zuul/zuul-client/+/794553 which fixes an incorrect behavior when searching builds using boolean filters (final, voting, held) | 14:26 |
| guillaumec | mhu: If it can help you, I have a small series involing console stream https://review.opendev.org/c/zuul/zuul/+/770818 | 14:26 |
| mhu | guillaumec, definitely! thanks | 14:27 |
| *** persia has joined #zuul | 14:51 | |
| *** erlon has quit IRC | 15:13 | |
| *** hashar has quit IRC | 15:20 | |
| *** hashar has joined #zuul | 15:25 | |
| opendevreview | Matthieu Huin proposed zuul/zuul-client master: Add change-status subcommand https://review.opendev.org/c/zuul/zuul-client/+/759838 | 15:29 |
| *** ironfoot has joined #zuul | 15:30 | |
| clarkb | ironfoot: welcome | 15:31 |
| opendevreview | Ade Lee proposed zuul/zuul-jobs master: Add role to enable FIPS on a node https://review.opendev.org/c/zuul/zuul-jobs/+/788778 | 15:33 |
| ironfoot | o/ | 15:38 |
| *** hashar is now known as Guest740 | 15:55 | |
| *** hashar has joined #zuul | 15:55 | |
| *** Guest740 has quit IRC | 16:02 | |
| *** marios is now known as marios|out | 16:08 | |
| *** rpittau is now known as rpittau|afk | 16:12 | |
| *** jpena is now known as jpena|off | 16:27 | |
| *** sshnaidm is now known as sshnaidm|afk | 16:32 | |
| *** marios|out has quit IRC | 16:40 | |
| *** bhavikdbavishi has joined #zuul | 16:42 | |
| *** josefwells has joined #zuul | 16:46 | |
| *** hashar has quit IRC | 17:19 | |
| *** bhavikdbavishi has quit IRC | 18:26 | |
| *** bhavikdbavishi has joined #zuul | 18:26 | |
| *** hashar has joined #zuul | 18:32 | |
| *** bhavikdbavishi has quit IRC | 18:38 | |
| *** dmsimard4 has joined #zuul | 19:14 | |
| *** dmsimard has quit IRC | 19:20 | |
| *** dmsimard4 is now known as dmsimard | 19:20 | |
| *** Shrews has quit IRC | 19:30 | |
| *** hashar has quit IRC | 19:47 | |
| *** hashar has joined #zuul | 20:34 | |
| *** hashar has quit IRC | 20:41 | |
| *** swest has quit IRC | 20:47 | |
| *** swest has joined #zuul | 20:48 | |
| ianw | corvus: not sure if you had any thoughts on 794353 not making it to the gate with github pull issues? http://eavesdrop.openstack.org/irclogs/%23zuul/%23zuul.2021-06-03.log.html#t2021-06-03T04:18:17 | 21:49 |
| corvus | ianw: not off the top of my head; i'm not super familiar with that | 21:52 |
| ianw | np. i did manage to replay the graphql query with my own token, and it returned something that looked like it could be parsed. i imagine it's something to do with however opendev zuul is authenticating | 22:00 |
| ianw | actually, i guess *i* should be able to replay the graphql query as zuul using the token on zuul02. that might give a clue as to the error. i didn't think of that ... will try and see if that enlightens anything | 22:01 |
| corvus | ianw: i note from your log message, the http response code is 401 (unauthorized) | 22:04 |
| corvus | ianw: so that seems like the likely immediate issue | 22:05 |
| ianw | result: 401 ... indeed | 22:07 |
| ianw | i *totally* missed that | 22:07 |
| corvus | we might want to change that from 'result' to 'response code' | 22:10 |
| corvus | it's a bit subtle | 22:10 |
| ianw | yeah and i think it should also bubble up an error rather than try and go on parsing; that's what my other changes try to do so not totally wasted time | 22:13 |
| ianw | we do get "ERROR zuul.GithubConnection.GithubClientManager: No installation ID available for project ansible/ansible" | 22:15 |
| ianw | i'm guessing the installation id must be important | 22:15 |
| corvus | ianw: we get one iff the repo has installed the zuul app (which ansible hasn't since the openstack stuff moved out) | 22:17 |
| corvus | ianw: without it, it should perform anonymous queries; did you try your graphql query anon? | 22:17 |
| ianw | well you have to be authenticated to do a graphql query i believe | 22:17 |
| ianw | To communicate with the GraphQL server, you'll need an OAuth token with the right scopes. | 22:18 |
| ianw | https://docs.github.com/en/graphql/guides/forming-calls-with-graphql#authenticating-with-graphql | 22:18 |
| corvus | this may be the crux of the problem then | 22:18 |
| ianw | that may be a new thing? i don't know what it used to be like :) | 22:19 |
| ianw | we seem to have had graphql too long for that to have not been noticed, as a first though -> https://review.opendev.org/c/zuul/zuul/+/709836 | 22:25 |
| corvus | ianw: are you sure we've tried to run a job that required-projects ansible since then? | 22:26 |
| corvus | (if the hypothesis is: the graphql change broke internal cloning of github repos with only anonymous access; i'm not sure we have a lot of those in order to disprove it) | 22:27 |
| corvus | or is this a depends-on? (doesn't change what i was trying to say; just clarifying) | 22:28 |
| ianw | this is a depends-on; upstream ansible committed something that broke our ansible-devel system-config job, so was trying to test the pull request that is supposed to fix it | 22:29 |
| ianw | we have "webhook_token" | 22:32 |
| ianw | is this saying it's looking for a config "api_token"? https://opendev.org/zuul/zuul/src/branch/master/zuul/driver/github/githubconnection.py#L1152 | 22:34 |
| ianw | i think that might be it. i do not think we have an api_token set in our config | 22:36 |
| ianw | https://zuul-ci.org/docs/zuul/reference/drivers/github.html#attr-%3Cgithub%20connection%3E.api_token | 22:36 |
| ianw | which points to making a scoped api token | 22:37 |
| *** tosky has quit IRC | 23:00 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!