*** gmann_afk is now known as gmann | 01:30 | |
openstackgerrit | James E. Blair proposed zuul/zuul master: Inherited dependencies are overwritten https://review.opendev.org/c/zuul/zuul/+/791994 | 02:03 |
---|---|---|
*** jamesmcarthur has quit IRC | 03:52 | |
*** jamesmcarthur has joined #zuul | 03:53 | |
*** jamesmcarthur has quit IRC | 03:58 | |
*** bhavikdbavishi has joined #zuul | 04:09 | |
*** jfoufas1 has joined #zuul | 04:21 | |
*** jamesmcarthur has joined #zuul | 04:23 | |
*** jamesmcarthur has quit IRC | 04:40 | |
*** jamesmcarthur has joined #zuul | 04:53 | |
*** ykarel|away has joined #zuul | 04:54 | |
*** freefood_ has quit IRC | 04:56 | |
*** jamesmcarthur has quit IRC | 04:57 | |
*** freefood_ has joined #zuul | 04:57 | |
*** ykarel|away is now known as ykarel | 05:00 | |
*** jamesmcarthur has joined #zuul | 05:10 | |
*** jamesmcarthur has quit IRC | 05:15 | |
*** jamesmcarthur has joined #zuul | 05:27 | |
*** jamesmcarthur has quit IRC | 05:33 | |
*** jamesmcarthur has joined #zuul | 05:47 | |
*** jamesmcarthur has quit IRC | 05:59 | |
*** jamesmcarthur has joined #zuul | 06:13 | |
*** jamesmcarthur has quit IRC | 06:19 | |
*** bhavikdbavishi has quit IRC | 06:37 | |
*** lyr has left #zuul | 06:43 | |
*** sshnaidm has joined #zuul | 06:58 | |
*** tosky has joined #zuul | 07:20 | |
*** jamesmcarthur has joined #zuul | 07:32 | |
*** jamesmcarthur has quit IRC | 07:36 | |
*** vishalmanchanda has joined #zuul | 07:42 | |
*** bhavikdbavishi has joined #zuul | 07:53 | |
*** ykarel is now known as ykarel|lunch | 08:27 | |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul-jobs master: Fix buildset-registry test on focal https://review.opendev.org/c/zuul/zuul-jobs/+/792349 | 08:35 |
*** nils has joined #zuul | 08:36 | |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul-jobs master: Fix buildset-registry test on focal https://review.opendev.org/c/zuul/zuul-jobs/+/792349 | 09:01 |
*** ykarel|lunch is now known as ykarel | 09:13 | |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul-jobs master: Fix buildset-registry test on focal https://review.opendev.org/c/zuul/zuul-jobs/+/792349 | 09:21 |
*** jpenag is now known as jpena | 09:30 | |
*** jamesmcarthur has joined #zuul | 09:34 | |
*** jamesmcarthur has quit IRC | 09:45 | |
*** jangutter_ has joined #zuul | 09:50 | |
*** jangutter has quit IRC | 09:53 | |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul-jobs master: Fix buildset-registry test on focal https://review.opendev.org/c/zuul/zuul-jobs/+/792349 | 09:54 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul-jobs master: Fix buildset-registry test on focal https://review.opendev.org/c/zuul/zuul-jobs/+/792349 | 10:08 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul-jobs master: Fix buildset-registry test on focal https://review.opendev.org/c/zuul/zuul-jobs/+/792349 | 10:57 |
*** bhavikdbavishi has quit IRC | 11:09 | |
*** saneax has joined #zuul | 11:14 | |
*** saneax has quit IRC | 11:22 | |
*** jpena is now known as jpena|lunch | 11:34 | |
*** jamesmcarthur has joined #zuul | 11:41 | |
*** rlandy has joined #zuul | 11:42 | |
*** jamesmcarthur has quit IRC | 11:46 | |
*** bhavikdbavishi has joined #zuul | 11:46 | |
*** bhavikdbavishi1 has joined #zuul | 11:50 | |
*** bhavikdbavishi has quit IRC | 11:51 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 11:51 | |
*** jamesmcarthur has joined #zuul | 12:11 | |
*** josefwells has joined #zuul | 12:14 | |
*** jamesmcarthur has quit IRC | 12:15 | |
*** jamesmcarthur has joined #zuul | 12:15 | |
*** jpena|lunch is now known as jpena | 12:24 | |
*** saneax has joined #zuul | 12:36 | |
*** bhavikdbavishi has quit IRC | 12:50 | |
*** arxcruz is now known as arxcruz|rover | 13:00 | |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: zuul-client: Test buildsets, buildset-info subcommands https://review.opendev.org/c/zuul/zuul/+/758985 | 13:07 |
sean-k-mooney | o/ | 13:43 |
sean-k-mooney | we have am "interesting workflow downstream" that invovled direct force pushs to the repos contolled by gerrit... | 13:44 |
sean-k-mooney | i was wondering has the problem statemnt of triggering a ci run on a force push ever come up | 13:45 |
sean-k-mooney | a little googleing and i found https://github.com/kyanny/git-hooks-detect-force-update/blob/master/pre-receive | 13:46 |
sean-k-mooney | which provide a high level way to tell using the git rev-list | 13:46 |
sean-k-mooney | i was talking to one of oure ci maintainer about this downstream than they were wondering if the git driver could be used in this case | 13:47 |
corvus | sean-k-mooney: from zuul's perspective, a force-push generates a ref-update event from gerrit, so can trigger a 'post' pipeline | 13:47 |
sean-k-mooney | corvus: well that was one of the questions we had | 13:48 |
sean-k-mooney | woudl it trigger a ref-update | 13:48 |
corvus | yep it does | 13:48 |
sean-k-mooney | can we tell form the ref-update that its a force push or do we have to compute that | 13:48 |
corvus | versus a change merge? i don't know off hand | 13:49 |
sean-k-mooney | yes i expect ref-updated to happen anytime we submit something | 13:49 |
sean-k-mooney | it does contain the old and new rev shas | 13:49 |
sean-k-mooney | so we coudl comare the trees and determin if one is a subset of the other | 13:50 |
sean-k-mooney | if not it was a force push | 13:50 |
sean-k-mooney | i wonder if we could use a require clause on ref udpate to trigger that comparison | 13:51 |
sean-k-mooney | e.g. add ref-updated as an event trigger for the pipleine but also add a require clase for force push | 13:51 |
sean-k-mooney | corvus: long term i would prefer if we could change the workflow to not allow force pushs for rebasing downstream agaisnt upstream | 13:52 |
*** migi has joined #zuul | 13:52 | |
sean-k-mooney | sort term we could add a nightly perodic job to make sure thing are not broken | 13:53 |
sean-k-mooney | medium term it woudl be nice if the gerrit driver could trigger on force pushes | 13:53 |
sean-k-mooney | the simple check by had would be "git checkout -f <old ref>; git merge --ff-only <new ref>" if it can fast forward then a rebase happened that was force pushed. we should be able to compute the same for the git trees in principal but im not sure we would want to do that always or how expensive it would be | 13:57 |
fungi | sean-k-mooney: i'm starting to wonder if when you say "force push" you don't actually mean `git push --force` | 13:58 |
fungi | are you trying to say they're just bypassing code review by directly pushing to the repositories? | 13:59 |
fungi | because `git push --force` is generally used to make non-fast-forwardable changes to a branch | 13:59 |
sean-k-mooney | fungi: i do | 14:00 |
sean-k-mooney | and yes | 14:00 |
sean-k-mooney | they are fully bypassign all our ci and pushing directly to the repos owned by gerrit | 14:00 |
sean-k-mooney | which means if there is an issue we find it the first time we propse a new patch as a backport | 14:01 |
fungi | okay, but not (necessarily) with git push --force | 14:01 |
sean-k-mooney | there workflows is to do a git rebase agsint stable/* and then git push --force | 14:01 |
sean-k-mooney | as a way to import any upstream changes into the downstream branch | 14:02 |
sean-k-mooney | without runing ci on those change or more imporantly on any local merge conflict that were resolved automatically or manually | 14:02 |
sean-k-mooney | fungi: there is a release pipleine that happens indepently of devleopes backporting change that involves testing the code after its merged into the repo | 14:04 |
sean-k-mooney | but form a deveploper point of view the current workflow can resultin breakign the branch we backport code into then we need to go fix it first | 14:05 |
sean-k-mooney | so we are tryign to figure out if we can triger a run wehn theis force push happend and at leat know about it | 14:06 |
* sean-k-mooney wishes we woudl use zuul to gate our downstream repos exclivly but cant | 14:08 | |
*** jangutter has joined #zuul | 14:16 | |
*** jangutter has quit IRC | 14:16 | |
*** jangutter_ has quit IRC | 14:16 | |
*** jangutter has joined #zuul | 14:16 | |
fungi | oh, i see what you're suggesting, the commit will look fast-forwardable to zuul after it's updated the branch state based on the push --force. however just checking for a ff isn't necessarily going to help because a change merged normally can also be a fast forward if the branch tip is also the commit's parent | 14:17 |
sean-k-mooney | ya it could. but if a rebase happened then we could not fast forward to the new tip | 14:18 |
sean-k-mooney | all our downstream change would be moved to the end i think | 14:19 |
sean-k-mooney | well in either cae i would expect it to fail which is why they force push in the first place | 14:19 |
sean-k-mooney | i was just looking at https://opendev.org/zuul/zuul/src/commit/6479892b9c41fb818b2a6ead14c0239bf33d6481/zuul/driver/gerrit/gerritconnection.py#L96-L101 | 14:19 |
sean-k-mooney | and wonderign if there was a way we could add a force-updated flag to the event that was not horbile expnsive to compute | 14:20 |
sean-k-mooney | the best i can come up with curently is if new ref can be created with a fast forward update form old ref then this was a force push | 14:21 |
sean-k-mooney | this likely is not the correct place to determin that however | 14:22 |
sean-k-mooney | we do not have a git client we can use to inspect the git reflogs or similar here | 14:23 |
corvus | sean-k-mooney: you might be able to detect the situation if ref-updated has a user field; but i don't know that it does. | 14:23 |
sean-k-mooney | am it has a submitter | 14:24 |
sean-k-mooney | https://gerrit-review.googlesource.com/Documentation/cmd-stream-events.html#_ref_updated | 14:24 |
corvus | then zuul=change-merged; not-zuul=ref-updated ? | 14:24 |
sean-k-mooney | the refUpdate attribute does not https://gerrit-review.googlesource.com/Documentation/json.html#refUpdate | 14:24 |
corvus | er i mean force-push | 14:24 |
corvus | zuul=change-merged; not-zuul=force-push | 14:25 |
sean-k-mooney | that might work migi ^ | 14:25 |
sean-k-mooney | migi: they do not use the zuul user for this right | 14:25 |
sean-k-mooney | or at least we could ask them not to it should be there own credentials | 14:26 |
sean-k-mooney | corvus: we might still want to use ref-uddated rather then change-merged | 14:27 |
corvus | sorry i wasn't clear | 14:27 |
sean-k-mooney | oh you mean when we get a ref-updated check if the change was merged by zuul | 14:27 |
corvus | a ref-updated event whose submitter is zuul is the result of merging a change in gerrit; a ref-updated event whose submitter is not zuul is a 'git push' (possibly with --force) | 14:28 |
corvus | unless you also have the zuul user doing that | 14:28 |
sean-k-mooney | right | 14:28 |
sean-k-mooney | in that case do you think we could extend the require syntax on a pipelien to allow use to express that | 14:29 |
sean-k-mooney | the same way we can use a regex for comments? | 14:29 |
corvus | you should already be able to add the user to the trigger at least | 14:29 |
sean-k-mooney | im not sure it will match on the submitter of the refupdate event but maybe it will | 14:30 |
sean-k-mooney | we dont currently seam to include that in the internal event that is used | 14:30 |
corvus | if that scheme doesn't work, you can probably do some heuristics to find out of the head commit is a change in gerrit, and if not, assume it's a force-push. we looked into that a while ago and determined it's complicated, but possible. you could do that in a job at the head of the job graph, so you would always run it, but let it decide whether to run anything else. | 14:31 |
sean-k-mooney | just looking at this https://opendev.org/zuul/zuul/src/commit/6479892b9c41fb818b2a6ead14c0239bf33d6481/zuul/driver/gerrit/gerritconnection.py#L60-L151 | 14:31 |
sean-k-mooney | oh there is event.account | 14:31 |
sean-k-mooney | ah right that how its populated | 14:32 |
corvus | yeah we try to include account for all the gerrit events | 14:33 |
sean-k-mooney | so we would use https://sf.hosted.upshift.rdu2.redhat.com/docs/zuul/reference/drivers/gerrit.html#attr-pipeline.trigger.%3Cgerrit%20source%3E.username | 14:33 |
sean-k-mooney | pipeline.trigger.<gerrit source>.username | 14:33 |
sean-k-mooney | corvus: im not sure if we can do a negitive regex can we | 14:35 |
sean-k-mooney | the example is username: ^zuul$. | 14:35 |
sean-k-mooney | but i assume username: !^zuul$. is not a thing | 14:35 |
corvus | sean-k-mooney: you should be able to do a negative lookahead match | 14:37 |
sean-k-mooney | i hate those but sure | 14:37 |
sean-k-mooney | i mean its not terrible but they can get slow | 14:38 |
corvus | sean-k-mooney: note that there's some stalled work in progress to remove that from some places in zuul, but i suspect if we do that we will add a "not-username" field to compensate. long story short: should be good for now, but there may be a deprecation/migration in the future. | 14:38 |
corvus | sean-k-mooney: yeah, that's why we'd like to remove them. | 14:38 |
guillaumec | corvus, sean-k-mooney : in order to be able to setup new tutorials in any order (to init, or re-init repos: https://review.opendev.org/c/zuul/zuul/+/732067/41..48/playbooks/tutorial/roles/init-repository/tasks/main.yaml) I made this series of patch https://review.opendev.org/c/zuul/zuul/+/739078 (on hold until all ZK patches are merged) | 14:38 |
sean-k-mooney | its just (?!^zuul$) then | 14:38 |
guillaumec | ie: reconfigure zuul on ref-upadted event | 14:38 |
corvus | guillaumec: nice | 14:40 |
*** ykarel is now known as ykarel|away | 14:40 | |
*** lyarwood has joined #zuul | 14:40 | |
sean-k-mooney | corvus: actully i realised im bing naive | 14:42 |
sean-k-mooney | corvus: we dont actully have zuul merge our stuff yet. we shoudl be currently we wait for zuul and jenkins to report back and then submit via the gerrit ui | 14:43 |
sean-k-mooney | corvus: but we could fix that with a ok_to_merge lable that we set to +1 and have zuul actully submit going forward | 14:43 |
sean-k-mooney | or somethign like that. | 14:44 |
*** jangutter_ has joined #zuul | 14:47 | |
*** jangutter has quit IRC | 14:51 | |
*** jangutter has joined #zuul | 15:03 | |
*** jangutter_ has quit IRC | 15:07 | |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: zuul-client: Test buildsets, buildset-info subcommands https://review.opendev.org/c/zuul/zuul/+/758985 | 15:16 |
*** jangutter_ has joined #zuul | 15:33 | |
*** jangutter has quit IRC | 15:37 | |
*** jangutter has joined #zuul | 16:09 | |
*** jangutter_ has quit IRC | 16:13 | |
*** jamesmcarthur has quit IRC | 16:29 | |
openstackgerrit | James E. Blair proposed zuul/zuul master: Fix race with watches in ExecutorAPI https://review.opendev.org/c/zuul/zuul/+/792300 | 16:29 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Execute builds via ZooKeeper https://review.opendev.org/c/zuul/zuul/+/788988 | 16:29 |
openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add buildsets, buildset-info to subcommands https://review.opendev.org/c/zuul/zuul-client/+/752909 | 16:30 |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: zuul-client: Test buildsets, buildset-info subcommands https://review.opendev.org/c/zuul/zuul/+/758985 | 16:31 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Cache unparsed config files in Zookeeper https://review.opendev.org/c/zuul/zuul/+/771455 | 16:31 |
*** ykarel|away has quit IRC | 16:32 | |
*** jamesmcarthur has joined #zuul | 16:42 | |
openstackgerrit | James E. Blair proposed zuul/zuul master: Add ExecutorApi https://review.opendev.org/c/zuul/zuul/+/770902 | 16:44 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Change zone handling in ExecutorApi https://review.opendev.org/c/zuul/zuul/+/787833 | 16:44 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Switch to string constants in BuildRequest https://review.opendev.org/c/zuul/zuul/+/791849 | 16:44 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Clean up Executor API build request locking and add tests https://review.opendev.org/c/zuul/zuul/+/788624 | 16:44 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Fix race with watches in ExecutorAPI https://review.opendev.org/c/zuul/zuul/+/792300 | 16:44 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Execute builds via ZooKeeper https://review.opendev.org/c/zuul/zuul/+/788988 | 16:44 |
*** jpena is now known as jpena|off | 17:23 | |
*** bhavikdbavishi has joined #zuul | 17:53 | |
*** sshnaidm is now known as sshnaidm|afk | 18:02 | |
*** jfoufas1 has quit IRC | 18:06 | |
*** Shrews has joined #zuul | 18:22 | |
openstackgerrit | James E. Blair proposed zuul/zuul master: Add ExecutorApi https://review.opendev.org/c/zuul/zuul/+/770902 | 18:23 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Change zone handling in ExecutorApi https://review.opendev.org/c/zuul/zuul/+/787833 | 18:23 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Switch to string constants in BuildRequest https://review.opendev.org/c/zuul/zuul/+/791849 | 18:23 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Clean up Executor API build request locking and add tests https://review.opendev.org/c/zuul/zuul/+/788624 | 18:23 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Fix race with watches in ExecutorAPI https://review.opendev.org/c/zuul/zuul/+/792300 | 18:23 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Execute builds via ZooKeeper https://review.opendev.org/c/zuul/zuul/+/788988 | 18:23 |
msuszko | I've got nodepool with azul driver to upload images to Azure (using HTTP proxy). Azul client is just pretty compared to azure sdk. | 18:47 |
msuszko | Image build using dib is 2.4GiB, and VMs /dev/sda is only 2GiB. It could by resized while VM is stopped. How do you grow an image? Uploading 28GiB of zeros seems impractical... | 18:53 |
clarkb | msuszko: we use the growroot dib element which installs a unit that on bootup expands the size of the disk and fs to fill the space set by the cloud | 19:03 |
msuszko | I have growroot element. But azure /dev/sda is 2GiB, there is no space to grow. | 19:04 |
clarkb | oh I see, does azure not provide larger flavors? | 19:04 |
clarkb | msuszko: the clouds we use provider instance flavors with larger disk (or we boot from volume and provide larger volume sizes) and then growroot fills that | 19:05 |
clarkb | I'm not familiar enough with how azure lays out its VMs to know if there is something special you need to do | 19:06 |
msuszko | This is "VHD" disk image made with dib. Actually format flag for qemu-img is -O vpc. This image has to be fixed, and aligned to 1MiB. | 19:09 |
msuszko | I have no clue if image can be grown after upload. | 19:09 |
clarkb | our vhd images built with dib are booted in rackspace on xen and they are resizeable there. I do not know if azure can do that or not | 19:10 |
msuszko | I could grow it to 30GB before, but it means uploading extra 28GB of zeros | 19:10 |
clarkb | the constraint for us on xen is the size of the backing disk which growroot expands to fill | 19:11 |
msuszko | vhd for azure is different, and dib had to be patched | 19:11 |
clarkb | https://docs.microsoft.com/en-us/azure/virtual-machines/linux/resize-os-disk-gpt-partition that implies it is possible but all of the steps there involve stopping the VM, resizing the root disk, then starting the vm and running growroot | 19:13 |
clarkb | is it possible to specify the root disk size on boot maybe? | 19:13 |
clarkb | rather than after the fact? | 19:13 |
clarkb | https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/createorupdate#storageprofile points to https://docs.microsoft.com/en-us/rest/api/compute/virtualmachines/createorupdate#osdisk which says diskSizeGB can set it | 19:15 |
clarkb | I suspect that if you boot with ^ setting a value larger than the size of the vhd then growroot will do what you want on boot | 19:15 |
msuszko | i was looking for way to resize image, but specifying disk size while invoking vm is worth checking, thanks | 19:15 |
fungi | yeah, to be clear, for openstack server instances we specify the size on boot, we don't resize the block device just the filesystem written to it | 19:26 |
*** jamesmcarthur_ has joined #zuul | 19:40 | |
*** jamesmcarthur has quit IRC | 19:43 | |
msuszko | solved :-) Added `"diskSizeGB": 30,` in https://review.opendev.org/c/zuul/nodepool/+/781187/6/nodepool/driver/azurestate/adapter.py#402 | 19:49 |
*** josefwells_ has joined #zuul | 19:51 | |
clarkb | adding the disk size as a parameter that can be supplied is probably a good improvement | 19:51 |
*** josefwells has quit IRC | 19:54 | |
msuszko | Definitely | 19:54 |
*** vishalmanchanda has quit IRC | 19:59 | |
*** rlandy is now known as rlandy|biab | 20:11 | |
openstackgerrit | Matthieu Huin proposed zuul/zuul master: zuul-client: test change-status command https://review.opendev.org/c/zuul/zuul/+/759840 | 20:22 |
*** jamesmcarthur_ has quit IRC | 20:28 | |
*** bhavikdbavishi has quit IRC | 20:38 | |
*** jamesmcarthur has joined #zuul | 20:48 | |
*** josefwells__ has joined #zuul | 20:50 | |
openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add console-stream subcommand https://review.opendev.org/c/zuul/zuul-client/+/751238 | 20:51 |
openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Add change-status subcommand https://review.opendev.org/c/zuul/zuul-client/+/759838 | 20:52 |
*** josefwells_ has quit IRC | 20:54 | |
*** rlandy|biab is now known as rlandy | 21:00 | |
openstackgerrit | James E. Blair proposed zuul/zuul master: WIP: Lock/unlock nodes on executor server https://review.opendev.org/c/zuul/zuul/+/774610 | 21:07 |
*** saneax has quit IRC | 22:05 | |
*** saneax has joined #zuul | 22:05 | |
*** openstackgerrit has quit IRC | 22:05 | |
*** Shrews has quit IRC | 22:20 | |
*** jamesmcarthur has quit IRC | 22:48 | |
*** snapiri has quit IRC | 23:14 | |
*** snapiri has joined #zuul | 23:14 | |
*** kgz has quit IRC | 23:17 | |
*** tosky has quit IRC | 23:18 | |
*** kgz has joined #zuul | 23:33 | |
*** systemd has joined #zuul | 23:36 | |
*** openstack has joined #zuul | 23:51 | |
*** ChanServ sets mode: +o openstack | 23:51 | |
*** jamesmcarthur has joined #zuul | 23:57 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!