Thursday, 2021-05-13

*** sassyn has quit IRC00:05
*** openstackgerrit has joined #zuul00:20
openstackgerritJames E. Blair proposed zuul/zuul-registry master: Add content-length headers and debug messages  https://review.opendev.org/c/zuul/zuul-registry/+/79106800:20
corvusianw: sorry i didn't get to your podman changes yesterday, but i retroreviewed them; +200:38
ianwcorvus: no worries, thanks, i figured it was pretty self-contained00:39
ianwincorporating a few tweaks in the dib side for building fedora images from containers, and i think we should be able to deploy that to production soon00:40
*** dry has joined #zuul01:17
*** msuszko has quit IRC01:18
ianwcorvus: TFR.  yaml tags is something that only recently entered my conciousness via recent discussions.  i'd agree it's an interesting avenue to explore for extending inheritance options01:26
openstackgerritMerged zuul/zuul master: Add pywinrm to default executor venv packages  https://review.opendev.org/c/zuul/zuul/+/78774301:35
corvusianw: yeah, i don't want to go overboard on them, but it feels like for things like that it might make sense (re 747614 for others in channel).  and we already have one with the encrypted secrets, so the door is open.  :)01:40
openstackgerritMerged zuul/zuul master: Add boto3 to default executor venv packages  https://review.opendev.org/c/zuul/zuul/+/78775101:51
openstackgerritMerged zuul/zuul master: Add waiting status to status page  https://review.opendev.org/c/zuul/zuul/+/78837601:58
*** rlandy|bbl is now known as rlandy02:09
*** rlandy has quit IRC02:25
*** evrardjp has quit IRC02:33
*** evrardjp has joined #zuul02:33
ianwfyi looks like devstack merged a change to neutron setup that has broken the nodepool build+boot jobs : proposed solution @ https://review.opendev.org/c/openstack/devstack/+/79108503:26
mordredianw: the comment about gate jobs copying /opt/stack - is that no longer needed because devstack has gotten smart enough to pull from teh cache location?03:41
mordredshould we perhaps remove that rsync you linked to?03:41
mordredhttps://opendev.org/openstack/devstack/src/branch/master/roles/setup-devstack-source-dirs/tasks/main.yaml#L703:41
ianwmordred: hrm, has the cloning got that smart though?03:46
ianwi feel like it clones from GIT_BASE03:49
mordredwell - that's the question - if it's happening there but not in nodepool jobs - it seems liek maybe it's only cloning from the right place some of the time?03:49
mordredor is it just that we don't care about zuul refs for the devstack repos?03:50
*** bhavikdbavishi has joined #zuul03:51
ianwhttps://zuul.opendev.org/t/openstack/build/8662f8d1490b4ddd8069ef219af6ad13/log/controller/logs/devstacklog.txt#413003:52
ianwthat's in devstack, where it's got RECLONE off, so it just takes what's already in /opt/stack (i.e. the rsync'd trees)03:52
ianwmordred: oh, yeah for the nodepool jobs, we treat devstack as a black box, so we wouldn't install depends-on for other projects, etc.03:53
mordredgotit03:53
ianwi think this will affect anyone who just pulls and uses devstack.  just most of them are likely asleep right now :)03:54
*** bhavikdbavishi1 has joined #zuul04:04
*** bhavikdbavishi has quit IRC04:06
*** bhavikdbavishi1 is now known as bhavikdbavishi04:06
*** josefwells has quit IRC04:11
*** ykarel has joined #zuul04:38
*** vishalmanchanda has joined #zuul05:06
*** saneax has joined #zuul05:27
*** bhavikdbavishi has quit IRC05:37
*** bhavikdbavishi has joined #zuul05:38
*** bhavikdbavishi has quit IRC06:27
*** ykarel has quit IRC06:46
*** jpena|off is now known as jpena06:48
*** zbr has quit IRC06:49
*** reiterative has quit IRC06:49
*** reiterative has joined #zuul06:49
*** zbr has joined #zuul06:51
*** bhavikdbavishi has joined #zuul06:56
openstackgerritIan Wienand proposed zuul/zuul-jobs master: ensure-devstack: allow for minimal configuration of pull location  https://review.opendev.org/c/zuul/zuul-jobs/+/79111606:57
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [dnm] testing devstack 791085  https://review.opendev.org/c/zuul/zuul-jobs/+/79111707:00
openstackgerritIan Wienand proposed zuul/zuul-jobs master: ensure-devstack: allow for minimal configuration of pull location  https://review.opendev.org/c/zuul/zuul-jobs/+/79111607:03
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [dnm] testing devstack 791085  https://review.opendev.org/c/zuul/zuul-jobs/+/79111707:03
*** bhavikdbavishi has quit IRC07:09
*** tosky has joined #zuul07:47
*** bhavikdbavishi has joined #zuul07:52
*** bhavikdbavishi has quit IRC07:54
*** ikhan has joined #zuul07:59
*** ikhan has quit IRC08:03
*** bhavikdbavishi has joined #zuul09:53
*** bhavikdbavishi1 has joined #zuul09:56
*** bhavikdbavishi has quit IRC09:57
*** bhavikdbavishi1 is now known as bhavikdbavishi09:57
ianw^ has at least fixed the syntax error in ensure-devstack10:00
ianwhttps://zuul.opendev.org/t/zuul/build/e5974c329a9047d28059bcd77d78e3ce/log/job-output.txt#811810:01
ianw2021-05-13 07:12:14.752345 | ubuntu-bionic | [ERROR] /opt/devstack/lib/neutron_plugins/ovn_agent:360 The q-agt/neutron-agt service must be disabled with OVN.10:02
ianwthat's going to take more brain-power than i have right now to untangle10:02
*** bhavikdbavishi has quit IRC10:11
*** bhavikdbavishi has joined #zuul10:21
*** Shrews has joined #zuul11:25
*** jpena is now known as jpena|lunch11:32
*** jhesketh has quit IRC11:43
*** rlandy has joined #zuul11:45
*** josefwells has joined #zuul12:16
*** jhesketh has joined #zuul12:21
*** jpena|lunch is now known as jpena12:33
*** bhavikdbavishi has quit IRC13:08
*** bhavikdbavishi has joined #zuul13:15
*** bhavikdbavishi has quit IRC13:43
clarkbianw: I suspected that maybe we were explicitly enabling services in ensure-devstack but we seem to only disable them: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/ensure-devstack/templates/local.conf.j214:13
clarkbI think devsatck didn't do the swap properly. THey are relying far too much on zuul job specific configs https://review.opendev.org/c/openstack/devstack/+/735097/37/.zuul.yaml14:14
openstackgerritJeremy Stanley proposed zuul/zuul master: Use ZK config for nodepool integration test  https://review.opendev.org/c/zuul/zuul/+/79082614:26
corvusfungi: quick nit on that14:32
fungicorvus: oh, i'm sure there's a ton wrong with it. still experimenting14:33
fungimainly at the point of trying to figure out everything which changed underneath it. since the job was nonvoting, i think nobody noticed it didn't get updated14:33
*** bhavikdbavishi has joined #zuul14:46
*** bhavikdbavishi1 has joined #zuul14:50
*** bhavikdbavishi has quit IRC14:53
*** bhavikdbavishi1 is now known as bhavikdbavishi14:53
*** pabelanger has joined #zuul14:58
fungithe continuous delivery foundation's interoperability working group has recently undertaken an effort to standardize ci/cd-related metadata. i think it's mostly focused on artifacts and so i'm not all that sure what relevance it would have for zuul (other than maybe producing some additional data in appropriate roles in the zuul-jobs repo?) but figured i'd link it here in case anyone is interested:14:58
fungihttps://hackmd.io/BYbkuR8uSlKt_w7Y4KE1OQ14:58
fungiin last week's meeting there was a lot of discussion about how to possibly merge it with or extend spdx object descriptions14:59
pabelangerdo we have any existing roles / playbooks that are wrapping commands in screen?15:00
pabelangerI'm hitting an issue where docker needs a TTY, and figure screen might help15:00
*** sshnaidm is now known as sshnaidm|afk15:00
pabelangerbasically, trying to run ansible, in a container, for testing purposes. Over using a virtualenv15:01
fungii haven't seen any... but also you could probably set a dummy tty or do a dance to allocate a pty toed to /dev/null?15:01
fungis/toed/tied/15:01
corvuspabelanger: i'm not aware of any either but ^15:01
pabelangerI haven't tested the dummy tty yet, can try that now15:02
pabelangerpodman seems to do the right thing, but using docker it complains about the missing TTY15:04
clarkbpabelanger: are you running with -t ?15:05
pabelangeryah15:05
clarkbthas your problem15:05
pabelangerI sadly don't have the option to control it15:05
pabelangerthis is via ansible-runner15:05
clarkbmaybe make that configurable or have it detect? I bet that is why podman works they do something like that already15:05
pabelangerI'm trying to avoid patching runner right now, but may end up doing that15:05
pabelangeryup, agree15:05
corvuspabelanger, fungi: maybe 'script' command would be useful?15:06
fungiit does seem like if ansible-runner tells docker to expect a tty then ansible-runner should do whatever's necessary to provide one15:06
fungicorvus: good point, that's basically file as a tty15:06
corvusand maybe the file can be '-' ?15:06
fungiby default i think script does use -15:07
corvus(the output file) oh cool15:07
fungiahh, nope, manpage says default is a file named typescript15:07
pabelangerscript /dev/null; screen might be working15:36
*** bhavikdbavishi has quit IRC15:36
pabelangerbut had to say with no stdout :)15:37
corvuspabelanger: i was thinking you might be able to use script without screen15:37
pabelangerI'll have to hack more on this later15:37
pabelangeryah, that's the next step15:37
corvuskk15:37
pabelangerthanks for info15:37
*** bhavikdbavishi has joined #zuul15:38
*** rlandy is now known as rlandy|biab15:42
fungithe openshift.tv episode about zuul starts in an hour! time to make popcorn...16:00
*** jpena is now known as jpena|off16:01
corvusi better get to hair and makeup16:06
*** saneax has quit IRC16:06
clarkbianw: I think https://review.opendev.org/c/openstack/devstack/+/791282 is part of the devstack puzzle16:10
*** rlandy|biab is now known as rlandy16:20
*** bhavikdbavishi has quit IRC16:58
fungithe zuul episode on openshift.tv is currently playing on the tv in my living room. this is great!17:03
clarkbnice17:06
pabelangerthe depends on graphic should update to show projects outside of openstack17:13
avass"We're pretty sure it's gonna work". never heard that one before :)17:21
fungidepends-on to review.openstack.org... so nostalgic! ;)17:23
avasscorvus: nice presentation! :)18:04
fungiit was most excellent18:04
corvusthanks!  hopefully exposed some new folks to zuul18:12
*** mhu has quit IRC20:09
*** mhu has joined #zuul20:11
-openstackstatus- NOTICE: Zuul is in the process of migrating to a new VM and will be restarted shortly.20:41
*** vishalmanchanda has quit IRC20:43
openstackgerritAde Lee proposed zuul/zuul-jobs master: Add role to enable FIPS on a node  https://review.opendev.org/c/zuul/zuul-jobs/+/78877821:05
pabelangeris Ade Lee on irc?21:14
pabelangerI might have asked that before21:14
pabelangerhttps://github.com/ansible/ansible-zuul-jobs/blob/master/roles/enable-fips-mode/tasks/main.yaml is now we are doing fips mode21:14
pabelangerand works well21:14
clarkbpabelanger: in #openstack-infra21:15
fungias ade_lee21:15
*** Shrews has quit IRC21:16
pabelangerack21:16
pabelangerleft a few comments21:17
mordredcorvus: I looked at the commit you and clarkb think caused the issue from #opendev, and I agree - I don't see a how21:37
mordredI also looked at a few others just for fun and also don't see anything21:38
corvusmordred: yeah, i think i'm going to have to fire up a full test env and poke at stuff21:40
corvuscause that was *definitely* tested21:40
mordredyah21:40
corvusi'm wondering if there's like yaml lib stuff going into the images that differs slightly from unit test env21:40
mordredyeah - could be?21:41
corvus(especially since our yamlutil module is like "try to import the c yaml lib, if not, use the backup")21:41
mordredcorvus: >>> yaml.__version__21:42
mordred'5.4.1'21:42
mordredthat's what I get in the container image21:42
fungimordred: if it helps, this is the traceback: http://paste.openstack.org/show/805368/21:42
corvusmordred: if you have that up, try: from yaml import cyaml21:43
corvusmordred: and then import _yaml21:43
mordredcorvus: both work21:44
corvusweeeeird21:44
mordredyeah21:44
corvusthis is gonna be a fun one :)21:44
mordredcorvus: it's probably caused by urls in comments21:45
openstackgerritJames E. Blair proposed zuul/zuul master: Omnibus executor secret decrypt revert  https://review.opendev.org/c/zuul/zuul/+/79132221:46
corvusgee that's a word salad of a commit subject21:46
corvusmordred: borland c++ used to produce different code (sometimes crashing) depending on comments21:48
corvusmordred: so if a comment can cause your complier to produce code that segfaults, you could say that comments are a security flaw21:49
openstackgerritAde Lee proposed zuul/zuul-jobs master: Add role to enable FIPS on a node  https://review.opendev.org/c/zuul/zuul-jobs/+/78877821:56
*** corvus has quit IRC21:58
-openstackstatus- NOTICE: We are cautiously optimistic that Zuul is functional now on the new server. We ran into some unexpected problems and want to do another restart in the near future to ensure a revert addresses the source of that problem.22:06
*** rlandy has quit IRC22:32
fungithis came up recently in an upstream python discussion about type annotations in the stdlib, and i had never noticed it was an option: https://www.python.org/dev/peps/pep-0484/#stub-files22:33
fungiin short, keeping the type annotations in separate files in the tree rather than comingling them within the python source files22:33
clarkbI think zuul already uses them22:33
fungipyi files?22:34
clarkbthere were definitely files generated for some reason22:34
fungioh, indeed it does22:34
clarkbyup22:34
fungithough most of them appear to be empty22:34
fungiapparently you can stick all your annotations in those and not clutter up your normal code with them22:35
fungiwhich might at least address some of the readability concerns22:35
fungioh, nevermind, the ones in the zuul source tree are all in the subtrees copied from ansible22:36
clarkbya its to make the type checker happy with those files iirc22:37
fungii don't see any outside of zuul/ansible/22:37
clarkbessentailly we are telling it don'y type check because its external code22:37
fungiaha, well anyway the same kinds of files could be used to abstract the annotations into, looks like22:37
fungifor people who want working annotations it's probably a bit more work to keep in sync with the source code, but then people who don't find the annotations useful or find the inline ones problematic can just ignore them. also adding annotations that way doesn't create a ton of unwarranted churn in the source22:39
fungiand from what i can see, it's possible to define a separate "typeshed" where the annotation stubs are stored, so they don't even have to be in the same tree/repository at all22:49
fungifor example here's the type annotations for the python stdlib urllib.request module: https://github.com/python/typeshed/blob/master/stdlib/urllib/request.pyi22:51
fungicompletely separate git repository from the actual stdlib files22:51
*** corvus has joined #zuul22:56
openstackgerritMerged zuul/zuul master: Omnibus executor secret decrypt revert  https://review.opendev.org/c/zuul/zuul/+/79132222:58
fungiclarkb: looks like it merged ^22:59
fungicorvus: in no way urgent, but if you get a chance to check the channel log from when you were gone, i ran across the type hinting and annotation solution used by the python stdlib and think it could be a reasonable compromise between people who would like to annotate the codebase and people who would rather not have to see the annotations23:02
fungii can't remember if that's an option we discussed23:03
corvusfungi: yeah, i would be fine with that, however we wouldn't be able to enforce it, and it would drift, so i don't think it's a silver bullet.  at this point, i kinda just want to get through v5 without having to think about that again :)23:08
fungicompletely agree23:11
fungimainly if hinting and annotations come up again, i'm inclined to steer people that direction23:11
fungiit seems to be the solution the python maintainers themselves have chosen, so it must be workable on some level23:12
*** tosky has quit IRC23:23
corvusgood point; may be more to learn about how to keep it up to date23:30
corvuszuul-maint: i'd like to tag zuul: commit ddb7259f0d4130f5fd5add84f82b0b9264589652 (HEAD -> master, tag: 4.3.0, origin/master, refs/changes/22/791322/1)23:56
corvuswe just restarted opendev on that, and it's looking good so far.  i think we need that as a checkpoint release for further v5 work23:57
fungithat looks like what we're running in opendev now23:57
corvuswe even have that git sha on the status page since it was a ff commit :)23:58

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!