*** sassyn has quit IRC | 00:05 | |
*** openstackgerrit has joined #zuul | 00:20 | |
openstackgerrit | James E. Blair proposed zuul/zuul-registry master: Add content-length headers and debug messages https://review.opendev.org/c/zuul/zuul-registry/+/791068 | 00:20 |
---|---|---|
corvus | ianw: sorry i didn't get to your podman changes yesterday, but i retroreviewed them; +2 | 00:38 |
ianw | corvus: no worries, thanks, i figured it was pretty self-contained | 00:39 |
ianw | incorporating a few tweaks in the dib side for building fedora images from containers, and i think we should be able to deploy that to production soon | 00:40 |
*** dry has joined #zuul | 01:17 | |
*** msuszko has quit IRC | 01:18 | |
ianw | corvus: TFR. yaml tags is something that only recently entered my conciousness via recent discussions. i'd agree it's an interesting avenue to explore for extending inheritance options | 01:26 |
openstackgerrit | Merged zuul/zuul master: Add pywinrm to default executor venv packages https://review.opendev.org/c/zuul/zuul/+/787743 | 01:35 |
corvus | ianw: yeah, i don't want to go overboard on them, but it feels like for things like that it might make sense (re 747614 for others in channel). and we already have one with the encrypted secrets, so the door is open. :) | 01:40 |
openstackgerrit | Merged zuul/zuul master: Add boto3 to default executor venv packages https://review.opendev.org/c/zuul/zuul/+/787751 | 01:51 |
openstackgerrit | Merged zuul/zuul master: Add waiting status to status page https://review.opendev.org/c/zuul/zuul/+/788376 | 01:58 |
*** rlandy|bbl is now known as rlandy | 02:09 | |
*** rlandy has quit IRC | 02:25 | |
*** evrardjp has quit IRC | 02:33 | |
*** evrardjp has joined #zuul | 02:33 | |
ianw | fyi looks like devstack merged a change to neutron setup that has broken the nodepool build+boot jobs : proposed solution @ https://review.opendev.org/c/openstack/devstack/+/791085 | 03:26 |
mordred | ianw: the comment about gate jobs copying /opt/stack - is that no longer needed because devstack has gotten smart enough to pull from teh cache location? | 03:41 |
mordred | should we perhaps remove that rsync you linked to? | 03:41 |
mordred | https://opendev.org/openstack/devstack/src/branch/master/roles/setup-devstack-source-dirs/tasks/main.yaml#L7 | 03:41 |
ianw | mordred: hrm, has the cloning got that smart though? | 03:46 |
ianw | i feel like it clones from GIT_BASE | 03:49 |
mordred | well - that's the question - if it's happening there but not in nodepool jobs - it seems liek maybe it's only cloning from the right place some of the time? | 03:49 |
mordred | or is it just that we don't care about zuul refs for the devstack repos? | 03:50 |
*** bhavikdbavishi has joined #zuul | 03:51 | |
ianw | https://zuul.opendev.org/t/openstack/build/8662f8d1490b4ddd8069ef219af6ad13/log/controller/logs/devstacklog.txt#4130 | 03:52 |
ianw | that's in devstack, where it's got RECLONE off, so it just takes what's already in /opt/stack (i.e. the rsync'd trees) | 03:52 |
ianw | mordred: oh, yeah for the nodepool jobs, we treat devstack as a black box, so we wouldn't install depends-on for other projects, etc. | 03:53 |
mordred | gotit | 03:53 |
ianw | i think this will affect anyone who just pulls and uses devstack. just most of them are likely asleep right now :) | 03:54 |
*** bhavikdbavishi1 has joined #zuul | 04:04 | |
*** bhavikdbavishi has quit IRC | 04:06 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 04:06 | |
*** josefwells has quit IRC | 04:11 | |
*** ykarel has joined #zuul | 04:38 | |
*** vishalmanchanda has joined #zuul | 05:06 | |
*** saneax has joined #zuul | 05:27 | |
*** bhavikdbavishi has quit IRC | 05:37 | |
*** bhavikdbavishi has joined #zuul | 05:38 | |
*** bhavikdbavishi has quit IRC | 06:27 | |
*** ykarel has quit IRC | 06:46 | |
*** jpena|off is now known as jpena | 06:48 | |
*** zbr has quit IRC | 06:49 | |
*** reiterative has quit IRC | 06:49 | |
*** reiterative has joined #zuul | 06:49 | |
*** zbr has joined #zuul | 06:51 | |
*** bhavikdbavishi has joined #zuul | 06:56 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-devstack: allow for minimal configuration of pull location https://review.opendev.org/c/zuul/zuul-jobs/+/791116 | 06:57 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [dnm] testing devstack 791085 https://review.opendev.org/c/zuul/zuul-jobs/+/791117 | 07:00 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-devstack: allow for minimal configuration of pull location https://review.opendev.org/c/zuul/zuul-jobs/+/791116 | 07:03 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [dnm] testing devstack 791085 https://review.opendev.org/c/zuul/zuul-jobs/+/791117 | 07:03 |
*** bhavikdbavishi has quit IRC | 07:09 | |
*** tosky has joined #zuul | 07:47 | |
*** bhavikdbavishi has joined #zuul | 07:52 | |
*** bhavikdbavishi has quit IRC | 07:54 | |
*** ikhan has joined #zuul | 07:59 | |
*** ikhan has quit IRC | 08:03 | |
*** bhavikdbavishi has joined #zuul | 09:53 | |
*** bhavikdbavishi1 has joined #zuul | 09:56 | |
*** bhavikdbavishi has quit IRC | 09:57 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 09:57 | |
ianw | ^ has at least fixed the syntax error in ensure-devstack | 10:00 |
ianw | https://zuul.opendev.org/t/zuul/build/e5974c329a9047d28059bcd77d78e3ce/log/job-output.txt#8118 | 10:01 |
ianw | 2021-05-13 07:12:14.752345 | ubuntu-bionic | [ERROR] /opt/devstack/lib/neutron_plugins/ovn_agent:360 The q-agt/neutron-agt service must be disabled with OVN. | 10:02 |
ianw | that's going to take more brain-power than i have right now to untangle | 10:02 |
*** bhavikdbavishi has quit IRC | 10:11 | |
*** bhavikdbavishi has joined #zuul | 10:21 | |
*** Shrews has joined #zuul | 11:25 | |
*** jpena is now known as jpena|lunch | 11:32 | |
*** jhesketh has quit IRC | 11:43 | |
*** rlandy has joined #zuul | 11:45 | |
*** josefwells has joined #zuul | 12:16 | |
*** jhesketh has joined #zuul | 12:21 | |
*** jpena|lunch is now known as jpena | 12:33 | |
*** bhavikdbavishi has quit IRC | 13:08 | |
*** bhavikdbavishi has joined #zuul | 13:15 | |
*** bhavikdbavishi has quit IRC | 13:43 | |
clarkb | ianw: I suspected that maybe we were explicitly enabling services in ensure-devstack but we seem to only disable them: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/ensure-devstack/templates/local.conf.j2 | 14:13 |
clarkb | I think devsatck didn't do the swap properly. THey are relying far too much on zuul job specific configs https://review.opendev.org/c/openstack/devstack/+/735097/37/.zuul.yaml | 14:14 |
openstackgerrit | Jeremy Stanley proposed zuul/zuul master: Use ZK config for nodepool integration test https://review.opendev.org/c/zuul/zuul/+/790826 | 14:26 |
corvus | fungi: quick nit on that | 14:32 |
fungi | corvus: oh, i'm sure there's a ton wrong with it. still experimenting | 14:33 |
fungi | mainly at the point of trying to figure out everything which changed underneath it. since the job was nonvoting, i think nobody noticed it didn't get updated | 14:33 |
*** bhavikdbavishi has joined #zuul | 14:46 | |
*** bhavikdbavishi1 has joined #zuul | 14:50 | |
*** bhavikdbavishi has quit IRC | 14:53 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 14:53 | |
*** pabelanger has joined #zuul | 14:58 | |
fungi | the continuous delivery foundation's interoperability working group has recently undertaken an effort to standardize ci/cd-related metadata. i think it's mostly focused on artifacts and so i'm not all that sure what relevance it would have for zuul (other than maybe producing some additional data in appropriate roles in the zuul-jobs repo?) but figured i'd link it here in case anyone is interested: | 14:58 |
fungi | https://hackmd.io/BYbkuR8uSlKt_w7Y4KE1OQ | 14:58 |
fungi | in last week's meeting there was a lot of discussion about how to possibly merge it with or extend spdx object descriptions | 14:59 |
pabelanger | do we have any existing roles / playbooks that are wrapping commands in screen? | 15:00 |
pabelanger | I'm hitting an issue where docker needs a TTY, and figure screen might help | 15:00 |
*** sshnaidm is now known as sshnaidm|afk | 15:00 | |
pabelanger | basically, trying to run ansible, in a container, for testing purposes. Over using a virtualenv | 15:01 |
fungi | i haven't seen any... but also you could probably set a dummy tty or do a dance to allocate a pty toed to /dev/null? | 15:01 |
fungi | s/toed/tied/ | 15:01 |
corvus | pabelanger: i'm not aware of any either but ^ | 15:01 |
pabelanger | I haven't tested the dummy tty yet, can try that now | 15:02 |
pabelanger | podman seems to do the right thing, but using docker it complains about the missing TTY | 15:04 |
clarkb | pabelanger: are you running with -t ? | 15:05 |
pabelanger | yah | 15:05 |
clarkb | thas your problem | 15:05 |
pabelanger | I sadly don't have the option to control it | 15:05 |
pabelanger | this is via ansible-runner | 15:05 |
clarkb | maybe make that configurable or have it detect? I bet that is why podman works they do something like that already | 15:05 |
pabelanger | I'm trying to avoid patching runner right now, but may end up doing that | 15:05 |
pabelanger | yup, agree | 15:05 |
corvus | pabelanger, fungi: maybe 'script' command would be useful? | 15:06 |
fungi | it does seem like if ansible-runner tells docker to expect a tty then ansible-runner should do whatever's necessary to provide one | 15:06 |
fungi | corvus: good point, that's basically file as a tty | 15:06 |
corvus | and maybe the file can be '-' ? | 15:06 |
fungi | by default i think script does use - | 15:07 |
corvus | (the output file) oh cool | 15:07 |
fungi | ahh, nope, manpage says default is a file named typescript | 15:07 |
pabelanger | script /dev/null; screen might be working | 15:36 |
*** bhavikdbavishi has quit IRC | 15:36 | |
pabelanger | but had to say with no stdout :) | 15:37 |
corvus | pabelanger: i was thinking you might be able to use script without screen | 15:37 |
pabelanger | I'll have to hack more on this later | 15:37 |
pabelanger | yah, that's the next step | 15:37 |
corvus | kk | 15:37 |
pabelanger | thanks for info | 15:37 |
*** bhavikdbavishi has joined #zuul | 15:38 | |
*** rlandy is now known as rlandy|biab | 15:42 | |
fungi | the openshift.tv episode about zuul starts in an hour! time to make popcorn... | 16:00 |
*** jpena is now known as jpena|off | 16:01 | |
corvus | i better get to hair and makeup | 16:06 |
*** saneax has quit IRC | 16:06 | |
clarkb | ianw: I think https://review.opendev.org/c/openstack/devstack/+/791282 is part of the devstack puzzle | 16:10 |
*** rlandy|biab is now known as rlandy | 16:20 | |
*** bhavikdbavishi has quit IRC | 16:58 | |
fungi | the zuul episode on openshift.tv is currently playing on the tv in my living room. this is great! | 17:03 |
clarkb | nice | 17:06 |
pabelanger | the depends on graphic should update to show projects outside of openstack | 17:13 |
avass | "We're pretty sure it's gonna work". never heard that one before :) | 17:21 |
fungi | depends-on to review.openstack.org... so nostalgic! ;) | 17:23 |
avass | corvus: nice presentation! :) | 18:04 |
fungi | it was most excellent | 18:04 |
corvus | thanks! hopefully exposed some new folks to zuul | 18:12 |
*** mhu has quit IRC | 20:09 | |
*** mhu has joined #zuul | 20:11 | |
-openstackstatus- NOTICE: Zuul is in the process of migrating to a new VM and will be restarted shortly. | 20:41 | |
*** vishalmanchanda has quit IRC | 20:43 | |
openstackgerrit | Ade Lee proposed zuul/zuul-jobs master: Add role to enable FIPS on a node https://review.opendev.org/c/zuul/zuul-jobs/+/788778 | 21:05 |
pabelanger | is Ade Lee on irc? | 21:14 |
pabelanger | I might have asked that before | 21:14 |
pabelanger | https://github.com/ansible/ansible-zuul-jobs/blob/master/roles/enable-fips-mode/tasks/main.yaml is now we are doing fips mode | 21:14 |
pabelanger | and works well | 21:14 |
clarkb | pabelanger: in #openstack-infra | 21:15 |
fungi | as ade_lee | 21:15 |
*** Shrews has quit IRC | 21:16 | |
pabelanger | ack | 21:16 |
pabelanger | left a few comments | 21:17 |
mordred | corvus: I looked at the commit you and clarkb think caused the issue from #opendev, and I agree - I don't see a how | 21:37 |
mordred | I also looked at a few others just for fun and also don't see anything | 21:38 |
corvus | mordred: yeah, i think i'm going to have to fire up a full test env and poke at stuff | 21:40 |
corvus | cause that was *definitely* tested | 21:40 |
mordred | yah | 21:40 |
corvus | i'm wondering if there's like yaml lib stuff going into the images that differs slightly from unit test env | 21:40 |
mordred | yeah - could be? | 21:41 |
corvus | (especially since our yamlutil module is like "try to import the c yaml lib, if not, use the backup") | 21:41 |
mordred | corvus: >>> yaml.__version__ | 21:42 |
mordred | '5.4.1' | 21:42 |
mordred | that's what I get in the container image | 21:42 |
fungi | mordred: if it helps, this is the traceback: http://paste.openstack.org/show/805368/ | 21:42 |
corvus | mordred: if you have that up, try: from yaml import cyaml | 21:43 |
corvus | mordred: and then import _yaml | 21:43 |
mordred | corvus: both work | 21:44 |
corvus | weeeeird | 21:44 |
mordred | yeah | 21:44 |
corvus | this is gonna be a fun one :) | 21:44 |
mordred | corvus: it's probably caused by urls in comments | 21:45 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Omnibus executor secret decrypt revert https://review.opendev.org/c/zuul/zuul/+/791322 | 21:46 |
corvus | gee that's a word salad of a commit subject | 21:46 |
corvus | mordred: borland c++ used to produce different code (sometimes crashing) depending on comments | 21:48 |
corvus | mordred: so if a comment can cause your complier to produce code that segfaults, you could say that comments are a security flaw | 21:49 |
openstackgerrit | Ade Lee proposed zuul/zuul-jobs master: Add role to enable FIPS on a node https://review.opendev.org/c/zuul/zuul-jobs/+/788778 | 21:56 |
*** corvus has quit IRC | 21:58 | |
-openstackstatus- NOTICE: We are cautiously optimistic that Zuul is functional now on the new server. We ran into some unexpected problems and want to do another restart in the near future to ensure a revert addresses the source of that problem. | 22:06 | |
*** rlandy has quit IRC | 22:32 | |
fungi | this came up recently in an upstream python discussion about type annotations in the stdlib, and i had never noticed it was an option: https://www.python.org/dev/peps/pep-0484/#stub-files | 22:33 |
fungi | in short, keeping the type annotations in separate files in the tree rather than comingling them within the python source files | 22:33 |
clarkb | I think zuul already uses them | 22:33 |
fungi | pyi files? | 22:34 |
clarkb | there were definitely files generated for some reason | 22:34 |
fungi | oh, indeed it does | 22:34 |
clarkb | yup | 22:34 |
fungi | though most of them appear to be empty | 22:34 |
fungi | apparently you can stick all your annotations in those and not clutter up your normal code with them | 22:35 |
fungi | which might at least address some of the readability concerns | 22:35 |
fungi | oh, nevermind, the ones in the zuul source tree are all in the subtrees copied from ansible | 22:36 |
clarkb | ya its to make the type checker happy with those files iirc | 22:37 |
fungi | i don't see any outside of zuul/ansible/ | 22:37 |
clarkb | essentailly we are telling it don'y type check because its external code | 22:37 |
fungi | aha, well anyway the same kinds of files could be used to abstract the annotations into, looks like | 22:37 |
fungi | for people who want working annotations it's probably a bit more work to keep in sync with the source code, but then people who don't find the annotations useful or find the inline ones problematic can just ignore them. also adding annotations that way doesn't create a ton of unwarranted churn in the source | 22:39 |
fungi | and from what i can see, it's possible to define a separate "typeshed" where the annotation stubs are stored, so they don't even have to be in the same tree/repository at all | 22:49 |
fungi | for example here's the type annotations for the python stdlib urllib.request module: https://github.com/python/typeshed/blob/master/stdlib/urllib/request.pyi | 22:51 |
fungi | completely separate git repository from the actual stdlib files | 22:51 |
*** corvus has joined #zuul | 22:56 | |
openstackgerrit | Merged zuul/zuul master: Omnibus executor secret decrypt revert https://review.opendev.org/c/zuul/zuul/+/791322 | 22:58 |
fungi | clarkb: looks like it merged ^ | 22:59 |
fungi | corvus: in no way urgent, but if you get a chance to check the channel log from when you were gone, i ran across the type hinting and annotation solution used by the python stdlib and think it could be a reasonable compromise between people who would like to annotate the codebase and people who would rather not have to see the annotations | 23:02 |
fungi | i can't remember if that's an option we discussed | 23:03 |
corvus | fungi: yeah, i would be fine with that, however we wouldn't be able to enforce it, and it would drift, so i don't think it's a silver bullet. at this point, i kinda just want to get through v5 without having to think about that again :) | 23:08 |
fungi | completely agree | 23:11 |
fungi | mainly if hinting and annotations come up again, i'm inclined to steer people that direction | 23:11 |
fungi | it seems to be the solution the python maintainers themselves have chosen, so it must be workable on some level | 23:12 |
*** tosky has quit IRC | 23:23 | |
corvus | good point; may be more to learn about how to keep it up to date | 23:30 |
corvus | zuul-maint: i'd like to tag zuul: commit ddb7259f0d4130f5fd5add84f82b0b9264589652 (HEAD -> master, tag: 4.3.0, origin/master, refs/changes/22/791322/1) | 23:56 |
corvus | we just restarted opendev on that, and it's looking good so far. i think we need that as a checkpoint release for further v5 work | 23:57 |
fungi | that looks like what we're running in opendev now | 23:57 |
corvus | we even have that git sha on the status page since it was a ff commit :) | 23:58 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!