tristanC | corvus: i also used secrets for simplicity's sake, using configmaps sounds good to me too | 00:27 |
---|---|---|
*** hamalq has quit IRC | 02:29 | |
*** evrardjp has quit IRC | 02:33 | |
*** evrardjp has joined #zuul | 02:33 | |
*** bhavikdbavishi has joined #zuul | 03:05 | |
*** bhavikdbavishi1 has joined #zuul | 03:07 | |
*** bhavikdbavishi has quit IRC | 03:09 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 03:09 | |
*** bhavikdbavishi has quit IRC | 04:11 | |
*** sanjayu__ has joined #zuul | 04:13 | |
*** ykarel has joined #zuul | 04:14 | |
*** sanjayu_ has joined #zuul | 04:15 | |
*** sanjayu__ has quit IRC | 04:18 | |
*** wuchunyang has joined #zuul | 04:22 | |
*** sanjayu__ has joined #zuul | 04:25 | |
*** wuchunyang has quit IRC | 04:26 | |
*** sanjayu_ has quit IRC | 04:27 | |
*** jfoufas1 has joined #zuul | 04:31 | |
*** rlandy|rover has quit IRC | 04:33 | |
*** vishalmanchanda has joined #zuul | 04:45 | |
*** bhavikdbavishi has joined #zuul | 05:33 | |
*** bhavikdbavishi1 has joined #zuul | 05:36 | |
*** bhavikdbavishi has quit IRC | 05:38 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 05:38 | |
*** sanjayu__ has quit IRC | 06:08 | |
avass | tristanC, corvus: there's also the added benefit where a service or user could have access to the config but not the secrets if that would ever be needed | 06:12 |
avass | now to be clear. if that configuration contains secrets then the entire configuration should be treated as a secret. but I like separating them to make it possible to stick the configmap in a repository. Some repositories are also scanning their repos for leaked secrets and k8s secrets could very well be part of that. maybe github secret scanning even does that? | 06:16 |
avass | they don't and that seems a bit weird :/ | 06:17 |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Store secrets keys and SSH keys in Zookeeper https://review.opendev.org/c/zuul/zuul/+/758940 | 06:22 |
*** saneax has joined #zuul | 06:24 | |
*** zbr has quit IRC | 06:30 | |
openstackgerrit | Albin Vass proposed zuul/zuul master: Filter events on event connection https://review.opendev.org/c/zuul/zuul/+/760907 | 06:30 |
*** zbr has joined #zuul | 06:31 | |
*** dcastellani has quit IRC | 06:34 | |
*** webknjaz has quit IRC | 06:34 | |
*** ajitha has quit IRC | 06:34 | |
*** PrinzElvis has quit IRC | 06:34 | |
*** iamweswilson has quit IRC | 06:35 | |
*** iamweswilson has joined #zuul | 06:36 | |
*** ajitha has joined #zuul | 06:36 | |
*** ajitha has quit IRC | 06:36 | |
*** webknjaz has joined #zuul | 06:36 | |
*** jcapitao has joined #zuul | 06:36 | |
*** dcastellani has joined #zuul | 06:36 | |
*** PrinzElvis has joined #zuul | 06:37 | |
*** bhavikdbavishi has quit IRC | 06:44 | |
*** bhavikdbavishi has joined #zuul | 07:20 | |
*** bhavikdbavishi1 has joined #zuul | 07:27 | |
*** bhavikdbavishi has quit IRC | 07:28 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 07:28 | |
*** AJaeger has joined #zuul | 07:35 | |
*** tosky has joined #zuul | 07:50 | |
*** rpittau|afk is now known as rpittau | 07:55 | |
*** jpena|off is now known as jpena | 07:57 | |
*** nilsph has joined #zuul | 08:03 | |
*** nilsph is now known as nils | 08:04 | |
*** AJaeger has quit IRC | 08:07 | |
*** ricolin has quit IRC | 08:39 | |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Make reporting asynchronous https://review.opendev.org/c/zuul/zuul/+/691253 | 09:01 |
*** bhavikdbavishi has quit IRC | 10:41 | |
*** jcapitao is now known as jcapitao_lucnh | 11:01 | |
*** jcapitao_lucnh is now known as jcapitao_lunch | 11:01 | |
*** avass has quit IRC | 11:07 | |
*** avass has joined #zuul | 11:08 | |
*** avass has quit IRC | 11:31 | |
*** jpena is now known as jpena|lunch | 11:32 | |
*** avass has joined #zuul | 11:32 | |
*** rlandy has joined #zuul | 11:35 | |
*** rlandy is now known as rlandy|rover | 11:36 | |
*** ykarel_ has joined #zuul | 11:37 | |
*** bhavikdbavishi has joined #zuul | 11:39 | |
*** ykarel has quit IRC | 11:40 | |
*** bhavikdbavishi has quit IRC | 11:43 | |
*** ykarel_ is now known as ykarel | 11:47 | |
*** rlandy|rover is now known as rlandy|rover|mtg | 12:14 | |
*** jcapitao_lunch is now known as jcapitao | 12:22 | |
*** AJaeger has joined #zuul | 12:28 | |
*** jpena|lunch is now known as jpena | 12:29 | |
*** wuchunyang has joined #zuul | 12:35 | |
*** wuchunyang has quit IRC | 12:42 | |
*** AJaeger has quit IRC | 13:04 | |
swest | corvus: updated 758940 with a test + minor change related to your comment | 13:21 |
*** ricolin has joined #zuul | 13:34 | |
*** rlandy|rover|mtg is now known as rlandy|rover | 13:35 | |
corvus | swest: that all makes sense, thanks! fungi, tobiash -- maybe you want to re-add your +2s | 13:36 |
fungi | swest: did you want to adjust those log calls from debug to info in a followup change? | 13:42 |
corvus | fungi: i already did that in a followup | 13:42 |
swest | fungi: done in 785972 | 13:42 |
swest | yes :) | 13:42 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Move key_store_password to keystore section in zuul.conf https://review.opendev.org/c/zuul/zuul/+/785972 | 13:43 |
corvus | rebased ^ | 13:43 |
fungi | aha, thanks. i was also looking for the [keystore] move | 13:44 |
corvus | we could squash those if we want | 13:45 |
fungi | nah, i think it's fine, i was just missing the necessary context for a bit | 13:46 |
*** arxcruz has quit IRC | 13:57 | |
*** arxcruz has joined #zuul | 13:59 | |
*** jfoufas1 has quit IRC | 14:11 | |
*** ykarel_ has joined #zuul | 14:20 | |
*** ykarel has quit IRC | 14:22 | |
*** ykarel_ is now known as ykarel | 14:29 | |
*** saneax has quit IRC | 14:56 | |
*** rlandy|rover is now known as rlandy|rover|mtg | 16:01 | |
*** rpittau is now known as rpittau|afk | 16:21 | |
*** jcapitao has quit IRC | 16:25 | |
*** hamalq has joined #zuul | 16:28 | |
*** rlandy|rover|mtg is now known as rlandy|rover | 17:05 | |
*** smyers has quit IRC | 17:07 | |
*** smyers has joined #zuul | 17:08 | |
*** clarkb has quit IRC | 17:08 | |
*** clarkb has joined #zuul | 17:08 | |
*** jpena is now known as jpena|off | 17:10 | |
*** avass has quit IRC | 17:16 | |
*** ykarel has quit IRC | 17:35 | |
*** nils has quit IRC | 17:40 | |
*** bhavikdbavishi has joined #zuul | 17:50 | |
*** bhavikdbavishi has quit IRC | 17:52 | |
*** ianychoi__ has quit IRC | 18:08 | |
*** avass has joined #zuul | 18:26 | |
*** vishalmanchanda has quit IRC | 18:44 | |
*** ironfoot has quit IRC | 21:53 | |
*** ironfoot has joined #zuul | 21:55 | |
*** rlandy|rover is now known as rlandy|rover|bbl | 22:32 | |
openstackgerrit | James E. Blair proposed zuul/zuul master: WIP: Revert "Revert "Make repo state buildset global"" https://review.opendev.org/c/zuul/zuul/+/785535 | 22:43 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Fix missing repo state restore https://review.opendev.org/c/zuul/zuul/+/785310 | 22:43 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Keep jobgraphs frozen across reconfiguration https://review.opendev.org/c/zuul/zuul/+/785536 | 22:43 |
corvus | tobiash: ^ i believe that stack should be about ready to go (we'll see what the tests say). we will need to squash the last 2 changes, but i left them as-is for this pass to make it easier to audit the test changes. | 22:44 |
corvus | clarkb: ^ fyi | 22:44 |
clarkb | corvus: ok, I don't know I'll get to reviewing it today, but can put it on the list for tomorrow morning | 22:45 |
corvus | clarkb: no rush; just keeping you up to date on it | 22:46 |
clarkb | thanks | 22:47 |
*** hamalq has quit IRC | 22:57 | |
*** hamalq has joined #zuul | 22:57 | |
*** tosky has quit IRC | 23:29 | |
*** irclogbot_1 has quit IRC | 23:50 | |
*** irclogbot_2 has joined #zuul | 23:57 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!