| corvus | https://github.com/python/cpython/blob/master/Lib/logging/__init__.py#L1610 | 00:00 |
|---|---|---|
| corvus | exc_info is currently getting called for every exception that we log | 00:00 |
| corvus | (whenever we do "log.exception(...)" | 00:00 |
| corvus | so if we need that, we have a lot of exception handlers to update | 00:01 |
| corvus | fungi: do you want to +3 https://review.opendev.org/784458 ? | 00:03 |
| *** sduthil has quit IRC | 00:07 | |
| *** hamalq has quit IRC | 00:47 | |
| *** sshnaidm|afk is now known as sshnaidm|off | 01:27 | |
| *** ajitha has joined #zuul | 01:46 | |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Periodically clean up leaked semaphores https://review.opendev.org/c/zuul/zuul/+/784523 | 02:02 |
| *** evrardjp has quit IRC | 02:33 | |
| *** evrardjp has joined #zuul | 02:33 | |
| *** ykarel|away has joined #zuul | 03:29 | |
| *** ykarel_ has joined #zuul | 03:40 | |
| *** ykarel|away has quit IRC | 03:44 | |
| *** vishalmanchanda has joined #zuul | 04:02 | |
| openstackgerrit | Merged zuul/zuul master: Fix SemaphoreHandler leak https://review.opendev.org/c/zuul/zuul/+/784458 | 04:22 |
| *** sanjayu__ has joined #zuul | 05:25 | |
| tobiash | corvus, clarkb: commented on https://review.opendev.org/c/zuul/zuul/+/784142 | 05:25 |
| tobiash | semaphore fix lgtm | 05:28 |
| *** ajitha has quit IRC | 06:05 | |
| *** vishalmanchanda has quit IRC | 06:11 | |
| *** ykarel__ has joined #zuul | 06:32 | |
| *** ykarel_ has quit IRC | 06:34 | |
| *** jcapitao has joined #zuul | 06:36 | |
| *** hashar has joined #zuul | 07:44 | |
| *** ykarel_ has joined #zuul | 08:06 | |
| *** ykarel__ has quit IRC | 08:09 | |
| *** tosky has joined #zuul | 08:09 | |
| *** ricolin has quit IRC | 08:51 | |
| *** ykarel_ has quit IRC | 10:15 | |
| *** hashar has quit IRC | 10:22 | |
| *** jcapitao is now known as jcapitao_lunch | 10:31 | |
| *** ykarel has joined #zuul | 11:17 | |
| *** jcapitao_lunch is now known as jcapitao | 11:53 | |
| *** rlandy has joined #zuul | 12:03 | |
| *** ykarel has quit IRC | 12:05 | |
| *** hashar has joined #zuul | 13:31 | |
| *** tosky has quit IRC | 14:01 | |
| *** openstackstatus has joined #zuul | 14:32 | |
| *** ChanServ sets mode: +v openstackstatus | 14:32 | |
| clarkb | tobiash: isn't fetch and reset the way we move branch HEADs forward though? | 14:41 |
| clarkb | tobiash: in this particular case that is all we are missing, essentially the upstream ref is point at N+1 and locally we have ref pointing to N with 1 also separately present | 14:41 |
| clarkb | I'll have to dig through the executor and merger git repo setup process to see where else we might want to do this instead | 14:42 |
| clarkb | it does seem like updateRepo is related to catting files which may not be in the expected just give me the up to date repo path | 14:44 |
| clarkb | the path in the executor server seems to be: Start by updating all repos that the job depends on (this goes through merger.updateRepo which calls isUpdateNeeded), then update all the repos from which playbooks/roles are consumed using the same updateRepo tooling, then it calls merge changes which only operates on the items (eg changes) list which won't update a related change that we just want an | 15:00 |
| clarkb | updated master for, then it sets the refs on the executor so that the git refs seens by the job are appropriate | 15:00 |
| clarkb | tobiash: ^ based on my reading of that the updateRepo path which relies on isUpdateNeeded() seems like the best place for checking this? | 15:00 |
| clarkb | tobiash: the restore repo state is a side effect of this last step which is setting up refs/remotes/origin and friends aiui | 15:01 |
| clarkb | I think that is correct though maybe slightly confusing in that we're restoring something that was never really there before? | 15:02 |
| clarkb | (mroe accurately we are setting what we want to see but it is logged as a restore) | 15:02 |
| clarkb | I need breakfast and tea, but then will go over that again to make sure on a second apss in the morning it all still makes sense | 15:04 |
| *** jcapitao is now known as jcapitao_afk | 15:42 | |
| *** hamalq has joined #zuul | 16:27 | |
| *** jcapitao_afk is now known as jcapitao | 16:57 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate your first patch" https://review.opendev.org/c/zuul/zuul/+/732067 | 17:03 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "Use zuul jobs" https://review.opendev.org/c/zuul/zuul/+/732068 | 17:03 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate pipeline" https://review.opendev.org/c/zuul/zuul/+/732069 | 17:03 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "job secrets" https://review.opendev.org/c/zuul/zuul/+/732070 | 17:03 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: [DNM] run TestSchedulerSSL test with pending gear change https://review.opendev.org/c/zuul/zuul/+/780261 | 17:03 |
| avass | clarkb: what is the problem you're debugging? | 17:11 |
| fungi | avass: it's fairly well described by the test scenario in 784142 | 17:11 |
| avass | I'll take a look | 17:11 |
| fungi | basically what we observed was with two projects sharing an integration test job, we merged a change to the first project, then triggered a build of the job on the second project and it continued to get teh old branch state for the first project rather than the state with the recently merged change | 17:12 |
| fungi | the merger on the executor had the new merged state of the first project because that was also the branch tip, but kept setting up the previous branch state in the build | 17:13 |
| fungi | i should say, it had the ref for the new branch state, but kept using the old branch state | 17:14 |
| *** jcapitao has quit IRC | 17:20 | |
| avass | yeah that sounds like it could be the same thing we've seen a couple of times. I haven't really dug into what our problem was exactly, but I'll check when I'm back at work on monday. | 17:21 |
| clarkb | avass: thanks | 17:29 |
| clarkb | fwiw I got distracted with gerrit things, realized itw asnt' going to be a quick run of scripts and done so I'm probably going to be slow getting back and triple checking the repo update process | 17:29 |
| *** hashar has quit IRC | 18:12 | |
| avass | just realized monday is a holiday so make that tuesday instead :) | 18:22 |
| *** sanjayu__ has quit IRC | 18:38 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: [DNM] run TestSchedulerSSL test with pending gear change https://review.opendev.org/c/zuul/zuul/+/780261 | 18:39 |
| *** tosky has joined #zuul | 19:20 | |
| *** hamalq has quit IRC | 20:08 | |
| *** hamalq has joined #zuul | 20:08 | |
| *** rlandy has quit IRC | 20:57 | |
| *** tosky has quit IRC | 23:19 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!