Thursday, 2021-03-11

*** jamesmcarthur has quit IRC00:17
*** tosky has quit IRC00:26
*** jamesmcarthur has joined #zuul01:19
*** jamesmcarthur has quit IRC02:32
*** SotK has quit IRC02:36
*** Phoenikzz has quit IRC02:36
*** SotK has joined #zuul02:37
*** jamesmcarthur has joined #zuul02:39
*** jamesmcarthur has quit IRC03:19
*** jamesmcarthur has joined #zuul03:21
*** jamesmcarthur has quit IRC03:23
*** jamesmcarthur has joined #zuul03:23
*** openstackgerrit has quit IRC03:25
corvustobiash: regarding https://review.opendev.org/775438 -- have you verified that if nodepool starts to launch an openstack node, then you change the config file so the provider gets replaced while the node is building, that node builds to completion?  i'm concerned that the provider.stop() method may be called and therefore terminate the server list thread, and then the launch thread will get no further03:54
corvusupdates.03:54
corvustobiash: i have that problem with the statemachine driver, and since it's the same design, suspect it may happen for the server list thread03:55
corvustobiash: i'm thinking an easy fix is to have that stop method wait until there are no active launch threads  (or launch/delete state machines in my case)03:56
*** saneax has joined #zuul04:08
*** openstackgerrit has joined #zuul04:12
openstackgerritJames E. Blair proposed zuul/nodepool master: Support threadless deletes  https://review.opendev.org/c/zuul/nodepool/+/77963704:12
openstackgerritJames E. Blair proposed zuul/nodepool master: WIP: add azure state machine driver  https://review.opendev.org/c/zuul/nodepool/+/77942004:12
openstackgerritJames E. Blair proposed zuul/nodepool master: Azure: delete disk based on VM reference  https://review.opendev.org/c/zuul/nodepool/+/77989704:12
openstackgerritJames E. Blair proposed zuul/nodepool master: Azure: reconcile config objects  https://review.opendev.org/c/zuul/nodepool/+/77989804:12
*** evrardjp has quit IRC05:33
*** evrardjp has joined #zuul05:33
*** jfoufas1 has joined #zuul05:34
*** wuchunyang has joined #zuul05:35
*** wuchunyang has quit IRC05:40
*** jamesmcarthur has quit IRC05:47
*** zbr6 has joined #zuul06:03
*** saneax has quit IRC06:05
*** zbr has quit IRC06:06
*** zbr6 is now known as zbr06:06
*** saneax has joined #zuul06:08
*** sanjayu_ has joined #zuul06:12
*** saneax has quit IRC06:15
*** sanjayu__ has joined #zuul06:24
*** sanjayu_ has quit IRC06:26
*** paulalbertella has quit IRC06:49
*** reiterative has joined #zuul06:49
openstackgerritSimon Westphahl proposed zuul/zuul master: Allow (de-)serialization of management events  https://review.opendev.org/c/zuul/zuul/+/76116407:44
openstackgerritSimon Westphahl proposed zuul/zuul master: Allow (de-)serialization of result events  https://review.opendev.org/c/zuul/zuul/+/76116507:44
openstackgerritSimon Westphahl proposed zuul/zuul master: Add and fix fields in driver trigger event models  https://review.opendev.org/c/zuul/zuul/+/76116607:44
openstackgerritSimon Westphahl proposed zuul/zuul master: Allow (de-)serialization of trigger events  https://review.opendev.org/c/zuul/zuul/+/76116707:44
*** jamesmcarthur has joined #zuul07:47
*** jamesmcarthur has quit IRC07:52
*** jcapitao has joined #zuul07:58
*** hashar has joined #zuul08:08
openstackgerritJonas Sticha proposed zuul/nodepool master: aws: add support for uploading diskimages  https://review.opendev.org/c/zuul/nodepool/+/73521708:17
openstackgerritJonas Sticha proposed zuul/nodepool master: aws: add image upload test  https://review.opendev.org/c/zuul/nodepool/+/77584408:17
*** jpena|off is now known as jpena08:33
*** tosky has joined #zuul08:33
*** sanjayu__ has quit IRC08:47
*** tosky_ has joined #zuul08:52
*** tosky is now known as Guest8681408:53
*** tosky_ is now known as tosky08:53
*** Guest86814 has quit IRC08:55
*** saneax has joined #zuul09:36
openstackgerritSorin Sbârnea proposed zuul/zuul-client master: Validate project metadata  https://review.opendev.org/c/zuul/zuul-client/+/76557009:57
openstackgerritSorin Sbârnea proposed zuul/zuul-client master: Validate project metadata  https://review.opendev.org/c/zuul/zuul-client/+/76557010:01
openstackgerritSimon Westphahl proposed zuul/zuul master: Component Registry in ZooKeeper  https://review.opendev.org/c/zuul/zuul/+/75918710:09
openstackgerritSimon Westphahl proposed zuul/zuul master: Component Registry in ZooKeeper  https://review.opendev.org/c/zuul/zuul/+/75918710:10
zbravass: tristanC: https://review.opendev.org/c/zuul/zuul-jobs/+/779276 is ready (low hanging)10:11
swestcorvus: I think it's easier you abandon the superseded changes as it seems that I'm only allowed to do that for my own changes.10:17
openstackgerritSimon Westphahl proposed zuul/zuul master: Move management and result events to model  https://review.opendev.org/c/zuul/zuul/+/76116310:21
openstackgerritSimon Westphahl proposed zuul/zuul master: Allow (de-)serialization of management events  https://review.opendev.org/c/zuul/zuul/+/76116410:21
openstackgerritSimon Westphahl proposed zuul/zuul master: Allow (de-)serialization of result events  https://review.opendev.org/c/zuul/zuul/+/76116510:21
openstackgerritSimon Westphahl proposed zuul/zuul master: Add and fix fields in driver trigger event models  https://review.opendev.org/c/zuul/zuul/+/76116610:21
openstackgerritSimon Westphahl proposed zuul/zuul master: Allow (de-)serialization of trigger events  https://review.opendev.org/c/zuul/zuul/+/76116710:21
openstackgerritSimon Westphahl proposed zuul/zuul master: Interface to get a driver's trigger event class  https://review.opendev.org/c/zuul/zuul/+/76116810:21
openstackgerritSimon Westphahl proposed zuul/zuul master: Implementation of Zookeeper backed event queues  https://review.opendev.org/c/zuul/zuul/+/76117010:21
openstackgerritSimon Westphahl proposed zuul/zuul master: Implementation of Zookeeper event watcher  https://review.opendev.org/c/zuul/zuul/+/76117110:21
openstackgerritSimon Westphahl proposed zuul/zuul master: Switch to Zookeeper backed trigger event queues  https://review.opendev.org/c/zuul/zuul/+/76375410:21
openstackgerritSimon Westphahl proposed zuul/zuul master: Switch to Zookeeper backed management event queues  https://review.opendev.org/c/zuul/zuul/+/76173810:21
avasszbr: lgtm10:25
swestcorvus: addressed/responded to your comments in #sos. I also added some new changes to the stack10:36
*** jangutter_ has quit IRC10:41
*** jangutter has joined #zuul10:42
tobiashswest, corvus: abandoning done10:54
*** jangutter has quit IRC11:07
*** jangutter has joined #zuul11:07
*** jcapitao is now known as jcapitao_lunch11:23
openstackgerritTobias Henkel proposed zuul/nodepool master: Fix possible thread leak  https://review.opendev.org/c/zuul/nodepool/+/77998611:28
tobiashcorvus: re nodepool threading:I think this should address your concern ^11:29
tobiashthat ensures that all threads are woken up in this case and continue their work as they would have without the thread optimization11:30
tobiashdownside is that this triggers the old non-optimized behavior on config changes until the work is done11:33
openstackgerritTobias Henkel proposed zuul/nodepool master: Fix possible thread leak  https://review.opendev.org/c/zuul/nodepool/+/77998711:34
tobiashI think this should work the same but avoids the pitfall ^11:35
openstackgerritMerged zuul/zuul-jobs master: Bits to keep ansible-lint happy  https://review.opendev.org/c/zuul/zuul-jobs/+/77927611:41
*** jangutter has quit IRC11:42
*** jangutter has joined #zuul11:42
openstackgerritSorin Sbârnea proposed zuul/zuul master: Document tox environments  https://review.opendev.org/c/zuul/zuul/+/76646011:50
*** saneax has quit IRC11:52
*** jangutter_ has joined #zuul11:59
*** jangutter has quit IRC12:02
openstackgerritSorin Sbârnea proposed zuul/zuul-jobs master: Upgrade ansible-lint to 5.0  https://review.opendev.org/c/zuul/zuul-jobs/+/77324512:03
*** jpena is now known as jpena|lunch12:35
openstackgerritSorin Sbârnea proposed zuul/zuul-jobs master: Upgrade ansible-lint to 5.0  https://review.opendev.org/c/zuul/zuul-jobs/+/77324512:56
*** openstack has joined #zuul13:17
*** ChanServ sets mode: +o openstack13:17
*** jpena|lunch is now known as jpena13:30
*** jangutter has joined #zuul13:45
*** jangutter_ has quit IRC13:48
zbravass: https://review.opendev.org/c/zuul/zuul-jobs/+/773245 is ready for review (ansible-lint v5)14:28
*** jangutter_ has joined #zuul14:29
*** jangutter has quit IRC14:32
*** nils has joined #zuul14:47
*** chandankumar is now known as raukadah15:02
*** spotz has joined #zuul15:10
*** saneax has joined #zuul15:19
*** GomathiselviS has joined #zuul15:26
GomathiselviSHi, Requesting review on https://review.opendev.org/c/zuul/zuul-jobs/+/77347415:27
*** jfoufas1 has quit IRC15:41
*** jamesmcarthur has joined #zuul15:46
*** harrymichal has quit IRC15:48
*** harrymichal has joined #zuul15:49
*** jangutter has joined #zuul15:52
*** jangutter_ has quit IRC15:54
*** harrymichal has quit IRC15:59
*** harrymichal has joined #zuul15:59
*** MapspaM is now known as SpamapS16:04
avasszbr: what's 'no-handler' ?16:08
zbravass: is not a new rule, mainly indicates that a task could better be moved to a handler, when it finds "when: foo is changed".16:08
zbrthe official guidelines recommend use of handlers for these, but that is not really very popular in practice.16:09
zbrand my goal was not to refactor the code16:09
avassyeah I don't think I ever use handlers16:09
*** harrymichal has quit IRC16:09
zbrthey are cool, can make few things quite nice and clean, but they have their own gotchas too16:10
zbrclassical example is using one to restart the service at the end of role or playbook, when in fact there are multiple locations which could decide that a restarts is needed.16:11
zbrusing handlers you run it only once16:11
avassah16:11
avassany reason why you needed to do the change from command to shell in the test-playbooks? :)16:12
avassoh and I suppose ansible-lint completely replaces ansible-playbook --syntax-check now?16:13
zbryep, I had to add the PATH16:13
avassI would have put that in 'environment:'16:13
zbrin fact ansible-lint runs syntax check on playbooks, even before it checks the other rules.16:13
zbrit does not work like that, I cannot add entry to PATH using environment.16:13
zbri did not want to override the default system path.16:14
fungiwe use some handlers in opendev's system-config repo, particularly for service restarts when specific config files have changed16:14
zbrthat avoids a nasty bug where linter may endup calling ansible from outside the virtualenv, a version that may not be compatible with it.16:14
avasszbr: you can with PATH: "{{ ansible_env.PATH }}:..." :)16:15
zbrwhen you run ansible-lint --version, it now also prints the version of ansible you got.16:15
zbryeah, if gather facts happened, that would work. I can change if you want.16:16
clarkbthe biggest problem we've had with handlers is they sometimes decide not tofire for some unknown reason16:16
clarkbbut it is infrequent16:16
avassdoesn't really matter, just checking why you added it16:16
zbrclarkb:  is right, there are cases where you have less control over when they fire or not16:16
avasstristanC: software factory fails on zbr's change with 'No package python-devel available'16:17
zbrI doubt i added that anywhere, it seems unrelated to me.16:18
zbrthat python-devel is the py27 one, something I don't plan to see anymore ;)16:19
avassno it's from the bindep.txt so it seems irrelevant to your change16:19
tristanCavass: oh right, that seems to be an issue where zuul-jobs bindep.txt isn't compatible with ubi8 image16:20
zbrin fact there are few wrong bits in zuul bindep file too, i often discover them because I have tox-bindep plugin installed, which checks them before running tox.16:20
zbri would recommend others to test it, is a nice way to validate how well our bindep.txt files cover a specific platform.16:21
avassi think bindep hasn't worked very well on manjaro/arch so far :)16:22
zbrinstead of writing docs about how to install dev deps, i squeeze it to tox.ini file, and it will inform the unlucky developer about what he may be missing.16:22
zbravass: neither on macos ;)16:23
*** jamesmcarthur has quit IRC16:28
*** jamesmcarthur has joined #zuul16:30
*** jangutter_ has joined #zuul16:37
*** jangutter has quit IRC16:40
*** saneax has quit IRC16:44
fungiavass: the recent release has some archlinux fixes in it. i don't know that it's got specific manjaro support though16:49
fungibut adding manjaro, if relevant, would be considered in scope for the tool16:49
*** harrymichal has joined #zuul16:55
*** harrymichal has quit IRC16:56
*** harrymichal has joined #zuul16:56
openstackgerritMatthieu Huin proposed zuul/zuul master: web UI: user login with OpenID Connect  https://review.opendev.org/c/zuul/zuul/+/73408216:57
openstackgerritMatthieu Huin proposed zuul/zuul master: Add authentication-realm attribute to tenants  https://review.opendev.org/c/zuul/zuul/+/73558616:59
*** harrymichal has quit IRC17:01
avassfungi: If it works for arch it probably works for manjaro. I'll check it out17:05
openstackgerritMerged zuul/zuul-client master: Validate project metadata  https://review.opendev.org/c/zuul/zuul-client/+/76557017:07
fungiavass: also, platform-specific fixes are most welcome. we try to support a variety of platforms we can't easily test on17:08
*** jangutter has joined #zuul17:26
*** jangutter_ has quit IRC17:30
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: bindep.txt: skip python-devel for el8 platform  https://review.opendev.org/c/zuul/zuul-jobs/+/78005017:31
clarkbtristanC: does centos-8 match el8? if so can we simplify that rule?17:36
*** jcapitao has quit IRC17:40
tristanCclarkb: do you know how to test the bindep rule? it seems like centos does have `PLATFORM_ID="platform:el8"` in /etc/os-release, or at least from the registry.centos.org/centos:8 image17:40
clarkbtristanC: ya there is a bindep command to print out the matching platforms. Let me find it17:41
tristanCbut my change doesn't work, it still tried to install python-devel on ubi817:41
clarkbtristanC: I think it is bindep --profiles17:41
clarkbtristanC: you want to start a ubi8 then run ^ to see which things match it iirc17:42
tristanCclarkb: in that case, centos-8 matches platform:centos-8, and ubi-8 matches platform:rhel-817:43
tristanCso is this not coming from the PLATFORM_ID in /etc/os-release?17:43
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: bindep.txt: skip python-devel for el8 platform  https://review.opendev.org/c/zuul/zuul-jobs/+/78005017:44
*** jpena is now known as jpena|off17:44
clarkbtristanC: it uses python-distro to interpret os-release, I'm not sure of what specific details in os-release are used though17:44
tristanCavass: zbr: here is a fix for test-job-unittests-ubi8 : https://review.opendev.org/c/zuul/zuul-jobs/+/78005017:50
fungitristanC: clarkb: https://opendev.org/opendev/bindep/src/branch/master/bindep/depends.py#L329-L33017:51
tristanCclarkb: alright, well i guess that is enough, thank you for the details17:51
avasstristanC: lgtm17:53
fungithere are also some defined distro aliases in bindep: https://opendev.org/opendev/bindep/src/branch/master/bindep/depends.py#L357-L42817:53
*** jangutter_ has joined #zuul17:53
fungiwhich allows for a bit more flexibility in how they're called17:53
*** jangutter has quit IRC17:57
*** harrymichal has joined #zuul18:01
*** harrymichal has quit IRC18:02
*** harrymichal has joined #zuul18:02
zbrthe change that documents dev commands (yarn) is ready for review: https://review.opendev.org/c/zuul/zuul/+/76646018:03
zbronce we upgrade ansible-lint to v5 on zuul-jobs, I will also merge https://github.com/ansible-community/ansible-lint/pull/1460/files -- which will prevent us being surprised by linter changes.18:22
* zbr thinks that bindep does not support Rocky yet :p 18:25
clarkbrocky?18:26
*** hashar is now known as hasharDinner18:26
zbrnot that openstack rocky, the other one ;)18:26
clarkbI guess I don't know what the other one is18:27
* mordred either18:27
mordredoh!18:30
mordredclarkb: https://rockylinux.org/18:30
mordredclarkb: the new replacement for centos now that centos got killed18:30
zbri wished they would have named it KennyLinux18:31
clarkbbindep should work with it as long as it sets a reasonable os-reelase. But bindep may need an update to identify it as an rpm distro18:31
fungiyeah, i suspect worst case we could get away with adding a distro alias for it in bindep (see above linked code block)18:35
fungithat'll depend on how it reports itself though, correct18:35
avasszbr: did ansible lint ditch zuul for ci?18:38
*** harrymichal has quit IRC18:42
*** harrymichal has joined #zuul18:42
*** harrymichal has quit IRC18:44
*** jamesmcarthur has quit IRC18:52
*** jamesmcarthur has joined #zuul18:55
*** hamalq has joined #zuul19:01
*** hasharDinner is now known as hashar19:02
zbryes, long time ago19:13
*** nils has quit IRC19:23
openstackgerritTristan Cacqueray proposed zuul/zuul master: Get executor job params  https://review.opendev.org/c/zuul/zuul/+/60707819:35
*** GomathiselviS has quit IRC19:39
openstackgerritTristan Cacqueray proposed zuul/zuul master: Separate out executor server from runner  https://review.opendev.org/c/zuul/zuul/+/60707919:44
openstackgerritTristan Cacqueray proposed zuul/zuul master: Move repository preparation into common class  https://review.opendev.org/c/zuul/zuul/+/64864219:45
openstackgerritTristan Cacqueray proposed zuul/zuul master: Separate out executor concerns from AnsibleJob  https://review.opendev.org/c/zuul/zuul/+/64864319:46
openstackgerritTristan Cacqueray proposed zuul/zuul master: runner: implement prep-workspace  https://review.opendev.org/c/zuul/zuul/+/60708219:47
openstackgerritTristan Cacqueray proposed zuul/zuul master: runner: add configuration schema  https://review.opendev.org/c/zuul/zuul/+/64067219:47
openstackgerritTristan Cacqueray proposed zuul/zuul master: runner: add prepare-workspace command line interface  https://review.opendev.org/c/zuul/zuul/+/64477019:47
openstackgerritTristan Cacqueray proposed zuul/zuul master: runner: add execute sub-command  https://review.opendev.org/c/zuul/zuul/+/63094419:47
*** jamesmcarthur has quit IRC19:47
*** jamesmcarthur has joined #zuul19:48
*** jamesmcarthur has quit IRC19:53
openstackgerritAlbin Vass proposed zuul/nodepool master: Add quota information to aws driver  https://review.opendev.org/c/zuul/nodepool/+/77986820:16
avasstobiash_: that works ^20:16
*** tobiash_ is now known as tobiash20:36
tobiashavass: cool, do you want to add a test case?20:37
clarkbI'm noticing what I think is a bug in nodepool's dummy records for cleaning up leaked isntances. I've got a relatively small number of them in a few regions that all fail to delete. Checking the cloud directly those instances don't exist (using uuid to look them up). I think nodepool should notice the instance just isn't there and remove the dummy record entirely?20:51
clarkbI'm not in a good spot to debug further right now and it isn't a major impact, but I thought I would mention it in case anyone else is familiar with it20:51
clarkbalso it seems the bug may have been around for a while given some of the node ids involved20:51
clarkbI'll try to dig in properly tomorrow20:52
corvusclarkb: that is what is supposed to happen (it should try to delete the node, see it doesn't exist, then delete the record).  are those records locked?20:54
clarkbyes those records are reported locked by the nodepool listing output20:55
corvusmaybe locked by a stuck delete thread or something?20:55
clarkbah ya could be I guess20:55
clarkbthen other attempts to clean them up will just sort of skip along20:55
corvusyep; next debug step would probably be to ask zk who holds the lock20:58
clarkbok, my afternoon is largely spoken for at this point (meetings and then meetings with people who want to fix a leak on the side of my house) but I'll try to look at it more closely tomorrow21:00
avasstobiash: I'll see if I can add something tomorrow21:06
corvusyeah i'm also booked for the day, sorry21:06
avasstobiash: acutally maybe I'll just try to fix the tests I broke since moto doesn't seem to support the cpu_options attribute :)21:10
*** hamalq has quit IRC21:30
*** hamalq has joined #zuul21:31
*** hashar has quit IRC21:51
*** hamalq has quit IRC22:38
*** fdegir has quit IRC23:10
*** fdegir has joined #zuul23:10
*** jamesmcarthur has joined #zuul23:16
*** jamesmcarthur has quit IRC23:41
*** sduthil has quit IRC23:44
*** jamesmcarthur has joined #zuul23:52
*** jamesmcarthur has quit IRC23:57

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!