Monday, 2021-03-01

*** tosky has quit IRC00:11
*** cloudnull has joined #zuul03:15
*** ykarel has joined #zuul03:16
*** akrpan-pure has joined #zuul03:34
*** akrpan-pure has quit IRC04:34
*** cloudnull has quit IRC04:58
*** cloudnull has joined #zuul05:00
*** akrpan-pure has joined #zuul05:20
*** cloudnull has quit IRC05:31
*** evrardjp has quit IRC05:33
*** cloudnull has joined #zuul05:33
*** evrardjp has joined #zuul05:33
*** akrpan-pure has quit IRC05:49
*** cloudnull has quit IRC06:13
*** jfoufas1 has joined #zuul06:14
*** cloudnull has joined #zuul06:14
*** etp has quit IRC06:54
*** decimuscorvinus_ has quit IRC07:00
*** etp has joined #zuul07:01
*** decimuscorvinus has joined #zuul07:05
*** jfoufas1 has quit IRC07:08
*** cloudnull has quit IRC07:10
*** piotrowskim has joined #zuul07:12
*** cloudnull has joined #zuul07:15
*** etp has quit IRC07:17
*** etp has joined #zuul07:19
*** ykarel has quit IRC07:20
*** ykarel has joined #zuul07:26
openstackgerritAlbin Vass proposed zuul/zuul master: Add messages to make the job setup more transparent  https://review.opendev.org/c/zuul/zuul/+/77788507:52
*** rpittau|afk is now known as rpittau08:04
*** cloudnull has quit IRC08:10
*** cloudnull has joined #zuul08:14
*** jcapitao has joined #zuul08:16
*** tosky has joined #zuul08:20
*** jangutter_ has joined #zuul08:43
*** jangutter has quit IRC08:47
*** zbr1 has joined #zuul08:58
*** zbr has quit IRC09:01
*** zbr1 is now known as zbr09:01
*** zbr8 has joined #zuul09:06
*** ykarel is now known as ykarel|lunch09:06
*** zbr has quit IRC09:08
*** zbr8 is now known as zbr09:08
*** jfoufas1 has joined #zuul09:08
*** holser has joined #zuul09:16
*** holser has quit IRC09:17
*** holser has joined #zuul09:17
*** ttx has quit IRC09:20
*** ttx has joined #zuul09:21
*** hashar has joined #zuul09:21
*** holser has quit IRC09:24
*** zbr1 has joined #zuul09:27
*** zbr1 has quit IRC09:27
*** zbr has quit IRC09:29
*** holser has joined #zuul09:31
openstackgerritSimon Westphahl proposed zuul/zuul master: Improve typings in context of builds via ZooKeeper  https://review.opendev.org/c/zuul/zuul/+/75357809:35
openstackgerritSimon Westphahl proposed zuul/zuul master: Make ZooKeeper mandatory for Scheduler  https://review.opendev.org/c/zuul/zuul/+/75671609:35
openstackgerritSimon Westphahl proposed zuul/zuul master: Move setupZK() helper function to BaseTestCase class  https://review.opendev.org/c/zuul/zuul/+/77663909:35
openstackgerritSimon Westphahl proposed zuul/zuul master: Initialize ZooKeeper connection in server rather than in cmd classes  https://review.opendev.org/c/zuul/zuul/+/77664009:35
openstackgerritSimon Westphahl proposed zuul/zuul master: Make ConnectionRegistry mandatory for Scheduler  https://review.opendev.org/c/zuul/zuul/+/75709509:35
openstackgerritSimon Westphahl proposed zuul/zuul master: Improve typings in context of 756716 and 757095  https://review.opendev.org/c/zuul/zuul/+/75714809:35
openstackgerritSimon Westphahl proposed zuul/zuul master: Instantiate executor client, merger, nodepool and app within Scheduler  https://review.opendev.org/c/zuul/zuul/+/75714909:35
openstackgerritSimon Westphahl proposed zuul/zuul master: Improve typings in context of lock nodes on executor  https://review.opendev.org/c/zuul/zuul/+/75709709:35
openstackgerritSimon Westphahl proposed zuul/zuul master: DNM: Reduce number of jobs for SOS development  https://review.opendev.org/c/zuul/zuul/+/77508109:35
*** jpenag is now known as jpena09:42
*** zbr has joined #zuul09:43
*** ykarel|lunch is now known as ykarel09:54
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Update tests/base.py to use proper git data  https://review.opendev.org/c/zuul/zuul/+/74274610:00
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Fix gerrit merge commit change with zuul configuration  https://review.opendev.org/c/zuul/zuul/+/76288610:00
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Fix zuul-client enqueue-ref when oldrev/newrev aren't provided  https://review.opendev.org/c/zuul/zuul/+/76576710:00
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Improve merger getFilesChanges, Fix edge cases  https://review.opendev.org/c/zuul/zuul/+/76288710:00
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Add tests  https://review.opendev.org/c/zuul/zuul/+/74274710:00
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Reorg scheduler event process loop  https://review.opendev.org/c/zuul/zuul/+/74274810:00
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Scheduler ref-updated create/delete  https://review.opendev.org/c/zuul/zuul/+/73919810:00
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Allow ref-updated newrev+oldrev reconfiguration  https://review.opendev.org/c/zuul/zuul/+/74274910:00
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Get ref-updated modified files  https://review.opendev.org/c/zuul/zuul/+/73907810:00
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "Use zuul jobs"  https://review.opendev.org/c/zuul/zuul/+/73206810:12
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate pipeline"  https://review.opendev.org/c/zuul/zuul/+/73206910:12
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "job secrets"  https://review.opendev.org/c/zuul/zuul/+/73207010:12
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "job dependencies"  https://review.opendev.org/c/zuul/zuul/+/73207110:12
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Rename quick-start to zuul-tutorial-quick-start  https://review.opendev.org/c/zuul/zuul/+/73765610:12
*** nils has joined #zuul10:26
*** harrymichal has joined #zuul10:40
*** jangutter has joined #zuul10:41
*** jangutter has quit IRC10:42
*** jangutter has joined #zuul10:43
*** jangutter_ has quit IRC10:44
*** jfoufas1 has quit IRC10:50
*** fbo|off is now known as fbo10:52
*** jangutter_ has joined #zuul11:02
*** jangutter has quit IRC11:05
*** jcapitao is now known as jcapitao_lunch11:54
*** yoctozepto has quit IRC12:17
*** yoctozepto has joined #zuul12:17
*** saneax has joined #zuul12:20
*** rlandy has joined #zuul12:29
*** jpena is now known as jpena|lunch12:32
*** zbr has quit IRC12:34
*** zbr has joined #zuul12:36
openstackgerritMatthieu Huin proposed zuul/zuul master: Spec: external permissions for the REST admin API  https://review.opendev.org/c/zuul/zuul/+/77762912:42
*** harrymichal has quit IRC12:49
*** ikhan has joined #zuul12:50
*** jcapitao_lunch is now known as jcapitao13:13
*** jfoufas1 has joined #zuul13:16
*** ykarel has quit IRC13:19
*** ykarel has joined #zuul13:20
*** jpena|lunch is now known as jpena13:24
*** sduthil has joined #zuul13:31
*** jangutter has joined #zuul13:33
*** jangutter_ has quit IRC13:37
*** jangutter_ has joined #zuul13:44
*** jangutter has quit IRC13:47
*** ikhan has quit IRC13:58
*** ikhan has joined #zuul13:59
*** jangutter has joined #zuul14:16
*** jangutter_ has quit IRC14:20
*** jangutte_ has joined #zuul14:20
*** jangutter has quit IRC14:23
jpenamnaser: we have identified an issue with our networking configuration. Currently, the public network has two subnets (38.102.../24 and 38.129.../24). However, I see all routers from our tenant private networks end up with an IP from the first subnet14:37
jpenathat's effectively preventing us from getting IPs from the second subnet, and I see no way to force the pool you get the subnet from when you create a router14:38
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Allow ref-updated newrev+oldrev reconfiguration  https://review.opendev.org/c/zuul/zuul/+/74274914:38
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Get ref-updated modified files  https://review.opendev.org/c/zuul/zuul/+/73907814:38
jpenasorry, wrong channel14:38
openstackgerritJames E. Blair proposed zuul/zuul master: Update zoned executor stats  https://review.opendev.org/c/zuul/zuul/+/77785215:17
openstackgerritJames E. Blair proposed zuul/zuul master: Optionally allow zoned executors to process unzoned jobs  https://review.opendev.org/c/zuul/zuul/+/67384015:23
*** SaifAddin has joined #zuul15:31
*** harrymichal has joined #zuul15:31
SaifAddinHi, I have a pre-run playbook on a job, that is supposed to load variables to make them available for the actual run.15:38
SaifAddinThe pre-run has a task that loads all variables inside a `set-facts:` - `cacheable: true` combination15:39
SaifAddinbut that alone doesn't work, it is only working (i.e. finding variables) when I also put the variable values in the `vars` folder yaml15:39
SaifAddinBut it is super ugly to have the variables repeated in two places15:40
corvuszuul-maint: 15:40 < openstackgerrit> James E. Blair proposed openstack/project-config master: Allow all registered users to edit hashtags on all Zuul projects  https://review.opendev.org/c/openstack/project-config/+/77801215:42
corvusSaifAddin: i don't know what the problem could be; all i can do at this point is reassure you that i would expect a cacheable fact to work and we use that frequently in zuul-jobs15:43
SaifAddinThank you corvus, that is reasuring15:44
SaifAddinI am figuring out why the variables I put in the cacheable facts are not found until I put them also in the vars15:44
tobiashcorvus: is it on purpose that zuul-client isn't listed there? ^15:45
corvustobiash: no... maybe my repo is out of date15:45
corvustobiash: or maybe zuul-client just uses the zuul config file15:45
corvustobiash: it's the latter -- it uses zuul.config15:46
tobiashk15:46
*** sassyn has quit IRC15:48
tobiashclarkb: could you put https://review.opendev.org/c/zuul/zuul/+/752056 (github request optimization) to your re-review list? I think the last ps was a rebase.15:50
*** jfoufas1 has quit IRC16:00
openstackgerritAndy Ladjadj proposed zuul/zuul master: [web][config] move timezone component to preferences  https://review.opendev.org/c/zuul/zuul/+/75592916:11
corvustristanC: you previously reviewed circular deps in https://review.opendev.org/685354 -- do you want to take another look at that and my followup in https://review.opendev.org/777843 ?16:13
openstackgerritAndy Ladjadj proposed zuul/zuul master: [web][config] move timezone component to preferences  https://review.opendev.org/c/zuul/zuul/+/75592916:15
openstackgerritAndy Ladjadj proposed zuul/zuul master: [web][config] move timezone component to preferences  https://review.opendev.org/c/zuul/zuul/+/75592916:17
*** ykarel is now known as ykarel|away16:28
*** SaifAddin has quit IRC16:31
*** ykarel|away has quit IRC16:33
corvusianw: you previously reviewed this github optimization: https://review.opendev.org/753571 -- would you care to re-review?16:41
*** ikhan has quit IRC16:42
corvusswest_, tobiash: can you take a look at https://review.opendev.org/761756 ?  i think primarily we want to make sure everyone understands the limitations with removing tags16:43
tobiashcorvus: I wonder if we should just delete all tags before fetching, but that might impose significant costs on every fetch16:46
corvustobiash: yeah that would be huge16:48
corvustobiash: to be clear: there is no way to gracefully handle tag deletion with git.  zuul is just encountering the same problems that any user would enconter. for that reason, nobody should ever delete tags.16:50
corvusnow if all of the users are in the same room and you can tell them all to delete their tags, that will work :)16:50
corvusbut that's sort of the exceptional case for a distributed version control system16:50
tobiashcorvus: yeah, some of our users use this to test their release pipelines using test tags :/16:50
fungitobiash: i've found pushing prereleases and release candidate tags to be a useful solution, at least on projects i help maintain16:51
corvustobiash: so it sounds like if those people never re-use the same tag, that might mostly work with this change.  (though users are going to have to add --prune-tags to avoid ending up with a big pile of unused tags)16:52
corvustobiash: if they re-use the same tag, then even this change isn't going to always work.16:52
tobiashthey don't re-use tags and don't care if they are persistent16:53
tobiashbut we all agree that's a bad practice16:53
corvustobiash: okay, sounds like we're all on the same page.  the main outcome i think we want to avoid is going down some rabbit hole of trying to make deleting tags "work for real" which we won't be able to achieve.16:56
fungii'm okay with the idea as long as we wrap any mention of it with a big noticeable disclaimer that it's of limited utility and you're better off not deleting tags because git wasn't really designed to support that properly16:59
*** rpittau is now known as rpittau|afk17:00
corvusfungi: the change as written doesn't actually mention anything in docs or release notes, it just silently changes an internal behavior.  would you be okay with that?  :)17:02
fungiyeah, i mean. we're not updating the docs to mention anything people should expect to suddenly work, so seems fine17:04
avasstobiash: yes I've had to tell people to not delete tags way too many times17:19
avassthough it would be easier if projects could re-enqueue release pipelines without admin access or creating a new tag somehow17:19
avassin case of intermittent errors17:20
*** jcapitao has quit IRC17:22
fungiin our (opendev's) case, release builds have enough nuanced side effects that reenqueuing may not work for some sorts of transient failures, and may even be destructive17:23
fungiwe'd probably need to caution our users to design release jobs with complete idempotence in mind17:23
fungiwhich is not always easy17:24
*** SaifAddin has joined #zuul17:25
SaifAddincorvus is it possible than an empty main.yaml in vars to override all the variables set in tasks/main.yaml ??17:25
corvusSaifAddin: i don't think so; i think it would only add variables for use in that role.17:29
corvus(but any vars explicitly set there might override cached facts?  i'm unsure about that)17:29
corvusSaifAddin: if you want, you could upload a test change to the opendev/sandbox repository to try out the process.  you can propose a new job with multiple playbooks and zuul will run it.  we could all look at it together then.17:31
*** rlandy is now known as rlandy|lunch17:36
SaifAddinahh that is cool, thanks. Will consider it17:40
SaifAddinbut yes it is so strange, the job runs well only when I  put the list of variables both inside the `set_fact:` AND when I put all the same variables (again) in the `vars/main.yml`17:41
SaifAddinjust one or the other is not enough, driving me crazy17:41
SaifAddin```17:42
SaifAddin---17:42
SaifAddin- name: setting_cache_variables17:42
SaifAddin  set_fact:17:42
SaifAddin    foo1: bar117:42
SaifAddin    foo2: bar217:42
SaifAddin```17:42
SaifAddin(+ cacheable: true)17:43
avassfungi: for us it's often that either the artifacts got uploaded or they didn't17:43
SaifAddinAnd then the same in `vars/main.yaml`17:43
SaifAddin`foo1: bar117:43
SaifAddinfoor2: bar217:43
SaifAddin`17:43
avassSaifAddin: can you use a paste service like: http://paste.openstack.org/ for pasting code? :)17:44
SaifAddinYes I am sorry. I thought triple beans would work for small snippets17:46
*** ikhan has joined #zuul17:50
openstackgerritMerged zuul/zuul master: Remove an unneeded api call when creating check_runs  https://review.opendev.org/c/zuul/zuul/+/75205617:55
openstackgerritMerged zuul/zuul master: Save superfluous api requests in check run reporting  https://review.opendev.org/c/zuul/zuul/+/75207917:55
*** rlandy|lunch is now known as rlandy18:07
*** jpena is now known as jpena|off18:10
*** hashar has quit IRC18:10
*** SaifAddin has quit IRC18:10
corvusclarkb, fungi, tobiash: fun fact: it looks like 'git fetch --tags' does cause local tags to update if remote tags are moved18:31
clarkbcorvus: cool, so if we --prune-tags and --tags we might address a good portion of this?18:33
corvusclarkb: yeah, that's how it's looking to me.  +1 for "write some tests to codify the behavior" :)18:33
openstackgerritJames E. Blair proposed zuul/zuul master: Prune git tags on fetch  https://review.opendev.org/c/zuul/zuul/+/76175618:34
corvusclarkb, fungi, tobiash, swest_: ^ i updated that with 2 tests: tag/delete/retag and moving a tag18:34
fungicorvus: however it won't remove a local tag when the remote is deleted, right?18:39
fungithat just winds up orphaned18:39
openstackgerritTobias Henkel proposed zuul/zuul master: Add optional support for circular dependencies  https://review.opendev.org/c/zuul/zuul/+/68535418:43
openstackgerritTobias Henkel proposed zuul/zuul master: Allow refreshing volatile data in canMerge check  https://review.opendev.org/c/zuul/zuul/+/76708418:45
openstackgerritTobias Henkel proposed zuul/zuul master: Check cycle items are mergeable before reporting  https://review.opendev.org/c/zuul/zuul/+/74345018:45
corvusfungi: it will because the change adds --prune-tags18:45
fungiahh18:45
fungigot it18:45
openstackgerritTobias Henkel proposed zuul/zuul master: Support enqueuing behind circular dependencies  https://review.opendev.org/c/zuul/zuul/+/77784318:45
tobiashcorvus: cdep needed a rebase ^18:46
fungiso the combination of the two is enough to sync up local tags to remote tags even if they've been deleted and/or recreated18:46
corvusso basically, aiui, zuul will probably do the thing everyone imagines happens: it will magically keep up with whatever happens to tags upstream.18:46
corvusfungi: that's my understanding18:46
fungineat18:46
corvustobiash: thanks!18:46
openstackgerritTobias Henkel proposed zuul/zuul master: Make reporting asynchronous  https://review.opendev.org/c/zuul/zuul/+/69125318:46
harrymichalHi folks, recently I started to use the dynamic badge and noticed the image does not get updated in the README preview on GitHub. I spent a bit of time digging and found this part of GItHub's documentation: https://docs.github.com/en/github/authenticating-to-github/about-anonymized-image-urls#an-image-that-changed-recently-is-not-updating.19:13
harrymichalBasically, the response with the image needs to contain value "Cache-Control" set to "no-cache".19:13
harrymichalCould that be set for the dynamic badge?19:14
openstackgerritTristan Cacqueray proposed zuul/zuul master: web: set cache-control header for the badge endpoint  https://review.opendev.org/c/zuul/zuul/+/77805419:23
tristanCharrymichal: perhaps ^ would do19:24
*** hamalq has joined #zuul19:24
harrymichaltristanC: Thank you!19:29
*** piotrowskim has quit IRC20:12
openstackgerritTristan Cacqueray proposed zuul/zuul master: Add project variables to the REST API  https://review.opendev.org/c/zuul/zuul/+/77806220:32
*** mgagne has joined #zuul20:42
*** nils has quit IRC20:50
openstackgerritMerged zuul/zuul master: web: set cache-control header for the badge endpoint  https://review.opendev.org/c/zuul/zuul/+/77805421:13
openstackgerritKevin Carter proposed zuul/zuul-jobs master: Make .sh browsable on swift logs  https://review.opendev.org/c/zuul/zuul-jobs/+/73179522:22
openstackgerritJames E. Blair proposed zuul/zuul master: Update zoned executor stats  https://review.opendev.org/c/zuul/zuul/+/77785223:04
openstackgerritJames E. Blair proposed zuul/zuul master: Optionally allow zoned executors to process unzoned jobs  https://review.opendev.org/c/zuul/zuul/+/67384023:04
fungiprobably been discussed before, but should we be limiting what we load from openstack/project-config and opendev/system-config in our zuul tenant definition? https://zuul.opendev.org/t/zuul/config-errors23:07
corvusfungi: probably so23:08
corvuswe can at least pull out the pipeline defs23:08
corvusi'm assuming they're there for jobs and we may not get 100% clean on that23:09
fungiyeah, maybe. and i agree the openstack/project-config one should be simple at least. i'll start there23:10
openstackgerritMerged zuul/zuul master: Don't query branch protection on pull request events  https://review.opendev.org/c/zuul/zuul/+/75357123:10
corvusclarkb: https://review.opendev.org/761756 look good now with the new tests?23:23
clarkbcorvus: I'll look in a minute23:24
corvusno rush, just trying to clear the deck :)23:26
fungicorvus: okay, this is mildly confounding... https://opendev.org/openstack/project-config/src/branch/master/zuul/main.yaml#L163023:35
fungiit already shouldn't be trying to load pipeline definitions, right?23:35
*** andy-ladjadj has joined #zuul23:36
fungiokay, even more confusing. it's not actually alarming about it now23:36
*** andy-ladjadj has quit IRC23:36
fungiyou saw it in there too though, right? i'm not imagining things?23:36
clarkbcorvus: both tests in that change seem to cover the tag has moved scenario. Am I reading that correctly?23:37
clarkbcorvus: I went ahead and approved it since the testing is only doing more than it claims and that should be fine :)23:40
openstackgerritJames E. Blair proposed zuul/zuul master: Make repo state buildset global  https://review.opendev.org/c/zuul/zuul/+/73860323:49
corvusclarkb: yes, though the first one is with zuul updating between the delete/add and the second is without23:50
corvusclarkb: i looked at it as the first one is "someone deleted the tag.  then (much) later, someone readded the tag with the same name".  versus "someone moved the tag"23:50
corvusfungi: yes, i still have the errors on my screen23:51
corvusfungi: i agree the pipelines are gone if i open in a new window23:51
fungithat's... unnerving23:54
clarkbcorvus: gotcha23:55
fungicorvus: also /etc/zuul/main.yaml was last modified on the scheduler's filesystem ~28 hours ago (if my math is correct)23:57
*** harrymichal has quit IRC23:58
*** harrymichal has joined #zuul23:58
fungiand last full reconfigure a few minutes after that file was touched23:59

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!