| *** jamesmcarthur has joined #zuul | 00:09 | |
| *** tosky has quit IRC | 00:09 | |
| *** jamesmcarthur has quit IRC | 00:13 | |
| *** jamesmcarthur has joined #zuul | 00:28 | |
| *** jamesmcarthur has quit IRC | 00:47 | |
| *** jamesmcarthur has joined #zuul | 00:48 | |
| *** jamesmcarthur has quit IRC | 00:53 | |
| *** jamesmcarthur has joined #zuul | 01:20 | |
| *** jamesmcarthur has quit IRC | 02:24 | |
| *** jamesmcarthur has joined #zuul | 02:24 | |
| *** jamesmcarthur has quit IRC | 02:30 | |
| *** jhesketh has joined #zuul | 02:34 | |
| *** jamesmcarthur has joined #zuul | 02:35 | |
| *** jamesmcarthur has quit IRC | 02:36 | |
| *** jamesmcarthur has joined #zuul | 02:38 | |
| openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Update upload-logs-swift and upload-logs-gcs https://review.opendev.org/c/zuul/zuul-jobs/+/774650 | 02:50 |
|---|---|---|
| openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Update upload-logs-swift and upload-logs-gcs https://review.opendev.org/c/zuul/zuul-jobs/+/774650 | 03:01 |
| *** jamesmcarthur has quit IRC | 03:09 | |
| *** jamesmcarthur has joined #zuul | 03:15 | |
| openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Update upload-logs-swift and upload-logs-gcs https://review.opendev.org/c/zuul/zuul-jobs/+/774650 | 03:16 |
| *** jamesmcarthur has quit IRC | 03:24 | |
| *** jamesmcarthur has joined #zuul | 03:25 | |
| openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Update upload-logs-swift and upload-logs-gcs https://review.opendev.org/c/zuul/zuul-jobs/+/774650 | 03:51 |
| *** vishalmanchanda has joined #zuul | 04:22 | |
| *** ericsysmin has quit IRC | 04:58 | |
| *** johnsom has quit IRC | 04:58 | |
| *** maxamillion has quit IRC | 04:58 | |
| *** ericsysmin has joined #zuul | 04:58 | |
| *** johnsom has joined #zuul | 04:58 | |
| *** maxamillion has joined #zuul | 04:59 | |
| *** ykarel|away has joined #zuul | 05:10 | |
| *** ykarel|away is now known as ykarel | 05:11 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #zuul | 05:33 | |
| *** saneax has joined #zuul | 06:06 | |
| *** jamesmcarthur has quit IRC | 06:46 | |
| *** jfoufas1 has joined #zuul | 07:13 | |
| *** jamesmcarthur has joined #zuul | 07:16 | |
| *** jamesmcarthur has quit IRC | 07:28 | |
| *** jamesmcarthur has joined #zuul | 07:44 | |
| *** ykarel_ has joined #zuul | 07:48 | |
| *** jamesmcarthur has quit IRC | 07:49 | |
| *** ykarel has quit IRC | 07:50 | |
| *** jamesmcarthur has joined #zuul | 08:01 | |
| *** ykarel_ is now known as ykarel | 08:06 | |
| *** jamesmcarthur has quit IRC | 08:12 | |
| *** hashar has joined #zuul | 08:14 | |
| *** jcapitao has joined #zuul | 08:20 | |
| *** jpena|off is now known as jpena | 08:31 | |
| *** ykarel is now known as ykarel|lunch | 08:39 | |
| *** piotrowskim has joined #zuul | 08:55 | |
| *** arxcruz|ruck is now known as arxcruz|rover | 09:03 | |
| *** rpittau|afk is now known as rpittau | 09:03 | |
| *** ofosos has joined #zuul | 09:05 | |
| *** ianychoi_ has joined #zuul | 09:18 | |
| ofosos | Moin | 09:18 |
| ofosos | Last I checked Zuul was working on K8s operator support, did anything decisive come out of that initiative? | 09:19 |
| avass | ofosos: slowly but yep | 09:21 |
| *** ianychoi has quit IRC | 09:21 | |
| *** holser has joined #zuul | 09:22 | |
| avass | ofosos: I believe only tristanC is working on it semi-actively at the moment (at least when checking changes in gerrit) | 09:24 |
| *** tosky has joined #zuul | 09:24 | |
| *** nils has joined #zuul | 09:34 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests https://review.opendev.org/c/zuul/zuul/+/721254 | 09:52 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Connect executor to Zookeeper https://review.opendev.org/c/zuul/zuul/+/716262 | 09:52 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/c/zuul/zuul/+/716221 | 09:52 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Improve typings in context of 744416 https://review.opendev.org/c/zuul/zuul/+/753578 | 09:52 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Make Zookeeper mandatory for Scheduler https://review.opendev.org/c/zuul/zuul/+/756716 | 09:52 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Make ConnectionRegistry mandatory for Scheduler https://review.opendev.org/c/zuul/zuul/+/757095 | 09:52 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Improve typings in context of 756716 and 757095 https://review.opendev.org/c/zuul/zuul/+/757148 | 09:52 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Instantiate executor client, merger, nodepool and app within Scheduler https://review.opendev.org/c/zuul/zuul/+/757149 | 09:52 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Improve typings in context of 756304 https://review.opendev.org/c/zuul/zuul/+/757097 | 09:52 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: DNM: Reduce number of jobs for SOS development https://review.opendev.org/c/zuul/zuul/+/775081 | 09:52 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Component Registry in ZooKeeper https://review.opendev.org/c/zuul/zuul/+/759187 | 09:52 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Move management and result events to model https://review.opendev.org/c/zuul/zuul/+/761163 | 09:52 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Allow (de-)serialization of management events https://review.opendev.org/c/zuul/zuul/+/761164 | 09:52 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Allow (de-)serialization of result events https://review.opendev.org/c/zuul/zuul/+/761165 | 09:53 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Add and fix fields in driver trigger event models https://review.opendev.org/c/zuul/zuul/+/761166 | 09:53 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Allow (de-)serialization of trigger events https://review.opendev.org/c/zuul/zuul/+/761167 | 09:53 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Interface to get a driver's trigger event class https://review.opendev.org/c/zuul/zuul/+/761168 | 09:53 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Increase default test wait timeout to 120s https://review.opendev.org/c/zuul/zuul/+/763754 | 09:53 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Implementation of Zookeeper backed event queues https://review.opendev.org/c/zuul/zuul/+/761170 | 09:53 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Implementation of Zookeeper event watcher https://review.opendev.org/c/zuul/zuul/+/761171 | 09:53 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Switch to Zookeeper backed trigger event queues https://review.opendev.org/c/zuul/zuul/+/761172 | 09:54 |
| *** sshnaidm|off is now known as sshnaidm | 09:54 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Switch to Zookeeper backed management event queues https://review.opendev.org/c/zuul/zuul/+/761738 | 09:54 |
| openstackgerrit | Tobias Henkel proposed zuul/nodepool master: WIP: Optimize node launches https://review.opendev.org/c/zuul/nodepool/+/775507 | 10:02 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler https://review.opendev.org/c/zuul/zuul/+/717269 | 10:15 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests https://review.opendev.org/c/zuul/zuul/+/721254 | 10:15 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Connect executor to Zookeeper https://review.opendev.org/c/zuul/zuul/+/716262 | 10:15 |
| *** ykarel|lunch is now known as ykarel | 10:18 | |
| felixedel | corvus: I've updated the patches and integrated them in our current stack and reused the old change-ids. I had to made a little adaptation which I explained directly as comment in the patch | 10:22 |
| *** nils has quit IRC | 11:56 | |
| *** jcapitao is now known as jcapitao_lunch | 12:12 | |
| *** rlandy has joined #zuul | 12:19 | |
| *** ykarel has quit IRC | 12:21 | |
| zbr | felixedel: corvus: can you please help with https://review.opendev.org/c/zuul/zuul-jobs/+/775373 ? | 12:23 |
| zbr | that was breaking docker installation of some particular cases (custom config) | 12:23 |
| *** jpena is now known as jpena|lunch | 12:32 | |
| *** ykarel has joined #zuul | 12:36 | |
| *** jcapitao_lunch is now known as jcapitao | 13:03 | |
| tristanC | ofosos: you can find the operator at https://opendev.org/zuul/zuul-operator/ , and here is some allinone resources to deploy it: https://review.opendev.org/plugins/gitiles/zuul/zuul-operator/+/a5de61d19f857f12dffa22cf3f874156b985fbc7/deploy/ | 13:03 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Switch to Zookeeper backed trigger event queues https://review.opendev.org/c/zuul/zuul/+/761172 | 13:06 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Switch to Zookeeper backed management event queues https://review.opendev.org/c/zuul/zuul/+/761738 | 13:06 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Improve test output by using named queues https://review.opendev.org/c/zuul/zuul/+/775620 | 13:06 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Avoid race when task from queue is in progress https://review.opendev.org/c/zuul/zuul/+/775621 | 13:06 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Implement Zookeeper backed connection event queue https://review.opendev.org/c/zuul/zuul/+/775622 | 13:06 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Dispatch Pagure webhook events via Zookeeper https://review.opendev.org/c/zuul/zuul/+/775623 | 13:06 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Dispatch Github webhook events via Zookeeper https://review.opendev.org/c/zuul/zuul/+/775624 | 13:06 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Dispatch Gitlab webhook events via Zookeeper https://review.opendev.org/c/zuul/zuul/+/775625 | 13:06 |
| zbr | tristanC: can you please help with https://review.opendev.org/c/zuul/zuul-jobs/+/775373 ? | 13:08 |
| *** jfoufas1 has quit IRC | 13:13 | |
| tristanC | zbr: is it ok to omit file mode now? | 13:13 |
| zbr | tristanC: depends how you look at it, but the old mode issue is not really linked to current fix. | 13:15 |
| zbr | the issue was that the folder was not created in the first place, and if I mention explicit rights it may affect existing behavior, better to be backwards compatible. | 13:16 |
| zbr | my opinion is still that we should aim to be explicit about mode in general, but using default is not really a big issue either. | 13:16 |
| *** ykarel_ has joined #zuul | 13:18 | |
| *** armstrongs has joined #zuul | 13:18 | |
| *** ykarel has quit IRC | 13:21 | |
| *** jpena|lunch is now known as jpena | 13:23 | |
| *** ykarel_ is now known as ykarel | 13:25 | |
| *** sduthil has joined #zuul | 13:32 | |
| *** holser has quit IRC | 13:38 | |
| *** holser has joined #zuul | 13:40 | |
| avass | tristanC: any reason you didn't +3 that? | 13:43 |
| tristanC | avass: i wasn't sure about omitting file mode, but since zbr confirmed it's ok the use the default i've +3 the change | 13:47 |
| avass | tristanC: got it | 13:57 |
| zbr | thanks! | 13:58 |
| openstackgerrit | Merged zuul/zuul-jobs master: update-json-file: avoid failure when destination does not exists https://review.opendev.org/c/zuul/zuul-jobs/+/775373 | 13:59 |
| *** saneax has quit IRC | 14:16 | |
| avass | tristanC: is there any good, easy to get into guide to set up a shell with nix. or a list of packages or somnething like that? | 14:18 |
| avass | reading the manual is a bit much to just try it out quickly | 14:18 |
| tristanC | avass: https://nixos.org/download.html usually works fine to get the tooling | 14:20 |
| avass | yeah I got it installed, just found nix-pills so maybe that's a good way to start | 14:20 |
| tristanC | avass: oh, for documentation, pills document the derivation concept from the ground up, for alternative materials you can read https://nix.dev/ or https://github.com/justinwoo/nix-shorts | 14:23 |
| tristanC | avass: in zuul-nix, for the vm I used https://github.com/nh2/nixos-vm-building/ , and for the container: https://nixos.org/guides/building-and-running-docker-images.html | 14:25 |
| tristanC | avass: i also wrote quite a few relatively simple nix expressions in https://github.com/podenv/devenv | 14:26 |
| avass | tristanC: thanks! :) | 14:28 |
| avass | I just needed something simpler to look at between tasks | 14:29 |
| tristanC | avass: i think the new learn pages are quite good at introducing the different concepts (e.g. https://nixos.org/learn.html ) | 14:32 |
| avass | tristanC: somehow I missed scrolling down on that page | 14:35 |
| tristanC | avass: though there is quite a lot to learn, and the nixpkgs design is quite complex as it supports many package sets that can be customized through different functions. For example i haven't fully understood the override mechanism and i often just create new set from scratch | 14:35 |
| avass | tristanC: yeah it feels a bit overwhelming | 14:41 |
| openstackgerrit | Tobias Henkel proposed zuul/nodepool master: Offload waiting for server creation/deletion https://review.opendev.org/c/zuul/nodepool/+/775438 | 14:47 |
| corvus | felixedel: which patch? i'm having trouble finding the comment you mentiond | 14:53 |
| *** tosky has quit IRC | 14:55 | |
| felixedel | corvus: https://review.opendev.org/c/zuul/zuul/+/716262/69/tests/base.py#4182 | 14:55 |
| corvus | felixedel: thanks! | 15:02 |
| corvus | felixedel: why share the connections in the tests? | 15:04 |
| felixedel | corvus: 1. I thougt we decided that in our call last week. 2. If we add a zk_disconnect() via add_cleanup() to various tests (e.g. where an additional merger is iinstantiated, this cleanup will be called before the test's shutdown(), resulting in the zk connection being closed before the merger.stop() is called | 15:08 |
| felixedel | I also think, if we share the ZK connection in the tests, we don't need any additional check in the end to assert that all ZK connections are closed. | 15:09 |
| corvus | felixedel: ah, well, 1) i hadn't reviewed the code in question yet :) 2) that's a compelling argument. still, there are only 4 tests where a separate merger is used; from that we can say this probably isn't that important, but nonetheless, i'd love it if they were more realistic (that way we're better exercising startup/shutdown code, etc). let's keep this in mind when we rework the connection class in | 15:13 |
| corvus | the next patch. i'd like to explore the idea of moving the connection handling into the various component server classes (scheduler, executor, merger) directly. i think if it were there, we wouldn't have to worry about the shutdown sequence as much. | 15:13 |
| corvus | felixedel, swest, tobiash: something that would help as we work through these: try not to make too many changes low in the stack to accommodate changes later in the stack (or if absolutely necessary, call them out in comments). it's really hard to review a line in a change that doesn't make sense unless you know it's used 10 changes later. it's better to have it be sub-optimal at first and then change it | 15:21 |
| corvus | when it's needed. not only for ease of comprehension, but it also helps avoid errors if we make a revsion that affects it (we don't forget that it's tied up in another patch). | 15:21 |
| felixedel | corvus: Handling the connections directly in the server classes sounds good. To be honest, I didn't really understand why we initialized the connections in the cmd/... files anyway, but this wasn't mine to decide :D But I think, we should first try to keep the stack working/in sync. | 15:22 |
| *** vishalmanchanda has quit IRC | 15:22 | |
| felixedel | corvus: That was never our intention. I usually only change things I directly (or in preperation for the next steps). Just in this case, every component is connected to ZooKeeper without using the connection. Thus, the errors first occur when the connection is used in later patches. But I also don't find iit right to fix this then in the later patch but in ther patch that introduced the problem in the first place. | 15:24 |
| corvus | felixedel: makes sense :) | 15:25 |
| tobiash | corvus: having the connections initialized within the components might make sense in nodepool as well to reduce exception spam during the shutdown sequence of the test cases | 15:25 |
| corvus | tobiash: ++ | 15:26 |
| corvus | felixedel: and yeah, at this point, i don't think there is a good reason to initialize them externally; there may have been in a very early version of the test setup, but i think we've gotten that to be pretty transparent now. | 15:27 |
| corvus | anyway we can look at that after we get this stack merged | 15:28 |
| felixedel | ++ | 15:28 |
| *** iurygregory_ has joined #zuul | 15:29 | |
| *** iurygregory has quit IRC | 15:30 | |
| *** iurygregory_ is now known as iurygregory | 15:30 | |
| corvus | felixedel: i've looked at the overall diff from where i left the stack to your updates, and all the changes make sense to me, so i'm going to +2 up through the merger change. | 15:40 |
| felixedel | corvus: Sounds good :) | 15:42 |
| tobiash | so that is settled now? | 15:42 |
| corvus | tobiash, zuul-maint: yes, i think 717269, 721254, 716262, 716221 are ready to merge and that gets the ZK stack up to what's needed for 4.0, if anyone wants to re-review those. | 15:45 |
| corvus | fwiw, i've told gertty to +2 all those changes, but gerrit is being slow | 15:48 |
| fungi | yeah, gerrit seems to be a bit strained at the moment | 15:49 |
| corvus | mhu: i verified that the zuul-client 0.0.4 pypi and dockerhub artifacts are published | 15:51 |
| mhu | corvus, was there a problem? | 15:51 |
| mhu | oh sorry, just catching up | 15:51 |
| corvus | mhu: no, but it's something that i do after every release to make sure the machinery is working ... i was trying to get you to help out with that but i failed. :) | 15:52 |
| corvus | mhu: the docs are out of date though -- https://zuul-ci.org/docs/zuul-client/releasenotes.html#in-development are we missing a doc build on tag job? | 15:53 |
| corvus | hrm, looks like the job is there | 15:54 |
| corvus | oh | 15:55 |
| mhu | zuul-publish-tox-docs in the release pipeline, yep | 15:55 |
| corvus | yeah, everything is working as best it can; the .4 docs are here: https://zuul-ci.org/docs/zuul-client/0.0.4/releasenotes.html | 15:55 |
| corvus | we won't get the unversioned docs updated until we merge a change to master | 15:55 |
| mhu | corvus, there are a few changes in the waiting list if you want to check that! :) | 15:56 |
| corvus | i think i can single-approve https://review.opendev.org/765553 | 15:56 |
| corvus | (that matches the other projects) | 15:56 |
| fungi | i ran into a similar challenge releasing opendev/bindep with the move to bindep doing docs in promote. seems the doc job would need to be written a bit differently to also be applicable to the release pipeline | 16:01 |
| corvus | mhu: qq on https://review.opendev.org/750999 | 16:01 |
| fungi | my workaround was basically to merge a trivial change to master immediately after release, so that release notes looked sane | 16:01 |
| fungi | and then do the release announcement at that point | 16:01 |
| *** tosky has joined #zuul | 16:02 | |
| corvus | fungi: yeah, in order to avoid this, we'd basically have to do 2 doc builds. maybe we should... but it's usually not a problem. | 16:02 |
| corvus | mhu: actually 2 questions on that change now | 16:07 |
| tobiash | corvus: the nodepool optimization (775438) is very promising in my testenv | 16:19 |
| Open10K8S | Hi team. Now I am trying to use path_join filter in the role of zuul-jobs. But seems path_join filter is introduced from v2.10. Which version are we using in zuul now and what can be the workaround for path_join with current version? | 16:19 |
| Open10K8S | {{ foo | default(bar) }}/{{ path }} simple string join includes double slashes and i am not sure if this can be ignored in ansible | 16:20 |
| Open10K8S | The PS including path_join is https://review.opendev.org/c/zuul/zuul-jobs/+/774650 | 16:20 |
| corvus | Open10K8S: we have to support back to ansible 2.7 | 16:20 |
| corvus | and in fact zuul doesn't support 2.10 yet | 16:21 |
| corvus | tobiash: \o/ | 16:21 |
| tobiash | there is a wip change for 2.10 support: https://review.opendev.org/c/zuul/zuul/+/757452 | 16:22 |
| openstackgerrit | Merged zuul/zuul-client master: Bump mypy to 0.790 https://review.opendev.org/c/zuul/zuul-client/+/765553 | 16:22 |
| tobiash | but I have no time for finishing this up atm | 16:22 |
| *** cloudnull has quit IRC | 16:25 | |
| *** cloudnull has joined #zuul | 16:28 | |
| openstackgerrit | Albin Vass proposed zuul/zuul master: Fix executor errors on faulty .gitmodules file. https://review.opendev.org/c/zuul/zuul/+/775334 | 16:28 |
| *** saneax has joined #zuul | 16:30 | |
| mhu | corvus: thanks, answered and asked another question :) | 16:32 |
| *** ykarel has quit IRC | 16:33 | |
| corvus | mhu: i don't see anything; are we waiting for your gertty to sync to gerrit now? :) | 16:34 |
| mhu | oops forgot to push reply ... | 16:34 |
| mhu | the behavior changed with gerrit 3 right? I swear I didn't forget this much before | 16:35 |
| corvus | i think that's the same | 16:35 |
| mhu | while we're on the subject of zuul-client, I'd like to suggest syncing releases with zuul, and maybe match versions from now on. WDYT? | 16:38 |
| mhu | the idea being that since the API is subject to changes, you want an easy way to ensure you're using a zuul-client that can talk to a given version of zuul | 16:39 |
| openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Update upload-logs-swift and upload-logs-gcs https://review.opendev.org/c/zuul/zuul-jobs/+/774650 | 16:39 |
| mhu | or should zuul-client have a way to be retro-compatible with older versions of zuul? | 16:40 |
| mhu | for example, zuul-client 0.0.4 supports master, but there are incompatibilities with zuul 3.19.1 | 16:41 |
| corvus | mhu: zuul-client will have long periods of not changing at all though; that makes the version # sync problematic | 16:42 |
| tobiash | zk changes are in gate | 16:55 |
| openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Update upload-logs-swift and upload-logs-gcs https://review.opendev.org/c/zuul/zuul-jobs/+/774650 | 16:59 |
| corvus | tobiash: w00t! | 17:00 |
| corvus | zuul-maint: please see this message regarding last call for 4.0 breaking changes: http://lists.zuul-ci.org/pipermail/zuul-discuss/2021-February/001530.html | 17:01 |
| *** smyers has quit IRC | 17:12 | |
| *** smyers has joined #zuul | 17:13 | |
| *** jpena is now known as jpena|brb | 17:15 | |
| *** piotrowskim has quit IRC | 17:30 | |
| *** jpena|brb is now known as jpena | 17:35 | |
| openstackgerrit | Merged zuul/zuul master: Prepare Zookeeper for scale-out scheduler https://review.opendev.org/c/zuul/zuul/+/717269 | 17:39 |
| Shrews | oooh, that's an exciting chain of changes ^^^. excited to see how that works out vs. gearman | 17:42 |
| avass | Exciting indeed :) | 17:43 |
| tobiash | corvus: speaking or your mail, what do you think about this deprecation? https://zuul-ci.org/docs/zuul/reference/releasenotes.html#relnotes-3-18-0-deprecation-notes | 17:47 |
| *** rpittau is now known as rpittau|afk | 17:47 | |
| corvus | tobiash: yes! i think this is an excellent time to resolve that | 17:48 |
| tobiash | and sighup? https://zuul-ci.org/docs/zuul/reference/releasenotes.html#relnotes-3-3-0-deprecation-notes | 17:48 |
| corvus | yep! | 17:48 |
| corvus | i'll start on a patch for sighup | 17:49 |
| tobiash | ++ | 17:49 |
| corvus | let's use topic: zuulv4 | 17:49 |
| *** jpena is now known as jpena|off | 17:51 | |
| openstackgerrit | Merged zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests https://review.opendev.org/c/zuul/zuul/+/721254 | 17:51 |
| openstackgerrit | Merged zuul/zuul master: Connect executor to Zookeeper https://review.opendev.org/c/zuul/zuul/+/716262 | 17:52 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Remove SIGHUP handling in scheduler https://review.opendev.org/c/zuul/zuul/+/775683 | 17:54 |
| corvus | tobiash: have you started on "-d" or should i? | 17:54 |
| tobiash | I've started | 17:54 |
| corvus | kk | 17:55 |
| Open10K8S | tobiash: can you check again please? https://review.opendev.org/c/zuul/zuul-jobs/+/774650 | 17:56 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Remove nodaemon when running with -f switch https://review.opendev.org/c/zuul/zuul/+/775685 | 18:00 |
| *** johnsom has quit IRC | 18:01 | |
| *** rpittau|afk has quit IRC | 18:01 | |
| *** johnsom has joined #zuul | 18:02 | |
| *** ericsysmin has quit IRC | 18:02 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Remove nodaemon when running with -f switch https://review.opendev.org/c/zuul/zuul/+/775685 | 18:02 |
| *** ericsysmin has joined #zuul | 18:03 | |
| *** rpittau|afk has joined #zuul | 18:04 | |
| corvus | Open10K8S: that change lgtm, but we need to test it in production before we can merge it; i left a comment describing the process. | 18:04 |
| corvus | tobiash: oops https://review.opendev.org/705189 already existed :) | 18:06 |
| corvus | tobiash: i +2d both of them, take your pick :) | 18:07 |
| openstackgerrit | Merged zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/c/zuul/zuul/+/716221 | 18:07 |
| tobiash | yay, both by me :D | 18:07 |
| tobiash | I'll take the older one due to the better commit message :) | 18:08 |
| *** jcapitao has quit IRC | 18:18 | |
| *** cloudnull has quit IRC | 18:24 | |
| openstackgerrit | Jonas Sticha proposed zuul/nodepool master: aws: add support for uploading diskimages https://review.opendev.org/c/zuul/nodepool/+/735217 | 18:26 |
| tobiash | corvus: I just did a quick load test with the nodepool optimization and it now tops out at ~800 nodes per 10min which roughly doubles what was possible before without being cpu bound | 18:27 |
| *** cloudnull has joined #zuul | 18:28 | |
| tobiash | however I think there is a further bottleneck somewhere because the node startup times are longer than a different launcher with less load operating against the same cloud | 18:28 |
| tobiash | I guess there are further things to consider like urllib connection pools or request handling | 18:29 |
| tobiash | but this seems as a big step forward | 18:29 |
| corvus | tobiash: cool, is that ready for review, or still working on it? | 18:33 |
| tobiash | corvus: maybe some debug output left but generally ready for review | 18:34 |
| tobiash | I'll load test it further later and try it in production tomorrow to see how it performs in real life | 18:34 |
| *** hashar has quit IRC | 18:36 | |
| tobiash | is there a way to do batched deletes? | 18:36 |
| tobiash | I think the next wall I'm hitting is number of api calls | 18:36 |
| openstackgerrit | James E. Blair proposed zuul/zuul-client master: Output subcommand help on argument errors https://review.opendev.org/c/zuul/zuul-client/+/775694 | 18:37 |
| corvus | tobiash: i don't believe so; worth double checking though. | 18:38 |
| *** openstackgerrit has quit IRC | 18:38 | |
| corvus | mhu: 775694 is based on a real experience from a new user | 18:38 |
| corvus | tobiash: want to +3 https://review.opendev.org/775683 ? | 18:49 |
| tobiash | done | 18:49 |
| corvus | avass: https://review.opendev.org/775334 lgtm! i think we should ask tobiash for a review of that based on his experience with that code | 18:52 |
| corvus | (.gitmodules repo reset fixing) | 18:53 |
| corvus | avass: oh wait, i think i spotted one more thing we should do to make it safer; comment inline | 18:54 |
| corvus | (it's a minor change; approach lgtm) | 18:54 |
| tobiash | corvus: I'll have a look later or tomorrow | 18:55 |
| corvus | cool, i don't think timing on that is critical | 18:56 |
| avass | corvus: looking | 19:01 |
| avass | corvus: the follow up also cleans up a fix you did a long time ago :) | 19:02 |
| corvus | avass: ah thanks for that! :) | 19:03 |
| *** openstackgerrit has joined #zuul | 19:03 | |
| openstackgerrit | Albin Vass proposed zuul/zuul master: Fix executor errors on faulty .gitmodules file. https://review.opendev.org/c/zuul/zuul/+/775334 | 19:03 |
| corvus | it took a long time for them to release with that | 19:03 |
| *** cloudnull has quit IRC | 19:05 | |
| *** cloudnull has joined #zuul | 19:08 | |
| avass | tristanC: going through the pills and I gotta say that I'm really starting to like nix | 19:58 |
| tristanC | avass: it's quite interesting isn't it? :-) | 20:00 |
| avass | it is :) | 20:01 |
| *** saneax has quit IRC | 20:04 | |
| *** openstackgerrit has quit IRC | 20:06 | |
| *** cloudnull has quit IRC | 20:46 | |
| *** cloudnull has joined #zuul | 20:48 | |
| *** openstackgerrit has joined #zuul | 21:05 | |
| openstackgerrit | James E. Blair proposed zuul/zuul-client master: Output subcommand help on argument errors https://review.opendev.org/c/zuul/zuul-client/+/775694 | 21:05 |
| openstackgerrit | Merged zuul/zuul master: Remove SIGHUP handling in scheduler https://review.opendev.org/c/zuul/zuul/+/775683 | 21:06 |
| *** hamalq has joined #zuul | 21:22 | |
| *** cloudnull has quit IRC | 21:26 | |
| *** cloudnull has joined #zuul | 21:28 | |
| *** armstrongs has quit IRC | 21:29 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate your first patch" https://review.opendev.org/c/zuul/zuul/+/732067 | 21:32 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "Use zuul jobs" https://review.opendev.org/c/zuul/zuul/+/732068 | 21:32 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate pipeline" https://review.opendev.org/c/zuul/zuul/+/732069 | 21:32 |
| openstackgerrit | James E. Blair proposed zuul/nodepool master: Add ssh/winrm credentials to static nodes https://review.opendev.org/c/zuul/nodepool/+/774014 | 21:49 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Support credentials supplied by nodepool https://review.opendev.org/c/zuul/zuul/+/774362 | 21:49 |
| corvus | tristanC: i think https://review.opendev.org/773826 is an easy edge-case bugfix | 21:51 |
| mordred | corvus: that patch is a great example of why an informative commit message is imporant | 21:55 |
| mordred | corvus: there are absolutely no circumstances where reviewing that patch with a commit message like "bugfix" would be possible | 21:56 |
| corvus | mordred: hah! :) yeah it has a 14:1 commit message to code lines ratio. really 14:-1 i guess. :) | 21:57 |
| corvus | mordred: i wonder how https://www.folklore.org/StoryView.py?story=Negative_2000_Lines_Of_Code.txt would have turned out if they included commit message lines in their end-of-week reports... | 21:59 |
| mordred | :) | 22:00 |
| avass | corvus: oooh I like that kind of malicious compliance | 22:02 |
| corvus | yeah, it's an insipring story :) | 22:08 |
| *** noonedeadpunk has quit IRC | 22:24 | |
| *** cloudnull has quit IRC | 22:26 | |
| *** cloudnull has joined #zuul | 22:29 | |
| *** noonedeadpunk has joined #zuul | 22:30 | |
| ianw | "This change will cause, in the case of a 404 for the manifest, a | 22:38 |
| ianw | toast to display the error regarding the fetch manifest failure, | 22:38 |
| ianw | but underneath it the rest of the build page will display as normal. | 22:38 |
| ianw | " | 22:38 |
| ianw | is a toast a delicious typo, or yet another web thing i don't know about | 22:38 |
| *** clarkb has quit IRC | 22:42 | |
| fungi | dunno, but now i'm hungry | 22:44 |
| corvus | ianw, fungi: it's a web thing: https://www.patternfly.org/v3/pattern-library/communication/toast-notifications/index.html | 22:48 |
| corvus | think toaster pop up :) | 22:49 |
| corvus | material design is trying to rename those to snackbars for some reason i don't understand https://material.io/archive/guidelines/components/snackbars-toasts.html# | 22:51 |
| fungi | huh, so much food | 22:54 |
| mordred | corvus: maybe it's because some folks are gluten intolerant and toast excludes them? | 22:57 |
| corvus | mordred: could be gluten free toast | 22:57 |
| mordred | that sounds like gluten free cream of wheat | 22:58 |
| corvus | mordred: but maybe they're concerned about acrylamide | 22:58 |
| mordred | "I would add that Toasts are preferred for messages that refer to the app as a whole in addition to system messages, while Snackbars are preferred for messages that refer to the current activity. For example if your app checks for updates on launch, it's best to use a toast for the result message. If your app has items that can be deleted, its preferred to show the deleted response message as a snackbar with an undo button" | 22:58 |
| ianw | haha thanks, TIL | 22:59 |
| mordred | (that's from a stackoverflow, so YMMV) | 22:59 |
| corvus | mordred: great. as a user or developer i still don't know the difference. :) | 22:59 |
| mordred | ah - here's a better one | 22:59 |
| mordred | " would like to add a small comparison between toast and snack bar. In my opinion if your intention is to present a warning or info that need user interaction/acknowledgement, you should use a snack bar. If it is just an info message that doesn't need any user acknowledgement you can use toast." | 23:00 |
| corvus | okay that's starting to help :) | 23:00 |
| *** jkt has quit IRC | 23:01 | |
| mordred | the primary difference seems to be more an android thing - whether the message is display in the app context or the system context and whether you can swipe to dismiss | 23:02 |
| corvus | ack | 23:02 |
| *** jkt has joined #zuul | 23:02 | |
| mordred | in a web based material design basis, "just use snackbar" seems to be the answer :) | 23:02 |
| mordred | but also - wow | 23:03 |
| *** cloudnull has quit IRC | 23:05 | |
| ianw | so we have hamburgers, sliders, snackbars, toast, which are all both like a menus and usually on a menu | 23:05 |
| *** cloudnull has joined #zuul | 23:06 | |
| fungi | and don't forget, cookies | 23:08 |
| fungi | the food reference which i expect started it all | 23:08 |
| tosky | ianw: hi! Could you please (or anyone other core) take a look at https://review.opendev.org/c/zuul/zuul-jobs/+/771428 ? It should fix an issue we have hit in cinderlib jobs | 23:09 |
| ianw | tosky: sure, looking | 23:17 |
| tosky | thank you! | 23:27 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: Allow customization of helm charts repos https://review.opendev.org/c/zuul/zuul-jobs/+/767354 | 23:28 |
| openstackgerrit | James E. Blair proposed zuul/project-config master: Zuul: remove explicit SQL reporters https://review.opendev.org/c/zuul/project-config/+/775719 | 23:32 |
| corvus | zuul-maint: ^ i just restarted opendev's scheduler, so that's ready to merge now. | 23:35 |
| *** rlandy has quit IRC | 23:37 | |
| corvus | re-enqueue complete | 23:40 |
| corvus | service-announce message sent awaiting mod approval (fungi, clarkb) | 23:41 |
| corvus | and wrong channel sorry | 23:41 |
| openstackgerrit | Merged zuul/zuul-jobs master: Fix CentOS wheel mirror URL https://review.opendev.org/c/zuul/zuul-jobs/+/771428 | 23:47 |
| *** clarkb has joined #zuul | 23:52 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!