Tuesday, 2021-01-12

*** jamesmcarthur has joined #zuul00:08
*** tosky has quit IRC00:15
*** rlandy has quit IRC00:21
*** hamalq has quit IRC01:15
*** jamesmcarthur has quit IRC01:23
*** jamesmcarthur has joined #zuul01:35
*** zenkuro has quit IRC01:59
*** jamesmcarthur has quit IRC02:24
*** jamesmcarthur has joined #zuul02:37
*** wuchunyang has joined #zuul02:45
*** jamesmcarthur has quit IRC03:41
*** jamesmcarthur has joined #zuul03:43
*** wuchunyang has quit IRC04:00
*** jamesmcarthur has quit IRC04:59
*** jamesmcarthur has joined #zuul05:00
*** jamesmcarthur has quit IRC05:05
*** saneax has joined #zuul05:09
*** ykarel has joined #zuul05:23
*** ykarel_ has joined #zuul05:26
*** ykarel has quit IRC05:29
*** evrardjp has quit IRC05:33
*** evrardjp has joined #zuul05:33
*** wuchunyang has joined #zuul05:35
*** vishalmanchanda has joined #zuul05:35
*** jamesmcarthur has joined #zuul06:00
*** ykarel_ has quit IRC06:01
*** jamesmcarthur has quit IRC06:05
*** jfoufas1 has joined #zuul06:10
*** jamesmcarthur has joined #zuul07:09
*** jcapitao has joined #zuul07:09
*** jamesmcarthur has quit IRC07:15
*** jamesmcarthur has joined #zuul07:30
*** jamesmcarthur has quit IRC07:34
*** hashar has joined #zuul07:37
*** saneax has quit IRC07:37
*** jpena|off is now known as jpena07:46
*** ykarel_ has joined #zuul07:56
*** ykarel__ has joined #zuul07:58
*** ykarel__ is now known as ykarel08:01
*** ykarel_ has quit IRC08:01
*** rpittau|afk is now known as rpittau08:08
*** tosky has joined #zuul08:22
*** jamesmcarthur has joined #zuul08:51
*** jamesmcarthur has quit IRC08:55
*** piotrowskim has joined #zuul09:04
*** nils has joined #zuul09:21
avasswe're seeing zuul-web disconnecting from gearman because of a timeout now and then, I'm not sure why yet, but this doesn't seem to crash zuul-web and it also doesn't try to reconnect to gearman from what I can see09:24
avassso that makes us stuck with a pod in a bad state, adding a liveness probe probably mitigates that but is there any fix for this yet?09:26
*** mgoddard has joined #zuul09:32
tobiashavass: we've seen this as well and I think this might be thread starvation since zuul-web waits until every request is processed by the scheduler and there the processing is single threaded09:43
tobiashwe're using a liveness probe to circumvent this09:44
tobiashand https://review.opendev.org/c/zuul/zuul/+/70837709:44
avasstobiash: yeah I suspected something like that09:47
avassbut I think it would be a good idea if the pod could crash or try to reconnect if it doesn't have a gearman connection09:49
tobiashit does have a gearman connection, it's just that all threads wait for a task to finish in the scheduler (at least that's my assumption so far)09:52
avassI'm getting "No connected Gearman servers" after the first timeout so my assumption was that it disconnects :)09:55
avassbut I haven't spent a lot of time debugging this yet09:56
tobiashhrm, then your issue seems to be different than ours09:58
tobiashbut gear should actually reconnect automatically09:58
tobiashthat's weird09:58
avassoh however I think it just throws that when it times out so you could be right.10:03
*** jamesmcarthur has joined #zuul10:15
*** wuchunyang has quit IRC10:17
*** jamesmcarthur has quit IRC10:19
openstackgerritMatthieu Huin proposed zuul/zuul master: Example Docker compose: keycloak integration  https://review.opendev.org/c/zuul/zuul/+/76994310:21
*** saneax has joined #zuul10:30
tobiashcorvus: do you want to have a look at 765873 (bump openshift dep to solve urllib3 conflict in nodepool)? clarkb and I are authors that's why it has no +3 yet I guess10:38
avassokay so the problem seems to be that gear either isn't able to reconnect or that it never tries, but I only have error logs from gear so I can't see what happens10:50
tobiashis the problem just zuul-web or the executor as well?10:51
avasshaven't experienced any executor problems so I don't think so10:52
avasscan't see any gear errors in the executor logs10:55
*** rpittau has quit IRC11:06
*** rpittau has joined #zuul11:07
*** jcapitao is now known as jcapitao_lunch11:22
avassalso just noticed our executors seem to be leaking processes11:36
*** jamesmcarthur has joined #zuul11:44
*** jamesmcarthur has quit IRC11:49
*** zenkuro has joined #zuul12:01
tobiashzombies?12:16
avasszyup12:17
avassFoufas, Johannes12:17
avass8:58 AM12:17
avass12:17
avasswell, we will now if all build dll fails...12:17
tobiashwe run the executor under tini that reaps zombies12:17
avassoh oops, accidental paste12:17
tobiashneed to check if the upstream images do something similar12:18
avasswe're overriding that with a "zuul-executor -f -d" maybe not a good idea then :)12:19
*** dry has joined #zuul12:19
tobiashupstream doesn't do that as long python-base doesn't use it as entrypoint12:19
tobiashchecking12:20
avasshowever the executor image seem to be using /usr/local/bin/zuul-executor -f so it should be practically the same12:20
*** msuszko has quit IRC12:21
tobiashit's in python-base: https://opendev.org/opendev/system-config/src/branch/master/docker/python-base/Dockerfile#L3312:21
tobiashso that should be reaping12:21
tobiashavass: do you see dumb-init in ps12:21
avassno12:23
tobiashdo you build your own images?12:23
avassno but like I said, we're setting the command to "zuul-executor -f -d" to get debug logging instead12:23
tobiashcommand just appends to entrypoint, so if you overwrite cmd and not entrypoint that should be fine12:24
avassoh right12:25
*** jpena is now known as jpena|lunch12:25
*** jcapitao_lunch is now known as jcapitao12:41
*** rlandy has joined #zuul12:50
avasstobiash: kubernetes command actually overrides docker entrypoint, I think I've seen that before and explains my confusion :)13:08
*** jamesmcarthur has joined #zuul13:08
tobiashoh13:08
avassentrypoint -> command, command -> args13:08
tobiashway of least surprise...13:08
*** jamesmcarthur has quit IRC13:12
*** jamesmcarthur has joined #zuul13:14
*** jamesmcarthur has quit IRC13:19
*** jpena|lunch is now known as jpena13:21
*** rfolco has joined #zuul13:41
avasstobiash: yeah that fixed it13:42
*** jamesmcarthur has joined #zuul14:38
*** ikhan has joined #zuul15:00
mordredyeah - you want to keep dumb-init in your command line if you're overriding things16:00
mordredoh  - nevermind - I was scrolled back a smidge16:00
*** zenkuro has quit IRC16:12
*** zenkuro has joined #zuul16:13
*** jfoufas1 has quit IRC16:34
*** jcapitao has quit IRC16:39
*** sshnaidm|ruck is now known as sshnaidm|afk16:47
*** openstackgerrit has quit IRC16:55
*** jpena is now known as jpena|off17:01
*** rpittau is now known as rpittau|afk17:32
*** piotrowskim has quit IRC17:33
*** nils has quit IRC17:48
*** hamalq has joined #zuul17:58
*** ykarel has quit IRC18:00
tristanCcorvus: could you please reconsider your -2 on this zuul-runner change https://review.opendev.org/c/zuul/zuul/607078 , if we can merge it, then it would be possible to test the other zuul-runner change with real job from an existing zuul18:15
tristanC(this change, and the other one to support depends-on are the only one affecting the rest api used by the zuul-runner cli)18:16
fungilooks like it's lifted now18:27
corvustristanC: i've removed the -2 because we merged the spec, so we have consensus there.  though i was and still am concerned about merging changes to the api without reviewing the whole stack18:27
corvustristanC: i agree it might be nice for folks to test it out against a real zuul, but i don't think that's necessary18:28
corvustristanC: i'm not opposed, just 'concerned'  :)18:29
corvus(i don't want to make it harder to fix the api if we find a problem with it several changes down the stack, that's all)18:29
corvustristanC: maybe the way to address that is to get at least some review of the whole stack before merging that one, even if the whole stack isn't 2x+2 yet18:30
*** jamesmcarthur has quit IRC18:32
tristanCcorvus: alright, thank you, i'm working on rebasing the stack again.18:32
*** jamesmcarthur has joined #zuul18:34
*** jamesmcarthur has quit IRC18:39
*** ianychoi_ has quit IRC18:46
*** ianw_pto is now known as ianw18:58
*** jamesmcarthur has joined #zuul19:17
*** jamesmcarthur has quit IRC19:22
*** hashar has quit IRC19:30
*** holser has quit IRC19:31
*** holser has joined #zuul19:35
*** holser has quit IRC19:39
*** holser has joined #zuul19:40
*** zenkuro has quit IRC19:42
*** holser has quit IRC19:43
*** zenkuro has joined #zuul19:43
*** holser has joined #zuul19:43
*** arxcruz has quit IRC20:14
*** zenkuro has quit IRC20:15
*** zenkuro has joined #zuul20:15
*** jamesmcarthur has joined #zuul20:36
*** jamesmcarthur has quit IRC20:40
*** jamesmcarthur has joined #zuul20:40
*** vishalmanchanda has quit IRC20:49
corvustristanC, clarkb, tobiash: question on https://review.opendev.org/76587321:11
clarkbcorvus: I'll have to differ to tobiash on that question as the change in question was one of tobiash's edits21:13
*** rfolco has quit IRC21:25
*** hashar has joined #zuul21:31
tobiashresponded, it was necessary to make it work. I don't know if it works with v4 though21:47
*** openstackgerrit has joined #zuul21:48
openstackgerritTristan Cacqueray proposed zuul/zuul master: Separate out executor concerns from AnsibleJob  https://review.opendev.org/c/zuul/zuul/+/64864321:48
corvustobiash, tristanC: i'm confused; we should have been using openshift3 for a while in the func test; i would not expect the client library to force a change like that21:53
tobiashthe old library might have done some implicit conversion. All I can tell is that it only worked lime this.21:56
tobiash*like21:56
corvusok, that wfm; i think the only remaining q i have is whether we think anyone is using v4 and if we need to test this with v4?21:56
corvusmy guess is that if neither tobiash nor tristanC are using v4, the number of v4 users is probably pretty close to 021:57
corvustristanC: i upgraded my vote on 765873 to +2; i'll let you +W based on your feelings about whether we need to test v4.21:59
tristanCcorvus: it seems quite difficult to run func test with v4 without an existing deployment22:01
corvustristanC: yeah, i was thinking testing 'by hand'22:01
corvusbut if you aren't then i don't know of anyone using v4 yet, so it's probably not important22:02
tristanCcorvus: we do use v4 internally, but through the simpler openshiftpods driver22:02
tristanC(which doesn't create service account or rolebinding)22:03
corvustristanC: ok.  i leave it at your discretion :)22:03
tobiashI dont't have a v4 testenv yet, but I think if its not working (I'd assume it will work since the want a hich degree of backwards compatibility) fixing it would be easy by adding a fallback22:03
corvustobiash: i agree, backwards compat on this seems likely22:04
openstackgerritTristan Cacqueray proposed zuul/zuul master: runner: implement prep-workspace  https://review.opendev.org/c/zuul/zuul/+/60708222:11
openstackgerritTristan Cacqueray proposed zuul/zuul master: runner: add configuration schema  https://review.opendev.org/c/zuul/zuul/+/64067222:13
openstackgerritTristan Cacqueray proposed zuul/zuul master: runner: add prepare-workspace command line interface  https://review.opendev.org/c/zuul/zuul/+/64477022:16
openstackgerritTristan Cacqueray proposed zuul/zuul master: runner: add execute sub-command  https://review.opendev.org/c/zuul/zuul/+/63094422:23
openstackgerritJames E. Blair proposed zuul/zuul-website master: Adding Get Started page  https://review.opendev.org/c/zuul/zuul-website/+/76652022:37
*** arxcruz has joined #zuul23:09
openstackgerritJames E. Blair proposed zuul/zuul-website master: Adjust title on Get Started page  https://review.opendev.org/c/zuul/zuul-website/+/77049023:12
openstackgerritJames E. Blair proposed zuul/zuul-website master: Add "Get Started" link to header  https://review.opendev.org/c/zuul/zuul-website/+/77049123:12
openstackgerritJames E. Blair proposed zuul/zuul-website master: Add vexxhost and opendev logos to get-started  https://review.opendev.org/c/zuul/zuul-website/+/77049223:12
openstackgerritJames E. Blair proposed zuul/zuul-website master: Link to opendev.org on get-started page  https://review.opendev.org/c/zuul/zuul-website/+/77049323:12
openstackgerritJames E. Blair proposed zuul/zuul-website master: Add Acme Gating to get-started page  https://review.opendev.org/c/zuul/zuul-website/+/77049423:12
corvusjamesmcarthur, fungi: ^23:12
*** hashar has quit IRC23:15
corvusmnaser: can you ack 770492 in particular?  I took the liberty of proposing we add your logo in that change.23:16
*** jamesmcarthur has quit IRC23:16
fungimnaser: but also 770491 since we're mentioning vexxhost's service offering there23:16
fungier, i mean 76652023:17
corvusoh yep, that too :)23:17
fungii would have approved it already otherwise23:18
*** rlandy has quit IRC23:19
corvusthe logos are two circles and a triangle.  that amuses me for some reason.23:20
corvusnotably missing: squares and octogons ("stop" merging broken code!)23:21
fungithe retentive topologist in me wants to redo one of the circles as a spindle so we have one, two and three segment forms23:22
openstackgerritMerged zuul/nodepool master: Bump openshift dep  https://review.opendev.org/c/zuul/nodepool/+/76587323:25
*** jamesmcarthur has joined #zuul23:31
*** jamesmcarthur has quit IRC23:35
*** jamesmcarthur has joined #zuul23:35

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!