*** rfolco has quit IRC | 00:02 | |
*** rfolco has joined #zuul | 00:03 | |
*** tosky has quit IRC | 00:39 | |
*** zenkuro has quit IRC | 00:45 | |
*** holser has quit IRC | 01:02 | |
*** holser has joined #zuul | 01:04 | |
*** holser has quit IRC | 01:43 | |
*** rfolco has quit IRC | 01:51 | |
*** bhavikdbavishi has joined #zuul | 03:55 | |
*** ykarel has joined #zuul | 04:21 | |
*** bhavikdbavishi has quit IRC | 05:25 | |
*** saneax has joined #zuul | 05:29 | |
*** evrardjp has quit IRC | 05:33 | |
*** evrardjp has joined #zuul | 05:33 | |
*** saneax has quit IRC | 06:15 | |
*** saneax has joined #zuul | 06:58 | |
*** bhavikdbavishi has joined #zuul | 07:27 | |
*** bhavikdbavishi1 has joined #zuul | 09:50 | |
*** bhavikdbavishi has quit IRC | 09:52 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 09:52 | |
*** hamalq has joined #zuul | 10:47 | |
*** hamalq has quit IRC | 10:52 | |
*** hamalq has joined #zuul | 10:55 | |
*** hamalq has quit IRC | 11:00 | |
*** bhavikdbavishi has quit IRC | 11:40 | |
*** zenkuro has joined #zuul | 11:45 | |
*** rfolco has joined #zuul | 11:57 | |
*** bhavikdbavishi has joined #zuul | 12:01 | |
*** tosky has joined #zuul | 12:05 | |
*** bhavikdbavishi1 has joined #zuul | 12:50 | |
*** bhavikdbavishi has quit IRC | 12:52 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 12:52 | |
*** bhavikdbavishi has quit IRC | 13:24 | |
*** holser has joined #zuul | 14:14 | |
*** zenkuro has quit IRC | 15:07 | |
*** zenkuro has joined #zuul | 15:07 | |
*** sshnaidm|rover is now known as sshnaidm|afk | 15:34 | |
*** noonedeadpunk has quit IRC | 15:48 | |
*** holser has quit IRC | 15:48 | |
*** noonedeadpunk has joined #zuul | 15:50 | |
*** saneax has quit IRC | 16:30 | |
*** bhavikdbavishi has joined #zuul | 16:35 | |
*** noonedeadpunk has quit IRC | 16:40 | |
*** noonedeadpunk_ has joined #zuul | 16:48 | |
*** hamalq has joined #zuul | 17:01 | |
*** ykarel has quit IRC | 17:24 | |
*** hamalq has quit IRC | 18:04 | |
*** bhavikdbavishi has quit IRC | 18:10 | |
*** hamalq has joined #zuul | 18:16 | |
*** hamalq has quit IRC | 18:20 | |
*** hamalq has joined #zuul | 18:31 | |
*** hamalq has quit IRC | 18:36 | |
*** saneax has joined #zuul | 19:33 | |
*** saneax has quit IRC | 19:39 | |
*** masterpe has joined #zuul | 20:20 | |
masterpe | I'm using zuul with the gitlab driver, but currently it is only cloning the default branch but what is the best why to change to use the source_branch. I was not able to find the answer in the docu or the driver code? | 20:20 |
---|---|---|
clarkb | masterpe: zuul should prepare all branches for a repo and then you can check them out in the jobs | 20:58 |
clarkb | masterpe: do you mean that a gitlab PR is made against branch foo but the driver is defaulting to using master/main in the job? | 20:59 |
clarkb | because the default checkout on the job side should be the PR itself (then you can switch from there) | 20:59 |
masterpe | Yes | 20:59 |
clarkb | hrm the default checkout should be for the change/PR merged against whatever its target is. Then on the test node that checked out state has the name of the target | 21:01 |
clarkb | there isn't a thing to force that beacuse it should just do that anyway | 21:01 |
clarkb | really quickly looking at the driver source it seems to set the event.branch values to the gitlab event's target_branch | 21:02 |
*** holser has joined #zuul | 21:02 | |
clarkb | which is how it would do what I describe | 21:02 |
masterpe | That is the target branch but how do I checkout the source branch? | 21:05 |
clarkb | masterpe: you mean the originating side of the PR? eg the branch on my fork? | 21:05 |
masterpe | Yes | 21:06 |
clarkb | I don't think you can because zuul is only looking at the target side (the events originate there and zuul is not likely to be tied to your forks) | 21:06 |
clarkb | what you can do is look at the delta between master and refs/origin/master since refs/origin/master is the pristine state and master is the pristine state + the PR | 21:07 |
clarkb | this might be a sitaution where zuul shows its original integration with gerrit too much (gerrit doesn't do forks so there really isn't a source "side" to consider). It might be useful to describe the use case here to either determine if a functional workaround is doable or if zuul needs to be extended somehow | 21:09 |
clarkb | masterpe: double checking the event ingestion code I don't think it records taht info from the event at all | 21:14 |
clarkb | the "change_url" is recorded though so possible the job could look it up via that url? | 21:14 |
*** holser has quit IRC | 21:16 | |
*** holser has joined #zuul | 21:17 | |
masterpe | I only do a branch in that branch I change the code. After that I do a Merge request to the default branch. | 21:18 |
masterpe | In the webhook from Gitlab I also see the source_branch variable | 21:21 |
clarkb | right I think zuul is interested in the merge request (because that reflects a potential future state). If you want to test branches before they get merge requested you may be able to use the gl_push trigger along with a ref regex to filter out branches to ignore? | 21:22 |
clarkb | masterpe: yes, I expect the event emitted includes the info but zuul's event ingestion doesn't seem to do anything with it that I can see | 21:23 |
clarkb | I think the piece of info I'm missing is how is that source_branch information and content useful to jobs running under zuul. Zuul is buitl around examining proposed future states and testing them as if they had merged. Describing how the source side before constructing the proposed state is useful would probably help me | 21:26 |
*** aprice has quit IRC | 21:28 | |
*** aprice has joined #zuul | 21:30 | |
clarkb | I have to pop out now but will check back in later to see if there is more info | 21:34 |
masterpe | Thanks for your help for now. | 21:37 |
masterpe | I was thinking in using {{ zuul.projects['git.example.com/org/project'].checkout }} -> https://zuul-ci.org/docs/zuul/reference/jobs.html#var-zuul.projects.checkout to change the branch in a pre playbook. | 21:38 |
masterpe | But this still gives me the default branch and not the branch where I'm working in. | 21:41 |
*** rfolco has quit IRC | 21:43 | |
*** rfolco has joined #zuul | 22:11 | |
*** rfolco has quit IRC | 22:12 | |
*** rfolco has joined #zuul | 22:13 | |
*** rfolco has quit IRC | 22:18 | |
*** holser has quit IRC | 23:09 | |
*** holser has joined #zuul | 23:35 | |
*** rfolco has joined #zuul | 23:44 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!