Tuesday, 2020-12-22

« Monday, 2020-12-21 Index Wednesday, 2020-12-23 »
*** cloudnull has quit IRC00:07
*** rlandy has quit IRC00:21
*** ikhan has joined #zuul00:27
*** ikhan has quit IRC00:32
*** ikhan has joined #zuul01:01
*** cloudnull has joined #zuul01:01
*** ikhan has quit IRC01:05
*** ikhan has joined #zuul01:17
*** bhavikdbavishi has joined #zuul03:27
*** ikhan has quit IRC03:27
*** bhavikdbavishi1 has joined #zuul03:30
*** bhavikdbavishi has quit IRC03:31
*** bhavikdbavishi1 is now known as bhavikdbavishi03:31
*** ykarel has joined #zuul04:40
*** ykarel has quit IRC04:45
*** ykarel has joined #zuul05:04
*** vishalmanchanda has joined #zuul05:17
*** hamalq has quit IRC05:37
*** evrardjp has quit IRC05:40
*** evrardjp has joined #zuul05:41
*** jfoufas1 has joined #zuul06:07
*** bhavikdbavishi has quit IRC06:11
*** bhavikdbavishi has joined #zuul06:32
*** bhavikdbavishi1 has joined #zuul06:35
*** bhavikdbavishi has quit IRC06:37
*** bhavikdbavishi1 is now known as bhavikdbavishi06:37
*** bhavikdbavishi has quit IRC06:54
*** ikhan has joined #zuul06:57
*** bhavikdbavishi has joined #zuul07:20
*** swest has quit IRC08:17
*** swest has joined #zuul08:18
*** zenkuro has joined #zuul08:34
*** zenkuro has quit IRC08:39
*** zenkuro has joined #zuul08:40
*** hashar has joined #zuul08:51
*** sanjayu_ has joined #zuul08:52
*** saneax has quit IRC08:54
*** saneax has joined #zuul08:59
*** jpena|off is now known as jpena08:59
*** sanjayu_ has quit IRC09:01
*** ikhan has quit IRC09:07
*** saneax has quit IRC09:07
openstackgerritMerged zuul/zuul master: Add post_review pipeline variable to jobs  https://review.opendev.org/c/zuul/zuul/+/76698209:11
*** danpawlik has quit IRC09:32
*** danpawlik0 has joined #zuul09:32
*** reiterative has quit IRC09:33
*** reiterative has joined #zuul09:35
*** nils has joined #zuul09:43
*** ikhan has joined #zuul09:50
*** bhavikdbavishi has quit IRC09:57
*** bhavikdbavishi has joined #zuul10:02
*** bhavikdbavishi has quit IRC10:23
*** maxamillion has joined #zuul10:29
*** ericsysmin has joined #zuul10:30
*** rpittau|afk has joined #zuul10:30
*** johnsom has joined #zuul10:33
*** bhavikdbavishi has joined #zuul10:41
openstackgerritMatthieu Huin proposed zuul/zuul master: Web UI: allow a privileged user to request autohold  https://review.opendev.org/c/zuul/zuul/+/76811510:45
*** saneax has joined #zuul10:53
openstackgerritClément Mondion proposed zuul/zuul master: [UI][Nodes] use patternfly 4  https://review.opendev.org/c/zuul/zuul/+/76819210:59
*** holser_ has quit IRC11:04
*** holser has joined #zuul11:06
*** evrardjp_ has joined #zuul11:11
*** evrardjp has quit IRC11:11
*** bhavikdbavishi has quit IRC11:15
*** bhavikdbavishi has joined #zuul11:20
*** jfoufas1 has quit IRC11:21
*** dry has joined #zuul11:36
*** msuszko has quit IRC11:37
*** jfoufas1 has joined #zuul11:48
*** tosky has joined #zuul12:02
*** icey has quit IRC12:04
*** icey has joined #zuul12:04
openstackgerritMatthieu Huin proposed zuul/zuul master: web UI: user login with OpenID Connect  https://review.opendev.org/c/zuul/zuul/+/73408212:05
openstackgerritMatthieu Huin proposed zuul/zuul master: Add authentication-realm attribute to tenants  https://review.opendev.org/c/zuul/zuul/+/73558612:06
openstackgerritMatthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to dequeue a change  https://review.opendev.org/c/zuul/zuul/+/73485012:06
openstackgerritMatthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to re-enqueue a change  https://review.opendev.org/c/zuul/zuul/+/73677212:07
openstackgerritMatthieu Huin proposed zuul/zuul master: Web UI: allow a privileged user to request autohold  https://review.opendev.org/c/zuul/zuul/+/76811512:07
*** hashar is now known as hasharLunch12:14
*** ikhan has quit IRC12:29
*** jpena is now known as jpena|lunch12:35
openstackgerritMatthieu Huin proposed zuul/zuul master: Web UI: add Autoholds page  https://review.opendev.org/c/zuul/zuul/+/76819912:54
*** Oriz has joined #zuul13:01
*** rlandy has joined #zuul13:03
*** hasharLunch is now known as hashar13:09
*** bhavikdbavishi has quit IRC13:15
*** cloudnull has quit IRC13:16
*** ikhan has joined #zuul13:17
*** cloudnull has joined #zuul13:17
*** ikhan has quit IRC13:21
*** jpena|lunch is now known as jpena13:33
*** ykarel_ has joined #zuul13:53
*** ikhan has joined #zuul13:53
*** ykarel has quit IRC13:56
*** ykarel_ is now known as ykarel14:07
*** ikhan has quit IRC14:19
openstackgerritMatthieu Huin proposed zuul/zuul master: Web UI: add Autoholds page  https://review.opendev.org/c/zuul/zuul/+/76819914:19
openstackgerritSorin Sbârnea proposed zuul/zuul master: Deprecates old admin client  https://review.opendev.org/c/zuul/zuul/+/76556414:41
*** hashar has quit IRC15:35
mhuwhat's the status of gearman as a component of Zuul?15:36
openstackgerritMatthieu Huin proposed zuul/zuul master: gerrit: fix invalid ref computation from change  https://review.opendev.org/c/zuul/zuul/+/76822915:51
corvusmhu: i'm not sure i understand the question15:52
mhuzuul-maint, a small fix for christmas ^ :)15:52
mhucorvus, I thought gearman wasn't going to be used anymore in Zuul, I might have misunderstood that15:53
corvusmhu: that is likely to be true in v515:53
corvus(at least, that's the plan; it's possible that during the zk work we find some things that gearman is still suited for, but at the moment, we anticipate removing gearman in v5)15:53
zbrmhu: i could easily wonder why it has no tests ;)15:54
corvuszbr: it has tests15:54
mhuzbr, I wouldn't have noticed if I wasn't doing my UI devs on a fresh SF install15:55
zbri did a grep on getRefForChange but found no file with test in it.15:55
zbrit should be extremely easy to add an unit test for it, particulary this bug15:55
corvusoh i thought we were talking about gearman15:55
mhuzbr, corvus re: the status of gearman, my question was related to https://review.opendev.org/c/zuul/zuul/+/76556415:56
corvusmhu: question on 76822915:56
zbrhaving a test with change 1, 10, 100000 would not hurt.15:57
mhucorvus, good question, I'm currently seeing the problem with gerrit 315:58
corvusmhu: i suspect the problem may not exist with older gerrit15:59
corvusmhu: or -- and this is maybe more important -- newer gerrits with old changes created in old gerrit15:59
corvusmhu: eg, any of the gerrits we run :)15:59
mhuI apologize for deploying brand new gerrits, I won't do it again! :P16:00
*** bhavikdbavishi has joined #zuul16:00
clarkbhow does the zuul quickstart integration testing work?16:00
clarkbmaybe that doesn't create any new changes?16:01
clarkb(re testing ^ I would've expected that to give some coverage)16:01
mhucorvus, that complicates things though ... how do I know a change was created on 2.X ?16:01
corvusclarkb: it does create testing16:01
corvuser create changes16:01
corvusmhu: i don't know how you could tell that (and i don't know if it's necessary).  all i know is that this is something that someone should look into before we merge that change16:02
corvusmhu: replied on 76556416:03
*** jfoufas1 has quit IRC16:07
mhucorvus, re: the getRefForChange fix, it seems to affect gerrit 2.X as well, see https://review.rdoproject.org/r/#/c/3/16:16
*** ykarel has quit IRC16:16
mhuthis is a gerrit 2.14.7 instance16:16
corvusmhu: how did the bug manifest in zuul?16:17
mhucorvus, while working on autoholds from the UI, and using a fresh gerrit + zuul deployment16:18
mhuI'm sending an autohold request for a change with a low id, and the ref is computed incorrectly16:19
mhuthe ref filter i mean16:19
corvusmhu: oh, interesting.  that method is only ever used for autohold16:19
mhubut the bug is reproducible from the CLIs as well, since the pb with the ref is in the gerritsource driver16:20
corvusyeah, it's called by the rpc listener16:20
mhucorvus, yes and you'd only notice it for the 100 first changes on gerrit!16:20
*** Oriz has quit IRC16:24
corvusmhu: i think we understand enough to know the change is okay.  regarding tests, normally i would say that a simple unit test that just tests that you typed the right thing twice isn't necessary, however, i think there is in fact an obob (off by one bug) in the change, so maybe a simple test as zbr suggests isn't a bad idea :)16:27
mhucorvus, yeah I was looking to squeeze a test in test_scheduler16:27
mhualso simplifying the fix with zfill16:28
*** bhavikdbavishi1 has joined #zuul16:29
*** bhavikdbavishi has quit IRC16:30
*** bhavikdbavishi1 is now known as bhavikdbavishi16:30
openstackgerritMatthieu Huin proposed zuul/zuul master: gerrit: fix invalid ref computation from change  https://review.opendev.org/c/zuul/zuul/+/76822916:35
*** vishalmanchanda has quit IRC16:44
openstackgerritMatthieu Huin proposed zuul/zuul master: gerrit: fix invalid ref computation from change  https://review.opendev.org/c/zuul/zuul/+/76822916:48
openstackgerritMatthieu Huin proposed zuul/zuul master: Web UI: allow a privileged user to request autohold  https://review.opendev.org/c/zuul/zuul/+/76811516:52
openstackgerritMatthieu Huin proposed zuul/zuul master: Web UI: add Autoholds page  https://review.opendev.org/c/zuul/zuul/+/76819916:52
*** hamalq has joined #zuul16:55
*** hamalq_ has joined #zuul16:56
*** hashar has joined #zuul17:00
*** hamalq has quit IRC17:00
mhuI'm leaving now until Jan 4, but I think the auth-related changes in the web UI are reviewable already17:04
mhuhttps://review.opendev.org/q/topic:%22fffaff%22+(status:open%20OR%20status:merged) (don't mind the random topic name)17:05
corvusmhu: enjoy the holidays, see you next year!17:05
mhuthere should be enough doc in the first patch to get google auth set up relatively painlessly17:05
mhuthanks corvus, enjoy the break too!17:06
openstackgerritMatthieu Huin proposed zuul/zuul master: Web UI: add Autoholds page  https://review.opendev.org/c/zuul/zuul/+/76819917:08
*** nils has quit IRC17:20
*** jpena has quit IRC17:45
*** sanjayu_ has joined #zuul17:51
*** saneax has quit IRC17:54
*** bhavikdbavishi has quit IRC18:15
*** bhavikdbavishi has joined #zuul18:15
*** ikhan has joined #zuul18:16
*** ikhan has quit IRC18:20
*** hashar has quit IRC18:21
mhuone last thing that might interest you: FOSDEM'21 will be full virtual and they haven't had a lot of talks submissions for the CI/CD track. If someone's motivated to talk about Zuul it might be a good opportunity to earn geek points18:30
fungijust have to stock your fridge with belgian beer in advance18:31
mhufungi, I have a delirium cafe in my town18:32
mhuwell, it was open in the Before Times, the Long Long Ago18:33
*** bhavikdbavishi has quit IRC18:52
avassmhu: the web-auth changes are appreciated, we're gonna try to deploy it as soon as possible after they're merged :)19:42
*** rfolco has quit IRC21:27
*** rfolco has joined #zuul22:19
*** rfolco has quit IRC22:23
*** ikhan has joined #zuul22:49
*** ikhan has joined #zuul22:50
*** ikhan has quit IRC23:30
*** zenkuro has quit IRC23:41
*** tosky has quit IRC23:57
« Monday, 2020-12-21 Index Wednesday, 2020-12-23 »

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!