Tuesday, 2020-12-15

*** sanjayu_ has joined #zuul00:06
*** saneax has quit IRC00:08
*** tosky has quit IRC00:10
*** rlandy has quit IRC00:18
*** rfolco has quit IRC00:19
*** rfolco has joined #zuul00:19
*** icey has quit IRC00:23
*** rfolco has quit IRC00:25
*** zenkuro has quit IRC00:31
*** hamalq_ has quit IRC02:55
*** bhavikdbavishi has joined #zuul03:14
*** bhavikdbavishi1 has joined #zuul03:17
*** bhavikdbavishi has quit IRC03:19
*** bhavikdbavishi1 is now known as bhavikdbavishi03:19
*** bhavikdbavishi has quit IRC03:37
*** bhavikdbavishi has joined #zuul03:39
*** bhavikdbavishi has quit IRC03:42
*** bhavikdbavishi has joined #zuul03:43
*** bhavikdbavishi has quit IRC04:00
*** bhavikdbavishi has joined #zuul04:04
*** bhavikdbavishi has quit IRC04:11
*** bhavikdbavishi has joined #zuul04:34
*** vishalmanchanda has joined #zuul05:04
*** bhavikdbavishi has quit IRC05:31
*** evrardjp has quit IRC05:33
*** evrardjp has joined #zuul05:33
vishalmanchandahi morning.05:41
vishalmanchandaCan I ask for another vote on this patch https://review.opendev.org/c/zuul/zuul-jobs/+/766744 ?05:41
vishalmanchandaIt's unblock  openstack/horizon gate.05:42
*** bhavikdbavishi has joined #zuul06:01
*** jfoufas1 has joined #zuul06:05
*** bhavikdbavishi1 has joined #zuul06:19
*** bhavikdbavishi has quit IRC06:20
*** bhavikdbavishi1 is now known as bhavikdbavishi06:20
openstackgerritMerged zuul/zuul-jobs master: Add Firefox browser role for horizon nodejs job  https://review.opendev.org/c/zuul/zuul-jobs/+/76674406:24
*** bhavikdbavishi has quit IRC06:45
*** bhavikdbavishi has joined #zuul07:09
openstackgerritSimon Westphahl proposed zuul/zuul master: Make reporting asynchronous  https://review.opendev.org/c/zuul/zuul/+/69125307:25
openstackgerritSimon Westphahl proposed zuul/zuul master: Allow refreshing changes in canMerge() check  https://review.opendev.org/c/zuul/zuul/+/76708407:25
*** bhavikdbavishi1 has joined #zuul07:26
*** bhavikdbavishi has quit IRC07:28
*** bhavikdbavishi1 is now known as bhavikdbavishi07:28
*** icey has joined #zuul07:42
*** bhavikdbavishi has quit IRC07:51
*** jcapitao has joined #zuul07:57
*** bhavikdbavishi has joined #zuul08:01
*** mach1na has joined #zuul08:02
*** bhavikdbavishi has quit IRC08:04
*** bhavikdbavishi has joined #zuul08:04
*** rpittau|afk is now known as rpittau08:06
openstackgerritSimon Westphahl proposed zuul/zuul master: Allow refreshing changes in canMerge() check  https://review.opendev.org/c/zuul/zuul/+/76708408:14
openstackgerritSimon Westphahl proposed zuul/zuul master: Check cycle items are mergeable before reporting  https://review.opendev.org/c/zuul/zuul/+/74345008:14
openstackgerritSimon Westphahl proposed zuul/zuul master: Make reporting asynchronous  https://review.opendev.org/c/zuul/zuul/+/69125308:14
*** nilsph has joined #zuul08:31
*** tosky has joined #zuul08:41
*** jpena|off is now known as jpena08:57
*** zenkuro has joined #zuul09:21
*** bhavikdbavishi has quit IRC09:26
*** bhavikdbavishi has joined #zuul09:27
*** bhavikdbavishi has quit IRC09:37
*** piotrowskim has joined #zuul10:14
*** vishalmanchanda has quit IRC10:22
*** wuchunyang has joined #zuul10:27
*** rpittau is now known as rpittau|bbl10:27
*** vishalmanchanda has joined #zuul10:30
*** wuchunyang has quit IRC10:32
openstackgerritLida Liu proposed zuul/zuul master: Fix errors regarding parsing timestamps  https://review.opendev.org/c/zuul/zuul/+/76599010:34
*** mach1na has quit IRC10:41
*** mach1na has joined #zuul11:00
tobiashianw: are there still centos related dib fixes in the pipeline? There are still two failing nodepool functional jobs, e.g. https://zuul.opendev.org/t/zuul/build/5ffce5f02bd74dfe810ad2615640375f11:04
*** wuchunyang has joined #zuul11:12
avasstobiash: I think there was a discussion in the issue a linked, or one of the links in there that explains that gitlab isn't always consistent with ISO format11:16
avassI think Lida happened to bump into that11:16
openstackgerritLida Liu proposed zuul/zuul master: Fix errors regarding parsing timestamps  https://review.opendev.org/c/zuul/zuul/+/76599011:30
*** jcapitao is now known as jcapitao_lunch11:30
openstackgerritLida Liu proposed zuul/zuul master: Fix errors regarding parsing timestamps  https://review.opendev.org/c/zuul/zuul/+/76599011:45
*** rfolco has joined #zuul11:46
zbr|rovercan I add an additional role to existing jobs without being forced to create new jobs? I need to add ensure-yarn for a specific tox-docs job and apparently it does not work via https://review.opendev.org/c/zuul/zuul/+/766460/7/.zuul.yaml12:05
zbr|roverthere are lots of cases where user may want to mix-and-match various roles w/o having to create extra jobs.12:06
*** ikhan has quit IRC12:06
*** ikhan has joined #zuul12:08
*** ikhan has quit IRC12:08
*** ikhan has joined #zuul12:09
*** mach1na has quit IRC12:12
openstackgerritSorin Sbârnea proposed zuul/project-config master: Add yarn to zuul-tox-docs  https://review.opendev.org/c/zuul/project-config/+/76712212:12
*** ikhan has quit IRC12:14
openstackgerritSorin Sbârnea proposed zuul/zuul master: Document tox environments  https://review.opendev.org/c/zuul/zuul/+/76646012:15
openstackgerritSorin Sbârnea proposed zuul/zuul master: Document tox environments  https://review.opendev.org/c/zuul/zuul/+/76646012:17
zbr|rovertobiash: any chance to look again at https://review.opendev.org/c/zuul/zuul/+/711002/ - the one on zuul_return overrides on retries. Are new changes needed?12:24
*** ikhan has joined #zuul12:28
*** hashar has joined #zuul12:34
*** jpena is now known as jpena|lunch12:35
*** zenkuro has quit IRC12:43
*** zenkuro has joined #zuul12:44
openstackgerritSorin Sbârnea proposed zuul/project-config master: Add yarn to zuul-tox-docs  https://review.opendev.org/c/zuul/project-config/+/76712212:51
*** cloudnull has quit IRC12:59
*** mach1na has joined #zuul13:00
*** cloudnull has joined #zuul13:00
*** rlandy has joined #zuul13:02
*** jcapitao_lunch is now known as jcapitao13:04
*** frenzyfriday has joined #zuul13:04
*** rpittau|bbl is now known as rpittau13:12
*** frenzyfriday has quit IRC13:20
tobiashzbr|rover: I'm now co-author of that so didn't vote, I think I've hopefully addressed all comments13:26
zbr|rovertobiash: i think is ok to vote if you are co-author, otherwise we would have a bunch of projects were it would be impossible to do anything :D13:27
zbr|roverusually I would refrain from voting in full if my contribution was signifiant, but most cases I do only fix minor bits.13:28
tobiashI'd like corvus to re-review that due to the earlier -113:28
zbr|rovertobiash: no worries, I was waiting for him to appear for the same reason, he had multiple questions, he should do make final decision on this one.13:29
*** jpena|lunch is now known as jpena13:36
*** zenkuro has quit IRC13:37
*** zenkuro has joined #zuul13:38
*** vishalmanchanda has quit IRC13:52
openstackgerritLida Liu proposed zuul/zuul master: Fix errors regarding parsing timestamps  https://review.opendev.org/c/zuul/zuul/+/76599014:07
*** smyers has quit IRC14:18
*** smyers has joined #zuul14:20
openstackgerritTobias Henkel proposed zuul/zuul master: Don't bail out if change behind cannot be queried  https://review.opendev.org/c/zuul/zuul/+/76716214:28
*** nilsph is now known as nils14:41
*** wuchunyang has quit IRC14:54
openstackgerritLida Liu proposed zuul/zuul master: Fix errors regarding parsing timestamps  https://review.opendev.org/c/zuul/zuul/+/76599015:29
*** jfoufas1 has quit IRC16:21
*** ikhan has quit IRC16:24
*** mach1na has quit IRC16:30
*** ikhan has joined #zuul16:31
openstackgerritTobias Henkel proposed zuul/zuul master: Don't bail out if change behind cannot be queried  https://review.opendev.org/c/zuul/zuul/+/76716216:34
*** wuchunyang has joined #zuul16:55
*** wuchunyang has quit IRC16:59
*** piotrowskim has quit IRC17:02
*** hamalq has joined #zuul17:25
*** hamalq_ has joined #zuul17:27
*** hamalq has quit IRC17:31
openstackgerritTristan Cacqueray proposed zuul/zuul-operator master: Add allinone deployment and documentation  https://review.opendev.org/c/zuul/zuul-operator/+/76563017:33
*** jcapitao has quit IRC17:38
*** rpittau is now known as rpittau|afk17:46
*** jpena is now known as jpena|off18:14
*** wuchunyang has joined #zuul18:57
*** wuchunyang has quit IRC19:01
*** nils has quit IRC19:20
*** hashar is now known as hasharAway19:47
avasstristanC: the allinone deployment can probably generate sshkeys with a job pod to make it easier19:47
tristanCavass: good point, though it is just a mitigation until the issue is fixed by https://review.opendev.org/c/zuul/zuul/+/76458419:50
avassoh :)19:51
avasstristanC: you could probably take parts of: https://review.opendev.org/c/zuul/zuul-helm/+/765554 to set up zookeeper as well19:52
avassI converted tools/zk-cert script to an ansible version to easily set up test environments in kubernetes19:53
tristanCavass: once https://github.com/pravega/zookeeper-operator/issues/141 is fixed we can also replace the provided zk resources with it19:55
tristanCso i think there will be 3 toggles, withCertManager, withZookeeperOperator and withDbOperator19:57
avassoh look at that19:58
corvus++ to those toggles20:07
openstackgerritMerged zuul/zuul master: Fix override variables in zuul_return  https://review.opendev.org/c/zuul/zuul/+/71100220:17
corvusinfra-root: ^ we may want to consider a full zuul restart to pick up that bugfix at some point; however, i don't think it's super urgent since the incidences are generally caused by job retries due to gerrit instability.20:22
avassooh good timing, I was planning a restart in a couple of minutes20:24
fungicorvus: that needs a full scheduler restart, not just executors?20:24
corvusfungi: yep20:25
funginoted. i can try to do a full restart later today when things calm down20:25
fungiahh, right, the structures won't be executor-local because retries don't necessarily end up on the same executor20:26
fungiresult goes back to the scheduler and then it schedules a new build20:28
corvusfungi: yeah; changes to model.py in the change are a clue there that it's [probably] global impact20:31
fungimakes sense20:33
*** hasharAway has quit IRC20:34
*** goneri has joined #zuul21:01
ianwyeah i'm around all day to, so can look in on this afternoon21:03
fungiawesome, let's coordinate in that case21:05
fungi(in #opendev obviously)21:05
*** rfolco has quit IRC21:10
corvusianw, infra-root, zuul-maint: https://gerrit-review.googlesource.com/admin/repos/plugins/zuul-results-summary exists and i added ianw, fungi, mordred, clarkb, fungi to the management group for it https://gerrit-review.googlesource.com/admin/groups/e56b738774680c0b696c20385399cc728291c473,members21:11
ianwcorvus: awesome, thanks!  i can import what we have21:12
corvushappy for more folks to be added, that was just the folks i could immediately find with existing accounts21:12
ianwi have our job producing screenshot artifacts like https://bf9fadcef442efcdf20f-b95957069fa081f0196bfab2502640d8.ssl.cf2.rackcdn.com/767079/2/check/system-config-run-review/d8ad74f/bridge.openstack.org/screenshots/21:13
ianwhowever i need to et a bit better at selenium so it waits long enough for the page to load before taking the screenshot21:13
corvusi wonder if we could do something similar in gerrit's zuul21:13
corvusi expect we'd just run the jar instead of the docker container21:14
corvusbut other than that difference, seems like it should be translatable21:14
ianwyes, the hardest part was working out the undocumented (for now, I'll propose patch :) --dev flag to init to setup an admin user21:15
ianwif you init with --dev *and* DEVELOPMENT_BECOME_ANY_ACCOUNT as the auth type, it creates a admin user for you21:16
fungineat21:16
ianwthe upstream container i think either does that somehow, or sets up the initial user in the in-container ldap it is connected to21:17
ianwanyway, easy to inject sample data after that -> https://review.opendev.org/c/opendev/system-config/+/765224/17/playbooks/test-review.yaml21:18
ianwit's easy enough to wait for document.readyState to be 'complete' ... but it seems 'complete' doesn't actually mean it's complete, in true javascript form21:20
corvusianw: maybe you need to check that document.readyState =============== 'complete' ?  :)21:27
ianwit would not surprise me in the slightest if that was valid javascript for the sign-extend-cast-to-float-left-shift-floor-ceiling-instantiate-new-object operator :)21:31
corvuslol21:31
mordredI really want to add a joke but I think ianw already won21:45
tristanCianw: that's because readyState is a web api document property, framework like polymer or react extends that api and may need more time to settle21:52
ianwtristanC: yeah, it's hard to know what exactly to choose, especially with all this shadow-dom stuff polymer does22:07
tristanCianw: perhaps you could register an extra polymerReadyState withing https://polymer-library.polymer-project.org/3.0/api/utils/render-status#afterNextRender ?22:09
tristanCor using a setTimeout without a delay should trigger at the next render cycle22:10
ianwactually, a big part of it might be a red-herring and the test actually working, because i think i've written the plugin installation wrong and broken all plugins22:14
ianwhttps://[2607:ff68:100:54:f816:3eff:fe4c:2752]/c/test-project/+/1 is a sample of the latest layout22:20
ianwthe .js file has to be in the plugin directory, not a sub-directory.  that's a bit annoying, because it means you bind mount in the file from outside; which means that you can't easily edit it (anything that changes the inode)22:22
ianwcorvus: do you have an opinion on mounting the plugin into the container V building it into the container image?22:23
corvusianw: probably an #opendev q; i'd build it in unless there's a reason not to.  good to have complete docker images for easy testing/reuse.22:30
fungithat's the approach we already took with the theme plugin22:31
* fungi finds his change for that22:31
ianwit does mean that updates to the plugin require a restart22:31
corvus-> #opendev22:31
*** wuchunyang has joined #zuul22:58
*** wuchunyang has quit IRC23:03

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!