Friday, 2020-12-11

*** _erlon_ has quit IRC00:10
*** armstrongs has joined #zuul00:25
*** Goneri has joined #zuul00:34
*** armstrongs has quit IRC00:35
*** Goneri has quit IRC00:58
openstackgerritAkihiro Motoki proposed zuul/zuul-jobs master: nodejs-test-dependencies: Install xdg-utils  https://review.opendev.org/c/zuul/zuul-jobs/+/76664401:06
*** zenkuro has quit IRC01:21
*** hamalq_ has quit IRC02:05
-openstackstatus- NOTICE: The Gerrit service on review.opendev.org is being restarted quickly to enable support for Git protocol v2, downtime should be less than 5 minutes02:55
*** wuchunyang has joined #zuul03:03
*** bhavikdbavishi has joined #zuul03:06
*** bhavikdbavishi1 has joined #zuul03:09
*** bhavikdbavishi has quit IRC03:11
*** bhavikdbavishi1 is now known as bhavikdbavishi03:11
*** rlandy has quit IRC03:13
*** wuchunyang has quit IRC04:01
*** wuchunyang has joined #zuul04:49
*** wuchunyang has quit IRC04:54
*** wuchunyang has joined #zuul04:55
*** bhavikdbavishi has quit IRC05:23
*** evrardjp_ has quit IRC05:33
*** evrardjp has joined #zuul05:33
*** vishalmanchanda has joined #zuul05:47
*** bhavikdbavishi has joined #zuul05:56
*** bhavikdbavishi has quit IRC06:57
*** nils has joined #zuul07:44
*** zenkuro has joined #zuul07:46
*** bhavikdbavishi has joined #zuul07:52
*** bhavikdbavishi1 has joined #zuul07:55
*** bhavikdbavishi has quit IRC07:56
*** bhavikdbavishi1 is now known as bhavikdbavishi07:56
*** hamalq has joined #zuul07:56
*** rpittau|afk is now known as rpittau07:57
*** hamalq_ has joined #zuul07:57
*** jcapitao has joined #zuul08:00
*** hamalq has quit IRC08:01
*** evrardjp has quit IRC08:15
*** evrardjp has joined #zuul08:16
*** zbr has quit IRC08:23
*** zbr has joined #zuul08:23
*** zbr has quit IRC08:26
*** zbr has joined #zuul08:26
*** tosky has joined #zuul08:47
*** hashar has joined #zuul08:51
*** jpena|off is now known as jpena08:56
*** hamalq_ has quit IRC09:15
*** hamalq has joined #zuul09:15
*** bhavikdbavishi has quit IRC09:20
*** bhavikdbavishi has joined #zuul09:20
*** bhavikdbavishi1 has joined #zuul09:53
*** bhavikdbavishi has quit IRC09:56
*** bhavikdbavishi1 is now known as bhavikdbavishi09:56
*** bhavikdbavishi has quit IRC10:02
*** bhavikdbavishi has joined #zuul10:08
*** hamalq has quit IRC10:10
*** bhavikdbavishi1 has joined #zuul10:24
*** bhavikdbavishi has quit IRC10:26
*** bhavikdbavishi1 is now known as bhavikdbavishi10:26
*** bhavikdbavishi has joined #zuul10:27
*** wuchunyang has quit IRC10:30
*** bhavikdbavishi has quit IRC10:46
avasszbr: I'm starting to see teams using ansible-lint for their zuul jobs internally. So you might see more issues on github in the future :)11:08
zbravass: btw, I got full control over the project, it is to be moved to community at any moment.11:09
zbrbut i did not had much time to focus on it recently, it does require a lot of time to fix current issues and apparently raising bugs is cheap, but new PRs are not really common.11:10
zbrtripleo is using it in any repo, i am not afraid of lack of popularity, on the opposite...11:11
zbravass: if you are interested about testing ansible code in general, keep an eye on https://github.com/ansible-community/tox-ansible -- you may find it useful.11:12
zbrthe readme is outdated, i hope to update it over the weekend.11:13
*** ashbullock has joined #zuul11:18
avasszbr: sure I'll take a look. But we're currently just testing them by running them like zuul-jobs11:23
*** jcapitao is now known as jcapitao_lunch11:26
*** sshnaidm is now known as sshnaidm|off11:59
*** ashbullock has quit IRC12:05
*** bhavikdbavishi has joined #zuul12:07
*** bhavikdbavishi1 has joined #zuul12:09
*** bhavikdbavishi has quit IRC12:11
*** bhavikdbavishi1 is now known as bhavikdbavishi12:11
openstackgerritJonas Sticha proposed zuul/nodepool master: WIP: aws: add support for uploading diskimages  https://review.opendev.org/c/zuul/nodepool/+/73521712:20
*** jpena is now known as jpena|lunch12:38
*** jcapitao_lunch is now known as jcapitao12:45
*** bhavikdbavishi has quit IRC13:07
*** rlandy has joined #zuul13:07
*** bhavikdbavishi has joined #zuul13:08
*** fbo|off is now known as fbo13:18
*** bhavikdbavishi has quit IRC13:29
*** jpena|lunch is now known as jpena13:36
*** Goneri has joined #zuul14:05
openstackgerritJan Zerebecki proposed zuul/zuul-jobs master: Switch from Debian Stretch to Buster  https://review.opendev.org/c/zuul/zuul-jobs/+/76649614:21
avasslooks like we also got hit by: https://review.opendev.org/c/zuul/zuul/+/765990 and according the gitlab issues the timestamp format is not defined at all14:40
avasssigh..14:40
corvusavass: can you add a link to the gitlab issue as a comment?14:43
avasssure14:44
corvus(also i left a comment)14:45
avassor as I read it the timestamp is ISO 8601 but that can vary a lot14:46
avassThere's also a problem that the time format is different between the api and the webhooks. But I'm not sure if that affcets zuul14:50
avasscorvus: https://dateutil.readthedocs.io/en/stable/parser.html#dateutil.parser.isoparse looks like a good choice in that case14:51
openstackgerritAlbin Vass proposed zuul/zuul master: Fix errors regarding parsing timestamps  https://review.opendev.org/c/zuul/zuul/+/76599015:06
avassThat probably works a bit better. I'll see if I can set up a test environment and makes sure that works on monday15:08
avassIt's been extremely dark here lately. We've had 10h of sun since november and no sun at all in december.15:09
corvusavass: wow, i guess that explains the late-night patches :)15:13
avasscorvus: Oh no those are just my regular side project working hours :)15:14
openstackgerritVishal Manchanda proposed zuul/zuul-jobs master: [DNM] Testing horizon nodejs job with Chrome browser  https://review.opendev.org/c/zuul/zuul-jobs/+/76674415:14
*** jfoufas1 has joined #zuul15:15
*** rpittau is now known as rpittau|afk15:15
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Gerrit: add support for patchset level comments  https://review.opendev.org/c/zuul/zuul/+/76674815:20
guillaumeccorvus, ^15:21
corvusguillaumec: awesome thanks!15:22
corvusguillaumec: did you build a gerrit with https://gerrit-review.googlesource.com/c/gerrit/+/291225 to test that?15:22
openstackgerritGuillaume Chauvel proposed zuul/zuul master: use opendev-buildset-registry, build tutorial image one time  https://review.opendev.org/c/zuul/zuul/+/73300515:26
openstackgerritGuillaume Chauvel proposed zuul/zuul master: [DNM] tutorials: push dep image to buildset registry  https://review.opendev.org/c/zuul/zuul/+/76607615:26
openstackgerritGuillaume Chauvel proposed zuul/zuul master: [DNM] run tutorials using gerrit-3.3.0  https://review.opendev.org/c/zuul/zuul/+/76608615:26
openstackgerritGuillaume Chauvel proposed zuul/zuul master: [DNM] un tutorials using gerrit-3.3.0 patchset_level friendly  https://review.opendev.org/c/zuul/zuul/+/76674915:26
openstackgerritGuillaume Chauvel proposed zuul/zuul master: [DNM] un tutorials using gerrit-3.3.0 patchset_level  https://review.opendev.org/c/zuul/zuul/+/76675015:26
guillaumeccorvus, ^, didn't had to15:30
*** jfoufas1 has quit IRC15:31
corvusguillaumec: sorry, i'm not fully awake yet -- how did you get a gerrit with the patchset_level patch applied?15:33
guillaumecJenkins build output15:33
corvusguillaumec: ah, i see it now in 766749,  thx15:34
corvusguillaumec: 766748+2 :)15:35
corvuswe might wait until gerrit's 291144 lands, but i don't think there's a downside if we go ahead and merge that (even if 291144 changes and we have to correct, it won't be a big deal)15:36
openstackgerritJan Zerebecki proposed zuul/zuul-jobs master: Switch from Debian Stretch to Buster  https://review.opendev.org/c/zuul/zuul-jobs/+/76649615:41
openstackgerritJan Zerebecki proposed zuul/zuul-jobs master: Better error output for update-test-platforms.py  https://review.opendev.org/c/zuul/zuul-jobs/+/76675415:49
openstackgerritJan Zerebecki proposed zuul/zuul-jobs master: ensure-pip: install virtualenv, it is still used  https://review.opendev.org/c/zuul/zuul-jobs/+/76647715:54
openstackgerritJonas Sticha proposed zuul/nodepool master: WIP: aws: add support for uploading diskimages  https://review.opendev.org/c/zuul/nodepool/+/73521715:57
openstackgerritJonas Sticha proposed zuul/nodepool master: Replace call to deprecated Thread.isAlive  https://review.opendev.org/c/zuul/nodepool/+/76675715:57
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kubernetes with kind  https://review.opendev.org/c/zuul/zuul-jobs/+/74093515:59
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Update ensure-helm to default to latest version  https://review.opendev.org/c/zuul/zuul-jobs/+/76256415:59
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add helm role  https://review.opendev.org/c/zuul/zuul-jobs/+/76675815:59
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add functional helm test jobs using kind  https://review.opendev.org/c/zuul/zuul-jobs/+/76675915:59
avassIf everyone else is pushing their stacks of changes I guess I just have to join in :)16:00
*** zbr3 has joined #zuul16:00
*** zbr has quit IRC16:01
*** zbr3 is now known as zbr16:01
openstackgerritAlbin Vass proposed zuul/zuul master: Clarify when to use zuul_return to pause a job.  https://review.opendev.org/c/zuul/zuul/+/76676116:09
*** bhavikdbavishi has joined #zuul16:33
openstackgerritJames E. Blair proposed zuul/zuul master: Enable git protocol v2 in merger  https://review.opendev.org/c/zuul/zuul/+/76676516:50
corvusclarkb, fungi, ianw: ^ that should improve things, but will require wiping out the local cache of git repos on the mergers/executors.16:51
clarkbcorvus: any idea if that will break zuul + git installs where the git version is older?16:57
mordredcorvus: +2 with comments16:57
corvusclarkb: i'm assuming that would just be ignored, but let me check16:57
clarkbcorvus: cool, and ya if it is just ignored then I think that is a good approach as you won't need specific images or installation details16:58
clarkb(with the downside being clearing out the existing repos as you say, or maybe just manually updating their configs in place?)16:58
corvusclarkb: yeah, i think that's the main thing that warrant's mordred's suggested reno16:59
clarkb++17:00
corvusugh, my assumption was wrong; it barfs if you set that on 2.1717:01
corvusclarkb, mordred: i'm starting to lean toward not putting this in the zuul source code, and instead only doing it in the docker images (and otherwise, leave it up to deployment or the happenstance of git versions)17:03
*** hashar has quit IRC17:03
corvusso if you use the zuul container images, you'll get v2; otherwise you'll get it if you configure it yourself in your own deployment method, or run on a new enough system where it's default17:03
clarkbcorvus: that seems like a good initial approach. Maybe add a bit to the docs suggesting you can enable it if producing your own images17:04
clarkbcorvus: pretty sure other tools like github and gitlab also do v2 as well so you'd likely see benefits there too17:04
corvusclarkb: honestly, i don't think it's a big enough deal to document17:04
clarkbk17:05
corvuseveryone will get it eventually when everyone runs newer git17:05
mordredGROSS17:06
mordredhow common is 2.1717:06
mordred?17:06
*** bhavikdbavishi has quit IRC17:08
fungisurprisingly17:09
clarkbcentos 8 has 2.18.117:09
fungi2.17 is what ships in ubuntu 18.04 lts17:09
fungiunless you use backports17:10
avassxenial is 2.7 and it wouldn't surprise me if anyone is running that17:10
clarkbcorvus: that si a good point about how it will autmatically happen over time17:10
fungiactually ubuntu's bionic-backports doesn't even have newer git like debian's buster-backports does17:11
fungiand even buster was already 2.2017:11
avassmakes me a bit sad since I really want partial clones to become stable. but even if they do it's gonna take a while until zuul would be able to use it17:13
openstackgerritJames E. Blair proposed zuul/zuul master: Enable git protocol v2 in container images  https://review.opendev.org/c/zuul/zuul/+/76676517:18
corvusmordred, clarkb, fungi, avass: ^ maybe something like that?17:19
clarkbcorvus: ya that should work. you can also use git config --global protocol.version 217:20
clarkbassuming git is already installed at that point in the image17:20
clarkboh also if we don't bind mount that dir?17:20
corvusoh hrm17:20
corvusVOLUME /var/lib/zuul right below17:20
clarkb/var/lib/zuul:/var/lib/zuul17:21
clarkbya17:21
clarkbdoes git do a system level config?17:21
clarkbit does!17:21
clarkb/etc/gitconfig17:21
corvusi reckon that's the answer then17:21
clarkbwhich will be written using git config --system too17:21
corvusi like that, but i'm unsure if git is installed then17:22
corvusi think so; i think it's installed at RUN /output/install-from-bindep17:23
corvusso i'll try that17:23
openstackgerritJames E. Blair proposed zuul/zuul master: Enable git protocol v2 in container images  https://review.opendev.org/c/zuul/zuul/+/76676517:23
zbrdoes it makes sense to keep testing gear with py27+py35 only when we really use it in production (zuul) with py38 ?17:24
corvuszbr: gear is a general purpose library17:24
corvusit doesn't exist only for zuul or opendev, and targets an extremely wide range of python versions17:25
zbrthat is not tested with any supported version of python.17:25
zbrthe only jobs running on it is are py27 and py3517:25
fungiis the question why not also test gear with newer python?17:25
zbryeah17:25
corvusthen the answer to that question is: go for it!17:25
fungiagreed17:25
*** hamalq has joined #zuul17:27
avassoh I guess partial clones are already supported by github17:28
*** hamalq has quit IRC17:28
*** hamalq has joined #zuul17:29
avasscorvus: could be something to look into for the merger at a later point. since that could make it faster by only cloning zuul.yaml/zuul.d17:29
avassrequires at least git 2.19 though17:29
corvusavass: that could be useful, but the other thing the merger does is freeze the state of the repo so that every executor gets the same content17:30
corvusand for that it needs to at least know what all the refs are17:31
corvus(and what they point to)17:31
*** saneax has quit IRC17:32
avassah, but could that at least make the full-reconfig faster?17:32
corvusavass: yeah i think so17:33
corvusthe current approach is generally for the mergers/executors to maintain a full cached copy of every repo, and therefore updates should be small deltas.  the git protocol v2 will improve that for repos with lots of refs.17:36
*** jcapitao has quit IRC17:38
avassbut it still has to clone and checkout a workspace to read the config files doesnt it?17:38
avassif it's lightweight enough with a partial clone maybe a merger could have a number of workers to do that17:39
corvusavass: it doesn't need to clone, just do an incremental update; and it doesn't need to checkout for a full reconfig, it reads it from the git store directly.  proposed changes do end up in a workspace because they have to be merged.17:40
corvusavass: the executors do exactly that.  i don't think the standalone mergers do, but they could fairly easily.17:41
corvusthat == have a bunch of workers17:43
avassoh that makes sense17:45
*** jcapitao has joined #zuul17:45
*** tosky has quit IRC17:46
*** hashar has joined #zuul17:56
*** jcapitao has quit IRC17:58
*** jpena is now known as jpena|off18:00
openstackgerritJames E. Blair proposed zuul/zuul master: Squash some RUN layers in Dockerfile  https://review.opendev.org/c/zuul/zuul/+/76677218:11
corvustristanC: ^ a quick cleanup prompted by your comment18:11
tristanCcorvus: that looks good to me, this is what this run function does automatically: https://softwarefactory-project.io/cgit/software-factory/dhall-containerfile/tree/Containerfile/run.dhall18:26
*** ashbullock has joined #zuul18:27
ashbullockHey, if anyone has an interest in the bitbucketcloud driver https://review.opendev.org/c/zuul/zuul/+/759003  I was thinking it might be easier to have a quick call to go over it, just conscious it's quite a big change to review!18:30
ashbullockif anyone had a spare 30 minutes sometime next week I could go through it :D18:35
*** ashbullock has quit IRC18:44
corvusoh cool, didn't know that was ready :)18:51
*** ashbullock has joined #zuul18:51
*** hashar is now known as hasharDinner19:04
openstackgerritMerged zuul/zuul master: Enable git protocol v2 in container images  https://review.opendev.org/c/zuul/zuul/+/76676519:05
mordredcorvus: oops in your dockerfile followup19:22
corvusderp19:23
openstackgerritJames E. Blair proposed zuul/zuul master: Squash some RUN layers in Dockerfile  https://review.opendev.org/c/zuul/zuul/+/76677219:25
fungifungi@ze02:/etc/zuul-executor$ sudo docker-compose exec executor cat /etc/gitconfig19:32
fungi[protocol]19:32
fungi        version = 219:32
fungiyay!19:32
fungithough that was meant for #opendev, it's still a good yay for in here too19:33
mordredfungi: woot19:33
avasshuh you don't use the docker group19:35
avass?19:35
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Gerrit: add support for patchset level comments  https://review.opendev.org/c/zuul/zuul/+/76674819:42
*** ashbullock has quit IRC19:46
fungiavass: not to my knowledge, we have individual sysadmin accounts and sudo provides a convenient mechanism to log who ran which commands at what times19:55
SpamapSbtw, I hope this isn't too.. spammy.. but.. if any of you want to have fun with other FOSS-y folks.. https://k8s.dev/celebration is happening today19:55
fungiin case we're trying to piece together a timeline later for some reason19:55
avassfungi: ah alright that makes sense19:56
*** hasharDinner is now known as hashar20:19
*** rfolco has quit IRC21:05
*** tosky has joined #zuul21:05
*** rlandy has quit IRC21:05
corvusfungi: ze02 doesn't seem to have blown up; we're probably good for a complete restart of the mergers and executors?21:21
openstackgerritTatiana Ovchinnikova proposed zuul/zuul-jobs master: [DNM] Testing horizon nodejs job with Firefox  https://review.opendev.org/c/zuul/zuul-jobs/+/76679321:22
corvus(sorry wrong channel)21:28
*** josefwells has joined #zuul22:02
*** vishalmanchanda has quit IRC22:03
josefwellsHey zuulers, trying to bring up a some test containers, using the examples (but using github and my own static nodepool)  Most stuff working (and I did have this working several months ago). But nodepool-launcher isn't happy with my host-keys somehow22:10
josefwells2020-12-11 16:09:09,820 DEBUG nodepool.utils: Added ssh host key: ssh-ed2551922:11
josefwellsI've got - name: host.fqdn labels: ubuntu-18.04, and importantly host-key: ""ssh-ed25519 AAAA....."  as returned by "ssh-keyscan -t ed25519 host.fqdn"  (well, I don't add in the hostname)22:14
*** Goneri has quit IRC22:22
fungijosefwells: sorry i don't have a good answer, but can you also provide the error message you're seeing from the launcher?22:25
fungimaybe that'll help jog someone's memory22:25
josefwellsI see more in the logs for the executor:22:34
josefwellsparamiko.ssh_exception.SSHException: Incompatible ssh peer (no acceptable host key)22:34
josefwellsI do think I got some ansible logs eventually that initially pointed me to an ssh issue22:35
josefwellsbut I can't seem to find any now22:36
*** zenkuro has quit IRC22:44
fungioh, you said nodepool-launcher isn't happy with your host-keys, i assumed that meant you were seeing an error in its logs23:13
josefwellsyes, I'm looking at its logs from docker, but I don't have anything from an actual job-run23:13
josefwellsI'm going to try to bring up the node as described by the docker compose example23:14
*** hashar has quit IRC23:57

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!