| *** tosky has quit IRC | 00:20 | |
| *** wuchunyang has joined #zuul | 01:00 | |
| *** wuchunyang has quit IRC | 03:12 | |
| *** bhavikdbavishi has joined #zuul | 03:15 | |
| *** bhavikdbavishi1 has joined #zuul | 03:18 | |
| *** bhavikdbavishi has quit IRC | 03:20 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 03:20 | |
| *** bhavikdbavishi has quit IRC | 04:26 | |
| *** bhavikdbavishi has joined #zuul | 04:27 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #zuul | 05:33 | |
| *** bhavikdbavishi has quit IRC | 06:04 | |
| *** bhavikdbavishi has joined #zuul | 06:04 | |
| *** bhavikdbavishi1 has joined #zuul | 06:07 | |
| *** bhavikdbavishi has quit IRC | 06:08 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 06:08 | |
| *** vishalmanchanda has joined #zuul | 06:15 | |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Driver event ingestion https://review.opendev.org/c/zuul/zuul/+/717299 | 06:36 |
|---|---|---|
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Component Registry in ZooKeeper https://review.opendev.org/c/zuul/zuul/+/759187 | 06:37 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Move management and result events to model https://review.opendev.org/c/zuul/zuul/+/761163 | 06:37 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Allow (de-)serialization of management events https://review.opendev.org/c/zuul/zuul/+/761164 | 06:37 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Allow (de-)serialization of result events https://review.opendev.org/c/zuul/zuul/+/761165 | 06:37 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Add and fix fields in driver trigger event models https://review.opendev.org/c/zuul/zuul/+/761166 | 06:37 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Allow (de-)serialization of trigger events https://review.opendev.org/c/zuul/zuul/+/761167 | 06:37 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Interface to get a driver's trigger event class https://review.opendev.org/c/zuul/zuul/+/761168 | 06:37 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Clear list of Zookeeper connections after tests https://review.opendev.org/c/zuul/zuul/+/761169 | 06:37 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Increase default test wait timeout to 120s https://review.opendev.org/c/zuul/zuul/+/763754 | 06:37 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Implementation of Zookeeper backed event queues https://review.opendev.org/c/zuul/zuul/+/761170 | 06:37 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Implementation of Zookeeper event watcher https://review.opendev.org/c/zuul/zuul/+/761171 | 06:37 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Switch to Zookeeper backed trigger event queues https://review.opendev.org/c/zuul/zuul/+/761172 | 06:37 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Switch to Zookeeper backed management event queues https://review.opendev.org/c/zuul/zuul/+/761738 | 06:37 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Use logical timestamp to detect outdated changes https://review.opendev.org/c/zuul/zuul/+/763755 | 06:37 |
| *** saneax has joined #zuul | 06:37 | |
| *** ikhan has quit IRC | 06:52 | |
| *** mach1na has joined #zuul | 07:03 | |
| *** mach1na has quit IRC | 07:07 | |
| *** bhavikdbavishi has quit IRC | 07:10 | |
| *** jfoufas1 has joined #zuul | 07:18 | |
| *** mach1na has joined #zuul | 07:27 | |
| *** bhavikdbavishi has joined #zuul | 07:33 | |
| *** mach1na has quit IRC | 07:41 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Switch to using zookeeper instead of gearman for jobs https://review.opendev.org/c/zuul/zuul/+/762506 | 08:02 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: WIP Switch to ZooKeeper backed result event queues https://review.opendev.org/c/zuul/zuul/+/764344 | 08:02 |
| *** Phoenikzz has joined #zuul | 08:04 | |
| *** mach1na has joined #zuul | 08:06 | |
| *** jcapitao has joined #zuul | 08:06 | |
| Phoenikzz | tobiash: Regarding https://review.opendev.org/c/zuul/zuul-jobs/+/764062, I had the thought that "lets do this as a concept, if you need a file tree in your tests, this is how you do it". If that concept is not wanted, I have no problem with doing it for the problematic files only. Just a bit messier to pack the files together, but if "only the problematic files" are what's wanted, I'll fix that. | 08:09 |
| tobiash | Phoenikzz: I think having the files in fixture folders is the much simpler concept than having those in a json file so I'd prefer to stick to that generally. However I also see that it's generally desirable to have one common approach. | 08:16 |
| tobiash | Phoenikzz: what do you think about combining those two concepts in terms of stage the files from the fixture tree into a tmp dir and having the filenames urlencoded/decoded in that process if needed? | 08:17 |
| tobiash | then we would have the simple filesystem layout and still the option to have funky names as filenames | 08:17 |
| Phoenikzz | Good idea. I'll find the time to fix it that way. I was myself a bit concerned about the extra step of running the script whenever the file tree needed changes. | 08:19 |
| *** savihou has quit IRC | 08:23 | |
| *** fdegir has quit IRC | 08:34 | |
| *** fdegir has joined #zuul | 08:34 | |
| *** rpittau|afk is now known as rpittau | 08:46 | |
| *** hashar has joined #zuul | 09:02 | |
| *** wuchunyang has joined #zuul | 09:02 | |
| *** mgoddard has joined #zuul | 09:20 | |
| *** nils has joined #zuul | 09:33 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Fix zuul-client enqueue-ref when oldrev/newrev aren't provided https://review.opendev.org/c/zuul/zuul/+/765767 | 09:33 |
| *** mach1na has quit IRC | 09:53 | |
| *** mach1na has joined #zuul | 09:55 | |
| *** bhavikdbavishi has quit IRC | 10:05 | |
| *** bhavikdbavishi has joined #zuul | 10:06 | |
| openstackgerrit | Jonas Sticha proposed zuul/nodepool master: WIP: aws: add support for uploading diskimages https://review.opendev.org/c/zuul/nodepool/+/735217 | 10:08 |
| *** bhavikdbavishi has quit IRC | 10:16 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Fix zuul-client enqueue-ref when oldrev/newrev aren't provided https://review.opendev.org/c/zuul/zuul/+/765767 | 10:27 |
| *** mgoddard has quit IRC | 10:33 | |
| *** bhavikdbavishi has joined #zuul | 10:37 | |
| *** wuchunyang has quit IRC | 10:37 | |
| *** jcapitao has quit IRC | 10:39 | |
| *** bhavikdbavishi1 has joined #zuul | 10:40 | |
| *** bhavikdbavishi has quit IRC | 10:41 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 10:41 | |
| *** jcapitao has joined #zuul | 10:45 | |
| *** mgoddard has joined #zuul | 10:49 | |
| *** mgoddard has quit IRC | 10:52 | |
| *** mgoddard has joined #zuul | 10:53 | |
| openstackgerrit | Jonas Sticha proposed zuul/nodepool master: WIP: aws: add support for uploading diskimages https://review.opendev.org/c/zuul/nodepool/+/735217 | 10:55 |
| *** wuchunyang has joined #zuul | 11:02 | |
| *** wuchunyang has quit IRC | 11:06 | |
| *** tosky has joined #zuul | 11:22 | |
| *** bhavikdbavishi has quit IRC | 11:22 | |
| *** wuchunyang has joined #zuul | 11:29 | |
| *** wuchunyang has quit IRC | 11:29 | |
| *** kgz has quit IRC | 11:48 | |
| *** bhavikdbavishi has joined #zuul | 11:51 | |
| *** savihou has joined #zuul | 11:51 | |
| *** rfolco has joined #zuul | 11:54 | |
| *** bhavikdbavishi1 has joined #zuul | 11:54 | |
| *** kgz has joined #zuul | 11:54 | |
| *** bhavikdbavishi has quit IRC | 11:56 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 11:56 | |
| *** jcapitao is now known as jcapitao_lunch | 12:09 | |
| *** ikhan has joined #zuul | 12:17 | |
| *** mach1na has quit IRC | 12:39 | |
| *** hashar has quit IRC | 12:40 | |
| *** hashar has joined #zuul | 12:40 | |
| *** hashar has quit IRC | 12:42 | |
| *** mach1na has joined #zuul | 12:51 | |
| sshnaidm | cores, can we merge this? https://review.opendev.org/c/zuul/zuul/+/681277 | 12:54 |
| *** rlandy has joined #zuul | 13:00 | |
| *** mach1na has quit IRC | 13:02 | |
| *** hashar has joined #zuul | 13:05 | |
| *** saneax has quit IRC | 13:14 | |
| *** jcapitao_lunch is now known as jcapitao | 13:17 | |
| *** bhavikdbavishi has quit IRC | 13:22 | |
| *** bhavikdbavishi has joined #zuul | 13:23 | |
| tobiash | sshnaidm: see http://lists.zuul-ci.org/pipermail/zuul-discuss/2020-December/001416.html | 13:24 |
| sshnaidm | tobiash, great | 13:25 |
| tobiash | tldr it will be merged on friday if nobody objects | 13:25 |
| *** mach1na has joined #zuul | 13:31 | |
| *** bhavikdbavishi has quit IRC | 13:42 | |
| *** Goneri has joined #zuul | 13:48 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Fix zuul-client enqueue-ref when oldrev/newrev aren't provided https://review.opendev.org/c/zuul/zuul/+/765767 | 13:51 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Fix exception when using enqueue-ref (gitlab test) https://review.opendev.org/c/zuul/zuul/+/765809 | 13:51 |
| *** savihou has quit IRC | 14:00 | |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Enable installing nimble siblings https://review.opendev.org/c/zuul/zuul-jobs/+/765672 | 14:24 |
| avass | if anyone wants to do a round of reviews later the Zuul Cache role is ready: https://review.opendev.org/c/zuul/zuul-jobs/+/764808 :) | 14:25 |
| avass | are we okay with a simple role as https://review.opendev.org/c/zuul/zuul-jobs/+/749706 zbr says that it will be expanded to do more things later but at this stage it seems like it could be causing more problems that it's worth maintaining | 14:28 |
| zbr | avass: what are these problems? | 14:29 |
| avass | a future role would need to default to installing ansible with pip that way and support all of those parameters since it's just a wrapper around the pip module | 14:30 |
| zbr | avass: let me describe what i want to achieve in the end, maybe we can find alternatives ways to implement it | 14:31 |
| zbr | i want to enable zuul to build and test collections, that means make use of ansible-galaxy and ansiblet-test. the second one has some very pelicular requirements for testing. | 14:32 |
| avass | I'm not sure what the role currently enables | 14:34 |
| zbr | both of them are included with ansible, but especially for building collections we need to be sure we use ansible >=2.10, even if you may later want to test the installed collections with a different version. | 14:35 |
| zbr | at this moment i see it incomplete, as it does cover only for the "pip" install path. | 14:36 |
| avass | zbr: so something like 1) install ansible 2.10 2) build collection 3) install ansible <2.10 4) test? | 14:36 |
| zbr | also known as upstream (if we follow our terminology) | 14:36 |
| zbr | is bit more complex that this but the idea is right (probably we would want to use a special venv only for building collection), to avoid tainting other things. | 14:37 |
| zbr | i was considering proposing a collection_build and collection_install roles. | 14:38 |
| avass | I guess what the role does is make it easier to set variables on a higher scope | 14:39 |
| *** bhavikdbavishi has joined #zuul | 14:41 | |
| avass | I'm not convinced it needs to be a role at this stage, is it okay if we wait with that change until it covers a broader usecase? | 14:42 |
| zbr | avass: sure, that one can clearly wait. | 14:46 |
| zbr | i do find your worries as valid, at least in current form it does not have a strong bussiness case ;) | 14:46 |
| *** bhavikdbavishi has quit IRC | 15:04 | |
| *** bhavikdbavishi has joined #zuul | 15:06 | |
| *** bhavikdbavishi has quit IRC | 15:50 | |
| *** bhavikdbavishi has joined #zuul | 15:50 | |
| *** holser has joined #zuul | 16:21 | |
| openstackgerrit | Andy Ladjadj proposed zuul/zuul master: [web][config] move timezone component to preferences https://review.opendev.org/c/zuul/zuul/+/755929 | 16:26 |
| *** mach1na has quit IRC | 16:29 | |
| *** bhavikdbavishi has quit IRC | 16:29 | |
| *** bhavikdbavishi has joined #zuul | 16:37 | |
| *** bhavikdbavishi1 has joined #zuul | 16:42 | |
| *** bhavikdbavishi has quit IRC | 16:43 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 16:43 | |
| *** hashar has quit IRC | 16:53 | |
| *** rpittau is now known as rpittau|afk | 16:58 | |
| *** jcapitao has quit IRC | 17:49 | |
| *** zenkuro has joined #zuul | 18:15 | |
| zenkuro | hi, Im curious if success-url and failure-url(job properties) are working | 18:17 |
| clarkb | zenkuro: I believe the idea is to get away from those and rely on the build dashboard urls | 18:18 |
| clarkb | but I don't recall the specific reasons for that anymore | 18:18 |
| zenkuro | clarkb: I suspect that marketing is the core idea, since showing dashboard will advertise the project. | 18:19 |
| *** hamalq has joined #zuul | 18:19 | |
| zenkuro | clarkb: but have you guys kicked out this nice properties? | 18:19 |
| clarkb | I thought there was some technical limitation too though, but ya could be | 18:19 |
| clarkb | zenkuro: the other thing to check is that maybe the interpolation is failing beacuse the vars you're trying to map aren't properlyn amed? | 18:20 |
| zenkuro | I was using them, and now my CI is failing after update, with very strange error message related to reporting to gerrit | 18:21 |
| *** hamalq_ has joined #zuul | 18:21 | |
| clarkb | zenkuro: looking at zuul/zuul/model.py the success-url handling is still there (search for success_url and pattern) | 18:24 |
| clarkb | it hasn't been removed at least as far as I can tell. Not sure if there have been other changes that may affect it though | 18:24 |
| corvus | zenkuro: the report-build-dashboard tenant config option controls whether they are used | 18:24 |
| zenkuro | many thanks clarkb! | 18:24 |
| clarkb | corvus: aha | 18:24 |
| corvus | zenkuro: the reason is not marketing -- it's because if you direct-link to something other than the dashboard, there is no way for the user to get to the dashboard | 18:24 |
| corvus | zenkuro: so instead, we now suggest that you add interesting urls (like doc builds, previews, etc) as artifacts so they will show prominently on the build page. it is one extra click, but at least it makes everything accessible | 18:25 |
| *** hamalq has quit IRC | 18:25 | |
| fungi | a prime example is that in opendev we used to link to draft documentation builds for successful runs of docs jobs, but to the logs in the case of failures. it was fine most of the time, but if you wanted to see the logs of a successful run of some docs job that became a lot harder | 18:27 |
| zenkuro | hm... hm... Oh what if I create a job that do ssh -i secret-key some-third-party-ci@review.opendev.org "SUCCESS http://my-logs.com" and place it as a separate job that runs locally after main job end? | 18:32 |
| zenkuro | by locally I mean on CI itself | 18:33 |
| fungi | it would be slightly inefficient since an executor would need to handle that rather than the scheduler taking care of it automatically, but also it would result in you needing to maintain two separate copies of your ssh credentials for that account | 18:35 |
| zenkuro | fungi: yes, but it should work. Because I can't imagine any better approach. | 18:37 |
| fungi | zenkuro: why is that better than unsetting report-build-dashboard and using success-url et cetera? | 18:38 |
| fungi | i'm going to assume the reason you don't want to report the build dashboard is that your zuul-web service can't be exposed for some reason | 18:39 |
| zenkuro | fungi: I will have to expose CI that have access to local network, while currently I expose some VPS with logs | 18:39 |
| fungi | zenkuro: you shouldn't have to expose anything if you use success-url and failure-url instead of report-build-dashboard | 18:40 |
| fungi | (well, shouldn't have to expose anything other than what you provide success/failure links for) | 18:40 |
| corvus | zenkuro: ah, more context helps. you didn't mention this was for 3rd-party ci behind a firewall. i agree that in that case unsetting report-build-dashboard makes sense. that will use the old behavior of just reporting the log url. you don't have to use success-url or failure-url unless you want something other than the log url. | 18:43 |
| corvus | zenkuro: https://zuul-ci.org/docs/zuul/reference/tenants.html#attr-tenant.report-build-page | 18:44 |
| corvus | zenkuro: it's likely we will set that default to true in or around the v4.0 release, so if that's what you want, you should probably explicitly set it to false now. however, we haven't changed that recently, so if something you had stopped working, i don't know what would have caused it. | 18:45 |
| *** bhavikdbavishi has quit IRC | 18:45 | |
| zenkuro | fungi: you are correct. | 18:46 |
| zenkuro | corvus: thanks for clarification, I will check report-build-page | 18:46 |
| *** bhavikdbavishi has joined #zuul | 18:47 | |
| *** bhavikdbavishi has quit IRC | 18:51 | |
| *** jfoufas1 has quit IRC | 19:09 | |
| *** imtiazc has joined #zuul | 19:10 | |
| zenkuro | corvus: thanks again for pointing out report-build-page. it was set to true in one place and false in the other! | 19:10 |
| *** imtiazc has quit IRC | 19:12 | |
| corvus | zenkuro: great, it's always nice to be able to explain confusion :) | 19:15 |
| *** hashar has joined #zuul | 19:25 | |
| avass | there's no way to check if the a build is in a pre-review pipeline or not right? it's only possible to check the name of the current pipeline? | 20:16 |
| clarkb | avass: zuul knows internally but ya I don't know if that info is shared with the job contexts | 20:17 |
| avass | was thinking of checking that in Zuul cache and add zuul.build to the path for the artifact if it was running in a pre-review context | 20:18 |
| avass | that way zuul-cache could still be used in pre-review to share artifacts between jobs with zuul_return | 20:18 |
| fungi | why not just do that always? | 20:31 |
| avass | fungi: so it can work as a cache for dependencies as well :) | 20:32 |
| fungi | couldn't it do the same in some post-review pipelines too though? | 20:32 |
| fungi | why limit it to pre-review? | 20:32 |
| avass | oh it's so you don't need to rebuild external dependencies. the idea came from when I had to build the nim compiler from source on alpine | 20:33 |
| avass | so that would be part of ensure-nimble | 20:34 |
| avass | if that's already been done for a specific version you could check if it's cached for every build and not need to rebuild it | 20:34 |
| avass | but that would be a problem if a pre-review pipeline could modify that artifact | 20:34 |
| clarkb | tristanC: can you take a look at https://storyboard.openstack.org/#!/story/2008427 which is nodepool having trouble with pip's new dep solver due to openshift and urllib incompatibilities | 20:35 |
| clarkb | tristanC: I think I've managed to track down the problem but I don't have the background to understand what updating the openshift dep to 0.11.2 is likely to entail | 20:35 |
| fungi | avass: not all post-review artifacts are guaranteed final either though | 20:35 |
| fungi | avass: consider the use case where jobs are run for a change after a trusted reviewer has acknowledged it, but not approved it | 20:36 |
| avass | so a pre-review pipeline should only be able to pass artifacts between jobs with zuul-cache while a post-review should be able to cache external dependencies so they won't need to be rebuilit | 20:36 |
| avass | what do you mean with acknowledged but not approved? | 20:37 |
| fungi | avass: oh got it, so the ccache example would be that builds within the same buildset could take advantage of cached object files, but only once changes are run in a post-review context can they add objects to a global ccache? | 20:38 |
| avass | yeah like that | 20:38 |
| avass | or with depends-on it could also work cross changes | 20:38 |
| avass | since it would fetch it with zuul.artifacts | 20:38 |
| fungi | avass: hard to put into context without knowing your workflow, but for example let's say relative to the gerrit workflow followed for the zuul tenant in opendev... we've got a check pipeline which is pre-review running on any uploaded change and a gate pipeline which is post-review running when any change is approved to merge, but we could also have something along the lines of a "reviewed" pipeline which runs | 20:40 |
| fungi | after a zuul maintainer adds their +2 vote to an unapproved change | 20:40 |
| avass | would there be a problem with that? | 20:41 |
| avass | since in that case it has been reviewed | 20:41 |
| fungi | nope, it's a relevant use case, i was just trying to understand how that fit with your use of post-review in caching. you're saying any builds run in the context of that "reviewed" pipeline should also be able to update the global cache, and yeah that sounds reasonable | 20:42 |
| corvus | indeed, we've contemplated similar "post-review, pre-merge" pipelines before. eg: run tests against a production service (like a cloud) if a core reviewer okay's the change | 20:43 |
| avass | yeah. and the names are configurable so if needed they could do things like <artifact>-<zuul.pipeline> if the caches should be separate per pipeline | 20:43 |
| corvus | avass: adding a post-review zuul inventory var should be trivial | 20:43 |
| corvus | the only thing is i'm sad we didn't do "zuul.pipeline.name" instead of "zuul.pipeline" :( | 20:43 |
| avass | fungi: if you got time over and you're interested in the current implementation the change is ready for review: https://review.opendev.org/c/zuul/zuul-jobs/+/764808 :) | 20:44 |
| corvus | we could switch that the same way we did zuul.project: make zuul._pipeline a dict, then deprecate zuul.pipeline, make it a copy, then drop zuul._pipeline | 20:45 |
| avass | corvus: maybe a good time to do that with 4.0 :) | 20:46 |
| openstackgerrit | Clark Boylan proposed zuul/nodepool master: Bump openshift dep https://review.opendev.org/c/zuul/nodepool/+/765873 | 20:46 |
| clarkb | tristanC: ^ thats a naive change pushed up to try and gather more data on what breaks | 20:47 |
| avass | corvus: though technically, isn't it the job that is post-review or not? https://zuul-ci.org/docs/zuul/reference/job_def.html#attr-job.post-review | 20:48 |
| avass | oh I might have read that wrong | 20:49 |
| corvus | nah its https://zuul-ci.org/docs/zuul/reference/pipeline_def.html#attr-pipeline.post-review | 20:49 |
| corvus | job attr just prevents job from running | 20:49 |
| tristanC | clarkb: thanks, updating shouldn't be an issue, for example ansible kubernetes collection is using `>=0.6.2` | 21:05 |
| *** hashar has quit IRC | 21:15 | |
| clarkb | tristanC: git history shows we capped beacuse 0.9.0 broke things | 21:23 |
| clarkb | that change should tell us if 0.11.2 is in the same situation and if so I can try and look into fixing it, though this portion of the code is less familiar to me | 21:24 |
| clarkb | tristanC: ya looks like openshift.config doesn't exist anymore at least | 21:25 |
| clarkb | I think I see what that was converted to. I'll whittle away at this for a bit and see if I can make any progress | 21:28 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul-operator master: Add zuul-ensure-own-config role https://review.opendev.org/c/zuul/zuul-operator/+/765882 | 21:40 |
| *** msuszko has joined #zuul | 21:42 | |
| *** sshnaidm has quit IRC | 21:49 | |
| *** zenkuro has quit IRC | 21:51 | |
| clarkb | tristanC: this is quickly getting out of my depth it seems that we need to create a dynamic openshift client and using that we then have to explicitly call .get or .post etc on various resources to do those operations. I'll try to continue to fumble my may through this in hopes someone can clean it up but it isn't the most straightforward thing | 21:51 |
| tristanC | clarkb: could this work in place https://github.com/ansible-collections/community.kubernetes/blob/2474ef1b2ca5640cd1ff040ebb2b562457049608/plugins/module_utils/common.py#L252 ? | 21:55 |
| clarkb | tristanC: yes, but openshift's api too ahs completely changed | 21:57 |
| clarkb | they really seemed to have rewritten the entire api around 0.9.0 | 21:57 |
| clarkb | I'll get an incomplete update up so you can see what I mean | 21:57 |
| clarkb | currently trying to udnerstand what the difference between a ProjectRequest and a Project is | 22:01 |
| *** mordred has quit IRC | 22:02 | |
| *** odyssey4me has quit IRC | 22:02 | |
| *** johnsom has quit IRC | 22:02 | |
| tristanC | clarkb: i'd say we don't want ProjectRequest | 22:02 |
| *** jhesketh has quit IRC | 22:06 | |
| clarkb | tristanC: the current drivers seem to use it to createa project but there is a separate project creation request api too | 22:07 |
| *** jhesketh has joined #zuul | 22:08 | |
| *** sshnaidm has joined #zuul | 22:08 | |
| openstackgerrit | Clark Boylan proposed zuul/nodepool master: Bump openshift dep https://review.opendev.org/c/zuul/nodepool/+/765873 | 22:09 |
| clarkb | tristanC: see ^ nodepool/driver/openshift/provider.py in particular | 22:09 |
| clarkb | I'm not sure I'm a fan of this new api they provide | 22:09 |
| clarkb | the old one generated from the swagger was a lot more direct | 22:09 |
| clarkb | also you could read the swagger and figure out the api | 22:10 |
| clarkb | but now it requires much better understanding of the underlying datastructures | 22:10 |
| *** fdegir has quit IRC | 22:14 | |
| *** tobberydberg has quit IRC | 22:14 | |
| *** fdegir has joined #zuul | 22:15 | |
| *** tobberydberg has joined #zuul | 22:19 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul-operator master: Add zuul-ensure-own-config role https://review.opendev.org/c/zuul/zuul-operator/+/765882 | 22:21 |
| openstackgerrit | Andy Ladjadj proposed zuul/zuul master: [web][config] move timezone component to preferences https://review.opendev.org/c/zuul/zuul/+/755929 | 22:23 |
| tristanC | clarkb: oh we do use project request, i see in the api doc that this is correct (`end users should use the requestproject resource.`) | 22:26 |
| clarkb | tristanC: I see is that difference between admin and normal user then? | 22:26 |
| *** bolg has quit IRC | 22:30 | |
| *** johnsom has joined #zuul | 22:30 | |
| *** odyssey4me has joined #zuul | 22:30 | |
| *** mordred has joined #zuul | 22:30 | |
| clarkb | https://groups.google.com/g/repo-discuss/c/A4AhqursMYo/m/riTwt6COBwAJ Gerrit 3.3.0 will break zuul | 22:34 |
| clarkb | or at least some bits of zuul? we need to listen to new types of events looks like | 22:34 |
| *** rfolco has quit IRC | 22:34 | |
| clarkb | fungi: ianw ^ fyi we shoudl ensure that zuul is updated before we upgrade to 3.3.0 I guess | 22:34 |
| ianw | indeed | 22:40 |
| clarkb | tristanC: also looks like we need to update all the fakes in testing :/ | 22:43 |
| *** rfolco has joined #zuul | 22:43 | |
| clarkb | is it bad that I wonder if forking 0.8 and using the swagger generation would be less work | 22:43 |
| clarkb | (I don't seriously think we should do that) | 22:44 |
| *** rfolco has quit IRC | 22:48 | |
| openstackgerrit | Andy Ladjadj proposed zuul/zuul master: [web][config] move timezone component to preferences https://review.opendev.org/c/zuul/zuul/+/755929 | 23:05 |
| clarkb | tristanC: it does look like the changes I have made work with kubernetes functioanlly though, which makes esnse as it is a bit less tied to the openshift client | 23:11 |
| *** vishalmanchanda has quit IRC | 23:24 | |
| openstackgerrit | Clark Boylan proposed zuul/nodepool master: Bump openshift dep https://review.opendev.org/c/zuul/nodepool/+/765873 | 23:28 |
| clarkb | that latest ps makes some of the testing happier but I'm not sure that it is making tests happier correctly if that makes sense. We have fakes that we use that aren't lining up with at least the new openshift library client | 23:30 |
| clarkb | (on the k8s side we may be fine though) | 23:30 |
| *** nils has quit IRC | 23:33 | |
| clarkb | ya now we are running into problems with the fakes | 23:39 |
| *** ikhan has quit IRC | 23:43 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!