Tuesday, 2020-11-24

*** wuchunyang has joined #zuul00:01
*** wuchunyang has quit IRC00:05
*** rfolco|ruck has quit IRC00:07
*** tosky has quit IRC00:17
*** Goneri has quit IRC00:37
*** wuchunyang has joined #zuul00:57
*** openstackgerrit has joined #zuul01:01
openstackgerritIan Wienand proposed zuul/nodepool master: Bump diskimage-builder requirement to 3.4.0  https://review.opendev.org/c/zuul/nodepool/+/76389401:01
openstackgerritJeremy Stanley proposed zuul/zuul-jobs master: Pin keystoneauth1 and cachetools on older Python  https://review.opendev.org/c/zuul/zuul-jobs/+/76386601:29
openstackgerritJeremy Stanley proposed zuul/zuul-jobs master: Use Python 3.x with launchpadlib  https://review.opendev.org/c/zuul/zuul-jobs/+/76383401:29
fungihttps://review.opendev.org/763866 now fixes the py27 unit test jobs which 763834 was previously failing01:54
*** holser has quit IRC02:05
*** iurygregory has quit IRC02:25
*** bhavikdbavishi has joined #zuul02:57
*** bhavikdbavishi1 has joined #zuul03:04
*** bhavikdbavishi has quit IRC03:06
*** bhavikdbavishi1 is now known as bhavikdbavishi03:06
openstackgerritIan Wienand proposed zuul/nodepool master: Bump diskimage-builder requirement to 3.4.0  https://review.opendev.org/c/zuul/nodepool/+/76389403:31
openstackgerritIan Wienand proposed zuul/nodepool master: nodepool-functional-k8s: don't run on Xenial  https://review.opendev.org/c/zuul/nodepool/+/76392103:31
*** wuchunyang has quit IRC04:04
*** bhavikdbavishi has quit IRC04:33
*** bhavikdbavishi has joined #zuul04:33
*** sanjayu_ has joined #zuul04:38
*** saneax has quit IRC04:38
*** y2kenny has quit IRC04:55
*** evrardjp has quit IRC05:33
*** evrardjp has joined #zuul05:33
ianwfungi: ^ that's somewhat related to related to your change to pin keystoneauth.  the dib bump is a follow-on requirement to get centos building again06:01
*** bhavikdbavishi1 has joined #zuul06:28
*** bhavikdbavishi has quit IRC06:30
*** bhavikdbavishi1 is now known as bhavikdbavishi06:30
*** Phoenikzz has quit IRC06:33
*** Phoenikzz has joined #zuul06:35
*** Phoenikzz has quit IRC06:36
*** Phoenikzz has joined #zuul06:36
*** Phoenikzz has quit IRC06:43
*** Phoenikzz has joined #zuul06:43
*** Phoenikzz has quit IRC06:49
*** Phoenikzz has joined #zuul06:50
*** Phoenikzz has joined #zuul06:51
*** bhavikdbavishi has quit IRC06:59
*** iurygregory has joined #zuul07:02
*** mach1na has joined #zuul07:11
*** Phoenikzz has quit IRC07:13
*** Phoenikzz has joined #zuul07:14
openstackgerritSimon Westphahl proposed zuul/zuul master: Use logical timestamp to detect outdated changes  https://review.opendev.org/c/zuul/zuul/+/76375507:27
*** mach1na has quit IRC07:30
*** rpittau|afk is now known as rpittau07:39
*** bhavikdbavishi has joined #zuul07:42
*** bhavikdbavishi1 has joined #zuul07:45
*** bhavikdbavishi has quit IRC07:46
*** bhavikdbavishi1 is now known as bhavikdbavishi07:46
*** zenkuro has quit IRC08:06
*** zenkuro has joined #zuul08:06
*** jcapitao has joined #zuul08:09
*** jpena|off is now known as jpena08:12
*** mach1na has joined #zuul08:15
*** tosky has joined #zuul08:48
*** zenkuro has quit IRC08:57
*** zenkuro has joined #zuul08:57
openstackgerritSorin Sbârnea proposed zuul/zuul-jobs master: Add ensure-ansible role  https://review.opendev.org/c/zuul/zuul-jobs/+/74970609:04
*** iurygregory has quit IRC09:37
*** iurygregory has joined #zuul09:43
*** piotrowskim has joined #zuul09:54
*** holser has joined #zuul10:02
*** CraigR has joined #zuul10:03
*** mach1na has quit IRC10:06
*** bhavikdbavishi has quit IRC10:06
zbrwhich zuul-maint can help me ditch the tox-py27 from zuul-jobs?10:09
*** nils has joined #zuul10:21
zbravass: https://review.opendev.org/c/zuul/zuul-jobs/+/749706 -- no brainer: ensure-ansible role. thanks10:32
*** wuchunyang has joined #zuul10:43
avassDo we need a role for that?10:49
avassall it does is run the pip module10:50
avasszbr: I think the tox-py27 is supposed to be kept10:51
zbravass: yes we need as we will want to add extra features to it, also this is a building block for testing ansible collections, with various ansible versions.10:53
zbravass: i agree with you that by itself it may look weird, but only because is not a goal by itself.10:53
avassSo why not add it when it does more?10:54
zbravass: sagi started working on this 3 months ago, see https://review.opendev.org/c/zuul/zuul-jobs/+/730360 -- i asked him to to the split.10:55
zbrthere are a bunch of ansible related roles that depend on it. build/install/publish.10:56
zbri personally hope that soon we will be able to publish zuul-jobs as a collection10:56
avassdoesn't the role names cause problems with ansible collections?10:57
*** wuchunyang has quit IRC10:57
zbryes it does but only for publish, and there are workarounds that can be taken even for this.10:58
avassI mean, the ansible-collection roles makes more sense to me but the ensure-ansible only runs the pip module, so why create a role for that.10:58
avassit's just having a role as a wrapper for a module so why not put the pip module directly in the pre-run?10:59
*** sanjayu_ has quit IRC10:59
zbrwe will likely add ability to install ansible from distro packages after that, "pip" is not the only way to install it.10:59
*** sanjayu_ has joined #zuul10:59
zbrlike we have with ensure-docker for example.11:00
zbrwe also have to specify which ansible we want: the base or the full-blown,...11:00
avassso why not add that role when it does more than just the pip module, when it makes sense to have it as a role.11:01
zbradd a comment to the review asking for this.11:01
zbri guess for main distros this can be quite easy to implement, and for others it can use the pip as fallback, i guess.11:02
zbrthe only downside is that IMHO, when installing from distro, you likely lose the option to pick the version.11:02
avassI think I did, but maybe it got lost since the changes was split up11:02
zbrsshnaidm: ^ how hard it would be add ability to install ansible from distro in addition to pip for ensure-ansible?11:05
sshnaidmshould be easy11:05
zbrin fact it would be cool to add a "system" option to ensure_ansible_version argument.11:06
zbrwhen system is mentioned, the role will install ansible using package instead of pip, for platforms supporting it, for others will keep using pip.11:07
zbrthis will make this role very useful for testing other ansible related issues, as ansible version may vary across platforms.11:07
sshnaidmavass, the problem is in ansible versions, with pip you can install whatever you need, with package - only those provided by distro11:12
sshnaidmwhen ansible move fast and change its names every week, it might be very useful to have this choice11:12
*** bhavikdbavishi has joined #zuul11:12
*** bhavikdbavishi1 has joined #zuul11:15
*** bhavikdbavishi has quit IRC11:16
*** bhavikdbavishi1 is now known as bhavikdbavishi11:16
avasssshnaidm: yeah sure, I don't have anything against that. But I don't think it makes sense to create a role that only wraps a module11:24
sshnaidmavass, I've been looking at all ensure-* that we have11:25
sshnaidmthought it will be logical to have the same for ansible, because of PIPs multiple config options that not a lot of users are familiar with11:26
zbrsshnaidm: if i understood correctly the only remark avass had was that unless ensure-ansible also allows user to mention that he wants system ansible, the use case for having a different role is weak, as it can be replaced by a single ansible task.11:40
zbrbased on this approach we could easily endup with ensure-<any-cli-from-pypa> role.11:41
avasszbr: yes :)11:41
zbrbut I do happen to know that ansible is different beast, well cow.11:41
zbrafaik no distro allows user to specify version of ansible they ship, it means that we can have another special value for version, in addition to latest, one named "system".11:42
zbrwhen system is mentioned, the role would using  system packager to install it instead of pip.11:43
zbrimho this would really make the role useful for many usecases.11:43
*** bhavikdbavishi has quit IRC11:43
*** bhavikdbavishi has joined #zuul11:44
*** CraigR has quit IRC11:55
*** hashar has joined #zuul12:00
*** rfolco|ruck has joined #zuul12:11
*** jcapitao is now known as jcapitao_lunch12:12
*** wuchunyang has joined #zuul12:19
*** wuchunyang has quit IRC12:19
*** wuchunyang has joined #zuul12:21
*** wuchunyang has quit IRC12:26
tristanCzbr: why would you want to remove tox-py27?12:26
*** nils has quit IRC12:32
*** jpena is now known as jpena|lunch12:34
*** rlandy has joined #zuul12:41
*** mach1na has joined #zuul12:55
*** bhavikdbavishi has quit IRC13:02
*** jcapitao_lunch is now known as jcapitao13:09
zbrtristanC: ignore it, i wanted to say from gerrit* related project not zuul (gerritlib)13:11
*** nils has joined #zuul13:12
*** jpena|lunch is now known as jpena13:31
*** Goneri has joined #zuul13:36
*** bhavikdbavishi has joined #zuul14:15
*** bhavikdbavishi1 has joined #zuul14:18
*** bhavikdbavishi has quit IRC14:20
*** bhavikdbavishi1 is now known as bhavikdbavishi14:20
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kubernetes with kind  https://review.opendev.org/c/zuul/zuul-jobs/+/74093514:22
fungianyone else interested in getting the zuul-jobs py27 job passing again? https://review.opendev.org/76386614:25
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add option to install kubernetes with kind  https://review.opendev.org/c/zuul/zuul-jobs/+/74093514:25
fungiianw: if you're still around, ttx commented on 763834 pointing out why it's not a problem (script explicitly invokes python3 anyway)14:27
fungitrying to finish transitioning those release jobs to python3, so if we do run into more corner cases where python 2.7 is being called we'll fix them anyway14:28
avassfungi: ++14:32
fungiit's a bit of a game of whack-a-mole because those jobs only run in post-merge pipelines and interact with external resources (e.g. launchpad bugs in that particular case)14:36
*** gouthamr_ has quit IRC14:36
openstackgerritMerged zuul/zuul-jobs master: Pin keystoneauth1 and cachetools on older Python  https://review.opendev.org/c/zuul/zuul-jobs/+/76386614:57
zbrfungi: https://review.opendev.org/c/zuul/zuul-jobs/+/735923 part of py3 migration, slipped.15:06
zbrdo we need to send emails about these? anything related to py2 seems very unstable these days.15:06
*** mach1na has quit IRC15:27
fungiit's worth discussing whether a blanket announcement that we're going to start changing any python defaults to python3 in coming weeks is sufficient15:30
fungii still feel like giving people a heads up is useful, but i agree it's likely noise to do a separate announcement for every single case given there are likely to be at least a few15:31
zbrgo for it! i have no authority to send such announcement :D15:33
avassI agree, a single announcement with clear intention that the jobs will default to python3 should be enough.15:33
openstackgerritPaul Belanger proposed zuul/zuul-jobs master: DNM - testing registry jobs  https://review.opendev.org/c/zuul/zuul-jobs/+/76400616:09
*** hashar is now known as hasharAway16:11
pabelangermnaser: just confirming, on your lgtm pipeline, you have post-review: true set?16:27
pabelangerthis has got me thinking, I wonder if we can limit secrets to specific pipelines16:27
mnaserpabelanger: I don’t but this job is defined and lives in a config project with final: true16:28
pabelangermnaser: okay, that is what I was thinking16:29
openstackgerritTobias Henkel proposed zuul/nodepool master: Check for images to upload single threaded  https://review.opendev.org/c/zuul/nodepool/+/74379016:29
pabelangerI think our zuul-jobs-test-registry-* jobs are broken16:34
pabelangerit is complaining about an expired SSL cert16:34
pabelangerhttps://c5696350317ad68c03d1-7c6e098ee109e2cfc4ca8fa68868cc2d.ssl.cf5.rackcdn.com/764006/1/check/zuul-jobs-test-registry-podman/22905db/job-output.txt16:34
pabelangerx509: certificate has expired or is not yet valid16:35
openstackgerritPaul Belanger proposed zuul/zuul-jobs master: Refresh intermediate TLS certs for testing  https://review.opendev.org/c/zuul/zuul-jobs/+/76402316:40
avassoh, uh, why don't we generate that in the job?16:41
pabelangernot sure, legacy reasons?16:41
avasscould be16:41
openstackgerritPaul Belanger proposed zuul/zuul-jobs master: Switch to container_images for push-to-intermediate-registry  https://review.opendev.org/c/zuul/zuul-jobs/+/76383616:42
fungimaybe somebody set the cert expiration as a reminder to look into generating it in the job later ;)16:42
pabelangerif it unblocks my testing, I can convert it to be more dynamic16:42
-openstackstatus- NOTICE: The Gerrit service on review.opendev.org is being restarted quickly to troubleshoot an SMTP queuing backlog, downtime should be less than 5 minutes16:43
avasscorvus doesn't seem to have left an explanation: https://review.opendev.org/c/zuul/zuul-jobs/+/66132716:45
avassmaybe he just didn't think about generating it and caching it16:45
*** hasharAway is now known as hashar16:46
avassor maybe caching facts wasn't available in 2019 :)16:46
*** timburke has quit IRC17:00
*** rpittau is now known as rpittau|afk17:01
*** jpena is now known as jpena|off17:02
*** rlandy is now known as rlandy|biab17:11
pabelangermnaser: neat! https://github.com/ansible-network/sandbox/pull/60#issuecomment-73312037317:19
pabelangermnaser: I forked locally and hacked in config file support, over env17:29
pabelangermnaser: okay, I think I understand lgtm role now. Great work, I totally think we can start to add new features like having bot leave 'review comment' and even label changes.17:44
pabelangerbut I won't work on that right now17:44
*** iurygregory has quit IRC17:59
openstackgerritTobias Henkel proposed zuul/nodepool master: Check for images to upload single threaded  https://review.opendev.org/c/zuul/nodepool/+/74379018:08
*** sanjayu_ has quit IRC18:13
*** iurygregory has joined #zuul18:27
*** jcapitao has quit IRC18:38
fungiianw: when you're around again, can you see if the followup comments on 763834 are satisfactory? i'm waiting for that to land to retry broken openstack release jobs18:49
*** nils has quit IRC18:53
*** rlandy|biab is now known as rlandy18:58
ianwfungi: hrm, ok, so it's already called by /usr/bin/python3 <script> directly -- and it was working, which must mean that launchpadlib is actually already installed for python3 some other way?19:03
*** bhavikdbavishi has quit IRC19:04
fungiianw: yeah, i expect so. we may wind up having to deduplicate it elsewhere in the consuming job later19:04
fungiit's unfortunately a big mess of shell scripts dating back to the jenkins job days so tough to follow in some places19:04
ianwfungi: ok, approved it; at least if there's version conflicts or something we have a place to start19:12
fungithanks! and yep, we're slowly iterating on retrying it to get it working on focal (so that the distro package of git-review will work with opendev's new gerrit)19:15
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Update tests/base.py to use proper git data  https://review.opendev.org/c/zuul/zuul/+/74274619:16
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Fix gerrit merge commit change with zuul configuration  https://review.opendev.org/c/zuul/zuul/+/76288619:16
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Fix gerrit amended merge commit change with zuul configuration  https://review.opendev.org/c/zuul/zuul/+/76288719:16
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Add tests  https://review.opendev.org/c/zuul/zuul/+/74274719:16
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Reorg scheduler event process loop  https://review.opendev.org/c/zuul/zuul/+/74274819:16
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Scheduler ref-updated create/delete  https://review.opendev.org/c/zuul/zuul/+/73919819:16
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Allow ref-updated newrev+oldrev reconfiguration  https://review.opendev.org/c/zuul/zuul/+/74274919:16
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Get ref-updated modified files  https://review.opendev.org/c/zuul/zuul/+/73907819:16
openstackgerritMerged zuul/zuul-jobs master: Use Python 3.x with launchpadlib  https://review.opendev.org/c/zuul/zuul-jobs/+/76383419:23
*** zenkuro has quit IRC20:03
*** y2kenny has joined #zuul20:16
*** hamalq has joined #zuul20:16
y2kennyquick question about yaml formatting.  For job definition Is there a difference between saying20:18
y2kennypre-run: <path>20:18
y2kennyvs20:18
y2kennypre-run:20:18
y2kenny - <path>20:18
y2kenny?20:18
tobiashy2kenny: no20:19
tristanCy2kenny: iirc that attribute is converted as_list20:19
y2kennyI ran into a situation where the parent pre-run didn't get executed20:19
y2kennyan I am wondering if one get replaced20:19
tobiashit's just syntactic sugar that you don't have to specify a list20:19
y2kennyand*20:19
y2kennyso all the pre-run playbooks should get executed right?  Only run playbook would be replaced by the child?20:20
tobiashyes20:20
fungiy2correct20:20
y2kennyok thanks20:21
fungilooks like i somehow missed my tab key20:22
*** wuchunyang has joined #zuul20:25
*** wuchunyang has quit IRC20:29
openstackgerritPaul Belanger proposed zuul/zuul-jobs master: Switch to container_images for push-to-intermediate-registry  https://review.opendev.org/c/zuul/zuul-jobs/+/76383620:44
openstackgerritDaniel Blixt proposed zuul/zuul-jobs master: Use script to populate test file tree fixtures  https://review.opendev.org/c/zuul/zuul-jobs/+/76406220:48
*** hamalq has quit IRC20:55
*** hashar has quit IRC20:59
*** hamalq has joined #zuul21:10
*** hamalq has quit IRC21:15
openstackgerritIan Wienand proposed zuul/zuul master: gerrit: restore change filter when querying  https://review.opendev.org/c/zuul/zuul/+/76406921:30
*** rfolco|ruck has quit IRC21:32
*** Goneri has quit IRC22:08
openstackgerritPaul Belanger proposed zuul/zuul-jobs master: Switch to container_images for push-to-intermediate-registry  https://review.opendev.org/c/zuul/zuul-jobs/+/76383622:14
*** ikhan has joined #zuul22:18
y2kennyabout the pause job (zuul_return, pause= true), the parent child relationship is between dependent job and not the other parent child relationship of pre and post run, is the correct?22:52
y2kenny(btw, how do you folks separate the two parent-child relationships usually?  is there a formal name for each of the relationship?)22:52
*** rfolco|ruck has joined #zuul22:57
clarkby2kenny: correct on the first thing, So you'd need to pause at the end of pre-run I think then let the child run its pre-run to nest22:58
clarkby2kenny: what we've been doing a lot of us the artifact dependencies which is similar but different22:58
clarkby2kenny: a job can declare it produces some named thing and others can depend on that22:58
clarkbthen zuul figures it out22:58
clarkb(the actual storage of that thing is up to the job implementation)22:59
y2kennyok22:59
y2kennymy use case is a bit different.  Right now I am trying to have a parallel "thing" that monitor a baremetal serial console using IPMI serial over lan while tests are being done on the baremetal machine23:00
y2kennyI have been trying different "thing" but kind of stuck right now.23:00
clarkby2kenny: would a multinode job solve that problem better?23:01
y2kennyyes about multinode and that's what I was thinking of doing initially23:01
clarkbyou could have the job specify it needs the target and the monitor, configure them both, then start testing on the target and at the end the job collects from the monitor23:01
y2kennybut my understanding is that I can't get a different node from different providers?23:01
y2kennyor may be I misunderstood something earlier.23:02
y2kennythe baremetal node is currently provided by the cobbler thing that I wrote.  I was actually thinking of launching a separate pod in the container cluster to do the monitoring23:03
clarkboh ya I think that may still be the case23:04
clarkbthough I think there has been talk of making it more flexible23:04
y2kennyI didn't quite figure out how to get that to work so I ended up using the executor/localhost and ansible async to do the monitoring.23:04
clarkb(we run into similar issues where we want to test arm64 but also have x86 for throughput)23:04
y2kennyso essentially I have a delegate to localhost task that launches the ipmitool to do the monitoring async, run the test and then close the monitoring23:05
y2kennybut then apparently I was exploiting a security hole :)23:05
y2kenny(since I was running the localhost call in an untrusted project pre-submit)23:06
y2kennyso then I refactored the monitoring to a parent job in a trusted project23:06
y2kennybut then I think the monitoring just die as the pre-run finish (because the execution is done inside the bubblewrap/container thing?  I am speculating.)23:07
y2kennythis is how I was thinking of using the pause job thing but sounds like the pause job is for a different parent-child relationship.23:08
y2kenny(dependency relationship ship instead of the inheritance relationship... I am going to call them this until you guys correct me with an official vocabular :)  )23:09
fungiif someone works out clear terminology, please make sure it gets added to https://zuul-ci.org/docs/zuul/reference/glossary.html (assuming it's not there already)23:12
fungiwe have "job dependency" and "provided/required artifact" documented there already23:13
fungisee which of those fits your mental model23:13
y2kennyfungi: ah yes, thanks.  I am getting my words mix up because both job dependency and job inheritance have parent-child relationship)23:16
fungiyep, we've got "child/parent job" terms in there too23:17
openstackgerritGuillaume Chauvel proposed zuul/zuul master: use opendev-buildset-registry, buil tutorial image one time  https://review.opendev.org/c/zuul/zuul/+/73300523:17
fungii tried to avoid saying "depend" when talking about inheritance so as to avoid people getting the concepts confused23:18
*** Goneri has joined #zuul23:18
y2kennythe glossary seems to use child/parent mostly for the job inheritance.  But then the pause job documentation uses child job term for the dependent job relationship23:19
y2kennyhttps://zuul-ci.org/docs/zuul/reference/jobs.html#pausing-the-job23:19
fungiyeah, that may be worth some cleanup23:19
fungii also have a long-standing to do list entry to go through and cross-link glossary terms from wherever they're used throughout the documentation23:20
y2kennyDoes the doc on the website derive from here: https://review.opendev.org/plugins/gitiles/zuul/zuul/+/refs/heads/master ?23:22
openstackgerritGuillaume Chauvel proposed zuul/zuul master: use opendev-buildset-registry, buil tutorial image one time  https://review.opendev.org/c/zuul/zuul/+/73300523:22
y2kennyI can probably post some clean up after I figure out this baremetal monitoring thing23:23
*** rlandy has quit IRC23:34
fungiy2kenny: yes, https://opendev.org/zuul/zuul/raw/branch/master/doc/source/reference/jobs.rst23:34
*** hamalq has joined #zuul23:37
*** holser has quit IRC23:38
*** holser has joined #zuul23:39
*** hamalq has quit IRC23:41
*** rfolco|ruck has quit IRC23:50
*** rfolco|ruck has joined #zuul23:50
*** hamalq has joined #zuul23:52
*** rfolco|ruck has quit IRC23:55
*** tosky has quit IRC23:57
*** hamalq has quit IRC23:57
*** openstackgerrit has quit IRC23:59

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!