| *** rlandy has quit IRC | 00:11 | |
| *** wuchunyang has joined #zuul | 00:14 | |
| *** wuchunyang has quit IRC | 00:18 | |
| *** smyers has quit IRC | 00:21 | |
| *** smyers has joined #zuul | 00:45 | |
| *** holser has quit IRC | 01:02 | |
| *** Goneri has quit IRC | 01:23 | |
| *** armstrongs has joined #zuul | 01:26 | |
| *** armstrongs has quit IRC | 01:36 | |
| *** hamalq has quit IRC | 01:38 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: merge-output-to-logs: convert to untrusted executor safe code https://review.opendev.org/758325 | 02:44 |
|---|---|---|
| *** bhavikdbavishi has joined #zuul | 02:54 | |
| *** bhavikdbavishi1 has joined #zuul | 02:57 | |
| *** yolanda has quit IRC | 02:57 | |
| *** bhavikdbavishi has quit IRC | 02:58 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 02:58 | |
| openstackgerrit | Merged zuul/zuul-jobs master: More E208 fixes https://review.opendev.org/761090 | 03:14 |
| *** zenkuro has quit IRC | 04:28 | |
| *** bhavikdbavishi has quit IRC | 04:28 | |
| *** bhavikdbavishi has joined #zuul | 04:29 | |
| openstackgerrit | Merged zuul/zuul master: Make protected attribute clearer to the end user https://review.opendev.org/759226 | 04:34 |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #zuul | 05:33 | |
| *** wuchunyang has joined #zuul | 05:45 | |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Implementation of Zookeeper backed event queues https://review.opendev.org/761170 | 05:51 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Implementation of Zookeeper event watcher https://review.opendev.org/761171 | 05:51 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Switch to Zookeeper backed trigger event queues https://review.opendev.org/761172 | 05:51 |
| *** bhavikdbavishi1 has joined #zuul | 06:25 | |
| *** vishalmanchanda has joined #zuul | 06:26 | |
| *** bhavikdbavishi has quit IRC | 06:27 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 06:27 | |
| *** saneax has joined #zuul | 06:38 | |
| *** bhavikdbavishi has quit IRC | 07:11 | |
| *** mach1na has joined #zuul | 07:18 | |
| *** mach1na has quit IRC | 07:18 | |
| *** mach1na has joined #zuul | 07:22 | |
| tobiash | ianw: responded on https://review.opendev.org/758092 | 07:25 |
| *** bhavikdbavishi has joined #zuul | 07:43 | |
| *** mach1na has quit IRC | 07:48 | |
| *** mach1na has joined #zuul | 07:52 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Configure json-server as mock API for development https://review.opendev.org/760933 | 07:53 |
| openstackgerrit | zbr proposed zuul/zuul-jobs master: Enable progressive mode with ansible-lint https://review.opendev.org/760691 | 08:02 |
| *** jcapitao has joined #zuul | 08:05 | |
| *** sshnaidm|afk is now known as sshnaidm|rover | 08:08 | |
| openstackgerrit | zbr proposed zuul/zuul-jobs master: More E208 https://review.opendev.org/761293 | 08:21 |
| *** bhavikdbavishi1 has joined #zuul | 08:22 | |
| *** bhavikdbavishi has quit IRC | 08:23 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 08:23 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: PF4: Rework of log viewer page https://review.opendev.org/751140 | 08:25 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: UI: Avoid empty state being shown before data is fetched https://review.opendev.org/758530 | 08:25 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: UI: Remove refresh button from build and buildset page https://review.opendev.org/758534 | 08:25 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Configure json-server as mock API for development https://review.opendev.org/760933 | 08:25 |
| openstackgerrit | zbr proposed zuul/zuul-jobs master: More E208 (22) https://review.opendev.org/761294 | 08:32 |
| *** bhavikdbavishi has quit IRC | 08:34 | |
| *** bhavikdbavishi has joined #zuul | 08:34 | |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Remove an unneeded api call when creating check_runs https://review.opendev.org/752056 | 08:42 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Save superfluous api requests in check run reporting https://review.opendev.org/752079 | 08:42 |
| *** tosky has joined #zuul | 08:42 | |
| *** hashar has joined #zuul | 08:54 | |
| *** jpena|off is now known as jpena | 08:56 | |
| openstackgerrit | zbr proposed zuul/zuul-jobs master: More E208 (final) https://review.opendev.org/761297 | 08:58 |
| ianw | tobiash: thanks; i should probably have noted more clearly that it just didn't seem to work for me; i will give it another go | 09:00 |
| ianw | like all the api pages were 404 | 09:00 |
| tobiash | ianw: are you referring to 758092? | 09:01 |
| ianw | yep | 09:01 |
| tobiash | ianw: that's weird, the test cases work and we have it in production as well. I'd be interesting in the root cause | 09:02 |
| *** rpittau|afk is now known as rpittau | 09:05 | |
| ianw | tobiash: maybe it's my yarn/npm mix up; i couldn't see anything from the 3001 server but didn't look too much. tomorrow i'll try clearing things and see if can start again | 09:06 |
| tobiash | k | 09:06 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Add and fix fields in driver trigger event models https://review.opendev.org/761166 | 09:14 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Allow (de-)serialization of trigger events https://review.opendev.org/761167 | 09:14 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Interface to get a driver's trigger event class https://review.opendev.org/761168 | 09:14 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Clear list of Zookeeper connections after tests https://review.opendev.org/761169 | 09:14 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Implementation of Zookeeper backed event queues https://review.opendev.org/761170 | 09:14 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Implementation of Zookeeper event watcher https://review.opendev.org/761171 | 09:14 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Switch to Zookeeper backed trigger event queues https://review.opendev.org/761172 | 09:14 |
| *** bhavikdbavishi has quit IRC | 09:33 | |
| *** holser has joined #zuul | 09:52 | |
| *** ironfoot has quit IRC | 09:56 | |
| *** ironfoot has joined #zuul | 09:58 | |
| *** hashar has quit IRC | 10:10 | |
| *** wuchunyang has quit IRC | 10:18 | |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Driver event ingestion https://review.opendev.org/717299 | 11:06 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Move management and result events to model https://review.opendev.org/761163 | 11:08 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Allow (de-)serialization of management events https://review.opendev.org/761164 | 11:08 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Allow (de-)serialization of result events https://review.opendev.org/761165 | 11:08 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Add and fix fields in driver trigger event models https://review.opendev.org/761166 | 11:08 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Allow (de-)serialization of trigger events https://review.opendev.org/761167 | 11:08 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Interface to get a driver's trigger event class https://review.opendev.org/761168 | 11:08 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Clear list of Zookeeper connections after tests https://review.opendev.org/761169 | 11:08 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Implementation of Zookeeper backed event queues https://review.opendev.org/761170 | 11:08 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Implementation of Zookeeper event watcher https://review.opendev.org/761171 | 11:08 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Switch to Zookeeper backed trigger event queues https://review.opendev.org/761172 | 11:08 |
| *** bhavikdbavishi has joined #zuul | 12:11 | |
| *** mach1na has quit IRC | 12:11 | |
| *** jcapitao is now known as jcapitao_lunch | 12:15 | |
| openstackgerrit | Ashley Bullock proposed zuul/zuul master: Add initial bitbucket cloud driver using webhooks https://review.opendev.org/759003 | 12:19 |
| *** AshBullock has joined #zuul | 12:25 | |
| AshBullock | Hey all, wanted to catch up on the bitbucketcloud driver I've been working on, one annoying thing I can't find a good way around is https://jira.atlassian.com/browse/BCLOUD-5814, which prevents forks from working currently, the pr ref spec has been a feature request for 8 years :( | 12:28 |
| *** jpena is now known as jpena|lunch | 12:32 | |
| *** rlandy has joined #zuul | 12:33 | |
| *** hashar has joined #zuul | 12:34 | |
| *** armstrongs has joined #zuul | 12:52 | |
| *** mach1na has joined #zuul | 12:59 | |
| *** rfolco has joined #zuul | 13:07 | |
| *** jcapitao_lunch is now known as jcapitao | 13:13 | |
| *** armstrongs has quit IRC | 13:16 | |
| *** holser has quit IRC | 13:18 | |
| tobiash | AshBullock: you mean you cannot fetch the pr head from the target repo if the pr was created from a fork? | 13:22 |
| AshBullock | tobiash yeah, i've tried a few things out, but i'm finding the forks commit references just aren't present on the target repo, reading through that feature request it seems everyone trying to integrate with bitbucketcloud is seeing similar issues | 13:26 |
| AshBullock | I'm sure there is some way around it i'm not seeing, but currently it limits to same repo branches | 13:26 |
| *** Goneri has joined #zuul | 13:37 | |
| *** bhavikdbavishi has quit IRC | 13:39 | |
| *** jpena|lunch is now known as jpena | 13:40 | |
| *** zenkuro has joined #zuul | 13:50 | |
| *** saneax has quit IRC | 13:52 | |
| *** saneax has joined #zuul | 13:59 | |
| sean-k-mooney | AshBullock: i guess you could work around it byt having the bitbucket driver add the PR source repo as a remote and pull the branch form there | 14:07 |
| sean-k-mooney | but really it is not something you should have to do | 14:07 |
| *** saneax has quit IRC | 14:08 | |
| *** mach1na has quit IRC | 14:11 | |
| *** zenkuro has quit IRC | 14:12 | |
| *** zenkuro has joined #zuul | 14:13 | |
| *** mach1na has joined #zuul | 14:14 | |
| *** holser has joined #zuul | 14:25 | |
| fungi | if zuul can already identify the source repo for the pr, couldn't the merger just fetch the commit id for it? doesn't actually require a named ref nor configuring an additional remote (you can fetch from a repository url, doesn't have to be configured as a remote first) | 14:28 |
| corvus | i think fetch by sha is new; you'd want to confirm that works | 14:29 |
| corvus | "new" is relative of course :) | 14:29 |
| fungi | good point, it works on *my* git, but maybe not *old* git | 14:31 |
| corvus | and who knows what bbc is running | 14:31 |
| fungi | oh, you mean depends on the git server version | 14:32 |
| corvus | yes -- i think that's the case. but am i remembering that wrong and it's only client? | 14:32 |
| fungi | i'm testing various combinations right now | 14:33 |
| fungi | git 1.9.1 client (ubuntu 14.04) can't do it, claims "error: no such remote ref" | 14:34 |
| fungi | 2.7.4 (ubuntu 16.04) also can't, same error | 14:38 |
| fungi | 2.17.1 (ubuntu 18.04) works | 14:38 |
| tobiash | the official docs about fetching a pr is this: https://confluence.atlassian.com/bbkb/how-to-locally-fetch-and-checkout-a-pull-request-724402529.html | 14:38 |
| fungi | but that's specifically when testing against opendev's gerrit 2.13 (whatever jgit rev that is) | 14:38 |
| tobiash | so tldr: git fetch <merge request url> | 14:39 |
| tobiash | with the source branch | 14:39 |
| tobiash | not sha | 14:39 |
| tobiash | but I wonder what happens if the forked repo has different permissions than the original one | 14:39 |
| tobiash | (if that's possible at all) | 14:39 |
| corvus | AshBullock: ^ fyi | 14:40 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Allow (de-)serialization of trigger events https://review.opendev.org/761167 | 14:40 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Interface to get a driver's trigger event class https://review.opendev.org/761168 | 14:40 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Clear list of Zookeeper connections after tests https://review.opendev.org/761169 | 14:40 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Implementation of Zookeeper backed event queues https://review.opendev.org/761170 | 14:40 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Implementation of Zookeeper event watcher https://review.opendev.org/761171 | 14:40 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Switch to Zookeeper backed trigger event queues https://review.opendev.org/761172 | 14:40 |
| tobiash | problem is that this makes it hard to integrate into zuul since the merger's architecture currently assumes a single remote url | 14:42 |
| fungi | also tested against opendev's gitea instance and i can similarly fetch by commit id (sha1 hash) | 14:42 |
| corvus | tobiash: true, but it's a tractable problem; we could pass a new url all the way through if necessary | 14:43 |
| tobiash | yes | 14:43 |
| tobiash | if there is a new url the merger needs to do two fetches | 14:43 |
| tobiash | just not as easy as implementing a driver ;) | 14:43 |
| fungi | would probably need to find a bb repo with an open pr and try closing the pr's sha i suppose, i'll see if i can find one quickly | 14:43 |
| fungi | er, s/closing/fetching/ | 14:44 |
| fungi | yeah, it works | 14:49 |
| fungi | AshBullock: example... http://paste.openstack.org/show/799694/ | 14:50 |
| fungi | so maybe not ideal, and as tobiash says it'll likely require a new merger feature to plumb the pr source repo name through | 14:50 |
| tobiash | fungi: can you fetch the same sha from the original repo as well? | 14:50 |
| fungi | oh, good question, i'll try that. i know it works on github only because of the way they designed their backend/forking solution | 14:51 |
| tobiash | I guess not since that ticket is not mentioning such a workaround | 14:51 |
| fungi | so i wouldn't expect that to be a universal behavior | 14:51 |
| fungi | error: Server does not allow request for unadvertised object 26b7b5ec07f4b8f6f1f2dfb18ea1685dfe7fdfae | 14:52 |
| fungi | so that's a no, unfortunately | 14:52 |
| tobiash | k so double fetch is the way to go | 14:52 |
| fungi | but like i said, that only works on github because they combine all objects for forks into the same space (doesn't even need a pr, you can fork a repo on github, push some new commits to it, then reference that commit id from the original repo) | 14:53 |
| *** bhavikdbavishi has joined #zuul | 14:53 | |
| fungi | that's been abused to amusing effect during the youtube-dl dmca takedown, to push copies of the youtube-dl source to a fork of github's dmca takedown repo and then publish references to it in the original. even if the fork is deleted the objects persist (supposedly indefinitely unless gh staff get a tipoff and manually delete said objects) | 14:55 |
| fungi | not quite the "security hole" folks keep making it out to be, but still rather humorous | 14:56 |
| AshBullock | Thanks for the help, i've hit the same issue tobiash mentions, the sha is not present on the original repo unfortunately, so it looks like I'll need to look into the bespoke merger method | 14:58 |
| *** bhavikdbavishi has quit IRC | 15:00 | |
| AshBullock | on another note, I'm adding test cases for the driver, I'm following similar examples from the base.py mock examples, it would be great to catch up with someone on this as I just want to make sure I'm following the correct format | 15:00 |
| *** bhavikdbavishi has joined #zuul | 15:01 | |
| AshBullock | also I've reached out to Maciej, who i've seen has made some great progress on the server implementation, just to check if we can consolidate anywhere | 15:01 |
| *** bhavikdbavishi has quit IRC | 15:29 | |
| *** bhavikdbavishi has joined #zuul | 15:30 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-website master: Add link to zuul-client documentation https://review.opendev.org/751312 | 15:54 |
| AshBullock | corvus tobiash fungi in your view would fork support with the additional merger method be a requirement before this gets put in? | 16:10 |
| fungi | AshBullock: i think as long as some workflow is supported we could start with what works and then try to add pr workflow support. the gitlab driver had similar feature parity gaps when we merged the initial support commits for it | 16:12 |
| AshBullock | or could we footnote that branch support is the only option for now, I'm just conscious of adding unneeded complexity to the code base, but seeing that feature request's open time i'm not confident it will be implemented any time soon, it's quite baffling | 16:13 |
| AshBullock | ok great, well, I'll look into the merger bits and see how much work it would be | 16:14 |
| corvus | AshBullock: yeah, i don't think we need to block on it, but i think it's important and we should plan on adding it soon. | 16:16 |
| AshBullock | a nice evening project! yeah, otherwise i'll add some bits to the docs on the issue | 16:17 |
| *** Goneri has quit IRC | 16:18 | |
| openstackgerrit | Daniel Pawlik proposed zuul/zuul master: Improve Elasticsearch reporter doc and driver, changed index name https://review.opendev.org/761441 | 16:18 |
| *** Goneri has joined #zuul | 16:21 | |
| *** mach1na has quit IRC | 16:26 | |
| *** hashar has quit IRC | 16:28 | |
| *** hashar has joined #zuul | 16:28 | |
| AshBullock | for testing, i'm working through test cases now, is the desired approach to add mocks for connection, pr etc to tests/base.py? | 16:30 |
| openstackgerrit | Clark Boylan proposed zuul/nodepool master: Have nodepool scan as many ssh host keys as possible https://review.opendev.org/761229 | 16:30 |
| clarkb | corvus: ^ that is updates based on test job logs. I'm trying to make the logging cleaner there | 16:30 |
| tobiash | clarkb: do you have an estimation of the performance impact that has? | 16:50 |
| tobiash | looks like that does six keyscans per node? | 16:50 |
| openstackgerrit | Merged zuul/zuul master: tools: use python3 for encrypt_secret https://review.opendev.org/760266 | 16:51 |
| clarkb | tobiash: on from the test logs, https://zuul.opendev.org/t/zuul/build/6fe013f39a9d4f0ba3abab796162ed9c/log/nodepool/nodepool-launcher.log#955, it looks to be about a second and a half spent key scanning | 16:51 |
| tobiash | k | 16:52 |
| clarkb | compared to the wait time for ssh to listen as well as general spin loop for server to boot I expect the impact to be small | 16:52 |
| mhu | since 760266 got merged, how about adding the encrypt subcommand to zuul-client? https://review.opendev.org/#/c/750709/ and https://review.opendev.org/#/c/754103/ | 16:53 |
| pabelanger | tristanC: thanks again, that got me the data we needed. | 17:14 |
| pabelanger | talking with Goneri, I think we are going to see about updating it to use REST API | 17:14 |
| *** tosky has quit IRC | 17:15 | |
| pabelanger | tobiash: clarkb: left comment too | 17:17 |
| clarkb | the logs are much cleaner with the latest patchset in the openstack functional job and shows it is adding rsa, ecdsa, and ed25519 keys | 17:22 |
| clarkb | pabelanger: note I think there are at least 3 different ecdsa key types | 17:22 |
| pabelanger | right | 17:23 |
| pabelanger | on centos, it is default 1 for bit size | 17:23 |
| pabelanger | haven't changed others | 17:23 |
| pabelanger | checked8 | 17:23 |
| pabelanger | tristanC: also, is the status-page report that is generated for SF live some place? | 17:24 |
| clarkb | the risk there is if you pick one ecdsa key size that your client decides is not valid later (because ansible uses openssh not paramiko) you'll break | 17:24 |
| clarkb | it really does seem more flexible to grab all the valid keys and add them then let ssh validate those that it sees | 17:24 |
| pabelanger | agree | 17:25 |
| *** jcapitao has quit IRC | 17:25 | |
| fungi | that way the answer to supporting additional host key types is just to make sure they get generated at boot | 17:28 |
| pabelanger | or deleted on boot | 17:28 |
| *** rpittau is now known as rpittau|afk | 17:35 | |
| *** vishalmanchanda has quit IRC | 17:38 | |
| tristanC | pabelanger: nice, sf-config runs status-page daily at fqdn/status, here is the one for sf-project.io: https://softwarefactory-project.io/status/ | 17:38 |
| pabelanger | great, thank you | 17:39 |
| pabelanger | tristanC: I'd love to see if we could agree to some sort of basic report page for zuul dashboard | 17:39 |
| pabelanger | but know that might be hard, since a lot of business logic | 17:39 |
| tristanC | pabelanger: ideally we would define a /metric endpoint, then we could share prometheus and grafana config that would work out of the box | 17:40 |
| tristanC | i think that would be the most ergonomic things to do | 17:40 |
| *** hamalq has joined #zuul | 17:46 | |
| *** jpena is now known as jpena|off | 18:04 | |
| *** sugaar has quit IRC | 18:13 | |
| *** reiterative has quit IRC | 18:14 | |
| *** mugsie has quit IRC | 18:18 | |
| *** mugsie has joined #zuul | 18:21 | |
| *** bhavikdbavishi has quit IRC | 18:32 | |
| *** holser has quit IRC | 19:32 | |
| *** sduthil has quit IRC | 20:22 | |
| *** Goneri has quit IRC | 20:23 | |
| *** tosky has joined #zuul | 20:35 | |
| *** Goneri has joined #zuul | 20:37 | |
| *** Goneri has quit IRC | 20:46 | |
| sean-k-mooney | is there a reason the zuul.conf options for the componets are grouped in https://zuul-ci.org/docs/zuul/discussion/components.html instead of https://zuul-ci.org/docs/zuul/reference/admin.html with the driver and connection options | 21:14 |
| sean-k-mooney | when i was redeploying my third party ci this split signifcantly increase the barrier to entry as its really un intuitive for the config for the zuul execucutor/schduler/web app to live under discussion not under reference | 21:16 |
| *** Goneri has joined #zuul | 21:26 | |
| *** Goneri has quit IRC | 21:51 | |
| *** hashar has quit IRC | 22:01 | |
| *** holser has joined #zuul | 22:08 | |
| *** rfolco has quit IRC | 22:30 | |
| *** rlandy is now known as rlandy|bbl | 23:07 | |
| *** AshBullock has quit IRC | 23:40 | |
| *** armstrongs has joined #zuul | 23:51 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!