| *** sai438 has quit IRC | 00:02 | |
| *** jamesmcarthur has joined #zuul | 00:16 | |
| *** jamesmcarthur has quit IRC | 00:29 | |
| *** jamesmcarthur has joined #zuul | 00:40 | |
| *** jamesmcarthur has quit IRC | 00:45 | |
| *** jamesmcarthur has joined #zuul | 00:46 | |
| *** tosky has quit IRC | 00:57 | |
| *** jamesmcarthur has quit IRC | 01:10 | |
| *** rfolco has quit IRC | 01:10 | |
| *** jamesmcarthur has joined #zuul | 01:20 | |
| *** jamesmcarthur has quit IRC | 01:28 | |
| *** jamesmcarthur has joined #zuul | 01:45 | |
| *** jamesmcarthur has quit IRC | 01:53 | |
| *** jamesmcarthur has joined #zuul | 01:53 | |
| *** zenkuro has quit IRC | 01:59 | |
| *** vorotech has joined #zuul | 02:08 | |
| *** vorotech has quit IRC | 02:10 | |
| *** jamesmcarthur has quit IRC | 02:18 | |
| *** saneax has quit IRC | 02:31 | |
| *** bhavikdbavishi has joined #zuul | 03:04 | |
| *** bhavikdbavishi1 has joined #zuul | 03:06 | |
| *** bhavikdbavishi has quit IRC | 03:08 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 03:08 | |
| *** jamesmcarthur has joined #zuul | 03:23 | |
| *** jamesmcarthur has quit IRC | 03:28 | |
| *** jamesmcarthur has joined #zuul | 03:51 | |
| *** jamesmcarthur has quit IRC | 04:02 | |
| *** jamesmcarthur has joined #zuul | 04:03 | |
| *** jamesmcarthur has quit IRC | 04:06 | |
| *** bhavikdbavishi has quit IRC | 04:29 | |
| *** bhavikdbavishi has joined #zuul | 04:30 | |
| *** saneax has joined #zuul | 05:02 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #zuul | 05:33 | |
| *** wuchunyang has joined #zuul | 05:42 | |
| *** bhavikdbavishi1 has joined #zuul | 06:08 | |
| *** bhavikdbavishi has quit IRC | 06:09 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 06:09 | |
| *** pots has quit IRC | 06:22 | |
| *** vishalmanchanda has joined #zuul | 06:22 | |
| *** pots has joined #zuul | 06:23 | |
| *** sshnaidm|off is now known as sshnaidm|rover | 06:49 | |
| *** vorotech has joined #zuul | 07:09 | |
| *** mach1na has joined #zuul | 07:13 | |
| *** mach1na has quit IRC | 07:14 | |
| *** bhavikdbavishi has quit IRC | 07:32 | |
| *** mach1na has joined #zuul | 07:38 | |
| *** bhavikdbavishi has joined #zuul | 07:44 | |
| *** jcapitao has joined #zuul | 08:42 | |
| *** tosky has joined #zuul | 08:45 | |
| *** vorotech has joined #zuul | 08:49 | |
| *** nils has joined #zuul | 09:03 | |
| *** rpittau|afk is now known as rpittau | 09:22 | |
| openstackgerrit | Benjamin Schanzel proposed zuul/nodepool master: k8s/OpenShift Provider: Remove workingDir Attribute https://review.opendev.org/758965 | 09:23 |
|---|---|---|
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: How-to: using the REST API with cURL https://review.opendev.org/727785 | 09:35 |
| *** yolanda has joined #zuul | 09:36 | |
| *** AJaeger has joined #zuul | 09:39 | |
| *** AJaeger has quit IRC | 09:45 | |
| *** holser has joined #zuul | 09:54 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Store version information in ZK component registry https://review.opendev.org/760804 | 09:54 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Add /components API endpoint to zuul-web https://review.opendev.org/760805 | 09:54 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: UI: Add actions and reducers to retieve components https://review.opendev.org/760806 | 09:54 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: UI: Add components page https://review.opendev.org/760807 | 09:54 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: UI: Make components table filterable and add pagination https://review.opendev.org/760808 | 09:54 |
| *** vorotech has quit IRC | 09:57 | |
| *** vorotech has joined #zuul | 09:59 | |
| openstackgerrit | Ashley Bullock proposed zuul/zuul master: Add initial bitbucket cloud driver using webhooks https://review.opendev.org/759003 | 10:08 |
| *** bhavikdbavishi has quit IRC | 10:12 | |
| avass | does a gerrit event filter not take into consideration which gerrit connection the event came from? | 10:25 |
| avass | I'm debugging a pipeline that triggered for a gerrit event even though the trigger is configured to not match that branch | 10:25 |
| avass | but it did. and when I updated config for other gerrit triggers to do the same it stopped triggering | 10:26 |
| avass | Looking through the source currently | 10:27 |
| *** odyssey4me|PTO is now known as odyssey4me | 10:43 | |
| tobiash | avass: you need to specify the filter for every connection | 10:55 |
| tobiash | avass: since that is connection based, not driver type based | 10:56 |
| *** bhavikdbavishi has joined #zuul | 11:09 | |
| *** bhavikdbavishi1 has joined #zuul | 11:12 | |
| *** bhavikdbavishi has quit IRC | 11:13 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 11:13 | |
| *** rfolco has joined #zuul | 11:52 | |
| avass | tobiash: yeah we do, but a filter for a different connection affected what jobs triggered | 11:53 |
| avass | so connection B affected the jobs for connection A | 11:53 |
| tobiash | oh that is weird | 11:54 |
| avass | it looks like the gerrit event filter doesn't care which connection an event comes from | 11:54 |
| tobiash | sounds like a bug then | 11:55 |
| avass | I also noticed we have pipelines running for a connection that doesn't have any filters specified because of it | 11:55 |
| avass | yep, looking into how to solve it | 11:55 |
| *** jcapitao is now known as jcapitao_lunch | 11:57 | |
| *** hashar has joined #zuul | 12:00 | |
| *** vorotech has quit IRC | 12:05 | |
| *** mach1na has quit IRC | 12:08 | |
| *** rlandy has joined #zuul | 12:17 | |
| *** holser has quit IRC | 12:18 | |
| *** holser has joined #zuul | 12:20 | |
| *** zenkuro has joined #zuul | 12:20 | |
| *** ianychoi has joined #zuul | 12:24 | |
| *** zenkuro has quit IRC | 12:28 | |
| *** zenkuro has joined #zuul | 12:29 | |
| openstackgerrit | Albin Vass proposed zuul/zuul master: WIP: Filter events on event connection https://review.opendev.org/760907 | 12:30 |
| *** iurygregory is now known as iurygregory|afk | 12:31 | |
| openstackgerrit | Albin Vass proposed zuul/zuul master: WIP: Filter events on event connection https://review.opendev.org/760907 | 12:31 |
| openstackgerrit | Albin Vass proposed zuul/zuul master: WIP: Filter events on event connection https://review.opendev.org/760907 | 12:32 |
| avass | tobiash: I would expect it to work something like that ^ | 12:33 |
| openstackgerrit | Albin Vass proposed zuul/zuul master: WIP: Filter events on event connection https://review.opendev.org/760907 | 12:45 |
| *** mach1na has joined #zuul | 12:48 | |
| openstackgerrit | Albin Vass proposed zuul/zuul master: WIP: Filter events on event connection https://review.opendev.org/760907 | 12:52 |
| *** vorotech has joined #zuul | 12:52 | |
| *** mach1na has quit IRC | 12:53 | |
| *** mach1na has joined #zuul | 12:56 | |
| *** jcapitao_lunch is now known as jcapitao | 13:08 | |
| openstackgerrit | Albin Vass proposed zuul/zuul master: WIP: Filter events on event connection https://review.opendev.org/760907 | 13:10 |
| openstackgerrit | Michal Pryc proposed zuul/zuul-jobs master: Allow bindep role to read from more then one bindep file https://review.opendev.org/759868 | 13:15 |
| openstackgerrit | Michal Pryc proposed zuul/zuul-jobs master: Allow bindep role to read from more then one bindep file https://review.opendev.org/759868 | 13:15 |
| zbr | avass: https://review.opendev.org/#/c/760809/ please, simple. | 13:16 |
| *** sduthil has joined #zuul | 13:16 | |
| openstackgerrit | Michal Pryc proposed zuul/zuul-jobs master: Allow bindep role to read from more then one bindep file https://review.opendev.org/759868 | 13:17 |
| openstackgerrit | Albin Vass proposed zuul/zuul master: WIP: Filter events on event connection https://review.opendev.org/760907 | 13:20 |
| avass | zbr: lgtm but I don't have access to +3 on that repo :) | 13:24 |
| openstackgerrit | zbr proposed zuul/zuul-jobs master: More E208 fixes https://review.opendev.org/760918 | 13:35 |
| tristanC | zbr: i thought the ansible default mode issue was fixed, in which situation not settings the mode results in undesirable permissions? | 13:43 |
| openstackgerrit | Merged zuul/zuul-jobs master: More E208 mode fixes https://review.opendev.org/748498 | 13:50 |
| *** dmsimard has quit IRC | 13:51 | |
| *** dmsimard has joined #zuul | 13:51 | |
| *** dmsimard has quit IRC | 14:03 | |
| *** dmsimard has joined #zuul | 14:03 | |
| *** bhavikdbavishi has quit IRC | 14:10 | |
| openstackgerrit | Michal Pryc proposed zuul/zuul-jobs master: Allow bindep role to read from more then one bindep file https://review.opendev.org/759868 | 14:13 |
| mhu | hello zuul-maint, here are a few patches that are ready for a final +3: https://review.opendev.org/#/c/728118/ https://review.opendev.org/#/c/751312/ https://review.opendev.org/#/c/754103/ https://review.opendev.org/#/c/755519/ | 14:27 |
| *** bhavikdbavishi has joined #zuul | 14:30 | |
| *** bhavikdbavishi1 has joined #zuul | 14:33 | |
| *** bhavikdbavishi has quit IRC | 14:34 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 14:34 | |
| *** iurygregory|afk is now known as iurygregory | 14:41 | |
| *** jamesmcarthur has joined #zuul | 14:43 | |
| *** bhavikdbavishi has quit IRC | 14:45 | |
| *** vishalmanchanda has quit IRC | 14:46 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Configure json-server as mock API for development https://review.opendev.org/760933 | 14:47 |
| *** nils has quit IRC | 15:09 | |
| *** hashar has quit IRC | 15:27 | |
| zbr | tristanC: regarding file mode depends who you ask about being fixed, they fix it twice and people still say that is not fixed yet. | 15:31 |
| zbr | as far the default behavior is undefined the file mode is an issue, and read https://docs.ansible.com/ansible/latest/collections/ansible/builtin/file_module.html | 15:31 |
| zbr | default is unspecified | 15:31 |
| zbr | there is a lot of docs about what to put and no mention of default/implicit behavior, mainly because is bit of a "hit or miss" | 15:32 |
| zbr | main reason for this is that ansible created files in a different temp folder and is moving them, the final outcome is not what you would get if you just create the file with touch at the destination | 15:33 |
| zbr | we seen bugs due to this | 15:33 |
| zbr | most people assumed POSIX behavior, but is not. | 15:33 |
| tristanC | zbr: right, but when is the default (although undefined) behavior undesirable? | 15:35 |
| zbr | usually i dislike being extra verbose and i like to reuse defaults, but in this case explicit is desired | 15:35 |
| zbr | that is what linter complains about undefined behavior is risky | 15:35 |
| *** AJaeger has joined #zuul | 15:36 | |
| zbr | it may produce unintended outcomes | 15:36 |
| tristanC | zbr: i still don't understand what is the risk and why does it warrant to require the mode to be always set | 15:37 |
| *** bhavikdbavishi has joined #zuul | 15:37 | |
| zbr | if you write files with credentials, you may endup having them world readable. | 15:38 |
| zbr | even if you write them to folders that have correct mask | 15:39 |
| *** rfolco has quit IRC | 15:41 | |
| *** AJaeger has quit IRC | 15:42 | |
| tristanC | zbr: that seems like a consistent behavior, aren't we already setting the mode for secrets? | 15:50 |
| *** smyers_ has joined #zuul | 15:51 | |
| tristanC | zbr: what is the issue with folder that have correct mask? | 15:51 |
| *** smyers has quit IRC | 15:52 | |
| *** smyers_ is now known as smyers | 15:52 | |
| *** rlandy has quit IRC | 15:58 | |
| *** smyers has quit IRC | 15:59 | |
| *** iurygregory has quit IRC | 16:12 | |
| danpawlik | tobiash: hey, could you check once again: https://review.opendev.org/#/c/644927/ ? | 16:17 |
| *** jamesmcarthur has quit IRC | 16:17 | |
| openstackgerrit | Michal Pryc proposed zuul/zuul-jobs master: Allow bindep role to read from more then one bindep file https://review.opendev.org/759868 | 16:17 |
| *** hashar has joined #zuul | 16:19 | |
| *** iurygregory has joined #zuul | 16:22 | |
| *** rlandy has joined #zuul | 16:22 | |
| danpawlik | thanks tobiash | 16:27 |
| tobiash | danpawlik: no problem :) | 16:27 |
| *** mach1na has quit IRC | 16:27 | |
| *** rlandy has quit IRC | 16:28 | |
| *** rfolco has joined #zuul | 16:30 | |
| *** jamesmcarthur has joined #zuul | 16:36 | |
| *** jamesmcarthur has quit IRC | 16:37 | |
| *** jamesmcarthur has joined #zuul | 16:42 | |
| *** rlandy has joined #zuul | 16:49 | |
| *** jamesmcarthur has quit IRC | 17:00 | |
| *** jamesmcarthur_ has joined #zuul | 17:01 | |
| openstackgerrit | Albin Vass proposed zuul/zuul master: WIP: Filter events on event connection https://review.opendev.org/760907 | 17:01 |
| *** armstrongs has joined #zuul | 17:04 | |
| *** rpittau is now known as rpittau|afk | 17:08 | |
| *** armstrongs has quit IRC | 17:13 | |
| clarkb | tobiash (and others) I'm going to try and catch up on reviews and things I've neglected due to recent distractions. Are there any important zuul related changes to call out that I can help with? | 17:14 |
| avass | clarkb: it's not quite ready since I need to add tests as well but having a quick review on this would be nice: https://review.opendev.org/#/c/760907/ | 17:15 |
| avass | tl;dr the manager doesn't take into account which connection an event originates from and if any event filter for any connection matches the change will be run | 17:16 |
| tobiash | clarkb: cool, let me look up some :) | 17:17 |
| avass | as long as the connection type is correct | 17:17 |
| tobiash | clarkb: maybe start with those of mhu and danpawlik mentioned above, they already have +2 by me | 17:18 |
| clarkb | avass: oh so if you have two different gerrits they can trigger across from each other? | 17:19 |
| clarkb | avass: that change looks fine. I would also add a release note since the behavior change may trip some people up. | 17:21 |
| avass | yup, we had changes running for branches that should have been ignored since it matches with another connections event filter | 17:22 |
| avass | will do :) | 17:22 |
| clarkb | avass: also maybe we can push that specific check into the EventFilter class and call super on it? | 17:23 |
| clarkb | that way all drivers get that as long as they are double checking the parent call | 17:24 |
| *** jamesmcarthur_ has quit IRC | 17:28 | |
| *** jamesmcarthur has joined #zuul | 17:28 | |
| *** tosky has quit IRC | 17:28 | |
| avass | sure I was thinking about that as well since it pretty much affected every trigger. I'll look into it after I've added tests | 17:28 |
| *** jamesmcarthur has quit IRC | 17:34 | |
| *** zenkuro has quit IRC | 17:38 | |
| *** zenkuro has joined #zuul | 17:39 | |
| tobiash | clarkb: this is a collection of things from us that are ready to review (mostly small but things): http://paste.openstack.org/show/799615/ | 17:39 |
| clarkb | k working through the large ES change now | 17:41 |
| *** zenkuro has quit IRC | 17:47 | |
| *** zenkuro has joined #zuul | 17:48 | |
| *** bhavikdbavishi1 has joined #zuul | 17:50 | |
| *** bhavikdbavishi has quit IRC | 17:50 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 17:50 | |
| tobiash | zuul-maint: probably not an easy topic, but I wonder if there is a way to generally improve the review situation in the project by some kind of better structuring/classification of the reviews? I often find it hard to go through reviews in a structured manner. This generally seems to lead to loudly advertised changes getting attention and less or not advertised changes get buried deep in an overwhelming stack of | 17:51 |
| tobiash | unreviewed changes. I sometimes also find it hard too distinguish if a change is ready to review or still actively being worked on. | 17:51 |
| *** bhavikdbavishi has quit IRC | 17:51 | |
| *** vorotech has quit IRC | 17:53 | |
| *** bhavikdbavishi has joined #zuul | 17:53 | |
| *** sshnaidm|rover is now known as sshnaidm|afk | 17:57 | |
| mhu | tobiash, I support that discussion, it must be frustrating sometimes for all parties involved | 17:58 |
| mhu | as for identifying changes that are still worked on, how about setting workflow -1 on all changes by default and have the contributor switch it to workflow 0 when it's ready for review? | 18:00 |
| tobiash | yeah, that could help probably | 18:01 |
| clarkb | I'm not sure we can do that mechanically? ew could ask people to set it though | 18:01 |
| clarkb | though maybe gerrit allows you to set a default value that is non neutral? | 18:01 |
| clarkb | fwiw I reviewed the ES change. I left a number of questions/concerns but not sure any are worthy of a -1 | 18:01 |
| mhu | clarkb, no idea, sorry | 18:01 |
| clarkb | would be good if others following along can check them | 18:01 |
| zbr | i support it too, i found it frustrating too, the overall idea was that almost no review is looked at unless you actively nag people to look at it. | 18:02 |
| zbr | and I am not referring to changes that already have a negative vote on them, i am referring to those that do not. | 18:02 |
| tobiash | the default can be specified in the project config: https://gerrit-review.googlesource.com/Documentation/config-labels.html#label_custom | 18:02 |
| clarkb | yup looks like the default default is the neutral 0 but can be overridden | 18:03 |
| tobiash | what I'd also find useful is some automatic abandon of stale changes after x months of no action | 18:03 |
| *** smyers has joined #zuul | 18:04 | |
| tobiash | we still have open changes for zuulv2 around from when we merged v3 into master | 18:04 |
| mhu | tobiash, maybe that discussion deserves a topic on zuul-discuss? | 18:04 |
| *** jamesmcarthur has joined #zuul | 18:04 | |
| tobiash | probably, I thought I start here to have a more direct discussion ;) | 18:05 |
| tobiash | but I can try to summarize some ideas in an email tomorrow then :) | 18:05 |
| avass | sounds good | 18:05 |
| zbr | tobiash: thanks for opening the subject. i hope something good comes out of this. | 18:06 |
| zbr | IMHO abandoning old/outdated reviews will make easier to review the rest, less noise. | 18:07 |
| clarkb | maybe? the old changes tend to go at the end of lists are get ignord naturally | 18:07 |
| clarkb | cleaning them up won't hurt but I'm not sure it will help much | 18:07 |
| clarkb | gerrit web ui sorts by recent activity and gertty allows you to mute a change until it has activity | 18:08 |
| zbr | in my opinion it does, multiple points of view: when someone new visits a project the state of open reviews is a good sign of how healthy is a projects | 18:08 |
| tobiash | that's true, but there are also some important old reviews actually that got forgotten (and probably would get revived after the abandon notification) | 18:08 |
| zbr | lots of forgotten stuff does not send a good signal to new/potential contributers, in fact is a good detterent | 18:09 |
| clarkb | zbr: right but still that doens't help active reviewers review active changes | 18:09 |
| zbr | especially PRs that passed CI and were nevered reviewed by a core | 18:09 |
| clarkb | tobiash: thats a good point if we need to revive them | 18:09 |
| zbr | i was considering writing a bot that sends a daily email with pending reviews, those that are green but no votes from cores. | 18:10 |
| tobiash | also there's also a psycological component there since for me as a reviewer it's virtually impossible to work through all reviews in the 'needs review list' | 18:10 |
| zbr | i already have the tool to create it, but i did not do it because i did not want to annoy cores. | 18:10 |
| clarkb | (as a side note we can already abandon change we know that are no longer applicable) | 18:11 |
| zbr | in fact i seen that some projects on gerrit do not have the Abandon right for cores, likely due to some ACL accident (not on purpose). | 18:11 |
| *** jamesmcarthur has quit IRC | 18:12 | |
| clarkb | zbr: yes, I don't expect that would be received well. We should make it easier for cores to opt into finding that data not spam them with it | 18:12 |
| *** jamesmcarthur has joined #zuul | 18:12 | |
| zbr | instead of email, it could be an irc bot, but one that is throttled to a limit of reminders per day. | 18:12 |
| tobiash | zbr: I prefer email spam over irc spam ;) | 18:13 |
| zbr | i am sure that if we do it right we could address the issue, and reduce the amount of stalling stuff, even without overloading cores. | 18:14 |
| tobiash | but actually we had a similar idea whether it's useful to have an automated weekly summary of what changed during the week (filtered for ready for review) | 18:14 |
| zbr | weekly, or twice a week report could be really nice. | 18:14 |
| zbr | maybe even including a top chart of cores that did reviews last week, positive motivation ;) | 18:15 |
| tobiash | but that would depend on a clear filter on what's ready to review | 18:15 |
| tobiash | zbr: well, we don't want to indirectly blame people for not doing reviews ;) | 18:16 |
| zbr | i did not say to list those that can perform reviews but do not do them, listing only the top 5 reviewers, or something like this. | 18:16 |
| clarkb | right, the goal should be to help people more efficiently use the time they have for reviews, not shame people who are busy with other things | 18:16 |
| zbr | the same approach can apply to other projects, is not an issue limited to zuul. | 18:17 |
| tobiash | considering -w by default something like this could help (filtered for one week maybe): https://review.opendev.org/#/q/project:zuul/zuul+label:Verified%252B1+label:Workflow%252B0 | 18:20 |
| avass | tobiash: tbh I prefer irc spam to email spam. I've turned off all gerrit mails :) | 18:20 |
| *** jamesmcarthur has quit IRC | 18:20 | |
| clarkb | tobiash: left a question on https://review.opendev.org/#/c/720249/7 | 18:21 |
| * zbr thinking about spaming avass on both irc and email.... ?:D | 18:22 | |
| tobiash | looking | 18:22 |
| zbr | there are some POST_FAILURE with centos-8: https://zuul.opendev.org/t/zuul/builds?job_name=zuul-jobs-test-multinode-roles-centos-8&project=zuul/zuul-jobs | 18:23 |
| zbr | is quite weird as is unrelated to the change, but they seem more than accidental. | 18:23 |
| avass | but defaulting to w-1 sounds like a good idea. that functionality isn't really used at the moment instead I'm adding "WIP: ... " to the commit since going into gerrit to add the w-1 label is extra work | 18:27 |
| avass | and the irc bot wouldn't have to report every change to irc, instead it could report changes that gets w=0 | 18:28 |
| tobiash | clarkb: no idea anymore, probably not needed, I'll test tomorrow | 18:29 |
| clarkb | avass: fwiw you can toggle the WIP vote instead of using the comments in the commit message. Usualy my rule of thumb is if I never want a change to merge because it tests via inducing failure or something then I use the commit message but use the WIP thing if it is expected to transition | 18:30 |
| tobiash | clarkb: yes, but the WIP thing currently resets itself on every upload | 18:31 |
| tobiash | yeah, I think -w by default is probably a key enabler for making such things like reporting or a dashboard possible | 18:31 |
| zbr | how about making use of private changes? can we make changes private by default? | 18:32 |
| avass | drafts are disabled in opendev I believe | 18:33 |
| clarkb | correct they cause more problems than they solve | 18:33 |
| clarkb | particularly problematic for ci | 18:33 |
| clarkb | but also for general human understanding | 18:33 |
| zbr | yes drafts are disabled, and were removed from newer gerrit being replaced by private changes | 18:33 |
| clarkb | zbr: no they are replaced by WIP changes | 18:33 |
| clarkb | (the upgrade we are doing automatically converts all drafts to wip) | 18:34 |
| tobiash | yes, I think that's also more difficult for a drive by contributor than the -w flag which can be removed by a core in case of an obvious ready to review | 18:34 |
| zbr | well, i would be very happy not to have to rename subject to move a change to/from WIP. | 18:34 |
| clarkb | zbr: you don't that is why we have the -W flag | 18:35 |
| clarkb | and in newer gerrit its a built in thing (may be a plugin though) | 18:35 |
| *** bhavikdbavishi1 has joined #zuul | 18:36 | |
| zbr | lets try to make the -W implicit to one project and see how it goes, i kinda like the idea that until author removes the -W, it will have it. | 18:36 |
| clarkb | however I don't know if you can default chnages to the built in wip state | 18:36 |
| tobiash | the -w flag would be probably sufficient | 18:37 |
| zbr | we should also remember that the upcoming upgrade could open new ways of doing things | 18:37 |
| avass | I do however see a problem with cores accidentally giving themselves w+1 instead of w=0 :) | 18:38 |
| *** bhavikdbavishi has quit IRC | 18:38 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 18:38 | |
| clarkb | yup, the improvements to dashboarding are definitely worth looking at I expect, but I'm trying to avoid getting to far ahead of myself and focus on the upgrade first | 18:38 |
| openstackgerrit | zbr proposed zuul/zuul-jobs master: More E208 fixes https://review.opendev.org/760918 | 18:38 |
| tobiash | avass: valid point, we could also introduce a ready-to-review flag instead | 18:39 |
| *** rlandy is now known as rlandy|brb | 18:47 | |
| *** jcapitao has quit IRC | 18:47 | |
| *** bhavikdbavishi has quit IRC | 18:49 | |
| corvus | tobiash: i don't have trouble finding things to review. that's fairly easy actually. i simply don't have much time at the moment. | 18:49 |
| corvus | i'm not really a fan of w-1 by default | 18:49 |
| corvus | it's usually pretty easy to identify reviews that aren't ready either | 18:50 |
| corvus | they either have WIP in the subject or folks set them WIP-1 or they don't pass tests | 18:50 |
| fungi | usually i don't push a change unless i feel it's ready to be reviewed/merged. if i push something i think is not ready i set workflow -1 on it, or if someone leaves feedback i intend to handle in another patchset on that change i set workflow -1 when acknowledging their comments | 18:51 |
| corvus | fungi: yep. i think that's the standard and we should continue to assume that. | 18:51 |
| avass | in contrast I push a lot since I usually switch between laptop/desktop/work computer | 18:52 |
| fungi | we might could do a better job of socializing that expectation. but i agree a lot of why things go unreviewed is taht i and others don't have a lot of time to devote to reviewing and i know i in particular rely on other folks to help me gauge relative reviewing priorities | 18:52 |
| corvus | avass: that's fine, and i don't want to discourage that. but they WIP method is sufficient -- i mean, people aren't accidentally approving your changes, so i don't think it's a problem. :) | 18:53 |
| *** smyers_ has joined #zuul | 18:55 | |
| *** smyers has quit IRC | 18:55 | |
| *** smyers_ is now known as smyers | 18:55 | |
| corvus | tobiash: keep in mind that the last 2 weeks have been summit/ptg/compromise. a number of us have had basically zero time for reviews during that time. i will have more time available this week, but not today. | 18:55 |
| corvus | clarkb, tobiash: i'm fairly strongly against auto-abandonment of old changes. i think it's fine to manually abandon them when they're not relevant, but there's no time limit on these things. it's also seen rather negatively by folks proposing those changes and is due to no fault of the authors. | 18:58 |
| clarkb | yup I mentioned that we have the ability to abandon them as we go | 18:58 |
| clarkb | might be worth doing a cleanup pass and abandon those we're sure are no longer relevant from the zuulv2 days | 18:59 |
| corvus | for instance, i'd love for someone to pick up work on https://review.opendev.org/541434 | 18:59 |
| fungi | also, the argument made was having unreviewed changes doesn't look welcoming to newcomers... it seems like having your change go unreviewed and then get abandoned would be far more unwelcoming | 19:00 |
| corvus | i subscribe to the second theory | 19:00 |
| avass | corvus: I'm planning on doing that one of those days I got time over :) | 19:02 |
| tobiash | corvus: I'm just thinking about possible improvements since my impression was that you were the only one with an advanced gertty based systematic review who also sees older changes when you had more time for reviews ;) | 19:04 |
| tobiash | I'm trying to do that as well but am currently in somewhat a mixed gertty/web mode | 19:04 |
| corvus | tobiash: clarkb may have tips for achieving similar efficiencies with the web client | 19:05 |
| corvus | you can probably bookmark some queries | 19:05 |
| clarkb | ya I use queries which sort newest to oldest | 19:05 |
| corvus | (filter out WIP/failing tests/etc to find 'most likely ready to merge') | 19:05 |
| clarkb | then you can get a feel for where the divide in stale and active is | 19:05 |
| tobiash | my current default query is this: https://review.opendev.org/#/dashboard/?title=Zuulv3&Outgoing%20reviews=owner:self%20status:open&Zuulv3%20open%20reviews=(projects:zuul)%20status:open%20limit:30&Starred=is:starred%20status:open&Zuulv3%20merged%20recently=(projects:zuul)%20limit:20%20status:merged | 19:06 |
| fungi | i'm not unsympathetic, i have roughly a hundred open changes of mine currently in opendev's gerrit, some of which have gone unreviewed since they were pushed in 2014 (and i'm really not that prolific of a developer) | 19:07 |
| corvus | i have a mere 78 open changes :) | 19:07 |
| fungi | looks like i'm at 83, close | 19:08 |
| clarkb | one thing I like to do is start with changes that already have a +2 from not me, to see if we can flush those out | 19:08 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: multi-node-bridge: update include to include_tasks https://review.opendev.org/730662 | 19:09 |
| tobiash | clarkb: I guess it's not possible to filter for those? | 19:09 |
| clarkb | tobiash: it is, but I never remember how. I should probably write it down | 19:09 |
| clarkb | you do can filter by +2s then also filter by not you iirc | 19:09 |
| fungi | and you can create hotkey to query mappings for stuff like that in gertty too, so could bind a "+2'd but not by me" dashboard to f6 for example | 19:10 |
| *** rlandy|brb is now known as rlandy | 19:14 | |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Add option to install kubernetes with kind https://review.opendev.org/740935 | 19:16 |
| * zbr finds a new opportunity to advertise his multi server gerrit query tool from https://pypi.org/project/gri/ | 19:16 | |
| avass | nimble job/role is ready by the way: https://review.opendev.org/#/c/747865/14 | 19:20 |
| avass | quick review to add Username to emit-job-header: https://review.opendev.org/#/c/760692/ | 19:21 |
| tobiash | avass: some reasoning in the nimble commit message would be awesome ;) | 19:24 |
| * tobiash goes googling what that is | 19:25 | |
| avass | tobiash: package manager, compiler and testools for nim-lang ;) | 19:27 |
| avass | tobiash: https://nim-lang.org/ | 19:28 |
| avass | I really like it so far | 19:29 |
| *** smyers has quit IRC | 19:34 | |
| *** smyers has joined #zuul | 19:34 | |
| openstackgerrit | Merged zuul/zuul master: Restore correct reason reporting of merge failures https://review.opendev.org/756063 | 19:35 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Add nimble roles and job https://review.opendev.org/747865 | 19:37 |
| tobiash | avass: I'll look at that tomorrow | 19:39 |
| avass | sure :) | 19:39 |
| *** vorotech has joined #zuul | 19:43 | |
| openstackgerrit | Merged zuul/zuul-jobs master: emit-job-header: Print username in node information https://review.opendev.org/760692 | 20:04 |
| *** persia has quit IRC | 20:08 | |
| *** persia has joined #zuul | 20:09 | |
| *** vorotech has quit IRC | 20:16 | |
| openstackgerrit | Merged zuul/zuul-jobs master: More E208 fixes https://review.opendev.org/760918 | 20:17 |
| *** tosky has joined #zuul | 20:27 | |
| *** hamalq has joined #zuul | 20:31 | |
| *** ikhan has quit IRC | 20:32 | |
| *** vorotech has joined #zuul | 20:42 | |
| *** rfolco has quit IRC | 20:46 | |
| *** rfolco has joined #zuul | 20:51 | |
| *** rfolco has quit IRC | 20:56 | |
| *** rfolco has joined #zuul | 21:06 | |
| *** saneax has quit IRC | 21:58 | |
| *** rfolco has quit IRC | 21:59 | |
| *** vorotech has quit IRC | 22:22 | |
| openstackgerrit | Merged zuul/zuul-jobs master: Allow bindep role to read from more then one bindep file https://review.opendev.org/759868 | 22:37 |
| *** armstrongs has joined #zuul | 23:19 | |
| *** hashar has quit IRC | 23:20 | |
| *** armstrongs has quit IRC | 23:29 | |
| openstackgerrit | Merged zuul/zuul master: Avoid ref parsing when creating heads https://review.opendev.org/757481 | 23:38 |
| *** smyers has quit IRC | 23:44 | |
| *** smyers has joined #zuul | 23:46 | |
| *** rlandy has quit IRC | 23:53 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!