| *** tosky has quit IRC | 00:06 | |
| *** hamalq has quit IRC | 00:18 | |
| *** armstrongs has joined #zuul | 00:30 | |
| mnaser | ok so i've progressed greatly, while i don't yet wanna mess around with manage-ansible stuff | 00:34 |
|---|---|---|
| mnaser | i have a pip install module call which succeds but then running my module fails (i moved this thing to an ansible module) | 00:35 |
| mnaser | http://paste.openstack.org/show/799495/ | 00:35 |
| mnaser | http://paste.openstack.org/show/799496/ | 00:36 |
| *** armstrongs has quit IRC | 00:40 | |
| *** mach1na has joined #zuul | 00:51 | |
| *** mach1na has quit IRC | 00:56 | |
| mnaser | > Defaulting to user installation because normal site-packages is not writeable | 00:56 |
| openstackgerrit | Mohammed Naser proposed zuul/zuul master: tools: use python3 for encrypt_secret https://review.opendev.org/760266 | 01:11 |
| *** jamesmcarthur has joined #zuul | 01:32 | |
| *** jamesmcarthur has quit IRC | 01:33 | |
| *** jamesmcarthur has joined #zuul | 01:33 | |
| *** zenkuro has quit IRC | 01:39 | |
| *** zenkuro has joined #zuul | 01:40 | |
| *** johnsom has quit IRC | 02:00 | |
| *** rpittau|afk has quit IRC | 02:00 | |
| *** ericsysmin has quit IRC | 02:00 | |
| *** maxamillion has quit IRC | 02:00 | |
| *** rpittau|afk has joined #zuul | 02:00 | |
| *** ericsysmin has joined #zuul | 02:01 | |
| *** johnsom has joined #zuul | 02:01 | |
| *** maxamillion has joined #zuul | 02:02 | |
| *** jamesmcarthur has quit IRC | 02:21 | |
| *** zenkuro has quit IRC | 02:32 | |
| *** jamesmcarthur has joined #zuul | 02:47 | |
| *** jamesmcarthur has quit IRC | 02:56 | |
| *** jamesmcarthur has joined #zuul | 02:56 | |
| *** mach1na has joined #zuul | 02:59 | |
| *** mach1na has quit IRC | 03:03 | |
| *** bhavikdbavishi has joined #zuul | 03:07 | |
| *** bhavikdbavishi1 has joined #zuul | 03:15 | |
| *** bhavikdbavishi has quit IRC | 03:17 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 03:17 | |
| *** rlandy|bbl is now known as rlandy | 03:20 | |
| *** jamesmcarthur has quit IRC | 04:12 | |
| *** vishalmanchanda has joined #zuul | 04:25 | |
| *** bhavikdbavishi has quit IRC | 04:25 | |
| *** bhavikdbavishi has joined #zuul | 04:26 | |
| *** mach1na has joined #zuul | 05:07 | |
| *** mach1na has quit IRC | 05:11 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #zuul | 05:33 | |
| *** reiterative has quit IRC | 05:44 | |
| *** reiterative has joined #zuul | 05:44 | |
| *** piotrowskim has joined #zuul | 05:52 | |
| *** mach1na has joined #zuul | 06:46 | |
| *** sshnaidm|afk is now known as sshnaidm|rover | 07:01 | |
| *** EmilienM has quit IRC | 07:16 | |
| *** mach1na has quit IRC | 07:18 | |
| *** mach1na has joined #zuul | 07:18 | |
| *** saneax has joined #zuul | 07:23 | |
| *** bhavikdbavishi has quit IRC | 07:25 | |
| *** jpena|off is now known as jpena | 07:45 | |
| *** pmannidi has quit IRC | 07:47 | |
| *** pmannidi has joined #zuul | 07:52 | |
| *** bhavikdbavishi has joined #zuul | 07:58 | |
| *** jcapitao has joined #zuul | 08:02 | |
| *** yolanda has quit IRC | 08:24 | |
| *** yolanda has joined #zuul | 08:25 | |
| *** sugaar has joined #zuul | 08:33 | |
| *** rpittau|afk is now known as rpittau | 08:40 | |
| *** AJaeger has quit IRC | 08:42 | |
| *** tosky has joined #zuul | 08:51 | |
| *** msuszko has joined #zuul | 08:54 | |
| msuszko | Hi, I've noticed Zuul will ignore commits that are just `git merge --no-ff`. Because of this gate won't start, or configuration won't be read from zuul.yaml for soch a change. | 09:04 |
| msuszko | Reason seems to be `no_merges=True` argument here: https://opendev.org/zuul/zuul/src/branch/master/zuul/merger/merger.py#L668 | 09:04 |
| msuszko | s/soch/such/ | 09:05 |
| *** vorotech has joined #zuul | 09:22 | |
| *** vorotech has quit IRC | 09:26 | |
| *** zenkuro has joined #zuul | 09:26 | |
| *** zenkuro has quit IRC | 09:30 | |
| *** vorotech has joined #zuul | 09:32 | |
| *** vorotech has quit IRC | 09:45 | |
| *** nilsph has joined #zuul | 09:47 | |
| *** vorotech has joined #zuul | 09:50 | |
| *** bhavikdbavishi has quit IRC | 10:00 | |
| *** hashar has joined #zuul | 10:07 | |
| *** holser has joined #zuul | 10:07 | |
| *** msuszko has quit IRC | 10:16 | |
| *** bhavikdbavishi has joined #zuul | 10:29 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: zuul-client: test change-status command https://review.opendev.org/759840 | 10:49 |
| *** wuchunyang has joined #zuul | 11:14 | |
| *** msuszko has joined #zuul | 11:22 | |
| *** jcapitao is now known as jcapitao_lunch | 11:39 | |
| *** zenkuro has joined #zuul | 11:45 | |
| *** msuszko has quit IRC | 11:45 | |
| *** nilsph is now known as nils | 11:49 | |
| *** vorotech has quit IRC | 11:51 | |
| *** wuchunyang has quit IRC | 12:03 | |
| *** rfolco has joined #zuul | 12:08 | |
| *** jpena is now known as jpena|lunch | 12:19 | |
| *** mach1na has quit IRC | 12:23 | |
| *** ianychoi__ is now known as ianychoi | 12:34 | |
| *** zenkuro has quit IRC | 12:45 | |
| *** jcapitao_lunch is now known as jcapitao | 12:51 | |
| sean-k-mooney | so dumb qustionion but any idea why https://github.com/SeanMooney/ci-sean-mooney/blob/main/zuul.d/pipelines.yaml#L2-L39 would reprot only the started message and not success or failure | 12:56 |
| sean-k-mooney | https://review.opendev.org/#/c/750008/ has the "Starting seans-nfv-ci jobs." comments after i trigger it | 12:58 |
| avass | sean-k-mooney: you're trying to set Code-Review.org :) | 12:58 |
| avass | instead of of Code-Review | 12:58 |
| sean-k-mooney | oh damit | 12:58 |
| sean-k-mooney | thank you :) | 12:58 |
| *** mach1na has joined #zuul | 12:59 | |
| *** vorotech has joined #zuul | 13:01 | |
| *** jpena|lunch is now known as jpena | 13:13 | |
| *** bhavikdbavishi has quit IRC | 13:14 | |
| *** bhavikdbavishi has joined #zuul | 13:14 | |
| mnaser | so after a long night, i got this working. it'll check for CODEOWNERS inside the repository, parse that and then add folks in there. if it sees a /lgtm comment it'll mark as 'reviewed' (but the `vexxhost/lgtm` pipeline still fails), if it gets a `/approve` (similar to work +W), it will update the comment too and the pipeline will pass (which is the trigger to enqueue into gate) | 13:34 |
| mnaser | https://usercontent.irccloud-cdn.com/file/UsCjyGDm/image.png | 13:34 |
| mnaser | and it takes around 14 seconds to respond, because it uses a zero node execution action | 13:34 |
| mnaser | so its pretty much mirroring out gerrit system where anyone inside CODEOWNERS can merge | 13:35 |
| mnaser | and allows for self-reviewal too in a super native and easy way | 13:35 |
| mnaser | if there is interest, i can push up the `lgtm` role, and all users need to do is create a pipeline that listens for comments/prs and triggers it | 13:36 |
| corvus | mnaser: that sounds great to me; tobiash ^ | 13:39 |
| mnaser | the only thing that it's kinda lacking is an 'undo' for a lgtm right now, if you delete the comment and write a comment it will trigger it, it looks like we can't trigger on a 'comment deleted' inside github rn | 13:40 |
| corvus | so you can undo by deleting the comment and leaving "/undo" for clarity i guess? | 13:41 |
| corvus | maybe that's not clear. maybe leave "removed previous lgtm comment" or something | 13:41 |
| mnaser | corvus: yes, that would be the 'current' workflow right now indeed | 13:51 |
| mnaser | github usually leaves a 'comment deleted' trace in the messages so that could make sense | 13:51 |
| tobiash | mnaser: so if I understand correctly that's mainly for making self-review possible? | 13:53 |
| mnaser | tobiash: correct | 13:53 |
| tobiash | k, I guess that'll be generally usefull | 13:54 |
| mnaser | tobiash: and also allowing for both a 'review' and 'approval' (i.e. code-review+2 and workflow+1) | 13:54 |
| mnaser | and also uses CODEOWNERS inside the repo to determine who can review/approve things too | 13:54 |
| tobiash | so if you want to restrict triggering the gate to codeowners as well | 13:55 |
| mnaser | yep, it actually entirely ignores the github acls and relies on codeowners only (so the person that leaves the `/lgtm` doesnt need any right, as long as they are inside CODEOWNERS) | 13:55 |
| *** bhavikdbavishi has quit IRC | 14:03 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Move the testing framework under zuul https://review.opendev.org/760361 | 14:11 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Move functional tests to zuul-client https://review.opendev.org/760363 | 14:22 |
| *** zenkuro has joined #zuul | 14:23 | |
| *** vishalmanchanda has quit IRC | 14:24 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Move functional tests to zuul-client https://review.opendev.org/760363 | 14:34 |
| *** evrardjp has quit IRC | 14:38 | |
| *** evrardjp has joined #zuul | 14:40 | |
| *** hamalq has joined #zuul | 14:41 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Move the testing framework under zuul https://review.opendev.org/760361 | 14:47 |
| *** zenkuro has quit IRC | 14:47 | |
| *** zenkuro has joined #zuul | 14:48 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Move the testing framework under zuul https://review.opendev.org/760361 | 14:51 |
| tobiash | corvus: we've been hit by an api limitation when reporting line comments to github: https://developer.github.com/v3/checks/runs/#output-object-1 | 15:09 |
| tobiash | github enforces max 50 line comments per PATCH request to the check run | 15:09 |
| tobiash | corvus: would you prefer to iterate over all line comments or just limit to 50 in zuul and ignore any further line comments? | 15:10 |
| tobiash | iterating would probably make zuul vulnerable for dos attacks as this can block reporting quite a while in extreme cases | 15:11 |
| clarkb | tobiash: if possible it might be good to sort them by uniqueness so that we're reporting the most diverse set of comments possible | 15:12 |
| tobiash | clarkb: how would you judge on that? | 15:12 |
| clarkb | if we have the comment content without filename and line numbers we may be able to put them in a set then pull out 50? | 15:13 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Move the testing framework under zuul https://review.opendev.org/760361 | 15:17 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Move the testing framework under zuul https://review.opendev.org/760361 | 15:18 |
| *** jamesmcarthur has joined #zuul | 15:22 | |
| *** jamesmcarthur has quit IRC | 15:23 | |
| *** jamesmcarthur has joined #zuul | 15:29 | |
| *** vorotech has quit IRC | 15:33 | |
| *** jamesmcarthur has quit IRC | 15:33 | |
| mnaser | tobiash: before i go deep into debuigging, any reason off the top of your mind why this is not queueing into gate? is it possible that a status _change_ doesn't actually trigger an event? https://www.irccloud.com/pastebin/rpBIk5i1/ | 15:34 |
| tobiash | mnaser: that looks ok, but are you using status or check runs for reporting? | 15:35 |
| tobiash | a status change always triggers an event | 15:35 |
| *** zenkuro has quit IRC | 15:36 | |
| mnaser | tobiash: i am using check for everything, so maybe that's where i messed up | 15:36 |
| tobiash | mnaser: I mean status api vs check_run api | 15:36 |
| tobiash | oh never mind | 15:36 |
| mnaser | my "lgtm" pipeline https://www.irccloud.com/pastebin/wkbeRE5z/ | 15:36 |
| mhu | hey there zuul-maint, here are a few patches that are ready for a final +3: https://review.opendev.org/#/c/728118/ https://review.opendev.org/#/c/751312/ https://review.opendev.org/#/c/754103/ https://review.opendev.org/#/c/755519/ | 15:36 |
| tobiash | mnaser: so yes, your pipeline reports a check_run but your trigger wants a status event | 15:37 |
| tobiash | mnaser: just a sec, I'll give you the according check run trigger | 15:37 |
| mnaser | ok so i want to listen on `check_run` then | 15:37 |
| tobiash | http://paste.openstack.org/show/799515/ | 15:38 |
| *** jamesmcarthur has joined #zuul | 15:38 | |
| tobiash | mnaser: note that the requirement stays at status: https://zuul-ci.org/docs/zuul/reference/drivers/github.html#attr-pipeline.require.%3Cgithub%20source%3E.status | 15:40 |
| tobiash | mnaser: that's because github doesn't distinguish that in the branch protection but it does in the events | 15:40 |
| tobiash | so zuul is aligned to that behavior | 15:40 |
| *** rfolco is now known as rfolco|bbl | 15:41 | |
| tobiash | mnaser: however you probably want the gate to listen to status AND check_run success triggers | 15:41 |
| tobiash | mnaser: this way it will interoperate nicely with any other github app regardless if it uses check runs or status api | 15:41 |
| corvus | tobiash: i agree that we should limit to 50 and not iterate; i also think it's worth thinking about implementing clarkb's suggestion of aiming for uniqueness; that could help users who have 100 "tabs not spaces" comments and 5 more other useful comments. | 15:42 |
| tobiash | (e.g. all of our projects use the wip bot) | 15:42 |
| mnaser | tobiash: so i think this might do it? https://www.irccloud.com/pastebin/M5gShKz7/ | 15:43 |
| tobiash | mnaser: you probably want only trigger on success check runs? | 15:43 |
| mnaser | tobiash: can i use `status` for `check_run` -- doesn't seem documented? | 15:44 |
| *** olaph has quit IRC | 15:44 | |
| tobiash | ? | 15:44 |
| mnaser | if i want to trigger on success check runs only, im not sure i have a way to do that | 15:45 |
| tobiash | just add: "check: .*:success" to the trigger | 15:45 |
| mnaser | https://zuul-ci.org/docs/zuul/reference/drivers/github.html#attr-pipeline.trigger.%3Cgithub%20source%3E.status => "This is used for pull-request and status actions." | 15:45 |
| mnaser | ok so i think we may need to document the `check` option on triggers then :D | 15:45 |
| tobiash | mnaser: this will be the your gate pipeline right? | 15:47 |
| mnaser | tobiash: correct | 15:47 |
| mnaser | technically i can even put the trigger only to be ".*/lgtm:success" | 15:47 |
| mnaser | cause i don't really ever want to enqueue otherwise | 15:47 |
| *** holser has quit IRC | 15:48 | |
| tobiash | mnaser: well that makes approve impossible before check is done | 15:48 |
| tobiash | mnaser: I'd do this: http://paste.openstack.org/show/799519/ | 15:48 |
| *** holser has joined #zuul | 15:48 | |
| tobiash | (ditch the requirement) | 15:48 |
| tobiash | any status/check requirement should be done in the branch protection | 15:49 |
| tobiash | zuul will respect that automatically | 15:49 |
| mnaser | tobiash: ok so put the lgtm protection inside github instead | 15:49 |
| tobiash | yes | 15:49 |
| tobiash | then you can just add any trigger and zuul will do the right thing and enter the gate regardless which event comes first | 15:50 |
| tobiash | that is a very flexible approach, like we also require WIP from the wip bot in the branch protection | 15:51 |
| tobiash | (and current zuul master now also handles review requirements in github correctly) | 15:53 |
| *** vorotech has joined #zuul | 15:59 | |
| *** hashar has quit IRC | 15:59 | |
| *** hashar has joined #zuul | 15:59 | |
| *** hashar_ has joined #zuul | 16:04 | |
| *** hashar has quit IRC | 16:04 | |
| mhu | How is Ansible 2.9 installed in Zuul unit tests? | 16:08 |
| clarkb | mhu: I think it uses zuul's ansible install tooling stuff | 16:10 |
| corvus | mhu: ^ yep; the executor installs ansible into the containing venv (ie, the tox pyXX venv) | 16:11 |
| corvus | so it's cached for subsequent tox runs | 16:11 |
| *** hashar_ is now known as hashar | 16:24 | |
| *** hashar has quit IRC | 16:25 | |
| *** hashar has joined #zuul | 16:25 | |
| *** mach1na has quit IRC | 16:32 | |
| *** jpena is now known as jpena|off | 16:54 | |
| *** mwhahaha has quit IRC | 16:55 | |
| *** mwhahaha has joined #zuul | 16:55 | |
| *** rpittau is now known as rpittau|afk | 16:57 | |
| *** rfolco|bbl is now known as rfolco | 17:01 | |
| *** hamalq has quit IRC | 17:13 | |
| *** hamalq has joined #zuul | 17:14 | |
| mhu | corvus: so I should look into zuul's tox.ini? | 17:18 |
| corvus | mhu: no it happens inside of zuul when the first test runs | 17:18 |
| *** jcapitao has quit IRC | 17:29 | |
| *** zenkuro has joined #zuul | 17:44 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Move the testing framework under zuul https://review.opendev.org/760361 | 17:46 |
| *** vorotech has quit IRC | 17:46 | |
| mnaser | tobiash: promise that'll be the last question -- you don't by any chance let zuul delete the branch after the merge? | 17:55 |
| *** hashar has quit IRC | 18:04 | |
| *** vorotech has joined #zuul | 18:08 | |
| *** vorotech has quit IRC | 18:10 | |
| *** tosky has quit IRC | 18:29 | |
| *** piotrowskim has quit IRC | 18:43 | |
| *** jamesmcarthur has quit IRC | 18:44 | |
| tobiash | mnaser: there are two possibilities | 18:59 |
| tobiash | first, github can delete branches after merge automatically (that's a setting of the repo) | 18:59 |
| tobiash | second there is a github app that can automate this as well: https://github.com/apps/baumpfleger | 19:00 |
| mnaser | tobiash: oh i didn't know about the auto delete | 19:02 |
| * mnaser looks for that | 19:02 | |
| mnaser | >Automatically delete head branches indeed | 19:03 |
| tobiash | mnaser: that is a new feature that has been introduced 6 to 12 months ago | 19:03 |
| tobiash | Before that we used the baumpfleger app | 19:03 |
| *** zenkuro has quit IRC | 19:04 | |
| *** zenkuro has joined #zuul | 19:04 | |
| *** pabelanger has joined #zuul | 19:07 | |
| pabelanger | mnaser: I hear you are working on self approvals in github | 19:07 |
| pabelanger | I am very much interested in that | 19:07 |
| pabelanger | that is basically one of the last things to drop write access to a github repo too | 19:07 |
| *** zenkuro has quit IRC | 19:13 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Move the testing framework under zuul https://review.opendev.org/760361 | 19:19 |
| *** zenkuro has joined #zuul | 19:21 | |
| *** jamesmcarthur has joined #zuul | 19:29 | |
| *** zenkuro has quit IRC | 19:31 | |
| *** vorotech has joined #zuul | 20:27 | |
| *** jamesmcarthur has quit IRC | 20:38 | |
| *** jamesmcarthur has joined #zuul | 20:38 | |
| openstackgerrit | Albin Vass proposed zuul/zuul master: Bump react version https://review.opendev.org/760458 | 21:00 |
| *** vorotech has quit IRC | 21:03 | |
| *** rfolco has quit IRC | 21:36 | |
| *** sduthil has quit IRC | 21:46 | |
| *** tosky has joined #zuul | 21:57 | |
| *** rlandy has quit IRC | 22:12 | |
| *** jamesmcarthur has quit IRC | 22:19 | |
| *** jamesmcarthur has joined #zuul | 22:20 | |
| *** jamesmcarthur has quit IRC | 22:25 | |
| avass | looks like we can bump react version to 17 without any problems. there are warnings about peer dependencies but since react 17 doesn't add any new features I'm not sure if that's any real problem. | 22:26 |
| *** jamesmcarthur has joined #zuul | 22:28 | |
| *** vorotech has joined #zuul | 22:31 | |
| *** vorotech has quit IRC | 22:38 | |
| *** vorotech has joined #zuul | 22:40 | |
| *** jamesmcarthur has quit IRC | 22:41 | |
| *** jamesmcarthur has joined #zuul | 22:42 | |
| *** jamesmcarthur has quit IRC | 22:46 | |
| *** vorotech has quit IRC | 22:49 | |
| *** hamalq has quit IRC | 22:57 | |
| *** nils has quit IRC | 23:01 | |
| *** zenkuro has joined #zuul | 23:14 | |
| *** zenkuro has quit IRC | 23:19 | |
| *** zenkuro has joined #zuul | 23:20 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!
