| *** rlandy has quit IRC | 00:35 | |
| *** ianychoi__ is now known as ianychoi | 00:44 | |
| *** armstrongs has quit IRC | 00:51 | |
| ianw | anyone seen a blank task installing packages, particularly on fedora? | 00:53 |
|---|---|---|
| ianw | it's an odd one | 00:53 |
| ianw | https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/ensure-haskell-stack/tasks/main.yaml#L21 | 00:54 |
| ianw | is blank in https://522d8c65037ee2f8378e-e8ad39bee4b03d74ca06a7b7508191a6.ssl.cf1.rackcdn.com/751975/1/check/zuul-jobs-test-haskell-stack-test/4c38975/job-output.json | 00:55 |
| ianw | "hosts": {}, | 00:55 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: Retire Fedora 31 for 32 https://review.opendev.org/751975 | 01:31 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: only run docker-setup.yaml when installed https://review.opendev.org/747062 | 01:31 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json https://review.opendev.org/746834 | 01:31 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 01:31 |
| *** armstrongs has joined #zuul | 01:35 | |
| armstrongs | Hi quick question. I am running a zuul job having created a PR on gthub branch and in the cloned project I am running git rev-parse --abbrev-ref HEAD as i want to get the branch I am on. However it is returning master rather than the branch. Any ideas why this is happening? How would i retrieve the branch name for current branch if not using this | 01:37 |
| armstrongs | command. | 01:37 |
| *** zenkuro has quit IRC | 01:58 | |
| *** armstrongs has quit IRC | 02:07 | |
| *** wuchunyang has joined #zuul | 02:13 | |
| ianw | noonedeadpunk / fungi: https://review.opendev.org/#/c/751975/ fixes up fedora 32 for zuul-jobs now; should be gtg to get rid of f31 | 02:16 |
| *** saneax has joined #zuul | 03:03 | |
| *** sanjayu_ has joined #zuul | 03:05 | |
| *** sanjayu_ has quit IRC | 03:07 | |
| *** saneax has quit IRC | 03:07 | |
| *** sanjayu_ has joined #zuul | 03:07 | |
| *** sanjayu__ has joined #zuul | 03:09 | |
| *** sanjayu_ has quit IRC | 03:12 | |
| *** sanjayu__ has quit IRC | 03:30 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-kubernetes: workaround slow account creation https://review.opendev.org/752184 | 03:52 |
| *** bhavikdbavishi has joined #zuul | 03:55 | |
| *** wuchunyang has quit IRC | 04:09 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-kubernetes: workaround slow account creation https://review.opendev.org/752184 | 04:11 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: Retire Fedora 31 for 32 https://review.opendev.org/751975 | 04:11 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: only run docker-setup.yaml when installed https://review.opendev.org/747062 | 04:11 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json https://review.opendev.org/746834 | 04:11 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 04:11 |
| *** sanjayu__ has joined #zuul | 04:11 | |
| *** sanjayu_ has joined #zuul | 04:13 | |
| *** sanjayu__ has quit IRC | 04:16 | |
| *** wuchunyang has joined #zuul | 04:18 | |
| *** bhavikdbavishi has quit IRC | 04:19 | |
| *** wuchunyang has quit IRC | 04:23 | |
| *** sanjayu_ has quit IRC | 04:25 | |
| *** sanjayu_ has joined #zuul | 04:26 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 04:59 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 05:42 |
| felixedel | corvus: Regarding the scrolling: To be honest I'm totally confused by now what you want to have in the end. So now we go for the div-scrolling in the LogFile page solution, right? I don't mind, I just went for the pre-wrap because I had in mind that you said the page is totally unusable with div-scrollig because you have to scroll to the bottom first to access the scrollbar. I don't mind either solution, so I will | 05:43 |
| felixedel | adapt the "wrap" change and enable div-scrolling for the logs tab. That's just a single line of code, so we should be fine with that. Would the stack around these changes be ready then once in this is done? | 05:43 |
| *** mach1na has joined #zuul | 05:46 | |
| *** mach1na has quit IRC | 05:57 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: UI: Enable horizontal scrolling on LogFile page https://review.opendev.org/750875 | 06:10 |
| felixedel | corvus: https://review.opendev.org/#/c/750875/ does now enable the honrizontal div-scrolling for the LogFile tab rather than wrapping the lines | 06:11 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Save superfluous api requests in check run reporting https://review.opendev.org/752079 | 06:15 |
| *** mach1na has joined #zuul | 06:20 | |
| *** mach1na has quit IRC | 06:38 | |
| *** vishalmanchanda has joined #zuul | 06:40 | |
| *** sanjayu_ has quit IRC | 06:48 | |
| *** sanjayu__ has joined #zuul | 06:48 | |
| *** jcapitao has joined #zuul | 06:49 | |
| *** mach1na has joined #zuul | 07:02 | |
| *** hashar has joined #zuul | 07:07 | |
| zbr | corvus: i am also confused by your -W on felixedel changes, especially as it is quite vague: "I'd like to hold this stack until the whole thing is ready." | 07:07 |
| zbr | the pile of changes is growing and i stopped working on other zuul changes several weeks ago, mainly because i wanted to allow pf4 changes to settle | 07:08 |
| openstackgerrit | Tobias Henkel proposed zuul/zuul master: Make revising node requests asynchronous https://review.opendev.org/752194 | 07:31 |
| *** tosky has joined #zuul | 07:43 | |
| *** guillaumec has quit IRC | 07:51 | |
| *** guillaumec has joined #zuul | 07:52 | |
| *** jpena|off is now known as jpena | 07:54 | |
| *** nils has joined #zuul | 08:05 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 08:10 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Scheduler's pause/resume functionality https://review.opendev.org/709735 | 08:11 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Separate connection registries in tests https://review.opendev.org/712958 | 08:11 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler https://review.opendev.org/717269 | 08:11 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests https://review.opendev.org/721254 | 08:11 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Driver event ingestion https://review.opendev.org/717299 | 08:11 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/716221 | 08:12 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper https://review.opendev.org/716875 | 08:12 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper https://review.opendev.org/716262 | 08:12 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 08:12 |
| *** yolanda has quit IRC | 08:22 | |
| *** yolanda has joined #zuul | 08:22 | |
| *** mach1na has quit IRC | 08:37 | |
| *** mach1na has joined #zuul | 08:37 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json https://review.opendev.org/746834 | 08:59 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround https://review.opendev.org/747063 | 08:59 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Fix branch name and project name for ref-updated create/delete https://review.opendev.org/738320 | 09:20 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Update tests/base.py to use proper git data https://review.opendev.org/742746 | 09:20 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Add tests https://review.opendev.org/742747 | 09:20 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Reorg scheduler event process loop https://review.opendev.org/742748 | 09:20 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Scheduler ref-updated create/delete https://review.opendev.org/739198 | 09:20 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Allow ref-updated newrev+oldrev reconfiguration https://review.opendev.org/742749 | 09:20 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Tenant reconfiguration: Get ref-updated modified files https://review.opendev.org/739078 | 09:20 |
| zbr | ianw: are you around? maybe you can help fixing the js identation, like https://review.opendev.org/#/c/749702/ | 09:29 |
| openstackgerrit | Pierre-Louis Bonicoli proposed zuul/zuul master: [gitlab] approvals: fix error with community edition https://review.opendev.org/750546 | 09:34 |
| *** hashar has quit IRC | 09:51 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers) https://review.opendev.org/744416 | 10:06 |
| *** tflink has quit IRC | 10:15 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [wip] Add zuul-client testing https://review.opendev.org/752039 | 10:20 |
| *** tflink has joined #zuul | 10:21 | |
| *** jcapitao is now known as jcapitao_lunch | 10:28 | |
| *** wuchunyang has joined #zuul | 10:29 | |
| *** wuchunyang has quit IRC | 10:32 | |
| openstackgerrit | zbr proposed zuul/zuul-jobs master: Partial address ansible-lint E208 https://review.opendev.org/748480 | 10:36 |
| *** zenkuro has joined #zuul | 10:37 | |
| mhu | fungi: about zuul/zuul-client cross testing, so it turns out I needed to explicitly declare zuul-client as a required-project for the tox jobs. That means that unless the depends-on is on a required project, the tox siblings script won't consider it | 10:38 |
| mhu | is that intended? | 10:38 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client to requirements https://review.opendev.org/752043 | 10:40 |
| openstackgerrit | zbr proposed zuul/zuul-jobs master: Add mode to packer https://review.opendev.org/752213 | 10:50 |
| openstackgerrit | Pierre-Louis Bonicoli proposed zuul/zuul master: [gitlab] approvals: fix error with community edition https://review.opendev.org/750546 | 10:51 |
| *** mach1na has quit IRC | 11:14 | |
| *** jpena is now known as jpena|lunch | 11:25 | |
| *** rfolco has joined #zuul | 11:36 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul-jobs master: ensure-haskell-stack: ensure all requirements are installed https://review.opendev.org/752225 | 12:00 |
| *** mach1na has joined #zuul | 12:00 | |
| *** mach1na has quit IRC | 12:04 | |
| *** mach1na has joined #zuul | 12:05 | |
| *** jcapitao_lunch is now known as jcapitao | 12:05 | |
| openstackgerrit | Pierre-Louis Bonicoli proposed zuul/zuul master: [gitlab] approvals: fix error with community edition https://review.opendev.org/750546 | 12:11 |
| *** Goneri has joined #zuul | 12:13 | |
| *** rlandy has joined #zuul | 12:20 | |
| *** jpena|lunch is now known as jpena | 12:28 | |
| tobiash | mhu: yes I think that was intended at that time | 12:33 |
| tobiash | but I don't recall the reasoning | 12:34 |
| mhu | tobiash, I guess it prevents injecting libraries out of nowhere | 12:40 |
| tobiash | probably | 12:40 |
| fungi | mhu: tobiash: yes, its so that jobs have some guaranteed stable expectations. if the job which normally tested with released dependencies suddenly allowed a change to merge which could only be satisfied in the dependency's unreleased state because there was a depends-on in the commit message, that could quite easily break the software being tested | 12:46 |
| fungi | so a job which is going to use zuul's speculative source state for some dependency should also use that dependency's branch tip under normal circumstances when there's no depends-on or related changes ahead in a dependent pipeline | 12:48 |
| fungi | having the same job switch at random between released and unreleased dependency states would be untenable | 12:48 |
| fungi | that's why i suggested your experimental job should declare zuul-client as a project-requires. it needs to be part of the job, either directly or via a job variant declaration | 12:50 |
| *** rfolco is now known as rfolco|ruck | 12:52 | |
| mhu | fungi, yeah now I understand, I thought the depends-on was enough | 12:58 |
| *** vishalmanchanda has quit IRC | 13:04 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [wip] Add zuul-client testing https://review.opendev.org/752039 | 13:12 |
| openstackgerrit | Fabien Boucher proposed zuul/zuul master: URLTrigger driver time based https://review.opendev.org/635567 | 13:31 |
| *** sshnaidm is now known as sshnaidm|afk | 13:32 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [wip] Add zuul-client testing https://review.opendev.org/752039 | 13:43 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul-client master: Fix integration with Zuul before release https://review.opendev.org/751291 | 13:43 |
| corvus | zbr: the w-1 was due to the negative review at the other end of the stack; sounds like felixedel addressed it, so we may be able to merge it today. | 13:47 |
| zbr | corvus: that is supper | 13:47 |
| zbr | i am bit worried about the chain size growing too much. | 13:48 |
| zbr | i want to avoid having to merge a huge pile in a short period of time, better to make these changes gradually so we have time to fix problems | 13:49 |
| corvus | zbr: fwiw, long change series don't bother me, or many other reviewers | 13:49 |
| corvus | zbr: we're seeing changes in one area "break" another, so in that case it makes sense to make sure everything is settled in review before merging | 13:50 |
| zbr | but all these changes are blocking/conflicting with other UI related changes | 13:50 |
| corvus | zbr: it's not required, but if you want, you can rebase other changes on these | 13:50 |
| corvus | (the effect will be the same whether these changes are merged or not) | 13:51 |
| zbr | that was my plan, but I due to the number of changes made to them, and the reverts, it takes too much effort. | 13:51 |
| *** rfolco|ruck is now known as rfolco|ruck|brb | 13:51 | |
| zbr | thus is why i wait for some of these to go in, so i can rework my own ones. | 13:52 |
| corvus | zbr: that would all be true whether these changes are merged or not. so while it may seem like asking for us to merge these quickly would solve the problem, it won't. what would really help you is to complete the pf4 effort quickly so the code base stops changing. i suspect that everyone working on it is already doing so as quickly as time permits. | 13:53 |
| zbr | corvus: sure. i was not trying to press for a quick merge, especially as the pf4 already got us enough problems. | 14:08 |
| felixedel | corvus: Thanks for reviewing those changes. I hope that we can close this whole scroll-issue topic once they are merged. | 14:11 |
| corvus | felixedel: well, after that we get zbr's user-toggle :) | 14:11 |
| corvus | but maybe then we can put it all behind us :) | 14:11 |
| zbr | if i understood correctly, my toggle is not blocking that change. happy to rebase it after. | 14:12 |
| zbr | corvus: fungi: maybe you can help withhttps://review.opendev.org/#/c/751975/ -- switch from fedora 31 to 32 for zuul-jobs. | 14:14 |
| felixedel | Just as a side note: I don't like the sound of those last messages which make the impression that PF4 is providing more problems that in solves. IMHO the new UI will bring a big benefit to Zuul and the community. At least from our uses I know that they would like Zuul a lot better if the UI would provide more features and would be more attractive/modern. I already have other changes ready for review https://review. | 14:14 |
| felixedel | opendev.org/#/c/746112/9 since a few weeks, but also for me it becomes more and more difficult to always stack changes on top if I don't know if the changes at the bottom of the stack will be accepted in the end or not. In the latter case it just brings up a lot of discussion about a lot of (partly unrelated) changes and also a lot of rebase-work | 14:14 |
| felixedel | *users | 14:14 |
| corvus | felixedel: i'm not sure what messages you are referring to or whether they were from me, but for my part i appreciate your work and understand its importance. | 14:15 |
| felixedel | > what would really help you is to complete the pf4 effort quickly so the code base stops changing | 14:16 |
| felixedel | But maybe I got that message wrong due to zbr's answer | 14:16 |
| felixedel | > especially as the pf4 already got us enough problems | 14:16 |
| corvus | felixedel: i said the first thing, and by that i meant that zbr was asking for the same thing you are, for the pf4 effort to be complete so he can stop rebasing changes. there was no judgement about quality there. i didn't say the second thing. i'll let zbr speak for himself. | 14:18 |
| zbr | felixedel: believe me that PF4 is great and I want to see it sooner than later. I see the problems as an assumed risk, IMHO we should have not done the reverts but it was mostly a bad timing (vacation), i guess. | 14:18 |
| corvus | zbr: we revert changes when we discover problems with them we didn't catch in review | 14:18 |
| corvus | zbr: we have done that frequently and we will do it again. it's not personal, it's just the nature of a CD system. | 14:19 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client testing https://review.opendev.org/752039 | 14:19 |
| corvus | doing that allowed us to re-stage the changes on top of a revert-revert, then fix each of the problems we observed, and verify that everything behaved as expected before merging. | 14:21 |
| zbr | corvus: i know is not perosnal/. Stiil you can understand why i am reluctant to rebase my changes now, all of them are around pf4 areas, mainly I would have rewrite them multiple times. | 14:21 |
| corvus | and while that was going on, users were still able to use the system. the problems we missed in review were severe enough that they affected users, and it took us quite a while to fix them (especially since this is a complex network and changing one thing can affect others) | 14:22 |
| corvus | zbr: that's fine, and that's your choice. at no point were you prevented from continuing work. you can always rebase your changes on the tip of the stack. i understand that it's work, and you would prefer not to. speeding up the merging process doesn't change that. it only means that you have to keep rebasing on master rather than un-merged changes. like i said earlier, the only thing that would | 14:24 |
| corvus | materially affect your work would be if we all just worked faster and better and got all of this done sooner. | 14:24 |
| corvus | zbr: but i think we are already working as fast and good as we can | 14:24 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Add zuul-client to requirements https://review.opendev.org/752043 | 14:29 |
| *** fdegir has quit IRC | 14:36 | |
| openstackgerrit | Pierre-Louis Bonicoli proposed zuul/zuul master: [gitlab] approvals: fix error with community edition https://review.opendev.org/750546 | 14:43 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] Add zuul-client to requirements https://review.opendev.org/752043 | 14:45 |
| *** vishalmanchanda has joined #zuul | 14:58 | |
| openstackgerrit | Merged zuul/zuul master: Revert "web: restore scrollbars and scroll behaviour" https://review.opendev.org/750361 | 15:05 |
| openstackgerrit | Merged zuul/zuul master: Revert "Revert PF4 build page" https://review.opendev.org/750365 | 15:05 |
| openstackgerrit | Merged zuul/zuul master: Use Modal to show config errors and fix scrolling https://review.opendev.org/750322 | 15:05 |
| openstackgerrit | Merged zuul/zuul master: web: Fix error modal contents https://review.opendev.org/744095 | 15:06 |
| openstackgerrit | Merged zuul/zuul master: UI: Enable horizontal scrolling on LogFile page https://review.opendev.org/750875 | 15:07 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] Add zuul-client to requirements https://review.opendev.org/752043 | 15:07 |
| openstackgerrit | zbr proposed zuul/zuul-jobs master: Add mode to packer https://review.opendev.org/752213 | 15:18 |
| openstackgerrit | zbr proposed zuul/zuul-jobs master: Add managed jobs to periodic https://review.opendev.org/748682 | 15:24 |
| openstackgerrit | zbr proposed zuul/zuul-jobs master: Add managed jobs to periodic-weekly https://review.opendev.org/748682 | 15:31 |
| *** mach1na has quit IRC | 15:35 | |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] Add zuul-client to requirements https://review.opendev.org/752043 | 15:45 |
| *** hamalq has joined #zuul | 15:45 | |
| clarkb | any objections to landing the zuul periodic-weekly pipeline change now ? https://review.opendev.org/#/c/748706/2/zuul.d/pipelines.yaml | 15:59 |
| AJaeger | zuul-jobs maintainer, please review the stack starting at https://review.opendev.org/#/c/742736/ to simplify our upload roles | 16:06 |
| *** tosky has quit IRC | 16:11 | |
| *** jcapitao has quit IRC | 16:48 | |
| *** rfolco|ruck|brb is now known as rfolco|ruck | 16:49 | |
| *** sanjayu__ has quit IRC | 16:50 | |
| *** tobberydberg has quit IRC | 16:51 | |
| *** tobberydberg_ has joined #zuul | 16:51 | |
| *** johanssone_ has quit IRC | 16:59 | |
| *** fdegir has joined #zuul | 17:01 | |
| *** jpena is now known as jpena|off | 17:01 | |
| *** johanssone has joined #zuul | 17:03 | |
| *** vishalmanchanda has quit IRC | 18:28 | |
| clarkb | tobiash: left a qusetion on https://review.opendev.org/#/c/752056/4 but +2'd it. Feel free to approve if my concern isn't valid (I think it may be fine hence the +2) | 18:40 |
| tobiash | clarkb: I think it's quite unlikely to have collisions there. It only needs to be unique within one repo and within one test case | 18:42 |
| clarkb | tobiash: one option may be to use a timestamp instead? | 18:44 |
| clarkb | if it includes subseconds I expect that will end up being unique? | 18:44 |
| clarkb | anyway I agree if its per test case that should likely be ok | 18:44 |
| *** tosky has joined #zuul | 18:51 | |
| hamalq | in https://zuul.opendev.org/t/openstack/build/1c6a5bb5f9934019a8820078dfca2384 i get ERROR: Could not find a version that satisfies the requirement python-designateclient===4.1.0 (from -c /home/zuul/src/opendev.org/openstack/requirements/upper-constraints.txt (line 474)) (from versions: 0.0.4, 0.0.5, 1.0.0, 1.0.1, 1.0.2, 1.0.3, 1.1.0, 1.1.1, 1.2.0, 1.3.0, 1.4.0, 1.5.0, 2.0.0, 2.1.0, 2.2.0, 2.3.0, 2.4.0, 2.5.0, 2.6.0, 2.7.0, | 18:59 |
| hamalq | hamalq | 18:59 |
| hamalq | 2.7.1, 2.8.0, 2.9.0, 2.10.0, 2.11.0, 2.12.0, 3.0.0, 3.1.0, 4.0.0) is there a comming chnage for this | 18:59 |
| clarkb | hamalq: that isn't a zuul problem. A better channel would be #opendev. But the issue was in pypi itself. https://github.com/pypa/warehouse/issues/8568 is the upstream bug we think it should be happier now | 19:01 |
| fungi | hamalq: probably a better question for the #opendev channel, but that looks like a problem with pypi which they fixed late yesterday. | 19:01 |
| hamalq | @fungi @clarkb thanks | 19:02 |
| clarkb | tobiash: similarly +2'd https://review.opendev.org/#/c/752079/3 but left an idea for improvement | 19:04 |
| clarkb | tobiash: the zuul py35 support dropping change has landed. Do we need to do similar with nodepool? | 19:06 |
| openstackgerrit | Merged zuul/zuul master: Fix branch name and project name for ref-updated create/delete https://review.opendev.org/738320 | 19:08 |
| tobiash | clarkb: thanks for review, I like your idea | 19:10 |
| tobiash | clarkb: yes dropping py35 on nodepool makes sense, I keep forgetting this ;) | 19:11 |
| openstackgerrit | Merged zuul/zuul master: [gitlab] approvals: fix error with community edition https://review.opendev.org/750546 | 19:29 |
| tobiash | clarkb: could you add https://review.opendev.org/745175 (add event queue sizes to stats reporting) to your review list? It has been proven to be quite useful as a performance indicator of the scheduler | 19:45 |
| clarkb | Yes | 19:46 |
| tobiash | thanks :) | 19:46 |
| tobiash | zuul-maint: this adds logging of missing required status checks which has been useful for our user support: https://review.opendev.org/718114 | 19:47 |
| tobiash | zuul-maint: and one more log annotation: https://review.opendev.org/747142 :) | 19:48 |
| tobiash | zuul-maint: this fixes a dos attack vector with large pull requests: https://review.opendev.org/751281. Last week we had a bunch (~35) of large pull requests where github refuses to create diffs which completely blocked github event processing for a full hour because getFiles triggered the retry handler while it didn't make sense in this case. | 19:52 |
| *** rlandy_ has joined #zuul | 20:16 | |
| *** rlandy has quit IRC | 20:18 | |
| *** frenzyfriday has joined #zuul | 20:24 | |
| *** frenzyfriday has quit IRC | 20:29 | |
| clarkb | tobiash: if you are still around why does pr['files'] need to be None not []? re https://review.opendev.org/#/c/751281/1/zuul/driver/github/githubconnection.py | 20:41 |
| clarkb | I'm reading the merger code and it seems we do if files in mergeChanges which is passed in from the merge gearman job (I think that is where it matters for this?) | 20:42 |
| clarkb | and on the cat side we expect a list becuase we do for fn in files | 20:43 |
| clarkb | tobiash: oh is this an issue iwth model.BuildSet.__init__() its checks item.change.files against None there | 20:44 |
| clarkb | that must be it | 20:44 |
| tristanC | clarkb: https://opendev.org/zuul/zuul/src/branch/master/zuul/driver/github/githubconnection.py#L1430 sets it to None too | 20:46 |
| tobiash | None is the signal to the scheduler to issue a fileschanges call to get the files list since github sometimes returns no or an incomplete list | 20:47 |
| tristanC | but i'm not sure either, the difference between None and [] is a bit confusing | 20:47 |
| clarkb | ya its tied to the model thing I discoverd | 20:49 |
| clarkb | we set the files_state based on that and if files_state is NEW then we do extra work | 20:49 |
| clarkb | we might want to make that less explicit to None but the change is correct given the model.py code | 20:49 |
| tobiash | We chose explixit None because git allows empty commits which would result in [] as file list | 20:50 |
| clarkb | got it | 20:51 |
| tobiash | and thus is a valid files list | 20:51 |
| *** frenzyfriday has joined #zuul | 20:59 | |
| *** frenzyfriday has quit IRC | 21:04 | |
| clarkb | tristanC: maybe you can review https://review.opendev.org/#/c/751975/ since it has to do with fedora (and even has a haskell bit) | 21:04 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: [DNM] Add zuul-client to requirements https://review.opendev.org/752043 | 21:08 |
| tristanC | clarkb: oh thanks, i thought i already approved it | 21:10 |
| openstackgerrit | Merged zuul/zuul master: Add event queue sizes to stats reporting https://review.opendev.org/745175 | 21:30 |
| *** rfolco|ruck has quit IRC | 21:35 | |
| openstackgerrit | Merged zuul/zuul master: Annotate getBranch with event id https://review.opendev.org/747142 | 21:56 |
| openstackgerrit | Merged zuul/zuul master: Ignore 500 errors when requesting pr files https://review.opendev.org/751281 | 21:56 |
| *** tosky_ has joined #zuul | 21:56 | |
| *** tosky has quit IRC | 21:59 | |
| *** tosky_ is now known as tosky | 22:00 | |
| *** rlandy_ has quit IRC | 22:01 | |
| *** nils has quit IRC | 22:44 | |
| *** tosky has quit IRC | 22:59 | |
| *** hamalq has quit IRC | 23:50 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!