Monday, 2020-08-24

*** tosky has quit IRC00:00
openstackgerritIan Wienand proposed zuul/zuul master: model.py : remove self.attributes.inheritable_attributes  https://review.opendev.org/74760001:38
openstackgerritIan Wienand proposed zuul/zuul master: model.py : remove unused inheritable_attributes dictionary  https://review.opendev.org/74760001:40
*** bhavikdbavishi has joined #zuul03:45
*** bhavikdbavishi1 has joined #zuul03:50
*** bhavikdbavishi has quit IRC03:51
*** bhavikdbavishi1 is now known as bhavikdbavishi03:51
*** bhavikdbavishi has quit IRC04:00
*** bhavikdbavishi has joined #zuul04:12
*** vishalmanchanda has joined #zuul04:33
openstackgerritIan Wienand proposed zuul/zuul master: [wip] always file matcher  https://review.opendev.org/74761404:40
*** evrardjp has quit IRC04:46
*** evrardjp has joined #zuul04:48
openstackgerritIan Wienand proposed zuul/zuul master: [wip] always file matcher  https://review.opendev.org/74761405:08
*** mach1na has joined #zuul05:18
*** mach1na has quit IRC05:28
*** raukadah is now known as chandankumar05:45
*** mach1na has joined #zuul06:05
*** yoctozepto has quit IRC06:10
*** yoctozepto has joined #zuul06:13
*** mach1na has quit IRC06:13
*** mach1na has joined #zuul06:14
*** mnasiadka has quit IRC06:16
*** mnasiadka has joined #zuul06:19
*** bhavikdbavishi has quit IRC06:28
openstackgerritIan Wienand proposed zuul/zuul master: [wip] always file matcher  https://review.opendev.org/74761406:32
*** AJaeger has quit IRC06:36
*** jhesketh_ has quit IRC06:39
*** jhesketh has joined #zuul06:41
*** AJaeger has joined #zuul06:45
zbrfelixedel: explained on https://review.opendev.org/#/c/747377/206:55
*** bhavikdbavishi has joined #zuul06:58
felixedelzbr: Ok, to me that documentation didn't make it very clear if they mean enforce the indentation (true/false) or if they mean enforce the indentation level (1, 2, 3).07:01
*** sshnaidm|afk is now known as sshnaidm07:03
*** AJaeger has quit IRC07:17
*** hashar has joined #zuul07:20
*** tosky has joined #zuul07:20
zbrfelixedel: true, but testing and seeing what others are using proved that 1 is what we needed.07:31
zbrianw: maybe you can help us close ^07:34
felixedelzbr: Maybe add a short comment to clarify what the switchCase 1 means? Just noted that - following the documentation - it's also not a bool value, but a factor (1 means 1x2=2 spaces indentation). 2 would mean 2x2=4 spaces indentation.07:39
zbri do not think is needed, if anyone would try to touch the value, they will see the results. still, if this is preventing this change from merging I will add it.07:41
zbrthat almost reminds me that at some point someone asked me to document how yaml anchors were working07:41
*** bolg has joined #zuul07:44
felixedelI just tink as it wasn't clear to me and also your answer wasn't the correct one, we should write it down as somebody else might have the same problem.08:02
felixedelAlso a comment shouldn't harm here ;-)08:03
*** yolanda has quit IRC08:03
*** avass has joined #zuul08:09
*** bhavikdbavishi has quit IRC08:14
*** bhavikdbavishi has joined #zuul08:15
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: DNM: Add unified synchronize-repos role that works with linux and windows  https://review.opendev.org/74000508:25
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Update synchronize-repos  https://review.opendev.org/74011008:25
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: synchronize-repos: Remove unecessary git path modifications  https://review.opendev.org/74764008:25
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul master: Consolidate js/jsx indentation  https://review.opendev.org/74737708:31
*** nils has joined #zuul08:35
*** bhavikdbavishi has quit IRC08:53
*** bhavikdbavishi has joined #zuul08:53
openstackgerritFelix Edel proposed zuul/zuul master: Merge file comments from multiple tasks  https://review.opendev.org/74766109:12
*** hashar has quit IRC09:12
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Enable linting of test-playbooks  https://review.opendev.org/73147109:25
*** AJaeger has joined #zuul09:32
felixedelzuul-maint: I have a bunch of small UI changes waiting for review https://review.opendev.org/#/c/747363/ , https://review.opendev.org/#/c/747152/ and https://review.opendev.org/#/c/739973/. Additionally the changes for the new filtertoolbar https://review.opendev.org/#/c/741385/ and the new layout for the builds/ and buildsets/ pages https://review.opendev.org/#/c/746112/5 are also ready for review09:35
*** bhavikdbavishi has quit IRC10:31
*** shanemcd has quit IRC10:52
*** shanemcd has joined #zuul10:53
*** bhavikdbavishi has joined #zuul11:03
zbrfelixedel: done.11:07
zbrmost ok, only issue with extra icons on columns11:07
*** mach1na has quit IRC11:24
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul master: Add releasenote about PF4 migration  https://review.opendev.org/74508511:25
swestzuul-maint: would be nice to get +w on https://review.opendev.org/#/c/747160/11:26
*** mach1na has joined #zuul11:55
*** rlandy has joined #zuul12:00
*** mach1na has quit IRC12:07
*** mach1na has joined #zuul12:08
*** mach1na has quit IRC12:18
*** mach1na has joined #zuul12:20
felixedelianw: Regarding https://review.opendev.org/#/c/741385/. What exactly "takes quites  a while to load"? In case you mean the table when the filters are changed, this change doesn't touch the table, so the behaviour is the same like before. But I've addressed that in the follow-up change https://review.opendev.org/#/c/746112/5 which also shows a spinner while the data is (re)loading12:25
*** rfolco has joined #zuul12:31
openstackgerritFelix Edel proposed zuul/zuul master: Merge file comments from multiple tasks  https://review.opendev.org/74766112:33
*** bhavikdbavishi has quit IRC12:44
*** hashar has joined #zuul12:49
*** nhicher has joined #zuul12:52
openstackgerritFelix Edel proposed zuul/zuul master: PF4: Update builds and buildsets tables + use newest patternfly release  https://review.opendev.org/74611213:06
openstackgerritFelix Edel proposed zuul/zuul master: UI: Highlight pipeline names on status page  https://review.opendev.org/74715213:09
*** Goneri has joined #zuul13:25
zbrtobiash: mordred tristanC: https://review.opendev.org/#/c/747377/ please (formatting)13:32
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul master: Consolidate js/jsx indentation  https://review.opendev.org/74737714:18
openstackgerritJan Kubovy proposed zuul/zuul master: WIP: Switch to using zookeeper instead of gearman for jobs (keep gearman for mergers)  https://review.opendev.org/74441614:19
*** chandankumar is now known as raukadah14:52
*** cloudnull7 has joined #zuul15:02
*** tdasilva has quit IRC15:03
*** evgenyl has quit IRC15:03
*** cloudnull has quit IRC15:03
*** cloudnull7 is now known as cloudnull15:03
*** tdasilva has joined #zuul15:03
*** webknjaz has quit IRC15:03
*** evgenyl has joined #zuul15:04
*** zbr has quit IRC15:04
*** zbr has joined #zuul15:05
*** webknjaz has joined #zuul15:06
*** nils has quit IRC15:07
*** nils has joined #zuul15:18
*** vishalmanchanda has quit IRC15:22
*** masterpe has quit IRC15:22
*** donnyd has quit IRC15:22
*** gundalow has quit IRC15:22
*** kklimonda has quit IRC15:22
*** mwhahaha has quit IRC15:22
*** mnaser has quit IRC15:22
*** guilhermesp has quit IRC15:22
*** iamweswilson has quit IRC15:26
*** iamweswilson has joined #zuul15:26
*** masterpe has joined #zuul15:30
*** mwhahaha has joined #zuul15:31
*** weshay|ruck has quit IRC15:31
*** weshay has joined #zuul15:32
*** vishalmanchanda has joined #zuul15:33
*** donnyd has joined #zuul15:33
*** gundalow has joined #zuul15:33
*** kklimonda has joined #zuul15:34
*** mnaser has joined #zuul15:34
*** guilhermesp has joined #zuul15:34
*** mach1na has quit IRC15:37
*** bhavikdbavishi has joined #zuul15:47
*** weshay has quit IRC16:05
*** weshay has joined #zuul16:05
*** iurygregory has quit IRC16:18
*** iurygregory has joined #zuul16:27
*** hashar has quit IRC16:48
*** tosky has quit IRC16:49
*** nils has quit IRC16:56
*** Pilou has quit IRC17:28
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: bindep: Add missing virtualenv and fixed repo install  https://review.opendev.org/69363717:29
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: bindep: Fixed runtime warnings  https://review.opendev.org/74778117:33
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: bindep: install packages one by one  https://review.opendev.org/69363717:37
clarkbzbr: any idea how much slower ^ is?17:38
clarkbI wonder if we can make that a role parameter (then set it as a project level var)17:38
zbrclarkb: i did not make any tests but I doubt is a real issue. i don't really enjoy making it an opt-in as bindep user may have zero zuul knowledge.17:39
zbri am more inclined to do another approach: try all at once and fallback to serial if failing.17:40
zbrit would make it slower only in case of failure17:40
zbrany other ideas?17:41
clarkbcould possibly have bindep output if serial is necessary17:42
zbrwhat i really love about bindep.txt is its simplicity, I seen it used (updated) by people which never used bindep tool.17:42
zbri think bindep itself has no clue if something may need serial or not, nor it has any ways to add generic config items.17:43
zbrit is very simplistic: list of package names with filters after17:43
clarkbyou could specify it in the config potentially17:44
clarkb[this is a repo package] type thing17:44
clarkbI'm mostly just brain storming not sureit us a good idea17:44
clarkbbut I expect serial installs to significantly slow down bindep17:45
clarkb(it is a long issue with puppet working aroound a yum behavior and makes it slow)17:45
zbras I said, alternative is to try current task (all), check result and try serial after instead of failing right away.17:46
zbrmore like using serial only as a fallback for bulk install failure17:46
clarkbya that would also likely work17:52
zbrclarkb: sure I will update it to do that.17:57
zbrcorvus: did we wait enough with https://review.opendev.org/#/c/739482/ ?17:58
*** Pilou has joined #zuul18:01
corvuszbr: yeah, looks like good consensus on that +318:02
* zbr pinching myself to check if I a dreaming or not18:03
zbrdo we happen to have (or plan) a test zuul instance that always runs master? as in real CD18:05
zbrit could prove very useful for testing unreleased version, especially around UI changes18:06
zbrthere another UI change I want to make to shorten durations and remove secons and write them compressed: "16 mins 47 secs" -> "17m"18:09
zbrthere is not much value in measuring seconds for duration18:10
zbrwe could display full value as tooltip...18:10
clarkbui changes are built then can be run against both opendev and software factory's zuul18:10
clarkbthats all done by the jobs for you18:10
clarkbabd for a master deployment the quickstart is good for that18:10
corvuszbr: before you write that, go look at the review history for the change that last modified the time fields18:11
corvusi don't want to have to go through that conversation again from scratch18:11
zbri found some reviews around that but not about listing in builds/buildsets page18:17
zbrhttps://sbarnea.com/ss/Screen-Shot-2020-08-24-19-19-33.13.png18:19
zbras seen the duration and start time are always wrapped. likely compressing duration alone is enough to make most rows not wrap.18:20
openstackgerritMerged zuul/zuul master: Prevent Git GC issue between merger and executor  https://review.opendev.org/74716018:21
zbrone dowside of the new ui is that I lock the ability to select text inside the rows18:22
openstackgerritMerged zuul/zuul master: UI: Show Ref on build(set) result page if no branch is set  https://review.opendev.org/74736318:30
openstackgerritMerged zuul/zuul-jobs master: ara-report: add option for artifact prefix  https://review.opendev.org/74710019:05
openstackgerritMerged zuul/zuul-jobs master: tox: include command output in log/error  https://review.opendev.org/74732519:05
openstackgerritMerged zuul/zuul master: Add user preferences dialog  https://review.opendev.org/73948219:07
*** bhavikdbavishi has quit IRC19:23
fungii'm on vacation and totally not here, but whether packages need to be installed serially is an instruction to whatever's running the package manager. bindep doesn't install things, so whether or not installation should be serialized is not information it would ever act on, and so i question whether it would make sense in the file used to instruct bindep19:30
fungibindep really does one (and only one) thing, that's tell you whether the packages you have installed match the list it was given (and then all the fanciness is in how it filters that list based on your platform and any command parameters)19:31
clarkbthats a fair point19:31
fungii wasn't following closely, but i guess this is related to multi-stage installation?19:32
clarkbfungi: ya so that you can install a package that enables a repo then install packages from that repo19:34
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul master: Enable optional pre-wrapping on console and output  https://review.opendev.org/72360319:34
clarkbcorvus: tobiash (is jan on irc too?) is there a good place to help dig into the zk work in zuul?19:34
clarkbI'm looking at hte change list and there are a number of them I'm not quite sure yet where would be the best plcae to help19:35
fungimaybe the role could just retry several times?19:35
fungithat would get you up to three stages19:35
fungiassuming the package manager doesn't just refuse to install anything if you include an unrecognized package name19:36
corvusclarkb: bolg is jan19:36
fungialso this would be an rpmism, debian derivatives would need an apt update in between installing a package which added a new package repository and then installing packages from that new repository19:37
fungiso even serializing wouldn't help you there19:37
tobiashclarkb, corvus: fyi, I'm out of office this week19:37
fungiunless you updated indices after each package installed19:37
fungitobiash: hah, me too19:38
fungineither of us is doing a very good job at that, apparently19:38
clarkbtobiash: no worries, enjoy your time off19:39
tobiashthanks19:39
clarkbfungi: ya you should go back to drinking rum on the deck or whatever it is you are doing:)19:39
fungii was painting, doing some radio repair, mowing the lawn and making releases of some personal software projects19:40
fungiunfortunately not all at the same moment though, that would have been impressibe19:40
fungiimpressive19:40
clarkbbolg: hey, if you're still around I'd be happy to help with some reivews on the zk work in zuul. Just point me at where I can be most useful19:40
clarkbhttps://review.opendev.org/#/c/709735/27 seems to be the bottom of a related stack so I'll start there for now19:41
tobiashclarkb: yes, that makes sense. Those changes at the bottom mostly prepare some stuff to aid further implementation19:44
corvusmight also be worth seeking out the required db changes19:44
openstackgerritMerged zuul/zuul master: UI: Highlight pipeline names on status page  https://review.opendev.org/74715220:20
ianwfelixedel: thanks, yeah the filter taking a while to load isn't new.  a spinner will be welcome and i'll take a look22:31
erbarrhello, any zuul install experts that can help me?22:34
openstackgerritIan Wienand proposed zuul/zuul-jobs master: Add ensure-rust role  https://review.opendev.org/74642323:05
clarkberbarr: I'm mostly around and happy to help if I can23:06
ianwerbarr: best to just ask ... you are in the right place though :)23:07
erbarrclarkb, thanks man, I've followed the zuul from scratch and I'm getting to a point where I have nodepool configured to use dib, it creates and uploads a ubuntu bionic image to my devstack cloud successfully, i can then go and use that image to launch instances, but then nodepool launcher is pretty much instantly deleting the instance it makes and then says that is ready23:08
clarkberbarr: it thinks the node is ready even though it has deleted it?23:09
clarkbgenerally with node deletions after boot the problem is with ssh23:09
clarkbI would double check that firwalls and security groups allow ssh in, and that cloud-init/glean/something is configuring networking on the host as well as ssh keys (if you don't bake them into the image)23:10
erbarrahh, that sounds familiar, i did the no host checking option since i was getting unable to connect to port 22 thing23:10
clarkbmanually booting the image is usually the easiest way to check that23:10
erbarrand after that it still deletes but says is ready23:10
erbarrbut that seemed to fail very quickly though, like the instance was barely starting to boot and it would delete it23:12
clarkbnodepool should log when it is deleting the instance too iirc23:13
clarkbI'm looking to see how that is logged now23:13
erbarri'm not seeing that in /var/log/nodepool/nodepool.log, "node is ready" is the last entry i see there23:14
clarkbself.log.info("Deleting %s instance %s from %s", node.state, node.external_id, node.provider)23:16
clarkbyou should see log lines like that if nodepool is deleting the instance23:16
clarkbyou are saying the nodepool state is ready though? But it is deleted from the cloud?23:16
clarkb Iwonder if it is a cloud side issue we don't account for23:16
erbarryea, and it seems the launcher is deleting it right in the middle of booting before I guess even the ssh server has initialized23:17
clarkbare there any exceptions?23:17
clarkboh wait when you say it is ready is that from nodepool list or from openstack listings?23:17
erbarrnodepool list23:17
erbarropenstack doesn't show, on cli or horizon23:18
erbarri see it pop up briefly then get deleted23:18
clarkbgot it23:18
clarkbcan you grep a node id from nodepool.log which should give the full cycle of that node according to nodepool23:18
clarkbthen share that ( just double check there isn't anything sensitive first like maybe IP addrs)23:19
clarkbbut the other thing I would try is manually booting and see what happens23:19
erbarrok, let me get that23:19
*** iurygregory has quit IRC23:21
erbarrhttps://www.irccloud.com/pastebin/IO6TgYNN/23:22
erbarrthat's the last one, not much message, let me remove the no host checking option to get the port 22 errors23:23
clarkbI'm trying to think of other ways that servers can be deleted23:23
clarkbif the connection to zookeeper is lost then they maybe depending on when the connection is lost23:23
clarkbdouble check that the nodepool and zuul processes and zookeeper processes aren't restarting?23:24
erbarrokay, let me see23:25
erbarrthey seem to not be restarting23:30
clarkband are there any other nodepool processes running that may be conflicting with a different config?23:30
clarkbfor nodepool launchers you want a single one running per provider23:30
erbarri only have one launcher and one builder running23:31
clarkbya not coming up with any other ideas right now. I would try a manual boot and see if you can replicate as that may help narrow down the problem23:32
*** vishalmanchanda has quit IRC23:32
erbarrokay, so for manual boot, i have tried to use the image uploaded by the builder manually, i can create an instance with the 3 interfaces, wait for it to boot, ping each one of them and then try to ssh but fail to do so, started with the (publickey) error but then I got it to "connection closed by remote host"23:34
openstackgerritMerged zuul/zuul-jobs master: Add ensure-rust role  https://review.opendev.org/74642323:34
clarkbok I would get ssh working completely as that could be related to the cleanups (if zuul/nodepool think the server isn't accessible they will get cleaned up)23:35
erbarrokay, let me try to get that fully working, so, in the zuul from scratch tutorial the private key gets moved to the zuul user .ssh folder, does the nodepool user need a copy of tha key as well?23:38
clarkbI think it is just zuul that does sshing in now23:42
clarkbnodepool will do a host key scan23:42
clarkbbut not actually ssh in23:42
erbarrokay, that makes sense, so maybe i need to fix my dib elements23:43
erbarri got nothing custom element wise, everything coming from the dib install, on diskimages i have elements in this order, ubuntu, vm, simple-init, openssh-server, growroot23:47
erbarrdoes that seem okay?23:47
clarkberbarr: mostly. What that will do is give you a glean configured server on boot. Glean will configure the root user with any ssh keys set by nodepool23:48
clarkberbarr: zuul will expect to ssh as the zuul user by default23:48
clarkbso that may be the mismatch23:49
clarkberbarr: https://opendev.org/openstack/project-config/src/branch/master/nodepool/nl01.openstack.org.yaml#L82 is how you set a key on instances in nodepool. Note that that key must be created in nova independently by something23:49
clarkbthat would then allow ssh to root not zuul. I think you can change the zuul user elsewhere. However, it would probably be better to configure a zuul user instead using an element like https://opendev.org/openstack/project-config/src/branch/master/nodepool/elements/zuul-worker23:50
*** rlandy has quit IRC23:51
* clarkb thinks out loud here: should we maybe put that lement in the nodepool repo?23:53
erbarrahh, that's neat, so I guess i can just get a local copy of that zuul-worker element and drop it in my local elements folder that i configured in nodepool.yaml23:53
erbarrdoes order matter?23:53
clarkbya that should work23:53
clarkbno order doesn't matter in the elements list23:53
clarkbthe elements are internally ordered23:53
erbarrnice! alright, let me give this a shot, i'll probably bother you again tomorrow lol, i need to update Dell Ironic CI to zuul v3 so I'm kind of just starting from scratch23:55
erbarrthanks for the help, i really appreciate it23:55
clarkbyou're welcome23:55

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!