| openstackgerrit | Merged zuul/zuul master: Correctly fail cat/fileschanges when update fails https://review.opendev.org/739762 | 00:01 |
|---|---|---|
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: remove amd64 architecture pin https://review.opendev.org/746245 | 00:09 |
| *** hashar_ has joined #zuul | 00:26 | |
| *** hashar has quit IRC | 00:28 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: remove amd64 architecture pin https://review.opendev.org/746245 | 00:29 |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: ensure-docker: remove amd64 architecture pin https://review.opendev.org/746245 | 00:30 |
| *** rfolco has quit IRC | 00:42 | |
| *** mgoddard has quit IRC | 01:00 | |
| *** mgoddard has joined #zuul | 01:06 | |
| *** reiterative has quit IRC | 02:53 | |
| *** Tahvok has quit IRC | 02:53 | |
| *** johanssone has quit IRC | 02:53 | |
| *** irclogbot_3 has quit IRC | 02:53 | |
| *** avass has quit IRC | 02:53 | |
| *** Miouge has quit IRC | 02:53 | |
| *** guillaumec has quit IRC | 02:53 | |
| *** bstinson has quit IRC | 02:53 | |
| *** frickler has quit IRC | 02:53 | |
| *** reiterative has joined #zuul | 02:59 | |
| *** Tahvok has joined #zuul | 02:59 | |
| *** johanssone has joined #zuul | 02:59 | |
| *** irclogbot_3 has joined #zuul | 02:59 | |
| *** avass has joined #zuul | 02:59 | |
| *** Miouge has joined #zuul | 02:59 | |
| *** guillaumec has joined #zuul | 02:59 | |
| *** bstinson has joined #zuul | 02:59 | |
| *** frickler has joined #zuul | 02:59 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| *** zbr1 has joined #zuul | 05:05 | |
| *** zbr has quit IRC | 05:06 | |
| *** zbr1 is now known as zbr | 05:06 | |
| openstackgerrit | Simon Westphahl proposed zuul/nodepool master: Ignore unparsable/empty image upload ZNode data https://review.opendev.org/738013 | 05:33 |
| swest | clarkb: corvus: addressed your comments ^ | 05:35 |
| *** saneax has joined #zuul | 05:44 | |
| *** ianw has quit IRC | 05:48 | |
| *** ianw has joined #zuul | 05:49 | |
| *** logan- has quit IRC | 05:49 | |
| *** hashar_ has quit IRC | 05:50 | |
| *** logan- has joined #zuul | 05:51 | |
| *** logan- has quit IRC | 05:59 | |
| *** logan- has joined #zuul | 05:59 | |
| ianw | corvus: not sure why, but I'm not seeing https://review.opendev.org/746245 be deployed with depends-on in pyca/ repos. i don't think it's a trusted repo? i'm not sure why | 06:58 |
| *** bhavikdbavishi has joined #zuul | 07:18 | |
| *** vishalmanchanda has joined #zuul | 07:21 | |
| *** hashar_ has joined #zuul | 07:33 | |
| *** hashar_ is now known as hashar | 07:35 | |
| AJaeger | zbr: I see ansible-lint failing on zuul-jobs with E208 - but that is not documented in https://docs.ansible.com/ansible-lint/rules/default_rules.html ;( | 07:46 |
| AJaeger | zbr: and there are false positives on roles/add-build-sshkey/tasks/remote-linux.yaml AFAIU ;( | 07:48 |
| zbr | AJaeger: i am fully aware of it | 07:48 |
| zbr | AJaeger: maybe you can help me with https://github.com/ansible/ansible-lint/pull/949 fix | 07:48 |
| zbr | i made it two days ago... | 07:49 |
| zbr | AJaeger: you will not find any documentation on ansible official website, that is outdated by more than an year | 07:50 |
| zbr | https://ansible-lint.readthedocs.io/en/latest/default_rules.html#file-permissions-not-mentioned | 07:50 |
| openstackgerrit | Andreas Jaeger proposed zuul/zuul-jobs master: Disable E208 for now https://review.opendev.org/746310 | 07:51 |
| AJaeger | zbr: thanks. | 07:52 |
| AJaeger | zbr: there seem to be more problems than you fix, see my commit message above | 07:52 |
| zbr | AJaeger: do a review on the linter even if you are not core, it will help me fastrack the fix. | 07:52 |
| zbr | i can make a release on the linter at any time but I cannot merge my own patches. | 07:53 |
| AJaeger | zbr: will do ;) | 07:53 |
| AJaeger | zbr: and reading your change, it should adddress the spots I found - great! | 07:53 |
| zbr | that fix resolves ~40% of issues reported on zuul-jobs | 07:53 |
| zbr | for the rest I am afraid adding mode is needed, unless someone finds other criterias to lower the false-positives | 07:54 |
| zbr | i plan to add an option to downgrade errors to warning level, to make transitions easier | 07:54 |
| zbr | disabling the rule does not help adding new bugs or fixing them progressively | 07:55 |
| AJaeger | zbr: yes, we should fix the real problems... I started to go down that road and run into too many false positives. | 07:56 |
| openstackgerrit | Andreas Jaeger proposed zuul/zuul-jobs master: Disable E208 for now https://review.opendev.org/746310 | 07:57 |
| zbr | avass: can you help with ^ linter fix above? i think your vote is counted. | 07:58 |
| avass | zbr: looking | 07:58 |
| AJaeger | zbr: do you ask avass to review https://github.com/ansible/ansible-lint/pull/949 or https://review.opendev.org/746310 - or both? ;) | 07:59 |
| zbr | both | 07:59 |
| avass | zbr, AJaeger: approved both :) | 08:00 |
| zbr | AJaeger: fyi, anyone is welcomed to help with linter maintenance, just comment on https://github.com/ansible/ansible-lint/issues/815 | 08:00 |
| avass | AJaeger: should I +wf that since it's blocking things? or is there any zuul-jobs maintainer here? | 08:01 |
| AJaeger | ianw, frickler , do you have time to approve https://review.opendev.org/746310 to unblock zuul-jobs, please? | 08:02 |
| AJaeger | avass: let's ask first ^. And while it blocks - if we have an urgent fix, I agree with single-core accept it but I think we have time to wait a bit... | 08:03 |
| avass | AJaeger: sure :) | 08:04 |
| avass | AJaeger: there's not really a lot happening in zuul-jobs at the moment anyway :) | 08:05 |
| AJaeger | avass: yeah, vacation time for many... | 08:05 |
| zbr | vacation time makes merging anything a stuggle | 08:10 |
| AJaeger | less conflicts ;) | 08:10 |
| zbr | i still hope to see https://review.opendev.org/#/c/739482/ merged to unblock other UI/UX changes. | 08:12 |
| zbr | i have 6m+ changes waiting for preferences dialog | 08:13 |
| zbr | just because some people asked for some changes to be "optional" | 08:13 |
| *** hashar has quit IRC | 08:34 | |
| tobiash | corvus: did you not +w the zuul.ignore change on purpose or shall we merge it (744811)? | 08:59 |
| openstackgerrit | Merged zuul/zuul-jobs master: Disable E208 for now https://review.opendev.org/746310 | 09:02 |
| openstackgerrit | Merged zuul/zuul-jobs master: ensure-pip: add instructions for RedHat system https://review.opendev.org/743750 | 09:02 |
| openstackgerrit | Merged zuul/zuul master: Annotate github client in mergePull https://review.opendev.org/744755 | 09:52 |
| openstackgerrit | Merged zuul/zuul master: gitlab: support the labels requirement https://review.opendev.org/741893 | 09:52 |
| *** wuchunyang has joined #zuul | 09:53 | |
| *** bhavikdbavishi has quit IRC | 09:54 | |
| *** wuchunyang has quit IRC | 09:59 | |
| openstackgerrit | Merged zuul/zuul master: Log complete output of kubectl port-forward https://review.opendev.org/745182 | 10:01 |
| openstackgerrit | Merged zuul/zuul master: Fix some doc typos https://review.opendev.org/746232 | 10:06 |
| *** tosky has joined #zuul | 10:22 | |
| *** bhavikdbavishi has joined #zuul | 10:24 | |
| *** bhavikdbavishi1 has joined #zuul | 10:27 | |
| *** bhavikdbavishi has quit IRC | 10:29 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 10:29 | |
| *** sanjayu_ has joined #zuul | 10:55 | |
| *** saneax has quit IRC | 10:57 | |
| *** sanjayu_ has quit IRC | 11:13 | |
| *** sanjayu_ has joined #zuul | 11:14 | |
| *** saneax has joined #zuul | 11:20 | |
| *** sanjayu_ has quit IRC | 11:23 | |
| *** saneax has quit IRC | 11:43 | |
| felixedel | zuul-maint: How do you usually deal with breaking changes to the Zuul web API? I have sopmething in my mind that zuul-web should support the two latest versions of the frontend, right? So we could introduce something like an api_version parameter which must be set to get the new API result? Background: I'm currently implementing a pagination for the builds/ and buildsets/ pages. While this works quite well with | 12:13 |
| felixedel | patternfly, we need the total number of builds/buildsets to make the pagination work properly as this information is used to calculate the total pages. By now, the builds/ endpoint directly returns the build list, which does not provide any room for additional attributes like total_builds. Thus, I would like to change this endpoint to return something like {"builds": [], "total_builds": 123} instead. | 12:13 |
| felixedel | The same applies for the buildsets/ endpoint | 12:14 |
| tobiash | typically zuul-web should support the last release, not two releases back so users can upgrade their services without having to care about the upgrade ordering | 12:15 |
| tobiash | running mixed version zuul deployments is actually not really supported except during upgrade paths | 12:16 |
| *** hashar has joined #zuul | 12:18 | |
| mnaser | tobiash: i think the bigger concern is the fact the api behaviour changes -- felixedel: could you not for example as something where you implement offset/limit parameters which won't break the api | 12:22 |
| mnaser | so if they're missing, you get * -- if they're not, you get N builds -- but i think the problem with that is now you cant get your total count | 12:22 |
| tobiash | ah yes, that's public api... | 12:25 |
| tobiash | then yes, we need to think about this more | 12:55 |
| felixedel | tobiash: With the last two, I mean the last and the current :D | 12:56 |
| felixedel | mnaser: Yes, the problem is not the limit/skip as those are already available. But you don't know how many pages are available depending on your filters. Another way would be to somehow always allow moving to the next page, but then the last page would be empty when no results are available anymore. Which is also not a good solution in my opinion. Our we could implement an infinite scrolling but that's IMHO also not | 13:00 |
| felixedel | the best solution for such a table | 13:00 |
| *** bhavikdbavishi has quit IRC | 13:04 | |
| openstackgerrit | Benjamin Schanzel proposed zuul/nodepool master: OpenShift/k8s Provider: Basic Support for k8s nodeSelectors https://review.opendev.org/746320 | 13:24 |
| mnaser | felixedel: yeah also its not nice if you want to point someone to a specific page | 13:30 |
| mnaser | if builds are page 4, "please scroll a bunch" :p | 13:30 |
| zbr | felixedel: to avoid changing the REST url, you could specify the client version using http headers | 13:45 |
| zbr | others like jira used an /api/version/... urls. | 13:46 |
| felixedel | zbr: Yes, api_version as http_header also came to my mind. Or something like Github does with the "beta" feature_flags | 13:46 |
| zbr | while nice, is a bit problematic as some clients may find hard to add headers, not even sure is possible with ajax | 13:47 |
| zbr | what they did at https://developer.atlassian.com/cloud/jira/platform/rest/v3/intro/ seems safer. | 13:47 |
| zbr | keep in mind that this applies to /rest/api/ | 13:48 |
| openstackgerrit | Benjamin Schanzel proposed zuul/nodepool master: OpenShift/k8s Provider: Basic Support for k8s nodeSelectors https://review.opendev.org/746320 | 14:39 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: WIP: Return number of total builds from builds/ API endpoint https://review.opendev.org/746328 | 14:40 |
| *** hashar has quit IRC | 14:46 | |
| corvus | today is a PTO day for me, i'll be back next week | 14:56 |
| fungi | have a good weekend! | 15:00 |
| *** sgw1 has joined #zuul | 15:34 | |
| *** bhavikdbavishi has joined #zuul | 15:40 | |
| *** tosky has quit IRC | 15:43 | |
| zbr | 1h ago pytest-xdist==2.0.0 was released, and it breaks with pytest-cov, happy friday! | 15:49 |
| fungi | i don't think we're using pytest not running coverage jobs for zuul, at least | 15:50 |
| fungi | er, i don't think we're using pytest nor running coverage jobs | 15:50 |
| *** bhavikdbavishi has quit IRC | 15:59 | |
| *** hamalq has joined #zuul | 16:01 | |
| openstackgerrit | Merged zuul/zuul-jobs master: ensure-docker: remove amd64 architecture pin https://review.opendev.org/746245 | 17:57 |
| *** hashar has joined #zuul | 19:26 | |
| clarkb | corvus: swest I've +2'd https://review.opendev.org/#/c/738013/9. We hit a similar problem with that again today though it was through the getBuilds path I think | 20:22 |
| clarkb | so we may need to do similar there like ^ does with uploads? | 20:22 |
| *** hashar has quit IRC | 20:48 | |
| openstackgerrit | Clark Boylan proposed zuul/nodepool master: Ignore unparsable/empty image build ZNode data https://review.opendev.org/746349 | 20:53 |
| clarkb | swest: corvus ^ not sure if the udnerlying cause is the same but I think that will handle it for the build case | 20:54 |
| *** vishalmanchanda has quit IRC | 21:43 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!