*** jamesmcarthur has joined #zuul | 00:12 | |
*** rlandy|bbl is now known as rlandy | 00:32 | |
*** Goneri has quit IRC | 00:39 | |
*** hamalq has quit IRC | 00:41 | |
*** SpamapS has quit IRC | 00:44 | |
*** sgw1 has quit IRC | 00:48 | |
*** gmann has quit IRC | 00:51 | |
*** gmann has joined #zuul | 00:51 | |
*** SpamapS has joined #zuul | 00:58 | |
*** rfolco has quit IRC | 00:58 | |
*** jamesmcarthur has quit IRC | 01:04 | |
openstackgerrit | Ian Wienand proposed zuul/zuul master: Give the focus to a <div> overlaying the main content https://review.opendev.org/743440 | 01:27 |
---|---|---|
*** jamesmcarthur has joined #zuul | 01:37 | |
*** jamesmcarthur has quit IRC | 01:48 | |
*** rlandy has quit IRC | 01:50 | |
*** jamesmcarthur has joined #zuul | 02:51 | |
*** sgw1 has joined #zuul | 02:53 | |
*** SpamapS has quit IRC | 03:06 | |
*** SpamapS has joined #zuul | 03:09 | |
*** bhavikdbavishi has joined #zuul | 03:10 | |
*** bhavikdbavishi1 has joined #zuul | 03:15 | |
*** jamesmcarthur has quit IRC | 03:15 | |
*** SpamapS has quit IRC | 03:15 | |
*** bhavikdbavishi has quit IRC | 03:17 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 03:17 | |
*** y2kenny has quit IRC | 04:12 | |
*** bhavikdbavishi has quit IRC | 04:22 | |
*** vishalmanchanda has joined #zuul | 04:22 | |
*** bhavikdbavishi has joined #zuul | 04:23 | |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #zuul | 04:33 | |
*** sgw1 has quit IRC | 04:53 | |
*** SpamapS has joined #zuul | 05:06 | |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Check cycle items are mergeable before reporting https://review.opendev.org/743450 | 05:11 |
*** nils has joined #zuul | 05:32 | |
*** bhavikdbavishi1 has joined #zuul | 05:59 | |
*** bhavikdbavishi has quit IRC | 06:00 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 06:00 | |
*** bhagyashris|away is now known as bhagyashris | 06:01 | |
*** marios has joined #zuul | 06:03 | |
*** bhavikdbavishi has quit IRC | 06:27 | |
*** bhavikdbavishi has joined #zuul | 06:51 | |
*** yolanda has quit IRC | 06:52 | |
*** yolanda has joined #zuul | 06:52 | |
*** bhavikdbavishi has quit IRC | 07:03 | |
*** bhavikdbavishi has joined #zuul | 07:05 | |
*** jcapitao has joined #zuul | 07:12 | |
*** tosky has joined #zuul | 07:42 | |
*** jpena|off is now known as jpena | 07:54 | |
*** bhagyashris is now known as bhagyashris|lunc | 08:10 | |
*** hashar has joined #zuul | 08:25 | |
*** wuchunyang has joined #zuul | 08:59 | |
openstackgerrit | Ian Wienand proposed zuul/zuul master: Give the focus to a <div> overlaying the main content https://review.opendev.org/743440 | 09:35 |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Check cycle items are mergeable before reporting https://review.opendev.org/743450 | 09:36 |
*** brendangalloway has joined #zuul | 09:37 | |
*** bhagyashris|lunc is now known as bhagyashris | 09:41 | |
brendangalloway | Hello, is there any way to have the speculative merger create the repo as it would be after merging (ie using the change's commit message, rather than a temporary merge message)? | 09:42 |
*** bhavikdbavishi has quit IRC | 09:50 | |
*** bhavikdbavishi has joined #zuul | 10:17 | |
felixedel | iawn: I've answered to your comments directly in my change https://review.opendev.org/#/c/743239/1 | 10:20 |
felixedel | ^ianw | 10:20 |
*** wuchunyang has quit IRC | 10:21 | |
openstackgerrit | Merged zuul/nodepool master: Remove default qcow2 format in diskimage config https://review.opendev.org/741166 | 10:23 |
*** bhavikdbavishi has quit IRC | 10:30 | |
*** wuchunyang has joined #zuul | 10:53 | |
*** saneax has joined #zuul | 10:53 | |
*** armstrongs has joined #zuul | 10:59 | |
*** jcapitao is now known as jcapitao_lunch | 11:04 | |
*** wuchunyang has quit IRC | 11:05 | |
*** bhagyashris is now known as bhagyashris|away | 11:06 | |
*** armstrongs has quit IRC | 11:08 | |
*** wuchunyang has joined #zuul | 11:12 | |
*** wuchunyang has quit IRC | 11:23 | |
*** wuchunyang has joined #zuul | 11:23 | |
*** jpena is now known as jpena|lunch | 11:28 | |
*** bhagyashris|away is now known as bhagyashris | 11:36 | |
*** bhavikdbavishi has joined #zuul | 11:37 | |
fungi | brendangalloway: i'm not sure i follow your question. zuul attempts to emulate the merge commit which your code hosting platform will eventually create when the change finally merges. are you wanting it to more closely emulate the merge commit message the code hosting platform will create? also if the change is fast-forwardable zuul doesn't create a merge commit, it only creates a merge commit if the change | 11:56 |
fungi | needs one | 11:56 |
*** jcapitao_lunch is now known as jcapitao | 11:58 | |
*** evrardjp has quit IRC | 12:00 | |
brendangalloway | So the context to the question is we have some build artefacts that were getting generated in gate and then consumed elsewhere. Rebuilding the artefacts in post with exactly the same job was seen as a waste - the artefact is only moved to the artefact store if the gate passes. The artefacts are tagged with the git hash as zuul see it. However, | 12:01 |
brendangalloway | when trying to trace an artefact, that hash is not in the repo. When we investigated further, we see that the commit message during gate is 'Merge commit 'refs/changes/29/4129/2' of ssh://<<repo>> into HEAD', while the commit message of the merged change is 'merge <commit title>'. It would seem the different message is what is causing the | 12:01 |
brendangalloway | different git hash. | 12:01 |
*** rfolco has joined #zuul | 12:02 | |
*** wuchunyang has quit IRC | 12:04 | |
*** hashar has quit IRC | 12:05 | |
fungi | the date/time of the merge will also affect the hash | 12:07 |
fungi | which zuul won't be able to predict | 12:07 |
fungi | we also struggle with the same problem in opendev/for zuul's own artifacts, so i agree finding a solution would be great | 12:08 |
fungi | currently our docker images built in the gate pipeline and published from the promote pipeline don't have the same commit id as what gets merged to the branch of the repository, for these reasons | 12:09 |
*** rlandy has joined #zuul | 12:10 | |
fungi | the best idea we have to solve it at this point is for zuul to gain the ability to push its merge commits directly to the public branch in the code hosting platform, rather than asking the code hosting platform to do the final merging | 12:10 |
fungi | then the timestamp and commit message and parentage, and therefore the commit id itself, will match between what the gate pipeline sees and what ends up in the repository | 12:11 |
brendangalloway | ok, for now we are moving the jobs to post to run after the commit has occurred, in order to correctly label the artefacts. I just wanted to confirm there isn't some other way we could still have it correct while generating in gate | 12:12 |
fungi | yeah, for our artifacts we've decided not to build them in post because there's a slight race that the images built after merge might not have quite the same contents as those tested in the gate pipeline | 12:13 |
fungi | and for our purposes, publishing the artifacts we tested is more important than having the commit id embedded in the build versions match the commit id in the public repo (granted, we'd love to have that too) | 12:15 |
*** jamesmcarthur has joined #zuul | 12:16 | |
*** holser has quit IRC | 12:30 | |
*** holser has joined #zuul | 12:31 | |
*** jpena|lunch is now known as jpena | 12:34 | |
mordred | yeah - zuul push should help this | 12:36 |
mordred | brendangalloway: fwiw - in our docker image build jobs we have zuul write some metadata into the image about the change in question to facilitate that sort of traceability that gets lost when using a gate built artifact. I'm not sure if there is any good way to do a similar thing in your artifacts, but maybe | 12:38 |
*** holser has quit IRC | 12:39 | |
*** holser has joined #zuul | 12:40 | |
mordred | brendangalloway: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/build-docker-image/tasks/build.yaml#L25-L28 | 12:41 |
brendangalloway | mordred: I've also suggested using refs or gerrit change IDs as reference instead of git hash, but the devs are wary of relying heavily on anything not in-repo | 12:49 |
*** brendangalloway has quit IRC | 12:49 | |
fungi | if brendangalloway comes back, he might like to know that gerrit refnames *are* in-repo (notesRef = refs/notes/review and make sure to fetch = +refs/notes/*:refs/notes/*) | 12:53 |
fungi | far more than just the refnames too, annotations about who approved, who voted, and so on | 12:55 |
*** tumble has joined #zuul | 12:55 | |
*** piotrowskim has joined #zuul | 12:56 | |
*** Goneri has joined #zuul | 13:13 | |
*** jamesmcarthur has quit IRC | 13:18 | |
*** bhavikdbavishi has quit IRC | 13:38 | |
mordred | avass: what's our strategy for testing roles that expect another role to have been run in a pre-playbook? | 14:02 |
mordred | this: https://review.opendev.org/#/c/739047/ is failing because nothing ever ran ensure-nodejs - should I just add a pre-playbook to the test job? | 14:03 |
* mordred tries that | 14:04 | |
openstackgerrit | Monty Taylor proposed zuul/zuul-jobs master: Add a job for publishing a site to netlify https://review.opendev.org/739047 | 14:04 |
corvus | mordred: that sounds good to me, or maybe just in the regular playbook? | 14:05 |
corvus | mordred: (that way you can run the new test job on changes to ensure-nodejs too and not have it retry on fail) | 14:05 |
mordred | corvus: well, Im using test-playbooks/simple-role-test.yaml as the regular playbook | 14:06 |
corvus | mordred: yeah, but as long as you're writing a playbook anyway... | 14:06 |
corvus | you can replace that | 14:06 |
mordred | oh - I can just use the existing preplaybook | 14:06 |
mordred | but - perhaps I should write a specific run playbook and do both things? | 14:07 |
*** rlandy is now known as rlandy|training | 14:07 | |
corvus | mordred: i think the germane question is: do you want to (also) run this job to test changes to ensure-nodejs? | 14:07 |
corvus | mordred: if yes: new main playbook with both; if no: (existing) pre-playbook is fine | 14:08 |
mordred | corvus: we could - but I'm not sure it's super important to | 14:08 |
mordred | I don't think this would really provide additional testing for that | 14:08 |
corvus | k, then probably keeping the test load down and using pre makes sense | 14:08 |
mordred | it just more assumes that it works and that it can use the results of it having been run | 14:08 |
mordred | cool | 14:08 |
openstackgerrit | Monty Taylor proposed zuul/zuul-jobs master: Add a job for publishing a site to netlify https://review.opendev.org/739047 | 14:09 |
*** hashar has joined #zuul | 14:28 | |
*** jamesmcarthur has joined #zuul | 14:30 | |
*** bhavikdbavishi has joined #zuul | 14:31 | |
*** bhavikdbavishi has quit IRC | 14:42 | |
*** bhavikdbavishi has joined #zuul | 14:44 | |
mordred | corvus, avass: yay, that ^^ is green now | 14:56 |
*** jamesmcarthur has quit IRC | 15:02 | |
*** nils has quit IRC | 15:19 | |
*** sgw1 has joined #zuul | 15:38 | |
*** bhavikdbavishi1 has joined #zuul | 15:45 | |
*** bhavikdbavishi has quit IRC | 15:46 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 15:46 | |
*** marios has quit IRC | 15:58 | |
*** jcapitao has quit IRC | 16:04 | |
*** wuchunyang has joined #zuul | 16:05 | |
*** wuchunyang has quit IRC | 16:10 | |
*** saneax has quit IRC | 16:21 | |
*** tumble has quit IRC | 16:23 | |
corvus | mordred: you'll appreciate https://review.opendev.org/742762 | 16:27 |
mordred | corvus: yas | 16:28 |
*** rlandy|training is now known as rlandy | 16:35 | |
zbr | i proposed a feature to ansible galaxy which could help us with zuul, please take a look https://github.com/ansible/galaxy/issues/2448 and add some feedback | 16:40 |
*** hashar has quit IRC | 16:46 | |
*** hamalq has joined #zuul | 16:46 | |
openstackgerrit | Clark Boylan proposed zuul/nodepool master: Add basic max-servers handling to the k8s driver https://review.opendev.org/743424 | 17:02 |
*** harrymichal has joined #zuul | 17:05 | |
*** jpena is now known as jpena|off | 17:16 | |
openstackgerrit | Merged zuul/zuul master: Use project vars for release_python https://review.opendev.org/742762 | 17:27 |
openstackgerrit | Merged zuul/zuul master: gitlab: implement git push support https://review.opendev.org/734159 | 17:53 |
tristanC | zbr: that looks like quite specific to zuul, could we do something similar to what the zuul-jobs tox role do with the requirements.txt instead? | 18:04 |
zbr | tristanC: i do not see what this has to do with tox or python deps | 18:05 |
zbr | yes, my example is from zuul use, but the feature I describe is not particular to zuul, can be any location | 18:06 |
zbr | tristanC: until few minutes ago, event he ability to install from local clone was not documented in galaxy, https://github.com/ansible/ansible/pull/70941/files | 18:08 |
tristanC | zbr: the tox role works in most case, would the fallback in galaxy requirements.yml kicks in only when a project includes the zuul src location? | 18:16 |
avass | corvus, mordred: I usually add the role to the test playbook or a pre-run and make sure any updates to that role also triggers the job to make sure it doesn't break without us noticing it | 18:16 |
zbr | tristanC: basically would be like "if foo dir found locally install from it instead of galaxy or whatever other src is mentioned there" | 18:17 |
zbr | you could chain as many sources you want and it will fail if none is available | 18:17 |
zbr | current behaviour is forcing us to either bypass install of reqs.yml or to have two different versions, one for zuul, and one for non zuul. | 18:19 |
avass | mordred: You could also just extend publish-javascript-to-netlify if we're okay with the test-job failing in post :) | 18:22 |
openstackgerrit | Merged zuul/zuul master: github: use change.message in squahsed commit message https://review.opendev.org/736019 | 18:42 |
openstackgerrit | Tobias Henkel proposed zuul/zuul master: Warn user when dynamic layout ignores zuul config https://review.opendev.org/720249 | 18:53 |
openstackgerrit | Tobias Henkel proposed zuul/zuul master: Use apt mirror infrastructure during zuul-quick-start https://review.opendev.org/649448 | 19:08 |
tobiash | corvus, clarkb: does opendev have mirror infrastructure for yarn stuff? | 19:13 |
clarkb | tobiash: we proxy cache npm, but not sure if yarn does something different | 19:14 |
tobiash | yarn can use npm afaik, but the zuul builds don't use it | 19:15 |
clarkb | tobiash: https://$mirrornode/registry.npmjs/ | 19:16 |
tobiash | clarkb: can you get me a url that works for local testing? | 19:16 |
*** hashar has joined #zuul | 19:17 | |
clarkb | tobiash: https://mirror.dfw.rax.opendev.org:4443/registry.npmjs/ sorry got the port wrong but that works | 19:19 |
clarkb | or at least via a browser, not sure about npm or yarn | 19:19 |
tobiash | thanks, will try it | 19:20 |
*** tosky has quit IRC | 19:25 | |
*** wuchunyang has joined #zuul | 19:30 | |
*** wuchunyang has quit IRC | 19:34 | |
openstackgerrit | Merged zuul/zuul master: gitlab - add the merge request updated test https://review.opendev.org/734869 | 19:40 |
openstackgerrit | Merged zuul/zuul master: gitlab - add dynamic reconfig test https://review.opendev.org/735186 | 19:40 |
openstackgerrit | Merged zuul/zuul master: gitlab - add test checking tenant reconfig when ref updated https://review.opendev.org/735187 | 19:45 |
openstackgerrit | Merged zuul/zuul master: gitlab: add enqueue/dequeue unit tests https://review.opendev.org/735188 | 19:45 |
openstackgerrit | Tobias Henkel proposed zuul/zuul master: Use npm mirrors in tox jobs https://review.opendev.org/743623 | 19:48 |
*** hashar has quit IRC | 19:50 | |
*** bhavikdbavishi has quit IRC | 19:51 | |
openstackgerrit | Merged zuul/zuul master: gitlab - Add support for depends-on dependency https://review.opendev.org/735189 | 19:52 |
*** mordred has quit IRC | 20:05 | |
tobiash | corvus: it looks like the test case test_project_override got unstable lately, last three tox-py35 failures are due to this test case: https://zuul.opendev.org/t/zuul/builds?job_name=tox-py35&job_name=tox-py38&result=FAILURE | 20:05 |
tobiash | however I didn't understand the error yet | 20:05 |
corvus | tobiash: wow, six projects. no doubt. :) | 20:16 |
*** mordred has joined #zuul | 20:18 | |
openstackgerrit | Tobias Henkel proposed zuul/zuul master: Use npm mirrors in tox jobs https://review.opendev.org/743623 | 20:21 |
corvus | tobiash: i think it's a sequencing problem; i'll work on a patch | 20:38 |
tobiash | awesome, thanks :) | 20:40 |
openstackgerrit | James E. Blair proposed zuul/zuul master: Sequence builds in test_executor https://review.opendev.org/743628 | 20:41 |
corvus | tobiash: ^ | 20:41 |
*** vishalmanchanda has quit IRC | 20:41 | |
*** rlandy is now known as rlandy|brb | 20:45 | |
*** evrardjp has joined #zuul | 20:55 | |
openstackgerrit | Merged zuul/zuul master: gitlab: support for the tag_push event https://review.opendev.org/735976 | 20:56 |
openstackgerrit | Merged zuul/zuul master: gitlab: update wording patchset to patch_number in getChange https://review.opendev.org/740504 | 20:56 |
*** rlandy|brb is now known as rlandy | 21:02 | |
*** rlandy has quit IRC | 21:28 | |
*** harrymichal has quit IRC | 22:13 | |
*** saneax has joined #zuul | 23:13 | |
*** piotrowskim has quit IRC | 23:22 | |
*** wuchunyang has joined #zuul | 23:30 | |
*** wuchunyang has quit IRC | 23:35 | |
*** hamalq has quit IRC | 23:48 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!