Tuesday, 2020-07-28

*** jamesmcarthur has joined #zuul00:12
*** rlandy|bbl is now known as rlandy00:32
*** Goneri has quit IRC00:39
*** hamalq has quit IRC00:41
*** SpamapS has quit IRC00:44
*** sgw1 has quit IRC00:48
*** gmann has quit IRC00:51
*** gmann has joined #zuul00:51
*** SpamapS has joined #zuul00:58
*** rfolco has quit IRC00:58
*** jamesmcarthur has quit IRC01:04
openstackgerritIan Wienand proposed zuul/zuul master: Give the focus to a <div> overlaying the main content  https://review.opendev.org/74344001:27
*** jamesmcarthur has joined #zuul01:37
*** jamesmcarthur has quit IRC01:48
*** rlandy has quit IRC01:50
*** jamesmcarthur has joined #zuul02:51
*** sgw1 has joined #zuul02:53
*** SpamapS has quit IRC03:06
*** SpamapS has joined #zuul03:09
*** bhavikdbavishi has joined #zuul03:10
*** bhavikdbavishi1 has joined #zuul03:15
*** jamesmcarthur has quit IRC03:15
*** SpamapS has quit IRC03:15
*** bhavikdbavishi has quit IRC03:17
*** bhavikdbavishi1 is now known as bhavikdbavishi03:17
*** y2kenny has quit IRC04:12
*** bhavikdbavishi has quit IRC04:22
*** vishalmanchanda has joined #zuul04:22
*** bhavikdbavishi has joined #zuul04:23
*** evrardjp has quit IRC04:33
*** evrardjp has joined #zuul04:33
*** sgw1 has quit IRC04:53
*** SpamapS has joined #zuul05:06
openstackgerritSimon Westphahl proposed zuul/zuul master: Check cycle items are mergeable before reporting  https://review.opendev.org/74345005:11
*** nils has joined #zuul05:32
*** bhavikdbavishi1 has joined #zuul05:59
*** bhavikdbavishi has quit IRC06:00
*** bhavikdbavishi1 is now known as bhavikdbavishi06:00
*** bhagyashris|away is now known as bhagyashris06:01
*** marios has joined #zuul06:03
*** bhavikdbavishi has quit IRC06:27
*** bhavikdbavishi has joined #zuul06:51
*** yolanda has quit IRC06:52
*** yolanda has joined #zuul06:52
*** bhavikdbavishi has quit IRC07:03
*** bhavikdbavishi has joined #zuul07:05
*** jcapitao has joined #zuul07:12
*** tosky has joined #zuul07:42
*** jpena|off is now known as jpena07:54
*** bhagyashris is now known as bhagyashris|lunc08:10
*** hashar has joined #zuul08:25
*** wuchunyang has joined #zuul08:59
openstackgerritIan Wienand proposed zuul/zuul master: Give the focus to a <div> overlaying the main content  https://review.opendev.org/74344009:35
openstackgerritSimon Westphahl proposed zuul/zuul master: Check cycle items are mergeable before reporting  https://review.opendev.org/74345009:36
*** brendangalloway has joined #zuul09:37
*** bhagyashris|lunc is now known as bhagyashris09:41
brendangallowayHello, is there any way to have the speculative merger create the repo as it would be after merging (ie using the change's commit message, rather than a temporary merge message)?09:42
*** bhavikdbavishi has quit IRC09:50
*** bhavikdbavishi has joined #zuul10:17
felixedeliawn: I've answered to your comments directly in my change https://review.opendev.org/#/c/743239/110:20
felixedel^ianw10:20
*** wuchunyang has quit IRC10:21
openstackgerritMerged zuul/nodepool master: Remove default qcow2 format in diskimage config  https://review.opendev.org/74116610:23
*** bhavikdbavishi has quit IRC10:30
*** wuchunyang has joined #zuul10:53
*** saneax has joined #zuul10:53
*** armstrongs has joined #zuul10:59
*** jcapitao is now known as jcapitao_lunch11:04
*** wuchunyang has quit IRC11:05
*** bhagyashris is now known as bhagyashris|away11:06
*** armstrongs has quit IRC11:08
*** wuchunyang has joined #zuul11:12
*** wuchunyang has quit IRC11:23
*** wuchunyang has joined #zuul11:23
*** jpena is now known as jpena|lunch11:28
*** bhagyashris|away is now known as bhagyashris11:36
*** bhavikdbavishi has joined #zuul11:37
fungibrendangalloway: i'm not sure i follow your question. zuul attempts to emulate the merge commit which your code hosting platform will eventually create when the change finally merges. are you wanting it to more closely emulate the merge commit message the code hosting platform will create? also if the change is fast-forwardable zuul doesn't create a merge commit, it only creates a merge commit if the change11:56
fungineeds one11:56
*** jcapitao_lunch is now known as jcapitao11:58
*** evrardjp has quit IRC12:00
brendangallowaySo the context to the question is we have some build artefacts that were getting generated in gate and then consumed elsewhere.  Rebuilding the artefacts in post with exactly the same job was seen as a waste - the artefact is only moved to the artefact store if the gate passes.  The artefacts are tagged with the git hash as zuul see it.  However,12:01
brendangallowaywhen trying to trace an artefact, that hash is not in the repo.  When we investigated further, we see that the commit message during gate is 'Merge commit 'refs/changes/29/4129/2' of ssh://<<repo>> into HEAD', while the commit message of the merged change is 'merge <commit title>'.  It would seem the different message is what is causing the12:01
brendangallowaydifferent git hash.12:01
*** rfolco has joined #zuul12:02
*** wuchunyang has quit IRC12:04
*** hashar has quit IRC12:05
fungithe date/time of the merge will also affect the hash12:07
fungiwhich zuul won't be able to predict12:07
fungiwe also struggle with the same problem in opendev/for zuul's own artifacts, so i agree finding a solution would be great12:08
fungicurrently our docker images built in the gate pipeline and published from the promote pipeline don't have the same commit id as what gets merged to the branch of the repository, for these reasons12:09
*** rlandy has joined #zuul12:10
fungithe best idea we have to solve it at this point is for zuul to gain the ability to push its merge commits directly to the public branch in the code hosting platform, rather than asking the code hosting platform to do the final merging12:10
fungithen the timestamp and commit message and parentage, and therefore the commit id itself, will match between what the gate pipeline sees and what ends up in the repository12:11
brendangallowayok, for now we are moving the jobs to post to run after the commit has occurred, in order to correctly label the artefacts.  I just wanted to confirm there isn't some other way we could still have it correct while generating in gate12:12
fungiyeah, for our artifacts we've decided not to build them in post because there's a slight race that the images built after merge might not have quite the same contents as those tested in the gate pipeline12:13
fungiand for our purposes, publishing the artifacts we tested is more important than having the commit id embedded in the build versions match the commit id in the public repo (granted, we'd love to have that too)12:15
*** jamesmcarthur has joined #zuul12:16
*** holser has quit IRC12:30
*** holser has joined #zuul12:31
*** jpena|lunch is now known as jpena12:34
mordredyeah - zuul push should help this12:36
mordredbrendangalloway: fwiw - in our docker image build jobs we have zuul write some metadata into the image about the change in question to facilitate that sort of traceability that gets lost when using a gate built artifact. I'm not sure if there is any good way to do a similar thing in your artifacts, but maybe12:38
*** holser has quit IRC12:39
*** holser has joined #zuul12:40
mordredbrendangalloway: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/build-docker-image/tasks/build.yaml#L25-L2812:41
brendangallowaymordred:  I've also suggested using refs or gerrit change IDs as reference instead of git hash, but the devs are wary of relying heavily on anything not in-repo12:49
*** brendangalloway has quit IRC12:49
fungiif brendangalloway comes back, he might like to know that gerrit refnames *are* in-repo (notesRef = refs/notes/review and make sure to fetch = +refs/notes/*:refs/notes/*)12:53
fungifar more than just the refnames too, annotations about who approved, who voted, and so on12:55
*** tumble has joined #zuul12:55
*** piotrowskim has joined #zuul12:56
*** Goneri has joined #zuul13:13
*** jamesmcarthur has quit IRC13:18
*** bhavikdbavishi has quit IRC13:38
mordredavass: what's our strategy for testing roles that expect another role to have been run in a pre-playbook?14:02
mordredthis: https://review.opendev.org/#/c/739047/ is failing because nothing ever ran ensure-nodejs - should I just add a pre-playbook to the test job?14:03
* mordred tries that14:04
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Add a job for publishing a site to netlify  https://review.opendev.org/73904714:04
corvusmordred: that sounds good to me, or maybe just in the regular playbook?14:05
corvusmordred: (that way you can run the new test job on changes to ensure-nodejs too and not have it retry on fail)14:05
mordredcorvus: well, Im using test-playbooks/simple-role-test.yaml as the regular playbook14:06
corvusmordred: yeah, but as long as you're writing a playbook anyway...14:06
corvusyou can replace that14:06
mordredoh - I can just use the existing preplaybook14:06
mordredbut - perhaps I should write a specific run playbook and do both things?14:07
*** rlandy is now known as rlandy|training14:07
corvusmordred: i think the germane question is: do you want to (also) run this job to test changes to ensure-nodejs?14:07
corvusmordred: if yes: new main playbook with both; if no: (existing) pre-playbook is fine14:08
mordredcorvus: we could - but I'm not sure it's super important to14:08
mordredI don't think this would really provide additional testing for that14:08
corvusk, then probably keeping the test load down and using pre makes sense14:08
mordredit just more assumes that it works and that it can use the results of it having been run14:08
mordredcool14:08
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Add a job for publishing a site to netlify  https://review.opendev.org/73904714:09
*** hashar has joined #zuul14:28
*** jamesmcarthur has joined #zuul14:30
*** bhavikdbavishi has joined #zuul14:31
*** bhavikdbavishi has quit IRC14:42
*** bhavikdbavishi has joined #zuul14:44
mordredcorvus, avass: yay, that ^^ is green now14:56
*** jamesmcarthur has quit IRC15:02
*** nils has quit IRC15:19
*** sgw1 has joined #zuul15:38
*** bhavikdbavishi1 has joined #zuul15:45
*** bhavikdbavishi has quit IRC15:46
*** bhavikdbavishi1 is now known as bhavikdbavishi15:46
*** marios has quit IRC15:58
*** jcapitao has quit IRC16:04
*** wuchunyang has joined #zuul16:05
*** wuchunyang has quit IRC16:10
*** saneax has quit IRC16:21
*** tumble has quit IRC16:23
corvusmordred: you'll appreciate https://review.opendev.org/74276216:27
mordredcorvus: yas16:28
*** rlandy|training is now known as rlandy16:35
zbri proposed a feature to ansible galaxy which could help us with zuul, please take a look https://github.com/ansible/galaxy/issues/2448 and add some feedback16:40
*** hashar has quit IRC16:46
*** hamalq has joined #zuul16:46
openstackgerritClark Boylan proposed zuul/nodepool master: Add basic max-servers handling to the k8s driver  https://review.opendev.org/74342417:02
*** harrymichal has joined #zuul17:05
*** jpena is now known as jpena|off17:16
openstackgerritMerged zuul/zuul master: Use project vars for release_python  https://review.opendev.org/74276217:27
openstackgerritMerged zuul/zuul master: gitlab: implement git push support  https://review.opendev.org/73415917:53
tristanCzbr: that looks like quite specific to zuul, could we do something similar to what the zuul-jobs tox role do with the requirements.txt instead?18:04
zbrtristanC: i do not see what this has to do with tox or python deps18:05
zbryes, my example is from zuul use, but the feature I describe is not particular to zuul, can be any location18:06
zbrtristanC: until few minutes ago, event he ability to install from local clone was not documented in galaxy, https://github.com/ansible/ansible/pull/70941/files18:08
tristanCzbr: the tox role works in most case, would the fallback in galaxy requirements.yml kicks in only when a project includes the zuul src location?18:16
avasscorvus, mordred: I usually add the role to the test playbook or a pre-run and make sure any updates to that role also triggers the job to make sure it doesn't break without us noticing it18:16
zbrtristanC: basically would be like "if foo dir found locally install from it instead of galaxy or whatever other src is mentioned there"18:17
zbryou could chain as many sources you want and it will fail if none is available18:17
zbrcurrent behaviour is forcing us to either bypass install of reqs.yml or to have two different versions, one for zuul, and one for non zuul.18:19
avassmordred: You could also just extend publish-javascript-to-netlify if we're okay with the test-job failing in post :)18:22
openstackgerritMerged zuul/zuul master: github: use change.message in squahsed commit message  https://review.opendev.org/73601918:42
openstackgerritTobias Henkel proposed zuul/zuul master: Warn user when dynamic layout ignores zuul config  https://review.opendev.org/72024918:53
openstackgerritTobias Henkel proposed zuul/zuul master: Use apt mirror infrastructure during zuul-quick-start  https://review.opendev.org/64944819:08
tobiashcorvus, clarkb: does opendev have mirror infrastructure for yarn stuff?19:13
clarkbtobiash: we proxy cache npm, but not sure if yarn does something different19:14
tobiashyarn can use npm afaik, but the zuul builds don't use it19:15
clarkbtobiash: https://$mirrornode/registry.npmjs/19:16
tobiashclarkb: can you get me a url that works for local testing?19:16
*** hashar has joined #zuul19:17
clarkbtobiash: https://mirror.dfw.rax.opendev.org:4443/registry.npmjs/ sorry got the port wrong but that works19:19
clarkbor at least via a browser, not sure about npm or yarn19:19
tobiashthanks, will try it19:20
*** tosky has quit IRC19:25
*** wuchunyang has joined #zuul19:30
*** wuchunyang has quit IRC19:34
openstackgerritMerged zuul/zuul master: gitlab - add the merge request updated test  https://review.opendev.org/73486919:40
openstackgerritMerged zuul/zuul master: gitlab - add dynamic reconfig test  https://review.opendev.org/73518619:40
openstackgerritMerged zuul/zuul master: gitlab - add test checking tenant reconfig when ref updated  https://review.opendev.org/73518719:45
openstackgerritMerged zuul/zuul master: gitlab: add enqueue/dequeue unit tests  https://review.opendev.org/73518819:45
openstackgerritTobias Henkel proposed zuul/zuul master: Use npm mirrors in tox jobs  https://review.opendev.org/74362319:48
*** hashar has quit IRC19:50
*** bhavikdbavishi has quit IRC19:51
openstackgerritMerged zuul/zuul master: gitlab - Add support for depends-on dependency  https://review.opendev.org/73518919:52
*** mordred has quit IRC20:05
tobiashcorvus: it looks like the test case test_project_override got unstable lately, last three tox-py35 failures are due to this test case: https://zuul.opendev.org/t/zuul/builds?job_name=tox-py35&job_name=tox-py38&result=FAILURE20:05
tobiashhowever I didn't understand the error yet20:05
corvustobiash: wow, six projects.  no doubt.  :)20:16
*** mordred has joined #zuul20:18
openstackgerritTobias Henkel proposed zuul/zuul master: Use npm mirrors in tox jobs  https://review.opendev.org/74362320:21
corvustobiash: i think it's a sequencing problem; i'll work on a patch20:38
tobiashawesome, thanks :)20:40
openstackgerritJames E. Blair proposed zuul/zuul master: Sequence builds in test_executor  https://review.opendev.org/74362820:41
corvustobiash: ^20:41
*** vishalmanchanda has quit IRC20:41
*** rlandy is now known as rlandy|brb20:45
*** evrardjp has joined #zuul20:55
openstackgerritMerged zuul/zuul master: gitlab: support for the tag_push event  https://review.opendev.org/73597620:56
openstackgerritMerged zuul/zuul master: gitlab: update wording patchset to patch_number in getChange  https://review.opendev.org/74050420:56
*** rlandy|brb is now known as rlandy21:02
*** rlandy has quit IRC21:28
*** harrymichal has quit IRC22:13
*** saneax has joined #zuul23:13
*** piotrowskim has quit IRC23:22
*** wuchunyang has joined #zuul23:30
*** wuchunyang has quit IRC23:35
*** hamalq has quit IRC23:48

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!