Thursday, 2020-06-18

openstackgerritIan Wienand proposed zuul/zuul-jobs master: [FOR DISCUSSION] Revert "Ensure wheel exists for build-release-python"  https://review.opendev.org/73640200:03
*** rfolco|rover has joined #zuul00:05
*** jamesmcarthur has joined #zuul00:10
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "Use zuul jobs"  https://review.opendev.org/73206800:12
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate pipeline"  https://review.opendev.org/73206900:12
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "job secrets"  https://review.opendev.org/73207000:12
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "job dependencies"  https://review.opendev.org/73207100:12
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Fix zuul_run_command ret when command is not found  https://review.opendev.org/73547500:12
openstackgerritGuillaume Chauvel proposed zuul/zuul master: zuul_stream: close streamer when task is skipped  https://review.opendev.org/73547600:12
openstackgerritGuillaume Chauvel proposed zuul/zuul master: DNM: execute zuul tutorial jobs with pending zuul-jobs changes  https://review.opendev.org/73547700:12
openstackgerritGuillaume Chauvel proposed zuul/zuul master: POC: test job multinode (zuul_stream+callback test)  https://review.opendev.org/73548300:12
openstackgerritGuillaume Chauvel proposed zuul/zuul master: WIP: Add 'uuid' to 'src_dir' in order to allow parallel jobs for a static node  https://review.opendev.org/73598100:12
openstackgerritGuillaume Chauvel proposed zuul/zuul master: POC: test 'uuid' in 'src_dir', 1 static/4 parallel jobs  https://review.opendev.org/73557600:12
*** Goneri has quit IRC00:22
*** jamesmcarthur has quit IRC00:24
mordredianw: the original fix for wheel used become - and broken ansible's zuul00:27
ianwmordred: https://review.opendev.org/#/c/736001/5/roles/build-python-release/tasks/main.yaml isn't in the pre-run phase where it already uses "ensure-pip" though, right?00:29
mordredianw: there was no ensure-pip in a pre at that point - so mayb ethat would be the fix00:32
mordredhonestly - I'm super confused by what's supposed to work and what's not at this point00:33
mordredso if there is a better way - cool00:34
ianw name: build-python-release00:34
ianwpre-run: playbooks/python/pre.yaml00:34
ianwwhich runs ensure-pip00:34
ianwit looks like the "wheel" binary is in python-wheel-common, which is separate to python3-wheel ... sigh00:35
mordredwell - we don't need the wheel binary00:36
mordredwe need bdist_wheel00:36
mordredso that python setup.py bdist wheel works :)00:36
mordredso maybe that makes it easier00:37
* mordred has to EOD ...00:37
ianwmordred: yeah i think it does, and if for some reason we *need* the wheel binary, it would be logical to add it along there if someone just wants to unravel what package goes where00:37
ianwmordred: ttyl :)00:38
*** rfolco|rover has quit IRC00:47
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [FOR DISCUSSION] Revert "Ensure wheel exists for build-release-python"  https://review.opendev.org/73640200:55
*** jamesmcarthur has joined #zuul00:58
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [FOR DISCUSSION] Revert "Ensure wheel exists for build-release-python"  https://review.opendev.org/73640200:58
*** jamesmcarthur has quit IRC01:00
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [FOR DISCUSSION] Revert "Ensure wheel exists for build-release-python"  https://review.opendev.org/73640201:01
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [FOR DISCUSSION] Revert "Ensure wheel exists for build-release-python"  https://review.opendev.org/73640201:11
*** jamesmcarthur has joined #zuul01:14
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [FOR DISCUSSION] Revert "Ensure wheel exists for build-release-python"  https://review.opendev.org/73640201:19
*** rfolco|rover has joined #zuul01:23
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [FOR DISCUSSION] Revert "Ensure wheel exists for build-release-python"  https://review.opendev.org/73640201:26
ianwwriting it is easy ... testing it properly is ... not :)01:26
ianwwhy are we testing stretch and not buster?01:30
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [FOR DISCUSSION] Revert "Ensure wheel exists for build-release-python"  https://review.opendev.org/73640201:41
*** jamesmcarthur has quit IRC01:43
*** swest has quit IRC01:50
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [FOR DISCUSSION] Revert "Ensure wheel exists for build-release-python"  https://review.opendev.org/73640201:51
*** jamesmcarthur has joined #zuul02:00
*** swest has joined #zuul02:04
*** bhavikdbavishi has joined #zuul02:49
*** bhavikdbavishi1 has joined #zuul02:52
*** bhavikdbavishi has quit IRC02:53
*** bhavikdbavishi1 is now known as bhavikdbavishi02:53
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [FOR DISCUSSION] Revert "Ensure wheel exists for build-release-python"  https://review.opendev.org/73640203:21
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [FOR DISCUSSION] Revert "Ensure wheel exists for build-release-python"  https://review.opendev.org/73640203:31
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [WIP] Revert "Ensure wheel exists for build-release-python"; move to ensure-pip  https://review.opendev.org/73640203:57
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [WIP] Revert "Ensure wheel exists for build-release-python"; move to ensure-pip  https://review.opendev.org/73640204:04
openstackgerritIan Wienand proposed zuul/zuul-jobs master: Partial revert "Ensure wheel exists for build-release-python"; move to ensure-pip  https://review.opendev.org/73640204:19
*** evrardjp has quit IRC04:33
*** evrardjp has joined #zuul04:33
*** jamesmcarthur has quit IRC04:52
*** jamesmcarthur has joined #zuul04:52
*** ysandeep|away is now known as ysandeep04:58
*** jamesmcarthur has quit IRC04:58
*** sgw1 has quit IRC05:03
*** rlandy|bbl has quit IRC05:08
*** felixedel has joined #zuul05:13
*** jamesmcarthur has joined #zuul05:26
*** bhavikdbavishi has quit IRC05:26
*** jamesmcarthur has quit IRC05:38
*** bhavikdbavishi has joined #zuul05:42
*** paulalbertella has quit IRC05:42
*** reiterative has joined #zuul05:43
*** sanjayu_ has joined #zuul05:51
AJaegerianw: could you check https://review.opendev.org/#/c/736379/1/test-playbooks/ensure-pip.yaml , please?05:53
AJaegermordred, ianw, corvus, clarkb, publish-openstack-python-branch-tarball still fails, see https://zuul.opendev.org/t/openstack/build/61fdd71509e6456397eeb6ca05d186b105:58
ianwAJaeger: hrm, that says it's missing setuptools06:00
AJaegerand test-release-openstack is failing as well, https://zuul.opendev.org/t/openstack/build/4f3e5bcc6e77409c90eb3dc08b5fe472 - invalid command 'bdist_wheel'06:00
ianwif it hasn't run ensure-pip, nothing may have brought in setuptools06:00
ianwhttps://review.opendev.org/736402 would fix that; it brings in setuptools along with pip, as pip: module needs setuptools06:01
AJaegerianw: great! I didn't have time to go through 402 yet06:01
AJaegerianw: can we do a depends-on testing test-release-openstack with 402?06:02
ianwummm, maybe?  is there an example from when the ensure-wheel role went in?06:03
AJaegerwhat about taking one of the fails?06:06
ianwbut does that work in the check queue?06:06
AJaegeror check https://zuul.opendev.org/t/openstack/builds?job_name=test-release-openstack06:06
AJaegeryes06:06
AJaegerand test-release-openstack tests parts of the publish part, so if that works, we're nearly there ;)06:07
openstackgerritMerged zuul/zuul-jobs master: Fix ansible-lint rules tests  https://review.opendev.org/73638706:11
ianwAJaeger: i put in https://review.opendev.org/736443 to test06:12
AJaegerianw: thanks. I added a lengthy comment to your review to point out what I know so that we can evaluate those together.06:15
AJaegerianw: found a nit in case you want to respin or do a followup.06:15
ianwAJaeger: thanks ... i mean the original pip-and-virtualenv must have been bringing in wheel somewhat accidentally.  afair it was certainly never explicitly installed as part of that, and now it's gone missing06:16
AJaegerianw: oh fun :(06:18
*** yolanda has quit IRC06:31
*** yolanda has joined #zuul06:36
*** noonedeadpunk has joined #zuul06:41
*** rpittau|afk is now known as rpittau06:43
*** hashar has joined #zuul06:54
*** bhavikdbavishi has quit IRC07:05
*** jcapitao has joined #zuul07:16
*** tosky has joined #zuul07:25
felixedelianw: What's the state about https://review.opendev.org/#/c/733564/ Did the runs of the test-job went well so far? :)07:28
*** harrymichal has joined #zuul07:31
AJaegerrequirements-check is failing sometimes, see https://zuul.opendev.org/t/openstack/builds?job_name=requirements-check with pip3 not found - "pip3 install --user src/opendev.org/openstack/requirements "07:34
*** bhavikdbavishi has joined #zuul07:36
* AJaeger is on it07:36
*** bhavikdbavishi1 has joined #zuul07:39
*** bhavikdbavishi has quit IRC07:41
*** bhavikdbavishi1 is now known as bhavikdbavishi07:41
*** harrymichal has quit IRC07:43
*** jpena|off is now known as jpena07:57
*** nils has joined #zuul08:08
*** ysandeep is now known as ysandeep|lunch08:30
ianwfelixedel: i'm not sure?  was a test job proposed to test it?08:37
ianwfelixedel: the testing procedure is described at https://opendev.org/opendev/base-jobs/src/branch/master/zuul.d/jobs.yaml#L1008:39
jktguilhermesp: a gentle ping about zuul.vexxhost.dev08:45
felixedelianw: Sry, than maybe I understood that wrong. I thought that there is already a testjob in place and you just wanted to execute it :D08:58
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add linting rule to enforce no-same-owner policy  https://review.opendev.org/72764209:06
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Add linting rule to enforce no-same-owner policy  https://review.opendev.org/72764209:08
*** felixedel has quit IRC09:10
*** ysandeep|lunch is now known as ysandeep09:12
openstackgerritMatthieu Huin proposed zuul/zuul master: REST API: improve tenant scoping of autohold, authorizations  https://review.opendev.org/72811809:21
openstackgerritMatthieu Huin proposed zuul/zuul master: CLI: add autohold-info, autohold-delete via REST  https://review.opendev.org/72841009:21
openstackgerritMatthieu Huin proposed zuul/zuul master: web UI: user login with OpenID Connect  https://review.opendev.org/73408209:21
openstackgerritMatthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to dequeue a change  https://review.opendev.org/73485009:22
avasszuul-jobs-maint: synchronize/unarchive linting rule is ready: https://review.opendev.org/#/c/727642/09:22
*** ysandeep is now known as ysandeep|afk09:35
*** jamesmcarthur has joined #zuul09:35
*** jamesmcarthur has quit IRC09:49
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Add ensure-pip to zuul-stream playbook  https://review.opendev.org/73652009:57
*** rpittau is now known as rpittau|bbl10:06
*** dennis_effa has joined #zuul10:13
*** ysandeep|afk is now known as ysandeep10:14
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Drop support for ansible 2.6  https://review.opendev.org/72715810:15
avassit's been 4 weeks since we dropped support for ansible 2.6 in zuul so should we go ahead with that ^ now?10:17
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate pipeline"  https://review.opendev.org/73206910:18
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "job secrets"  https://review.opendev.org/73207010:18
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "job dependencies"  https://review.opendev.org/73207110:18
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Fix zuul_run_command ret when command is not found  https://review.opendev.org/73547510:18
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Drop support for ansible 2.7  https://review.opendev.org/72741010:23
*** jcapitao is now known as jcapitao_lunch10:37
mordredianw: that update looks great to me!11:23
openstackgerritAndreas Jaeger proposed zuul/zuul-jobs master: nit: Fix missing word in roles/ensure-pip/README.rst  https://review.opendev.org/73661711:25
openstackgerritGuillaume Chauvel proposed zuul/zuul master: zuul_stream: close streamer when task is skipped  https://review.opendev.org/73547611:25
openstackgerritGuillaume Chauvel proposed zuul/zuul master: DNM: execute zuul tutorial jobs with pending zuul-jobs changes  https://review.opendev.org/73547711:25
openstackgerritGuillaume Chauvel proposed zuul/zuul master: POC: test job multinode (zuul_stream+callback test)  https://review.opendev.org/73548311:25
openstackgerritGuillaume Chauvel proposed zuul/zuul master: WIP: Add 'uuid' to 'src_dir' in order to allow parallel jobs for a static node  https://review.opendev.org/73598111:25
openstackgerritGuillaume Chauvel proposed zuul/zuul master: POC: test 'uuid' in 'src_dir', 1 static/4 parallel jobs  https://review.opendev.org/73557611:25
*** jcapitao_lunch is now known as jcapitao11:27
mordredavass: after all of yesterday's work around getting wheel installed, ianw made a patch that's a bit different but I think is better11:33
mordredavass: https://review.opendev.org/#/c/736402/11:36
mordredavass: tested by https://review.opendev.org/#/c/736443/11:36
*** jpena is now known as jpena|lunch11:38
*** jcapitao has quit IRC11:46
*** jcapitao has joined #zuul11:49
*** rlandy has joined #zuul11:50
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: phoronix-test-suite: extract ensure- role from run playbook  https://review.opendev.org/73636811:54
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: Add ensure pre-run policy to ansible-lint  https://review.opendev.org/73636711:54
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: Add ensure pre-run policy to ansible-lint  https://review.opendev.org/73636711:55
*** wuchunyang has joined #zuul12:03
*** bhavikdbavishi has quit IRC12:04
openstackgerritGuillaume Chauvel proposed zuul/zuul master: POC: test 'uuid' in 'src_dir', 1 static/4 parallel jobs  https://review.opendev.org/73557612:12
*** sgw1 has joined #zuul12:14
*** rpittau|bbl is now known as rpittau12:20
*** wuchunyang has quit IRC12:24
*** dennis_effa has quit IRC12:26
*** jpena|lunch is now known as jpena12:38
*** bhavikdbavishi has joined #zuul12:43
*** ysandeep is now known as ysandeep|brb12:47
avassmordred: should Suse install python3-wheel for python2?12:50
avassAJaeger: ^?12:51
mordredavass: almost certainly not :)12:51
mordredavass: lemme update that real quick12:51
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Partial revert "Ensure wheel exists for build-release-python"; move to ensure-pip  https://review.opendev.org/73640212:52
mordredavass: published edit12:52
mordredgreat catch!12:52
openstackgerritGuillaume Chauvel proposed zuul/zuul master: WIP: Add 'uuid' to 'src_dir' in order to allow parallel jobs for a static node  https://review.opendev.org/73598112:52
openstackgerritGuillaume Chauvel proposed zuul/zuul master: POC: test 'uuid' in 'src_dir', 1 static/4 parallel jobs  https://review.opendev.org/73557612:52
avassmordred: also not sure why we're checking ansible_python.version.major 2 for Redhat but nowhere else12:53
mordredavass: yeah - I'm not sure why we care about ansible-python at all tbh12:55
mordredavass: but the ansible_python.version.major == 3 check was already in there12:55
mordredso - shrug?12:55
avassI guess so huh12:56
*** noonedeadpunk is now known as noonedeadpunk_12:57
AJaegeravass, mordred, good catch, thanks!12:58
avassmordred: otherwise it looks good, I'll get back to preparing for midsummer tomorrow :)12:58
avassbut I'd rather someone add a comment to why Redhat checks ansible_python version12:59
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Drop support for ansible 2.7  https://review.opendev.org/72741013:11
*** sshnaidm is now known as sshnaidm|mtg13:23
*** ysandeep|brb is now known as ysandeep13:29
openstackgerritJens Harbott (frickler) proposed zuul/zuul-jobs master: Fix with_* loop for ansible 2.9  https://review.opendev.org/73671413:33
zbranother zuul UX issue: page lacking essential information: project, patch and job-name: https://review.rdoproject.org/zuul/build/97eac8964a5646f98a541b6d13fa898b/console13:38
zbrunless I chick on summary tab, it will be impossible to figure it out where this run from.13:39
zbrnot only that this should be included in the page, but it should also be sticky/floating, like the top menubar.13:39
mhuI get you, but the summary tab is just one click away ...13:40
zbryes, but you need to browse back if you go there, changes context twice13:40
zbralso to reach summary page you need to scroll up from where you are13:40
zbrcontext can easily be mentioned in a single line, it does not need to take more then one line, but it needs to stay on screen all the time.13:41
zbrneither the build URL helps because either it does not include the build name or is so long that is no longer visible in the address bar.13:42
fungithough also relying on the url to be displayed at all is probably a poor choice, regardless of whether breadcrubms about where you are have been embedded there or not13:44
openstackgerritMatthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to dequeue a change  https://review.opendev.org/73485013:45
* fungi often runs browsers in chromeless mode without buttons, tabs, titles or location bar showing, to save screen real estate13:45
*** jamesmcarthur has joined #zuul13:46
*** Goneri has joined #zuul13:47
*** jamesmcarthur has quit IRC13:51
*** Goneri has quit IRC13:55
*** bhavikdbavishi has quit IRC13:56
zbrfungi: what I wanted to check is if others would support a change that aims to make these "basic" information visibale on the webpage at all time.13:57
openstackgerritAndreas Jaeger proposed zuul/zuul-jobs master: nit: Fix missing word in roles/ensure-pip/README.rst  https://review.opendev.org/73661713:57
AJaegerfungi: that's the followup change to address one of your comments ^13:57
zbras i do not want to spend weeks working on that feature and discover that some don't like it, of don't find it useful.13:57
openstackgerritAndreas Jaeger proposed zuul/zuul-jobs master: phoronix-test-suite: extract ensure- role from run playbook  https://review.opendev.org/73636813:58
openstackgerritAndreas Jaeger proposed zuul/zuul-jobs master: Add ensure pre-run policy to ansible-lint  https://review.opendev.org/73636713:58
zbri personally find the ensure-wheel role result of lack of vision. Are we now looking to create another one ensure-pep517.build one? or another one for twine,....13:59
zbris not that we do not need a role to install it, but we need a reusable role to ensure a pypi requirement in general, one that is extensible.14:00
*** jamesmcarthur has joined #zuul14:00
zbrin fact, maybe we can even use a ensure-pip to install extra tools, and have a variable that defines them.14:01
*** rfolco|rover is now known as rfolco14:01
fungizbr: the outcome there was that pip already needs wheel anyway, and the chances you're going to use wheel without having pip are low, so installing wheel with the ensure-pip role makes sense14:01
*** dennis_effa has joined #zuul14:01
fungi(pip doesn't install sdists directly, it creates a wheel from them and then installs that)14:02
mordredalso - it turns out the correct solution from ianw is not to install wheel from pypi at all - but, like pip, to instal it from distro packages14:07
fungithat also gets us a wheel version contemporary with the pip version14:08
mordredyeah.14:08
*** Goneri has joined #zuul14:08
mordredthe reason to have some ensure- roles (I agree, it's not necessary to have one for each thing you can install from pypi) - is to nagivate figuring out if someone has pre-installed a given common tool, which can happen in multiple ways, and if not to intsall it- again usually supporting multiple different site-specific deployment choices - so that a given job can express "I need fundamental tool x" - and we can14:10
mordredprovide that without needing to have stuff pre-baked into image but also not having job authors having to understand everything about structural choices deployers have made14:10
mordredit's always going to be a judgement call as to whether something needs an ensure- role14:10
mordredI agree - if all the role does is "pip install foo" - that would be silly14:11
mordredmost of our ensure- roles are a bit more complex than that14:11
openstackgerritMerged zuul/zuul-jobs master: Partial revert "Ensure wheel exists for build-release-python"; move to ensure-pip  https://review.opendev.org/73640214:12
mnasermordred: i think ensure-foo being simple does have another benefit of running inside pre so if it depends on any network resource that fails, it gives you that 3 retry thing14:16
mnaserso even if its really simple, it does add the benefit of making the job a bit more reliable, but we can also totally replace that with retries inside ansible (but that wouldn't protect us from landing on a bad node and failing a job)14:16
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: tox: allow tox to be upgraded  https://review.opendev.org/69005714:18
openstackgerritMerged zuul/zuul-jobs master: nit: Fix missing word in roles/ensure-pip/README.rst  https://review.opendev.org/73661714:19
zbri think that ianw is not aware about the fact that newer wheel is required for building projects using pyproject.toml14:19
zbri am almost sure that centos-7 will fail to build with some distro wheel (i have one in particular in mind)14:20
mordredzbr: then I think in that case people wanting to run build-python-release should not use a centos-7 node14:21
mordredor - if that's important for an administrator of a zuul system providing centos-7 nodes, pre-installing a newer wheel in their images should avoid the use of that role14:21
*** hashar has quit IRC14:21
zbrmordred: i am not using it, but the same issue applies to other distros. they may be working today, but sooner or later the wheel package may lack behind long enough to break some builds.14:22
mordredthe ensure-pip system as it is written installs pip from packages, because people feel that using the version of the tools that comes with the distro under test is important - especially when people are doing integration testing of production deployments14:22
zbri think that all agreed that pre-hacking system images was a bad idea14:22
mordredwhile I *personally* would *never* install pip from packages14:22
mordredthis isn't about my personal preferences :)14:23
zbrmordred: we share that personal preference, when I see pip 9.0 ..., i step back and scream.14:23
mordredyup. but overall the design was agreed on that distro packages would be used for these things since they are easy for job content to unintsall and replace with something else of their choosing as needed14:26
mordredand - in general, for jobs like "build-python-release" - as long as that is run on a recent base image things should be fine14:26
*** noonedeadpunk_ is now known as noonedeadpunk14:29
openstackgerritMerged zuul/zuul master: Shift docker and pip setup to pre-playbook for quick-start  https://review.opendev.org/73591014:29
corvusmordred: i think i'm caught up on the latest wheel stuff in 736402; makes sense.  anything else need attention?14:33
*** Goneri has quit IRC14:35
fungii'm working with the openstack release team to test the updated state of that stuff by reenqueuing a recent failure in opendev14:36
mordredcorvus: I don't think so - to my knowledge I think it's solid now14:40
avassmnaser: well, you don't really need a role for running something like "pip install this specific package" you can just run that in the playbook directly :)14:43
avasscorvus: should we announce that we're dropping ansible 2.6 support for zuul-jobs or just drop it since zuul already dropped it? https://review.opendev.org/#/c/727158/14:45
avassmordred, mnaser: that's my thoughts on https://review.opendev.org/#/c/730360/9 as well. the ensure-ansible role doesn't really do a lot (and I'd like others opinion on that)14:48
mnaseravass: maybe ensure-pip-package should be a thing, similar to ensure-package-repositories14:49
avassmnaser: yeah I had that idea as well14:49
mnaserand then we can iron out all of the little kinks of getting a pip package installed, which can run in pre to save failures14:49
fungiavass: mnaser: we may still want to announce that, as folks could be directly using zuul-jobs but not upgrading zuul continuously14:50
mnaserand have improvements to that role fix anything else that needs to pull things from pip14:50
openstackgerritMerged zuul/zuul-jobs master: phoronix-test-suite: extract ensure- role from run playbook  https://review.opendev.org/73636814:50
*** Goneri has joined #zuul14:51
corvusfungi, avass: ++ to announcing; we don't actually have an 'ansible version' policy in zuul-jobs, but i think trailing zuul itself by a little bit seems reasonable.14:56
fungijust got confirmation from openstack release jobs the latest updates to ensure-pip et cetera have worked15:04
fungithey're able to process new releases again15:04
*** jamesmcarthur has quit IRC15:04
*** harrymichal has joined #zuul15:06
AJaegergreat news!15:07
avasscorvus, fungi: alright I'll send an email announcing that zuul-jobs is dropping 2.6 support later. I also remembered that I forgot to announce dropping tox_envlist: venv default so I'll do that too :)15:07
avassshould we wait another week with dropping 2.6 support then?15:10
avasscorvus, fungi: ^?15:11
*** harrymichal has quit IRC15:11
corvusavass: yes, let's wait 2 weeks to give people time to pin zuul-jobs if they need to15:11
avassalright15:12
*** jcapitao has quit IRC15:17
avasscorvus: send!15:24
avasssent*15:25
zbrtechnically speaking zuul is in breach of EU cookie low due to the timezone feature..... :p15:26
zbri wonder if I will sleep well knowing this...15:27
mordredzbr: we do not belive that to be the case15:27
zbrno? i think that the law required prompt regardless if they are tracked or not.15:27
mordredno - there's specific language that allows thigns like what we're doing15:27
zbranyway, i think we are likely better using localStorage instead and avoid sending data to the server. is there a reason for not doing it?15:28
mordredwhat data on the server?15:28
mhuprobably so that it's transient?15:28
mordredcookies are stored in browser15:28
mhuand you don't have to re-set your TZ every time you open a tab15:29
zbrcookies are sent always, there is no such thing as local cookie, cookie are sent with each request.15:29
mhuzbr: cookies are stored locally AND sent as headers - but the content is stored in the browser, it's the whole point15:29
mordredyeah. I suppose if we used local storage we could avoid the cookie in the header15:30
mordredbut - also I think browser support for local storage is much newer and requires a user to opt-in no?15:30
zbri will investigate use of localStorage, as if we add more settings, this may prove more practical.15:30
zbrno opt-in afaik, https://www.w3schools.com/html/html5_webstorage.asp15:31
mhudon't take my word for it, but I'm not certain localStorage is shared among tabs15:31
zbrin fact is quite old15:31
avassmordred: ready https://www.privacypolicies.com/blog/eu-cookie-law/ I'd say the timezone cookie would fall under 'customized experience'15:31
* mordred has no issues with local storage - likes it for things it's good for15:31
zbrthere are two things localStorage and localSession, we want the first.15:31
avassbut we've had this discussion before and I'm no lawyer so I have no idea :)15:32
mordredavass: I would not interpret customeized user experience in the way they use it there to be what we're talking about here15:32
zbravass: yep, customized experience for sure.15:32
mordredI believe they're talking about things that change the behavior - like, on espn.com I dont' want to see boxing news,so I set a prefernece saying that15:33
mordredthat's a customized user experience - it changes the UI of the site in a way that is personal to me15:33
fungithe rules also have a carve-out for using cookies in ways which are necessary for functionality of the site/application15:36
fungiall the language in gdpr is around cookies used for tracking behavior and other personal information for marketing purposes and sharing with third parties15:37
mordredyeah15:37
fungibut people who are scared by the legalese tend to just decide that to be safe they have to mention any cookie being used, regardless of what it's for or how it's used15:37
mordredactually, specifically this: "as strictly necessary in order for the provider of an information society service explicitly requested by the subscriber or user to provide the service" - the fact that the cookie in question is in service of providing a service that is explicitly requested by the user15:38
mordredthe only thing the cookie does is allow us to provide a timezone-modified date time that the user asks us to show them - and it is necessary to do that15:38
avasslooking at: https://wikis.ec.europa.eu/display/WEBGUIDE/04.+Cookies most of the exemptions are 'for the duration of a session'15:39
avassmordred: wouldn't it be a 'user input cookie'?15:39
mordredyeah - but since we don't have authentication - a session is of indeterminate duration - I do not believe anyone could define when a zuul dashboard session ends15:40
mhumordred: we don't have authentication YET!15:40
avasswell, it ends when you close the tab imo :)15:40
mordredavass: I think we use the dashboard differently :)15:41
mordredor tabs15:41
clarkbclose the tab?15:41
fungiwait... you *close* tabs?15:41
*** sshnaidm|mtg is now known as sshnaidm|ruck15:41
avassyeah, after usually when I've opened >100 to solve a problem15:41
fungii just throw my computer away and replace it when browser tabs build up to the point where it's no longer usable15:41
mhuyou guys have tabs?15:41
mordredbut anyway - I argue that we're covered by strictly necessary to provide requested service15:41
zbrback to practical stuff: i will look into use of localstorage15:42
*** hashar has joined #zuul15:42
openstackgerritMerged zuul/zuul master: Restore release jobs  https://review.opendev.org/73632715:42
zbrreason for that is that i may need it to implement the requested feature to change the wrapping behavior ... :(15:42
avassmordred: and I'd argue that it would fall under being a customized experience and/or user input15:42
mordredavass: I know - I'd argue differently15:42
mordredwhich means that it's literally impossible to know unless we get sued15:43
avassbut I think we need a lawyer for this :)15:43
clarkbwe could use the timezone reported by the browser15:43
zbryou know a good lawyer is a ... one.15:43
mordreda lawyer can't tell us the answer - a lawyer can give advice as to what our relative risk profiles might be and what they believe the answer might be15:43
*** ysandeep is now known as ysandeep|away15:43
tristanCzbr: where do you see the cookie being sent to the server?15:43
clarkbbut then that has the problem of showing peopel different timestamps15:44
clarkbwe could also just force utc (I'd be fine with that)15:44
zbri did not check, but i know how cookies work. any cookie set is sent to the server with each request.15:44
*** rlandy is now known as rlandy|ruck215:44
avassmordred: they can give us advice based on experience :)15:44
zbris how cookies was designed to work.15:44
zbrif the server does somethign with them or not, is less important.15:44
mordredavass: they can indeed - but they're also typically overly risk averse because they don't want to be wrong in the wrong direction15:44
tristanCzbr: i thought that only happens for http cookie, like the one used for session, not for any cookie, like the one used for site preference15:44
mordredavass: so they tend to give the _Absolute_ safest advice even. like, the laywer would say "just show a consent, you know you won't be in violation then"15:45
tristanCzbr: unless i'm mistaken, i do not see any cookie being exchanged between the client and the zuul server15:45
AJaegerpublish-openstack-python-branch-tarball is still failing - I'm confused15:45
AJaegerhttps://zuul.opendev.org/t/openstack/builds?job_name=publish-openstack-python-branch-tarball15:45
zbrprobably because none of us did customize the timezone preference15:45
avassmordred: probably15:47
zbranyone reason to write ensure-setuptools? ;) -- i am out now.15:47
* mordred throws a bucket of pies at zbr15:47
avassnot cookies?15:48
avassmordred: I can't say I want zuul to have a cookie banner though :)15:49
*** bhagyashris is now known as bhagyashris|away15:49
clarkbavass: I think that is my biggest concern. Those banners are so completely useless15:49
clarkbthey've just trained everyone to accept all the cookies we didn't want them to have in the first place15:49
clarkbwhich is worse because now we've consented to the problem15:49
clarkbrather than eliminating the underlying issue /grump15:49
avassI usually go 'ugh I'll read it somewhere else'15:50
fungiheh, yeah, i mostly just try not to click any consent banners, and if stuff doesn't work without consenting, i leave the page15:50
clarkbfungi: the new thing is if you don't explicitly consent but start scrolling they have verbage to say that is implicit consent15:51
avassyeah15:51
clarkbwhether that would hold up in court i have no idea15:51
clarkbbut the problem remains we're just training people to give up their info without a second thought15:51
clarkbits completely backfired the intent/goal of the law imo15:51
tristanCoops, i was wrong, the timezone is being sent to the server when it is set15:52
fungiand anyway, i would leave it up to the deployers/sysadmins to decide if they're going to overlay something like that. there's plenty of other open source software we run in opendev which uses cookies for a variety of similar purposes and the upstream authors of those services haven't felt they need to add in "gdpr support" or anything like that15:52
fungi(though i know there's an open feature request against jitsi-meet for it, that's a little different since it directly handles video and audio recordings of users)15:53
mhutristanC, maybe sending the tz to the server is unneeded actually - where is the UI code executed?15:53
*** harrymichal has joined #zuul15:53
clarkbmhu: ya it isnt that is why zbr is looking at local storage aiui15:55
mhuoooh ok according to Stack Overflow localStorage can be shared among tabs, but it needs to be set explicitly https://stackoverflow.com/questions/20325763/browser-sessionstorage-share-between-tabs15:57
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Deprecate default tox_envlist: venv  https://review.opendev.org/72683016:00
*** bhavikdbavishi has joined #zuul16:01
*** harrymichal has quit IRC16:03
*** harrymichal has joined #zuul16:03
avasscorvus: I sent the tox_envlist announcement as well16:03
*** bhavikdbavishi1 has joined #zuul16:04
*** bhavikdbavishi has quit IRC16:05
*** bhavikdbavishi1 is now known as bhavikdbavishi16:05
openstackgerritAlbin Vass proposed zuul/zuul master: Add commit id and owner to Change for mqtt reporter  https://review.opendev.org/72247816:06
*** dennis_effa has quit IRC16:11
*** jamesmcarthur has joined #zuul16:19
openstackgerritJeremy Stanley proposed zuul/zuul-jobs master: Simplify twine invocation for PyPI uploads  https://review.opendev.org/73593216:40
*** jamesmcarthur has quit IRC16:43
*** rlandy|ruck2 is now known as rlandy|ruck2|brb16:45
*** jamesmcarthur has joined #zuul16:51
*** sshnaidm|ruck is now known as sshnaidm|off16:52
openstackgerritMerged zuul/zuul-jobs master: Fix with_* loop for ansible 2.9  https://review.opendev.org/73671416:54
openstackgerritMatthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to re-enqueue a change  https://review.opendev.org/73677216:55
openstackgerritMatthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to re-enqueue a change  https://review.opendev.org/73677216:57
*** olaph has joined #zuul17:00
*** rpittau is now known as rpittau|afk17:00
*** rlandy|ruck2|brb is now known as rlandy|ruck217:04
*** bhavikdbavishi has quit IRC17:04
*** bhavikdbavishi has joined #zuul17:05
*** hashar has quit IRC17:05
*** jamesmcarthur has quit IRC17:08
*** jamesmcarthur has joined #zuul17:08
openstackgerritJeremy Stanley proposed zuul/zuul-jobs master: Simplify twine invocation for PyPI uploads  https://review.opendev.org/73593217:09
*** nils has quit IRC17:14
openstackgerritJeremy Stanley proposed zuul/zuul-jobs master: Simplify twine invocation for PyPI uploads  https://review.opendev.org/73593217:15
*** jpena is now known as jpena|off17:21
fungiwebknjaz: ^ thanks for all your help on that one!17:22
webknjaz👍17:22
fungii'm still struggling to come up to speed with ansible17:23
avassfungi: should that fail if it detects unsafe files?17:25
fungiavass: er, yes, do i need to add a failed_when on the twnie check task?17:26
avassfungi: you can use 'fail' instead of 'debug' on the 'Report files unsafe for upload' task17:27
avassunless the check already sets an exit code, then you might as well remove the debug task because it will never report any unsafe files :)17:27
fungioh, cool, still learning ;)17:27
clarkbit will actually fail on line 1217:27
clarkbif the output from twine is verbsoe enough you probably don't need the extra debug/fail task17:28
clarkbbut if not then you want a failed_when: false on the line 12 task and then switch debug to fail17:28
fungibasically the twine check command will have a nonzero exit code if it detects a problem sich as a file not fit for uploading17:28
avassclarkb, fungi: alright, then I guess you can remove the register and just run 'twine check' and if that fails nothing else will run17:28
fungiand it does provide verbose output17:28
avass(in that playbook)17:28
fungii didn't know if it was important for the cleanup task to still run17:28
clarkbfungi: followup tasks like that are usually for when the previous failure is going to be obtuse to the end user17:29
avassif it is you can use a block and use the 'always' keyword17:29
clarkbor if you're relying on somethign other than exit code to determine failure17:29
avassfungi: like https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/tox/tasks/main.yaml#L3717:30
fungidoes the failing task need to be inside the block, i guess?17:31
avassthat will run tox and return comments even if tox fails, sort of like a try/finally17:32
avassyeah17:32
*** michael-beaver has joined #zuul17:32
openstackgerritJeremy Stanley proposed zuul/zuul-jobs master: Simplify twine invocation for PyPI uploads  https://review.opendev.org/73593217:33
fungiavass: so like that? ^17:33
avassfungi: lgtm :)17:33
fungithanks!17:34
avassoh, you might actually need to indent the block another level17:35
avassnot sure about that though17:35
avasslet me check17:35
fungioh, i see, looking at the example, the list entry markers are two spaces deeper than the always17:36
avassyeah17:36
fungithe list entry markers earlier in the block i mean17:36
fungii guess the top level data structure is a list, and then one of the list items is a dict with keys "block" and "always" and then each has list items within it17:37
avassboth seem  to work but you might get a linter yelling at you17:37
openstackgerritJeremy Stanley proposed zuul/zuul-jobs master: Simplify twine invocation for PyPI uploads  https://review.opendev.org/73593217:38
fungione of those nuances of yaml which is easy to not spot17:38
fungiit's technically correct because the list markers count as indentation for the yaml parser, basically17:39
fungibut it can make things hard to follow, and a number of linters will yell at you about it, yes17:39
mordredfungi, avass: both are correct - we've chosen in zuul to adopt the extra-2-spaces indentation as a yaml style17:45
fungiyeah, i'm down with that17:47
avasschanged my vote to a +1 since the ansible looks correct, but I've never used twine :)17:48
mordredfungi: so - I have a suggestion ...17:48
fungiavass: it's okay, i'm pretty confident in the command line bits, i appreciate the deeper ansible review17:49
mordredfungi: (ansible looks good)17:49
mordredfungi: {{ pypi_path }}/* will work - but will upload things in shell-expansion order according to your commit message17:49
mordredthis could result in uploading the tarball before the wheel - but it's important to upload the wheel first so that people installing don't get caught in the moment between tarball and wheel only having the tarball available and thus having to build the wheel17:50
avassoh, actually, we have tests for those17:50
fungimordred: yeah, that's a great point17:50
mordredfungi: so maybe {{ pypi_path }}/*whl {{ pypi_path }}/*tar.gz instead of just the bare * ?17:50
fungii think if we have a project only uploading a tarball, that will cause an error17:51
mordredwe also apparently were excluding excludes: "*-linux_x86_64.whl"17:51
mordredI'm not sure why were we doing that17:51
fungioh, because pypi won't allow platform-specific wheels for linux abi17:51
mordredah17:52
fungiin theory twine check will also complain there, but either way it's a bit late at that point17:52
mordredso maybe the two finds are worth keeping - but then combine on the single twine command line17:52
mordredor something17:52
avassyeah17:53
fungii was struggling with how to do that in ansible, as you'll see in earlier patchsets17:53
fungifind is returning a list of dicts17:53
fungiso turning dict keys from each element into a concatenated list of strings is... well if it was just python i could use a list comprehension but...17:54
fungirather, turning the values associated with specific dict keys in each of the list elements into a concatenated string17:55
avassfungi: you can use map with join for that I believe: https://docs.ansible.com/ansible/latest/user_guide/playbooks_filters.html#id817:57
avassfungi: something like {{ files | map(attribute='path') | join(' ') }}17:58
fungiyeah, i see the map join example in there17:59
fungii can give that a shot17:59
fungiand i guess if files is an empty list then that will result in an empty string, so i don't have to test for whether they're empty?18:00
avassfungi: here's a better link: https://jinja.palletsprojects.com/en/2.11.x/templates/#map18:00
avassI would think so18:00
fungii'll give that a shot after my next meeting18:01
*** hashar has joined #zuul18:09
openstackgerritMatthieu Huin proposed zuul/zuul master: Add authentication-realm attribute to tenants  https://review.opendev.org/73558618:39
openstackgerritMatthieu Huin proposed zuul/zuul master: web UI: allow a privileged user to re-enqueue a change  https://review.opendev.org/73677218:39
openstackgerritJeremy Stanley proposed zuul/zuul-jobs master: Simplify twine invocation for PyPI uploads  https://review.opendev.org/73593218:45
openstackgerritAhmad Mahmoudi proposed zuul/zuul-jobs master: (fix) - Added tox location to PATH  https://review.opendev.org/73680118:47
*** bhavikdbavishi has quit IRC19:13
*** gmann is now known as gmann_afk19:22
corvusavass: note i pinged you in http://lists.zuul-ci.org/pipermail/zuul-discuss/2020-June/001262.html19:31
avasscorvus: yep I saw, and no there's no rush19:36
avasscorvus: ah wait, that reply didn't do what I wanted it to right?19:37
*** gmann_afk is now known as gmann19:37
corvusavass: your second one is right :)19:44
corvusavass: and sounds great. you want to send an updated -announce post, or want me to?19:45
avassyou can do it :)19:49
openstackgerritJames E. Blair proposed zuul/nodepool master: Run upload-docker-image on release  https://review.opendev.org/73633319:50
corvusmordred, clarkb: can you re-review https://review.opendev.org/736333 ^ pls?  need one more fix for nodepool's build-python-release19:50
mordredcorvus: lgtm20:00
*** rlandy|ruck2 is now known as rlandy|ruck2|mtg20:00
*** gmann is now known as gmann_afk20:10
clarkblooking20:21
clarkbcorvus: I +2'd but didn't approve as I'm not sure how much coordination that needs20:22
corvusnone, i +wd thx20:22
*** rlandy|ruck2|mtg is now known as rlandy|ruck220:31
*** hashar has quit IRC20:47
*** rfolco has quit IRC20:52
*** harrymichal has quit IRC21:33
*** harrymichal has joined #zuul21:35
openstackgerritMerged zuul/nodepool master: Run upload-docker-image on release  https://review.opendev.org/73633321:37
openstackgerritMerged zuul/zuul-jobs master: Add linting rule to enforce no-same-owner policy  https://review.opendev.org/72764221:37
ianwzbr: just back to your previous note about people wanting later wheel for toml or wanting later pip for dependencies when that's around or whatever -- no problem with that -- and you can tell ensure-pip to install from source.21:38
ianwhowever, i think that is something you should opt-in to ... if people think they're testing on bionic and then we've installed yesterdays pip etc., then they build something relying on that and someone tries it on bionic outside the gate it all blows up21:39
mordredianw: ++21:45
mordredianw: also - they can just a focal nodeset or something21:45
mordredmany options21:45
avassspeaking of focal, any idea what's going on here https://review.opendev.org/#/c/731995/ ?21:46
*** gmann_afk is now known as gmann22:04
fungianybody have a spare moment to take a look at a couple of new user case study summaries for the website? https://review.opendev.org/736053 (and thanks corvus for reviewing already!)22:09
clarkbfungi: I can get to that in a bit probably22:10
fungiit's not super urgent, just figure it's also an easy one to get out of the way22:11
mnaserfungi: it would be nice if we landed the gatsby comment :(22:22
mnasers/comment/change/22:22
clarkbmnaser: did you see the feedback on it?22:23
clarkbmnaser: there were a few things that corvus asked be fixed frist22:23
mordredmnaser, clarkb: yeah - I keep meaning to circle back and fix those22:23
mnaserah yes, i see those now, my bad.22:24
mnasermordred: think you can get to those? i dont know if i have the bandwidth now to get them done right away, if not, i can try to get soemone here to work on it but that might take a little bit22:25
*** tosky has quit IRC22:25
clarkbfungi: one small thing on https://review.opendev.org/#/c/736053/ but I +2'd in case my english is just bad or you want to fix in a followup22:26
clarkbfungi: feel free to approve if either of those is the case22:26
mordredmnaser: yeah - I'l give them a look tomorrow - and if I can't figure them out I might ask some specific questions22:37
mnasermordred: ok i can route those questions to the right people here22:37
fungiclarkb: ahh, yeah, i can fix that real quick. i copied and pasted aprice's prose verbatim22:37
mordredmnaser: the menu thing is one that I looked at for a second and then just kind of cried and moved on to something else22:37
mnaseri think the menu thing could be trivial because we might steal it from the component we use/built for vexxhost.com22:37
mnaseri can talk to the guy who owns that site, he's cool with us using it, i think22:37
mnaser:P22:37
mordredmnaser: cool. because it's like - nontrivial but seems like it should be trivial22:38
openstackgerritJeremy Stanley proposed zuul/zuul-website master: Add user story summaries for Wazo and T-Systems  https://review.opendev.org/73605322:40
fungiclarkb: ^ better?22:40
clarkbyup +2 thanks22:41
corvusi approved that; mordred, mnaser: that means the gatsby stuff will need a rebase to pick up the new content, but that should be easy22:43
mordredcorvus: yah. the adds there are not hard adds22:43
fungialso those user case study blocks are repetitive22:48
fungiformat wise22:48
openstackgerritMerged zuul/zuul-website master: Add user story summaries for Wazo and T-Systems  https://review.opendev.org/73605322:48
mordredfungi: yah - once we have the base thing done, we can replace them with a directory of markdown files22:53
fungithat'll be slick22:54
mordredyeah23:14
mordredI very much enjoy my gatsby site23:14
*** jamesmcarthur has quit IRC23:43
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Rework quick-start and prepare for other tutorials  https://review.opendev.org/73206623:57
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate your first patch"  https://review.opendev.org/73206723:57
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "Use zuul jobs"  https://review.opendev.org/73206823:57
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate pipeline"  https://review.opendev.org/73206923:57
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "job secrets"  https://review.opendev.org/73207023:57
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "job dependencies"  https://review.opendev.org/73207123:57
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Fix zuul_run_command ret when command is not found  https://review.opendev.org/73547523:57
openstackgerritGuillaume Chauvel proposed zuul/zuul master: zuul_stream: close streamer when task is skipped  https://review.opendev.org/73547623:57
openstackgerritGuillaume Chauvel proposed zuul/zuul master: [DNM] TEST run zuul tutorials with pending zuul-jobs changes  https://review.opendev.org/73547723:57
openstackgerritGuillaume Chauvel proposed zuul/zuul master: [DNM] TEST zuul_stream+callback test using multinode jobs  https://review.opendev.org/73548323:57
openstackgerritGuillaume Chauvel proposed zuul/zuul master: Add 'uuid' to 'src_dir' in order to allow parallel jobs for a static node  https://review.opendev.org/73598123:57
openstackgerritGuillaume Chauvel proposed zuul/zuul master: [DNM] TEST 'uuid' in 'src_dir': 1 node, 4 parallel jobs  https://review.opendev.org/73557623:57
*** rfolco has joined #zuul23:58

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!