openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Rework quick-start and prepare for other tutorials https://review.opendev.org/732066 | 00:26 |
---|---|---|
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate your first patch" https://review.opendev.org/732067 | 00:26 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "Use zuul jobs" https://review.opendev.org/732068 | 00:26 |
*** jamesmcarthur_ has quit IRC | 01:01 | |
*** swest has quit IRC | 01:23 | |
*** rfolco|rover has quit IRC | 01:29 | |
*** rlandy has quit IRC | 01:32 | |
*** swest has joined #zuul | 01:37 | |
*** jamesmcarthur has joined #zuul | 01:53 | |
*** jamesmcarthur has quit IRC | 01:53 | |
*** jamesmcarthur has joined #zuul | 01:53 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download https://review.opendev.org/733425 | 02:38 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download https://review.opendev.org/733425 | 02:43 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download https://review.opendev.org/733425 | 02:45 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download https://review.opendev.org/733425 | 02:49 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download https://review.opendev.org/733425 | 02:50 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download https://review.opendev.org/733425 | 03:01 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download https://review.opendev.org/733425 | 03:09 |
*** bhavikdbavishi has joined #zuul | 03:11 | |
*** bhavikdbavishi1 has joined #zuul | 03:38 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download https://review.opendev.org/733425 | 03:39 |
*** bhavikdbavishi has quit IRC | 03:39 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 03:39 | |
*** ajitha has joined #zuul | 03:50 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download https://review.opendev.org/733425 | 03:50 |
*** sgw has quit IRC | 04:00 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download https://review.opendev.org/733425 | 04:00 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download https://review.opendev.org/733425 | 04:17 |
*** evrardjp has quit IRC | 04:33 | |
*** evrardjp has joined #zuul | 04:33 | |
*** wuchunyang has joined #zuul | 04:39 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download https://review.opendev.org/733425 | 04:51 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download https://review.opendev.org/733425 | 05:03 |
*** wuchunyang has quit IRC | 05:07 | |
*** sgw has joined #zuul | 05:12 | |
*** bhavikdbavishi has quit IRC | 05:12 | |
*** bhavikdbavishi has joined #zuul | 05:13 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download https://review.opendev.org/733425 | 05:14 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download https://review.opendev.org/733425 | 05:18 |
*** jamesmcarthur has quit IRC | 05:18 | |
masterpe | Now the next one :), I have a zuul from scratch and I try to upload the logs, I use the tasks generate-zuul-manifest and upload-logs to upload the log. Both works, but I still can not find the logs. In the docker version I see the setting trusted_rw_paths who saves the logs on /srv/static/logs, If I also use trusted_rw_paths in the config. I only get console-fa163e70-c4c9-e16f-4171-000000000014-localhost.log. | 05:18 |
masterpe | with the text: "2020-06-03 20:30:04.881486 | [Zuul] Task exit code: 0" | 05:19 |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download https://review.opendev.org/733425 | 05:20 |
*** ysandeep|away is now known as ysandeep | 05:25 | |
*** saneax has quit IRC | 05:27 | |
*** saneax has joined #zuul | 05:28 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download https://review.opendev.org/733425 | 05:30 |
*** reiterative has quit IRC | 05:39 | |
*** reiterative has joined #zuul | 05:39 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download https://review.opendev.org/733425 | 05:42 |
openstackgerrit | Merged zuul/zuul-jobs master: Document twine_executable https://review.opendev.org/732150 | 05:43 |
*** bhavikdbavishi has quit IRC | 05:58 | |
*** bhavikdbavishi has joined #zuul | 06:00 | |
*** themroc has joined #zuul | 06:06 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download https://review.opendev.org/733425 | 06:13 |
*** decimuscorvinus has quit IRC | 06:23 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download https://review.opendev.org/733425 | 06:25 |
*** decimuscorvinus has joined #zuul | 06:26 | |
*** bhavikdbavishi has quit IRC | 06:35 | |
*** wuchunyang has joined #zuul | 06:37 | |
*** jcapitao has joined #zuul | 06:47 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: download-artifact: cleanup long when statement https://review.opendev.org/733446 | 06:47 |
*** bhavikdbavishi has joined #zuul | 06:48 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: download-artifact: cleanup long when statement https://review.opendev.org/733446 | 07:00 |
*** bhavikdbavishi has quit IRC | 07:02 | |
*** bhavikdbavishi has joined #zuul | 07:06 | |
*** hashar has joined #zuul | 07:08 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: download-artifact: cleanup long when statement https://review.opendev.org/733446 | 07:13 |
*** jpena|off is now known as jpena | 07:19 | |
*** themroc has quit IRC | 07:35 | |
*** bhavikdbavishi has quit IRC | 07:38 | |
tobiash | zuul-maint: we discovered that we seldom have empty or missing files in the swift upload logs without any trace of an error in the logs. The reason seems to be that upload-logs-swift throws an error when the initial preparation and connection fails but ignores any file upload error (logging.foo goes to nowhere within the module context). See https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/upload-logs-swift/library/ | 07:42 |
tobiash | zuul_swift_upload.py#L677 | 07:42 |
tobiash | zuul-maint: I see two viable options how we could improve this. First would be to fail the task in case of an upload error, the second would be to retain the behavior but add an errors list to the task upload so this at least can be logged on the executor side | 07:43 |
tobiash | zuul-maint: what do you think? | 07:44 |
*** tosky has joined #zuul | 07:46 | |
*** rpittau|afk is now known as rpittau | 07:50 | |
guillaumec | AJaeger: about ensure-python, ensure-twine, ensure-tox (https://review.opendev.org/#/c/731853/) and for the latter where I said in a comment that I didn't think it that the zuul's tutorial was able to fetch the change. because how can the git driver using http://opendev.org/zuul/zuul-jobs can possibly fetch a change ! | 08:00 |
guillaumec | AJaeger: I did try for https://review.opendev.org/#/c/733419/ and it worked! use by https://review.opendev.org/#/c/732068/ where tox-py27 is used, and the node-Dockerfile modified from https://review.opendev.org/#/c/732066 doesn't have python2 installed | 08:01 |
guillaumec | AJaeger: I looked at the logs, saw some "mirror" roles, I checked opendev.org/zuul/zuul-jobs/roles/*mirror* but I cannot find how "git clone https://opendev.org/zuul/zuul-jobs" from the tutorial's executor can fetch the change. from /home/zuul/src/opendev.org/zuul/zuul-jobs (on the node ? and how ?) | 08:02 |
AJaeger | guillaumec: I'm using OpenDev's Zuul where all changes are pre-pushed on the images. | 08:02 |
AJaeger | let me find you some links | 08:02 |
*** nils has joined #zuul | 08:02 | |
AJaeger | https://zuul.opendev.org/t/zuul/build/5db38688bcb84dd0911b9739e1eb890b/log/job-output.txt#220-224 | 08:03 |
AJaeger | sorry, not pre-pushed - we have an ansible role that pushes them | 08:03 |
*** bhavikdbavishi has joined #zuul | 08:03 | |
AJaeger | guillaumec: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/mirror-workspace-git-repos | 08:04 |
AJaeger | So, the executor prepares the git repo and then this role pushes it on the images. So, no need to fetch anything, it gets pushed ;) | 08:04 |
guillaumec | AJaeger: yes, I saw that in the job file "3c60f4e7a2bf6626a45ed7c5883e2e551c660cc6 Add python_version for tox27" https://3828237a78f90f6372ec-12b9f401fcb2e40f556f780fa3b8c456.ssl.cf5.rackcdn.com/732068/6/check/zuul-tutorial-use-zuul-jobs/5afa312/job-output.txt | 08:09 |
guillaumec | but this job will start a zuul's executor container, which will fetch opendev.org, zuul/zuul-jobs using the git driver. I can't find the link between the 2. | 08:10 |
*** yolanda has joined #zuul | 08:12 | |
AJaeger | guillaumec: sorry, can't help with that | 08:14 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on https://review.opendev.org/732068 | 08:20 |
*** ysandeep is now known as ysandeep|lunch | 08:20 | |
openstackgerrit | Albin Vass proposed zuul/zuul master: zookeeper-tls-howto: Remove unused keystorepassword https://review.opendev.org/733478 | 08:27 |
openstackgerrit | Simon Westphahl proposed zuul/zuul master: Don't recreate parse context for every config file https://review.opendev.org/728774 | 08:37 |
*** wuchunyang has quit IRC | 08:39 | |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Rework quick-start and prepare for other tutorials https://review.opendev.org/732066 | 08:45 |
*** themroc has joined #zuul | 08:47 | |
ajitha | Hi, how to enable the web UI in zuul. I am getting this error "FileNotFoundError: [Errno 2] No such file or directory | 08:55 |
ajitha | in web.log | 08:55 |
mrcirca | Hello, | 08:55 |
*** dennis_effa has joined #zuul | 09:02 | |
*** ysandeep|lunch is now known as ysandeep | 09:03 | |
dennis_effa | Hello, I'm a noob here and I would want to ask how zuul stream logs during long running tasks | 09:06 |
dennis_effa | The whole point is I'm running a playbook in ansible and it gives feedback after the task is done. But I would like to stream the output during runtime | 09:09 |
dennis_effa | And I was told zuul implements similar concept in its logs | 09:10 |
tobiash | dennis_effa: zuul overwrites the command module and uses a custom callback plugin | 09:53 |
tobiash | ajitha: can you post more logs of the zuul-web service? | 09:55 |
*** dpawlik has quit IRC | 09:57 | |
*** dpawlik3 has joined #zuul | 09:57 | |
ajitha | tobiash: Thanks. sure | 09:57 |
ajitha | http://paste.openstack.org/show/794360/ | 09:57 |
tobiash | ajitha: that tail shows only an error while zuul-web is already stopping. The real error must be before that | 09:58 |
ajitha | i have just started to configure zuulv3 for a third part CI | 09:59 |
tobiash | is there more in the logs? | 10:00 |
ajitha | yes | 10:00 |
ajitha | http://paste.openstack.org/show/794361/ | 10:00 |
ajitha | any clue? i am a newbie | 10:02 |
*** rpittau is now known as rpittau|bbl | 10:02 | |
tobiash | that exception happens in the shutdown sequence so you can ignore that for now. Did you stop it yourself directly after starting? | 10:03 |
*** themroc has left #zuul | 10:03 | |
ajitha | tobiash: also config-projects: field in main.yaml need to be a git repo? | 10:04 |
ajitha | yes yes.. | 10:04 |
ajitha | i thought it is an error | 10:04 |
tobiash | yes, config-projects needs to list git repos | 10:04 |
*** dpawlik3 has quit IRC | 10:05 | |
tobiash | but main.yaml is relevant for the scheduler, not web | 10:05 |
ajitha | but when i check the UI using ip:9000. I got 404 Not Found | 10:05 |
*** dpawlik3 has joined #zuul | 10:05 | |
tobiash | how did you install it? | 10:05 |
tobiash | that sounds like the static stuff is missing | 10:06 |
ajitha | yes main.yaml i know its different.. i had a query on that.. | 10:06 |
ajitha | installed by following zuul from scratch | 10:06 |
ajitha | i didnt configure any git repo yet.. Will that be an issue like web UI cant fetch it? | 10:07 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate your first patch" https://review.opendev.org/732067 | 10:07 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on https://review.opendev.org/732068 | 10:07 |
dennis_effa | tobiash: thanks for the response and can you help me with a link to the custom callback plugin? | 10:07 |
tobiash | zuul-web needs a running scheduler | 10:07 |
ajitha | tobiash: scheduler is running | 10:10 |
ajitha | 2020-06-04 03:01:33,245 INFO zuul.Scheduler: Starting scheduler | 10:10 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on https://review.opendev.org/733520 | 10:11 |
ajitha | tobiash: http://paste.openstack.org/show/794363/ | 10:13 |
ajitha | my conf | 10:13 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "Use zuul jobs" https://review.opendev.org/732068 | 10:16 |
*** saneax is now known as saneax_AFK | 10:48 | |
openstackgerrit | Tobias Henkel proposed zuul/zuul master: Increase gerrit event delay to 20s https://review.opendev.org/733542 | 10:50 |
*** ajitha has quit IRC | 10:50 | |
*** ysandeep is now known as ysandeep|afk | 10:51 | |
tobiash | zuul-maint: we see a lot of unprocessed events because of the gerrit event vs api availability race of a change therefore this change ^ | 10:53 |
*** wuchunyang has joined #zuul | 10:53 | |
tobiash | zuul-maint: I think we don't want to make this configurable. Thus just increasing the delay is the wrong path I think. What do you think about replacing that delay by busy waiting until a change is available with a higher timeout like 30s ir 1min? | 10:54 |
*** jcapitao is now known as jcapitao_lunch | 11:04 | |
*** wuchunyang has quit IRC | 11:11 | |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on https://review.opendev.org/733520 | 11:15 |
openstackgerrit | Felix Edel proposed zuul/zuul-jobs master: Return upload_results in upload-logs-swift role https://review.opendev.org/733564 | 11:24 |
*** felixedel has joined #zuul | 11:31 | |
*** donnyd_ has quit IRC | 11:33 | |
*** donnyd_ has joined #zuul | 11:34 | |
*** donnyd_ has quit IRC | 11:34 | |
*** rpittau|bbl is now known as rpittau | 11:35 | |
felixedel | zuul-main: Are there any plans on updating zuul-web from using Patternfly 3 to Patternfly 4? | 11:36 |
felixedel | zuul-maint: ^ | 11:37 |
*** jpena is now known as jpena|lunch | 11:38 | |
openstackgerrit | Felix Edel proposed zuul/zuul-jobs master: Return upload_results in upload-logs-swift role https://review.opendev.org/733564 | 11:41 |
*** donnyd_ has joined #zuul | 11:42 | |
*** ysandeep|afk is now known as ysandeep | 11:43 | |
*** donnyd_ is now known as donnyd | 11:44 | |
*** felixedel has quit IRC | 11:47 | |
tobiash | felixedel: I saw no changes in that regard afaik | 11:48 |
tristanC | tobiash: i would be in favor for using a busy dynamic retry, the arbritary timeout makes gerrit connection feel sluggish. Though iirc the delay was set because gerrit data can be inconsistent earlier, how can we detect that the data we get is correct? | 11:52 |
tobiash | tristanC: the problem was that the change was not there at all (which is inconsistent with getting events for that) | 11:53 |
tobiash | I had such an attempt back in v2 times: https://review.opendev.org/206043 | 11:53 |
tobiash | maybe it's worth to revive that | 11:53 |
tristanC | tobiash: perhaps we could use https://github.com/jd/tenacity ? | 11:54 |
zbr | tristanC: https://review.opendev.org/#/c/731591/ - already removed the albin part, to allow it to be merged. | 11:55 |
*** rfolco|rover has joined #zuul | 11:58 | |
*** bhavikdbavishi has quit IRC | 11:58 | |
*** jcapitao_lunch is now known as jcapitao | 12:01 | |
*** fbo|off is now known as fbo | 12:06 | |
*** rlandy has joined #zuul | 12:23 | |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on https://review.opendev.org/733520 | 12:26 |
*** arxcruz has quit IRC | 12:28 | |
*** arxcruz has joined #zuul | 12:29 | |
*** ianychoi_ has joined #zuul | 12:32 | |
*** sanjayu_ has joined #zuul | 12:32 | |
*** dpawlik6 has joined #zuul | 12:33 | |
*** dry has joined #zuul | 12:33 | |
*** Tahvok_ has joined #zuul | 12:34 | |
*** tobiash_ has joined #zuul | 12:35 | |
*** dmellado_ has joined #zuul | 12:35 | |
*** bhavikdbavishi has joined #zuul | 12:36 | |
*** bolg has quit IRC | 12:36 | |
*** SotK has quit IRC | 12:36 | |
*** tobberydberg has quit IRC | 12:36 | |
*** pots has quit IRC | 12:36 | |
*** dmellado has quit IRC | 12:36 | |
*** arxcruz has quit IRC | 12:36 | |
*** dpawlik3 has quit IRC | 12:36 | |
*** jkt has quit IRC | 12:36 | |
*** tobiash has quit IRC | 12:36 | |
*** ysandeep has quit IRC | 12:36 | |
*** saneax_AFK has quit IRC | 12:36 | |
*** paladox has quit IRC | 12:36 | |
*** Tahvok has quit IRC | 12:36 | |
*** ianychoi has quit IRC | 12:36 | |
*** yolanda has quit IRC | 12:36 | |
*** msuszko has quit IRC | 12:36 | |
*** Tahvok_ is now known as Tahvok | 12:36 | |
*** dmellado_ is now known as dmellado | 12:37 | |
*** pots has joined #zuul | 12:37 | |
*** arxcruz has joined #zuul | 12:37 | |
*** ysandeep has joined #zuul | 12:37 | |
*** paladox has joined #zuul | 12:37 | |
*** SotK has joined #zuul | 12:37 | |
*** tobberydberg has joined #zuul | 12:38 | |
*** yolanda has joined #zuul | 12:38 | |
*** sanjayu_ is now known as saneax | 12:46 | |
*** jpena|lunch is now known as jpena | 12:46 | |
*** wuchunyang has joined #zuul | 12:46 | |
*** sshnaidm is now known as sshnaidm|mtg | 12:59 | |
*** bhavikdbavishi has quit IRC | 13:17 | |
*** rpittau is now known as rpittau|brb | 13:24 | |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on https://review.opendev.org/733520 | 13:25 |
*** saneax has quit IRC | 13:46 | |
*** hashar has quit IRC | 13:56 | |
*** rpittau|brb is now known as rpittau | 14:01 | |
corvus | tobiash_: you linked to https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/upload-logs-swift/library/zuul_swift_upload.py#L677 earlier at 07:42, but i don't see the relevance to what you're describing; did you mean a different line? | 14:21 |
corvus | tobiash_: if we added an errors list to the return value, are we sure it would show up in executor logs? i think it would only show up if -vvv were set, right? but maybe there's some way we can return that to ansible that would cause it to appear as a warning? | 14:22 |
*** tobiash_ is now known as tobiash | 14:23 | |
tobiash | corvus: we could register and print that using a debug task afterwards | 14:23 |
corvus | tobiash_: but generally, i think we expect the upload tasks to fail in the case of error, so i think maybe we should do that as well. so return an errors list and fail? | 14:24 |
corvus | guillaumec: it is correct that you can't use depends-on with the git driver. in a tutorial, when we teach people how to use depends-on, it should be between two repos in gerrit (not zuul-jobs). | 14:24 |
tobiash | corvus: makes sense generally | 14:25 |
tobiash | we do failover to another cloud when upload fails | 14:25 |
tobiash | so this would make at least our use case more predictable | 14:25 |
corvus | tobiash, tristanC: i think a retry/back-off would be okay, but maybe keep a minimum value? it's also possible that the inconsistent data problem is solved, especially in later gerrits; maybe once we add retry we could experiment with dropping the minimum delay. | 14:29 |
corvus | tobiash: yeah, register/debug would be good, then it'll show up in the streaming log too (but we'll need to be careful not to log any error messages with credentials) | 14:30 |
tobiash | corvus: I think we're already retrying the files upload so I guess failing the task with the file plus stacktrace would be ok | 14:33 |
corvus | tobiash: incidentally, do you know what the failure is? (i think a goal of this should probably be to get enough error information out that we can then also maybe make the role more robust -- maybe retry this failing action) | 14:35 |
*** hashar has joined #zuul | 14:36 | |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on https://review.opendev.org/733520 | 14:37 |
tobiash | corvus: that's my problem, I only know that something happened because a user wanted to download a file (index was correctly uploaded) and got a 404 | 14:37 |
tobiash | with no trace of an error anywhere | 14:37 |
*** bhavikdbavishi has joined #zuul | 15:36 | |
*** bhavikdbavishi1 has joined #zuul | 15:39 | |
*** bhavikdbavishi has quit IRC | 15:41 | |
*** bhavikdbavishi1 is now known as bhavikdbavishi | 15:41 | |
*** fbo is now known as fbo|off | 15:46 | |
*** ajitha has joined #zuul | 16:09 | |
*** nils has quit IRC | 16:10 | |
tobiash | corvus: with that link I meant this and the following function, more specifically https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/upload-logs-swift/library/zuul_swift_upload.py#L708 where we log (which only works in cli testing) and ignore the error | 16:19 |
corvus | tobiash: ah yep. i agree we could do something more useful there. | 16:26 |
tobiash | corvus: felix is working on this, but I think we should decide if we want success+reporting or fail+reporting there | 16:27 |
tobiash | his current state is success+reporting (https://review.opendev.org/733564) | 16:28 |
*** rpittau is now known as rpittau|afk | 16:31 | |
*** jcapitao has quit IRC | 16:32 | |
corvus | tobiash: oooh, i think i misunderstood where the error was happening | 16:34 |
corvus | tobiash: i think in that case, it's really hard to determine whether we should return success or failure. let's stick with success for now, and maybe as we learn more about the problem, consider switching to failure. | 16:35 |
tobiash | ok | 16:36 |
corvus | tobiash: but we might want to include more info in the 'error' than that :) i'll leave a quick preliminary review | 16:36 |
tobiash | corvus: my thinking was a list of dicts containing filename and exception trace | 16:37 |
*** jpena is now known as jpena|off | 16:52 | |
*** ysandeep is now known as ysandeep|away | 16:53 | |
*** sshnaidm|mtg is now known as sshnaidm|afk | 16:59 | |
*** ajitha has quit IRC | 17:03 | |
*** hashar has quit IRC | 17:07 | |
*** avass has joined #zuul | 17:24 | |
AJaeger | zuul-jobs-maint, ianw has updated the download-artifact role for recursive download, see https://review.opendev.org/#/c/733425/ Please check the test job - it uses logs that expire, so when we update in a few month and rerun the tests, we need to change that. Reviews welcome - this is part of reworking the wheel building. | 17:37 |
*** rlandy is now known as rlandy|brb | 17:45 | |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on https://review.opendev.org/733520 | 17:50 |
openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: test-playbooks: avoid warnings with shell/command https://review.opendev.org/731605 | 17:55 |
avass | huh, I just realized there's an easy way to leave file comments, but no easy way to just leave a comment. | 18:03 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform jobs https://review.opendev.org/733675 | 18:18 |
*** rlandy|brb is now known as rlandy | 18:20 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 18:30 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 18:32 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 18:40 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on https://review.opendev.org/733520 | 18:48 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 18:48 |
*** bhavikdbavishi has quit IRC | 18:59 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 19:01 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 19:13 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 19:17 |
*** hashar has joined #zuul | 19:44 | |
*** dennis_effa has quit IRC | 19:49 | |
*** harrymichal has joined #zuul | 19:58 | |
openstackgerrit | Merged zuul/zuul-jobs master: test-playbooks: improved syntax https://review.opendev.org/731591 | 20:00 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 20:04 |
zbr | ianw: avass : https://review.opendev.org/#/c/731605/ - already sorted all comments | 20:06 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 20:08 |
avass | zbr: looking | 20:08 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on https://review.opendev.org/733520 | 20:09 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: QUICKSTART https://review.opendev.org/733689 | 20:09 |
avass | zbr: it's just disabling runtime warnings from ansible right? | 20:10 |
zbr | avass: yes, mainly in order to allow us to include testing playbooks in linting (where these warnings are errors) | 20:11 |
zbr | mainly, we are telling ansible that we know what we are doing. | 20:12 |
avass | zbr: oh do you know if we're removing pip with shell for a reason? | 20:13 |
avass | zbr: otherwise it might be better to change that to command: instead of hiding those warnings | 20:14 |
avass | zbr: otherwise it lgtm | 20:14 |
zbr | avass: is during testing, tbh, likely it should have being a command too. | 20:14 |
zbr | but lets fix one problem at a time | 20:14 |
zbr | otherwise we will never finish it. | 20:15 |
avass | zbr: but adding warn: false there is actually hiding something | 20:15 |
avass | zbr: but I guess that's small enough to not cause any harm | 20:15 |
avass | zbr: since it's just testing anyway | 20:15 |
zbr | something nobody looked at anyway | 20:15 |
avass | sure | 20:16 |
zbr | avass: mainly the goal is to be able to do that https://review.opendev.org/#/c/731471/4/.ansible-lint | 20:17 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 20:20 |
zbr | avass: i am also curious what you think about https://review.opendev.org/#/c/731795/ -- that one needs extra feedback before implementing. | 20:20 |
avass | zbr: I believe I already commented on it. I'm for it since as far as I can see it's seems to be more flexible. | 20:22 |
zbr | yep, for me is no brainer: enables something for which you would need browser extensions in order to avoid, w/o breaking it for those desiring to download them. | 20:27 |
*** harrymichal has quit IRC | 20:42 | |
*** rlandy is now known as rlandy|biab | 20:56 | |
*** sgw has quit IRC | 21:00 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 21:18 |
*** sgw has joined #zuul | 21:18 | |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 21:25 |
corvus | zbr, avass: i left some thoughts on 731795 based on ianw's feedback | 21:31 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 21:31 |
corvus | in short -- i think we should do some preliminary tests to see if that change is going to back us into a corner and make it harder to implement ianw's idea | 21:32 |
avass | corvus: yeah, I like that better but it's not as straight forward to implement. | 21:35 |
corvus | (and yes, if we like that idea, i think we may want to back out the same thing for .yaml files) | 21:36 |
avass | anyway, is there an easy way to template dictionary keys in ansible? Returning file comments isn't as straight forward as I would have wanted since this doesn't work: https://review.opendev.org/#/c/733675/8/roles/terraform/tasks/main.yaml | 21:38 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Rework quick-start and prepare for other tutorials https://review.opendev.org/732066 | 21:38 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate your first patch" https://review.opendev.org/732067 | 21:38 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "Use zuul jobs" https://review.opendev.org/732068 | 21:38 |
corvus | avass: it's true, but i expect not too hard. i think the main thing i'd want to see before we merge 795 is at least an analysis of it -- like "i ran highlight.js on a file locally and it did ...."; if it looks like we'll need correct mimetypes, then we can weigh the complexity of implementing it now against reverting the change later. and if we don't need the mimetypes, then we might want to do both... | 21:39 |
corvus | but if it's as not-difficult as i hope, then there's also a good chance someone will just implement ianw's idea before we finish talking about it :) | 21:40 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 21:40 |
corvus | avass: yeah, let me see if i can dig something up | 21:41 |
corvus | avass: oh you just wrote a module? :) | 21:42 |
avass | corvus: yep, that was the easiest way to get around it as far as I could see | 21:44 |
avass | corvus: I was trying to set a fact and then parse that as yaml but that had other problems :) | 21:44 |
corvus | avass: take a look at multi-node-hosts-file/tasks/main.yaml | 21:47 |
corvus | avass: basically "{% set %}" will let you create a dictionary inside a jinja template | 21:48 |
avass | corvus: nice, didn't know about that | 21:49 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 21:59 |
avass | corvus: so I'm guessing what I want is something like that ^. but I'll have to take a closer look at that tomorrow since it's getting later | 21:59 |
avass | corvus: thanks :) | 21:59 |
openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles https://review.opendev.org/733675 | 22:04 |
*** hashar has quit IRC | 22:05 | |
corvus | avass: good night! :) | 22:08 |
avass | corvus: good night! :) | 22:10 |
*** rlandy|biab is now known as rlandy | 22:15 | |
*** noonedeadpunk has quit IRC | 22:19 | |
*** noonedeadpunk has joined #zuul | 22:20 | |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Rework quick-start and prepare for other tutorials https://review.opendev.org/732066 | 22:23 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate your first patch" https://review.opendev.org/732067 | 22:23 |
openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: tutorial: Add "Use zuul jobs" https://review.opendev.org/732068 | 22:23 |
*** tdasilva has quit IRC | 22:35 | |
*** evgenyl has quit IRC | 22:35 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download https://review.opendev.org/733425 | 22:35 |
*** jbryce has quit IRC | 22:35 | |
openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: download-artifact: cleanup long when statement https://review.opendev.org/733446 | 22:35 |
*** ericsysmin has quit IRC | 22:35 | |
*** erbarr has quit IRC | 22:35 | |
*** guilhermesp has quit IRC | 22:36 | |
*** kklimonda has quit IRC | 22:36 | |
*** iamweswilson has quit IRC | 22:36 | |
*** maxamillion has quit IRC | 22:36 | |
*** rpittau|afk has quit IRC | 22:36 | |
*** mnaser has quit IRC | 22:36 | |
*** tributarian has quit IRC | 22:36 | |
*** donnyd has quit IRC | 22:36 | |
*** samccann has quit IRC | 22:36 | |
*** Open10K8S has quit IRC | 22:37 | |
*** mnasiadka has quit IRC | 22:37 | |
*** gundalow has quit IRC | 22:37 | |
*** kmalloc has quit IRC | 22:37 | |
*** portdirect has quit IRC | 22:37 | |
*** lseki has quit IRC | 22:37 | |
*** Shrews has quit IRC | 22:37 | |
*** mwhahaha has quit IRC | 22:37 | |
*** samccann has joined #zuul | 22:37 | |
*** tdasilva has joined #zuul | 22:37 | |
*** piotrowskim has quit IRC | 22:37 | |
*** johnsom has quit IRC | 22:37 | |
*** gmann has quit IRC | 22:37 | |
*** vblando has quit IRC | 22:37 | |
*** ChrisShort has quit IRC | 22:37 | |
*** wxy has quit IRC | 22:37 | |
*** webknjaz has quit IRC | 22:37 | |
*** tributarian has joined #zuul | 22:37 | |
*** stevthedev has quit IRC | 22:38 | |
*** wxy has joined #zuul | 22:38 | |
*** zbr has quit IRC | 22:38 | |
*** iamweswilson has joined #zuul | 22:38 | |
*** gmann has joined #zuul | 22:38 | |
*** Open10K8S has joined #zuul | 22:39 | |
*** ChrisShort has joined #zuul | 22:39 | |
*** vblando has joined #zuul | 22:39 | |
*** mnasiadka has joined #zuul | 22:40 | |
*** gundalow has joined #zuul | 22:40 | |
*** webknjaz has joined #zuul | 22:40 | |
*** guilhermesp has joined #zuul | 22:40 | |
*** kmalloc has joined #zuul | 22:40 | |
*** jbryce has joined #zuul | 22:41 | |
*** mnaser has joined #zuul | 22:41 | |
*** piotrowskim has joined #zuul | 22:41 | |
*** donnyd has joined #zuul | 22:41 | |
*** maxamillion has joined #zuul | 22:41 | |
*** mwhahaha has joined #zuul | 22:42 | |
*** lseki has joined #zuul | 22:42 | |
*** portdirect has joined #zuul | 22:42 | |
*** Shrews has joined #zuul | 22:42 | |
*** johnsom has joined #zuul | 22:43 | |
*** yolanda has quit IRC | 22:43 | |
*** stevthedev has joined #zuul | 22:50 | |
*** zbr has joined #zuul | 22:51 | |
*** evgenyl has joined #zuul | 22:54 | |
*** erbarr has joined #zuul | 23:01 | |
*** guilhermesp has quit IRC | 23:02 | |
*** guilhermesp has joined #zuul | 23:02 | |
*** kklimonda has joined #zuul | 23:04 | |
*** rpittau|afk has joined #zuul | 23:04 | |
*** ericsysmin has joined #zuul | 23:15 | |
*** tosky has quit IRC | 23:35 | |
*** rlandy has quit IRC | 23:37 | |
openstackgerrit | Merged zuul/zuul-jobs master: download-artifact : support recursive download https://review.opendev.org/733425 | 23:59 |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!