Thursday, 2020-06-04

openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Rework quick-start and prepare for other tutorials  https://review.opendev.org/73206600:26
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate your first patch"  https://review.opendev.org/73206700:26
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "Use zuul jobs"  https://review.opendev.org/73206800:26
*** jamesmcarthur_ has quit IRC01:01
*** swest has quit IRC01:23
*** rfolco|rover has quit IRC01:29
*** rlandy has quit IRC01:32
*** swest has joined #zuul01:37
*** jamesmcarthur has joined #zuul01:53
*** jamesmcarthur has quit IRC01:53
*** jamesmcarthur has joined #zuul01:53
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download  https://review.opendev.org/73342502:38
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download  https://review.opendev.org/73342502:43
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download  https://review.opendev.org/73342502:45
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download  https://review.opendev.org/73342502:49
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download  https://review.opendev.org/73342502:50
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download  https://review.opendev.org/73342503:01
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download  https://review.opendev.org/73342503:09
*** bhavikdbavishi has joined #zuul03:11
*** bhavikdbavishi1 has joined #zuul03:38
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download  https://review.opendev.org/73342503:39
*** bhavikdbavishi has quit IRC03:39
*** bhavikdbavishi1 is now known as bhavikdbavishi03:39
*** ajitha has joined #zuul03:50
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download  https://review.opendev.org/73342503:50
*** sgw has quit IRC04:00
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download  https://review.opendev.org/73342504:00
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download  https://review.opendev.org/73342504:17
*** evrardjp has quit IRC04:33
*** evrardjp has joined #zuul04:33
*** wuchunyang has joined #zuul04:39
openstackgerritIan Wienand proposed zuul/zuul-jobs master: [wip] download-artifact : recursive download  https://review.opendev.org/73342504:51
openstackgerritIan Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download  https://review.opendev.org/73342505:03
*** wuchunyang has quit IRC05:07
*** sgw has joined #zuul05:12
*** bhavikdbavishi has quit IRC05:12
*** bhavikdbavishi has joined #zuul05:13
openstackgerritIan Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download  https://review.opendev.org/73342505:14
openstackgerritIan Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download  https://review.opendev.org/73342505:18
*** jamesmcarthur has quit IRC05:18
masterpeNow the next one :), I have a zuul from scratch and I try to upload the logs, I use the tasks generate-zuul-manifest and upload-logs to upload the log. Both works, but I still can not find the logs. In the docker version I see the setting trusted_rw_paths who saves the logs on /srv/static/logs, If I also use trusted_rw_paths in the config. I only get console-fa163e70-c4c9-e16f-4171-000000000014-localhost.log.05:18
masterpewith the text: "2020-06-03 20:30:04.881486 | [Zuul] Task exit code: 0"05:19
openstackgerritIan Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download  https://review.opendev.org/73342505:20
*** ysandeep|away is now known as ysandeep05:25
*** saneax has quit IRC05:27
*** saneax has joined #zuul05:28
openstackgerritIan Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download  https://review.opendev.org/73342505:30
*** reiterative has quit IRC05:39
*** reiterative has joined #zuul05:39
openstackgerritIan Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download  https://review.opendev.org/73342505:42
openstackgerritMerged zuul/zuul-jobs master: Document twine_executable  https://review.opendev.org/73215005:43
*** bhavikdbavishi has quit IRC05:58
*** bhavikdbavishi has joined #zuul06:00
*** themroc has joined #zuul06:06
openstackgerritIan Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download  https://review.opendev.org/73342506:13
*** decimuscorvinus has quit IRC06:23
openstackgerritIan Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download  https://review.opendev.org/73342506:25
*** decimuscorvinus has joined #zuul06:26
*** bhavikdbavishi has quit IRC06:35
*** wuchunyang has joined #zuul06:37
*** jcapitao has joined #zuul06:47
openstackgerritIan Wienand proposed zuul/zuul-jobs master: download-artifact: cleanup long when statement  https://review.opendev.org/73344606:47
*** bhavikdbavishi has joined #zuul06:48
openstackgerritIan Wienand proposed zuul/zuul-jobs master: download-artifact: cleanup long when statement  https://review.opendev.org/73344607:00
*** bhavikdbavishi has quit IRC07:02
*** bhavikdbavishi has joined #zuul07:06
*** hashar has joined #zuul07:08
openstackgerritIan Wienand proposed zuul/zuul-jobs master: download-artifact: cleanup long when statement  https://review.opendev.org/73344607:13
*** jpena|off is now known as jpena07:19
*** themroc has quit IRC07:35
*** bhavikdbavishi has quit IRC07:38
tobiashzuul-maint: we discovered that we seldom have empty or missing files in the swift upload logs without any trace of an error in the logs. The reason seems to be that upload-logs-swift throws an error when the initial preparation and connection fails but ignores any file upload error (logging.foo goes to nowhere within the module context). See https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/upload-logs-swift/library/07:42
tobiashzuul_swift_upload.py#L67707:42
tobiashzuul-maint: I see two viable options how we could improve this. First would be to fail the task in case of an upload error, the second would be to retain the behavior but add an errors list to the task upload so this at least can be logged on the executor side07:43
tobiashzuul-maint: what do you think?07:44
*** tosky has joined #zuul07:46
*** rpittau|afk is now known as rpittau07:50
guillaumecAJaeger: about ensure-python, ensure-twine, ensure-tox (https://review.opendev.org/#/c/731853/) and for the latter where I said in a comment that I didn't think it that the zuul's tutorial was able to fetch the change.  because how can the git driver using http://opendev.org/zuul/zuul-jobs can possibly fetch a change !08:00
guillaumecAJaeger: I did try for https://review.opendev.org/#/c/733419/ and it worked! use by https://review.opendev.org/#/c/732068/ where tox-py27 is used, and the node-Dockerfile modified from https://review.opendev.org/#/c/732066 doesn't have python2 installed08:01
guillaumecAJaeger: I looked at the logs, saw some "mirror" roles, I checked opendev.org/zuul/zuul-jobs/roles/*mirror*  but I cannot find how "git clone https://opendev.org/zuul/zuul-jobs" from the tutorial's executor can fetch the change. from /home/zuul/src/opendev.org/zuul/zuul-jobs (on the node ? and how ?)08:02
AJaegerguillaumec: I'm using OpenDev's Zuul where all changes are pre-pushed on the images.08:02
AJaegerlet me find you some links08:02
*** nils has joined #zuul08:02
AJaegerhttps://zuul.opendev.org/t/zuul/build/5db38688bcb84dd0911b9739e1eb890b/log/job-output.txt#220-22408:03
AJaegersorry, not pre-pushed - we have an ansible role that pushes them08:03
*** bhavikdbavishi has joined #zuul08:03
AJaegerguillaumec: https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/mirror-workspace-git-repos08:04
AJaegerSo, the executor prepares the git repo and then this role pushes it on the images. So, no need to fetch anything, it gets pushed ;)08:04
guillaumecAJaeger: yes, I saw that in the job file "3c60f4e7a2bf6626a45ed7c5883e2e551c660cc6 Add python_version for tox27"  https://3828237a78f90f6372ec-12b9f401fcb2e40f556f780fa3b8c456.ssl.cf5.rackcdn.com/732068/6/check/zuul-tutorial-use-zuul-jobs/5afa312/job-output.txt08:09
guillaumecbut this job will start a zuul's executor container, which will fetch opendev.org, zuul/zuul-jobs  using the git driver.    I can't find the link between the 2.08:10
*** yolanda has joined #zuul08:12
AJaegerguillaumec: sorry, can't help with that08:14
openstackgerritGuillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on  https://review.opendev.org/73206808:20
*** ysandeep is now known as ysandeep|lunch08:20
openstackgerritAlbin Vass proposed zuul/zuul master: zookeeper-tls-howto: Remove unused keystorepassword  https://review.opendev.org/73347808:27
openstackgerritSimon Westphahl proposed zuul/zuul master: Don't recreate parse context for every config file  https://review.opendev.org/72877408:37
*** wuchunyang has quit IRC08:39
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Rework quick-start and prepare for other tutorials  https://review.opendev.org/73206608:45
*** themroc has joined #zuul08:47
ajithaHi, how to enable the web UI in zuul. I am getting this error "FileNotFoundError: [Errno 2] No such file or directory08:55
ajithain web.log08:55
mrcircaHello,08:55
*** dennis_effa has joined #zuul09:02
*** ysandeep|lunch is now known as ysandeep09:03
dennis_effaHello,  I'm a noob here and I would want to ask how zuul stream logs during long running tasks09:06
dennis_effaThe whole point is I'm running a playbook in ansible and it gives feedback after the task is done. But I would like to stream the output during runtime09:09
dennis_effaAnd I was told zuul implements similar concept in its logs09:10
tobiashdennis_effa: zuul overwrites the command module and uses a custom callback plugin09:53
tobiashajitha: can you post more logs of the zuul-web service?09:55
*** dpawlik has quit IRC09:57
*** dpawlik3 has joined #zuul09:57
ajithatobiash: Thanks. sure09:57
ajithahttp://paste.openstack.org/show/794360/09:57
tobiashajitha: that tail shows only an error while zuul-web is already stopping. The real error must be before that09:58
ajithai have just started to configure zuulv3 for a third part CI09:59
tobiashis there more in the logs?10:00
ajithayes10:00
ajithahttp://paste.openstack.org/show/794361/10:00
ajithaany clue? i am a newbie10:02
*** rpittau is now known as rpittau|bbl10:02
tobiashthat exception happens in the shutdown sequence so you can ignore that for now. Did you stop it yourself directly after starting?10:03
*** themroc has left #zuul10:03
ajithatobiash: also config-projects: field in main.yaml need to be a git repo?10:04
ajithayes yes..10:04
ajithai thought it is an error10:04
tobiashyes, config-projects needs to list git repos10:04
*** dpawlik3 has quit IRC10:05
tobiashbut main.yaml is relevant for the scheduler, not web10:05
ajithabut when i check the UI using ip:9000. I got 404 Not Found10:05
*** dpawlik3 has joined #zuul10:05
tobiashhow did you install it?10:05
tobiashthat sounds like the static stuff is missing10:06
ajithayes main.yaml i know its different.. i had a query on that..10:06
ajithainstalled by following zuul from scratch10:06
ajithai didnt configure any git repo yet.. Will that be an issue like web UI cant fetch it?10:07
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate your first patch"  https://review.opendev.org/73206710:07
openstackgerritGuillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on  https://review.opendev.org/73206810:07
dennis_effatobiash: thanks for the response and can you help me with a link to the custom callback plugin?10:07
tobiashzuul-web needs a running scheduler10:07
ajithatobiash: scheduler is running10:10
ajitha2020-06-04 03:01:33,245 INFO zuul.Scheduler: Starting scheduler10:10
openstackgerritGuillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on  https://review.opendev.org/73352010:11
ajithatobiash: http://paste.openstack.org/show/794363/10:13
ajithamy conf10:13
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "Use zuul jobs"  https://review.opendev.org/73206810:16
*** saneax is now known as saneax_AFK10:48
openstackgerritTobias Henkel proposed zuul/zuul master: Increase gerrit event delay to 20s  https://review.opendev.org/73354210:50
*** ajitha has quit IRC10:50
*** ysandeep is now known as ysandeep|afk10:51
tobiashzuul-maint: we see a lot of unprocessed events because of the gerrit event vs api availability race of a change therefore this change ^10:53
*** wuchunyang has joined #zuul10:53
tobiashzuul-maint: I think we don't want to make this configurable. Thus just increasing the delay is the wrong path I think. What do you think about replacing that delay by busy waiting until a change is available with a higher timeout like 30s ir 1min?10:54
*** jcapitao is now known as jcapitao_lunch11:04
*** wuchunyang has quit IRC11:11
openstackgerritGuillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on  https://review.opendev.org/73352011:15
openstackgerritFelix Edel proposed zuul/zuul-jobs master: Return upload_results in upload-logs-swift role  https://review.opendev.org/73356411:24
*** felixedel has joined #zuul11:31
*** donnyd_ has quit IRC11:33
*** donnyd_ has joined #zuul11:34
*** donnyd_ has quit IRC11:34
*** rpittau|bbl is now known as rpittau11:35
felixedelzuul-main: Are there any plans on updating zuul-web from using Patternfly 3 to Patternfly 4?11:36
felixedelzuul-maint: ^11:37
*** jpena is now known as jpena|lunch11:38
openstackgerritFelix Edel proposed zuul/zuul-jobs master: Return upload_results in upload-logs-swift role  https://review.opendev.org/73356411:41
*** donnyd_ has joined #zuul11:42
*** ysandeep|afk is now known as ysandeep11:43
*** donnyd_ is now known as donnyd11:44
*** felixedel has quit IRC11:47
tobiashfelixedel: I saw no changes in that regard afaik11:48
tristanCtobiash: i would be in favor for using a busy dynamic retry, the arbritary timeout makes gerrit connection feel sluggish. Though iirc the delay was set because gerrit data can be inconsistent earlier, how can we detect that the data we get is correct?11:52
tobiashtristanC: the problem was that the change was not there at all (which is inconsistent with getting events for that)11:53
tobiashI had such an attempt back in v2 times: https://review.opendev.org/20604311:53
tobiashmaybe it's worth to revive that11:53
tristanCtobiash: perhaps we could use https://github.com/jd/tenacity ?11:54
zbrtristanC: https://review.opendev.org/#/c/731591/ - already removed the albin part, to allow it to be merged.11:55
*** rfolco|rover has joined #zuul11:58
*** bhavikdbavishi has quit IRC11:58
*** jcapitao_lunch is now known as jcapitao12:01
*** fbo|off is now known as fbo12:06
*** rlandy has joined #zuul12:23
openstackgerritGuillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on  https://review.opendev.org/73352012:26
*** arxcruz has quit IRC12:28
*** arxcruz has joined #zuul12:29
*** ianychoi_ has joined #zuul12:32
*** sanjayu_ has joined #zuul12:32
*** dpawlik6 has joined #zuul12:33
*** dry has joined #zuul12:33
*** Tahvok_ has joined #zuul12:34
*** tobiash_ has joined #zuul12:35
*** dmellado_ has joined #zuul12:35
*** bhavikdbavishi has joined #zuul12:36
*** bolg has quit IRC12:36
*** SotK has quit IRC12:36
*** tobberydberg has quit IRC12:36
*** pots has quit IRC12:36
*** dmellado has quit IRC12:36
*** arxcruz has quit IRC12:36
*** dpawlik3 has quit IRC12:36
*** jkt has quit IRC12:36
*** tobiash has quit IRC12:36
*** ysandeep has quit IRC12:36
*** saneax_AFK has quit IRC12:36
*** paladox has quit IRC12:36
*** Tahvok has quit IRC12:36
*** ianychoi has quit IRC12:36
*** yolanda has quit IRC12:36
*** msuszko has quit IRC12:36
*** Tahvok_ is now known as Tahvok12:36
*** dmellado_ is now known as dmellado12:37
*** pots has joined #zuul12:37
*** arxcruz has joined #zuul12:37
*** ysandeep has joined #zuul12:37
*** paladox has joined #zuul12:37
*** SotK has joined #zuul12:37
*** tobberydberg has joined #zuul12:38
*** yolanda has joined #zuul12:38
*** sanjayu_ is now known as saneax12:46
*** jpena|lunch is now known as jpena12:46
*** wuchunyang has joined #zuul12:46
*** sshnaidm is now known as sshnaidm|mtg12:59
*** bhavikdbavishi has quit IRC13:17
*** rpittau is now known as rpittau|brb13:24
openstackgerritGuillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on  https://review.opendev.org/73352013:25
*** saneax has quit IRC13:46
*** hashar has quit IRC13:56
*** rpittau|brb is now known as rpittau14:01
corvustobiash_: you linked to https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/upload-logs-swift/library/zuul_swift_upload.py#L677 earlier at 07:42, but i don't see the relevance to what you're describing; did you mean a different line?14:21
corvustobiash_: if we added an errors list to the return value, are we sure it would show up in executor logs?  i think it would only show up if -vvv were set, right?  but maybe there's some way we can return that to ansible that would cause it to appear as a warning?14:22
*** tobiash_ is now known as tobiash14:23
tobiashcorvus: we could register and print that using a debug task afterwards14:23
corvustobiash_: but generally, i think we expect the upload tasks to fail in the case of error, so i think maybe we should do that as well.  so return an errors list and fail?14:24
corvusguillaumec: it is correct that you can't use depends-on with the git driver.  in a tutorial, when we teach people how to use depends-on, it should be between two repos in gerrit (not zuul-jobs).14:24
tobiashcorvus: makes sense generally14:25
tobiashwe do failover to another cloud when upload fails14:25
tobiashso this would make at least our use case more predictable14:25
corvustobiash, tristanC: i think a retry/back-off would be okay, but maybe keep a minimum value?  it's also possible that the inconsistent data problem is solved, especially in later gerrits; maybe once we add retry we could experiment with dropping the minimum delay.14:29
corvustobiash: yeah, register/debug would be good, then it'll show up in the streaming log too (but we'll need to be careful not to log any error messages with credentials)14:30
tobiashcorvus: I think we're already retrying the files upload so I guess failing the task with the file plus stacktrace would be ok14:33
corvustobiash: incidentally, do you know what the failure is?  (i think a goal of this should probably be to get enough error information out that we can then also maybe make the role more robust -- maybe retry this failing action)14:35
*** hashar has joined #zuul14:36
openstackgerritGuillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on  https://review.opendev.org/73352014:37
tobiashcorvus: that's my problem, I only know that something happened because a user wanted to download a file (index was correctly uploaded) and got a 40414:37
tobiashwith no trace of an error anywhere14:37
*** bhavikdbavishi has joined #zuul15:36
*** bhavikdbavishi1 has joined #zuul15:39
*** bhavikdbavishi has quit IRC15:41
*** bhavikdbavishi1 is now known as bhavikdbavishi15:41
*** fbo is now known as fbo|off15:46
*** ajitha has joined #zuul16:09
*** nils has quit IRC16:10
tobiashcorvus: with that link I meant this and the following function, more specifically https://opendev.org/zuul/zuul-jobs/src/branch/master/roles/upload-logs-swift/library/zuul_swift_upload.py#L708 where we log (which only works in cli testing) and ignore the error16:19
corvustobiash: ah yep.  i agree we could do something more useful there.16:26
tobiashcorvus: felix is working on this, but I think we should decide if we want success+reporting or fail+reporting there16:27
tobiashhis current state is success+reporting (https://review.opendev.org/733564)16:28
*** rpittau is now known as rpittau|afk16:31
*** jcapitao has quit IRC16:32
corvustobiash: oooh, i think i misunderstood where the error was happening16:34
corvustobiash: i think in that case, it's really hard to determine whether we should return success or failure.  let's stick with success for now, and maybe as we learn more about the problem, consider switching to failure.16:35
tobiashok16:36
corvustobiash: but we might want to include more info in the 'error' than that :)   i'll leave a quick preliminary review16:36
tobiashcorvus: my thinking was a list of dicts containing filename and exception trace16:37
*** jpena is now known as jpena|off16:52
*** ysandeep is now known as ysandeep|away16:53
*** sshnaidm|mtg is now known as sshnaidm|afk16:59
*** ajitha has quit IRC17:03
*** hashar has quit IRC17:07
*** avass has joined #zuul17:24
AJaegerzuul-jobs-maint, ianw has updated the download-artifact role for recursive download, see https://review.opendev.org/#/c/733425/ Please check the test job - it uses logs that expire, so when we update in a few month and rerun the tests, we need to change that. Reviews welcome - this is part of reworking the wheel building.17:37
*** rlandy is now known as rlandy|brb17:45
openstackgerritGuillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on  https://review.opendev.org/73352017:50
openstackgerritSorin Sbarnea (zbr) proposed zuul/zuul-jobs master: test-playbooks: avoid warnings with shell/command  https://review.opendev.org/73160517:55
avasshuh, I just realized there's an easy way to leave file comments, but no easy way to just leave a comment.18:03
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform jobs  https://review.opendev.org/73367518:18
*** rlandy|brb is now known as rlandy18:20
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367518:30
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367518:32
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367518:40
openstackgerritGuillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on  https://review.opendev.org/73352018:48
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367518:48
*** bhavikdbavishi has quit IRC18:59
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367519:01
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367519:13
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367519:17
*** hashar has joined #zuul19:44
*** dennis_effa has quit IRC19:49
*** harrymichal has joined #zuul19:58
openstackgerritMerged zuul/zuul-jobs master: test-playbooks: improved syntax  https://review.opendev.org/73159120:00
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367520:04
zbrianw: avass : https://review.opendev.org/#/c/731605/ - already sorted all comments20:06
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367520:08
avasszbr: looking20:08
openstackgerritGuillaume Chauvel proposed zuul/zuul master: DNM: tutorial: Add "Use zuul jobs", test without depends-on  https://review.opendev.org/73352020:09
openstackgerritGuillaume Chauvel proposed zuul/zuul master: QUICKSTART  https://review.opendev.org/73368920:09
avasszbr: it's just disabling runtime warnings from ansible right?20:10
zbravass: yes, mainly in order to allow us to include testing playbooks in linting (where these warnings are errors)20:11
zbrmainly, we are telling ansible that we know what we are doing.20:12
avasszbr: oh do you know if we're removing pip with shell for a reason?20:13
avasszbr: otherwise it might be better to change that to command: instead of hiding those warnings20:14
avasszbr: otherwise it lgtm20:14
zbravass: is during testing, tbh, likely it should have being a command too.20:14
zbrbut lets fix one problem at a time20:14
zbrotherwise we will never finish it.20:15
avasszbr: but adding warn: false there is actually hiding something20:15
avasszbr: but I guess that's small enough to not cause any harm20:15
avasszbr: since it's just testing anyway20:15
zbrsomething nobody looked at anyway20:15
avasssure20:16
zbravass: mainly the goal is to be able to do that https://review.opendev.org/#/c/731471/4/.ansible-lint20:17
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367520:20
zbravass: i am also curious what you think about https://review.opendev.org/#/c/731795/ -- that one needs extra feedback before implementing.20:20
avasszbr: I believe I already commented on it. I'm for it since as far as I can see it's seems to be more flexible.20:22
zbryep, for me is no brainer: enables something for which you would need browser extensions in order to avoid, w/o breaking it for those desiring to download them.20:27
*** harrymichal has quit IRC20:42
*** rlandy is now known as rlandy|biab20:56
*** sgw has quit IRC21:00
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367521:18
*** sgw has joined #zuul21:18
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367521:25
corvuszbr, avass: i left some thoughts on 731795 based on ianw's feedback21:31
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367521:31
corvusin short -- i think we should do some preliminary tests to see if that change is going to back us into a corner and make it harder to implement ianw's idea21:32
avasscorvus: yeah, I like that better but it's not as straight forward to implement.21:35
corvus(and yes, if we like that idea, i think we may want to back out the same thing for .yaml files)21:36
avassanyway, is there an easy way to template dictionary keys in ansible? Returning file comments isn't as straight forward as I would have wanted since this doesn't work: https://review.opendev.org/#/c/733675/8/roles/terraform/tasks/main.yaml21:38
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Rework quick-start and prepare for other tutorials  https://review.opendev.org/73206621:38
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate your first patch"  https://review.opendev.org/73206721:38
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "Use zuul jobs"  https://review.opendev.org/73206821:38
corvusavass: it's true, but i expect not too hard.  i think the main thing i'd want to see before we merge 795 is at least an analysis of it -- like "i ran highlight.js on a file locally and it did ...."; if it looks like we'll need correct mimetypes, then we can weigh the complexity of implementing it now against reverting the change later.  and if we don't need the mimetypes, then we might want to do both...21:39
corvusbut if it's as not-difficult as i hope, then there's also a good chance someone will just implement ianw's idea before we finish talking about it :)21:40
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367521:40
corvusavass: yeah, let me see if i can dig something up21:41
corvusavass: oh you just wrote a module? :)21:42
avasscorvus: yep, that was the easiest way to get around it as far as I could see21:44
avasscorvus: I was trying to set a fact and then parse that as yaml but that had other problems :)21:44
corvusavass: take a look at multi-node-hosts-file/tasks/main.yaml21:47
corvusavass: basically "{% set %}" will let you create a dictionary inside a jinja template21:48
avasscorvus: nice, didn't know about that21:49
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367521:59
avasscorvus: so I'm guessing what I want is something like that ^. but I'll have to take a closer look at that tomorrow since it's getting later21:59
avasscorvus: thanks :)21:59
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: WIP: Add terraform roles  https://review.opendev.org/73367522:04
*** hashar has quit IRC22:05
corvusavass: good night! :)22:08
avasscorvus: good night! :)22:10
*** rlandy|biab is now known as rlandy22:15
*** noonedeadpunk has quit IRC22:19
*** noonedeadpunk has joined #zuul22:20
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Rework quick-start and prepare for other tutorials  https://review.opendev.org/73206622:23
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "gate your first patch"  https://review.opendev.org/73206722:23
openstackgerritGuillaume Chauvel proposed zuul/zuul master: tutorial: Add "Use zuul jobs"  https://review.opendev.org/73206822:23
*** tdasilva has quit IRC22:35
*** evgenyl has quit IRC22:35
openstackgerritIan Wienand proposed zuul/zuul-jobs master: download-artifact : support recursive download  https://review.opendev.org/73342522:35
*** jbryce has quit IRC22:35
openstackgerritIan Wienand proposed zuul/zuul-jobs master: download-artifact: cleanup long when statement  https://review.opendev.org/73344622:35
*** ericsysmin has quit IRC22:35
*** erbarr has quit IRC22:35
*** guilhermesp has quit IRC22:36
*** kklimonda has quit IRC22:36
*** iamweswilson has quit IRC22:36
*** maxamillion has quit IRC22:36
*** rpittau|afk has quit IRC22:36
*** mnaser has quit IRC22:36
*** tributarian has quit IRC22:36
*** donnyd has quit IRC22:36
*** samccann has quit IRC22:36
*** Open10K8S has quit IRC22:37
*** mnasiadka has quit IRC22:37
*** gundalow has quit IRC22:37
*** kmalloc has quit IRC22:37
*** portdirect has quit IRC22:37
*** lseki has quit IRC22:37
*** Shrews has quit IRC22:37
*** mwhahaha has quit IRC22:37
*** samccann has joined #zuul22:37
*** tdasilva has joined #zuul22:37
*** piotrowskim has quit IRC22:37
*** johnsom has quit IRC22:37
*** gmann has quit IRC22:37
*** vblando has quit IRC22:37
*** ChrisShort has quit IRC22:37
*** wxy has quit IRC22:37
*** webknjaz has quit IRC22:37
*** tributarian has joined #zuul22:37
*** stevthedev has quit IRC22:38
*** wxy has joined #zuul22:38
*** zbr has quit IRC22:38
*** iamweswilson has joined #zuul22:38
*** gmann has joined #zuul22:38
*** Open10K8S has joined #zuul22:39
*** ChrisShort has joined #zuul22:39
*** vblando has joined #zuul22:39
*** mnasiadka has joined #zuul22:40
*** gundalow has joined #zuul22:40
*** webknjaz has joined #zuul22:40
*** guilhermesp has joined #zuul22:40
*** kmalloc has joined #zuul22:40
*** jbryce has joined #zuul22:41
*** mnaser has joined #zuul22:41
*** piotrowskim has joined #zuul22:41
*** donnyd has joined #zuul22:41
*** maxamillion has joined #zuul22:41
*** mwhahaha has joined #zuul22:42
*** lseki has joined #zuul22:42
*** portdirect has joined #zuul22:42
*** Shrews has joined #zuul22:42
*** johnsom has joined #zuul22:43
*** yolanda has quit IRC22:43
*** stevthedev has joined #zuul22:50
*** zbr has joined #zuul22:51
*** evgenyl has joined #zuul22:54
*** erbarr has joined #zuul23:01
*** guilhermesp has quit IRC23:02
*** guilhermesp has joined #zuul23:02
*** kklimonda has joined #zuul23:04
*** rpittau|afk has joined #zuul23:04
*** ericsysmin has joined #zuul23:15
*** tosky has quit IRC23:35
*** rlandy has quit IRC23:37
openstackgerritMerged zuul/zuul-jobs master: download-artifact : support recursive download  https://review.opendev.org/73342523:59

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!