| *** jamesmcarthur has quit IRC | 00:00 | |
| *** jamesmcarthur has joined #zuul | 00:00 | |
| *** jamesmcarthur has quit IRC | 00:01 | |
| *** jamesmcarthur has joined #zuul | 00:01 | |
| *** jamesmcarthur has quit IRC | 00:01 | |
| *** jamesmcarthur has joined #zuul | 00:01 | |
| *** jamesmcarthur has quit IRC | 00:04 | |
| *** jamesmcarthur has joined #zuul | 00:05 | |
| fungi | computers: it's messy | 00:34 |
|---|---|---|
| *** jamesmcarthur has quit IRC | 00:34 | |
| *** sanjayu_ has quit IRC | 00:40 | |
| *** swest has quit IRC | 01:29 | |
| *** swest has joined #zuul | 01:44 | |
| *** threestrands_ has joined #zuul | 02:47 | |
| *** threestrands_ has quit IRC | 02:48 | |
| *** threestrands_ has joined #zuul | 02:49 | |
| *** threestrands_ has quit IRC | 02:50 | |
| *** threestrands has quit IRC | 02:50 | |
| *** threestrands_ has joined #zuul | 02:50 | |
| *** threestrands_ has quit IRC | 02:51 | |
| *** threestrands_ has joined #zuul | 02:52 | |
| *** threestrands_ has quit IRC | 02:53 | |
| *** threestrands_ has joined #zuul | 02:53 | |
| *** threestrands_ has quit IRC | 02:54 | |
| *** threestrands_ has joined #zuul | 02:55 | |
| *** threestrands_ has quit IRC | 02:56 | |
| *** threestrands_ has joined #zuul | 02:56 | |
| *** threestrands_ has quit IRC | 02:57 | |
| *** threestrands_ has joined #zuul | 02:58 | |
| *** threestrands_ has quit IRC | 02:59 | |
| *** threestrands_ has joined #zuul | 02:59 | |
| *** threestrands_ has quit IRC | 03:00 | |
| *** threestrands_ has joined #zuul | 03:01 | |
| *** threestrands_ has quit IRC | 03:02 | |
| *** threestrands_ has joined #zuul | 03:02 | |
| *** threestrands_ has quit IRC | 03:03 | |
| *** threestrands_ has joined #zuul | 03:04 | |
| *** threestrands_ has quit IRC | 03:05 | |
| *** threestrands_ has joined #zuul | 03:05 | |
| *** threestrands_ has quit IRC | 03:06 | |
| *** threestrands_ has joined #zuul | 03:07 | |
| *** threestrands_ has quit IRC | 03:08 | |
| *** threestrands_ has joined #zuul | 03:08 | |
| *** threestrands_ has quit IRC | 03:09 | |
| *** threestrands_ has joined #zuul | 03:10 | |
| *** threestrands_ has quit IRC | 03:11 | |
| *** threestrands_ has joined #zuul | 03:11 | |
| *** threestrands_ has quit IRC | 03:12 | |
| *** threestrands_ has joined #zuul | 03:13 | |
| *** threestrands_ has quit IRC | 03:14 | |
| *** threestrands_ has joined #zuul | 03:14 | |
| *** threestrands_ has quit IRC | 03:15 | |
| *** threestrands_ has joined #zuul | 03:16 | |
| *** threestrands_ has quit IRC | 03:17 | |
| *** threestrands_ has joined #zuul | 03:17 | |
| *** threestrands_ has quit IRC | 03:18 | |
| *** threestrands_ has joined #zuul | 03:19 | |
| *** threestrands_ has quit IRC | 03:20 | |
| *** threestrands_ has joined #zuul | 03:20 | |
| *** threestrands_ has quit IRC | 03:21 | |
| *** threestrands_ has joined #zuul | 03:22 | |
| *** threestrands_ has quit IRC | 03:23 | |
| *** threestrands_ has joined #zuul | 03:23 | |
| *** threestrands_ has quit IRC | 03:24 | |
| *** threestrands_ has joined #zuul | 03:25 | |
| *** threestrands_ has quit IRC | 03:26 | |
| *** threestrands_ has joined #zuul | 03:26 | |
| *** threestrands_ has quit IRC | 03:27 | |
| *** threestrands_ has joined #zuul | 03:28 | |
| *** threestrands_ has quit IRC | 03:29 | |
| *** threestrands_ has joined #zuul | 03:29 | |
| *** threestrands_ has quit IRC | 03:30 | |
| *** threestrands_ has joined #zuul | 03:31 | |
| *** threestrands_ has quit IRC | 03:32 | |
| *** threestrands_ has joined #zuul | 03:32 | |
| *** threestrands_ has quit IRC | 03:33 | |
| *** threestrands_ has joined #zuul | 03:34 | |
| *** threestrands_ has quit IRC | 03:35 | |
| *** threestrands_ has joined #zuul | 03:35 | |
| *** threestrands_ has quit IRC | 03:36 | |
| *** threestrands_ has joined #zuul | 03:37 | |
| *** threestrands_ has quit IRC | 03:38 | |
| *** threestrands_ has joined #zuul | 03:38 | |
| *** threestrands_ has quit IRC | 03:39 | |
| *** threestrands_ has joined #zuul | 03:40 | |
| *** threestrands_ has quit IRC | 03:41 | |
| *** threestrands_ has joined #zuul | 03:41 | |
| *** threestrands_ has quit IRC | 03:42 | |
| *** threestrands_ has joined #zuul | 03:43 | |
| *** threestrands_ has quit IRC | 03:44 | |
| *** threestrands_ has joined #zuul | 03:44 | |
| *** threestrands_ has quit IRC | 03:45 | |
| *** threestrands_ has joined #zuul | 03:46 | |
| *** threestrands_ has quit IRC | 03:47 | |
| *** threestrands_ has joined #zuul | 03:47 | |
| *** threestrands_ has quit IRC | 03:48 | |
| *** threestrands_ has joined #zuul | 03:49 | |
| *** threestrands_ has quit IRC | 03:50 | |
| *** threestrands_ has joined #zuul | 03:50 | |
| *** threestrands_ has quit IRC | 03:51 | |
| *** threestrands_ has joined #zuul | 03:52 | |
| *** threestrands_ has quit IRC | 03:53 | |
| *** threestrands_ has joined #zuul | 03:53 | |
| *** threestrands_ has quit IRC | 03:54 | |
| *** threestrands_ has joined #zuul | 03:55 | |
| *** threestrands_ has quit IRC | 03:56 | |
| *** threestrands_ has joined #zuul | 03:56 | |
| *** threestrands_ has quit IRC | 03:57 | |
| *** threestrands_ has joined #zuul | 03:58 | |
| *** threestrands_ has quit IRC | 03:59 | |
| *** threestrands_ has joined #zuul | 03:59 | |
| *** threestrands_ has quit IRC | 04:00 | |
| *** threestrands_ has joined #zuul | 04:01 | |
| *** threestrands_ has quit IRC | 04:02 | |
| *** threestrands_ has joined #zuul | 04:02 | |
| *** threestrands_ has quit IRC | 04:03 | |
| *** threestrands_ has joined #zuul | 04:04 | |
| *** threestrands_ has quit IRC | 04:05 | |
| *** threestrands_ has joined #zuul | 04:05 | |
| *** threestrands_ has quit IRC | 04:06 | |
| *** threestrands_ has joined #zuul | 04:07 | |
| *** threestrands_ has quit IRC | 04:08 | |
| *** threestrands_ has joined #zuul | 04:08 | |
| *** threestrands_ has quit IRC | 04:09 | |
| *** threestrands_ has joined #zuul | 04:10 | |
| *** threestrands_ has quit IRC | 04:11 | |
| *** threestrands_ has joined #zuul | 04:11 | |
| *** threestrands_ has quit IRC | 04:12 | |
| *** threestrands_ has joined #zuul | 04:13 | |
| *** threestrands_ has quit IRC | 04:14 | |
| *** threestrands_ has joined #zuul | 04:14 | |
| *** threestrands_ has quit IRC | 04:15 | |
| *** threestrands_ has joined #zuul | 04:16 | |
| *** threestrands_ has quit IRC | 04:17 | |
| *** threestrands_ has joined #zuul | 04:17 | |
| *** threestrands_ has quit IRC | 04:18 | |
| *** threestrands_ has joined #zuul | 04:19 | |
| *** threestrands_ has quit IRC | 04:20 | |
| *** threestrands_ has joined #zuul | 04:20 | |
| *** threestrands_ has quit IRC | 04:21 | |
| *** threestrands_ has joined #zuul | 04:22 | |
| *** dmellado has quit IRC | 04:23 | |
| *** evrardjp has quit IRC | 04:33 | |
| *** evrardjp has joined #zuul | 04:33 | |
| *** sanjayu_ has joined #zuul | 04:38 | |
| *** bolg has quit IRC | 05:12 | |
| *** sgw has quit IRC | 05:48 | |
| *** ysandeep|away is now known as ysandeep | 05:55 | |
| *** dpawlik has joined #zuul | 05:55 | |
| *** guillaumec has joined #zuul | 06:23 | |
| *** dmellado has joined #zuul | 06:24 | |
| *** harrymichal has quit IRC | 06:33 | |
| *** harrymichal has joined #zuul | 06:34 | |
| *** ajitha has joined #zuul | 06:39 | |
| ajitha | Hi , We are running a third party CI and currently using zuulv2 with devstack-gate. We are yet to migrate to zuulv3. Can I know when zuulv2 will retire? | 06:40 |
| *** rpittau|afk is now known as rpittau | 07:04 | |
| *** jcapitao has joined #zuul | 07:06 | |
| *** hashar has joined #zuul | 07:08 | |
| *** tosky has joined #zuul | 07:12 | |
| *** jpena|off is now known as jpena | 07:56 | |
| ajitha | Hi , We are running a third party CI and currently using zuulv2 with devstack-gate. We are yet to migrate to zuulv3. Can I know when zuulv2 will retire? | 07:57 |
| *** harrymichal has quit IRC | 08:03 | |
| *** harrymichal has joined #zuul | 08:04 | |
| *** harrymichal has quit IRC | 08:40 | |
| *** ysandeep is now known as ysandeep|lunch | 08:43 | |
| avass | ajitha: I'm not sure if there's any active development on zuulv2 and zuulv4 is getting close since the last zuulv3 version was just released | 08:46 |
| ajitha | avass: zuulv4 | 08:47 |
| ajitha | ? | 08:47 |
| ajitha | devstack-gate is supported? | 08:47 |
| AJaeger | ajitha: devstack-gate is getting retired in current cycle | 08:57 |
| ajitha | V release? | 08:57 |
| AJaeger | yes, Victoria | 08:58 |
| ajitha | AJaeger: Thank you. Ok So till October(V release date) devstack-gate will get supported. | 08:59 |
| ajitha | ? | 08:59 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: web UI: add Autoholds Requests page https://review.opendev.org/729307 | 09:12 |
| zbr | avass: AJaeger: any change to help with https://review.opendev.org/#/q/topic:al43b+(status:open+OR+status:merged) ? | 09:22 |
| avass | zbr: too much to do today sorry, but I can take a look after working hours | 09:44 |
| AJaeger | ajitha: supported is a loaded word. There'S nothing new getting added to it, we move everything away from it. Latest with V release, master will not be supported - the work has already started. | 09:45 |
| AJaeger | zbr: later, yes | 09:45 |
| zbr | thanks. ping me if you need help others. | 09:45 |
| AJaeger | will do, thanks | 09:46 |
| *** yolanda has joined #zuul | 09:46 | |
| *** threestrands_ has quit IRC | 09:48 | |
| *** hashar has quit IRC | 09:59 | |
| *** ysandeep|lunch is now known as ysandeep | 10:03 | |
| *** rpittau is now known as rpittau|bbl | 10:07 | |
| *** ajitha has quit IRC | 10:22 | |
| *** jcapitao is now known as jcapitao_lunch | 11:07 | |
| *** fbo|off is now known as fbo | 11:09 | |
| *** harrymichal has joined #zuul | 11:22 | |
| *** jpena is now known as jpena|lunch | 11:36 | |
| *** harrymichal has quit IRC | 11:39 | |
| *** rfolco|rover has joined #zuul | 11:51 | |
| *** hashar has joined #zuul | 11:56 | |
| *** harrymichal has joined #zuul | 12:07 | |
| *** Tahvok has quit IRC | 12:10 | |
| *** jcapitao_lunch is now known as jcapitao | 12:16 | |
| *** EmilienM is now known as EvilienM | 12:21 | |
| *** Tahvok has joined #zuul | 12:29 | |
| *** rpittau|bbl is now known as rpittau | 12:35 | |
| *** jpena|lunch is now known as jpena | 12:42 | |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Enhance ZK CA script and doku https://review.opendev.org/731475 | 12:45 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper https://review.opendev.org/716221 | 12:59 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper https://review.opendev.org/716262 | 12:59 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper https://review.opendev.org/716875 | 12:59 |
| piotrowskim | did anyone have a problem with cloning repository with ssh on zuul job? | 13:03 |
| tobiash | piotrowskim: what is the use case, cloning as part of the job or is zuul itself having problems to clone the repo? | 13:16 |
| piotrowskim | part of the job, i get the 'Host key verification failed. fatal: Could not read from remote repository' and I it was working few hous ago | 13:18 |
| piotrowskim | https://review.opendev.org/#/c/725200/ | 13:18 |
| AJaeger | piotrowskim: why are you cloning at all? | 13:19 |
| AJaeger | piotrowskim: you should get the repos you need with requireed-projects in your job defintion | 13:19 |
| piotrowskim | i need to clone kibana reposiotry to build plugin, generally I need to create zuul job that will check if plugin builds, just it | 13:20 |
| piotrowskim | hmm | 13:20 |
| AJaeger | ah, cloning a repo that is not in OpenStack? WE can add repos to our config to allow cloning as well | 13:21 |
| piotrowskim | how can i achieve that? | 13:22 |
| piotrowskim | in required projects section i can specify github repo with specific branch? | 13:26 |
| AJaeger | piotrowskim: you first need to add it here: https://opendev.org/openstack/project-config/src/branch/master/zuul/main.yaml#L1481-L1502 | 13:30 |
| AJaeger | and then you can add to required-projects | 13:30 |
| *** hashar has quit IRC | 13:37 | |
| AJaeger | piotrowskim: your problem might have been a hickup and temporary | 13:38 |
| piotrowskim | it looks like, few hours ago I didnt have this problem | 13:39 |
| piotrowskim | however, is it better to clone or should I add it to list? | 13:39 |
| AJaeger | try it again ;) | 13:40 |
| *** ysandeep is now known as ysandeep|afk | 13:41 | |
| masterpe | I try to figer out how the nodepool works, I have set in the repo, in the job the nodeset to ubuntu-xenial | 13:44 |
| masterpe | I have a ansible playbook that writes a hello world to hosts: all | 13:44 |
| masterpe | and in the /etc/nodepool/nodepool.yaml config I have two static vm with the labels ubuntu-xenial | 13:45 |
| masterpe | But I don't see the "hello world" file on the two static files | 13:46 |
| *** harrymichal has quit IRC | 13:49 | |
| *** hashar has joined #zuul | 13:52 | |
| corvus | masterpe: have you set up log storage yet? | 13:53 |
| corvus | masterpe: (if you followed the quick-start, you should have a static logserver running apache; that should be sufficient) | 13:54 |
| corvus | masterpe: with that, you should be able to see the log for the job and find out why it didn't write the file | 13:54 |
| masterpe | I have followed the setup from scrash to set it up | 13:55 |
| masterpe | I also found https://gist.github.com/leifmadsen/93b9283d10dfddba096e32fb172cf569 with some logs. will this help do debug? | 13:56 |
| corvus | masterpe: unfortunately, the zuul from scratch document doesn't address log storage for jobs, it really only gets the basic system up and running. | 13:58 |
| corvus | masterpe: zuul has no internal log storage, so you need a place to put job build logs. that can either be a static server, or google cloud storage, or openstack swift. | 13:59 |
| corvus | masterpe: this part of the quick-start shows how to set up a base job that copies logs to a location on the zuul executor: https://zuul-ci.org/docs/zuul/tutorials/quick-start.html#configure-a-base-job | 14:01 |
| corvus | masterpe: these are the different log upload roles that are available: https://zuul-ci.org/docs/zuul-jobs/log-roles.html | 14:01 |
| corvus | masterpe: the logging configuration you linked to in the gist is about logging for the service. that's not as important for figuring out why the job didn't do what you expected. for that we need the build logs so we can see what ansible did. | 14:03 |
| masterpe | ah | 14:10 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Enhance ZK CA script and doku https://review.opendev.org/731475 | 14:11 |
| openstackgerrit | Merged zuul/zuul-jobs master: upload-artifactory: fix variable misspelling https://review.opendev.org/731535 | 14:15 |
| openstackgerrit | Jan Kubovy proposed zuul/zuul master: Enhance ZK CA script and doku https://review.opendev.org/731475 | 14:19 |
| openstackgerrit | Merged zuul/zuul-jobs master: ensure-bazel: replace ignore_errors with failed_when https://review.opendev.org/730733 | 14:21 |
| *** sgw has joined #zuul | 14:29 | |
| openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Add the namespace in wait-for-pods role https://review.opendev.org/731292 | 14:44 |
| openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Add namespace in the collect-k8s-logs role https://review.opendev.org/731319 | 14:44 |
| *** dennis_effa has joined #zuul | 14:56 | |
| *** hashar has quit IRC | 15:00 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul-jobs master: WIP: improve ensure-tox, ensure-twine, upload-pypi https://review.opendev.org/731784 | 15:01 |
| openstackgerrit | Oleksandr Kozachenko proposed zuul/zuul-jobs master: Add namespace in the collect-k8s-logs role https://review.opendev.org/731319 | 15:14 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul-jobs master: WIP: improve ensure-tox, ensure-twine, upload-pypi https://review.opendev.org/731784 | 15:16 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul-jobs master: WIP: improve ensure-tox, ensure-twine, upload-pypi https://review.opendev.org/731784 | 15:24 |
| *** jcapitao has quit IRC | 15:52 | |
| openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Make .sh browsable on swift logs https://review.opendev.org/731795 | 15:56 |
| zbr | any reason why we do have two copies of zuul_swift_upload.py in zuul-jobs? | 16:13 |
| zbr | can't we symlink library folders? | 16:13 |
| clarkb | the intent is to be able to have a distinct test role that can be included in some jobs without modifying all jobs | 16:14 |
| clarkb | whether or not there is a better way to accomplish that within the confines of ansible and zuul I don't know | 16:14 |
| zbr | or even better, move to a single(official) plugins/modules location for ansible modules? | 16:14 |
| *** dpawlik has quit IRC | 16:15 | |
| zbr | easiest fix would symlinks for start, and later single module location. | 16:15 |
| avass | clarkb: why do we have the test role in roles/ anyway? | 16:18 |
| avass | clarkb: is it imported in another project? | 16:18 |
| clarkb | avass: it enables us to test changes to swift uploads in production without modify all jobs | 16:19 |
| clarkb | avass: because log uploads affect everything, being able to test changes in a controlled manner against real clouds is important | 16:19 |
| corvus | when we want to make changes to the role (like the one zbr suggested above) we can apply it to the test role first, change base-test to use the test role, verify it works, then copy it to the prod role | 16:19 |
| avass | clarkb: ah so they're used in base vs base-test jobs in a config project? | 16:19 |
| clarkb | avass: ya | 16:19 |
| clarkb | there may be better ways to accomplish this, but that is why we've got it set up this way today | 16:20 |
| avass | zbr: I'm not sure how symlinks, or having modules outside the role would work with importing roles in a different project anyway. | 16:20 |
| avass | clarkb: yeah, the setup makes sense to me | 16:20 |
| *** rpittau is now known as rpittau|afk | 16:21 | |
| corvus | i also am not sure how i feel about intentionally setting the wrong mime type | 16:23 |
| corvus | maybe we can just change the dashboard to render it inline. | 16:24 |
| openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul-jobs master: Make .sh browsable on swift logs https://review.opendev.org/731795 | 16:25 |
| zbr | corvus: i know lots of people that deliberately avoid using the dashboard for browsing (not me) | 16:26 |
| zbr | and we already have the yaml there. | 16:26 |
| corvus | zbr: why? | 16:27 |
| zbr | i was told that they found it too slow | 16:27 |
| avass | corvus: looking around at: https://zuul.opendev.org/t/zuul/job/base I wonder if it would make sense for the dashboard to render the variables in the description somehow | 16:28 |
| fungi | for those people, the .sh file will probably download faster than copying it from their browser too | 16:29 |
| zbr | i found myself the need to use browser native rendering of the file in some cases, without extra magic. sometimes, you just want to modify a URL to point it to a known foo.sh file near your current foo.log for example. | 16:29 |
| fungi | also, they can set their browser to display .sh files instead of downloading them, if that's important to them | 16:30 |
| corvus | zbr: modifying the url does work | 16:30 |
| corvus | (that's required for the deep linking to work) | 16:31 |
| corvus | zbr: do you have a link to a build with a .sh file? | 16:31 |
| zbr | sure, any tripleo, build look at https://abc0488e063f5fa92dad-c4c8c9f72d027ee98f5da4950dd6b423.ssl.cf1.rackcdn.com/730763/8/check/tripleo-buildimage-overcloud-full-centos-8/c98e395/ | 16:32 |
| zbr | so far i never seen someone wanting to download the sh, afaik most likely use-case is looking at content in browser, just like plain text. | 16:34 |
| clarkb | fwiw I had to switch to raw logs to debug that issue we had the other day fungi. Except now I don't recall what the issue was | 16:34 |
| zbr | if they want to download, they can use curl or saves as. | 16:34 |
| corvus | every build has a shell script to download all the logs. when you click on that artifact link, you are (correctly) prompted to download the script. | 16:35 |
| zbr | i can understand that behavior for .json may be debatable (as they could easily crash a browser), but .sh files, are mostly like text | 16:35 |
| clarkb | fungi: the mirror build logs. We had a ton of log files uploaded which made the manifest very large and I think that made the dashboard unhappy | 16:36 |
| clarkb | (an exceptional case for sure) | 16:36 |
| corvus | i'm a little surprised that browsing shell scripts in log dirs is a common thing. i guess the shell scripts are automatically generated and people want to see the content that was created? | 16:37 |
| zbr | ideally the dashboard could load a single index.json and avoid being slow. we could pre-build it. | 16:37 |
| clarkb | zbr: that is what it does | 16:37 |
| corvus | zbr: that's exactly what the dashboard does | 16:37 |
| corvus | except it's called "zuul-manifest.json" | 16:37 |
| zbr | still, in some cases is feels quite slow. | 16:38 |
| zbr | any concerns of what we could break by forcing mime types? | 16:39 |
| corvus | zbr: got anything more specific or actionable than "in some cases is feels quite slow"? | 16:39 |
| zbr | nope | 16:40 |
| zbr | but I will try to ask them to give examples | 16:41 |
| corvus | zbr: that would be helpful | 16:41 |
| zbr | but for the .sh part I do not need explanations, i had the same issue. | 16:41 |
| zbr | the only case where I needed to download instead of browsing a file was our reproducer.sh file, something i did not use again 6+ months. | 16:42 |
| corvus | zbr: i raised 2 questions: 1) the download-logs.sh script currently appears as a convenient download link; this may change that. the other is the question i asked at 16:37, which goes to the issue of whether it's really more likely for a .sh script in a log dir to be "content" or "functionality" | 16:42 |
| zbr | even if that was aimed to be downloaded and run, i almost always wanted to run it from anther host, so browser download was not useful. | 16:43 |
| zbr | usually when I want to download something I use right click and not relying on browser to prompt me, but i cannot speak for others. | 16:44 |
| zbr | we could make a special casefor download-logs.sh maybe? (not sure a good idea) | 16:45 |
| *** weshay|ruck has joined #zuul | 16:45 | |
| corvus | if people think that most of the time we expect .sh files to be read in the browser rather than downloaded and executed, i'm okay with the change. but i think we need to get wider input on this, including ianw and non-openstack users. | 16:45 |
| weshay|ruck | missed most of the conv.. but that seems fair. | 16:46 |
| clarkb | if right click and save as didn't exist I'd be more concerned, but that seems like a good shortcut people will hvae in their browser? | 16:46 |
| corvus | zbr: maybe a quick note to zuul-discuss to take care of the latter | 16:46 |
| corvus | clarkb: yeah | 16:47 |
| zbr | yeah, why not, I can send an email on zuul-discuss to the propose change, and people can vote on the review directly | 16:47 |
| zbr | there is no urgent pressure to merge the change | 16:47 |
| zbr | based on the feedback we can decide what to do, maybe nobody complains,.... | 16:48 |
| corvus | this is one of those things that's going to change for everyone, so getting a diverse range of input is good | 16:48 |
| fungi | one way we've worked around it is to rename shell scripts by appending .txt on them prior to archiving | 16:48 |
| fungi | if they're really intended to be browsed as plain text files rather than downloaded and run | 16:49 |
| zbr | fungi: the rename was also used by us, but is ugly. | 16:49 |
| fungi | "ugly" is relative | 16:49 |
| fungi | all the solutions proposed so far are potentially ugly in some way | 16:49 |
| fungi | however the rename trick works now | 16:49 |
| corvus | arguably yes; the counter-argument is that it more correctly represents the intent of its presence in the log dir | 16:49 |
| weshay|ruck | agree.. renaming is fine.. my only hesitation.. is that I would think everything in the zuul job log is a log not a file system meant for download | 16:50 |
| weshay|ruck | but I don't have strong feelings about it | 16:50 |
| *** kmalloc has quit IRC | 16:50 | |
| weshay|ruck | re: what's ugly or not | 16:51 |
| weshay|ruck | anyhoo.. thanks zbr for raising it 0/ | 16:51 |
| corvus | weshay|ruck: there are some shell scripts in the log dir that are intended exclusively to be downloaded and executed (at least one in every job log dir) | 16:51 |
| corvus | eg https://abc0488e063f5fa92dad-c4c8c9f72d027ee98f5da4950dd6b423.ssl.cf1.rackcdn.com/730763/8/check/tripleo-buildimage-overcloud-full-centos-8/c98e395/download-logs.sh | 16:52 |
| corvus | so it's... not 100% clear cut either way and worth careful consideration :) | 16:52 |
| weshay|ruck | right... I've seen it.. just as easy to right click | 16:52 |
| weshay|ruck | agree.. re: careful consideration | 16:52 |
| avass | there's no easy way to display the contents of a single .sh file like downloading a file with right click and save right? | 16:59 |
| fungi | i looked at the options for firefox... long ago they gave up letting you add mime types or file types in the applications preferences, so you have to manually edit the file which stores those in your profile and add a new entry | 17:00 |
| *** jpena is now known as jpena|off | 17:01 | |
| fungi | however there are also some extensions to do things like view a specific mime type as if it were a different mime type | 17:01 |
| avass | yeah | 17:01 |
| avass | but what I mean is that if the .sh file is displayed instead of automatically downloaded the user can do both easily | 17:01 |
| fungi | yeah, that's true | 17:02 |
| corvus | yeah, it's arguably the better compromise position | 17:03 |
| zbr | done, sent email. | 17:06 |
| avass | zbr: can we wait with https://review.opendev.org/#/c/731591/1 ? I'll update the rule to ignore anything in test-playbooks | 17:15 |
| avass | zbr: since it's not valid in there | 17:15 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Do not lint loopvar in test-playbooks https://review.opendev.org/731814 | 17:24 |
| avass | wait, that breaks by tests :( | 17:25 |
| *** tumble has joined #zuul | 17:25 | |
| zbr | avass: why to bother to make rule more complex? code can easily move between tests and role itself, as some roles have validation included in them. | 17:28 |
| zbr | your rule is not "bad" when applied to tests, just less useful. you can also use a noqa for it. | 17:29 |
| avass | zbr: sure, but I don't like that it's linting for something that doesn't apply | 17:34 |
| zbr | avass: in fact the rule makes sense for code inside roles, but i am not sure you can distinguish between task inside a role vs task inside a playbook. | 17:36 |
| openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul master: Make task errors expandable https://review.opendev.org/723534 | 17:41 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Do not lint loopvar in test-playbooks https://review.opendev.org/731814 | 17:42 |
| avass | zbr: it makes sense for roles that are supposed to be imported somewhere else that zuul-jobs is not aware of | 17:43 |
| openstackgerrit | Albin Vass proposed zuul/zuul-jobs master: Do not lint loopvar in test-playbooks https://review.opendev.org/731814 | 17:51 |
| openstackgerrit | Sorin Sbarnea (zbr) proposed zuul/zuul master: WIP: Enable ANSI rendering on stdout/stderr https://review.opendev.org/716251 | 18:04 |
| *** fbo is now known as fbo|off | 18:19 | |
| *** dennis_effa has quit IRC | 18:34 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Import user tutorials from Software Factory project blog https://review.opendev.org/728193 | 18:34 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Add tutorial tests https://review.opendev.org/728194 | 18:34 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul master: Add tutorial tests https://review.opendev.org/728194 | 18:37 |
| *** harrymichal has joined #zuul | 18:44 | |
| *** Goneri has quit IRC | 19:42 | |
| *** mgoddard has quit IRC | 19:44 | |
| *** mgoddard has joined #zuul | 19:50 | |
| *** EvilienM is now known as EmilienM | 21:16 | |
| *** paladox has quit IRC | 21:27 | |
| *** paladox has joined #zuul | 21:29 | |
| *** harrymichal has quit IRC | 21:38 | |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul-jobs master: ensure-tox: fix tox_executable fact when tox is preinstalled https://review.opendev.org/731853 | 22:36 |
| openstackgerrit | Guillaume Chauvel proposed zuul/zuul-jobs master: ensure-twine: Update using same format as ensure-tox https://review.opendev.org/731854 | 22:36 |
| *** guillaumec has quit IRC | 22:59 | |
| *** armstrongs has joined #zuul | 23:37 | |
| *** tosky has quit IRC | 23:38 | |
| *** armstrongs has quit IRC | 23:46 | |
Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!