Friday, 2020-04-24

openstackgerritMerged zuul/zuul-jobs master: Fix the checking helm_values_file definition  https://review.opendev.org/72251600:40
*** swest has quit IRC01:09
ianwsigh, somehow the sibling container build now looks broken ... https://zuul.opendev.org/t/openstack/build/09f147450ed64da984d6f1e0a99def6c/log/job-output.txt#73601:19
ianwi'm thinking it has to do with 721514 but not sure how01:20
openstackgerritIan Wienand proposed zuul/nodepool master: Add nodepool as required project to siblings image build  https://review.opendev.org/72255601:24
*** swest has joined #zuul01:24
*** rlandy has quit IRC02:12
openstackgerritIan Wienand proposed zuul/zuul master: Add intermediate flag for jobs  https://review.opendev.org/72220002:52
*** bhavikdbavishi has joined #zuul03:02
*** bhavikdbavishi1 has joined #zuul03:24
*** bhavikdbavishi has quit IRC03:26
*** bhavikdbavishi1 is now known as bhavikdbavishi03:26
*** bhavikdbavishi has quit IRC04:09
*** ysandeep|away is now known as ysandeep04:10
*** bhavikdbavishi has joined #zuul04:22
*** evrardjp has quit IRC04:35
*** evrardjp has joined #zuul04:35
*** ysandeep is now known as ysandeep|brb04:58
*** ysandeep|brb is now known as ysandeep05:29
*** dpawlik has joined #zuul06:03
*** bhavikdbavishi has quit IRC06:27
*** yolanda has joined #zuul06:28
*** bhavikdbavishi has joined #zuul06:37
*** jcapitao has joined #zuul07:09
*** rpittau|afk is now known as rpittau07:17
*** jpena|off is now known as jpena07:20
*** tosky has joined #zuul07:33
*** bhavikdbavishi has quit IRC07:51
*** ysandeep is now known as ysandeep|lunch07:57
*** bhavikdbavishi has joined #zuul08:06
*** ysandeep|lunch is now known as ysandeep09:08
openstackgerritAlbin Vass proposed zuul/zuul master: WIP: Add commit id to Change for mqtt reporter  https://review.opendev.org/72247809:09
tobiashzuul-maint: looks like the line mapping might be off by one: https://review.opendev.org/#/c/722478/1/zuul/driver/mqtt/mqttreporter.py@4409:13
tobiashzuul-maint: never mind, the linter itself reported exactly this line, so it's correct09:15
openstackgerritFabien Boucher proposed zuul/zuul-jobs master: Remove hardcoded use of /home/zuul  https://review.opendev.org/72264909:33
openstackgerritAndy Ladjadj proposed zuul/zuul master: convert utc format to local timezone with format YYYY-MM-DD HH:mm:ss  https://review.opendev.org/72265309:59
openstackgerritAndy Ladjadj proposed zuul/zuul master: [web] convert utc format to local timezone with format YYYY-MM-DD HH:mm:ss  https://review.opendev.org/72265309:59
openstackgerritAndy Ladjadj proposed zuul/zuul master: [web] convert utc format to local timezone with format YYYY-MM-DD HH:mm:ss  https://review.opendev.org/72265310:02
openstackgerritAndy Ladjadj proposed zuul/zuul master: [web] convert utc format to local timezone with format YYYY-MM-DD HH:mm:ss  https://review.opendev.org/72265310:05
*** yoctozepto has quit IRC10:09
*** rpittau is now known as rpittau|bbl10:12
tobias-urdinin a non-modified centos 8 cloud image neither py2 or py3 is installed by default, is there any way to run ansible tasks before zuul launches the ansible "setup" part (i.e runAnsibleSetup method)? doesn't look like it10:16
tobias-urdinmeaning i need to have a customized image with preinstalled python, i cannot inject a ansible "raw" task somewhere10:16
tobiashtobias-urdin: that's correct atm10:19
tobiashfor this use case it would be needed to skip the setup part in zuul10:20
tobias-urdinthere is no way to skip setup as of now?10:20
tobiashtobias-urdin: no, someone would need to implement this10:21
tobias-urdinthanks, then i'll work around the problem for now :)10:21
tobiashI guess it would be a 'skip-ansible-setup' flag on the job10:21
*** bhavikdbavishi has quit IRC10:23
openstackgerritAndy Ladjadj proposed zuul/zuul master: [web] convert utc format to local timezone with format YYYY-MM-DD HH:mm:ss  https://review.opendev.org/72265310:44
*** jcapitao is now known as jcapitao_lunch10:59
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179611:18
reiterativeI'm trying to run up Zuul Quickstart for local testing, but version on master fails in executor with a FileNotFoundError for /var/run/zuul/executor.pid11:25
reiterativeHas anyone else had problems running quickstart? I'm running Debian stretch.11:26
openstackgerritPaul Albertella proposed zuul/zuul-jobs master: Add Bazel build and ensure roles  https://review.opendev.org/69351311:27
*** jpena is now known as jpena|lunch11:28
*** sassyn has quit IRC11:34
*** bhavikdbavishi has joined #zuul11:36
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179611:41
avassI don't really like that the tox roles default to using venv as a target test environment11:45
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179611:53
*** sgw has quit IRC12:08
*** rpittau|bbl is now known as rpittau12:13
*** jcapitao_lunch is now known as jcapitao12:20
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179612:27
openstackgerritPaul Albertella proposed zuul/zuul-jobs master: Add Bazel build and ensure roles  https://review.opendev.org/69351312:31
*** rlandy has joined #zuul12:31
*** rlandy is now known as rlandy|mtg12:35
*** jpena|lunch is now known as jpena12:38
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179612:42
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179612:48
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179612:53
*** Goneri has joined #zuul13:08
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: cabal-test: add initial haskell job  https://review.opendev.org/72173513:12
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: hlint: add haskell source code suggestions job  https://review.opendev.org/72230913:12
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179613:24
*** rlandy|mtg is now known as rlandy13:34
*** ysandeep is now known as ysandeep|afk13:50
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Support multi-arch image builds with docker buildx  https://review.opendev.org/72233913:51
corvusreiterative: the quickstart runs in docker, so the host os shouldn't matter (much).  and we run that on every change to zuul, so it should be very well tested.  you're following these instructions?  https://zuul-ci.org/docs/zuul/tutorials/quick-start.html13:55
*** bhavikdbavishi has quit IRC13:56
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179613:58
fungiavass: can you elaborate on the problem you're having with venv in the tox roles? what would you prefer?14:02
fungii'm confused by your comment about "target test environment" since tox generally uses virtualenv not venv (though the latest releases of virtualenv are supposed to be almost identical to stdlib venv environments)14:03
fungithere is a tox-venv plugin which will tell tox to use stdlib venv instead of virtualenv, but i didn't think we were installing that in the role14:04
corvusfungi: i think he means the "tox environment" named "venv"; see https://review.opendev.org/72179614:04
fungiohhh14:04
avassfungi, corvus: yeah, instead of checking if the variable is undefined I have to set it to an empty string and check if tox_envlist is empty14:05
fungii see, the problem is that the tox_envlist rolevar has a default of "venv" so launches the [testenv:venv] defined in the tox.ini if you don't pass any tox_envlist value14:06
avassyeah14:06
fungimakes sense, i agree that's probably an old openstackism leaking into our defaults14:07
avassit's a bit counter intuitive that the tox job runs venv by default instead of working the same way as if you would run 'tox' on the commandline14:07
fungifor openstack jobs since ages we used a fallback generic testenv:venv to run arbitrary commands in a virtualenv14:07
avassfungi: that's what I was guessing, so I don't want to break it :)14:08
fungiand i agree, that's somewhat inflexible and a questionable default choice14:08
openstackgerritMerged zuul/nodepool master: Add nodepool as required project to siblings image build  https://review.opendev.org/72255614:13
avassand checking for an empty string is hard for some reason.. :(14:18
avassI really don't understand why that fails14:22
*** zxiiro has joined #zuul14:31
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179614:34
openstackgerritMerged zuul/zuul-jobs master: Remove hardcoded use of /home/zuul  https://review.opendev.org/72264914:34
openstackgerritMerged zuul/zuul-jobs master: cabal-test: add initial haskell job  https://review.opendev.org/72173514:35
*** sgw has joined #zuul14:43
*** wxy has quit IRC14:45
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179614:46
*** harrymichal has joined #zuul14:47
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Support multi-arch image builds with docker buildx  https://review.opendev.org/72233914:48
openstackgerritMonty Taylor proposed zuul/zuul-jobs master: Support multi-arch image builds with docker buildx  https://review.opendev.org/72233914:50
openstackgerritMerged zuul/zuul-operator master: Increase scheduler wait timeout and improve logs collection  https://review.opendev.org/71816214:51
openstackgerritMerged zuul/zuul-operator master: Add schema validation error message  https://review.opendev.org/71899914:51
reiterativecorvus Yes, I'm following the instructions and had it working with an older iteration. Just pruned my Docker containers and cloned a fresh copy to make sure - same problem.14:52
reiterativeHere's the log output: http://paste.openstack.org/show/792670/14:52
openstackgerritMerged zuul/zuul-operator master: Add a zuul-ensure-database-passwords role  https://review.opendev.org/71788014:54
corvusreiterative: do you have any modifications to the docker-compose file?  bind-mounting any extra volumes in, or user id settings?14:56
tristanCcorvus: reiterative: shouldn't the container entrypoint be using `-f` command line argument, resulting in the run file to *not* be created?14:56
corvustristanC: i believe that is correct -- it should use "-f" and according to the code, that should bypass the lockfile14:58
avasscorvus, tristanC, reiterative: I get the same error running docker-compose up -d14:58
avasson ubuntu-bionic14:58
tristanCcorvus: hmm, looking at the zuul.cmd.ZuulDaemonApp class, the main function seems to use pid_file_module.TimeoutPIDLockFile before the nodaemon check15:00
corvustristanC: but that shouldn't aquire it, and reiterative's traceback included the context manager15:00
openstackgerritMerged zuul/zuul-operator master: Add zuul-registry deployment  https://review.opendev.org/71065015:01
corvusi have run 'docker-compose down -v' and am running 'docker-compose pull' now.15:02
reiterativetristanC Interesting. When I first tried running the latest version, I got a different error stating that -f was not a valid option for zuul-scheduler...15:03
reiterativeI wonder if there are some old Docker containers hanging around on my system to confuse things?15:04
corvusreiterative: you can run 'docker-compose pull' to update them all15:05
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179615:05
reiterativecorvus Just trying that now (I'm still quite new to Docker)15:06
*** dpawlik has quit IRC15:10
corvusreiterative: i can't reproduce with the following steps: update to latest zuul checkout (to get the latest docker-compose file) -- sha should be ccddc37fa04dc66ab29b9bc97cc63b0665e64430;  then 'docker-compose down -v' (to remove old containers and volumes); 'docker-compose pull' to pull updated images; then 'docker-compose up -d'15:11
corvusavass: ^15:11
corvusso maybe try that process to make sure everything is in sync15:11
avasscorvus: it worked for me after pulling to make sure I had the latest containers15:11
avassmust have had something old on this machine15:11
avass*images15:12
reiterativecorvus tristanC avass Thanks very much for your help - that all seems to be working now!15:16
mordred*phew*15:23
avassam I missing something stupid here or is this behaving strange? https://review.opendev.org/#/c/721796/1315:26
avassI really can't figure out why it behaves like that15:26
corvusavass: i'm guessing you need something like != ""  /15:34
corvus?15:34
avasscoruvs: I believe I tried that earlier, but got an error with something like "should not compare to an empty string"15:37
avasscoruvs: "if tox_envlist" should return false for tox_envlist = "" as well15:38
avasscorvus: let's see what happens anyway15:39
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179615:40
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179615:41
*** harrymichal has quit IRC15:42
corvusavass: for these things, sometimes i'll set up a simple playbook for testing, just using "vars:" and "debug" tasks15:42
avasscorvus: I should probably do that, was messing around with a jinja2 parser but I guess the versions don't match or something15:44
*** jcapitao has quit IRC15:47
corvusavass: something like http://paste.openstack.org/show/792675/15:48
corvusthat repros the error, and this seems to work?  when: tox_envlist != ''15:48
avasscorvus: yep, just tried that and it works15:48
*** ysandeep|afk is now known as ysandeep|away15:49
avasswhat ansible version were you using?15:49
avasscorvus: I'm confused to why the first debug works and the second one doesn't: http://paste.openstack.org/show/792678/15:55
corvusavass: 2.8.815:55
corvusavass: maybe the second form it just tries to evaluate the substitution, where as in the first form it implicitly treats it as a boolean?15:56
avasscorvus: aah, yeah that could be it15:57
avasscorvus: also seing a deprecation warning for that15:57
avasscorvus: ah yeah, I'm getting a linting error for comparing to an empty string, guess I'll just disable that16:04
corvusavass: could you just use the "when: tox_envlist is defined and tox_envlist" form?16:05
avasscorvus: I could, the list form feels easier to read, but that could just be me16:07
corvusavass: i agree, but it seems better than a lint ignore :)16:07
avasscorvus: tried using the recommended |bool filter but I ended up with a wrong 'false' value instead: https://github.com/ansible/ansible/issues/2589316:09
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179616:10
avasslet's if this works16:10
*** harrymichal has joined #zuul16:10
*** bhavikdbavishi has joined #zuul16:14
avassI like how the solution is to use "some_var|default(False, boolean=True)|bool" instead of comparing to an empty string because that's evil for some reason16:14
*** bhavikdbavishi1 has joined #zuul16:17
*** bhavikdbavishi has quit IRC16:18
*** bhavikdbavishi1 is now known as bhavikdbavishi16:18
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: tox: allow running default envlist in tox  https://review.opendev.org/72179616:23
avasscorvus: that format also didn't work :)16:30
avasscorvus: it doesn't error but it seems like it evaluates to false instead16:31
avasscorvus: wait, nevermind I was looking at an old report16:33
*** evrardjp has quit IRC16:35
*** evrardjp has joined #zuul16:35
*** rpittau is now known as rpittau|afk16:41
*** harrymichal has quit IRC16:42
*** harrymichal has joined #zuul16:43
*** jpena is now known as jpena|off16:48
avasscorvus: looks like it works, thanks!17:03
*** bhavikdbavishi has quit IRC17:09
*** rlandy is now known as rlandy|brb17:14
*** logan- has quit IRC17:30
*** logan- has joined #zuul17:42
*** mhu has quit IRC18:05
*** tjgresha__ has quit IRC18:06
openstackgerritJames E. Blair proposed zuul/zuul master: Add serial pipeline manager  https://review.opendev.org/72298118:10
openstackgerritJames E. Blair proposed zuul/zuul master: Make fake test Gerrit merger more realistic  https://review.opendev.org/72298218:10
corvusmordred: ^ i think maybe that's the way to go.18:10
*** yolanda has quit IRC18:11
corvusi expect the first change to pass tests, and i think it's an adequate simulation with the caveats.  the second change is a follup which is going to affect almost every unit test, so i have no idea if it's feasible.18:11
corvusi consider it an optional improvement18:11
*** rlandy|brb is now known as rlandy18:12
corvustristanC, tobiash: ^ feedback on a new serial pipeline manager feature welcome18:19
tristanCcorvus: nice, i'll have a look shortly18:21
mordredcorvus: "one queue per project"18:35
mordredcorvus: how does that interact with jobs triggered by both opendev/system-config and openstack/project-config18:36
tristanCcorvus: at a first look serial looks like a combinaison of check/gate/promote18:39
avassmordred: can't you still configure multiple projects to share a queue for a pipelie? I would expect that to be the default behaviour18:44
avassmordred: oh, maybe that's specific to the dependent pipeline18:45
mordredavass: it's specific to this new pipeline manager proposal18:53
corvusmordred: that's a very good question -- but for that specific example, opendev/system-config and openstack/project-config are going to be in different tenants.  but we could address the issue for opendev/system-config and opendev/project-config, which will be in the same tenant.18:55
corvusmordred: in that case, maybe we need a queue attachment like dependent18:55
avassmordred: yeah, had to look up how that works18:56
mordredcorvus: yeah - opendev/system-config and opendev/project-config is definitely the issue18:56
corvusif we do that, we need to base the work on https://review.opendev.org/72018218:56
dmsimardmordred: o/ re: https://opendev.org/zuul/zuul/src/branch/master/zuul/executor/server.py#L2019-L202718:56
corvusmordred: or, if not base, at least make sure it's forward-compatible with that18:56
dmsimardin avass' https://review.opendev.org/#/c/717260/, I thought we could take that opportunity to make it generic18:57
dmsimardbut it's for configuring callback_plugins vs callback_whitelist18:58
mordredcorvus: yeah.18:58
dmsimardcan an operator set custom ansible action plugin and library paths ? it should work the same18:59
corvusdmsimard: zuul executors maintain their own virtualenvs for each ansible version, and i think any callback needs to be installed in those19:00
corvusso i think we can handle this by...19:00
avasscorvus: right19:01
corvusdmsimard, avass: making this generic: https://opendev.org/zuul/zuul/src/branch/master/zuul/lib/ansible.py#L24019:01
corvusso the process becomes: 1) tell zuul-manage-ansible to install the callback plugin; 2) add a new config option that says to add the path for these additional callbacks plugins.19:02
corvusfor example for ara:19:03
corvus1) ANSIBLE_EXTRA_PACKAGES=ara zuul-manage-ansible19:03
corvus2) ansible_extra_callback_modules=ara19:03
corvusis that enough to get us to running "python -m ara.setup.callback_plugins" to get the path?19:04
avasscorvus: seems like we could make the 'ara.setup.callback_plugins' configurable19:04
corvusand does that work for any module?19:04
corvusor is that ara-specific?19:04
avasscorvus: I'll have to do some research on that :)19:05
dmsimardara.setup.callback_plugins is a shortcut to printing the path where ara's callback_plugins directory is19:05
dmsimardbecause it can change depending on where it's installed and hard coding is meh19:05
corvusright -- that's what we need to do to make this generic for any plugin19:05
corvusto put this another way: it's not possible for the user to actually specify the path to the callback plugins.  so we need a way to automate the executor finding out the right callback_plugins path for any plugin the user names19:06
avasscorvus: how about we add an ansible_extra_packages in zuul.conf, that way pywinrm can be installed as well19:06
corvusavass: that feature already exists, but it's an env variable: https://zuul-ci.org/docs/zuul/howtos/installation.html#ansible19:07
avasscorvus: guess I missed that19:08
corvusalso, does collections help out?  (ie, does it standardize anything about callback plugin installation paths?)19:08
corvusmordred: ^?19:08
corvussorry, i have to grab lunch now, biab.19:09
avasscorvus: thanks, have to make a quick update to our scripts then :)19:09
dmsimardcollections might be helpful because they are installed in a standardized location19:10
fungiat least once collections get standardized ;)19:10
dmsimardeh :D19:10
* dmsimard looks at docs19:11
dmsimardhttps://docs.ansible.com/ansible/latest/reference_appendices/config.html#collections-paths19:11
mordredcorvus: yes19:11
dmsimardso the callback could ship inside a collection and have a common path (regardless of the path of the python interpreter)19:11
dmsimardbut collections do not solve the problem of python dependencies that might be required19:11
mordrednope19:12
mordredbut - my understanding is that you can refer to plugins by module path rather than fs path19:12
mordredso once you install a collection, the config file could have callback_plugin = ara.collection.callback_plugin19:12
dmsimardoh yeah ?19:12
dmsimardthat could be convenient19:13
mordredhowever - I'm not sure there's a good story for per-ansible-installation collection installs - as much as there is a "install the collection on the system"19:13
mordredso we still might have things to figure out19:13
dmsimardit'd be inside the bubblewrap ?19:14
dmsimardI mean, with other prepared roles and stuff19:14
mordredyeah - we'll have to put it inside the bubblewrap - but if we do that we might have to invent a place to install/stage per-ansible install collections so we can bind-mount them into bubblewrap into the right location :)19:14
tristanCcorvus: left a comment/question on the serial pipeline, it lgtm19:15
avassmordred: couldn't you just configure different collections_paths for each ansible installation?19:20
mordredavass: oh - duh19:20
mordredyes19:20
avass:)19:20
* mordred goes back to staring blankly at the wall19:20
*** harrymichal has quit IRC19:26
*** harrymichal has joined #zuul19:26
fungiit's almost like staring blankly at source code19:29
avassI get stuck doing that a bit too often19:29
avassI'll be back in a bit, gotta make some falafel :)19:38
*** mgagne has joined #zuul19:49
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: hlint: add haskell source code suggestions job  https://review.opendev.org/72230919:52
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: hlint: add haskell source code suggestions job  https://review.opendev.org/72230919:58
*** toabctl has quit IRC20:00
corvusmordred, dmsimard, avass: so maybe the "make the ara install generic for all third-party callback plugins" step should be based on collections?20:02
corvusthat way we don't have to figure out anything for the current system20:03
tristanCnot sure what is going on with https://review.opendev.org/722309 , it says `Patch in Merge Conflict` but it is on master without git or depends-on related change. Are opendev merger healthy?20:12
tristanCsorry for the noise, this is already discussed in #opendev :)20:15
-openstackstatus- NOTICE: The Zuul project gating service is reporting new patches in merge conflict erroneously due to a configuration error, fix in progress20:22
avasscorvus: sounds reasonable, I guess we could make it like ANSIBLE_EXTRA_PACKAGES and enable configuring ansible-galaxy servers20:23
*** michael-beaver has joined #zuul20:59
*** rf0lc0 has quit IRC21:36
*** cdearborn has joined #zuul21:39
*** rlandy has quit IRC22:48
*** rf0lc0 has joined #zuul22:55
-openstackstatus- NOTICE: the This Zuul outage was taken as an opportunity to perform an impromptu maintenance for changing our service deployment model; any merge failures received from Zuul between 19:40 and 20:20 UTC were likely in error and those changes should be rechecked; any patches uploaded between 20:55 and 22:45 UTC were missed entirely by Zuul and should also be rechecked to get fresh test results22:59
*** harrymichal has quit IRC23:13
*** harrymichal has joined #zuul23:13
*** tosky has quit IRC23:14
*** rf0lc0 has quit IRC23:30
*** harrymichal has quit IRC23:31

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!