| *** mattw4 has quit IRC | 00:00 | |
| *** Defolos has quit IRC | 00:23 | |
| *** erbarr has quit IRC | 00:49 | |
| *** zxiiro has quit IRC | 01:18 | |
| *** jamesmcarthur has joined #zuul | 01:18 | |
| *** igordc has quit IRC | 01:18 | |
| *** tosky has quit IRC | 01:39 | |
| *** jamesmcarthur has quit IRC | 01:41 | |
| *** jamesmcarthur has joined #zuul | 01:42 | |
| *** jamesmcarthur has quit IRC | 01:47 | |
| *** jamesmcarthur has joined #zuul | 02:12 | |
| *** Goneri has quit IRC | 02:18 | |
| *** swest has quit IRC | 02:20 | |
| *** jamesmcarthur has quit IRC | 02:21 | |
| *** jamesmcarthur has joined #zuul | 02:21 | |
| *** jamesmcarthur has quit IRC | 02:24 | |
| *** igordc has joined #zuul | 02:25 | |
| *** jamesmcarthur has joined #zuul | 02:26 | |
| *** jamesmcarthur has quit IRC | 02:32 | |
| *** swest has joined #zuul | 02:35 | |
| *** jamesmcarthur has joined #zuul | 02:54 | |
| *** bhavikdbavishi has joined #zuul | 03:18 | |
| *** zxiiro has joined #zuul | 03:20 | |
| *** jamesmcarthur has quit IRC | 03:50 | |
| *** jamesmcarthur has joined #zuul | 03:51 | |
| *** rlandy has quit IRC | 03:56 | |
| *** jamesmcarthur has quit IRC | 03:56 | |
| *** michael-beaver has quit IRC | 04:11 | |
| *** jamesmcarthur has joined #zuul | 04:21 | |
| *** hashar has joined #zuul | 04:23 | |
| *** jamesmcarthur has quit IRC | 04:26 | |
| *** decimuscorvinus_ has quit IRC | 04:59 | |
| *** decimuscorvinus has joined #zuul | 04:59 | |
| *** saneax has joined #zuul | 05:08 | |
| *** jamesmcarthur has joined #zuul | 05:22 | |
| *** raukadah is now known as chandankumar | 05:24 | |
| *** jamesmcarthur has quit IRC | 05:26 | |
| *** evrardjp has quit IRC | 05:35 | |
| *** evrardjp has joined #zuul | 05:35 | |
| *** jamesmcarthur has joined #zuul | 05:53 | |
| *** jamesmcarthur has quit IRC | 05:58 | |
| *** hashar has quit IRC | 06:40 | |
| *** igordc has quit IRC | 06:41 | |
| *** jamesmcarthur has joined #zuul | 06:54 | |
| *** jamesmcarthur has quit IRC | 06:59 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Allow check runs to be configured as required status in pipeline config https://review.opendev.org/711241 | 07:17 |
|---|---|---|
| *** armstrongs has joined #zuul | 07:23 | |
| *** armstrongs has quit IRC | 07:27 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Make github file annotation levels configurable via zuul return https://review.opendev.org/711179 | 07:28 |
| *** jamesmcarthur has joined #zuul | 07:28 | |
| *** jamesmcarthur has quit IRC | 07:33 | |
| *** jcapitao_off has joined #zuul | 07:46 | |
| *** Defolos has joined #zuul | 07:52 | |
| *** jamesmcarthur has joined #zuul | 07:53 | |
| *** hashar has joined #zuul | 07:55 | |
| *** jcapitao_off is now known as jcapitao | 07:55 | |
| *** sshnaidm_ has joined #zuul | 07:57 | |
| *** sshnaidm|afk has quit IRC | 07:58 | |
| *** jamesmcarthur has quit IRC | 07:58 | |
| *** jamesmcarthur has joined #zuul | 08:29 | |
| *** jamesmcarthur has quit IRC | 08:35 | |
| *** tosky has joined #zuul | 08:40 | |
| *** avass has joined #zuul | 08:42 | |
| *** jpena|off is now known as jpena | 08:47 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Report canceled changes via Github checks API https://review.opendev.org/711023 | 08:49 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Provide some documentation for the checks API implementation https://review.opendev.org/711493 | 09:05 |
| openstackgerrit | Antoine Musso proposed zuul/zuul master: Enhance some logging messages https://review.opendev.org/704331 | 09:07 |
| *** tflink has quit IRC | 09:07 | |
| *** tflink has joined #zuul | 09:07 | |
| *** avass has quit IRC | 09:08 | |
| *** danpawlik has joined #zuul | 09:09 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Provide some documentation for the checks API implementation https://review.opendev.org/711493 | 09:12 |
| *** zxiiro has quit IRC | 09:25 | |
| *** yolanda has quit IRC | 09:29 | |
| *** jamesmcarthur has joined #zuul | 09:31 | |
| *** yolanda has joined #zuul | 09:33 | |
| *** jamesmcarthur has quit IRC | 09:35 | |
| *** jamesmcarthur has joined #zuul | 11:11 | |
| *** sshnaidm_ is now known as sshnaidm|afk | 11:13 | |
| *** jamesmcarthur has quit IRC | 11:16 | |
| *** harrymichal has joined #zuul | 11:30 | |
| *** jcapitao is now known as jcapitao_lunch | 11:35 | |
| *** hashar has quit IRC | 11:38 | |
| *** jamesmcarthur has joined #zuul | 11:43 | |
| *** jamesmcarthur has quit IRC | 11:48 | |
| *** irclogbot_2 has quit IRC | 12:05 | |
| *** amotoki has quit IRC | 12:05 | |
| *** jlk has quit IRC | 12:06 | |
| *** amotoki has joined #zuul | 12:09 | |
| *** irclogbot_3 has joined #zuul | 12:09 | |
| *** jpena is now known as jpena|lunch | 12:37 | |
| *** jamesmcarthur has joined #zuul | 12:45 | |
| *** hashar has joined #zuul | 12:46 | |
| *** jamesmcarthur has quit IRC | 12:49 | |
| *** rlandy has joined #zuul | 12:55 | |
| *** jcapitao_lunch is now known as jcapitao | 13:03 | |
| *** jamesmcarthur has joined #zuul | 13:16 | |
| *** sgw has quit IRC | 13:20 | |
| *** jamesmcarthur has quit IRC | 13:23 | |
| *** jamesmcarthur_ has joined #zuul | 13:23 | |
| tristanC | corvus: Shrews: while refactoring the zk auth code a bit to get a better interface, i found some code inconsistencies, which makes me wonder how this work at all... let me explain, kazoo client connect auth_data argument needs to be a list of (scheme, cred) tuple, like so: https://review.opendev.org/#/c/619155/32/nodepool/zk.py@968 or https://review.opendev.org/#/c/619155/32/nodepool/tests/__init__.py@78 | 13:26 |
| tristanC | which match with the current kazoo client code here: https://github.com/python-zk/kazoo/blob/2.6.1/kazoo/client.py#L308 | 13:27 |
| tristanC | arg, nevermind, i thought we were not using a list of tuple in some places, but that's ok because nodepool.zk takes care of the transformation. sorry for the noise | 13:30 |
| *** jpena|lunch is now known as jpena | 13:33 | |
| *** avass has joined #zuul | 13:40 | |
| *** jamesmcarthur_ has quit IRC | 13:49 | |
| *** zenkuro has quit IRC | 13:56 | |
| mordred | tristanC: my favorite way of debugging - explaining the bug to someone else until you realize it isn't a bug | 14:18 |
| fungi | commonly known as "rubber duck debugging" | 14:26 |
| *** sreejithp has joined #zuul | 15:11 | |
| *** avass has quit IRC | 15:33 | |
| *** Goneri has joined #zuul | 15:33 | |
| *** Goneri has quit IRC | 15:38 | |
| *** jcapitao is now known as jcapitao_afk | 15:50 | |
| *** hashar has quit IRC | 15:55 | |
| *** mattw4 has joined #zuul | 16:12 | |
| tobiash | corvus, mordred: shall we merge 578557? (match tag items against containing branches) it has now +2 from both of you and myself (and we're running this in prod since 1.5 years) | 16:13 |
| clarkb | tobiash: I just volunteered to look at it if you want to wait just a few minutes longer | 16:15 |
| clarkb | slow start this morning but happy to review it soon | 16:15 |
| tobiash | k | 16:15 |
| *** jcapitao_afk is now known as jcapitao | 16:16 | |
| *** jamesmcarthur has joined #zuul | 16:19 | |
| corvus | tobiash, clarkb, mordred: i actually just started looking into that again, give me a bit more time as well | 16:23 |
| tobiash | k | 16:25 |
| *** chandankumar is now known as raukadah | 16:38 | |
| clarkb | rgr | 16:39 |
| *** danpawlik has quit IRC | 16:41 | |
| openstackgerrit | Merged zuul/zuul master: Support pausing merge jobs https://review.opendev.org/707192 | 16:48 |
| *** harrymichal has quit IRC | 16:54 | |
| *** harrymichal_ has joined #zuul | 16:54 | |
| openstackgerrit | Merged zuul/zuul master: Test that retries don't trigger fail-fast https://review.opendev.org/704983 | 16:54 |
| *** harrymichal_ is now known as harrymichal | 16:54 | |
| clarkb | corvus: I +2'd but did leave several comments that may be worthy of followups | 17:00 |
| corvus | clarkb: ack, thx | 17:01 |
| *** jamesmcarthur has quit IRC | 17:05 | |
| *** hashar has joined #zuul | 17:06 | |
| *** Defolos has quit IRC | 17:07 | |
| openstackgerrit | Merged zuul/zuul master: Don't reset file list to None in updateChange https://review.opendev.org/704328 | 17:20 |
| openstackgerrit | Merged zuul/zuul master: Protect prime_installation_map with mutex https://review.opendev.org/704932 | 17:20 |
| *** dtroyer has quit IRC | 17:33 | |
| *** evrardjp has quit IRC | 17:35 | |
| *** evrardjp has joined #zuul | 17:35 | |
| *** harrymichal_ has joined #zuul | 17:36 | |
| *** jlk has joined #zuul | 17:36 | |
| *** harrymichal has quit IRC | 17:37 | |
| *** harrymichal_ is now known as harrymichal | 17:37 | |
| *** harrymichal has quit IRC | 17:47 | |
| openstackgerrit | Merged zuul/zuul master: Centralize merge handling https://review.opendev.org/707692 | 17:56 |
| *** jpena is now known as jpena|off | 17:57 | |
| *** bhavikdbavishi has quit IRC | 17:59 | |
| openstackgerrit | Merged zuul/zuul master: Uncap GitPython https://review.opendev.org/708593 | 18:03 |
| openstackgerrit | Merged zuul/zuul master: Log duration of tenant reconfigurations https://review.opendev.org/708403 | 18:04 |
| openstackgerrit | Merged zuul/zuul master: Reduce gearman logging in tests https://review.opendev.org/707587 | 18:04 |
| openstackgerrit | Merged zuul/zuul master: Increase timeout in timeout test https://review.opendev.org/710146 | 18:04 |
| openstackgerrit | Merged zuul/zuul master: web ui: fix buildset display when no builds https://review.opendev.org/710508 | 18:04 |
| openstackgerrit | Merged zuul/zuul master: Optimize canMerge using graphql https://review.opendev.org/709836 | 18:08 |
| *** jcapitao has quit IRC | 18:10 | |
| openstackgerrit | Merged zuul/zuul master: Increase zookeeper timeout during tests https://review.opendev.org/707945 | 18:12 |
| openstackgerrit | Merged zuul/zuul master: Authorization rules: add templating https://review.opendev.org/705193 | 18:12 |
| *** rlandy is now known as rlandy|brb | 18:13 | |
| *** dtroyer has joined #zuul | 18:14 | |
| *** saneax has quit IRC | 18:15 | |
| *** igordc has joined #zuul | 18:20 | |
| *** igordc has quit IRC | 18:20 | |
| *** gmann is now known as gmann_lunch | 18:27 | |
| *** gmann_lunch is now known as gmann | 18:32 | |
| *** hashar has quit IRC | 18:33 | |
| *** rlandy|brb is now known as rlandy | 18:33 | |
| openstackgerrit | Merged zuul/zuul master: Add reference pipelines file for Github driver https://review.opendev.org/672712 | 18:40 |
| *** jamesmcarthur has joined #zuul | 18:41 | |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Add a test for retroactive branch tag application https://review.opendev.org/711741 | 18:57 |
| corvus | mordred, clarkb, tobiash: i replied (extensively) to the tags-on-branches change and wrote a followup patch with a test case showing the behavior that Niklas was asking about | 18:59 |
| corvus | i believe the original patch is now in merge conflict; i'm going to take a break and work on rebasing it, probably will have something after lunch. | 19:00 |
| *** Defolos has joined #zuul | 19:00 | |
| tobiash | corvus: wow, great answer | 19:04 |
| openstackgerrit | Merged zuul/zuul master: Improve error reporting when pr merge fails https://review.opendev.org/707637 | 19:12 |
| *** erbarr has joined #zuul | 19:15 | |
| *** jamesmcarthur has quit IRC | 19:24 | |
| mordred | corvus: have I mentioned I really wish there was a magical way to have speculative tags that can be gated? | 19:27 |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: Implement zookeeper-auth https://review.opendev.org/619155 | 19:28 |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: Add mypy to linter test https://review.opendev.org/711750 | 19:28 |
| Shrews | tristanC: that release note still references zookeeper-update-zk-auth :( | 19:33 |
| tristanC | corvus: clarkb: in ^ PS33 i suggest we only support a login/password digest sasl scheme, let me know if that's ok for you | 19:34 |
| tristanC | Shrews: arg oops, it's half fixed then :) I'll update after ci results | 19:35 |
| tristanC | in the meantime, perhaps we should consider a common tool for both zuul and nodepool? | 19:35 |
| Shrews | tristanC: i *think* it's true that zuul is aware of all znodes nodepool creates, but the reverse is not true. So maybe it could just be moved to zuul/zuul? | 19:36 |
| tristanC | what do you think about a creating a kazoo wrapper library to share the zk module between zuul and nodepool. then we could have a generic update-zk-auth script provided by that new library? | 19:36 |
| tristanC | for example, a new zuul/zklib project | 19:37 |
| Shrews | i proposed that at the beginning of the v3 work | 19:37 |
| tristanC | such project does rings a bell :) | 19:38 |
| tristanC | or, as you suggested, let's drop the script from nodepool and let's implement it as part of the zuul change? | 19:38 |
| Shrews | i think just moving it to zuul is best at this point | 19:38 |
| Shrews | rather than a major code extraction :) | 19:39 |
| openstackgerrit | Merged zuul/zuul master: Add load-branch to tenant configuration https://review.opendev.org/705664 | 19:41 |
| corvus | tristanC: i think supporting sasl only is okay, but we should support both kerberos or digest with sasl. | 19:41 |
| tristanC | Shrews: well, i think that's a worthy operation, and I think i can work on the implementation | 19:42 |
| corvus | tristanC: (that should be pretty easy, the acl is the same in both cases, the only difference is the credential passed to auth info) | 19:42 |
| tristanC | corvus: i linked an upcoming change in kazoo about kerberos | 19:44 |
| tristanC | which should be easy to support in the new zk_auth module i proposed. but we would need an extra toggle in the user configuration | 19:44 |
| tristanC | e.g. (scheme: sasl-digest, username: text, password: text) and (scheme: sasl-gssapi, service: text, principal: text) | 19:45 |
| Shrews | tristanC: oh, i suppose there are znodes created by nodepool that zuul doesn't know about (e.g., image builds). That being said, I think just having that script in a single place is fine (either nodepool or zuul), but it needs to consider znodes from both. | 19:45 |
| tristanC | Shrews: understood. I suggested a new zuul/zk lib project to also reduce code duplication between zuul and nodepool. | 19:47 |
| Shrews | tristanC: that can (and I think should) be considered independently of the zk-auth change, IMO | 19:48 |
| corvus | there's very little overlap between the two, and there will be even less over time as more of the zk action is in zuul. i'm not opposed but i'm not sure it's worth the effort. | 19:49 |
| corvus | (and, tbh, i'd suggest if we're going to do that, do it after zuul v5) | 19:49 |
| Shrews | the zk.py files are different enough in some of the things they do, it's going to be more work than you think | 19:50 |
| tristanC | corvus: well, it's not very little: https://opendev.org/zuul/zuul/src/branch/master/zuul/zk.py#L466-L736 | 19:50 |
| tristanC | Shrews: the difference is actually what worries me | 19:51 |
| corvus | tristanC: that comment is a lie | 19:51 |
| corvus | nodepool doesn't have hold requests | 19:51 |
| corvus | https://opendev.org/zuul/zuul/src/branch/master/zuul/zk.py#L466-L540 is closer to the functional overlap | 19:52 |
| tristanC | corvus: that's fair, and i'm the one to blame as I added the comment :) | 19:52 |
| corvus | tristanC: well, it was true when you wrote it, but i guess we forgot to add an "End copy of..." :) | 19:53 |
| tristanC | anyway, i'm also happy to not do the code extraction. | 19:54 |
| corvus | tristanC: back to the other thing, yeah, i think maybe a small abstraction layer for zk auth so we can be forward compatible with the gssapi change if it lands would be good. so maybe we can implement something that accepts a "principal" now and encodes it as kazoo currently needs, and can encode it differently later | 19:54 |
| corvus | tristanC: yeah, i think if we go ahead and accept "user/password/service/principal/mechanism" as inputs as appropriate, we can support current and future kazoo | 19:56 |
| Shrews | tristanC: looking at update_zk_auth.py, it supports a configurable chroot, so maybe all we need is a note to run it with "chroot=/zuul" ? | 19:57 |
| tristanC | corvus: i'm not entirely sure how current kazoo works with kerberos, it seems like it tries to import the kerberos module but i don't see principal setting beside an hardcoded self.sasl_server_principal = "zk-sasl-md5" | 19:59 |
| tristanC | Shrews: yes, i'll do that when moving the script to zuul | 19:59 |
| corvus | tristanC: i think that's the server principal, or the hostname of the server, and i suspect it's just ignored in most cases. that should be different than the client principal, which is == username for our purposes (and is the thing that should be in the acl). | 20:02 |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: Implement zookeeper-auth https://review.opendev.org/619155 | 20:02 |
| tristanC | corvus: isn't the username the `service` in gssapi? | 20:05 |
| tristanC | i'm not sure we can make such assumption, and without an integration test it's hard to tell if that would work. | 20:07 |
| corvus | tristanC: this is relevant https://github.com/thobbs/pure-sasl/blob/master/puresasl/client.py#L73 | 20:07 |
| corvus | tristanC: so it seems that for zk, host is not relevant for sasl-digest (ie, there's no third-party gssapi server, it's zk itself that handles the sasl requests) | 20:09 |
| corvus | tristanC: based on that patch, it does look like only digest-md5 is supported by the current kazoo code? | 20:14 |
| corvus | tristanC: specifically https://github.com/python-zk/kazoo/commit/cd49b3fa01136848c5e6bfafb4c241b9704f249d#diff-7c89c6cfc6a591cef0ed3be6bbfb375eL703 ? | 20:14 |
| corvus | tristanC: if that's the case, then i agree, there's not much point to our supporting krb now, but we can plan our config syntax to be forward-compatible with the kazoo gssapi change, so if/when it lands we can support both | 20:16 |
| tristanC | corvus: i find zk auth quite confusing. it seems like the sasl scheme used in ci does work (and it fails when auth is missing as we noticed yesterday). | 20:23 |
| corvus | well, sasl is confusing | 20:23 |
| tristanC | i think we should assume zuul operator are also zookeeper operator, and thus we should provide an easy to follow documentation to setup the zk auth. | 20:24 |
| corvus | no objection there, i think that would be the typical case. we just shouldn't assume that, so that enterprises with externally managed zk can still be used | 20:25 |
| tristanC | in that situation, how about we support this initial schemas (username, password), and when gssapi lands (or when enterprise user reports auth compat issue), then we support an optional scheme that enables setting extra parameter (for example if scheme == gssapi, then uses (service, principal) instead of (username, password) ) | 20:29 |
| tristanC | and when scheme is not defined, we default to sasl-digest which only requires an (username, password) product | 20:30 |
| corvus | tristanC: sure, but let's just make the syntax forward compatible. like, use a dictionary so we can have 'username' or 'principal' as keys | 20:33 |
| tristanC | corvus: the way zk_auth is designed is that the ZkAuth is opaque for the rest of nodepool code, only the read method can convert a nodepool.yaml dict into a ZkAuth, then only the `acl` and `kazoo_args` accepts the ZkAuth type. thus it should be relatively safe to extend it for new scheme | 20:37 |
| *** erbarr has quit IRC | 21:11 | |
| *** Shrews has quit IRC | 21:11 | |
| *** portdirect has quit IRC | 21:13 | |
| *** ChanServ has quit IRC | 21:13 | |
| *** adam_g has quit IRC | 21:13 | |
| *** clayg has quit IRC | 21:13 | |
| *** johnsom has quit IRC | 21:13 | |
| *** ironfoot has quit IRC | 21:13 | |
| *** aspiers has quit IRC | 21:13 | |
| *** jkt has quit IRC | 21:13 | |
| *** corvus has quit IRC | 21:13 | |
| *** mugsie has quit IRC | 21:13 | |
| *** klindgren has quit IRC | 21:13 | |
| *** donnyd has quit IRC | 21:13 | |
| *** kklimonda has quit IRC | 21:13 | |
| *** maxamillion has quit IRC | 21:13 | |
| *** logan- has quit IRC | 21:13 | |
| *** stevthedev has quit IRC | 21:13 | |
| *** evgenyl has quit IRC | 21:13 | |
| *** dustinc has quit IRC | 21:13 | |
| *** samccann has quit IRC | 21:13 | |
| *** pots has quit IRC | 21:13 | |
| *** mgoddard has quit IRC | 21:13 | |
| *** SpamapS has quit IRC | 21:13 | |
| *** arxcruz|rover has quit IRC | 21:13 | |
| *** jpena|off has quit IRC | 21:13 | |
| *** adamw has quit IRC | 21:13 | |
| *** zbr|pto has quit IRC | 21:13 | |
| *** gmann has quit IRC | 21:13 | |
| *** bstinson has quit IRC | 21:13 | |
| *** tristanC has quit IRC | 21:13 | |
| *** smcginnis has quit IRC | 21:13 | |
| *** iamweswilson has quit IRC | 21:13 | |
| *** persia has quit IRC | 21:13 | |
| *** lseki has quit IRC | 21:13 | |
| *** yolanda has quit IRC | 21:13 | |
| *** nhicher has quit IRC | 21:13 | |
| *** fdegir has quit IRC | 21:13 | |
| *** jhesketh has quit IRC | 21:13 | |
| *** yoctozepto has quit IRC | 21:13 | |
| *** fbo has quit IRC | 21:13 | |
| *** dmsimard|off has quit IRC | 21:13 | |
| *** ianw has quit IRC | 21:13 | |
| *** tobberydberg has quit IRC | 21:13 | |
| *** EmilienM has quit IRC | 21:13 | |
| *** dtroyer has quit IRC | 21:13 | |
| *** irclogbot_3 has quit IRC | 21:13 | |
| *** reiterative has quit IRC | 21:13 | |
| *** dmellado has quit IRC | 21:13 | |
| *** evrardjp has quit IRC | 21:13 | |
| *** swest has quit IRC | 21:13 | |
| *** webknjaz has quit IRC | 21:13 | |
| *** dcastellani has quit IRC | 21:13 | |
| *** jbryce has quit IRC | 21:13 | |
| *** mnasiadka has quit IRC | 21:13 | |
| *** fungi has quit IRC | 21:13 | |
| *** cloudnull has quit IRC | 21:13 | |
| *** Defolos has quit IRC | 21:13 | |
| *** flaper87 has quit IRC | 21:13 | |
| *** toabctl has quit IRC | 21:13 | |
| *** mhu has quit IRC | 21:13 | |
| *** tobiash has quit IRC | 21:13 | |
| *** johanssone has quit IRC | 21:13 | |
| *** timburke has quit IRC | 21:13 | |
| *** clarkb has quit IRC | 21:13 | |
| *** ianychoi has quit IRC | 21:13 | |
| *** aluria has quit IRC | 21:13 | |
| *** guilhermesp has quit IRC | 21:13 | |
| *** wxy-xiyuan has quit IRC | 21:13 | |
| *** tdasilva has quit IRC | 21:13 | |
| *** gouthamr has quit IRC | 21:13 | |
| *** frickler has quit IRC | 21:13 | |
| *** Diabelko has quit IRC | 21:13 | |
| *** mordred has quit IRC | 21:13 | |
| *** ChrisShort has quit IRC | 21:13 | |
| *** andreaf has quit IRC | 21:13 | |
| *** mattw4 has quit IRC | 21:13 | |
| *** sreejithp has quit IRC | 21:13 | |
| *** jlk has quit IRC | 21:13 | |
| *** tosky has quit IRC | 21:13 | |
| *** sshnaidm|afk has quit IRC | 21:13 | |
| *** decimuscorvinus has quit IRC | 21:13 | |
| *** pabelanger has quit IRC | 21:13 | |
| *** etp has quit IRC | 21:13 | |
| *** raukadah has quit IRC | 21:13 | |
| *** tflink has quit IRC | 21:13 | |
| *** sugaar has quit IRC | 21:13 | |
| *** smyers has quit IRC | 21:13 | |
| *** amotoki has quit IRC | 21:13 | |
| *** openstackgerrit has quit IRC | 21:13 | |
| *** Miouge has quit IRC | 21:13 | |
| *** marvs has quit IRC | 21:13 | |
| *** lennyb has quit IRC | 21:13 | |
| *** shanemcd has quit IRC | 21:13 | |
| *** mmedvede has quit IRC | 21:13 | |
| *** gothicmindfood has quit IRC | 21:13 | |
| *** masterpe has quit IRC | 21:13 | |
| *** jtanner has quit IRC | 21:13 | |
| *** mnaser has quit IRC | 21:13 | |
| *** tributarian has quit IRC | 21:13 | |
| *** gundalow has quit IRC | 21:13 | |
| *** ttx has quit IRC | 21:13 | |
| *** kgz has quit IRC | 21:13 | |
| *** erbarr has joined #zuul | 21:13 | |
| *** Defolos has joined #zuul | 21:13 | |
| *** dtroyer has joined #zuul | 21:13 | |
| *** jlk has joined #zuul | 21:13 | |
| *** evrardjp has joined #zuul | 21:13 | |
| *** mattw4 has joined #zuul | 21:13 | |
| *** sreejithp has joined #zuul | 21:13 | |
| *** irclogbot_3 has joined #zuul | 21:13 | |
| *** amotoki has joined #zuul | 21:13 | |
| *** yolanda has joined #zuul | 21:13 | |
| *** tflink has joined #zuul | 21:13 | |
| *** tosky has joined #zuul | 21:13 | |
| *** sshnaidm|afk has joined #zuul | 21:13 | |
| *** decimuscorvinus has joined #zuul | 21:13 | |
| *** swest has joined #zuul | 21:13 | |
| *** flaper87 has joined #zuul | 21:13 | |
| *** pabelanger has joined #zuul | 21:13 | |
| *** portdirect has joined #zuul | 21:13 | |
| *** Shrews has joined #zuul | 21:13 | |
| *** sugaar has joined #zuul | 21:13 | |
| *** marvs has joined #zuul | 21:13 | |
| *** reiterative has joined #zuul | 21:13 | |
| *** nhicher has joined #zuul | 21:13 | |
| *** toabctl has joined #zuul | 21:13 | |
| *** mgoddard has joined #zuul | 21:13 | |
| *** dmellado has joined #zuul | 21:13 | |
| *** openstackgerrit has joined #zuul | 21:13 | |
| *** Miouge has joined #zuul | 21:13 | |
| *** mhu has joined #zuul | 21:13 | |
| *** masterpe has joined #zuul | 21:13 | |
| *** tobiash has joined #zuul | 21:13 | |
| *** ChanServ has joined #zuul | 21:13 | |
| *** smyers has joined #zuul | 21:13 | |
| *** lennyb has joined #zuul | 21:13 | |
| *** etp has joined #zuul | 21:13 | |
| *** raukadah has joined #zuul | 21:13 | |
| *** andreaf has joined #zuul | 21:13 | |
| *** tdasilva has joined #zuul | 21:13 | |
| *** gouthamr has joined #zuul | 21:13 | |
| *** frickler has joined #zuul | 21:13 | |
| *** Diabelko has joined #zuul | 21:13 | |
| *** aluria has joined #zuul | 21:13 | |
| *** ttx has joined #zuul | 21:13 | |
| *** bstinson has joined #zuul | 21:13 | |
| *** orwell.freenode.net sets mode: +o ChanServ | 21:13 | |
| *** tristanC has joined #zuul | 21:13 | |
| *** smcginnis has joined #zuul | 21:13 | |
| *** iamweswilson has joined #zuul | 21:13 | |
| *** persia has joined #zuul | 21:13 | |
| *** dmsimard|off has joined #zuul | 21:13 | |
| *** ianw has joined #zuul | 21:13 | |
| *** tobberydberg has joined #zuul | 21:13 | |
| *** EmilienM has joined #zuul | 21:13 | |
| *** arxcruz|rover has joined #zuul | 21:13 | |
| *** jpena|off has joined #zuul | 21:13 | |
| *** clayg has joined #zuul | 21:13 | |
| *** johnsom has joined #zuul | 21:13 | |
| *** ironfoot has joined #zuul | 21:13 | |
| *** aspiers has joined #zuul | 21:13 | |
| *** jkt has joined #zuul | 21:13 | |
| *** corvus has joined #zuul | 21:13 | |
| *** logan- has joined #zuul | 21:13 | |
| *** stevthedev has joined #zuul | 21:13 | |
| *** evgenyl has joined #zuul | 21:13 | |
| *** dustinc has joined #zuul | 21:13 | |
| *** samccann has joined #zuul | 21:13 | |
| *** pots has joined #zuul | 21:13 | |
| *** zbr|pto has joined #zuul | 21:13 | |
| *** gmann has joined #zuul | 21:13 | |
| *** maxamillion has joined #zuul | 21:13 | |
| *** gundalow has joined #zuul | 21:13 | |
| *** kklimonda has joined #zuul | 21:13 | |
| *** tributarian has joined #zuul | 21:13 | |
| *** donnyd has joined #zuul | 21:13 | |
| *** mnaser has joined #zuul | 21:13 | |
| *** cloudnull has joined #zuul | 21:13 | |
| *** fungi has joined #zuul | 21:13 | |
| *** yoctozepto has joined #zuul | 21:13 | |
| *** fbo has joined #zuul | 21:13 | |
| *** wxy-xiyuan has joined #zuul | 21:13 | |
| *** adamw has joined #zuul | 21:13 | |
| *** mnasiadka has joined #zuul | 21:13 | |
| *** guilhermesp has joined #zuul | 21:13 | |
| *** jhesketh has joined #zuul | 21:13 | |
| *** SpamapS has joined #zuul | 21:13 | |
| *** fdegir has joined #zuul | 21:13 | |
| *** gothicmindfood has joined #zuul | 21:13 | |
| *** lseki has joined #zuul | 21:13 | |
| *** klindgren has joined #zuul | 21:13 | |
| *** jbryce has joined #zuul | 21:13 | |
| *** jtanner has joined #zuul | 21:13 | |
| *** ChrisShort has joined #zuul | 21:13 | |
| *** mmedvede has joined #zuul | 21:13 | |
| *** dcastellani has joined #zuul | 21:13 | |
| *** mordred has joined #zuul | 21:13 | |
| *** webknjaz has joined #zuul | 21:13 | |
| *** ianychoi has joined #zuul | 21:13 | |
| *** clarkb has joined #zuul | 21:13 | |
| *** timburke has joined #zuul | 21:13 | |
| *** shanemcd has joined #zuul | 21:13 | |
| *** johanssone has joined #zuul | 21:13 | |
| *** mugsie has joined #zuul | 21:13 | |
| *** adam_g has joined #zuul | 21:13 | |
| *** kgz has joined #zuul | 21:16 | |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Match tag items against containing branches https://review.opendev.org/578557 | 21:29 |
| openstackgerrit | James E. Blair proposed zuul/zuul master: Add a test for retroactive branch tag application https://review.opendev.org/711741 | 21:29 |
| corvus | tristanC: i left some comments on the zk_auth portion of the nodepool change | 21:36 |
| *** hashar has joined #zuul | 21:46 | |
| tristanC | corvus: thanks, i replied | 21:47 |
| tristanC | i don't mind using a class, though using a newtype seems like a good example of opaque data type | 21:48 |
| *** mattw4 has quit IRC | 21:52 | |
| corvus | this just looks like a class with methods (the file actually has the same structure as a C file implementing object oriented programming (eg, glib)) so since the rest of nodepool is oop, let's stick with that paradigm. :) | 21:53 |
| fungi | i assume the jit compiler optimizes both to the same underlying structure regardless | 21:55 |
| *** mattw4 has joined #zuul | 21:56 | |
| tristanC | corvus: when adding support for gssapi/service/principal it will looks odd without subclass, which i find it more cumbersome to use than pure fp with an opaque data type | 21:58 |
| clarkb | I think the issue is that without some carried state you are forced to parse and unparse the string? | 21:59 |
| corvus | tristanC: then use a subclass | 21:59 |
| clarkb | oh I see that consistency is the other concern | 21:59 |
| corvus | it's an object oriented program | 22:00 |
| corvus | let's not change that now | 22:00 |
| corvus | tristanC: all of the methods you wrote in zk_auth.py should just be methods of the class | 22:01 |
| tristanC | corvus: alright, i'll rewrite in oop | 22:02 |
| corvus | like "ZKAuth.getACL()" should return the acl | 22:02 |
| *** mattw4 has quit IRC | 22:02 | |
| *** mattw4 has joined #zuul | 22:02 | |
| tristanC | corvus: i didn't meant to change nodepool model, i just find it more efficient to use fp in such situation. | 22:06 |
| tristanC | to properly use subclass i now need to define abstract static method | 22:08 |
| corvus | tristanC: right, but please include consistency and the comfort of others when you make decisions like that. it's a big cost to other maintainers if every file in the program looks different. plus, in this particular case, you did not use a functional model. you literally just made a class without using the word "class" or self. | 22:08 |
| corvus | tristanC: you know what, i'll just do it | 22:09 |
| tristanC | corvus: the zk_auth module act like a class, but without mutable self. to make it extra safe i used the typing.NewType function, hoping that such style would not be a big deal. | 22:14 |
| tristanC | though if you think that is too awkward i'm happy to rewrite it in oop | 22:17 |
| *** mattw4 has quit IRC | 22:17 | |
| *** sreejithp has quit IRC | 22:26 | |
| openstackgerrit | James E. Blair proposed zuul/nodepool master: Implement zookeeper-auth https://review.opendev.org/619155 | 22:27 |
| *** hashar has quit IRC | 22:31 | |
| *** rlandy has quit IRC | 22:33 | |
| *** Defolos has quit IRC | 23:01 | |
| *** mattw4 has joined #zuul | 23:05 | |
| *** igordc has joined #zuul | 23:17 | |
| *** erbarr has quit IRC | 23:17 | |
| openstackgerrit | James E. Blair proposed zuul/nodepool master: Implement zookeeper-auth https://review.opendev.org/619155 | 23:32 |
| *** mattw4 has quit IRC | 23:38 | |
| *** mattw4 has joined #zuul | 23:41 | |
| *** tosky has quit IRC | 23:51 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!