| *** felixedel has joined #zuul | 00:01 | |
| openstackgerrit | Merged zuul/zuul master: Update k8s log streaming release note https://review.opendev.org/711124 | 00:03 |
|---|---|---|
| *** Defolos has quit IRC | 00:16 | |
| *** igordc has joined #zuul | 00:21 | |
| *** marvs has quit IRC | 00:39 | |
| *** igordc has quit IRC | 00:40 | |
| *** igordc has joined #zuul | 01:20 | |
| *** jamesmcarthur has joined #zuul | 01:30 | |
| *** igordc has quit IRC | 01:33 | |
| *** jamesmcarthur has quit IRC | 01:39 | |
| *** jamesmcarthur has joined #zuul | 01:40 | |
| *** jamesmcarthur has quit IRC | 01:54 | |
| *** jamesmcarthur has joined #zuul | 01:57 | |
| *** threestrands has joined #zuul | 02:06 | |
| *** jamesmcarthur has quit IRC | 02:08 | |
| *** jamesmcarthur has joined #zuul | 02:16 | |
| *** mhu has quit IRC | 02:23 | |
| *** Goneri has quit IRC | 02:41 | |
| *** jamesmcarthur has quit IRC | 03:13 | |
| *** jamesmcarthur has joined #zuul | 03:14 | |
| *** jamesmcarthur has quit IRC | 03:31 | |
| *** jamesmcarthur has joined #zuul | 03:53 | |
| *** rlandy has quit IRC | 04:03 | |
| *** sgw has quit IRC | 04:05 | |
| *** sgw has joined #zuul | 04:05 | |
| *** jamesmcarthur has quit IRC | 04:50 | |
| *** raukadah is now known as chandankumar | 05:09 | |
| *** evrardjp has quit IRC | 05:35 | |
| *** evrardjp has joined #zuul | 05:35 | |
| *** igordc has joined #zuul | 05:38 | |
| *** igordc has quit IRC | 06:11 | |
| *** dpawlik has joined #zuul | 06:33 | |
| *** threestrands has quit IRC | 06:34 | |
| *** threestrands has joined #zuul | 06:35 | |
| *** threestrands has quit IRC | 06:36 | |
| *** threestrands has joined #zuul | 06:36 | |
| *** threestrands has quit IRC | 06:37 | |
| *** threestrands has joined #zuul | 06:38 | |
| *** threestrands has quit IRC | 06:39 | |
| *** michael-beaver has joined #zuul | 06:42 | |
| *** felixedel has joined #zuul | 06:43 | |
| openstackgerrit | Andreas Jaeger proposed zuul/zuul-jobs master: ensure-tox: add prefer_python2 https://review.opendev.org/711056 | 07:21 |
| *** felixedel has quit IRC | 07:27 | |
| *** AJaeger has quit IRC | 07:32 | |
| *** AJaeger has joined #zuul | 07:35 | |
| *** AJaeger has joined #zuul | 07:36 | |
| openstackgerrit | Merged zuul/zuul-jobs master: ensure-tox: add prefer_python2 https://review.opendev.org/711056 | 07:39 |
| *** felixedel has joined #zuul | 07:51 | |
| *** zxiiro has quit IRC | 07:54 | |
| *** Defolos has joined #zuul | 07:58 | |
| *** jcapitao has joined #zuul | 08:09 | |
| *** tosky has joined #zuul | 08:32 | |
| *** jpena|off is now known as jpena | 08:48 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Make github file annotation levels configurable via zuul return https://review.opendev.org/711179 | 09:00 |
| *** mhu has joined #zuul | 09:10 | |
| *** michael-beaver has quit IRC | 09:11 | |
| *** hashar has joined #zuul | 09:12 | |
| *** felixedel has quit IRC | 09:16 | |
| *** avass has joined #zuul | 09:21 | |
| *** bhavikdbavishi has joined #zuul | 09:23 | |
| *** avass has quit IRC | 09:52 | |
| *** hashar has quit IRC | 10:46 | |
| *** felixedel has joined #zuul | 10:47 | |
| *** felixedel has quit IRC | 11:02 | |
| *** Miouge has quit IRC | 11:08 | |
| *** Miouge has joined #zuul | 11:08 | |
| *** felixedel has joined #zuul | 11:08 | |
| *** felixedel has quit IRC | 11:28 | |
| *** felixedel has joined #zuul | 11:40 | |
| *** jcapitao is now known as jcapitao_lunch | 11:41 | |
| *** avass has joined #zuul | 11:49 | |
| *** bhavikdbavishi has quit IRC | 11:50 | |
| *** openstackstatus has joined #zuul | 11:51 | |
| *** ChanServ sets mode: +v openstackstatus | 11:51 | |
| *** AJaeger_ has joined #zuul | 11:55 | |
| *** AJaeger has quit IRC | 11:56 | |
| *** AJaeger_ is now known as AJaeger | 11:57 | |
| avass | hmm, I'm trying to install zuul-web from source but I'm getting 404 | 12:11 |
| avass | I'm following this: https://zuul-ci.org/docs/zuul/howtos/zuul_install.html | 12:11 |
| tristanC | avass: what is yielding 404? | 12:26 |
| avass | the zuul-web server (?). With a message "The path '/' was not found" I'm probably missing something. | 12:27 |
| *** jpena is now known as jpena|lunch | 12:32 | |
| *** bhavikdbavishi has joined #zuul | 12:50 | |
| *** Shrews has quit IRC | 12:54 | |
| *** Shrews has joined #zuul | 12:55 | |
| *** rlandy has joined #zuul | 12:56 | |
| *** jcapitao_lunch is now known as jcapitao | 13:14 | |
| *** Goneri has joined #zuul | 13:16 | |
| avass | tristanC: looks like zuul/web/static is empty after installing zuul | 13:16 |
| avass | tristanC: and I get the same effect if i install it locally without building the web components first. | 13:21 |
| avass | according to this: https://zuul-ci.org/docs/zuul/reference/developer/javascript.html?highlight=web%20static#deploying that's supposed to be built during installation if I'm reading that right. | 13:21 |
| avass | and the Dockerfile builds it explicitly: https://review.opendev.org/gitweb?p=zuul/zuul.git;a=blob;f=Dockerfile;h=a1d4636340799e6a2c30ac6cce6fcdf1bd1d4858;hb=refs/heads/master#l29 | 13:23 |
| *** jamesmcarthur has joined #zuul | 13:23 | |
| *** jamesmcarthur has quit IRC | 13:23 | |
| *** jamesmcarthur has joined #zuul | 13:24 | |
| *** felixedel has quit IRC | 13:27 | |
| *** michael-beaver has joined #zuul | 13:31 | |
| *** bhavikdbavishi has quit IRC | 13:31 | |
| *** jamesmcarthur has quit IRC | 13:32 | |
| *** jamesmcarthur has joined #zuul | 13:33 | |
| *** jpena|lunch is now known as jpena | 13:33 | |
| *** jamesmcarthur has quit IRC | 13:38 | |
| avass | Yep that solved it. | 13:42 |
| *** felixedel has joined #zuul | 13:46 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Report aborted changes via Github checks API https://review.opendev.org/711023 | 13:50 |
| *** nhicher has quit IRC | 13:51 | |
| *** nhicher has joined #zuul | 13:51 | |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Report aborted changes via Github checks API https://review.opendev.org/711023 | 13:56 |
| mordred | avass: yes - that's is :) | 14:04 |
| mordred | avass: it _is_ supposed to be built for you if you have the javascript tools installed | 14:05 |
| *** armstrongs has joined #zuul | 14:08 | |
| *** jamesmcarthur has joined #zuul | 14:11 | |
| *** arxcruz is now known as arxcruz|rover | 14:13 | |
| *** jamesmcarthur has quit IRC | 14:18 | |
| *** sgw has quit IRC | 14:32 | |
| *** sgw has joined #zuul | 14:33 | |
| *** sgw has quit IRC | 14:39 | |
| openstackgerrit | Benedikt Löffler proposed zuul/zuul master: Fix override variables in zuul_return https://review.opendev.org/711002 | 14:40 |
| openstackgerrit | Felix Edel proposed zuul/zuul master: Allow check runs to be configured as required status in pipeline config https://review.opendev.org/711241 | 14:41 |
| *** jamesmcarthur has joined #zuul | 14:53 | |
| *** jamesmcarthur has quit IRC | 14:58 | |
| *** sgw has joined #zuul | 15:02 | |
| *** felixedel has quit IRC | 15:05 | |
| *** felixedel has joined #zuul | 15:14 | |
| *** swest has quit IRC | 15:19 | |
| *** felixedel has quit IRC | 15:20 | |
| *** chandankumar is now known as raukadah | 15:20 | |
| *** jamesmcarthur has joined #zuul | 15:28 | |
| *** jamesmcarthur has quit IRC | 15:33 | |
| *** michael-beaver has quit IRC | 15:40 | |
| *** jamesmcarthur has joined #zuul | 15:55 | |
| corvus | tristanC: are you planning on updating https://review.opendev.org/708686 or would you like me to? | 16:00 |
| *** jcapitao is now known as jcapitao_afk | 16:02 | |
| *** jamesmcarthur has quit IRC | 16:05 | |
| avass | mordred: I had the javascript tools isntalled, but it didn't work anyway :) | 16:06 |
| mordred | avass: that's ... disappointing | 16:07 |
| *** avass has quit IRC | 16:23 | |
| *** jcapitao_afk is now known as jcapitao | 16:31 | |
| *** mattw4 has joined #zuul | 16:37 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: docs: move components to reference https://review.opendev.org/708686 | 16:54 |
| *** hashar has joined #zuul | 16:55 | |
| *** Defolos has quit IRC | 16:55 | |
| *** jamesmcarthur has joined #zuul | 17:11 | |
| openstackgerrit | James E. Blair proposed zuul/zuul master: WIP: one option for scheduler test app manager https://review.opendev.org/711289 | 17:16 |
| *** openstackgerrit has quit IRC | 17:20 | |
| *** igordc has joined #zuul | 17:33 | |
| *** evrardjp has quit IRC | 17:35 | |
| *** evrardjp has joined #zuul | 17:35 | |
| *** jcapitao is now known as jcapitao_off | 17:36 | |
| *** jpena is now known as jpena|off | 17:46 | |
| corvus | tristanC, clarkb, Shrews: what's the status of zk auth? | 17:46 |
| clarkb | corvus: in general or in zuul? | 17:47 |
| corvus | in zuul | 17:47 |
| corvus | like, what do we need to do to get to "zuul supports zk auth"? | 17:47 |
| corvus | since that's step on of the scale out scheduler sequence | 17:48 |
| corvus | step one | 17:48 |
| clarkb | I know the first thing was getting support in kazoo, I believe that happened | 17:50 |
| corvus | looks like https://review.opendev.org/619155 is relevant | 17:51 |
| clarkb | https://kazoo.readthedocs.io/en/latest/api/client.html#kazoo.client.KazooClient.__init__ shows that the client takes certs/keys for authentication | 17:52 |
| corvus | that patch uses sasl | 17:52 |
| clarkb | ya via auth_data | 17:53 |
| tobiash | corvus: turned out that I was wrong about explitcly requiring check runs. It's implemented in 711289 today | 17:53 |
| tristanC | corvus: i'm pretty sure topic:zk-auth implemented zk auth when it was proposed... not sure what needs to happen with it now | 17:53 |
| clarkb | that is probably better since you can force auth on connection which I know tristanC is worried about | 17:53 |
| corvus | tobiash: that change number is wrong :) | 17:53 |
| tobiash | whoops | 17:53 |
| clarkb | tristanC: corvus that change doesn't seem to be in merge conflict. Maybe recheck? | 17:53 |
| clarkb | and go from there? | 17:54 |
| corvus | clarkb: yeah, i rechecked the nodepool change | 17:54 |
| tobiash | I meant 711241 | 17:54 |
| corvus | https://review.opendev.org/619156 is the corresponding zuul change | 17:54 |
| corvus | it's green as of feb 20 | 17:54 |
| *** openstackgerrit has joined #zuul | 17:54 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: Implement zookeeper-auth https://review.opendev.org/619155 | 17:54 |
| tristanC | corvus: unfortunately the zuul change is also un-tested | 17:55 |
| corvus | tristanC: oh... there was testing in the nodepool change; can we do the same for zuul? | 17:55 |
| corvus | tobiash did add https://review.opendev.org/657096 which is good, but we should have it in actual unit tests too | 17:56 |
| tristanC | corvus: yes sure, though we can also merge the nodepool side first, then use the same testing in zuul | 17:57 |
| corvus | tristanC: yeah, sounds like there are no blockers for the np change | 17:58 |
| corvus | (though a nodepool with zk auth but no zk auth in zuul is not useful -- maybe we want to wait until they're both ready to merge?) | 17:58 |
| *** sshnaidm is now known as sshnaidm|afk | 17:59 | |
| corvus | tobiash: https://review.opendev.org/711241 lgtm but needs a doc update | 18:00 |
| tobiash | corvus: oh yes, I think he said he'll add the docs tomorrow to that change | 18:01 |
| Shrews | the only reason i didn't merge the np change was wanting the zuul equivalent ready to go | 18:03 |
| Shrews | which i noted in my last +2 on it | 18:03 |
| corvus | Shrews: ah yep. i think i agree with that | 18:03 |
| corvus | so i think the blocker is now adding equivalent testing to zuul | 18:04 |
| *** igordc has quit IRC | 18:04 | |
| *** igordc has joined #zuul | 18:05 | |
| corvus | tristanC: are you planning on doing that? | 18:10 |
| corvus | tobiash: interesting, the github api uses the more-british spelling of cancelled (canceled is the more-american spelling and is what zuul uses) | 18:11 |
| corvus | english is neat | 18:11 |
| tobiash | corvus: interesting | 18:13 |
| clarkb | corvus: I seem to recall inconsistent application of z's and s's in places like dib where you had new zealand and australian english mixed with american english | 18:13 |
| tobiash | I thought it started in america | 18:13 |
| clarkb | dib was started by a kiwi | 18:14 |
| clarkb | though really it started wtih a team | 18:14 |
| clarkb | and so there was a mixture of english | 18:14 |
| mordred | ya - but several of them enjoyed their more-british english and advocated for it in ways like using it in code | 18:14 |
| tristanC | corvus: well i can work on that stack again, but please let's keep the feedback loop short. it has been more than a year i worked on that feature, up to a point where both zuul and nodepool implementation had +1 +2 | 18:16 |
| tobiash | I guess I mix that up by myself as well as I learned british english at school and transitioned more to american spelling at the university and at work | 18:16 |
| corvus | tristanC: agreed. i'll try to watch for changes, but if i miss an update, feel free to ping me and i'll review asap | 18:17 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: Implement zookeeper-auth https://review.opendev.org/619156 | 18:18 |
| corvus | i assume the github checks api was implemented by their london office | 18:18 |
| mordred | corvus: this is why we should implement all APIs in german | 18:20 |
| *** armstrongs has quit IRC | 18:25 | |
| tobiash | mordred: veto :) | 18:25 |
| tobiash | Luckily I can't even remember when I saw a program written in german the last time... | 18:27 |
| *** igordc has quit IRC | 18:27 | |
| mordred | tobiash: yeah ... we might have to increase the max line length ... | 18:27 |
| clarkb | java melody is written in french | 18:28 |
| tobiash | lol | 18:28 |
| *** sugaar has quit IRC | 18:29 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: Implement zookeeper-auth https://review.opendev.org/619156 | 18:31 |
| *** igordc has joined #zuul | 18:33 | |
| *** tosky has quit IRC | 18:44 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: DNM: debug zookeeper service flags https://review.opendev.org/711300 | 18:47 |
| tristanC | hmm, it seems like something change in the way zookeeper is configured, the tests are now failing hard with kazoo.exceptions.NoAuthError | 18:49 |
| *** jcapitao_off has quit IRC | 18:50 | |
| *** jamesmcarthur has quit IRC | 18:56 | |
| tristanC | seems like it is a change only affecting ubuntu, the openshift test, which is running on fedora, doesn't have the issue | 18:58 |
| clarkb | possible the ubuntu zk doesn't support sasl auth? | 19:03 |
| clarkb | we can switch to the upstream provided tarball instead if so? | 19:03 |
| corvus | but used to? | 19:03 |
| clarkb | oh if it regressed that would be weird | 19:04 |
| *** reiterative has quit IRC | 19:04 | |
| *** reiterative has joined #zuul | 19:04 | |
| tristanC | fedora provides 3.4.9-13 , and the one in ubuntu is 3.4.10-3 | 19:05 |
| corvus | i'm poking at it on my local ubuntu machine | 19:09 |
| mordred | I mean - it's nice to know there are hard failures if auth isnt' there | 19:10 |
| corvus | i have replicated locally | 19:11 |
| corvus | tristanC: /usr/bin/java -cp /etc/zookeeper/conf:/usr/share/java/jline.jar:/usr/share/java/log4j-1.2.jar:/usr/share/java/xercesImpl.jar:/usr/share/java/xmlParserAPIs.jar:/usr/share/java/netty.jar:/usr/share/java/slf4j-api.jar:/usr/share/java/slf4j-log4j12.jar:/usr/share/java/zookeeper.jar -Djava.security.auth.login.config=/etc/zookeeper/auth.conf -Dcom.sun.management.jmxremote | 19:11 |
| corvus | -Dcom.sun.management.jmxremote.local.only=true -Dzookeeper.log.dir=/var/log/zookeeper -Dzookeeper.root.logger=INFO,ROLLINGFILE org.apache.zookeeper.server.quorum.QuorumPeerMain /etc/zookeeper/conf/zoo.cfg | 19:11 |
| corvus | tristanC: that's my local ps | 19:11 |
| corvus | tristanC: do we need to run the acl script? | 19:12 |
| corvus | in the test setup | 19:12 |
| corvus | tristanC: from the log: http://paste.openstack.org/show/790310/ | 19:13 |
| corvus | hrm, it's in the test _setUp method | 19:14 |
| tristanC | corvus: iiuc, you run the test-setup.sh from 619155 and got this paste after running the acl script? | 19:15 |
| corvus | tristanC: no, i ran the test-setup.sh then the unit test. i did not run the acl script. | 19:15 |
| tristanC | `SaslServerCallbackHandler@120] - Successfully authenticated client: authenticationID=super; authorizationID=super.` sounds like the configuration is correct | 19:16 |
| *** Defolos has joined #zuul | 19:16 | |
| *** jamesmcarthur has joined #zuul | 19:22 | |
| *** dmellado has quit IRC | 19:24 | |
| *** dmellado has joined #zuul | 19:25 | |
| *** mgoddard has quit IRC | 19:27 | |
| *** mgoddard has joined #zuul | 19:28 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: DNM: investigate zookeeper service setup https://review.opendev.org/711300 | 19:28 |
| *** jamesmcarthur has quit IRC | 19:33 | |
| *** jamesmcarthur has joined #zuul | 19:47 | |
| tristanC | perhaps k8s is failing because of test-setup removal in pre ( https://review.opendev.org/#/c/619155/22..24/playbooks/nodepool-functional-k8s/pre.yaml ) | 19:52 |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: Implement zookeeper-auth https://review.opendev.org/619155 | 19:52 |
| tristanC | in which case, the issue may be a difference in the unittest operations | 19:53 |
| corvus | there has been a kazoo release since patchset 22 | 19:56 |
| corvus | and a couple of pure-sasl releases | 19:58 |
| tristanC | corvus: it seems like zk-auth is working, at least for nodepool-functional-openshift | 19:59 |
| corvus | downgrading pure-sasl and kazoo doesn't help | 19:59 |
| tristanC | i thought it was failing in nodepool-functional-k8s because of a diff with ubuntu, but i think it 's because the k8s pre stopped running test-setup role (which setup zk auth) | 20:00 |
| corvus | tristanC: do you want to try running the unit tests on centos? | 20:00 |
| tristanC | corvus: i don't think that's necessary | 20:01 |
| corvus | oh, i thought you were getting at the idea that the zk binary provided by ubuntu may be faulty | 20:01 |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: Implement zookeeper-auth https://review.opendev.org/619155 | 20:02 |
| corvus | tristanC: what do you think the problem is then? | 20:03 |
| tristanC | corvus: i was, because openshift integration worked (where zk run on fedora) on not k8s (where zk run on ubuntu). but then, lookint at all the diff between PS24 and PS22 i noticed: the test-setup role got removed ( https://review.opendev.org/#/c/619155/22..24/playbooks/nodepool-functional-k8s/pre.yaml ), which would explain the difference | 20:03 |
| corvus | tristanC: that doesn't explain the unit test failures, does it? | 20:03 |
| tristanC | no, there must be something in the 22..24 that would explains the unit test failure | 20:04 |
| corvus | tristanC: (also see the comment i just left on ps25; i've verified it's not the current problem with the unit tests on ubuntu, but we should keep it in mind) | 20:04 |
| corvus | tristanC: 22 was almost a year ago; a lot of external things could have changed | 20:05 |
| corvus | i have to get lunch now | 20:06 |
| tristanC | i think that line is the issue: https://review.opendev.org/#/c/619155/22..26/nodepool/cmd/config_validator.py@124 | 20:10 |
| tristanC | or not *the* issue, but that seems wrong | 20:11 |
| tobiash | corvus, tristanC: kazoo now needs pure-sasl to work with sasl: https://github.com/python-zk/kazoo/blob/master/requirements_sasl.txt | 20:28 |
| tristanC | tobiash: it is added yes https://review.opendev.org/#/c/619155/26/requirements.txt | 20:30 |
| tobiash | tristanC: at least the zuul change seems to miss it and the job failure indicates that it's missing: https://review.opendev.org/619156 | 20:32 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: Implement zookeeper-auth https://review.opendev.org/619156 | 20:40 |
| tristanC | tobiash: good catch. though we are looking at nodepool failures | 20:41 |
| tobiash | oh | 20:41 |
| tristanC | so, adding test-setup role back to nodepool-k8s pre run fixed the zk auth issue. | 20:41 |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: Implement zookeeper-auth https://review.opendev.org/619155 | 20:45 |
| *** jamesmcarthur has quit IRC | 20:49 | |
| tobiash | corvus: I like 711289, btw, Jan is ooo this week, so he'll answer next week on your review comments | 20:52 |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: Implement zookeeper-auth https://review.opendev.org/619155 | 20:55 |
| *** jamesmcarthur has joined #zuul | 21:12 | |
| corvus | tristanC: unit tests are still a problem, right? | 21:12 |
| corvus | yeah, looks like it | 21:12 |
| corvus | tristanC: so is the test setup script doing something extra that the unit test fixture setup should be doing? | 21:13 |
| corvus | (but the test setup script *is* running for unit tests, we just also have the extra chroot | 21:14 |
| corvus | so maybe it's the chroot that's the issue?) | 21:14 |
| tristanC | the test setup is doing the zookeeper auth configuration | 21:15 |
| tristanC | zookeeper service* | 21:15 |
| corvus | right. that's running for the unit test jobs too, but they are failing | 21:16 |
| tristanC | i think the test setup is correct, it did fixed the auth error happening in the functional-k8s job | 21:17 |
| corvus | tristanC: do you agree that the unit test jobs are failing? | 21:17 |
| tristanC | yes, and i haven't figure out why yet | 21:18 |
| corvus | ok, just wanted to make sure we were on the same page :) | 21:18 |
| corvus | i'm trying to make a standalone reproducer script | 21:18 |
| tristanC | would be nice to know if PS22 worked, then we could perhaps bisect what is the issue? | 21:20 |
| corvus | hrm, i am unable to reproduce with a simple script that creates a lock | 21:29 |
| tristanC | me neither, the nodepool-update-zk-auth works fine locally. so zookeeper service and kazoo seems to be working as expected | 21:31 |
| tristanC | is it me or all the stack trace are passing through `zk.py", line 1048, in imageBuildLock` ? | 21:32 |
| corvus | tristanC: yep, i think i'm narrowing down the problem -- it looks like the tests start a builder without auth info | 21:33 |
| corvus | tristanC: nodepool/tests/__init__.py", line 345, in setUp | 21:34 |
| tristanC | i'm on the same line indeed :) | 21:34 |
| corvus | i've confirmed with extra debugging that auth_info is none in the connect call | 21:35 |
| corvus | so maybe that isn't getting the right secure.conf file | 21:35 |
| tristanC | perhaps it's only missing a `if not securefile: securefile = self.setup_secure('zookeeper-auth.yaml')` | 21:36 |
| corvus | tristanC: yep, i think that may be it | 21:37 |
| tristanC | ok, let me propose that shortly | 21:37 |
| corvus | tristanC: yes, adding that to useBuilder fixes it | 21:37 |
| corvus | tristanC: sounds good | 21:37 |
| corvus | tristanC: i'm going to explore my question about the password now | 21:37 |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: Implement zookeeper-auth https://review.opendev.org/619155 | 21:38 |
| corvus | tristanC: my test script suggests that we don't need the password in the acl | 21:38 |
| corvus | tristanC: so just this should work: acl = (kazoo.security.make_acl("sasl", "super", all=True),) | 21:39 |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: Implement zookeeper-auth https://review.opendev.org/619155 | 21:42 |
| tristanC | corvus: alright, here is the acl change ^ | 21:42 |
| *** jamesmcarthur has quit IRC | 21:44 | |
| corvus | tristanC: i think there's one more spot -- see comment on ps29 update_zk_auth.py line 46 | 21:44 |
| *** jamesmcarthur has joined #zuul | 21:44 | |
| openstackgerrit | Merged zuul/zuul master: Make test setup_config more pure https://review.opendev.org/709084 | 21:46 |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: Implement zookeeper-auth https://review.opendev.org/619155 | 21:46 |
| corvus | tristanC: lgtm! let's see what the tests say now :) | 21:48 |
| tristanC | corvus: tobiash: I really like seing types in zuul source, but they are not checked everywhere, and they might become outdated over time. For example, in https://review.opendev.org/709084, the setup_config is missing a return type (-> str). | 21:50 |
| *** jamesmcarthur has quit IRC | 21:56 | |
| *** jamesmcarthur has joined #zuul | 21:57 | |
| tristanC | err, actually (-> configparser.ConfigParser). So I think we should either add test, or avoid the annotations | 21:57 |
| openstackgerrit | Tristan Cacqueray proposed zuul/nodepool master: Implement zookeeper-auth https://review.opendev.org/619155 | 22:00 |
| *** jamesmcarthur has quit IRC | 22:08 | |
| *** jamesmcarthur has joined #zuul | 22:10 | |
| *** tosky has joined #zuul | 22:11 | |
| *** hashar has quit IRC | 22:15 | |
| *** jamesmcarthur has quit IRC | 22:22 | |
| *** jamesmcarthur has joined #zuul | 22:32 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: Implement zookeeper-auth https://review.opendev.org/619156 | 22:33 |
| corvus | jamesmcarthur: i just went through the survey againd and sent an email with a list of suggested changes... i think we're almost there :) | 22:35 |
| *** jamesmcarthur has quit IRC | 22:37 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: Implement zookeeper-auth https://review.opendev.org/619156 | 22:44 |
| *** jamesmcarthur has joined #zuul | 22:44 | |
| *** jamesmcarthur has quit IRC | 22:47 | |
| *** jamesmcarthur has joined #zuul | 22:52 | |
| *** jamesmcarthur has quit IRC | 22:53 | |
| *** jamesmcarthur has joined #zuul | 22:54 | |
| *** jamesmcarthur has quit IRC | 23:02 | |
| *** jamesmcarthur has joined #zuul | 23:09 | |
| *** jamesmcarthur has quit IRC | 23:12 | |
| *** rlandy is now known as rlandy|bbl | 23:15 | |
| tristanC | zuul-maint: it seems like topic:zk-auth is back to a verified state. Please review it, i'll try to address comments before it gets into merge conflict again :) | 23:17 |
| *** threestrands has joined #zuul | 23:28 | |
| *** Goneri has quit IRC | 23:36 | |
| *** tosky has quit IRC | 23:40 | |
| *** Goneri has joined #zuul | 23:42 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: Implement zookeeper-auth https://review.opendev.org/619156 | 23:56 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!