Thursday, 2020-01-30

*** jamesmcarthur has quit IRC00:07
*** igordc has quit IRC00:28
jheskethcorvus, tobiash: added some comments about the multi-connection SQL discussion to 621479. Let me know if it makes sense or if I can help further :-)00:29
*** rfolco has joined #zuul00:55
*** igordc has joined #zuul00:59
*** rfolco has quit IRC01:29
*** jamesmcarthur has joined #zuul01:47
*** jamesmcarthur has quit IRC02:06
*** jamesmcarthur has joined #zuul02:11
*** jamesmcarthur has quit IRC02:18
*** jamesmcarthur has joined #zuul02:18
*** jamesmcarthur has quit IRC02:24
*** jamesmcarthur has joined #zuul02:49
*** jamesmcarthur has quit IRC02:55
*** bhavikdbavishi has joined #zuul02:56
*** bhavikdbavishi1 has joined #zuul02:59
*** bhavikdbavishi has quit IRC03:01
*** bhavikdbavishi1 is now known as bhavikdbavishi03:01
*** jamesmcarthur has joined #zuul03:50
*** armstrongs has joined #zuul03:54
*** armstrongs has quit IRC04:04
*** rlandy|bbl is now known as rlandy04:08
*** igordc has quit IRC04:08
*** jamesmcarthur has quit IRC04:25
*** jamesmcarthur has joined #zuul04:28
*** jamesmcarthur has quit IRC04:33
*** jamesmcarthur has joined #zuul04:56
*** jamesmcarthur has quit IRC05:02
*** mattw4 has quit IRC05:21
*** swest has joined #zuul05:26
*** reiterative has quit IRC05:41
*** reiterative has joined #zuul05:41
*** raukadah is now known as chkumar|rover05:57
*** jamesmcarthur has joined #zuul05:58
*** jamesmcarthur has quit IRC06:03
*** jamesmcarthur has joined #zuul06:38
*** jamesmcarthur has quit IRC06:42
*** bolg has joined #zuul06:57
*** bolg has quit IRC07:10
*** yolanda has quit IRC07:32
*** jamesmcarthur has joined #zuul07:39
*** jamesmcarthur has quit IRC07:44
*** jamesmcarthur has joined #zuul07:55
*** jamesmcarthur has quit IRC07:59
*** jpena|off is now known as jpena08:10
openstackgerritTobias Henkel proposed zuul/zuul master: Protect prime_installation_map with mutex  https://review.opendev.org/70493208:12
*** sshnaidm|afk is now known as sshnaidm08:12
*** dmsimard5 has joined #zuul08:31
*** dmsimard has quit IRC08:33
*** dmsimard5 is now known as dmsimard08:33
*** hashar has joined #zuul08:39
*** tosky has joined #zuul08:46
*** jpena is now known as jpena|off09:00
openstackgerritAndreas Jaeger proposed zuul/zuul-jobs master: fetch-output-openshift: initial role  https://review.opendev.org/68204409:11
AJaegertristanC: docs work now ^09:34
*** bhavikdbavishi has quit IRC09:42
*** bhavikdbavishi has joined #zuul09:43
*** bhavikdbavishi has quit IRC09:47
*** zxiiro has quit IRC10:03
*** pcaruana has quit IRC10:46
*** zbr has quit IRC10:52
*** zbr has joined #zuul11:23
*** zbr has quit IRC11:35
*** zbr has joined #zuul11:35
*** pcaruana has joined #zuul11:48
openstackgerritTobias Henkel proposed zuul/zuul master: Report retried builds in a build set via mqtt.  https://review.opendev.org/63272712:07
openstackgerritTobias Henkel proposed zuul/zuul master: Test that retries don't trigger fail-fast  https://review.opendev.org/70498312:07
*** rfolco has joined #zuul12:08
*** bolg has joined #zuul12:08
openstackgerritTobias Henkel proposed zuul/zuul master: Report retried builds via sql reporter.  https://review.opendev.org/63350112:09
*** pcaruana has quit IRC12:21
openstackgerritTobias Henkel proposed zuul/zuul master: Test that retries don't trigger fail-fast  https://review.opendev.org/70498312:24
openstackgerritTobias Henkel proposed zuul/zuul master: Protect prime_installation_map with mutex  https://review.opendev.org/70493212:35
*** bhavikdbavishi has joined #zuul12:41
tristanCAJaeger: thanks!12:43
*** bhavikdbavishi1 has joined #zuul12:44
*** bhavikdbavishi has quit IRC12:46
*** bhavikdbavishi1 is now known as bhavikdbavishi12:46
*** rlandy has joined #zuul12:59
hashargood morning13:24
hashartristanC: it seems you wrote the the zuul react page and I have a tiny feature request for it ;]13:25
hasharhopefully it is very simple, else I will fill an issue/story or something13:25
hasharwhen listing the playbook console and all the play / tasks, it would be very helpful to add a column for the duration of the plays / tasks13:26
hasharfor example on https://zuul.opendev.org/t/zuul/build/86d17d1791b94d1aacebd8617799f372/console13:26
hashar;)13:26
tristanChashar: sure, i can help for that. note that i wrote a guide to get started in react: https://www.softwarefactory-project.io/react-for-python-developers.html13:31
*** bhavikdbavishi has quit IRC13:31
openstackgerritJan Kubovy proposed zuul/zuul master: Add spec for scale out scheduler  https://review.opendev.org/62147913:31
* hashar looks for py2react13:32
hashartristanC: I gave it a try last night but all of that react/jsx is way over my brain capacity right now unfortunately.  Though I only wasted a couple hours on it13:32
hasharwill read that doc for sure13:32
tristanChashar: i can help you find your way in the zuul implementation. I didn't wrote the console interface, but i may be able to figure out how to add a column13:34
hasharit was just a wild idea I had yesterday, nothing blocking ;]13:37
hasharI am trying to make those tests faster, notably the AnsibleZuulTestCase ones13:38
openstackgerritAntoine Musso proposed zuul/zuul master: executor: avoid duplicate debug logs  https://review.opendev.org/70501013:45
tristanChashar: adding something like `ai.push(<p>{task.duration}</p>)` to https://opendev.org/zuul/zuul/src/branch/master/web/src/containers/build/Console.jsx#L200  should add the column you want13:46
hashartristanC: I will give it a try locally :]13:48
hasharI at least managed to run it locally. Thank you!13:48
tristanChashar: nice, let me know if you have issue with react/jsx, i'm happy to help13:54
*** harrymichal has joined #zuul14:01
*** pcaruana has joined #zuul14:03
*** zxiiro has joined #zuul14:05
*** sshnaidm is now known as sshnaidm|afk14:07
*** sshnaidm|afk is now known as sshnaidm14:32
*** pcaruana has quit IRC14:34
zbrcan we change the summary page top include a link to job history for specific project?14:41
zbrnow you have to click to job, which has history, but is history on entire tenant, which is not of much use14:42
zbrif we have direct link, we can include both job name and project name14:42
tristanCzbr: what is `the summary page` ?14:43
zbrhttps://zuul.opendev.org/t/openstack/build/a8ce4c9611d2426a89d81524717bebd814:43
tristanCzbr: oh, in the build page, then to add a new link, this would be in that file: https://opendev.org/zuul/zuul/src/branch/master/web/src/containers/build/Summary.jsx#L3314:47
tristanCzbr: adding something like `<Link ...>build history for that project</Link>` to https://opendev.org/zuul/zuul/src/branch/master/web/src/containers/build/Summary.jsx#L52 should do the trick14:49
*** swest has quit IRC14:50
*** migi has joined #zuul14:51
tristanCzuul-maint: would it be possible to get review on https://review.opendev.org/#/q/topic:zuul-crd . it would be really useful to get the operator image published so that we can start using it!14:52
*** pcaruana has joined #zuul15:02
*** bhavikdbavishi has joined #zuul15:02
*** swest has joined #zuul15:03
*** swest has quit IRC15:05
*** rishabhhpe has joined #zuul15:05
rishabhhpeHI All, Can anyone check the error i am getting here http://paste.openstack.org/show/788980/ .. while creating an instance from nodepool15:05
Shrewsrishabhhpe: that does not look like a nodepool error. you might want to ask in the neutron channel15:07
*** harrymichal has quit IRC15:07
rishabhhpeShrews: actually this one is generated by neutron while nodepool is calling to create the instance15:08
Shrewsrishabhhpe: that may be, but the error occurs within neutron operations. you'll need to start there to see what may cause it15:09
rishabhhpecan u please tell me the channel name for neutron15:10
Shrewsrishabhhpe: fwiw, nodepool doesn't call any neutron operations directly.15:10
Shrews#openstack-neutron, iirc15:10
rishabhhpeshrews: thanks15:11
*** bhavikdbavishi1 has joined #zuul15:16
*** bhavikdbavishi has quit IRC15:17
*** bhavikdbavishi1 is now known as bhavikdbavishi15:17
*** mattw4 has joined #zuul15:22
*** chkumar|rover is now known as raukadah15:24
corvustobiash, bolg: i thought of one more problem with the scale out scheduler spec overnight; left a comment on 62147915:26
*** hashar has quit IRC15:29
bolgcorvus: will check it out15:34
*** rishabhhpe has quit IRC15:46
tobiashcorvus: thanks, regarding sharding of uncached files. I think it can add quite a bit of complexity and maybe it's easier to just start without and support a max file size of 1mb?15:48
zbrtristanC: thanks for the hints on jsx. i am now writing the PR, i only need to figure out which var contains the project name15:49
openstackgerritSorin Sbarnea proposed zuul/zuul master: POC: Add build history link to summary  https://review.opendev.org/70504915:54
corvustobiash: i think if we just do it by size it should be easy -- basicaly jobs.yaml/1 is up to 1mb, and anything > is in jobs.yaml/215:56
corvustobiash: we will probably almost never use more than /1, but if someone does, that way it's not an error15:57
tobiashcorvus: ok, we should just not forget to test this :)16:03
corvushah yes16:04
openstackgerritJames E. Blair proposed zuul/zuul master: Add gcloud_service auth option for Gerrit driver  https://review.opendev.org/70490416:09
openstackgerritJames E. Blair proposed zuul/zuul master: Gerrit: poll for merged changes if no stream events  https://review.opendev.org/70505316:09
*** plaurin has joined #zuul16:16
plauringmorning irc people16:16
*** mattw4 has quit IRC16:22
*** mattw4 has joined #zuul16:31
*** rishabhhpe has joined #zuul16:33
*** hashar has joined #zuul16:37
*** michael-beaver has quit IRC16:50
plaurintristanC: Hi! I have couple of questions regarding the fetch-output-openshift module16:51
*** jamesmcarthur has joined #zuul16:54
tristanCplaurin: hello, what's your questions?16:55
clarkbTIL about .dockerignore and how it can break assumptions in opendev/python-builder16:55
corvusplaurin: (you can usually just go ahead and ask your question without preamble and people will get around to responding when they check irc)16:56
corvusclarkb: how can i learn what you learned?16:56
tristanCclarkb: yeah i'm curious too :)16:56
plaurintristanC: There is a similar task in the main.yml and rsync.yaml. "Ensure local output dirs" and  "Ensure local directory exists". The latter fails for some unexpected reason for me. But also I don't why the zuul.executor.work_root are created on the target pod?16:57
plaurin'' I don't get why [...]16:57
plaurincorvus: right, this is not slack lol16:57
clarkbcorvus: tristanC I'm trying to build a docker image for refstack that follows some of our assumptions and practices. So I've ported a simple dockerfile to it that basically just attempts to build and install python things and build the js things. Except I kept getting pip errors about not a valid git repo when trying to build an sdist for refstack in opendev/python-builder. I fired up the build container and16:58
clarkblooked in /tmp/src and sure enough there is no .git dir. Googling around I discoverd that .dockerignore is a thing and refstack set that to not copy the .git dir contents. https://opendev.org/openstack/refstack/src/branch/master/.dockerignore16:58
tristanCplaurin: https://review.opendev.org/#/c/682044/6/roles/fetch-output-openshift/tasks/main.yaml@11 is running on the executor, that's to prevent rsync issue16:58
tristanCplaurin: https://review.opendev.org/#/c/682044/6/roles/fetch-output-openshift/tasks/rsync.yaml@2 is running on the pod, that's also to prevent rsync issue (iirc it fails if source or target dir are absent)16:59
corvusclarkb: wow, that is "neat"16:59
clarkbcorvus: tristanC basically the COPY for . into /tmp/src that we use with python-builder is somewhat at odds with a .dockerignore16:59
clarkbI've just deleted the file and now I get real build errors like gcc not found (now to update bindep)16:59
corvusclarkb: yeah, i think the .dockerignore should be removed and "RUN rm" added as desired to compensate16:59
tristanCplaurin: `zuul.executor` is not meant to reference pod path, it's just data related to the executor env17:00
Shrewsoh, that reminds me of things i learned yesterday... we don't seem to use it anymore, but this outlines reasons we should avoid alpine for python images: https://pythonspeed.com/articles/alpine-docker-python/17:00
corvusShrews: ++17:00
tristanCplaurin: could you share the failure log?17:00
plaurintristanC: so, hum where do I put my log files? in {{ zuul_output_dir }}/logs ?17:00
*** rishabhhpe has quit IRC17:01
plaurintristanC: https://gist.github.com/plaurin84/06a955666cb06ddd450f0a0afe5441bc17:01
plaurinI should add more debug logging I guess17:02
tristanCplaurin: hmm, that second task looks odd indeed, it shouldn't be necessary to create zuul.executor.work_root on the pod. that seems like a typo17:02
tristanCplaurin: but yes, a job should put log files in "{{ zuul_output_dir }}/logs"17:02
plaurinthe loop could only use     - "{{ log_path }}" maybe17:03
tristanCplaurin: seems like the error got removed by the no_log, could you comment that line please: https://review.opendev.org/#/c/682044/6/roles/fetch-output-openshift/tasks/rsync.yaml@2217:04
plaurinsure17:05
plaurinThat doesn't change anything because I don't get to the "Fetch zuul-output from the pod" task17:08
plaurinexactly the same log as previously17:08
plaurinlet me check if I can get some debug output fomr the file task17:09
*** bhavikdbavishi has quit IRC17:09
tristanCplaurin: hmm, perhaps also remove the file task from the rsync.yaml file too17:09
plaurinokay I was thinking about trying that, let me test17:09
*** hashar has quit IRC17:13
plaurinokay I get a loop of missing directories in "Fetch zuul-output from the pod". I'll ensure to create the one I need before and only keep that one in the loop17:13
*** mattw4 has quit IRC17:14
plaurintristanC: I also realise this module uses {{ ansible_user_dir }} instead of the default Workdir of /tmp, so it's a bit confusing, because now it's trying to use /home/ubuntu (as I expected to be in /tmp/zuul-output)17:15
plaurintristanC: Okay it works now!! Here's my current rsync.yaml https://gist.github.com/plaurin84/d0a959b7b94866e8817171d166e62c7f17:21
tristanCplaurin: nice!17:21
plaurinI create and put files in the {{ ansible_user_dir }}/zuul-output/logs during my normal job run17:21
plaurinso then it works with jobs that directory in the loop17:22
plaurinerr '' so then it works with just that directory in the loop >> {{ zuul_output_dir }}/logs17:23
tristanCplaurin: thank you for the feedback, i'll have a look to fix https://review.opendev.org/682044 later today17:25
plaurintristanC: glad I could help, thx for your help too17:25
ShrewstristanC: was it intentional to remove the zuul-operator-build-image job from gate too? (re: https://review.opendev.org/#/c/702103/7/.zuul.yaml)17:26
Shrewsif it passes check, not seeing the reason to remove from gate17:28
tristanCShrews: no it was not, i guess that will prevent merging changes17:28
Shrewsi'm genuinely curious how zuul would deal with that  :)17:28
corvusShrews: i think it would sit there and ignore it17:29
corvushttp://zuul.opendev.org/t/zuul/project/opendev.org/zuul/zuul-operator shows no other jobs17:29
openstackgerritTristan Cacqueray proposed zuul/zuul-operator master: Update sdk to v0.13.0 and install dhall-to-json  https://review.opendev.org/70210317:29
*** evrardjp has joined #zuul17:33
*** armstrongs has joined #zuul18:02
*** igordc has joined #zuul18:09
*** armstrongs has quit IRC18:12
*** sshnaidm is now known as sshnaidm|afk18:20
*** adamw has quit IRC18:27
openstackgerritJames E. Blair proposed zuul/zuul master: Gerrit: poll for merged changes if no stream events  https://review.opendev.org/70505318:30
*** hashar has joined #zuul18:46
*** sshnaidm|afk is now known as sshnaidm|off18:53
*** mattw4 has joined #zuul18:58
hashartristanC: thank you for your React guide :]  Looks like magic now on my machine!18:59
tristanChashar: that's great to hear thanks19:00
hasharthey even found out a proper way to reload everything as soon as I saving a file modification19:03
hasharvery handy19:03
mnaseri have a very trivial change here that only needs +W: https://review.opendev.org/#/c/704756/19:10
*** hashar has quit IRC19:23
*** felixedel has joined #zuul19:33
Shrewsmnaser: seems reasonable to me. +319:39
corvusmnaser: out of curiosity, do you happen to have a cache-evection event json handy?19:43
mnasercorvus: i dont because its not logged i guess, but i can try and capture one19:50
mnasercorvus: have something up right now and ill grab you a copy when i have one19:51
mnasercorvus: `{"cacheName":"web_sessions","key":"aS2hpHsFTJilOkNB-c-urn5dJPNkBOKnaq","type":"cache-eviction","eventCreatedOn":1580413898}`19:51
corvusmnaser: thanks!  that looks very boring indeed.  :)19:53
mnaser:)19:53
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: fetch-output-openshift: initial role  https://review.opendev.org/68204420:00
*** hashar has joined #zuul20:04
tristanCplaurin: ^ seems to work as excepted, https://review.opendev.org/#/c/682049/ ran with it successfully20:12
*** bolg has quit IRC20:12
plaurin😁️20:13
hashartristanC: I got it working thank you very much ;]  Will polish up something worth a review tomorrow!20:14
*** felixedel has quit IRC20:23
openstackgerritMerged zuul/zuul master: Start ignoring certain Gerrit events  https://review.opendev.org/70475620:35
*** jamesmcarthur has quit IRC20:39
*** jamesmcarthur has joined #zuul20:49
*** jamesmcarthur has quit IRC20:53
*** jamesmcarthur has joined #zuul20:57
openstackgerritTristan Cacqueray proposed zuul/zuul-operator master: Setup Prelude and Kubernetes binding  https://review.opendev.org/70210421:00
openstackgerritTristan Cacqueray proposed zuul/zuul-operator master: Replace existing operator tasks with the new dhall function  https://review.opendev.org/70210621:00
*** jamesmcarthur has quit IRC21:02
*** jamesmcarthur has joined #zuul21:03
*** jamesmcarthur has quit IRC21:10
*** jamesmcarthur has joined #zuul21:10
openstackgerritAntoine Musso proposed zuul/zuul master: web: show duration of each task in console  https://review.opendev.org/70512021:17
*** rfolco has quit IRC21:24
*** rfolco has joined #zuul21:24
*** plaurin has quit IRC21:24
*** jamesmcarthur has quit IRC21:25
*** jamesmcarthur has joined #zuul21:27
*** jamesmcarthur has quit IRC21:29
openstackgerritTristan Cacqueray proposed zuul/zuul-operator master: Replace existing operator tasks with the new dhall function  https://review.opendev.org/70210621:32
*** jamesmcarthur has joined #zuul21:35
hashartristanC: I got my zuul-web patch done for react using momentjs for some human() duration ;]21:41
hasharI wanted to use https://github.com/codebox/moment-precise-range/ to have them formatted as 3 minutes 12 seconds 125 miliseconds but could not figure out ;)21:41
tristanChashar: it seems easier to use something like that https://review.opendev.org/#/c/704191/21:43
corvuswe can make that a util function and import it in multiple components21:44
hashartristanC: but it is not moment() friendly ! :D21:45
tristanChashar: the patch looks good, i suggested some hardcoded alignment, the console i picked randomly had multiple hosts with different name, ( build/84627509738444928a702ba51b5401ff/console )21:45
*** armstrongs has joined #zuul21:45
hasharthanks will catch up tomorrow21:46
hasharand give a try at factoring out the code to some common util function21:46
tristanCi think it would be nice to keep the moment() output, and add a tooltip overlay with the precise notation (e.g. using the `title` dom attribute)21:48
*** jamesmcarthur has quit IRC21:49
*** jamesmcarthur has joined #zuul21:51
*** sgw has quit IRC21:54
*** armstrongs has quit IRC21:55
openstackgerritTristan Cacqueray proposed zuul/zuul-operator master: Replace existing operator tasks with the new dhall function  https://review.opendev.org/70210621:56
*** jamesmcarthur has quit IRC21:57
*** jamesmcarthur has joined #zuul22:03
*** jamesmcarthur_ has joined #zuul22:05
*** jamesmcarthur has quit IRC22:08
*** jamesmcarthur_ has quit IRC22:08
*** jamesmcarthur has joined #zuul22:09
*** jamesmcarthur has quit IRC22:11
*** sgw has joined #zuul22:11
ssbarneai need some feedback re the new job history link i want to add to summary pages, see it at https://7526c4c70fcb636961b8-9585b566393241b76329bc2140bbefac.ssl.cf5.rackcdn.com/705049/1/check/zuul-build-dashboard/f94d613/npm/html/build/6012014d91f747d1830545c99ddbd60d22:34
ssbarneais after the build url (missing a space)22:34
ssbarnealink works, space is should be easy to add.22:35
ssbarneai wanted to avoid cluttering the table with an extra row22:35
corvusssbarnea: seems good.  you might say "build history for this job" or at least "build history" since it's not entirely clear what "history" means without more context.22:37
ssbarneai can also put tooltip info. i guess use of icons is not encouraged.22:38
ssbarneai was also considering implementing a feature that reports relative job duration compared with average, to measure speed up/down, but that seems quite advanced for the moment.22:39
corvusshould be possible, but for performance, probably the best way to do that would be to add it into the api result for the build endpoint.  the time database is about to change significantly, so it might be best to wait a bit.22:45
openstackgerritTristan Cacqueray proposed zuul/zuul-operator master: Replace existing operator tasks with the new dhall function  https://review.opendev.org/70210622:46
*** hashar has quit IRC22:51
*** paladox is now known as paladox|UKInEU23:00
*** zxiiro has quit IRC23:05
openstackgerritTristan Cacqueray proposed zuul/zuul-operator master: Generate TLS certificats for the gearman service  https://review.opendev.org/70271623:08
openstackgerritTristan Cacqueray proposed zuul/zuul-operator master: Handle service restart when connections are changed  https://review.opendev.org/70362423:08
openstackgerritTristan Cacqueray proposed zuul/zuul-operator master: Add tenant reconfiguration when main.yaml changed  https://review.opendev.org/70363123:08
corvustristanC: do we have a way to add packages to the standard executor image?  ie, it seems like the on-executor dependencies in zuul-jobs should be there (openstacksdk, google, boto, etc)23:43
openstackgerritJames E. Blair proposed zuul/zuul-helm master: Set ClusterIP to None for executor logs  https://review.opendev.org/70513223:45
corvusmnaser: ^ that seemed to be a bug in the helm charts (was causing streaming logs not to work because the dns name of the executor did not resolve.  that seemed to fix it)23:45
corvustristanC: oh, i guess for the *python* requirements we add them to the ansible config23:47
tristanCcorvus: the k8s task failed because of a missing openshift library on the job nodeset node23:52
openstackgerritTristan Cacqueray proposed zuul/zuul-operator master: Add OpenShift SCC and functional test  https://review.opendev.org/70275823:54
corvustristanC: sorry i was asking because of a problem of my own making, but i think i have refreshed my memory now :)23:54
tristanCcorvus: i'm not entirely sure what needs to be installed on the executor or the test instance, but i guess if we want to enable using k8s tasks on localhost, then `openshift` needs to be installed there23:58
tristanCfor the zuul-operator integration job, running `python3 -mpip install --user openshift` on the node seems enough to enable using k8s task23:59
corvustristanC: i believe openshift is installed in the zuul-executor image23:59

Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!