| openstackgerrit | Sagi Shnaidman proposed zuul/zuul-jobs master: DNM: debug vars https://review.opendev.org/702144 | 00:20 |
|---|---|---|
| *** threestrands has joined #zuul | 00:38 | |
| openstackgerrit | Sagi Shnaidman proposed zuul/zuul-jobs master: Rename vars/ directory to prevent conflicts https://review.opendev.org/702144 | 00:59 |
| *** threestrands has quit IRC | 01:43 | |
| *** sanjayu_ has joined #zuul | 02:04 | |
| *** threestrands has joined #zuul | 03:10 | |
| *** threestrands has quit IRC | 03:11 | |
| *** threestrands has joined #zuul | 03:11 | |
| *** bhavikdbavishi has joined #zuul | 03:18 | |
| *** bhavikdbavishi1 has joined #zuul | 03:33 | |
| *** bhavikdbavishi has quit IRC | 03:35 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 03:35 | |
| *** sanjayu_ has quit IRC | 04:24 | |
| *** evrardjp has quit IRC | 05:33 | |
| *** evrardjp has joined #zuul | 05:34 | |
| *** threestrands has quit IRC | 05:38 | |
| *** saneax has joined #zuul | 06:02 | |
| openstackgerrit | Ian Wienand proposed zuul/zuul-jobs master: Disable wheel mirror https://review.opendev.org/702166 | 06:24 |
| *** fdegir has quit IRC | 07:08 | |
| *** fdegir has joined #zuul | 07:09 | |
| *** avass has joined #zuul | 07:27 | |
| *** tflink has quit IRC | 08:07 | |
| *** tflink has joined #zuul | 08:08 | |
| *** hashar has joined #zuul | 08:09 | |
| *** tosky has joined #zuul | 08:22 | |
| *** armstrongs has joined #zuul | 08:26 | |
| *** jangutter has joined #zuul | 08:33 | |
| *** armstrongs has quit IRC | 08:36 | |
| *** zbr is now known as zbr|rover | 08:37 | |
| *** jpena|off is now known as jpena | 08:47 | |
| *** mhu has joined #zuul | 08:50 | |
| *** themroc has joined #zuul | 09:18 | |
| *** electrofelix has joined #zuul | 09:27 | |
| *** hashar has quit IRC | 09:36 | |
| openstackgerrit | Paul Albertella proposed zuul/zuul-jobs master: Add Bazel build and install roles https://review.opendev.org/693513 | 09:45 |
| *** pcaruana has joined #zuul | 09:49 | |
| *** bhavikdbavishi has quit IRC | 09:51 | |
| *** pcaruana has quit IRC | 09:56 | |
| openstackgerrit | Paul Albertella proposed zuul/zuul-jobs master: Add Bazel build and install roles https://review.opendev.org/693513 | 11:19 |
| *** rfolco has joined #zuul | 11:55 | |
| openstackgerrit | Paul Albertella proposed zuul/zuul-jobs master: Add Bazel build and install roles https://review.opendev.org/693513 | 11:55 |
| *** jpena is now known as jpena|lunch | 12:23 | |
| *** bhavikdbavishi has joined #zuul | 12:38 | |
| *** bhavikdbavishi1 has joined #zuul | 12:41 | |
| *** bhavikdbavishi has quit IRC | 12:43 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 12:43 | |
| *** bhavikdbavishi has quit IRC | 12:51 | |
| *** bhavikdbavishi has joined #zuul | 12:52 | |
| *** rlandy has joined #zuul | 13:00 | |
| *** Goneri has quit IRC | 13:04 | |
| *** jpena|lunch is now known as jpena | 13:22 | |
| tristanC | it seems like shutil.rmtree raise an exception when a build log file has 0444 mode, and such file prevents executor from restarting | 13:37 |
| *** bhavikdbavishi has quit IRC | 13:38 | |
| *** hashar has joined #zuul | 13:39 | |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Add optional support for circular dependencies https://review.opendev.org/685354 | 13:48 |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Add optional support for circular dependencies https://review.opendev.org/685354 | 13:50 |
| *** Goneri has joined #zuul | 13:51 | |
| *** sgw has quit IRC | 14:04 | |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Ensure correct cleanup on repo update and reset https://review.opendev.org/701531 | 14:31 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul master: executor: prevent restart exception on bad build log https://review.opendev.org/702228 | 14:34 |
| *** pcaruana has joined #zuul | 14:34 | |
| openstackgerrit | Simon Westphahl proposed zuul/zuul master: Ensure correct cleanup on repo update and reset https://review.opendev.org/701531 | 14:36 |
| *** bhavikdbavishi has joined #zuul | 14:50 | |
| *** bhavikdbavishi1 has joined #zuul | 14:53 | |
| *** bhavikdbavishi has quit IRC | 14:54 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 14:54 | |
| openstackgerrit | Paul Albertella proposed zuul/zuul-jobs master: Add Bazel build and install roles https://review.opendev.org/693513 | 15:07 |
| *** zxiiro has joined #zuul | 15:10 | |
| openstackgerrit | Benjamin Schanzel proposed zuul/zuul master: Allow Passing of Jitter Values in TimerDriver https://review.opendev.org/702237 | 15:18 |
| openstackgerrit | Paul Albertella proposed zuul/zuul-jobs master: Add Bazel build and install roles https://review.opendev.org/693513 | 15:23 |
| *** avass has quit IRC | 15:24 | |
| tobiash | zuul-maint: fyi, we just had a full scheduler wedge because of an unnoticed (and unchecked) typo in the timespec of a periodic pipeline that also prevented a successful restart | 15:30 |
| tobiash | until we have a fix for this you might want to take special care when adding/modifying periodic pipelines | 15:31 |
| tristanC | tobiash: arg, sounds painful... didn't we talked about moving the timer spec to the ppc, do you know if some work has been done for that already? | 15:36 |
| tobiash | fix is part of https://review.opendev.org/702237 (I asked Benjamin to split the fix from the new feature and add a test case tomorrow) | 15:36 |
| tobiash | tristanC: I don't remember that discussion | 15:37 |
| tobiash | tristanC: it took me a full hour to get our zuul running again | 15:37 |
| mordred | tobiash: yikes | 15:40 |
| *** rfolco is now known as rfolco|brb | 15:57 | |
| openstackgerrit | Merged zuul/zuul-jobs master: Rename vars/ directory to prevent conflicts https://review.opendev.org/702144 | 16:06 |
| *** pcaruana has quit IRC | 16:12 | |
| *** bhavikdbavishi has quit IRC | 16:18 | |
| *** bhavikdbavishi has joined #zuul | 16:19 | |
| clarkb | tobiash: we can probably have voluptious validate those too | 16:19 |
| clarkb | which would cause zuul to recognize the input as invalid confg and ignore it until it is valid I think | 16:20 |
| clarkb | Shrews: tobiash https://review.opendev.org/#/c/702062/ is an image management optimization that came out of opendev's image deletion in cloud problems last week | 16:20 |
| *** jamesmcarthur has joined #zuul | 16:20 | |
| clarkb | reviews on taht would be much appreciated as it should help us with reliabiltiy when clouds refuse to delete images due to leaked BFV instances | 16:20 |
| *** swest has quit IRC | 16:21 | |
| *** themroc has quit IRC | 16:23 | |
| *** jamesmcarthur has quit IRC | 16:34 | |
| *** jamesmcarthur has joined #zuul | 16:35 | |
| *** swest has joined #zuul | 16:36 | |
| *** bhavikdbavishi1 has joined #zuul | 16:38 | |
| *** jamesmcarthur_ has joined #zuul | 16:39 | |
| *** jamesmcarthur has quit IRC | 16:39 | |
| *** bhavikdbavishi has quit IRC | 16:40 | |
| *** bhavikdbavishi1 is now known as bhavikdbavishi | 16:40 | |
| *** rfolco|brb has quit IRC | 16:41 | |
| *** hashar has quit IRC | 16:52 | |
| *** mattw4 has joined #zuul | 17:08 | |
| *** mhu has quit IRC | 17:09 | |
| tobiash | clarkb: not sure if voluptious is best there as there are also range restrictions there | 17:10 |
| Shrews | clarkb: initial review looks ok. we probably can get rid of that hostname check now but doesn't hurt to leave it. i *do* think there should be some sort of test involved here though | 17:11 |
| clarkb | Shrews: specific to the all deleting case? I believe we already cover the cleanup case in general | 17:11 |
| Shrews | clarkb: yes | 17:12 |
| *** pcaruana has joined #zuul | 17:13 | |
| *** bhavikdbavishi has quit IRC | 17:13 | |
| *** yolanda has quit IRC | 17:15 | |
| clarkb | looks like we test image deletion via test_commands.test_image_delete and test_commands_test_dib_image_delete | 17:15 |
| clarkb | so ya everything but the all deleting state case should be covered | 17:16 |
| Shrews | yeah, which is the new thing | 17:16 |
| clarkb | yup I'm just confirming my assumptions there | 17:17 |
| Shrews | clarkb: i mean, it looks like it *should* work with no ill side effects, but it would be nice to know for sure | 17:17 |
| Shrews | i never like assuming anything with nodepool these days as complex as it has gotten :) | 17:18 |
| Shrews | has become, is probably more betterer grammar | 17:18 |
| fungi | s/nodepool/computers/ | 17:18 |
| Shrews | s/nodepool/life/ | 17:18 |
| *** rfolco|brb has joined #zuul | 17:20 | |
| fungi | happiness is mandatory | 17:21 |
| fungi | questioning the benevolence of friend computer is an act of treason | 17:21 |
| Shrews | tristanC: corvus: does the new user/admin separation in the docs-reorg change make better sense? https://12fa06736adb2174b060-99e30c61631357d52e091f75fecb0b32.ssl.cf1.rackcdn.com/701608/7/check/zuul-tox-docs/4084360/docs/ | 17:21 |
| *** sgw has joined #zuul | 17:26 | |
| *** electrofelix has quit IRC | 17:27 | |
| *** evrardjp has quit IRC | 17:33 | |
| *** evrardjp has joined #zuul | 17:34 | |
| *** jamesmcarthur_ has quit IRC | 17:38 | |
| tristanC | Shrews: well I still prefer the unified structure, but that looks great too. Perhaps it needs an introduction paragraph to explains what are the sections about, e.g. https://docs.djangoproject.com/en/3.0/#how-the-documentation-is-organized | 17:46 |
| Shrews | tristanC: i prefer the unified too, tbh | 17:47 |
| Shrews | i don't know how to satisfy all of the things, though | 17:48 |
| tristanC | well i do get comparaison to django is not fair since zuul have operators and users with very different need. but until there is enough content to make the tutorial/how-to overwhelming, the unified structure looks better to me | 17:50 |
| Shrews | that django doc format is very "busy" IMO | 17:50 |
| fungi | to me it's mostly about first impressions. the first time someone considering interacting with a running zuul visits the documentation i don't want them to be overwhelmed by a lot of administrative/operational documentation that they don't realize they don't need to read through | 17:52 |
| fungi | and clearly separating user-oriented documentation hopefully helps avoid them being distracted by all the rest | 17:53 |
| fungi | during those first interactions they're going to be unfamiliar with much of the terminology, even, to be able to make the distinction between things they need to install and already running things they merely need to interface with | 17:54 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: Authorization rules: support YAML nested dictionaries https://review.opendev.org/684790 | 17:58 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: JWT drivers: Deprecate RS256withJWKS, introduce OpenIDConnect https://review.opendev.org/701972 | 17:58 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: OIDCAuthenticator: add capabilities, scope option https://review.opendev.org/702275 | 17:58 |
| Shrews | fungi: so, does that mean you like the presentation in the above link? | 17:58 |
| fungi | it's like the difference between instructions for an ikea bookshelf (the person assembling it is likely also the person who will be using it) and instructions for a power drill (a good one will have a parts breakdown and assembly diagram, but that shouldn't be what you start the manual with) | 17:58 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: admin REST API: zuul-web integration https://review.opendev.org/643536 | 17:58 |
| fungi | Shrews: still looking | 17:58 |
| openstackgerrit | Matthieu Huin proposed zuul/zuul master: admin REST API: zuul-web integration https://review.opendev.org/643536 | 17:59 |
| *** mhu has joined #zuul | 17:59 | |
| fungi | but yes, at first blush i think that should work | 17:59 |
| Shrews | *nod* | 18:01 |
| corvus | Shrews: that toc lgtm. | 18:05 |
| *** jpena is now known as jpena|off | 18:06 | |
| Shrews | awesome. that's at least 4 of us that find it acceptable | 18:07 |
| Shrews | 5 if you count gerrit | 18:07 |
| fungi | what does gerrit know? | 18:08 |
| Shrews | um, only _everything_, duh | 18:08 |
| fungi | oh, right, that | 18:08 |
| openstackgerrit | Merged zuul/nodepool master: Always identify static nodes by node tuple https://review.opendev.org/701969 | 18:19 |
| *** armstrongs has joined #zuul | 18:42 | |
| clarkb | Shrews: I think the existing build and upload cleanup tests are buggy | 18:51 |
| clarkb | the waits for image deletion returns None when there is still data in the zk db | 18:52 |
| clarkb | at least according to the printZK helper method | 18:52 |
| Shrews | clarkb: waitForImageDeletion waits for image upload deletion, not zk | 18:53 |
| Shrews | there may not be a wait method for the zk record. maybe we need one | 18:54 |
| clarkb | oh I wonder if my induced failure there makes it think the image is deleted | 18:54 |
| Shrews | clarkb: oh, waitForImageDeletion checks the most recent upload zk records | 18:56 |
| Shrews | clarkb: are you wanting to check for upload record deletion? | 18:59 |
| Shrews | or build data? | 18:59 |
| clarkb | both | 19:00 |
| clarkb | I need to check that the build data on disk is gone before the upload record is deleted | 19:00 |
| clarkb | I now understand the problem with my test is it is performing the deletion via config update taht remove an image and we don't run a cleanup thread on that image | 19:01 |
| *** jamesmcarthur has joined #zuul | 19:01 | |
| Shrews | i think maybe waitForBuildDeletion and then waitForUploadRecordDeletion might be what you need | 19:01 |
| clarkb | I think. I'm slowly working through the behavior here | 19:01 |
| Shrews | waitForBuildDeletion waits for the ondisk files to be removed, and then waits for the subsequent zk record | 19:02 |
| clarkb | waitForBuildDeletion waits for the zk build record too though right? | 19:03 |
| Shrews | yeah, that's the second wait | 19:04 |
| clarkb | well there are two records | 19:04 |
| clarkb | the upload record and the build record | 19:04 |
| *** jamesmcarthur has quit IRC | 19:05 | |
| clarkb | I want to check that the build on disk is gone, then the image upload record is gone, then the build db record is gone | 19:05 |
| *** jamesmcarthur has joined #zuul | 19:05 | |
| clarkb | anyway the current problem I have is the cleanup worker stops cleaning up my old image once it is removed from the config | 19:05 |
| clarkb | even though it should generate the list of images to cleanup from the zk db data | 19:05 |
| Shrews | so you probably need a new wait then if you need to do it in that order | 19:06 |
| clarkb | aha yup the problem is we stop trying to cleanup the image once its diskimage config goes away | 19:09 |
| clarkb | I need a different way to induce this then | 19:09 |
| clarkb | Shrews: I based this on test_builder.test_image_removal. I don't know that the two asserts at the end there are valid | 19:10 |
| clarkb | Shrews: because the build cannot go away in the scenario of removing the diskimage from the config | 19:10 |
| clarkb | working to confirm that | 19:11 |
| Shrews | i think it becomes an obsolete image in that case, which automatically causes the uploads to be deleted | 19:12 |
| clarkb | oh I see it works in that case because the cleanup thread runs once in that case rather than multiple times in my case | 19:12 |
| clarkb | Shrews: yes, the issue is if you need to run cleanup multiple times (due to image deletion failure in a cloud perhaps) | 19:13 |
| clarkb | my new test case fakes the cloud failure to set up that scenario but then the build and upload records never go away because the cleanup can't make it past the diskimage check I think | 19:13 |
| clarkb | and this is a new behavior with my change exciting | 19:16 |
| clarkb | Shrews: the issue is we check against local_builds at the beginning of _cleanupImage | 19:17 |
| clarkb | but on the second run in my scenario local_builds is empty becuase we cleaned up the local files for space saving already | 19:17 |
| clarkb | instead we want to check against the build records builder id | 19:17 |
| Shrews | yay for testing | 19:18 |
| *** mattw4 has quit IRC | 19:18 | |
| *** mattw4 has joined #zuul | 19:18 | |
| *** jamesmcarthur has quit IRC | 19:18 | |
| openstackgerrit | Clark Boylan proposed zuul/nodepool master: Delete dib images when all uploads set to deleting https://review.opendev.org/702062 | 19:30 |
| clarkb | Shrews: ^ there we go | 19:31 |
| clarkb | Shrews: https://review.opendev.org/#/c/702062/3/nodepool/builder.py line 391 is the stuff that was tripping me up | 19:31 |
| clarkb | probably warrants careful review, but is tested now :)_ | 19:31 |
| *** mattw4 has quit IRC | 19:33 | |
| *** mattw4 has joined #zuul | 19:33 | |
| *** armstrongs has quit IRC | 19:36 | |
| clarkb | Shrews: also I ended up just embedding the new assertion in the test rather than make a new method for it. I don't expect this will be needed anywhere else | 19:36 |
| *** jamesmcarthur has joined #zuul | 19:36 | |
| *** jamesmcarthur has quit IRC | 19:42 | |
| *** sshnaidm is now known as sshnaidm|bbl | 19:45 | |
| Shrews | clarkb: lgtm on initial glance. should use iterate_timeout() instead of while loop though | 19:45 |
| clarkb | Shrews: thats the same loop we use in the other waits | 19:46 |
| clarkb | but ya if we wanted to bail the test earlier than the global timeout we could do that | 19:46 |
| Shrews | clarkb: yes, but those are pre-iterate_timeout. all should be changed eventually but low priority | 19:46 |
| Shrews | just trying to not add new ones to have to change later | 19:47 |
| clarkb | I see | 19:47 |
| *** armstrongs has joined #zuul | 19:59 | |
| *** Goneri has quit IRC | 20:05 | |
| *** armstrongs has quit IRC | 20:09 | |
| *** rfolco|brb is now known as rfolco | 21:08 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul-jobs master: fetch-tox-output: introduce zuul_use_fetch_output https://review.opendev.org/681864 | 21:14 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul-jobs master: fetch-subunit-output: introduce zuul_use_fetch_output https://review.opendev.org/681882 | 21:14 |
| tristanC | mordred: corvus: i can't recall what's the next step to support kubectl connection in zuul-jobs, is zuul_use_fetch_output toggle still needed or should i drop support for job not using the *-zuul-output roles? | 21:16 |
| openstackgerrit | Clark Boylan proposed zuul/nodepool master: Delete dib images when all uploads set to deleting https://review.opendev.org/702062 | 21:22 |
| clarkb | Shrews: ^ now with iterate timeout | 21:22 |
| corvus | tristanC: i don't recall immediately, and probably won't have time today to research it, sorry | 21:24 |
| *** rfolco has quit IRC | 21:31 | |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul-jobs master: DNM: test tox-py36 on openshift node https://review.opendev.org/682049 | 21:35 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul-jobs master: fetch-subunit-output: introduce zuul_use_fetch_output https://review.opendev.org/681882 | 21:40 |
| openstackgerrit | Tristan Cacqueray proposed zuul/zuul-jobs master: DNM: test tox-py36 on openshift node https://review.opendev.org/682049 | 21:40 |
| tristanC | mordred: corvus: so keeping the new behavior optional, here is a simple stack that enable running the tox zuul-jobs with a kubectl connection: https://review.opendev.org/#/c/682049/3 | 21:43 |
| *** jamesmcarthur has joined #zuul | 21:58 | |
| *** sshnaidm|bbl is now known as sshnaidm | 22:02 | |
| openstackgerrit | Clark Boylan proposed zuul/nodepool master: Use iterate_timeout in test waits https://review.opendev.org/702303 | 22:24 |
| clarkb | Shrews: ^ that what you had in mind? | 22:24 |
| openstackgerrit | Sorin Sbarnea proposed zuul/zuul-jobs master: install-docker: allow removal of conflicting packages https://review.opendev.org/702304 | 22:29 |
| corvus | tristanC: thanks! let's ask mordred and tobiash to look at that too | 22:30 |
| *** zxiiro has quit IRC | 22:36 | |
| zbr|rover | small addition to install-docker: https://review.opendev.org/702304 | 22:58 |
| *** jamesmcarthur has quit IRC | 23:03 | |
| *** tosky has quit IRC | 23:06 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!